On Thursday 04 February 2016 14:39:16 Peter Chen wrote:
> > ---
> > Preliminary for now, I've added it to my patch stack for randconfig tests
> > and will test it overnight to see if any build-time regressions come up.
400 randconfig builds later, no obvious regressions, so please consider this
a
On 03.02.2016 23:55, Greg Kroah-Hartman wrote:
On Wed, Feb 03, 2016 at 12:51:12PM -0500, Joe Lawrence wrote:
xhci_find_next_ext_cap doesn't check for PCI hotplug removal and may use
the PCI master abort bit pattern (~0) to calculate a new PCI address
offset to read/write. The has lead to reprod
On Wed, 2016-02-03 at 22:20 -0800, Marc MERLIN wrote:
> But the main point remains that default mount options and default cp
> work at horrible speed. I'm happy to try stuff to get around that
> (nosync might be one, but having my stick write after I unmounted it,
> makes me very nervous), so I'd
On Thu, 2016-02-04 at 14:53 +0800, Peter Chen wrote:
> On Wed, Feb 03, 2016 at 11:24:57AM -0500, Alan Stern wrote:
> > On Wed, 3 Feb 2016, Oliver Neukum wrote:
> >
> > > Some devices I got show an inability to operate right after
> > > power on if they are already connected. They are beyond recove
On Thu, Feb 04, 2016 at 09:53:10AM +0100, Oliver Neukum wrote:
> On Thu, 2016-02-04 at 14:53 +0800, Peter Chen wrote:
> > On Wed, Feb 03, 2016 at 11:24:57AM -0500, Alan Stern wrote:
> > > On Wed, 3 Feb 2016, Oliver Neukum wrote:
> > >
> > > > Some devices I got show an inability to operate right a
On Thu, 2016-02-04 at 17:08 +0800, Peter Chen wrote:
> On Thu, Feb 04, 2016 at 09:53:10AM +0100, Oliver Neukum wrote:
> > On Thu, 2016-02-04 at 14:53 +0800, Peter Chen wrote:
> > > On Wed, Feb 03, 2016 at 11:24:57AM -0500, Alan Stern wrote:
> > > > On Wed, 3 Feb 2016, Oliver Neukum wrote:
> > > >
Issue a TASK_ABORT iu to the device and wait for it
to complete.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 1b901c8..e69ef2b 100644
--- a/drivers/usb/storage/u
This is my second attempt, including the comments on tags
Hans made and Alan's remarks on eh_abort_handler()
I've dropped the locking as the SCSI layer does that already.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
UAS uses a shared tag space. We reserve tag #1 for management.
That leaves us with an offset of 2.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/
If we succeed, we should report that.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index d388e78..31ff1a0 100644
--- a/drivers/usb/storage/
A reset in progress obsoletes all TMFs.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index e69ef2b..4c1d6c3 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/u
Simple evaluation of the response uis result codes
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 80 ++-
1 file changed, 65 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 843c73e.
We need to give up on this TMF to have a free tag
again.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 167 ++
1 file changed, 110 insertions(+), 57 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 5
First evaluate, then notify the consumer.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index d2d9244..d789227 100644
--- a/drivers/usb/storage/uas.c
+++ b/d
This maps a device reset to a RESET LOGICAL UNIT
and sends the TMF. Also factor out common code with abort handling.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/
If we go into the reset_resume() code path, the device
cannot report on the result of a TMF. We must forget
about the request at the host level.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/
Make sure we consider a command abort only if the device confirms
that.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index acd2034..d388e78 100644
--- a/drivers/usb/st
A reset based on usb_reset_device() will reset the whole
host, not just a bus. We should use the correct entry.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 33 +++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/ua
This just allocates the structures.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 44b096c..13e6313 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/us
Use a TMF_ABORT_TASK TMF_IU in the abort handler,
to deal with commands we need to get rid of.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index a805
"Steinar H. Gunderson" writes:
> On Thu, Feb 04, 2016 at 12:15:50AM +0200, Felipe Balbi wrote:
>>> Since I've now been bitten by this several times: Is there any sort of best
>>> practice for integrating git with MUAs? What I'm doing right now is
>>> cut-and-paste from mutt to get the to/cc/in-rep
On Thu, Feb 04, 2016 at 11:17:26AM +0100, Bjørn Mork wrote:
> Then use Mutt to reply, but include the patch inline instead of
> attaching it. I believe this is discussed in the Mutt section of
> Documentation/email-clients.txt
Thanks; if that works (even though it changes the “From” line and such
Hi Peter,
Am Montag, den 25.01.2016, 15:24 +0800 schrieb Peter Chen:
> Although most of USB devices are hot-plug's, there are still some devices
> are hard wired on the board, eg, for HSIC and SSIC interface USB devices.
> If these kinds of USB devices are multiple functions, and they can supply
>
Hi Greg,
Arnd Bergmann writes:
> The phy-am335x driver selects 'USB_COMMON', but all other drivers
> use 'depends on' for that symbol, and it depends on USB || USB_GADGET
> itself, which causes a Kconfig warning:
>
> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct
> dependen
Hi Greg,
here's the first set of fixes for v4.5-rc, sorry for the delay but
things have been hectic lately (changing company and country isn't
really effortless, I hear ;-)
cheers
The following changes since commit 36f90b0a2ddd60823fe193a85e60ff1906c2a9b3:
Linux 4.5-rc2 (2016-01-31 18:12:16
That FIFO resizing logic was added to support OMAP5
ES1.0 which had a bogus default FIFO size. I can't
remember the exact size of default FIFO, but it was
less than one bulk superspeed packet (<1024) which
would prevent USB3 from ever working on OMAP5 ES1.0.
However, OMAP5 ES1.0 support has been d
DWC3's tx-fifo-resize property has been deprecated
because of it being unnecessary to any HW other than
OMAP5 ES1.0.
Signed-off-by: Felipe Balbi
---
arch/arm/boot/dts/dra7.dtsi | 3 ---
arch/arm/boot/dts/dra74x.dtsi | 1 -
arch/arm/boot/dts/omap5.dtsi | 1 -
3 files changed, 5 deletions(-)
d
On 2/3/2016 3:40 PM, Robert Baldyga wrote:
> In context of FIFO registers we use ep->fifo_index instead of ep->index.
>
> Signed-off-by: Robert Baldyga
> ---
> drivers/usb/dwc2/gadget.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/dri
Hello Peter,
On 16-01-14 11:12:32, Peter Chen wrote:
> On Wed, Jan 13, 2016 at 6:12 PM, wrote:
> > Hello Peter,
> >
> > On 16-01-13 10:33:06, Peter Chen wrote:
> >> On Tue, Jan 12, 2016 at 06:34:47PM +0530, maitysancha...@gmail.com wrote:
> >> > Hello Peter,
> >> >
> >> > I had reported the susp
TI DA8xx MUSB driver equipped with DeviceTree support.
Tested with AM1808 board and USB2.0 (OTG) in host mode.
Signed-off-by: Petr Kulhavy
---
.../devicetree/bindings/usb/da8xx-usb.txt | 52 +++
drivers/usb/musb/da8xx.c | 166 +
include
On 2/3/2016 3:38 PM, Robert Baldyga wrote:
> According to DWC2 documentation, DPTxFSize field of DPTXFSIZn register
> is read only, which means that software cannot change FIFO size.
>
> Register description says:
> "The value of this register is the Largest Device Mode Periodic Tx Data
> FIFO Dep
On Thursday 04 February 2016 14:00:07 Petr Kulhavy wrote:
> @@ -560,6 +626,97 @@ static int da8xx_probe(struct platform_device *pdev)
> glue->dev = &pdev->dev;
> glue->clk = clk;
>
> + if (np) {
> + struct musb_hdrc_config *co
Hi,
I've some comments inline, not I've mainly focussed on the TMF
bits, and not looked so much at the changes in reset handling.
On 04-02-16 10:54, Oliver Neukum wrote:
We need to give up on this TMF to have a free tag
again.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 167
On Thu, 4 Feb 2016, Oliver Neukum wrote:
> On Thu, 2016-02-04 at 17:08 +0800, Peter Chen wrote:
> > On Thu, Feb 04, 2016 at 09:53:10AM +0100, Oliver Neukum wrote:
> > > On Thu, 2016-02-04 at 14:53 +0800, Peter Chen wrote:
> > > > On Wed, Feb 03, 2016 at 11:24:57AM -0500, Alan Stern wrote:
> > > >
On Wed, 3 Feb 2016, Marc MERLIN wrote:
> On Wed, Feb 03, 2016 at 09:05:26PM -0800, Greg Kroah-Hartman wrote:
> > > Still, you're likely on the right track, something seems to wait for
> > > each write to proceed before sending the next one.
> >
> > What are you using to copy files?
>
> midnight
Hi Arnd,
thanks for your feedback, please see my comments below.
On 04.02.2016 14:37, Arnd Bergmann wrote:
I would suggest you do the opposite and leave the id table in there
but change the first check to
if (IS_ENABLED(CONFIG_OF) && np)
So the compiler can discard that code when CONF
Fix the following compiler warning (found by the kbuild test robot):
drivers/usb/host/ehci-hcd.c:312:13: warning: 'unlink_empty_async_suspended'
declared 'static' but never defined
Commit 2a40f324541e ("USB: EHCI: fix regression during bus resume")
protected the function definition with a "#ifde
On Thu, 4 Feb 2016, Emilio López wrote:
> From: Reilly Grant
>
> The new USBDEVFS_DROP_PRIVILEGES ioctl allows a process to voluntarily
> relinquish the ability to issue other ioctls that may interfere with
> other processes and drivers that have claimed an interface on the
> device.
>
> Signed
On Thu, 4 Feb 2016, Peter Chen wrote:
> On Mon, Jan 25, 2016 at 03:24:39PM +0800, Peter Chen wrote:
> > Although most of USB devices are hot-plug's, there are still some devices
> > are hard wired on the board, eg, for HSIC and SSIC interface USB devices.
> > If these kinds of USB devices are mult
On 02/02/2016 04:24 PM, Sergei Shtylyov wrote:
From: Cristian Birsan
Commit ac33cdb166811223cc (usb: musb: Remove ifdefs for musb_host_rx in
musb_host.c part5) introduces a problem setting DMA host mode.
scripts/checkpatch.pl now enforces certain commit citing style, yours
doesn't quite
Move constants to the right of binary operators.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
Signed-off-by: Mathieu OTHACEHE
---
Move constants to the right improve readability in my opinion.
But it's a matter of taste, and nothing is specified in CodingStyle.
drivers/usb/seri
Remove unneeded variables when "0" can be returned.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/cyberjack.c | 3 +--
drivers/usb/serial/garmin_gps.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/
Bool initializations should use true and false. Bool tests don't need
comparisons.
Also, use IS_ENABLED instead of ifdef.
Generated by: scripts/coccinelle/misc/boolinit.cocci
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/iuu_phoenix.c | 4 ++--
drivers/usb/serial/mos7840.c | 4 +
This series of patches fixes all coccinelle warnings in
USB serial subsystem.
V2:
* Squash patches per type of issues reported by coccinelle
Mathieu OTHACEHE (4):
USB: serial: fix compare_const_fl.cocci warnings
USB: serial: fix returnvar.cocci warnings
USB: serial: fix boolinit.cocci warni
Remove unneeded semicolons.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/keyspan.c| 2 +-
drivers/usb/serial/kl5kusb105.c | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/dri
The XHCI controller presents two USB buses to the system - one for USB 2
and one for USB 3. When only one bus is locked there is a race condition
during hub init that results in errors like:
[ 13.183701] usb 3-3: device descriptor read/all, error -110
On a test system this error occurred on 6%
On Thu, 4 Feb 2016, Chris Bainbridge wrote:
> The XHCI controller presents two USB buses to the system - one for USB 2
> and one for USB 3. When only one bus is locked there is a race condition
> during hub init that results in errors like:
>
> [ 13.183701] usb 3-3: device descriptor read/all,
On Thu, Feb 04, 2016 at 01:58:36PM +0200, Felipe Balbi wrote:
>
> Hi Greg,
>
> here's the first set of fixes for v4.5-rc, sorry for the delay but
> things have been hectic lately (changing company and country isn't
> really effortless, I hear ;-)
>
> cheers
>
> The following changes since commi
On Thu, Feb 04, 2016 at 04:00:51PM -0500, Alan Stern wrote:
> On Thu, 4 Feb 2016, Chris Bainbridge wrote:
>
> > The XHCI controller presents two USB buses to the system - one for USB 2
> > and one for USB 3. When only one bus is locked there is a race condition
> > during hub init that results in
Hi Greg,
We have two Digi Edgeport devices. I will call them A and B. If I only have A
then ttyUSB0-7 correspond to ports 1-8 on A respectively. The same applies if I
only have B. When I have A and B, then I get something like this:
ttyUSB0 - Unit B port 3
ttyUSB1 - Unit B port 4
ttyUSB2 - Unit
On Thu, Feb 04, 2016 at 11:10:33PM +, Howard Lum (holum) wrote:
> Hi Greg,
>
> We have two Digi Edgeport devices. I will call them A and B. If I only
> have A then ttyUSB0-7 correspond to ports 1-8 on A respectively. The
> same applies if I only have B. When I have A and B, then I get
> someth
Fixes an issue found on rockchip rk3036-based SOC platforms. For some
reason, the existing msleep(25) is not enough after the force mode. The
following patch was reported to fix the issue.
This does increase the probe delay again slightly, but not up to the
level it was before the original series
On Thu, Feb 04, 2016 at 10:41:45AM -0500, Alan Stern wrote:
> On Thu, 4 Feb 2016, Oliver Neukum wrote:
>
> > On Thu, 2016-02-04 at 17:08 +0800, Peter Chen wrote:
> > > On Thu, Feb 04, 2016 at 09:53:10AM +0100, Oliver Neukum wrote:
> > > > On Thu, 2016-02-04 at 14:53 +0800, Peter Chen wrote:
> > >
On Thu, 4 Feb 2016, Chris Bainbridge wrote:
> On Thu, Feb 04, 2016 at 04:00:51PM -0500, Alan Stern wrote:
> > On Thu, 4 Feb 2016, Chris Bainbridge wrote:
> >
> > > The XHCI controller presents two USB buses to the system - one for USB 2
> > > and one for USB 3. When only one bus is locked there i
On Thu, Feb 04, 2016 at 09:49:22AM +0100, Oliver Neukum wrote:
> On Wed, 2016-02-03 at 22:20 -0800, Marc MERLIN wrote:
>
> > But the main point remains that default mount options and default cp
> > work at horrible speed. I'm happy to try stuff to get around that
> > (nosync might be one, but havi
Hi Felipe,
(I changed your email address)
Would you review this patch?
I checked that I could apply this patch to the latest Felipe's usb.git /
testing/next branch correctly.
(the commit id = 36f90b0a2ddd60823fe193a85e60ff1906c2a9b3)
P.S.
I will submit a patch for this driver (but it doesn't dep
Since Some SoCs (e.g. R-Car Gen2) don't have the CSSTS bit in the
pipectrl registers ({DCP,PIPEn}CTR) because such SoCs have peripheral
mode only. So, this driver should not check the CSSTS bit if peripheral
mode is running.
Signed-off-by: Yoshihiro Shimoda
---
drivers/usb/renesas_usbhs/pipe.c |
On Thu, Feb 04, 2016 at 11:44:50AM +0100, Philipp Zabel wrote:
> Hi Peter,
>
> Am Montag, den 25.01.2016, 15:24 +0800 schrieb Peter Chen:
> > Although most of USB devices are hot-plug's, there are still some devices
> > are hard wired on the board, eg, for HSIC and SSIC interface USB devices.
> >
58 matches
Mail list logo
