DWC3 question

Hello, I am seeing that drivers/usb/dwc3/otg.c makes calls to functions in dwc3-exynos.c However, this does not apply to gadget.c driver (drivers/usb/dwc3/usb/dwc3/gadget.c) Why is this? As a result, i am not seeing runtime-pm getting executed when the gadget is plugged out. Am i missing someth

[patch] USB: cxacru: fix an bounds check warning

This is a privileged operation so it doesn't matter much. We use "tmp" as an offset into an array. If it were invalid we could read out of bounds and trigger an oops if the memory is not mapped. Plus it makes static checkers complain. Signed-off-by: Dan Carpenter --- This changes the behavior

Re: DWC3 question

Hi, Ryan writes: > Hello, > > I am seeing that drivers/usb/dwc3/otg.c makes calls to functions in > dwc3-exynos.c there's no drivers/usb/dwc3/otg.c in mainline, so I'll assume you're using a kernel from which you got from Samsung, in which case, you need to direct your questions to them ;-) The

Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial private data

On Mon, Jan 25, 2016 at 01:01:59PM +0100, Johan Hovold wrote: > On Mon, Jan 04, 2016 at 07:49:36PM +0100, Mathieu OTHACEHE wrote: > > On nominal execution, private data allocated on port_probe and attach > > are never freed. Add port_remove and release callbacks to free them > > respectively. > >

[PATCH 14/14] USB: serial: kl5kusb105: remove unneeded semicolons

This patch fixes the following coccinelle warnings: drivers/usb/serial/kl5kusb105.c:475:2-3: Unneeded semicolon drivers/usb/serial/kl5kusb105.c:530:2-3: Unneeded semicolon drivers/usb/serial/kl5kusb105.c:549:2-3: Unneeded semicolon Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/kl5kusb1

[PATCH 13/14] USB: serial: f81232: move constants to right

This patch fixes the following coccinelle warning: drivers/usb/serial/f81232.c:193:7-20: Move constant to right. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/f81232.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f

[PATCH 09/14] USB: serial: cyberjack: remove unneeded variable

This patch fixes the following coccinelle warning: drivers/usb/serial/cyberjack.c:143:5-11: Unneeded variable: "result". Return "0" on line 155 Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/cyberjack.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/se

[PATCH 10/14] USB: serial: garmin_gps: remove unneeded variable

This patch fixes the following coccinelle warning: drivers/usb/serial/garmin_gps.c:863:5-11: Unneeded variable: "status". Return "0" on line 873 Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/garmin_gps.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/

[PATCH 08/14] USB: serial: keyspan: remove unused semicolon

This patch fixes the following coccinelle warning: drivers/usb/serial/keyspan.c:1966:49-50: Unneeded semicolon Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/keyspan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/k

[PATCH 12/14] USB: serial: ch341: move constants to right

This patch fixes the following coccinelle warning: drivers/usb/serial/ch341.c:373:2-18: Move constant to right. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ch341.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch34

[PATCH 11/14] USB: serial: mos7840: move constants to right

This patch fixes the following coccinelle warnings: drivers/usb/serial/mos7840.c:2042:4-10: Move constant to right. drivers/usb/serial/mos7840.c:2062:16-22: Move constant to right. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/mos7840.c | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[PATCH 07/14] USB: serial: ftdi_sio: move constants to right

This patch fixes the following coccinelle warnings: drivers/usb/serial/ftdi_sio.h:242:31-32: Move constant to right. drivers/usb/serial/ftdi_sio.h:243:31-32: Move constant to right. drivers/usb/serial/ftdi_sio.h:245:31-32: Move constant to right. drivers/usb/serial/ftdi_sio.h:246:30-31: Move const

[PATCH 06/14] USB: serial: garmin_gps: move constants to right

This patch fixes the following coccinelle warning: drivers/usb/serial/garmin_gps.c:1195:3-4: Move constant to right. drivers/usb/serial/garmin_gps.c:1206:6-7: Move constant to right. drivers/usb/serial/garmin_gps.c:1252:5-6: Move constant to right. drivers/usb/serial/garmin_gps.c:1257:6-7: Move co

[PATCH 03/14] USB: serial: quatech2: remove comparison to bool

This patch fixes the following coccinelle warning: drivers/usb/serial/quatech2.c:976:5-26: WARNING: Comparison to bool Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/quatech2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/quatech2.c b/drivers/us

[PATCH 05/14] USB: serial: mos7840: remove comparison to bool

This patch fixes the following coccinelle warning: drivers/usb/serial/mos7840.c:1845:5-32: WARNING: Comparison to bool drivers/usb/serial/mos7840.c:1909:5-32: WARNING: Comparison to bool Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/mos7840.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH 02/14] USB: serial: safe_serial: fix assignment of bool to non 0/1 constant

This patch fixes the following coccinelle error: drivers/usb/serial/safe_serial.c:85:12-18: ERROR: Assignment of bool to non-0/1 constant Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/safe_serial.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/s

[PATCH 04/14] USB: serial: iuu_phoenix: remove comparison of bool

This patch fixes the following coccinelle warning: drivers/usb/serial/iuu_phoenix.c:383:5-9: WARNING: Comparison of bool to 0/1 drivers/usb/serial/iuu_phoenix.c:363:5-9: WARNING: Comparison of bool to 0/1 Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/iuu_phoenix.c | 4 ++-- 1 file chan

[PATCH 01/14] USB: serial: safe_serial: fix assignment of bool to 0/1

This patch fixes the following coccinelle warnings: drivers/usb/serial/safe_serial.c:84:12-16: WARNING: Assignment of bool to 0/1 drivers/usb/serial/safe_serial.c:281:2-8: WARNING: Assignment of bool to 0/1 Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/safe_serial.c | 4 ++-- 1 file ch

[PATCH 00/14] USB: serial: Fix coccinelle warnings

This series of patches fixes all coccinelle warnings in USB serial subsystem Mathieu OTHACEHE (14): USB: serial: safe_serial: fix assignment of bool to 0/1 USB: serial: safe_serial: fix assignment of bool to non 0/1 constant USB: serial: quatech2: remove comparison to bool USB: serial: iuu