On Sun, Jan 24, 2016 at 01:12:08PM -0800, Greg Kroah-Hartman wrote:
> Something is really wrong with your email client, it is saying this is
> sent on Nov 26, the same exact time as your previous patch, yet you sent
> this in January. Which implies that this is an old patch and not an
> updated on
On Tue, Jan 19, 2016 at 01:45:31PM +0800, Li Jun wrote:
> Adds HNP polling timer when transits to host state, the OTG status
> request will be sent to peripheral after timeout, if host request flag
> is set, it will switch to peripheral state, otherwise it will repeat HNP
> polling every 1.5s and m
On Tue, Jan 19, 2016 at 01:45:36PM +0800, Li Jun wrote:
> Enable HNP polling support for chipidea gadget and allocate memory
> for host request flag when otg fsm init.
>
> Signed-off-by: Li Jun
> ---
> drivers/usb/chipidea/otg_fsm.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/d
On Tue, Jan 19, 2016 at 01:45:37PM +0800, Li Jun wrote:
> Update HNP test procedure as HNP polling is supported.
>
> Signed-off-by: Li Jun
> ---
> Documentation/usb/chipidea.txt | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/usb/chipidea.txt b/Do
We really need to favour build-in properties over platform data in
general, but especially with individual flags like "usb3-lpm-capable".
Heikki Krogerus (3):
xhci: plat: adapt to unified device properties interface
usb: dwc3: host: use build-in property instead of platform data
xhci: get r
This should allow xhci to remove handling of platform data.
Signed-off-by: Heikki Krogerus
Cc: Felipe Balbi
---
drivers/usb/dwc3/host.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index c679f63
Requesting the only property that the driver needs using the
unified device properties interface so it will be available
for all types of platforms, not just the ones using DT.
Signed-off-by: Heikki Krogerus
---
drivers/usb/host/xhci-plat.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions
No more users for it.
Signed-off-by: Heikki Krogerus
---
drivers/usb/host/xhci-plat.c | 5 +
include/linux/usb/xhci_pdriver.h | 27 ---
2 files changed, 1 insertion(+), 31 deletions(-)
delete mode 100644 include/linux/usb/xhci_pdriver.h
diff --git a/drivers/usb
The ID table becomes a bit more uniform that way. Also
sorting the IDs alphabetically.
Signed-off-by: Heikki Krogerus
---
drivers/usb/dwc3/dwc3-pci.c | 31 +++
1 file changed, 11 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dw
No more users for it.
Signed-off-by: Heikki Krogerus
---
drivers/usb/dwc3/core.c | 35 --
drivers/usb/dwc3/platform_data.h | 53
2 files changed, 88 deletions(-)
delete mode 100644 drivers/usb/dwc3/platform_data.h
diff -
Hi,
Now that we can use the build-in properties as fallback when the
primary firmware (DT or ACPI) does not provide the requested property,
it should be always safe to add them. I.e, by adding them to a device,
nothing will be overwritten.
Heikki Krogerus (3):
usb: dwc3: pci: use PCI_VDEVICE m
This should allow the core driver to drop handling of
platform data and expect the platform specific details to
always come from properties.
Signed-off-by: Heikki Krogerus
Cc: Huang Rui
CC: John Youn
---
drivers/usb/dwc3/dwc3-pci.c | 81 +++--
1 file cha
Emilio López writes:
>>> diff --git a/include/uapi/linux/usbdevice_fs.h
>>> b/include/uapi/linux/usbdevice_fs.h
>>> index 019ba1e..9abcb34 100644
>>> --- a/include/uapi/linux/usbdevice_fs.h
>>> +++ b/include/uapi/linux/usbdevice_fs.h
>>> @@ -154,6 +154,10 @@ struct usbdevfs_streams {
>>> uns
On Sun, 2016-01-24 at 13:22 -0800, Greg KH wrote:
> On Thu, Jan 21, 2016 at 03:18:48PM +0100, Oliver Neukum wrote:
> > Quting the relevant thread:
> >
> > > In fact, I suspect the locking added by the kernel 3.13 commit for
> > > read_descriptors() is invalid because read_descriptors() performs no
On Monday 25 January 2016 11:57:37 Peter Chen wrote:
> >> >
> >> > hub@3 { /* same external hub, highspeed mode */
> >> > compatible = "usb2109,0812.591",
> >> > "usb2109,0812",
> >> > "usb2109,class9
On Mon, Jan 25, 2016 at 09:50:53AM +0100, Arnd Bergmann wrote:
> On Monday 25 January 2016 11:57:37 Peter Chen wrote:
> > >> >
> > >> > hub@3 { /* same external hub, highspeed mode */
> > >> > compatible = "usb2109,0812.591",
> > >> >
On Fri, Jan 08, 2016 at 01:06:47PM +0100, Johan Hovold wrote:
> On Fri, Jan 08, 2016 at 12:34:41PM +0100, Peter Dedecker wrote:
> > Added the USB serial console device ID for IAI Corp. RCB-CV-USB
> > USB to RS485 adaptor.
> >
> > Signed-off-by: Peter Dedecker
> > ---
> > drivers/usb/serial/c
On Tue, Jan 12, 2016 at 12:05:20PM +0100, Johan Hovold wrote:
> Fix null-pointer dereference at probe should a (malicious) Treo device
> lack the expected endpoints.
>
> Specifically, the Treo port-setup hack was dereferencing the bulk-in and
> interrupt-in urbs without first making sure they had
On Tue, Jan 12, 2016 at 03:10:50PM +0100, Vladis Dronov wrote:
> The visor driver crashes in clie_5_attach() when a specially crafted USB
> device without bulk-out endpoint is detected. This fix adds a check that
> the device has proper configuration expected by the driver.
>
> Reported-by: Ralf S
On Tue, Jan 12, 2016 at 05:22:06PM +0100, Daniele Palmas wrote:
> This patch adds support for two PIDs of LE922.
>
> Signed-off-by: Daniele Palmas
Now applied, thanks.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel
On Tue, Jan 19, 2016 at 11:43:13PM -0800, Greg Kroah-Hartman wrote:
> From: Greg Kroah-Hartman
>
> Harald Linden reports that the ftdi_sio driver works properly for the
> Yaesu SCU-18 cable if the device ids are added to the driver. So let's
> add them.
>
> Reported-by: Harald Linden
> Cc: sta
On Wed, Jan 20, 2016 at 03:05:56PM +0300, Andrey Skvortsov wrote:
> $ lsusb:
> Bus 001 Device 101: ID 1e0e:9001 Qualcomm / Option
>
> $ usb-devices:
> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=101 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 2
> P: Vendor=1e0e
On Sun, 2016-01-24 at 14:48 -0800, Greg KH wrote:
> On Sun, Jan 24, 2016 at 11:05:05PM +0100, Oliver Neukum wrote:
> > On Sat, 2016-01-23 at 08:39 -0800, Greg KH wrote:
> > > Have your program install a udev rule to make it run automatically
> > > when
> > > the device is plugged in, and then just
[ Please avoid top-posting. ]
On Thu, Jan 07, 2016 at 08:52:38AM +, John Ernberg wrote:
> Hi Johan,
>
> Apologies for the late reply, I was out of office.
>
> Below is the 'lsusb -v' output for the AH3 modem.
Thanks for the info. I believe your fix is the right one, but it seems
you forgot
On 01/25/2016 12:44 PM, Johan Hovold wrote:
> [ Please avoid top-posting. ]
>
> On Thu, Jan 07, 2016 at 08:52:38AM +, John Ernberg wrote:
>> Hi Johan,
>>
>> Apologies for the late reply, I was out of office.
>>
>> Below is the 'lsusb -v' output for the AH3 modem.
> Thanks for the info. I beli
On 25.01.2016 06:16, Greg KH wrote:
On Thu, Dec 10, 2015 at 09:59:30AM +0200, Mathias Nyman wrote:
In most cases the devices with the speed set to USB_SPEED_SUPER_PLUS
are handled like regular SuperSpeed devices.
- if (udev->speed == USB_SPEED_SUPER)
+ if (udev->speed >= USB_SPEED
The commit 7d32cdef5356 ("usb: musb: fail with error when no DMA
controller set"), caused the core platform driver to correctly return an
error code when fail probing.
Unfurtante it also caused bug for a NULL pointer dereference, during
system suspend for the ux500 driver. The reason is a lacking
On Mon, Jan 04, 2016 at 07:49:36PM +0100, Mathieu OTHACEHE wrote:
> On nominal execution, private data allocated on port_probe and attach
> are never freed. Add port_remove and release callbacks to free them
> respectively.
>
> Signed-off-by: Mathieu OTHACEHE
I've applied this one for 4.5-rc2 no
From: John Ernberg
Added signoff and made corrections to the commit message after review by
Johan Hovold.
This resolves a race condition that may occur with Cinterion AH3 modem modules
if both the option and cdc_ether drivers are compiled as kernel modules.
Note:
Since I have no other AHxx mode
From: John Ernberg
In certain kernel configurations where the cdc_ether and option drivers
are compiled as modules there can occur a race condition in enumeration.
This causes the option driver to enumerate the ethernet(wwan) interface
as usb-serial interfaces.
usb-devices output for the modem:
On Mon, Jan 25, 2016 at 12:27:17PM +, John Ernberg wrote:
> From: John Ernberg
>
> In certain kernel configurations where the cdc_ether and option drivers
> are compiled as modules there can occur a race condition in enumeration.
> This causes the option driver to enumerate the ethernet(wwan)
Hi Greg
These are the last 4 patches of the USB 3.1 support series asked to be
resent because of the extra line and weird indentation of patch 6/9.
The only change in v3 is removing the empty line and comment.
full v2 series can be found here :
http://marc.info/?l=linux-usb&m=144973426021853&w=2
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 32d23e1..503d82f 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -4898,6 +4898,7 @@ int xhci_gen_setup(struct
In most cases the devices with the speed set to USB_SPEED_SUPER_PLUS
are handled like regular SuperSpeed devices.
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-mem.c | 9 ++---
drivers/usb/host/xhci-ring.c | 3 ++-
drivers/usb/host/xhci.c | 7 +--
3 files changed, 13 inser
The speed field of the input slot context should represent the speed the
device is working at.
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-mem.c | 3 +++
drivers/usb/host/xhci.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xh
If a xhci controller does not provide a protocol speed ID (PSI) table, a
default one should be used instead. Add the default values to the
SuperSpeedPlus device capability. Overwrite the default ones if a PSI table
exists. See xHCI 1.1 sectio 7.2.2.1.1 for more info
Signed-off-by: Mathias Nyman
-
On Sat, 23 Jan 2016, Michal Malý wrote:
> I briefly considered leaving the switch up to the userspace and handling the
> device in the kernel only once it's been switched. I am however uncertain how
> to advertise this to the users. Writing a tiny app that would currently
> handle
> just one d
Add 64-bit DMA operation support to the USB DWC3 driver.
First attempt to set the coherent DMA mask for 64-bit DMA.
If that failed, attempt again with 32-bit DMA.
Signed-off-by: Thang Q. Nguyen
---
Changes from v1:
- Remove WARN_ON if dma_mask is NULL
drivers/usb/dwc3/core.c | 15 ++
The xhci-hcd child node needs to inherit archdata attribute to use
dma_ops functions and attributes. This patch enables the USB DWC3
driver to pass archdata attributes to its xhci-hcd child node.
Signed-off-by: Thang Q. Nguyen
---
Changes from v1:
- None
drivers/usb/dwc3/host.c | 1 +
1
On Sat, 23 Jan 2016, Raphael Assenat wrote:
> The correct product ID for the old version of the raphnet 4nes4snes
> device was 0x0a9d, not 0x0a8d.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to major
On Mon, 25 Jan 2016, Bjørn Mork wrote:
> I don't feel much like an expert here, but I can certainly make up an
> opinion anyway :)
>
> Since 64bits kernels allow usb devio with interface numbers up to 63, I
> guess you need __u64 to avoid limiting the range? Limiting will create
> all sorts of f
The index variable of list_for_each_entry_safe is an offset from a list
pointer, and thus should not be NULL.
Generated by: scripts/coccinelle/iterators/itnull.cocci
CC: Geliang Tang
Signed-off-by: Fengguang Wu
Signed-off-by: Julia Lawall
---
tree: https://git.kernel.org/pub/scm/linux/kerne
On Mon, 25 Jan 2016, Peter Chen wrote:
> Alan, do you know which physical number is larger for
> the same port, HS or SS port? Is it spec defined or vendor defined?
> I haven't found related information at xHCI spec.
I believe it is defined by the vendor. In fact, I think vendors are
allowed to
Alan Stern writes:
> On Mon, 25 Jan 2016, Bjørn Mork wrote:
>
>> I don't feel much like an expert here, but I can certainly make up an
>> opinion anyway :)
>>
>> Since 64bits kernels allow usb devio with interface numbers up to 63, I
>> guess you need __u64 to avoid limiting the range? Limiting
On Mon, 25 Jan 2016, Bjørn Mork wrote:
> Alan Stern writes:
> > On Mon, 25 Jan 2016, Bjørn Mork wrote:
> >
> >> I don't feel much like an expert here, but I can certainly make up an
> >> opinion anyway :)
> >>
> >> Since 64bits kernels allow usb devio with interface numbers up to 63, I
> >> gues
Hi,
Heikki Krogerus writes:
> The ID table becomes a bit more uniform that way. Also
> sorting the IDs alphabetically.
>
> Signed-off-by: Heikki Krogerus
> ---
> drivers/usb/dwc3/dwc3-pci.c | 31 +++
> 1 file changed, 11 insertions(+), 20 deletions(-)
>
> diff --git
Hi,
Heikki Krogerus writes:
> This should allow the core driver to drop handling of
> platform data and expect the platform specific details to
> always come from properties.
>
> Signed-off-by: Heikki Krogerus
> Cc: Huang Rui
> CC: John Youn
> ---
> drivers/usb/dwc3/dwc3-pci.c | 81
> ++
hi,
Heikki Krogerus writes:
> No more users for it.
>
> Signed-off-by: Heikki Krogerus
I very much like this :-) Let me just understand that device
property_entry thing.
--
balbi
signature.asc
Description: PGP signature
Heikki Krogerus writes:
> This should allow xhci to remove handling of platform data.
>
> Signed-off-by: Heikki Krogerus
> Cc: Felipe Balbi
> ---
> drivers/usb/dwc3/host.c | 25 +++--
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/dwc3/host.
Now that usb_bus_list has been removed and switched to idr
rename the related mutex accordingly.
Signed-off-by: Heiner Kallweit
---
drivers/usb/core/devices.c | 6 +++---
drivers/usb/core/hcd.c | 30 +++---
drivers/usb/core/hub.c | 4 ++--
drivers/usb/mon/mon_ma
Use mutex usb_bus_idr_lock to protect idr_find.
Signed-off-by: Heiner Kallweit
---
drivers/usb/host/r8a66597-hcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c
index 1ef8873..bfa7fa3 100644
--- a/drivers/usb/host/r8a66597
USB bus numbering is based on directly dealing with bitmaps and
defines a separate list of busses.
This can be simplified and unified by using existing idr functionality.
Signed-off-by: Heiner Kallweit
---
drivers/usb/core/devices.c | 10 ++
drivers/usb/core/hcd.c | 21
Am 25.01.2016 um 06:02 schrieb Greg Kroah-Hartman:
> On Tue, Dec 22, 2015 at 09:22:09PM +0100, Heiner Kallweit wrote:
>> USB bus numbering is based on directly dealing with bitmaps and
>> defines a separate list of busses.
>> This can be simplified and unified by using existing idr functionality.
>
2016-01-25 0:30 GMT-03:00 Greg Kroah-Hartman :
> On Thu, Dec 24, 2015 at 01:03:39PM -0300, Geyslan G. Bem wrote:
>> 2015-12-13 13:59 GMT-03:00 Geyslan G. Bem :
>> >
>> > Cleanup done with the help of coccinelle, checkpatch and cppcheck tools.
>> >
>> > Geyslan G. Bem (10):
>> > usb: host: ehci-sc
On Mon, Jan 25, 2016 at 04:52:52PM -0300, Geyslan G. Bem wrote:
> 2016-01-25 0:30 GMT-03:00 Greg Kroah-Hartman :
> > On Thu, Dec 24, 2015 at 01:03:39PM -0300, Geyslan G. Bem wrote:
> >> 2015-12-13 13:59 GMT-03:00 Geyslan G. Bem :
> >> >
> >> > Cleanup done with the help of coccinelle, checkpatch an
On Thu, 21 Jan 2016 22:18:30 -0300
"Geyslan G. Bem" wrote:
> This patch does use of more emacs functionalities which deliver to the
> user indentation, commenting and white space highlighting.
So perhaps it's just me, but that's an awful lot of elisp code for readers
to wade through; many of tho
On Fri, 22 Jan 2016, Doug Anderson wrote:
> > The corresponding line in the dwc2_host_hub_info() routine simply does:
> >
> > *hub_port = urb->dev->ttport;
> >
> > Unfortunately, even after I changed the dwc_otg routine the device
> > still didn't work. My bus analyzer isn't on hand today
On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
> Ok Greg, there was three patchset versions for this file that would
> count over 40+ emails. This is v3. I didn't find any answer with ack
> for it.
> About sending, there's no problem, I'm here trying to help :-) but in
> order to not increase the nois
2016-01-25 16:56 GMT-03:00 Greg Kroah-Hartman :
> On Mon, Jan 25, 2016 at 04:52:52PM -0300, Geyslan G. Bem wrote:
>> 2016-01-25 0:30 GMT-03:00 Greg Kroah-Hartman :
>> > On Thu, Dec 24, 2015 at 01:03:39PM -0300, Geyslan G. Bem wrote:
>> >> 2015-12-13 13:59 GMT-03:00 Geyslan G. Bem :
>> >> >
>> >> >
2016-01-25 17:08 GMT-03:00 Alan Stern :
> On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>
>> Ok Greg, there was three patchset versions for this file that would
>> count over 40+ emails. This is v3. I didn't find any answer with ack
>> for it.
>> About sending, there's no problem, I'm here trying to h
On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
> 2016-01-25 17:08 GMT-03:00 Alan Stern :
> > On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
> >
> >> Ok Greg, there was three patchset versions for this file that would
> >> count over 40+ emails. This is v3. I didn't find any answer with ack
> >> for it.
>
This patch replaces the "exception" bitflag in the ehci_qh structure
with a more explicit "unlink_reason" bitmask. This is for use in the
following patch, where we will need to have a good idea of the
reason for unlinking a QH, not just "something exceptional happened".
Signed-off-by: Alan Stern
This patch improves the way ehci-hcd handles the iaa_in_progress flag.
The current code is somewhat careless in this regard:
The flag is meaningless when the root hub isn't running, most
particularly after the root hub has been suspended. But in
start_iaa_cycle(), the driv
Michael Reutman reports that an AMD/ATI EHCI host controller on one of
his computers does not stop transferring data when an active bulk QH
is unlinked from the async schedule. Apparently that host controller
fails to implement the IAA mechanism correctly when an active QH is
unlinked. This leads
Hi,
On Mon, Jan 25, 2016 at 12:05 PM, Alan Stern wrote:
> On Fri, 22 Jan 2016, Doug Anderson wrote:
>
>> > The corresponding line in the dwc2_host_hub_info() routine simply does:
>> >
>> > *hub_port = urb->dev->ttport;
>> >
>> > Unfortunately, even after I changed the dwc_otg routine the
unlink_empty_async_suspended() is marked __maybe_unused. This is
because its caller, ehci_bus_suspend(), is protected by "#ifdef
CONFIG_PM". We should use the same protection here instead of
__maybe_unused.
unlink_empty_async_suspended() gets called only when the root hub is
suspended. It's sil
On Mon, 2016-01-25 at 15:17 +0100, Jiri Kosina wrote:
> On Sat, 23 Jan 2016, Michal Malý wrote:
>
> > I briefly considered leaving the switch up to the userspace and
> handling the
> > device in the kernel only once it's been switched. I am however
> uncertain how
> > to advertise this to the us
On Mon, 25 Jan 2016, Doug Anderson wrote:
> > Okay, I checked it. Oddly enough, even though the SPLIT packet's
> > contents are now correct, the device still doesn't respond.
> >
> > Bizarrely, when I interpose a USB-1.1 hub between the RPi and the
> > compound device, it _does_ work. I guess th
Alan Stern wrote:
> the device's embedded hub ACKs the packets from the PC and not the
> packets from the RPi.
>
> What other differences could there be? Timing? Power levels?
Yes, both good candidates. Can you measure VUSB? As for timing, the
host controller will send SOF more or less regularl
Alan,
On Mon, Jan 25, 2016 at 1:04 PM, Alan Stern wrote:
> On Mon, 25 Jan 2016, Doug Anderson wrote:
>
>> > Okay, I checked it. Oddly enough, even though the SPLIT packet's
>> > contents are now correct, the device still doesn't respond.
>> >
>> > Bizarrely, when I interpose a USB-1.1 hub betwee
On Mon, 25 Jan 2016, Peter Stuge wrote:
> Alan Stern wrote:
> > the device's embedded hub ACKs the packets from the PC and not the
> > packets from the RPi.
> >
> > What other differences could there be? Timing? Power levels?
>
> Yes, both good candidates. Can you measure VUSB?
Distinctly hig
When plugging an external sound card (usb audio class 2) into USB3
ports on my ASUSTeK P9X79 motherboard, lsusb hangs and the usb device
does not work. If I plug the sound card into a USB2 port, lsusb does
not hang but the device is not detected. There are 0 new messages
printed in dmesg when the
Hi,
On Mon, Jan 25, 2016 at 1:51 PM, Alan Stern wrote:
> On Mon, 25 Jan 2016, Peter Stuge wrote:
>
>> Alan Stern wrote:
>> > the device's embedded hub ACKs the packets from the PC and not the
>> > packets from the RPi.
>> >
>> > What other differences could there be? Timing? Power levels?
>>
>>
> Doug Anderson hat am 25. Januar 2016 um 21:44
> geschrieben:
>
>
> Hi,
>
> On Mon, Jan 25, 2016 at 12:05 PM, Alan Stern
> wrote:
> > On Fri, 22 Jan 2016, Doug Anderson wrote:
> >
> >> > Can you tell me how to configure a mainline kernel to work on the
> >> > Raspberry Pi? There is no arch/arm/
2016-01-25 17:40 GMT-03:00 Alan Stern :
> On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>
>> 2016-01-25 17:08 GMT-03:00 Alan Stern :
>> > On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>> >
>> >> Ok Greg, there was three patchset versions for this file that would
>> >> count over 40+ emails. This is v3. I
2016-01-25 17:01 GMT-03:00 Jonathan Corbet :
> On Thu, 21 Jan 2016 22:18:30 -0300
> "Geyslan G. Bem" wrote:
>
>> This patch does use of more emacs functionalities which deliver to the
>> user indentation, commenting and white space highlighting.
>
> So perhaps it's just me, but that's an awful lot
This patchset is the compendium of three series and an isolated patch.
[PATCH resend 0/9] usb: host: ehci.h cleanup
[PATCH v3 00/16] usb: host: ehci-dbg: cleanup and refactoring
[PATCH] usb: ehci: remove old stub_debug_files definition
[PATCH v3 00/10] usb: host: ehci-sched: cleanup
ehci.h:
Thi
Get rid of spaces before comma.
Caught by checkpatch: "ERROR: space prohibited before that ','"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index ec61aed..
Don't use the 'do {} while (0)' wrapper in a single statement macro.
Caught by checkpatch: "WARNING: Single statement macros should not
use a do {} while (0) loop"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
Get rid of space before open square bracket.
Caught by checkpatch: "ERROR: space prohibited before open square
bracket '['"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/host/ehc
Get rid of space between function name and open parenthesis.
Caught by checkpatch: "WARNING: space prohibited between function name
and open parenthesis '('"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
Put space after comma.
This patch also changes QH_NEXT macro for better reading.
Caught by checkpatch: "ERROR: space required after that ','"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci
This patch fixes coding style issues reported by checkpatch concerning
to conditional blocks without braces.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/e
The pointer operator must be sticked to name.
Caught by checkpatch:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index cccbe
This patch fixes coding style issues reported by checkpatch.
Coding style demands usage of C89-style comments and a specific format
when it's multiline.
This also removes the Free Software Foundation address because FSF can
change it again.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/eh
This patch converts macros into inline functions since the usage of
second is encouraged by Coding Style instead of the first.
Macros converted to functions:
- dbg_status
- dbg_cmd
- dbg_port
- speed_char
The size after changes remains the same.
Before:
text data bss dec hex filename
369
This patch puts the closing parenthesis at the statement end removing
unnecessary "new line".
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
i
This patch fixes coding style issues reported by checkpatch. The vast
majority of changes in this patch are removing spaces before opening
parenthesis, but in some cases, a few additional changes are made to fix
other coding style issues.
These additional changes are:
- Spaces around >> on line
This patch fixes a coding style issue reported by checkpatch concerning
to usage of sizeof operand as a variable instead the type.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drive
Prefer to use __aligned(size) macro instead of
__attribute__((aligned(size))).
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index 6
Removes trailing semicolon from macros.
Caught by checkpatch:
"WARNING: macros should not use a trailing semicolon"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
This patch fixes coding style issues reported by checkpatch concerning
to switch case statements. There are few additional changes made to fix
other coding styles issues.
These additional changes are:
- The compound statement "({...})" on line 474 is pulled out from
snprintf parameters.
- O
This patch fixes coding style issues reported by checkpatch concerning
to missing spaces around operators.
There is an additional change on line 49 that removes unnecessary
parentheses around ternary operands.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 16
This patch fixes coding style issues reported by checkpatch. The only
change in this patch that isn't just removing spaces before opening
square brackets is at line 213 where the initialization of fls_strings[]
is placed in same line.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c
This patch moves the constant 0x3ff to right and put spaces
in the right shift.
Caught by coccinelle:
scripts/coccinelle/misc/compare_const_fl.cocci
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehc
This patch fixes coding style issues reported by checkpatch concerning
to missing line after struct declarations.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 4
This patch removes the local STUB_DEBUG_FILES debugging
definition. STUB_DEBUG_FILES was used only in ehci-hcd, whereas
CONFIG_DYNAMIC_DEBUG is used all over the kernel.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 4 ++--
drivers/usb/host/ehci.h | 5 -
2 files changed
This patch adds parens to sizeof operator uses.
Tested by compilation only.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-sched.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sch
This patch removes an useless else branch after a break, reducing one
indent block.
Tested by compilation only.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-sched.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci-sc
This patch removes unnecessary braces in single statement blocks at the
same time as replaces the if statement with a ternary conditional.
Tested by compilation only.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-sched.c | 6 +-
1 file changed, 1 insertion(+)
1 - 100 of 144 matches
Mail list logo
