[PATCH RESEND 1/1] usb: phy: mxs: declare variable with initialized value

2016-01-21 Thread Li Jun
Initialize vbus_value to be 0 since it's possible not to assign any value before judgement. Signed-off-by: Li Jun diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index c2936dc..00bfea0 100644 --- a/drivers/usb/phy/phy-mxs-usb.c +++ b/drivers/usb/phy/phy-mxs-usb.c @@ -2

Re: Nokia N900: musb is in wrong state after boot

2016-01-21 Thread Pali Rohár
On Tuesday 19 January 2016 12:33:15 Tony Lindgren wrote: > Hi, > > * Pali Rohár [160109 07:16]: > > Hello, > > > > when I boot 4.4.0-rc7+ kernel compiled with g_nokia into zImage on Nokia > > N900 into userspace then usb gadget (g_nokia) does not work. Notebook, > > connected on other side doe

Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-21 Thread Arnd Bergmann
On Thursday 21 January 2016 11:15:24 Peter Chen wrote: > > Just adding from device driver view and change the name from "roohub" to > "port". > > It is the port number (1-9), but not the root hub number. > > At the most of embedded platforms, we have only one port per controller. > For example,

Re: [PATCH v2] hid: usbhid: hid-core: fix recursive deadlock

2016-01-21 Thread Jiri Kosina
On Wed, 20 Jan 2016, Jason Gerecke wrote: > I've been prompted to resurrect this question after fielding yet another > question from a user encountering a locked-up system. We received a > surprising number of reports of people encountering this issue in the > past several weeks and that's only

Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-21 Thread Peter Chen
On Thu, Jan 21, 2016 at 09:41:20AM +0100, Arnd Bergmann wrote: > On Thursday 21 January 2016 11:15:24 Peter Chen wrote: > > > > Just adding from device driver view and change the name from "roohub" to > > "port". > > > > It is the port number (1-9), but not the root hub number. > > > > At the mo

Re: Nokia N900: musb is in wrong state after boot

2016-01-21 Thread Ivaylo Dimitrov
On 21.01.2016 10:40, Pali Rohár wrote: I do not know now. I tried to find it in N900 schemantics, but do not see it. CCing Joerg, do you know? http://plan9.stanleylieber.com/hardware/n900/n900.schematics.pdf -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the bo

Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-21 Thread Arnd Bergmann
On Thursday 21 January 2016 17:48:32 Peter Chen wrote: > > > > > So two hubs at ports 1 and 2 of the USB controller that integrates > > the root hub and shares a device node with it. > > > Ok, so the "reg" is the address for certain root hub (HS or SS), not > the unity address for the whole cont

RE: Deadlock in USB/IP driver

2016-01-21 Thread Andrew Goodbody
Is there anyone who can help me with this deadlock? Thanks, Andrew > -Original Message- > From: Andrew Goodbody > Sent: 14 December 2015 16:23 > To: linux-usb@vger.kernel.org > Subject: Deadlock in USB/IP driver > > https://bugzilla.kernel.org/show_bug.cgi?id=109351 > > I posted the log

Re: Nokia N900: musb is in wrong state after boot

2016-01-21 Thread Pali Rohár
On Thursday 21 January 2016 11:57:48 Ivaylo Dimitrov wrote: > > > On 21.01.2016 10:40, Pali Rohár wrote: > > > >I do not know now. I tried to find it in N900 schemantics, but do not > >see it. > > > >CCing Joerg, do you know? > > > > > http://plan9.stanleylieber.com/hardware/n900/n900.schematic

Re: Nokia N900: musb is in wrong state after boot

2016-01-21 Thread Ivaylo Dimitrov
On 21.01.2016 12:23, Pali Rohár wrote: You probably forgot to specify page in PDF or other location where is that PHY interrupt. As I wrote I tried to find it, but do not see it there. Oh, sorry, I misunderstood what you wrote - I was under the impression that you can't find the schematics

Re: Nokia N900: musb is in wrong state after boot

2016-01-21 Thread joerg Reisenweber
On Thu 21 January 2016 09:40:07 Pali Rohár wrote: > On Tuesday 19 January 2016 12:33:15 Tony Lindgren wrote: > > Hi, > > > > * Pali Rohár [160109 07:16]: > > > Hello, > > > > > > when I boot 4.4.0-rc7+ kernel compiled with g_nokia into zImage on Nokia > > > N900 into userspace then usb gadget (g

[PATCH 2/2] usb: no locking for reading descriptors in sysfs

2016-01-21 Thread Oliver Neukum
Quting the relevant thread: > In fact, I suspect the locking added by the kernel 3.13 commit for > read_descriptors() is invalid because read_descriptors() performs no USB > activity; read_descriptors() just reads information from an allocated > memory structure. This structure is protected as the

[PATCH 1/2] usb: sysfs: make locking interruptible

2016-01-21 Thread Oliver Neukum
232275a USB: fix substandard locking for the sysfs files introduced needed locking into sysfs operations on USB devices It, however, uses uninterruptible sleep and if the error handling is on extreme cases of sleep lengths of 10s of seconds are possible. Unless we are removing the device we should

Re: NET2280: Adding PLX usb2380 support (issues encountered)

2016-01-21 Thread Justin DeFields
In the start_dma function, I added the following lines at the start of the function: if (req->req.length % ep->ep.maxpacket) { printk("%s packet is short(%d)...\n", (ep->is_in) ? "IN" : "OUT", req->req.length); } The packet is never listed as short via my method above during this erroneous d

[PATCH 2/2] Drivers: MUSB: Davinci MUSB: added DT support

2016-01-21 Thread Petr Kulhavy
TI DaVinci MUSB driver equipped with DeviceTree support. Tested with AM1808 board and USB2.0 (OTG) in host mode. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 52 +++ drivers/usb/musb/da8xx.c | 166 + inclu

Re: [PATCH 02/14] uas: reserve a tag for management

2016-01-21 Thread Hans de Goede
Hi, Thanks for working on this. I've not done much work (if any) on uas lately) Are you interested in becoming a co-maintainer for the uas driver, or even taking it over completely ? On 19-01-16 11:39, Oliver Neukum wrote: UAS uses a shared tag space. We reserve tag #1 for management. That leav

Re: [PATCH 04/14] uas: lock the abort handler

2016-01-21 Thread Hans de Goede
Hi, On 19-01-16 11:39, Oliver Neukum wrote: We have exactly one TMF. It must be locked against reuse. Signed-off-by: Oliver Neukum --- drivers/usb/storage/uas.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 05b6f80..06211

usbip-utils

2016-01-21 Thread Argus Rosenhaim
Hi! I got your git from a forum, but I can’t figure out how to installed in my OpenWRT CC, any help? Argus Luconi Rosenhaim AV Tecnologias Inovadoras +55 51 9283 7934 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org M

Re: [PATCH 2/2] usb: no locking for reading descriptors in sysfs

2016-01-21 Thread Dean Jenkins
On 21/01/16 14:18, Oliver Neukum wrote: Quting the relevant thread: In fact, I suspect the locking added by the kernel 3.13 commit for read_descriptors() is invalid because read_descriptors() performs no USB activity; read_descriptors() just reads information from an allocated memory structure.

Re: [PATCH 2/2] usb: no locking for reading descriptors in sysfs

2016-01-21 Thread Alan Stern
On Thu, 21 Jan 2016, Oliver Neukum wrote: > Quting the relevant thread: > > > In fact, I suspect the locking added by the kernel 3.13 commit for > > read_descriptors() is invalid because read_descriptors() performs no USB > > activity; read_descriptors() just reads information from an allocated >

Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-21 Thread Alan Stern
On Thu, 21 Jan 2016, Arnd Bergmann wrote: > On Thursday 21 January 2016 17:48:32 Peter Chen wrote: > > > > > > > > So two hubs at ports 1 and 2 of the USB controller that integrates > > > the root hub and shares a device node with it. > > > > > Ok, so the "reg" is the address for certain root h

Re: Introducing the use of TMF in the UAS driver

2016-01-21 Thread Hans de Goede
Hi, On 19-01-16 11:39, Oliver Neukum wrote: This set introduces the TMF functions of SAM in the UAS driver to handle abort() and device_reset(). That allows to do an abort() without resetting the whole adapter and just one of the devices in case multiple devices are connected to the host. One ta

Updates to submitted patches

2016-01-21 Thread Alan Stern
Greg: Your queue of pending patches should include the following three changes to ehci-hcd: USB: EHCI: store reason for unlinking a QH USB: EHCI: add a delay when unlinking an active QH USB: EHCI: fix problems involving ehci->iaa_in_progress flag (The last one was sent in

Re: [PATCH 05/14] uas: actually use TASK_ABORT iu

2016-01-21 Thread Hans de Goede
Hi, On 19-01-16 11:39, Oliver Neukum wrote: Issue a TASK_ABORT iu to the device and wait for it to complete. Signed-off-by: Oliver Neukum --- drivers/usb/storage/uas.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 06

Re: Nokia N900: musb is in wrong state after boot

2016-01-21 Thread Tony Lindgren
* joerg Reisenweber [160121 02:30]: > On Thu 21 January 2016 09:40:07 Pali Rohár wrote: > > On Tuesday 19 January 2016 12:33:15 Tony Lindgren wrote: > > > Hi, > > > > > > * Pali Rohár [160109 07:16]: > > > > Hello, > > > > > > > > when I boot 4.4.0-rc7+ kernel compiled with g_nokia into zImage

Re: [PATCH 2/2] Drivers: MUSB: Davinci MUSB: added DT support

2016-01-21 Thread Sergei Shtylyov
Hello. On 01/21/2016 05:53 PM, Petr Kulhavy wrote: TI DaVinci MUSB driver equipped with DeviceTree support. Tested with AM1808 board and USB2.0 (OTG) in host mode. Signed-off-by: Petr Kulhavy --- .../devicetree/bindings/usb/da8xx-usb.txt | 52 +++ drivers/usb/musb/da8xx.c

Re: Etron EJ168 USB3.0 rev1 and SanDisk Extreme 64GB USB3.0 Stick: random resets

2016-01-21 Thread Ivan P
Turns out I DO have another USB3.0 device, an external HDD enclosure. The PC it is connected to is so weak that it is unable to reach USB3.0 speeds with it, so I forgot about it. I've tested the controller on my PC with that USB HDD and there doesn't seem to be any issues unlike with the Sandisk st

Re: xhci list corruption on sysfs removal

2016-01-21 Thread Joe Lawrence
On 12/23/2015 08:40 AM, Joe Lawrence wrote: > On 12/21/2015 10:07 AM, Mathias Nyman wrote: >> Hi >> >> On 18.12.2015 18:48, Joe Lawrence wrote: >>> Hello Roger and Mathias, >>> >>> Running with slub_debug=FZPU and removing an XHCI host controller via >>> sysfs, I've hit a use-after-free that I've b

Re: Nokia N900: musb is in wrong state after boot

2016-01-21 Thread joerg Reisenweber
On Thu 21 January 2016 09:41:46 Tony Lindgren wrote: > Then for supporting the USB host mode.. We should add regulator support > to the USB PHY driver so if the ID pin is grounded, the PHY driver enables > the VBUS regulator. That too seems to need some coordination between the > drivers/phy/phy-tw

NET2280: usb2380/usb3380 CDC ACM serial gadget issue

2016-01-21 Thread Justin DeFields
We had our hardware engineer add in a usb3380 chip to our board in place of the usb2380 (with some small wiring adjustments, and utilizing the usb 2.0 pins only). It has the EXACT same issue as the 2280, which leads me to the following: 1) I have probably implemented the usb2380 device correctly

Re: Nokia N900: musb is in wrong state after boot

2016-01-21 Thread Tony Lindgren
* joerg Reisenweber [160121 10:45]: > On Thu 21 January 2016 09:41:46 Tony Lindgren wrote: > > Then for supporting the USB host mode.. We should add regulator support > > to the USB PHY driver so if the ID pin is grounded, the PHY driver enables > > the VBUS regulator. That too seems to need some

Re: Nokia N900: musb is in wrong state after boot

2016-01-21 Thread joerg Reisenweber
On Thu 21 January 2016 11:21:13 Tony Lindgren wrote: > Do you have some pointer > to the "certain resistor value on ID to GND" spec? Is it maybe part of > the carkit related parts of the USB spec? ""Three additional ID pin states are defined[4] at the nominal resistance values of 124 kΩ, 68 kΩ, a

Re: Nokia N900: musb is in wrong state after boot

2016-01-21 Thread Tony Lindgren
* joerg Reisenweber [160121 11:35]: > On Thu 21 January 2016 11:21:13 Tony Lindgren wrote: > > Do you have some pointer > > to the "certain resistor value on ID to GND" spec? Is it maybe part of > > the carkit related parts of the USB spec? > > ""Three additional ID pin states are defined[4] at t

Re: NET2280: Adding PLX usb2380 support (issues encountered)

2016-01-21 Thread Alan Stern
On Thu, 21 Jan 2016, Justin DeFields wrote: > In the start_dma function, I added the following lines at the start of > the function: > > if (req->req.length % ep->ep.maxpacket) > { > printk("%s packet is short(%d)...\n", (ep->is_in) ? "IN" : "OUT", > req->req.length); > } > > The packet is

Re: NET2280: usb2380/usb3380 CDC ACM serial gadget issue

2016-01-21 Thread Alan Stern
On Thu, 21 Jan 2016, Justin DeFields wrote: > We had our hardware engineer add in a usb3380 chip to our board in > place of the usb2380 (with some small wiring adjustments, and > utilizing the usb 2.0 pins only). It has the EXACT same issue as the > 2280, which leads me to the following: > > 1)

Bug in split transactions on Raspberry Pi

2016-01-21 Thread Alan Stern
John, Doug, or anyone else: I've got a Raspberry Pi 2B and I'm trying to use it with a compound device. The device has a High-Speed hub with a Full-Speed function permanently attached to port 4. The RPi detects the function but fails to initialize it. My bus analyzer shows the reason why: A Sta

Re: NET2280: usb2380/usb3380 CDC ACM serial gadget issue

2016-01-21 Thread Justin DeFields
Alan, Yes 'req->td->dmadesc = 0;' is set from within start_dma right before the 'paranoia' block is called. (adding email train back to list serv) On Thu, Jan 21, 2016 at 4:41 PM, Alan Stern wrote: > On Thu, 21 Jan 2016, Justin DeFields wrote: > >> Alan, I guess I misspoke, but I was referring

Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-21 Thread Arnd Bergmann
On Thursday 21 January 2016 10:21:15 Alan Stern wrote: > On Thu, 21 Jan 2016, Arnd Bergmann wrote: > > > On Thursday 21 January 2016 17:48:32 Peter Chen wrote: > > > > > > > > > > > So two hubs at ports 1 and 2 of the USB controller that integrates > > > > the root hub and shares a device node w

Re: Bug in split transactions on Raspberry Pi

2016-01-21 Thread Doug Anderson
Hi, On Thu, Jan 21, 2016 at 1:28 PM, Alan Stern wrote: > John, Doug, or anyone else: > > I've got a Raspberry Pi 2B and I'm trying to use it with a compound > device. The device has a High-Speed hub with a Full-Speed function > permanently attached to port 4. > > The RPi detects the function but

Re: [PATCH 2/2] Drivers: MUSB: Davinci MUSB: added DT support

2016-01-21 Thread Rob Herring
On Thu, Jan 21, 2016 at 03:53:19PM +0100, Petr Kulhavy wrote: > TI DaVinci MUSB driver equipped with DeviceTree support. > Tested with AM1808 board and USB2.0 (OTG) in host mode. > > Signed-off-by: Petr Kulhavy > --- > .../devicetree/bindings/usb/da8xx-usb.txt | 52 +++ > drivers/u

Re: [PATCH v2 0/2] usb: dwc2: Fix regressions on bcm2835

2016-01-21 Thread Heiko Stuebner
Am Montag, 11. Januar 2016, 16:32:00 schrieb John Youn: > This series fixes a couple regressions reported on Raspberry Pi. same regressions (Isaw strange usb resets) seem to affect Rockchip as well and these two patches seem to fix that there too, so Tested-by: Heiko Stuebner -- To unsubscribe

[PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-21 Thread Emilio López
From: Reilly Grant The new USBDEVFS_DROP_PRIVILEGES ioctl allows a process to voluntarily relinquish the ability to issue other ioctls that may interfere with other processes and drivers that have claimed an interface on the device. Signed-off-by: Reilly Grant Signed-off-by: Emilio López ---

Re: [PATCH v4 07/21] usb: dwc2: hcd: fix split transfer schedule sequence

2016-01-21 Thread Doug Anderson
he system] > > url: > https://github.com/0day-ci/linux/commits/Douglas-Anderson/usb-dwc2-host-Fix-and-speed-up-all-the-stuff-especially-with-splits/20160121-131414 > config: x86_64-randconfig-x019-01201142 (attached as .config) > reproduce: > # save the attached .config to

[RFC PATCH] codingstyle: improve elisp for a better experience

2016-01-21 Thread Geyslan G. Bem
This patch does use of more emacs functionalities which deliver to the user indentation, commenting and white space highlighting. As known tabs are the higher law and the prior elisp code enforces that law for any lineup indentation. However some trees have specific rules about line continuation

Re: [PATCH v3 1/1] USB: core: let USB device know device node

2016-01-21 Thread Peter Chen
On Thu, Jan 21, 2016 at 11:24:21PM +0100, Arnd Bergmann wrote: > On Thursday 21 January 2016 10:21:15 Alan Stern wrote: > > On Thu, 21 Jan 2016, Arnd Bergmann wrote: > > > > > On Thursday 21 January 2016 17:48:32 Peter Chen wrote: > > > > > > > > > > > > > > So two hubs at ports 1 and 2 of the U

Re: [PATCH RESEND 1/1] usb: phy: mxs: declare variable with initialized value

2016-01-21 Thread Peter Chen
On Thu, Jan 21, 2016 at 03:51:26PM +0800, Li Jun wrote: > Initialize vbus_value to be 0 since it's possible not to assign > any value before judgement. > > Signed-off-by: Li Jun > > diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c > index c2936dc..00bfea0 100644 > --- a

Re: Updates to submitted patches

2016-01-21 Thread Greg KH
On Thu, Jan 21, 2016 at 10:26:28AM -0500, Alan Stern wrote: > Greg: > > Your queue of pending patches should include the following three > changes to ehci-hcd: > > USB: EHCI: store reason for unlinking a QH > USB: EHCI: add a delay when unlinking an active QH > USB: EHCI: fix pr