Hello.
On 12/12/2015 4:19 AM, Geyslan G. Bem wrote:
This patch removes useless assignments.
Initializers, you mean?
Tested by compilation only.
Caught by cppcheck.
Signed-off-by: Geyslan G. Bem
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb
On 12/12/2015 4:19 AM, Geyslan G. Bem wrote:
This patch removes unnecessary braces in single statement blocks at the
same time as replaces the if statement with a ternary conditional.
Tested by compilation only.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-s
2015-12-12 11:48 GMT-03:00 Sergei Shtylyov :
> Hello.
>
> On 12/12/2015 4:19 AM, Geyslan G. Bem wrote:
>
>> This patch removes useless assignments.
>
>
>Initializers, you mean?
You're right. Fixing.
>
>> Tested by compilation only.
>> Caught by cppcheck.
>>
>> Signed-off-by: Geyslan G. Bem
>
2015-12-12 11:50 GMT-03:00 Sergei Shtylyov :
> On 12/12/2015 4:19 AM, Geyslan G. Bem wrote:
>
>> This patch removes unnecessary braces in single statement blocks at the
>> same time as replaces the if statement with a ternary conditional.
>>
>> Tested by compilation only.
>> Caught by checkpatch.
>
On Fri, 11 Dec 2015, Geyslan G. Bem wrote:
> This patch removes an infinite 'for' loop and makes use of the already
> existing 'restart' tag instead, reducing one leading tab.
>
> The comments and code were corrected conforming coding style.
>
> Tested by compilation only.
> Caught by checkpatch
On Fri, 11 Dec 2015, Geyslan G. Bem wrote:
> This patch moves comment into the else branch avoiding the following
> misleading warning.
>
> "braces {} are not necessary for single statement blocks"
>
> Caught by checkpatch.
>
> Signed-off-by: Geyslan G. Bem
> Suggested-by: Joe Perches
> ---
>
Hello,
2015-12-12 13:19 GMT-03:00 Alan Stern :
> On Fri, 11 Dec 2015, Geyslan G. Bem wrote:
>
>> This patch moves comment into the else branch avoiding the following
>> misleading warning.
>>
>> "braces {} are not necessary for single statement blocks"
>>
>> Caught by checkpatch.
>>
>> Signed-off-
2015-12-12 13:15 GMT-03:00 Alan Stern :
> On Fri, 11 Dec 2015, Geyslan G. Bem wrote:
>
>> This patch removes an infinite 'for' loop and makes use of the already
>> existing 'restart' tag instead, reducing one leading tab.
>>
>> The comments and code were corrected conforming coding style.
>>
>> Tes
On Sat, 12 Dec 2015, Geyslan G. Bem wrote:
> >> + if (q.itd->hw_transaction[uf] &
> >> + ITD_ACTIVE(ehci))
> >
> > The style used in this source file does not align continuation lines
> > with open parens on the line above
This patch adds parens to sizeof operator uses.
Tested by compilation only.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-sched.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sch
This patch removes unnecessary braces in single statement blocks at the
same time as replaces the if statement with a ternary conditional.
Tested by compilation only.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
v2: removes unnecessary parens in ternary conditional.
---
drivers/usb
This patch adds a blank line after declarations.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-sched.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index 00d1932..ff6319b 100644
--- a/drivers/
This patch changes comments conforming coding style.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-sched.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched
This patch removes an useless else branch after a break, reducing one
indent block.
Tested by compilation only.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-sched.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci-sc
This patch removes useless initializations.
Tested by compilation only.
Caught by cppcheck.
Signed-off-by: Geyslan G. Bem
---
v2: replaces 'assignments' with 'initializations'
---
drivers/usb/host/ehci-sched.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb
This patch removes prohibited spaces before open parenthesis and open
brackets.
It also removes an assignment inside condition and unnecessary braces in
single statement block.
Tested by compilation only.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-sched.c | 2
This patch adds spaces around operators.
Tested by compilation only.
Caught by checkpatch.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index 0ab3
This patch removes an infinite 'for' loop and makes use of the already
existing 'restart' tag instead, reducing one leading tab.
It also puts the easier evaluation (live variable) to be the first in
two conditionals.
if (live && frame == now_frame) { ...
if (live && ((frame == now_frame) ||
This patch moves the constants to right.
Tested by compilation only.
Caught by coccinelle:
scripts/coccinelle/misc/compare_const_fl.cocci
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-sched.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/eh
Cleanup done with the help of coccinelle, checkpatch and cppcheck tools.
Geyslan G. Bem (10):
usb: host: ehci-sched: refactor scan_isoc function
usb: host: ehci-sched: move constants to right
usb: host: ehci-sched: remove useless initializations
usb: host: ehci-sched: add spaces around ope
The following changes since commit 31ade3b83e1821da5fbb2f11b5b3d4ab2ec39db8:
Linux 4.4-rc3 (2015-11-29 18:58:26 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.4-rc5
for you to fetch changes up to ad87e03213b552a5c33d5e
added iounmap inorder to free memory mapped to base before returning
Signed-off-by: Saurabh Sengar
---
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index 26cb8c8..35af362 100644
-
22 matches
Mail list logo
