Hello Alan,
Should I resend this patch version with the tear line correction?
Regards
Rahul Pathak
From: Alan Stern
Sent: Tuesday, December 8, 2015 8:53 PM
To: Pathak, Rahul (R.)
Cc: gre...@linuxfoundation.org; kbo...@gmail.com; dan.carpen...@oracle.c
On Tue, Dec 08, 2015 at 10:50:49AM +0100, Philipp Zabel wrote:
> Hi Peter,
>
> Am Dienstag, den 08.12.2015, 09:37 +0800 schrieb Peter Chen:
> > Add dt-binding documentation for generic onboard USB HUB.
> >
> > Signed-off-by: Peter Chen
> > ---
> > .../bindings/usb/generic-onboard-hub.txt
On Tue, Dec 08, 2015 at 09:24:03PM -0600, Rob Herring wrote:
> On Tue, Dec 08, 2015 at 10:58:48AM +0100, Arnd Bergmann wrote:
> > On Tuesday 08 December 2015 10:50:49 Philipp Zabel wrote:
> > > Am Dienstag, den 08.12.2015, 09:37 +0800 schrieb Peter Chen:
> > > > Add dt-binding documentation for gen
On Tue, Dec 08, 2015 at 10:48:28AM +0100, Arnd Bergmann wrote:
> On Tuesday 08 December 2015 09:37:48 Peter Chen wrote:
>
> > +struct usb_hub_generic_data {
> > + struct clk *clk;
> > +};
> > +
> > +static int usb_hub_generic_probe(struct platform_device *pdev)
> > +{
> > + struct device *dev
On Tue, Dec 08, 2015 at 10:44:02AM +0100, Sascha Hauer wrote:
> On Tue, Dec 08, 2015 at 05:26:56PM +0800, Peter Chen wrote:
> > On Tue, Dec 08, 2015 at 07:19:05AM +0100, Sascha Hauer wrote:
> > > > + hub_data = devm_kzalloc(dev, sizeof(*hub_data), GFP_KERNEL);
> > > > + if (!hub_data)
>
Add a new interface for userspace to preallocate memory that can be
used with usbfs. This gives two primary benefits:
- Zerocopy; data no longer needs to be copied between the userspace
and the kernel, but can instead be read directly by the driver from
userspace's buffers. This works for a
On Tue, Dec 08, 2015 at 07:55:05AM -0600, Felipe Balbi wrote:
>
> Hi,
>
> Peter Chen writes:
> >> seriously ? Is this really all ? What about that reset line below ?
> >
> > The clock is PHY input clock on the HUB, this clock may from SoC's
> > PLL.
>
> oh, you might have misunderstood my comme
On Tue, Dec 08, 2015 at 08:36:00AM -0700, Mathieu Poirier wrote:
> On 7 December 2015 at 18:37, Peter Chen wrote:
> > +
> > + if (dev->of_node) {
> > + struct device_node *node = dev->of_node;
> > +
> > + hub_data->clk = devm_clk_get(dev, "external_clk");
> > +
On Wednesday 09 December 2015 16:12:24 Peter Chen wrote:
> On Tue, Dec 08, 2015 at 09:24:03PM -0600, Rob Herring wrote:
> > On Tue, Dec 08, 2015 at 10:58:48AM +0100, Arnd Bergmann wrote:
> > > On Tuesday 08 December 2015 10:50:49 Philipp Zabel wrote:
> > > > This something we don't have to define a
Am Mittwoch, den 09.12.2015, 16:50 +0800 schrieb Peter Chen:
> On Tue, Dec 08, 2015 at 08:36:00AM -0700, Mathieu Poirier wrote:
> > On 7 December 2015 at 18:37, Peter Chen wrote:
> > > +
> > > + if (dev->of_node) {
> > > + struct device_node *node = dev->of_node;
> > > +
> > >
On Wed, Dec 09, 2015 at 09:57:40AM +0100, Lucas Stach wrote:
> Am Mittwoch, den 09.12.2015, 16:50 +0800 schrieb Peter Chen:
> > On Tue, Dec 08, 2015 at 08:36:00AM -0700, Mathieu Poirier wrote:
> > > On 7 December 2015 at 18:37, Peter Chen wrote:
> > > > +
> > > > + if (dev->of_node) {
> > >
On Wednesday 09 December 2015 09:57:40 Lucas Stach wrote:
> Am Mittwoch, den 09.12.2015, 16:50 +0800 schrieb Peter Chen:
> > On Tue, Dec 08, 2015 at 08:36:00AM -0700, Mathieu Poirier wrote:
> > > On 7 December 2015 at 18:37, Peter Chen wrote:
> > > > +
> > > > + if (dev->of_node) {
> > > > +
On Wed, Dec 09, 2015 at 10:10:51AM +0100, Arnd Bergmann wrote:
> On Wednesday 09 December 2015 09:57:40 Lucas Stach wrote:
> > Am Mittwoch, den 09.12.2015, 16:50 +0800 schrieb Peter Chen:
> > > On Tue, Dec 08, 2015 at 08:36:00AM -0700, Mathieu Poirier wrote:
> > > > On 7 December 2015 at 18:37, Pet
Am Mittwoch, den 09.12.2015, 17:00 +0800 schrieb Peter Chen:
> On Wed, Dec 09, 2015 at 09:57:40AM +0100, Lucas Stach wrote:
> > Am Mittwoch, den 09.12.2015, 16:50 +0800 schrieb Peter Chen:
> > > On Tue, Dec 08, 2015 at 08:36:00AM -0700, Mathieu Poirier wrote:
> > > > On 7 December 2015 at 18:37, Pe
Best regards,
Peter Chen
> -Original Message-
> From: Lucas Stach [mailto:l.st...@pengutronix.de]
> Sent: Wednesday, December 09, 2015 5:13 PM
> To: Chen Peter-B29397
> Cc: Mathieu Poirier ; Mark Rutland
> ; devicet...@vger.kernel.org; feste...@gmail.com;
> Philipp Zabel ; Paweł Moll ;
We need to kfree(opts) on error. Also it's nicer to allocate opts
before taking the lock.
Signed-off-by: Dan Carpenter
diff --git a/drivers/usb/gadget/function/f_tcm.c
b/drivers/usb/gadget/function/f_tcm.c
index ed47e40..0a26a2e 100644
--- a/drivers/usb/gadget/function/f_tcm.c
+++ b/drivers/us
On Wed, Dec 09, 2015 at 08:02:53AM +, Pathak, Rahul (R.) wrote:
> Hello Alan,
>
> Should I resend this patch version with the tear line correction?
Why wouldn't you?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
On Thu, Nov 26, 2015 at 01:19:13AM +0100, Steinar H. Gunderson wrote:
> Add a new interface for userspace to preallocate memory that can be
> used with usbfs. This gives two primary benefits:
>
> - Zerocopy; data no longer needs to be copied between the userspace
>and the kernel, but can inst
On Wed, Dec 09, 2015 at 09:29:20AM -0500, Greg Kroah-Hartman wrote:
> Shouldn't there also be some sort of documentation update with this
> patch as well, so that people know of the new functionality we are
> adding?
I can write documentation if you can point me to a reasonable place.
/* Steinar
queue_work() has never returned anything less than zero.
Reported-by: Dan Carpenter
Signed-off-by: Andrzej Pietrasiewicz
---
This patch depends on the series adding configfs support to tcm usb gadget:
http://www.spinics.net/lists/target-devel/msg11215.html
drivers/usb/gadget/function/f_tcm.c
On Tue, 8 Dec 2015, Josh Triplett wrote:
> On Tue, Dec 08, 2015 at 11:04:00AM -0500, Alan Stern wrote:
> > On Mon, 7 Dec 2015, Josh Triplett wrote:
> >
> > > > You're looking at the wrong files. The files to monitor are the ones
> > > > in /sys/devices/pci:00/:00:14.0/usb2/2-3/2-3.1/2-3.
On Wed, 9 Dec 2015, Steinar H. Gunderson wrote:
> On Wed, Dec 09, 2015 at 09:29:20AM -0500, Greg Kroah-Hartman wrote:
> > Shouldn't there also be some sort of documentation update with this
> > patch as well, so that people know of the new functionality we are
> > adding?
>
> I can write document
On Tue, 8 Dec 2015, Steinar H. Gunderson wrote:
> Do you know what the status is for the LPM blacklisting patch we discussed
> earlier?
Last I heard, Baolu Lu was working on a more general solution. In its
absence, maybe I should go ahead and submit the patch.
Alan Stern
--
To unsubscribe fro
Hi Greg,
Here's what I hope to be the last set of fixes for current -rc. Let me
know if you want anything to be changed.
cheers
The following changes since commit f74875dc36135ebae82a8e005f4b7f52289d2c40:
usb: dwc2: fix kernel oops during driver probe (2015-11-20 09:29:47 -0600)
are availabl
A hcd roothub that supports HCD_USB31 is running at SuperSpeedPlus speed
Signed-off-by: Mathias Nyman
---
drivers/usb/core/hcd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 0e38ce6..ff3073d 100644
--- a/drivers/usb/
Hi Greg
This patchseries continues on the USB 3.1 support. It adds a new
USB_SUPER_SPEED_PLUS speed, adds and takes into use a new extended
get_port_status hub request introduced in USB 3.1.
The most visible change to users is the speed "1" shown by
lsusb -t, and the occasional "SuperSpeedPlu
Signed-off-by: Mathias Nyman
---
drivers/usb/core/hcd.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index ff3073d..fb0a9c2 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -128,6 +128,27 @@ static
Add a new USB_SPEED_SUPER_PLUS device speed, and make sure usb core can
handle the new speed.
In most cases the behaviour is the same as with USB_SPEED_SUPER SuperSpeed
devices. In a few places we add a "Plus" string to inform the user of the
new speed.
Signed-off-by: Mathias Nyman
---
drivers/u
usb 3.1 extend the hub get-port-status request by adding different
request types. the new request types return 4 additional bytes called
extended port status, these bytes are returned after the regular
portstatus and portchange values.
The extended port status contains a speed ID for the currently
In most cases the devices with the speed set to USB_SPEED_SUPER_PLUS
are handled like regular SuperSpeed devices.
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-mem.c | 11 ---
drivers/usb/host/xhci-ring.c | 3 ++-
drivers/usb/host/xhci.c | 7 +--
3 files changed, 15
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index dd87be2..1044241 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -4890,6 +4890,7 @@ int xhci_gen_setup(struct
The speed field of the input slot context should represent the speed the
device is working at.
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-mem.c | 3 +++
drivers/usb/host/xhci.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xh
The same way as SuperSpeed devices show "5000" as device speed we wan't to
show "1" as the default speed for SuperSpeedPlus devices in sysfs.
Signed-off-by: Mathias Nyman
---
drivers/usb/core/sysfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/sysfs.c b/drivers/us
If a xhci controller does not provide a protocol speed ID (PSI) table, a
default one should be used instead. Add the default values to the
SuperSpeedPlus device capability. Overwrite the default ones if a PSI table
exists. See xHCI 1.1 sectio 7.2.2.1.1 for more info
Signed-off-by: Mathias Nyman
-
On Wed, Dec 09, 2015 at 09:58:41AM -0600, Felipe Balbi wrote:
> Hi Greg,
>
> Here's what I hope to be the last set of fixes for current -rc. Let me
> know if you want anything to be changed.
>
> cheers
>
> The following changes since commit f74875dc36135ebae82a8e005f4b7f52289d2c40:
>
> usb: d
Hello.
On 12/09/2015 09:22 PM, Mathias Nyman wrote:
Signed-off-by: Mathias Nyman
---
drivers/usb/core/hcd.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index ff3073d..fb0a9c2 100644
--- a/drivers/usb/core/hcd.c
We are using sierra modem for 4G LTE networks. we used to communicate
with modem using AT commands via ttyUSB ports.
Recently we observed a crash in usb driver interface when we try to
post some AT commands. After the crash the kernel seems to be hanged.
We were not able to execute any commands or
Hi Andrzej,
[auto build test WARNING on next-20151209]
[cannot apply to balbi-usb/next usb/usb-testing v4.4-rc4 v4.4-rc3 v4.4-rc2
v4.4-rc4]
url:
https://github.com/0day-ci/linux/commits/Andrzej-Pietrasiewicz/usb-gadget-f_tcm-ignore-return-value-of-queue_work/20151209-225509
config: i386
On Mon, Dec 7, 2015 at 1:17 PM, Alan Stern wrote:
> Michael:
>
> Here at last is the final version of the patch, or something very close
> to it. This should be applied on top of the other EHCI patches, but
> not the quick-and-dirty fix, which it replaces.
>
> Please test it and let me know the r
C99 standardized flexible arrays 'array[]'. The zero-length ones are
old gcc implementation 'array[0]'.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index 49b91b
This patch does align function/macro definitions.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index a4f5ab5..0daed80 100644
--- a/drivers/u
This patch removes the return of the default switch case, since
'ehci_port_speed()' already has the same default return.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
This patch silences
- A coccinelle warning 'scripts/coccinelle/misc/compare_const_fl.cocci'
- All the errors and many warnings shown by checkpatch
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 89 +
1 file changed, 45 insertions(+),
On Wed, Dec 09, 2015 at 04:57:30PM -0300, Geyslan G. Bem wrote:
> This patch silences
> - A coccinelle warning 'scripts/coccinelle/misc/compare_const_fl.cocci'
> - All the errors and many warnings shown by checkpatch
"all" is a lot. Please break down each type of change to a separate
patch. Th
Hello.
On 12/09/2015 10:57 PM, Geyslan G. Bem wrote:
This patch removes the return of the default switch case, since
'ehci_port_speed()' already has the same default return.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
Hello.
On 12/09/2015 10:57 PM, Geyslan G. Bem wrote:
This patch does align function/macro definitions.
Signed-off-by: Geyslan G. Bem
USB code just uses different alignment style (2 tabs) than the other
kernel parts (like networking).
MBR, Sergei
--
To unsubscribe from this list: sen
2015-12-09 17:10 GMT-03:00 Sergei Shtylyov :
> Hello.
>
> On 12/09/2015 10:57 PM, Geyslan G. Bem wrote:
>
>> This patch removes the return of the default switch case, since
>> 'ehci_port_speed()' already has the same default return.
>>
>> Signed-off-by: Geyslan G. Bem
>> ---
>> drivers/usb/host/
2015-12-09 17:11 GMT-03:00 Sergei Shtylyov :
> Hello.
>
> On 12/09/2015 10:57 PM, Geyslan G. Bem wrote:
>
>> This patch does align function/macro definitions.
>>
>> Signed-off-by: Geyslan G. Bem
>
>
> USB code just uses different alignment style (2 tabs) than the other
> kernel parts (like net
On Wed, Dec 09, 2015 at 12:36:12PM -0600, SaRaVanAn wrote:
> We are using sierra modem for 4G LTE networks. we used to communicate
> with modem using AT commands via ttyUSB ports.
> Recently we observed a crash in usb driver interface when we try to
> post some AT commands. After the crash the kern
On Wed, Dec 09, 2015 at 05:15:43PM -0300, Geyslan G. Bem wrote:
> 2015-12-09 17:10 GMT-03:00 Sergei Shtylyov
> :
> > Hello.
> >
> > On 12/09/2015 10:57 PM, Geyslan G. Bem wrote:
> >
> >> This patch removes the return of the default switch case, since
> >> 'ehci_port_speed()' already has the same d
On 12/09/2015 11:15 PM, Geyslan G. Bem wrote:
This patch removes the return of the default switch case, since
'ehci_port_speed()' already has the same default return.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
Our device went for reset. So it starts loading and unloading the
serial USB port.
Here the serious concern is kernel lock. Once it happens the system
is unusable and hard reboot is the only way of recovering it.
Kernel version is 3.12.0
Regards,
Saravanan N
On Wed, Dec 9, 2015 at 2:21 PM, Greg
2015-12-09 17:09 GMT-03:00 Greg Kroah-Hartman :
> On Wed, Dec 09, 2015 at 04:57:30PM -0300, Geyslan G. Bem wrote:
>> This patch silences
>> - A coccinelle warning 'scripts/coccinelle/misc/compare_const_fl.cocci'
>> - All the errors and many warnings shown by checkpatch
>
> "all" is a lot. Please
Hi Geyslan,
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.4-rc4 next-20151209]
url:
https://github.com/0day-ci/linux/commits/Geyslan-G-Bem/usb-host-ehci-h-cleanup-header-file/20151210-040115
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb
Hi Geyslan,
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.4-rc4 next-20151209]
url:
https://github.com/0day-ci/linux/commits/Geyslan-G-Bem/usb-host-ehci-h-cleanup-header-file/20151210-040115
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb
2015-12-09 18:24 GMT-03:00 kbuild test robot :
> Hi Geyslan,
>
> [auto build test ERROR on usb/usb-testing]
> [also build test ERROR on v4.4-rc4 next-20151209]
>
> url:
> https://github.com/0day-ci/linux/commits/Geyslan-G-Bem/usb-host-ehci-h-cleanup-header-file/20151210-0
On Wed, Dec 09, 2015 at 10:39:35AM -0500, Alan Stern wrote:
>> I can write documentation if you can point me to a reasonable place.
> The only documentation I know of for usbfs is a dreadfully out-of-date
> section in Documentation/DocBook/usb.tmpl.
I don't volunteer to get your documentation in
Put space after comma.
This patch also changes QH_NEXT macro for better reading.
Caught by cppcheck: "ERROR: space required after that ','"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci.h
This patch moves the constant 0x3ff to right and put spaces
in the right shift.
Caught by coccinelle:
scripts/coccinelle/misc/compare_const_fl.cocci
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehc
The pointer operator must be sticked to name.
Caught by cppcheck:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index 15de5bf
Removes trailing semicolon from macros.
Caught by cppcheck:
"WARNING: macros should not use a trailing semicolon"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
i
Don't use the 'do {} while (0)' wrapper in a single statement macro.
Caught by cppcheck: "WARNING: Single statement macros should not
use a do {} while (0) loop"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dri
Get rid of spaces before comma.
Caught by cppcheck: "ERROR: space prohibited before that ','"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index ec61aed..6a
Get rid of space before open square bracket.
Caught by cppcheck: "ERROR: space prohibited before open square
bracket '['"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/host/ehci.h
Get rid of space between function name and open parenthesis.
Caught by cppcheck: "WARNING: space prohibited between function name
and open parenthesis '('"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
d
Prefer to use __aligned(size) macro instead of
__attribute__((aligned(size))).
Caught by cppcheck: "WARNING"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
Get rid of space between function name and open parenthesis.
Caught by checkpatch: "WARNING: space prohibited between function name
and open parenthesis '('"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
Get rid of space before open square bracket.
Caught by checkpatch: "ERROR: space prohibited before open square
bracket '['"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/host/ehci.
Put space after comma.
This patch also changes QH_NEXT macro for better reading.
Caught by checkpatch: "ERROR: space required after that ','"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci
The pointer operator must be sticked to name.
Caught by checkpatch:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index 15de5
Removes trailing semicolon from macros.
Caught by checkpatch:
"WARNING: macros should not use a trailing semicolon"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
Prefer to use __aligned(size) macro instead of
__attribute__((aligned(size))).
Caught by checkpatch: "WARNING"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci
Get rid of spaces before comma.
Caught by checkpatch: "ERROR: space prohibited before that ','"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index ec61aed..
Don't use the 'do {} while (0)' wrapper in a single statement macro.
Caught by checkpatch: "WARNING: Single statement macros should not
use a do {} while (0) loop"
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
I've parked some working code, and I wanted to leave a pointer to it to
end this thread.
That is, the sense was that usbredir was not appropriate for the linux
kernel, because Intel was working on a driver implementing the Media
Agnostic USB standard, and having a proliferation of drivers didn't m
From: Jack Pham
Currently the EHCI MSM driver has a hard dependency to be created
by an OTG layer, namely the phy-msm-usb driver. In some cases or
board configurations we want to allow the EHCI host to be
instantiated without OTG capability. Instead, relax the dependency
on having an OTG PHY bein
From: Jack Pham
Disable the silicon quirk which is normally enabled for HSIC
host mode. This would otherwise prevent low speed devices
from enumerating properly.
Signed-off-by: Jack Pham
Signed-off-by: Timur Tabi
---
drivers/usb/host/ehci-msm.c | 2 ++
include/linux/usb/msm_hsusb_hw.h |
From: Jack Pham
Allow the EHCI MSM driver to probe against an ACPI enumerated
device with ID QCOM8040.
Signed-off-by: Jack Pham
Signed-off-by: Timur Tabi
---
drivers/usb/host/ehci-msm.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/
From: Azriel Samson
Registering usb_hcd_platform_shutdown to be called during
shutdown. This is a generic function that performs the
generic host stack's shutdown. It ensures that USB
operations do not continue while kexec boots a new kernel.
Signed-off-by: Azriel Samson
Signed-off-by: Timur Ta
From: Jack Pham
The default value for the 'transceiver select' field of
the PORTSC register may not always be correct. Previously
the phy-msm-usb driver would do this for us, but since
ehci-msm can now be instantiated standalone without any PHY
driver, the register needs to be explicitly initiali
John,
On Wed, Dec 2, 2015 at 11:11 AM, John Youn wrote:
> This series includes patches that were submitted earlier by Douglas
> Anderson and Yunzhi Li to reduce delays during probe and get the
> correct reset values of the hardware configuration registers. These
> are patches 1-6 in this series.
John,
On Wed, Dec 2, 2015 at 11:14 AM, John Youn wrote:
> The reset is required to get reset values of the hardware parameters but
> the force mode is not. Move the base reset into dwc2_get_hwparams() and
> do the reset and force mode afterwards.
>
> Signed-off-by: John Youn
> ---
> drivers/usb
Hi Timur,
Thanks for sending these patches upstream on my behalf.
On Wed, Dec 09, 2015 at 05:41:07PM -0600, Timur Tabi wrote:
> Also, update to use the correct value of AHBMODE to allow
> data transfers to be posted AHB transactions. This aligns
> with the value used in the downstream MSM kernel.
This patch removes redundant conditions.
- (!A || (A && B)) is the same as (!A || B).
- (length && length > 5) can be reduced to a single evaluation.
Caught by: cppcheck
Signed-off-by: Geyslan G. Bem
---
drivers/usb/gadget/udc/s3c-hsudc.c | 2 +-
drivers/usb/host/fhci-sched.c | 2 +-
Jack Pham wrote:
Andy already sent a patch for just this register change.
http://marc.info/?l=linux-usb&m=144678991912202&w=2
I see it's already been queued on Greg's usb-next. I think it would be
good to rebase.
Ok, I will do that in my next patch version.
--
Sent by an employee of the Qualc
On 12/9/2015 4:46 PM, Doug Anderson wrote:
> John,
>
> On Wed, Dec 2, 2015 at 11:14 AM, John Youn wrote:
>> The reset is required to get reset values of the hardware parameters but
>> the force mode is not. Move the base reset into dwc2_get_hwparams() and
>> do the reset and force mode afterwards
John,
On Wed, Dec 2, 2015 at 11:13 AM, John Youn wrote:
> Renamed dwc2_core_reset() to dwc2_core_reset_and_force_mode(). This
> describes what it is doing more accurately. This is in preparation of
> introducing a plain dwc2_core_reset() function that only performs the
> reset and doesn't force t
John,
On Wed, Dec 2, 2015 at 11:13 AM, John Youn wrote:
> Added functions to query the GHWCFG2.OTG_MODE. This tells us whether the
> controller hardware is configured for OTG, device-only, or host-only.
>
> Signed-off-by: John Youn
> ---
> drivers/usb/dwc2/core.c | 37 ++
John,
On Wed, Dec 2, 2015 at 11:13 AM, John Youn wrote:
> According to the databook, the core soft reset should be done before
> checking for AHBIDLE. The gadget version of core reset had it correct
> but the hcd version did not. This fixes the hcd version.
>
> Signed-off-by: John Youn
> ---
>
John,
On Wed, Dec 2, 2015 at 11:13 AM, John Youn wrote:
> dwc2_core_reset() was previously renamed to
> dwc2_core_reset_and_force_mode(). Now add back dwc2_core_reset() which
> performs only a basic core reset without forcing the mode.
>
> Signed-off-by: John Youn
> ---
> drivers/usb/dwc2/core.
John,
On Wed, Dec 2, 2015 at 11:14 AM, John Youn wrote:
> These functions should go in core.h where they can be called from core,
> device, or host.
>
> Signed-off-by: John Youn
> ---
> drivers/usb/dwc2/core.h | 12
> drivers/usb/dwc2/hcd.h | 12
> 2 files changed, 12
John,
On Wed, Dec 2, 2015 at 11:14 AM, John Youn wrote:
> Added functions to set force mode for host and device. These functions
> will check the current mode and only force if needed.
>
> Signed-off-by: John Youn
> ---
> drivers/usb/dwc2/core.c | 54
> +
John,
On Wed, Dec 2, 2015 at 11:15 AM, John Youn wrote:
> The delay for force mode is only 25ms according to the databook.
>
> Signed-off-by: John Youn
> ---
> drivers/usb/dwc2/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/
John,
On Wed, Dec 2, 2015 at 11:15 AM, John Youn wrote:
> This commit adds separate functions for getting the host and device
> specific hardware params. These functions check whether the parameters
> need to be read at all, depending on dr_mode, and they force the mode
> only if necessary. This
Hi,
this short series adds generic, and soc-specific r8a7792 and r8a7793 compat
strings to the Renesas USBHS driver. The intention is to provide a complete
set of compat strings for known R-Car SoCs.
Changes since v1:
* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
a single
Simply document new compatibility string.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.
Signed-off-by: Simon Horman
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++
1 file changed, 2
Add fallback compatibility strings for R-Car Gen2 and Gen3.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.
Also add SoC names.
Signed-off-by: Simon Horman
---
v2
* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
a
Hi Laura,
On Mon, Nov 16, 2015 at 02:47:13PM -0800, Laura Abbott wrote:
> +static int __xpad_submit_urb(struct usb_xpad *xpad,
> + unsigned char odata[XPAD_PKT_LEN], int transfer_length,
> + int type, bool safe_submit)
> +{
> + int ret;
> +
> + if (s
Hi Simon
Thank you for your patch
> Add fallback compatibility strings for R-Car Gen2 and Gen3.
> This is in keeping with the fallback scheme being adopted wherever
> appropriate for drivers for Renesas SoCs.
>
> Also add SoC names.
>
> Signed-off-by: Simon Horman
> ---
(snip)
> Required pro
On 09.12.2015 20:35, Sergei Shtylyov wrote:
Hello.
On 12/09/2015 09:22 PM, Mathias Nyman wrote:
Signed-off-by: Mathias Nyman
---
drivers/usb/core/hcd.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index ff3073d
1 - 100 of 110 matches
Mail list logo
