Re: [PATCH] usb-host: Remove fusbh200 driver

On Fri, Oct 2, 2015 at 7:39 PM, Felipe Balbi wrote: > On Fri, Oct 02, 2015 at 01:18:27PM +0200, Peter Senna Tschudin wrote: >> fusbh200 and fotg210 are very similar. The initial idea was to consolidate >> both drivers but I'm afraid fusbh200 is not being used. >> >> This patch remove the fusbh200

Re: [GIT PULL] usb fixes for v4.3-rc4

On Fri, Oct 02, 2015 at 01:48:49PM -0500, Felipe Balbi wrote: > Hi Greg, > > here's three more fixes for current -rc. They have been in next for a couple > days or so and no build problems have been found. > > regards > > The following changes since commit 9ffecb10283508260936b96022d4ee43a7798b4

[PATCH 01/23] configfs: add show and store methods to struct configfs_attribute

Add methods to struct configfs_attribute to directly show and store attributes without adding boilerplate code to every user. In addition to the methods this also adds 3 helper macros to define read/write, read-only and write-only attributes with a single line of code. Signed-off-by: Christoph He

[PATCH 08/23] usb-gadget/f_midi: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_midi.c | 37 1 file changed, 16 insertions(+), 21 deletions(-)

[PATCH 22/23] ocfs2/cluster: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- fs/ocfs2/cluster/heartbeat.c | 205 +++ fs/ocfs2/cluster/nodemanager.c | 241 ++--- 2 files changed, 100 insertions(+), 346 deletions(-) diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2

[PATCH 20/23] netconsole: use per-attribute show and store methods

Note that the old code actually used the store_attributes method to do locking, this is moved into the individual methods. Signed-off-by: Christoph Hellwig --- drivers/net/netconsole.c | 271 +++ 1 file changed, 132 insertions(+), 139 deletions(-) dif

[PATCH 11/23] usb-gadget/f_mass_storage: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_mass_storage.c | 119 +++ 1 file changed, 46 insertions(+), 73 deletions(-)

[PATCH 13/23] usb-gadget/f_uac2: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_uac2.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff -

simplify configfs attributes V2

This series consolidates the code to implement configfs attributes by providing the ->show and ->store method in common code and using container_of in the methods to access the containing structure. This reduces source and binary size of configfs consumers a lot. Changes since V1: - a couple fix

[PATCH 06/23] usb-gadget/ether: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_ecm.c| 8 ++--- drivers/usb/gadget/function/f_eem.c| 8 ++--- drivers/usb

[PATCH 07/23] usb-gadget/f_loopback: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_loopback.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-)

[PATCH 10/23] usb-gadget/f_sourcesink: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_sourcesink.c | 83 +- 1 file changed, 36 insertions(+), 47 deletions(-)

[PATCH 12/23] usb-gadget/f_uac1: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_uac1.c | 39 +++- 1 file changed, 16 insertions(+), 23 deletions(-)

[PATCH 23/23] configfs: remove old API

Remove the old show_attribute and store_attribute methods and update the documentation. Also replace the two C samples with a single new one in the proper samples directory where people expect to find it. Signed-off-by: Christoph Hellwig --- Documentation/filesystems/Makefile |

[PATCH 17/23] dlm: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: David Teigland cl_cluster_name); } -static ssize_t cluster_cluster_name_write(struct dlm_cluster *cl, +static ssize_t cluster_cluster_name_store(struct co

[PATCH 21/23] ocfs2/cluster: move locking into attribute store methods

The test and separate set bit scheme was racy to start with, so move to do a test_and_set_bit after doing the earlier error checks inside the actual store methods. Also remove the locking for the local attribute which already has a different scheme to synchronize. Signed-off-by: Christoph Hellwig

[PATCH 09/23] usb-gadget/f_printer: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_printer.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) d

[PATCH 05/23] usb-gadget/f_acm: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_acm.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git

[PATCH 04/23] usb-gadget/f_hid: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_hid.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) d

[PATCH 16/23] usb-gadget/f_serial: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_serial.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --

[PATCH 15/23] usb-gadget/f_phonet: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_phonet.c | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff --g

[PATCH 14/23] usb-gadget/f_obex: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_obex.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --gi

[PATCH 18/23] spear13xx_pcie_gadget: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/misc/spear13xx_pcie_gadget.c | 216 --- 1 file changed, 71 insertions(+), 145 deletions(-) diff --git a/drivers/misc/spear13xx_pcie_gadget.c b/drivers/misc/spear13xx_pcie_gadget.c index b8374cd..ee120dc 100644 --- a/dr

[PATCH 03/23] usb-gadget/uvc: use per-attribute show and store methods

UVC is a little different from other configfs consumers in that it wants different function and field names from the exposed attribute name, so it keeps it's local macros to define attributes instead of using the common ones. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --

[PATCH 02/23] usb-gadget: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also causes binary bloat. Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/configfs.c | 295 ++-- include/linux/usb/gadget_configfs.h | 19 +-- 2

[PATCH 15/15] dma: remove external references to dma_supported

Signed-off-by: Christoph Hellwig --- Documentation/DMA-API.txt | 13 - drivers/usb/host/ehci-hcd.c | 2 +- drivers/usb/host/fotg210-hcd.c | 2 +- drivers/usb/host/fusbh200-hcd.c | 2 +- drivers/usb/host/oxu210hp-hcd.c | 2 +- 5 files changed, 4 insertions(+), 17 deletio

[PATCH 14/15] pci: remove pci_dma_supported

Signed-off-by: Christoph Hellwig --- drivers/parisc/ccio-dma.c| 2 -- include/asm-generic/pci-dma-compat.h | 6 -- 2 files changed, 8 deletions(-) diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c index 957b421..8e11fb2 100644 --- a/drivers/parisc/ccio-dma.c +++

[PATCH 12/15] kaweth: remove ifdefed out call to dma_supported

Signed-off-by: Christoph Hellwig --- drivers/net/usb/kaweth.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index 1e9cdca..f64b25c 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -1177,12 +1177,6 @@ err_fw:

[PATCH 13/15] usbnet: remove ifdefed out call to dma_supported

Signed-off-by: Christoph Hellwig --- drivers/net/usb/usbnet.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index b4cf107..9497d51 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1661,12 +1661,6 @@ usbnet_prob

[PATCH 11/15] sfc: don't call dma_supported

dma_set_mask already checks for a supported DMA mask before updating it, the call to dma_supported is redundant. Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/sfc/efx.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx.c b/driver

[PATCH 10/15] nouveau: don't call pci_dma_supported

Just try to set a 64-bit DMA mask first and retry with the smaller dma_mask if dma_set_mask failed. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drive

[PATCH 08/15] netup_unidvb: use pci_set_dma_mask insted of pci_dma_supported

This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_c

[PATCH 09/15] mpsc: use dma_set_mask insted of dma_supported

This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/tty/serial/mpsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/mpsc.c b/drivers/tty/serial/mpsc.c index 82bb6d1..1

[PATCH 07/15] cx23885: use pci_set_dma_mask insted of pci_dma_supported

This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/media/pci/cx23885/cx23885-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx23885/cx23885-core.c b/drivers/med

[PATCH 06/15] cx25821: use pci_set_dma_mask insted of pci_dma_supported

This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/media/pci/cx25821/cx25821-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx25821/cx25821-core.c b/drivers/med

[PATCH 04/15] saa7134: use pci_set_dma_mask insted of pci_dma_supported

This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/media/pci/saa7134/saa7134-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/saa7134/saa7134-core.c b/drivers/med

[PATCH 05/15] cx88: use pci_set_dma_mask insted of pci_dma_supported

This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/media/pci/cx88/cx88-alsa.c | 2 +- drivers/media/pci/cx88/cx88-mpeg.c | 2 +- drivers/media/pci/cx88/cx88-video.c | 2 +- 3 files changed, 3 insertions(+)

remove dma_supported and pci_dma_supported as public APIs

All driver should be using dma_set_mask / pci_set_dma_mask to try to set the dma mask instead of just querying it. Without that some iommu implementations may not work. pci_dma_supported is removed entirely, but dma_supported stays for dma_ops implementations for now. -- To unsubscribe from this

[PATCH 02/15] tw68-core: use pci_set_dma_mask insted of pci_dma_supported

This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/media/pci/tw68/tw68-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/tw68/tw68-core.c b/drivers/media/pci/tw68/

[PATCH 03/15] saa7164: use pci_set_dma_mask insted of pci_dma_supported

This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/media/pci/saa7164/saa7164-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/med

[PATCH 01/15] pcnet32: use pci_set_dma_mask insted of pci_dma_supported

This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/amd/pcnet32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/am

[PATCH] usbhid: Fix for the WiiU adapter from Mayflash

The WiiU adapter from Mayflash (see http://www.mayflash.com/Products/NINTENDOWiiU/W009.html) is not working correctly. The "XInput" mode works fine, the controller is recognized as a xbox controller. But it is only possible to connect one controller with this method. In "DInput" mode the devic

Re: [PATCH 05/15] cx88: use pci_set_dma_mask insted of pci_dma_supported

Hi Christoph, Em Sat, 3 Oct 2015 17:19:29 +0200 Christoph Hellwig escreveu: > This ensures the dma mask that is supported by the driver is recorded > in the device structure. For this and the other patches touching at drivers/media: Acked-by: Mauro Carvalho Chehab > > Signed-off-by: Chri

Re: [PATCH] usbhid: Fix for the WiiU adapter from Mayflash

Oliver Schmitt writes: Hi, > The WiiU adapter from Mayflash (see > http://www.mayflash.com/Products/NINTENDOWiiU/W009.html) is not working > correctly. > > The "XInput" mode works fine, the controller is recognized as a xbox > controller. But it is only possible to connect one controller with

Re: [PATCH] usb-host: Remove fusbh200 driver

Peter Senna Tschudin writes: > On Fri, Oct 2, 2015 at 7:39 PM, Felipe Balbi wrote: >> On Fri, Oct 02, 2015 at 01:18:27PM +0200, Peter Senna Tschudin wrote: >>> fusbh200 and fotg210 are very similar. The initial idea was to consolidate >>> both drivers but I'm afraid fusbh200 is not being used. >

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

On 30/09/15 20:40, Jiri Kosina wrote: > On Wed, 30 Sep 2015, Luis de Bethencourt wrote: > >> The driver is using -1 instead of the -ENOMEM defined macro to specify >> that a buffer allocation failed. Since the error number is propagated, >> the caller will get a -EPERM which is the wrong error con