Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support

Hi Peter, On Thu, Sep 24, 2015 at 2:17 AM, Peter Chen wrote: > On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote: >> If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile >> properly. >> > > Would you post the warning or error messages? > > I just tried at v4.3-rc1 (

Re: [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails

On Thu, Sep 24, 2015 at 2:20 AM, Peter Chen wrote: > On Wed, Sep 23, 2015 at 12:40:46PM +0100, Felipe Tonello wrote: >> Hi Peter, >> >> On Wed, Sep 23, 2015 at 8:09 AM, Peter Chen wrote: >> > On Tue, Sep 22, 2015 at 07:59:10PM +0100, Felipe F. Tonello wrote: >> >> This fix a memory leak that will

RE: [PATCH v1] usb: dwc2: gadget: fix a memory use-after-free bug

> -Original Message- > From: Kaukab, Yousaf > Sent: Tuesday, September 22, 2015 2:24 PM > To: John Youn; Yunzhi Li; Felipe Balbi > Cc: he...@sntech.de; c...@rock-chips.com; h...@rock-chips.com; yk@rock- > chips.com; gaura...@google.com; albe...@google.com; w...@rock-chips.com; > jwer...@chr

Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support

On Fri, Sep 25, 2015 at 09:26:21AM +0100, Felipe Tonello wrote: > Hi Peter, > > On Thu, Sep 24, 2015 at 2:17 AM, Peter Chen wrote: > > On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote: > >> If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile > >> properly. > >> >

Re: [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails

On Fri, Sep 25, 2015 at 09:27:49AM +0100, Felipe Tonello wrote: > On Thu, Sep 24, 2015 at 2:20 AM, Peter Chen wrote: > > On Wed, Sep 23, 2015 at 12:40:46PM +0100, Felipe Tonello wrote: > >> Hi Peter, > >> > >> On Wed, Sep 23, 2015 at 8:09 AM, Peter Chen > >> wrote: > >> > On Tue, Sep 22, 2015 at

Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

Hi Peter, On Thu, Sep 24, 2015 at 2:38 AM, Peter Chen wrote: > On Wed, Sep 23, 2015 at 01:01:44PM +0100, Felipe F. Tonello wrote: >> req->actual == req->length means that there is no data left to enqueue, >> so free the request. >> >> Signed-off-by: Felipe F. Tonello >> --- >> >> Changes in v2:

Re: Problems with printk logs and my driver

On Thu, Sep 24, 2015 at 9:51 PM, Alan Stern wrote: > On Thu, 24 Sep 2015, Jiri Kosina wrote: > >> On Wed, 23 Sep 2015, Alan Stern wrote: >> >> > Your mistake was thinking that the driver for your keyboard is usbkbd. >> > It isn't. It's usbhid, as you can see in the "lsusb -t" output above. >> >>

Re: [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails

On Fri, Sep 25, 2015 at 10:02 AM, Peter Chen wrote: > On Fri, Sep 25, 2015 at 09:27:49AM +0100, Felipe Tonello wrote: >> On Thu, Sep 24, 2015 at 2:20 AM, Peter Chen wrote: >> > On Wed, Sep 23, 2015 at 12:40:46PM +0100, Felipe Tonello wrote: >> >> Hi Peter, >> >> >> >> On Wed, Sep 23, 2015 at 8:09

Re: Problems with printk logs and my driver

On Fri, 25 Sep 2015, Felipe Tonello wrote: > Maybe a better description on Kconfig and/or comments on source code > it's enough. I personally find the current Kconfig description: === config USB_KBD tristate "USB HIDBP Keyboard (simple Boot) support" depends on USB && INPUT

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

On Tue, Sep 15, 2015 at 6:50 PM, Felipe Balbi wrote: > Hi, > > On Tue, Sep 15, 2015 at 06:41:55PM +0200, Peter Senna Tschudin wrote: >> On Tue, Sep 15, 2015 at 4:33 PM, Felipe Balbi wrote: >> > On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote: >> >> On Mon, Sep 14, 2015 at 5:0

[PATCH 07/23] usb-gadget/f_loopback: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_loopback.c | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/drivers/usb/gadget/function/f_loopback.c b/drivers/usb/gadget/function/f_loopback.c index 6e2fe63..d4ef421 100644 -

[PATCH 05/23] usb-gadget/f_acm: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_acm.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/usb/gadget/function/f_acm.c b/drivers/usb/gadget/function/f_acm.c index be9df09..68b289f 100644 --- a/drivers/usb/gadge

[PATCH 04/23] usb-gadget/f_hid: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_hid.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c index 6df9715..d15b061 100644 --- a/drivers/

[PATCH 11/23] usb-gadget/f_mass_storage: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_mass_storage.c | 123 ++- 1 file changed, 46 insertions(+), 77 deletions(-) diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c index a6eb537..db71ae9

[PATCH 23/23] configfs: remove old API

Remove the old show_attribute and store_attribute methods and update the documentation. Also replace the two C samples with a single new one in the proper samples directory where people expect to find it. Signed-off-by: Christoph Hellwig --- Documentation/filesystems/Makefile |

[PATCH 22/23] ocfs2/cluster: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- fs/ocfs2/cluster/heartbeat.c | 205 +++ fs/ocfs2/cluster/nodemanager.c | 241 ++--- 2 files changed, 100 insertions(+), 346 deletions(-) diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2

[PATCH 14/23] usb-gadget/f_obex: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_obex.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/usb/gadget/function/f_obex.c b/drivers/usb/gadget/function/f_obex.c index 5460426..f6f1e6b 100644 --- a/drivers/usb/ga

[PATCH 16/23] usb-gadget/f_serial: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_serial.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/usb/gadget/function/f_serial.c b/drivers/usb/gadget/function/f_serial.c index 1d162e2..ec837f4 100644 --- a/drivers/

[PATCH 15/23] usb-gadget/f_phonet: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_phonet.c | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/usb/gadget/function/f_phonet.c b/drivers/usb/gadget/function/f_phonet.c index c0c3ef2..c029ef6 100644 --- a/drivers/u

[PATCH 20/23] netconsole: use per-attribute show and store methods

Note that the old code actually used the store_attributes method to do locking, this is moved into the individual methods. Signed-off-by: Christoph Hellwig --- drivers/net/netconsole.c | 269 +++ 1 file changed, 131 insertions(+), 138 deletions(-) dif

[PATCH 18/23] spear13xx_pcie_gadget: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/misc/spear13xx_pcie_gadget.c | 216 --- 1 file changed, 71 insertions(+), 145 deletions(-) diff --git a/drivers/misc/spear13xx_pcie_gadget.c b/drivers/misc/spear13xx_pcie_gadget.c index b8374cd..ee120dc 100644 --- a/dr

[PATCH 17/23] dlm: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- fs/dlm/config.c | 288 +++- 1 file changed, 74 insertions(+), 214 deletions(-) diff --git a/fs/dlm/config.c b/fs/dlm/config.c index d521bdd..8e294fb 100644 --- a/fs/dlm/config.c +++ b/fs/dlm/config.c @@ -61,

[PATCH 21/23] ocfs2/cluster: move locking into attribute store methods

The test and separate set bit scheme was racy to start with, so move to do a test_and_set_bit after doing the earlier error checks inside the actual store methods. Also remove the locking for the local attribute which already has a different scheme to synchronize. Signed-off-by: Christoph Hellwig

[PATCH 12/23] usb-gadget/f_ac1: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_uac1.c | 39 +++- 1 file changed, 16 insertions(+), 23 deletions(-) diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_uac1.c index 7856b33..ad01032 100644 --- a/dri

[PATCH 13/23] usb-gadget/f_uac2: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_uac2.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c index f8de7ea..0a5a1e1 100644 --- a/drivers/usb

[PATCH 09/23] usb-gadget/f_printer: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_printer.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c index 8e2b6be..29c90d5 100644 --- a

[PATCH 01/23] configfs: add show and store methods to struct configfs_attribute

Add methods to struct configfs_attribute to directly show and store attributes without adding boilerplate code to every user. In addition to the methods this also adds 3 helper macros to define read/write, read-only and write-only attributes with a single line of code. Signed-off-by: Christoph He

simplify configfs attributes

This series consolidates the code to implement configfs attributes by providing the ->show and ->store method in common code and using container_of in the methods to access the containing structure. This reduces source and binary size of configfs consumers a lot. -- To unsubscribe from this list:

[PATCH 06/23] usb-gadget/ether: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_ecm.c| 8 ++--- drivers/usb/gadget/function/f_eem.c| 8 ++--- drivers/usb/gadget/function/f_ncm.c| 8 ++--- drivers/usb/gadget/function/f_rndis.c | 8 ++--- drivers/usb/gadget/funct

[PATCH 10/23] usb-gadget/f_sourcesink: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_sourcesink.c | 88 -- 1 file changed, 36 insertions(+), 52 deletions(-) diff --git a/drivers/usb/gadget/function/f_sourcesink.c b/drivers/usb/gadget/function/f_sourcesink.c index cbfaf86..e5288c7 1006

[PATCH 08/23] usb-gadget/f_midi: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_midi.c | 37 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c index a287a48..0e2b8ed 100644 --- a/dri

[PATCH 03/23] usb-gadget/uvc: use per-attribute show and store methods

UVC is a little different from other configfs consumers in that it wants different function and field names from the exposed attribute name, so it keeps it's local macros to define attributes instead of using the common ones. Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/uvc_c

[PATCH 02/23] usb-gadget: use per-attribute show and store methods

Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/configfs.c | 295 ++-- include/linux/usb/gadget_configfs.h | 19 +-- 2 files changed, 118 insertions(+), 196 deletions(-) diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c inde

Re: simplify configfs attributes

Any I promised to Cc Pantelis when posting this for his binary attribute work but failed to do. I'm very sorry for that and blame in on the lack of sleep. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: Overly conservative xHCI bandwidth estimation

On Fri, 25 Sep 2015, Steinar H. Gunderson wrote: > On Fri, Sep 25, 2015 at 12:42:22AM +0200, Steinar H. Gunderson wrote: > > I downgraded to Debian's 3.16 kernel. Both cards came up without a hitch. > > But I only seem to get frames back from the second one. > > ...and after a quick app fix, I ha

Re: [PATCH 01/23] configfs: add show and store methods to struct configfs_attribute

Hello, Christoph. On Fri, Sep 25, 2015 at 06:49:38AM -0700, Christoph Hellwig wrote: > Add methods to struct configfs_attribute to directly show and store > attributes without adding boilerplate code to every user. In addition > to the methods this also adds 3 helper macros to define read/write,

Re: Problems with printk logs and my driver

On 2015-09-25 08:02, Jiri Kosina wrote: On Fri, 25 Sep 2015, Felipe Tonello wrote: Maybe a better description on Kconfig and/or comments on source code it's enough. I personally find the current Kconfig description: === config USB_KBD tristate "USB HIDBP Keyboard (simple Boot) suppo

[PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big endian 64 bit systems. There are no such platforms yet, but the code needs to be robust for such a case. Fix that by passing a local variable to deb

[PATCH V4 2/2] debugfs: Pass bool pointer to debugfs_create_bool()

Its a bit odd that debugfs_create_bool() takes 'u32 *' as an argument, when all it needs is a boolean pointer. It would be better to update this API to make it accept 'bool *' instead, as that will make it more consistent and often more convenient. Over that bool takes just a byte (mostly). That

Re: [PATCH 01/23] configfs: add show and store methods to struct configfs_attribute

On Fri, Sep 25, 2015 at 10:28:57AM -0400, Tejun Heo wrote: > Hello, Christoph. > > On Fri, Sep 25, 2015 at 06:49:38AM -0700, Christoph Hellwig wrote: > > Add methods to struct configfs_attribute to directly show and store > > attributes without adding boilerplate code to every user. In addition >

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On Fri, 2015-09-25 at 09:41 -0700, Viresh Kumar wrote: > Signed-off-by: Viresh Kumar > --- > V3->V4: > - Create a local variable instead of changing type of global_lock > (Rafael) Err, surely that wasn't what Rafael meant, since it's clearly impossible to use a pointer to the stack, assign to

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On 25-09-15, 19:42, Johannes Berg wrote: > On Fri, 2015-09-25 at 09:41 -0700, Viresh Kumar wrote: > > > Signed-off-by: Viresh Kumar > > --- > > V3->V4: > > - Create a local variable instead of changing type of global_lock > > (Rafael) > > Err, surely that wasn't what Rafael meant, since it's c

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

> Rafael wrote: > > Actually, what about adding a local u32 variable, say val, here and > > doing > > > > > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 > > > *)&first_ec->gpe)) > > > goto error; > > > if (!debugfs_create_bool("use_global_lock", 0444, > > > dev_dir, > > > -

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On 25-09-15, 20:49, Johannes Berg wrote: > Ok, then, but that means Rafael is completely wrong ... > debugfs_create_bool() takes a *pointer* and it needs to be long-lived, > it can't be on the stack. You also don't get a call when it changes. Ahh, ofcourse. My bad as well... I think we can change

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On Friday, September 25, 2015 09:41:37 AM Viresh Kumar wrote: > global_lock is defined as an unsigned long and accessing only its lower > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > for big endian 64 bit systems. There are no such platforms yet, but the > code needs to b

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On Friday, September 25, 2015 10:18:13 PM Rafael J. Wysocki wrote: > On Friday, September 25, 2015 09:41:37 AM Viresh Kumar wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > > for big endian

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On Friday, September 25, 2015 11:52:56 AM Viresh Kumar wrote: > On 25-09-15, 20:49, Johannes Berg wrote: > > Ok, then, but that means Rafael is completely wrong ... > > debugfs_create_bool() takes a *pointer* and it needs to be long-lived, > > it can't be on the stack. You also don't get a call whe

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On Friday, September 25, 2015 10:26:22 PM Rafael J. Wysocki wrote: > On Friday, September 25, 2015 11:52:56 AM Viresh Kumar wrote: > > On 25-09-15, 20:49, Johannes Berg wrote: > > > Ok, then, but that means Rafael is completely wrong ... > > > debugfs_create_bool() takes a *pointer* and it needs to

Re: Overly conservative xHCI bandwidth estimation

On Fri, Sep 25, 2015 at 10:26:23AM -0400, Alan Stern wrote: >> Does this mean I have a long bisect ahead of me? > In the absence of any better suggestions, that's the most > straightforward way to get an answer. Three hours of bisecting (actually three bisects; I found a git bug along the way :-/

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On 25 September 2015 at 13:33, Rafael J. Wysocki wrote: > You're going to change that into bool in the next patch, right? Yeah. > So what if bool is a byte and the field is not word-aligned Its between two 'unsigned long' variables today, and the struct isn't packed. So, it will be aligned, isn

Re: PROBLEM: lsusb -v freezes kernel on Acer ES1-111M

Hi Alan, > (I still think it's the BIOS's fault.) You're spot on, and the keyboard doesn't have enough special characters to express my feelings. (@$#!§*) I created a bootable USB stick with the Xubuntu 15.04 installer. When booting in legacy BIOS mode... > lspci 00:00.0 Host bridge: Intel Corp

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On Friday, September 25, 2015 01:25:49 PM Viresh Kumar wrote: > On 25 September 2015 at 13:33, Rafael J. Wysocki wrote: > > You're going to change that into bool in the next patch, right? > > Yeah. > > > So what if bool is a byte and the field is not word-aligned > > Its between two 'unsigned l

Re: PROBLEM: lsusb -v freezes kernel on Acer ES1-111M

On Fri, 25 Sep 2015, Roland Weber wrote: > Hi Alan, > > > (I still think it's the BIOS's fault.) > > You're spot on, and the keyboard doesn't have enough special characters > to express my feelings. (@$#!§*) > > I created a bootable USB stick with the Xubuntu 15.04 installer. > When booting in

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On 25-09-15, 22:58, Rafael J. Wysocki wrote: > Say you have three adjacent fields in a structure, x, y, z, each one byte > long. > Initially, all of them are equal to 0. > > CPU A writes 1 to x and CPU B writes 2 to y at the same time. > > What's the result? But then two CPUs can update the sam

Re: First kernel patch (optimization)

Hi Erik, > > Yeah, I'm still reading this email thread and learned lots from it. > I'm working on something more meaningful, but it's not going to be > ground breaking of course, there is a led on my capslock key on a new > machine I won at work that does not switch off properly after it is > swit

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

On Fri, Sep 25, 2015 at 11:44 PM, Viresh Kumar wrote: > On 25-09-15, 22:58, Rafael J. Wysocki wrote: >> Say you have three adjacent fields in a structure, x, y, z, each one byte >> long. >> Initially, all of them are equal to 0. >> >> CPU A writes 1 to x and CPU B writes 2 to y at the same time.