Re: First kernel patch (optimization)

2015-09-18 Thread Greg KH
On Thu, Sep 17, 2015 at 11:12:51PM -0400, Theodore Ts'o wrote: > On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: > > > > That isn't true. It helps the submitter understand the workflow and > > expectations. What you meant to say is that it doesn't help you. > > > The problem is tha

Re: [PATCH] usb: renesas_usbhs: Add support for R-Car H3

2015-09-18 Thread Kuninori Morimoto
Hi Shimoda-san > This patch adds a compatible string to support for R-Car H3. > > Since the HS-USB controller of R-Car H3 is almost the same specification > with R-Car Gen2 (these have 16 pipes and usb-dmac), this patch > sets the "type" of renesas_usbhs_driver_param to USBHS_TYPE_RCAR_GEN2. >

[GIT PULL] USB chipidea fixes for v4.3-rc2

2015-09-18 Thread Peter Chen
The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git/ tags/usb-ci-v4.3-rc2 for you to fetch changes up to 8315b77d72c5f

Re: USB bug

2015-09-18 Thread Clemens Ladisch
Andrew Gillis wrote: > Sep 17 10:07:38 sonicorbiter kernel: xhci_hcd :06:00.0: ERROR: unexpected > command completion code 0x11. This means that the USB controller does not like what the controller driver has told it to do. This could be a bug in some driver, but if it happens only with that

Re: First kernel patch (optimization)

2015-09-18 Thread Raymond Jennings
On 09/18/15 00:42, Greg KH wrote: On Thu, Sep 17, 2015 at 11:12:51PM -0400, Theodore Ts'o wrote: On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: That isn't true. It helps the submitter understand the workflow and expectations. What you meant to say is that it doesn't help you. Th

Re: USB client crash on Vybrid with USB gadget RNDIS connection

2015-09-18 Thread Felipe Tonello
Hi Peter, On Fri, Sep 18, 2015 at 6:39 AM, Peter Chen wrote: > On Wed, Sep 16, 2015 at 02:48:50PM +0530, maitysancha...@gmail.com wrote: >> On 15-09-16 15:54:21, Peter Chen wrote: >> > On Wed, Sep 16, 2015 at 02:18:49PM +0530, maitysancha...@gmail.com wrote: >> > > Hello Peter, >> > > >> > > > >>

Re: MIDI gadget allocating too much from coherent pool

2015-09-18 Thread Felipe Tonello
After some debugging, here is where I am: The crash trace is like this: (f_midi.c) -> ALSA calls f_midi_in_trigger() ->tasklet_hi_schedule(&midi->tasklet) -> f_midi_transmit(midi, NULL) the NULL here causes the f_midi to request a usb_request allocation, also it sets req->complete (which is

Re: [RFC][PATCH] Add spurious wakeup quirk for Lynxpoint controllers

2015-09-18 Thread Mathias Nyman
On 10.09.2015 20:27, Laura Abbott wrote: We received several reports of systems rebooting and powering on after an attempted shutdown. Testing showed that setting XHCI_SPURIOUS_WAKEUP quirk in addition to the XHCI_SPURIOUS_REBOOT quirk allowed the system to shutdown as expected for Lynxpoint xHC

Re: USB client crash on Vybrid with USB gadget RNDIS connection

2015-09-18 Thread maitysanchayan
On 15-09-18 13:39:11, Peter Chen wrote: > On Wed, Sep 16, 2015 at 02:48:50PM +0530, maitysancha...@gmail.com wrote: > > On 15-09-16 15:54:21, Peter Chen wrote: > > > On Wed, Sep 16, 2015 at 02:18:49PM +0530, maitysancha...@gmail.com wrote: > > > > Hello Peter, > > > > > > > > > > > > > > Enable C

Re: [RFC][PATCH] Add spurious wakeup quirk for Lynxpoint controllers

2015-09-18 Thread Oliver Neukum
On Fri, 2015-09-18 at 13:18 +0300, Mathias Nyman wrote: > Better ask Oliver, > Do you still have access to the HP laptop? No I am sorry, we no longer have those laptops. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: xhci_hcd: unstable communication with Opella-XD JTAG probe

2015-09-18 Thread Mathias Nyman
On 16.09.2015 00:06, Alexey Brodkin wrote: Hi Mathias, On Tue, 2015-09-15 at 16:18 +0300, Mathias Nyman wrote: On 10.09.2015 14:54, Alexey Brodkin wrote: I'm not sure what happens here, have you tried the 4.2 kernel? I've just tried vanilla 4.3-rc1 and see exactly the same picture. If I

Re: MIDI gadget allocating too much from coherent pool

2015-09-18 Thread Felipe Balbi
On Fri, Sep 18, 2015 at 11:03:26AM +0100, Felipe Tonello wrote: > After some debugging, here is where I am: > > The crash trace is like this: > > (f_midi.c) > -> ALSA calls f_midi_in_trigger() > ->tasklet_hi_schedule(&midi->tasklet) > -> f_midi_transmit(midi, NULL) the NULL here causes the

Re: [PATCH] usb: gadget: atmel: remove useless include

2015-09-18 Thread Nicolas Ferre
Le 10/08/2015 16:29, Alexandre Belloni a écrit : > Definitions from linux/platform_data/atmel.h are not used, remove the > include. > > Signed-off-by: Alexandre Belloni Acked-by: Nicolas Ferre > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --g

[PATCH 2/9] xhci: give command abortion one more chance before killing xhci

2015-09-18 Thread Mathias Nyman
We want to give the command abortion an additonal try to stop the command ring before we completely hose xhci. Tested-by: Vincent Pelletier Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/host/xhci-ring.c b/d

[PATCH 6/9] usb: xhci: stop everything on the first call to xhci_stop

2015-09-18 Thread Mathias Nyman
From: Roger Quadros xhci_stop will be called twice, once for the shared hcd and again for the primary hcd. We stop the XHCI controller in any case so clean up everything on the first call else we can timeout waiting for pending requests to complete. Signed-off-by: Roger Quadros Signed-off-by:

[PATCH 8/9] xhci: change xhci 1.0 only restictions to support xhci 1.1

2015-09-18 Thread Mathias Nyman
Some changes between xhci 0.96 and xhci 1.0 specifications forced us to check the hci version in code, some of these checks were implemented as hci_version == 1.0, which will not work with new xhci 1.1 controllers. xhci 1.1 behaves similar to xhci 1.0 in these cases, so change these checks to hci_

[PATCH 3/9] xhci: Move xhci_pme_quirk() behind #ifdef CONFIG_PM

2015-09-18 Thread Mathias Nyman
From: Tomer Barletz xhci_pme_quirk() is only used when CONFIG_PM is defined. compiling a kernel without PM complains about this function [reworded commit message -Mathias] Signed-off-by: Tomer Barletz Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-pci.c | 90 ++

[PATCH 7/9] usb: xhci: exit early in xhci_setup_device() if we're halted or dying

2015-09-18 Thread Mathias Nyman
From: Roger Quadros During quick plug/removal of OTG adapter during dual-role testing it can happen that xhci_alloc_device() is called for the newly detected device after the DRD library has called xhci_stop to remove the HCD. If that is the case, just fail early to prevent the following warning

[PATCH 5/9] usb: xhci: Clear XHCI_STATE_DYING on start

2015-09-18 Thread Mathias Nyman
From: Roger Quadros For whatever reason if XHCI died in the previous instant then it will never recover on the next xhci_start unless we clear the DYING flag. Signed-off-by: Roger Quadros Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 dele

[PATCH 0/9] xhci fixes for usb-linus, including a small usb core fix

2015-09-18 Thread Mathias Nyman
Hi Greg This series contain one usb core fix that makes sure we don't use bmAttribute bits that were reseved 0 in usb 3 specification. These bits are taken into use in USB 3.1, and we want to make sure usb 3.1 devices don't mess up calculations. The xhci fixes are mostly minor ones, except for th

[PATCH 4/9] usb: xhci: lock mutex on xhci_stop

2015-09-18 Thread Mathias Nyman
From: Roger Quadros Else it races with xhci_setup_device Signed-off-by: Roger Quadros Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 6b0f4a4..f560c41 100644 --- a/drivers/

[PATCH 1/9] usb: Use the USB_SS_MULT() macro to get the burst multiplier.

2015-09-18 Thread Mathias Nyman
Bits 1:0 of the bmAttributes are used for the burst multiplier. The rest of the bits used to be reserverd (zero), but USB3.1 takes bit 7 into use. Use the existing USB_SS_MULT() macro instead to make sure the mult value and hence max packet calculations are correct for USB3.1 devices. Note that b

[PATCH 9/9] xhci: init command timeout timer earlier to avoid deleting it before init

2015-09-18 Thread Mathias Nyman
Don't check if timer is running with a timer_pending() before deleting it with del_timer_sync(), this defies the whole point of the sync part and can cause a possible race. Instead we just want to make sure the timer is initialized early enough before we have a chance to delete it. Reported-by:

Re: [PATCH] usb: gadget: at91_udc: move at91_udc_data in at91_udc.h

2015-09-18 Thread Nicolas Ferre
Le 10/08/2015 16:46, Alexandre Belloni a écrit : > struct at91_udc_data is now only used inside the driver, move it to its > include. > > Signed-off-by: Alexandre Belloni Acked-by: Nicolas Ferre Thanks. > --- > drivers/usb/gadget/udc/at91_udc.h | 8 > include/linux/platform_data/a

Re: [PATCH v2] USB: EHCI: fix dereference of ERR_PTR

2015-09-18 Thread Alan Stern
On Fri, 18 Sep 2015, Sudip Mukherjee wrote: > On Wed, Sep 16, 2015 at 12:54:03PM -0400, Alan Stern wrote: > > On Wed, 16 Sep 2015, Sudip Mukherjee wrote: > > > > > On error find_tt() returns either a NULL pointer or the error value in > > > ERR_PTR. But we were dereferencing it directly without e

[PATCH] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

2015-09-18 Thread Nicolas Ferre
From: Sylvain Rochet The recently added endpoint capabilities flags verification breaks Atmel USBA because the endpoint configuration was only added when the driver is bound using the legacy pdata interface. Convert endpoint configuration to new capabilities model when driver is bound to a devic

Re: [PATCH] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

2015-09-18 Thread Felipe Balbi
On Fri, Sep 18, 2015 at 04:58:28PM +0200, Nicolas Ferre wrote: > From: Sylvain Rochet > > The recently added endpoint capabilities flags verification breaks Atmel > USBA because the endpoint configuration was only added when the driver > is bound using the legacy pdata interface. > > Convert end

[RFT PATCH] xhci: don't finish a TD if we get a short transfer event mid TD

2015-09-18 Thread Mathias Nyman
If the difference is big enough between the bytes asked and received in a bulk tranfer we can get a short transfer event pointing to a TRB in the middle of the TD. We don't want to handle the TD yet as we will anyway receive a new event for the last TRB in the TD. Hold off removing TD from list an

Re: MIDI gadget allocating too much from coherent pool

2015-09-18 Thread Felipe Tonello
Hi Balbi, On Fri, Sep 18, 2015 at 3:25 PM, Felipe Balbi wrote: > On Fri, Sep 18, 2015 at 11:03:26AM +0100, Felipe Tonello wrote: >> After some debugging, here is where I am: >> >> The crash trace is like this: >> >> (f_midi.c) >> -> ALSA calls f_midi_in_trigger() >> ->tasklet_hi_schedule(&midi-

Re: MIDI gadget allocating too much from coherent pool

2015-09-18 Thread Felipe Balbi
Hi, On Fri, Sep 18, 2015 at 04:53:09PM +0100, Felipe Tonello wrote: > Hi Balbi, > > On Fri, Sep 18, 2015 at 3:25 PM, Felipe Balbi wrote: > > On Fri, Sep 18, 2015 at 11:03:26AM +0100, Felipe Tonello wrote: > >> After some debugging, here is where I am: > >> > >> The crash trace is like this: > >>

[PATCH] usb: chipidea: udc: improve error handling on ep_queue and f_midi

2015-09-18 Thread eu
From: "Felipe F. Tonello" _ep_queue() didn't check for errors when using add_td_to_list() which can fail if dma_pool_alloc fails, thus causing a kernel panic when lastnode->ptr is NULL. Also f_midi is not checking weather the is an error on usb_ep_queue request, ignoring potential problems, such

Re: MIDI gadget allocating too much from coherent pool

2015-09-18 Thread Felipe Tonello
Balbi, On Fri, Sep 18, 2015 at 5:02 PM, Felipe Balbi wrote: > Hi, > > On Fri, Sep 18, 2015 at 04:53:09PM +0100, Felipe Tonello wrote: >> Hi Balbi, >> >> On Fri, Sep 18, 2015 at 3:25 PM, Felipe Balbi wrote: >> > On Fri, Sep 18, 2015 at 11:03:26AM +0100, Felipe Tonello wrote: >> >> After some debu

Re: [PATCH 1/9] usb: Use the USB_SS_MULT() macro to get the burst multiplier.

2015-09-18 Thread Greg KH
On Fri, Sep 18, 2015 at 05:42:05PM +0300, Mathias Nyman wrote: > Bits 1:0 of the bmAttributes are used for the burst multiplier. > The rest of the bits used to be reserverd (zero), but USB3.1 takes bit 7 > into use. > > Use the existing USB_SS_MULT() macro instead to make sure the mult value > and

Re: [PATCH 8/9] xhci: change xhci 1.0 only restictions to support xhci 1.1

2015-09-18 Thread Greg KH
On Fri, Sep 18, 2015 at 05:42:12PM +0300, Mathias Nyman wrote: > Some changes between xhci 0.96 and xhci 1.0 specifications forced us to > check the hci version in code, some of these checks were implemented as > hci_version == 1.0, which will not work with new xhci 1.1 controllers. > > xhci 1.1 b

Re: [PATCH 0/9] xhci fixes for usb-linus, including a small usb core fix

2015-09-18 Thread Greg KH
On Fri, Sep 18, 2015 at 05:42:04PM +0300, Mathias Nyman wrote: > Hi Greg > > This series contain one usb core fix that makes sure we don't > use bmAttribute bits that were reseved 0 in usb 3 specification. > These bits are taken into use in USB 3.1, and we want to make sure > usb 3.1 devices don't

Re: [GIT PULL] USB chipidea fixes for v4.3-rc2

2015-09-18 Thread Greg KH
On Fri, Sep 18, 2015 at 03:54:31PM +0800, Peter Chen wrote: > The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: > > Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/us

Re: [RFC][PATCH] Add spurious wakeup quirk for Lynxpoint controllers

2015-09-18 Thread Laura Abbott
On 09/18/2015 03:18 AM, Mathias Nyman wrote: On 10.09.2015 20:27, Laura Abbott wrote: We received several reports of systems rebooting and powering on after an attempted shutdown. Testing showed that setting XHCI_SPURIOUS_WAKEUP quirk in addition to the XHCI_SPURIOUS_REBOOT quirk allowed the sy

Re: [PATCH] usb: chipidea: udc: improve error handling on ep_queue and f_midi

2015-09-18 Thread Felipe Balbi
Hi, On Fri, Sep 18, 2015 at 05:48:45PM +0100, e...@felipetonello.com wrote: > From: "Felipe F. Tonello" > > _ep_queue() didn't check for errors when using add_td_to_list() > which can fail if dma_pool_alloc fails, thus causing a kernel > panic when lastnode->ptr is NULL. > > Also f_midi is not

[PATCH 1/2] usb: chipidea: udc: improve error handling on ep_queue

2015-09-18 Thread eu
From: "Felipe F. Tonello" _ep_queue() didn't check for errors when using add_td_to_list() which can fail if dma_pool_alloc fails, thus causing a kernel panic when lastnode->ptr is NULL. Signed-off-by: Felipe F. Tonello --- drivers/usb/chipidea/udc.c | 26 +++--- 1 file chan

[PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-18 Thread eu
From: "Felipe F. Tonello" f_midi is not checking weather the is an error on usb_ep_queue request, ignoring potential problems, such as memory leaks. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff

Re: [PATCH 1/2] usb: chipidea: udc: improve error handling on ep_queue

2015-09-18 Thread Felipe Balbi
Hi, On Fri, Sep 18, 2015 at 06:12:40PM +0100, e...@felipetonello.com wrote: > From: "Felipe F. Tonello" > > _ep_queue() didn't check for errors when using add_td_to_list() > which can fail if dma_pool_alloc fails, thus causing a kernel > panic when lastnode->ptr is NULL. > > Signed-off-by: Feli

[PATCH 0/2] improve error handling on chipidea/udc.c and f_midi.c

2015-09-18 Thread eu
From: "Felipe F. Tonello" Felipe F. Tonello (2): usb: chipidea: udc: improve error handling on ep_queue usb: gadget: f_midi: check for error on usb_ep_queue drivers/usb/chipidea/udc.c | 26 +++--- drivers/usb/gadget/function/f_midi.c | 10 -- 2 files ch

Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-18 Thread Felipe Balbi
On Fri, Sep 18, 2015 at 06:12:41PM +0100, e...@felipetonello.com wrote: > From: "Felipe F. Tonello" > > f_midi is not checking weather the is an error on usb_ep_queue > request, ignoring potential problems, such as memory leaks. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/f

[PATCH 2/3] usb: chipidea: udc: improve error handling on ep_queue

2015-09-18 Thread eu
From: "Felipe F. Tonello" _ep_queue() didn't check for errors when using add_td_to_list() which can fail if dma_pool_alloc fails, thus causing a kernel panic when lastnode->ptr is NULL. Signed-off-by: Felipe F. Tonello --- Changes for v2: - Use separate patch for cleanups. drivers/usb/chip

[PATCH 1/3] usb: chipidea: udc: _ep_queue and _hw_queue cleanup

2015-09-18 Thread eu
From: "Felipe F. Tonello" Update comments to reflect current state of functions. Signed-off-by: Felipe F. Tonello --- Changes for v2: - Introduced this patch. drivers/usb/chipidea/udc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b

Re: [PATCH 1/2] usb: chipidea: udc: improve error handling on ep_queue

2015-09-18 Thread Felipe Tonello
Hi Felipe, On Fri, Sep 18, 2015 at 6:17 PM, Felipe Balbi wrote: > Hi, > > On Fri, Sep 18, 2015 at 06:12:40PM +0100, e...@felipetonello.com wrote: >> From: "Felipe F. Tonello" >> >> _ep_queue() didn't check for errors when using add_td_to_list() >> which can fail if dma_pool_alloc fails, thus cau

[PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-18 Thread eu
From: "Felipe F. Tonello" f_midi is not checking weather the is an error on usb_ep_queue request, ignoring potential problems, such as memory leaks. Signed-off-by: Felipe F. Tonello --- Changes for v2: - Update code style. drivers/usb/gadget/function/f_midi.c | 12 +--- 1 file chan

Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-18 Thread Felipe Tonello
On Fri, Sep 18, 2015 at 6:30 PM, wrote: > From: "Felipe F. Tonello" > > f_midi is not checking weather the is an error on usb_ep_queue > request, ignoring potential problems, such as memory leaks. > > Signed-off-by: Felipe F. Tonello > --- > > Changes for v2: > - Update code style. > > drive

[PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-18 Thread eu
From: "Felipe F. Tonello" f_midi is not checking whether there is an error on usb_ep_queue request, ignoring potential problems, such as memory leaks. Signed-off-by: Felipe F. Tonello --- Changes for v2: - Update code style. Changes for v3: - Use ip_ep instead of out_ep. Fixed typo in com

[PATCH 0/4] usb: host: Fix module autoload for OF platform drivers

2015-09-18 Thread Luis de Bethencourt
Hi, These patches add the missing MODULE_DEVICE_TABLE() for OF to export the information so modules have the correct aliases built-in and autoloading works correctly. A longer explanation by Javier Canillas can be found here: https://lkml.org/lkml/2015/7/30/519 Thanks, Luis Luis de Bethencourt

[PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

2015-09-18 Thread Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/usb/host/ehci-spear.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/

[PATCH 2/4] usb: host: fsl-mph-dr-of: Fix module autoload for OF platform driver

2015-09-18 Thread Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/usb/host/fsl-mph-dr-of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/driver

[PATCH 3/4] usb: host: ohci-spear: Fix module autoload for OF platform driver

2015-09-18 Thread Luis de Bethencourt
Signed-off-by: Luis de Bethencourt --- drivers/usb/host/ohci-spear.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c index 707437c..56478ed 100644 --- a/drivers/usb/host/ohci-spear.c +++ b/drivers/usb/host/ohci-spear.c @@ -161,6 +1

[PATCH 4/4] usb: host: uhci-platform: Fix module autoload for OF platform driver

2015-09-18 Thread Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/usb/host/uhci-platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/uhci-platform.c b/driver

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-18 Thread Felipe Balbi
On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > This amd5536udc was a complete mess. The major problems that i could > find are: > > 1) if udc_pci_probe() fails in any stage then it just calls the > udc_pci_remove() to handle error. And udc_pci_remove() works with > struct udc *

Re: [PATCH v2 1/3] usb: of: add an api to get dr_mode by the phy node

2015-09-18 Thread Felipe Balbi
On Tue, Sep 15, 2015 at 01:58:16PM -0500, Bin Liu wrote: > Some USB phy drivers have different handling for the controller in each > dr_mode. But the phy driver does not have visibility to the dr_mode of > the controller. > > This adds an api to return the dr_mode of the controller which > associa

Re: [PATCH v2 1/3] usb: of: add an api to get dr_mode by the phy node

2015-09-18 Thread Bin Liu
Hi, On 09/18/2015 01:41 PM, Felipe Balbi wrote: On Tue, Sep 15, 2015 at 01:58:16PM -0500, Bin Liu wrote: Some USB phy drivers have different handling for the controller in each dr_mode. But the phy driver does not have visibility to the dr_mode of the controller. This adds an api to return the

Re: [PATCH v3] usb: dwc2: Use platform endianness when accessing registers

2015-09-18 Thread Felipe Balbi
On Thu, Aug 27, 2015 at 12:10:24AM +, John Youn wrote: > On 8/20/2015 11:43 AM, Antti Seppälä wrote: > > This patch switches calls to readl/writel to their > > dwc2_readl/dwc2_writel equivalents which preserve platform endianness. > > > > This patch is necessary to access dwc2 registers correc

Re: [PATCH v3] usb: dwc2: Use platform endianness when accessing registers

2015-09-18 Thread John Youn
On 9/18/2015 11:50 AM, Felipe Balbi wrote: > On Thu, Aug 27, 2015 at 12:10:24AM +, John Youn wrote: >> On 8/20/2015 11:43 AM, Antti Seppälä wrote: >>> This patch switches calls to readl/writel to their >>> dwc2_readl/dwc2_writel equivalents which preserve platform endianness. >>> >>> This patch

Re: [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

2015-09-18 Thread Alan Stern
On Fri, 18 Sep 2015, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- > drivers/usb/host/ehci-spear.c | 1 + > 1 file changed, 1 insertio

Re: [PATCH 3/4] usb: host: ohci-spear: Fix module autoload for OF platform driver

2015-09-18 Thread Alan Stern
On Fri, 18 Sep 2015, Luis de Bethencourt wrote: > Signed-off-by: Luis de Bethencourt > --- -ENODESCRIPTION Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/maj

Re: [PATCH v3] usb: dwc2: Use platform endianness when accessing registers

2015-09-18 Thread Felipe Balbi
On Fri, Sep 18, 2015 at 06:54:56PM +, John Youn wrote: > On 9/18/2015 11:50 AM, Felipe Balbi wrote: > > On Thu, Aug 27, 2015 at 12:10:24AM +, John Youn wrote: > >> On 8/20/2015 11:43 AM, Antti Seppälä wrote: > >>> This patch switches calls to readl/writel to their > >>> dwc2_readl/dwc2_writ

Re: First kernel patch (optimization)

2015-09-18 Thread Austin S Hemmelgarn
On 2015-09-18 05:31, Raymond Jennings wrote: On 09/18/15 00:42, Greg KH wrote: On Thu, Sep 17, 2015 at 11:12:51PM -0400, Theodore Ts'o wrote: On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: That isn't true. It helps the submitter understand the workflow and expectations. What you

Re: [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

2015-09-18 Thread Luis de Bethencourt
On Fri, Sep 18, 2015 at 02:57:10PM -0400, Alan Stern wrote: > On Fri, 18 Sep 2015, Luis de Bethencourt wrote: > > > This platform driver has a OF device ID table but the OF module > > alias information is not created so module autoloading won't work. > > > > Signed-off-by: Luis de Bethencourt >

Re: [PATCH v2 1/3] usb: of: add an api to get dr_mode by the phy node

2015-09-18 Thread Felipe Balbi
On Fri, Sep 18, 2015 at 01:45:56PM -0500, Bin Liu wrote: > Hi, > > On 09/18/2015 01:41 PM, Felipe Balbi wrote: > >On Tue, Sep 15, 2015 at 01:58:16PM -0500, Bin Liu wrote: > >>Some USB phy drivers have different handling for the controller in each > >>dr_mode. But the phy driver does not have visib

Re: [PATCH v2 1/3] usb: of: add an api to get dr_mode by the phy node

2015-09-18 Thread Bin Liu
Hi, On 09/18/2015 02:09 PM, Felipe Balbi wrote: On Fri, Sep 18, 2015 at 01:45:56PM -0500, Bin Liu wrote: Hi, On 09/18/2015 01:41 PM, Felipe Balbi wrote: On Tue, Sep 15, 2015 at 01:58:16PM -0500, Bin Liu wrote: Some USB phy drivers have different handling for the controller in each dr_mode. B

[PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

2015-09-18 Thread Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/usb/host/ehci-spear.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/

[PATCH] usb: dwc2: Use platform endianness when accessing registers

2015-09-18 Thread John Youn
From: Antti Seppälä This patch switches calls to readl/writel to their dwc2_readl/dwc2_writel equivalents which preserve platform endianness. This patch is necessary to access dwc2 registers correctly on big-endian systems such as the mips based SoCs made by Lantiq. Then dwc2 can be used to repl

Re: [PATCH v2 0/7] usb: usbtest misc changes

2015-09-18 Thread Felipe Balbi
Hi Greg, On Tue, Sep 01, 2015 at 09:47:57AM +0800, Peter Chen wrote: > Alan Stern (1): > usb: misc: usbtest: format the data pattern according to max packet > size > > Peter Chen (6): > usb: misc: usbtest: allocate size of urb array according to user > parameter > usb: misc: usbtest

Re: [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

2015-09-18 Thread Alan Stern
On Fri, 18 Sep 2015, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- > drivers/usb/host/ehci-spear.c | 1 + > 1 file changed, 1 insertio

Re: [PATCH 1/5] usb: common: of_usb_get_maximum_speed to usb_get_maximum_speed

2015-09-18 Thread Felipe Balbi
On Tue, Aug 25, 2015 at 02:04:31PM +0300, Heikki Krogerus wrote: > By using the unified device property interface, the function > can be made available for all platforms and not just the > ones using DT. > > Signed-off-by: Heikki Krogerus this breaks compilation of my current testing/next. --

[PATCH v3] usb: of: add an api to get dr_mode by the phy node

2015-09-18 Thread Bin Liu
Some USB phy drivers have different handling for the controller in each dr_mode. But the phy driver does not have visibility to the dr_mode of the controller. This adds an api to return the dr_mode of the controller which associates the given phy node. Signed-off-by: Bin Liu --- v3: search contr

Re: [RFC][PATCH] Add spurious wakeup quirk for Lynxpoint controllers

2015-09-18 Thread Oliver Neukum
On Fri, 2015-09-18 at 09:56 -0700, Laura Abbott wrote: > Would you rather see a revert of the patch you gave rather than a new > one re-introducing the flag? We need a big fat comment here saying that different tests should different results and the quirk is needed for LynxPoint. That suggests a n

Re: [PATCH 0/2] improve error handling on chipidea/udc.c and f_midi.c

2015-09-18 Thread Albino B Neto
2015-09-18 14:12 GMT-03:00 : > From: "Felipe F. Tonello" Signed-off-by ? Albino -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] improve error handling on chipidea/udc.c and f_midi.c

2015-09-18 Thread Felipe Balbi
On Fri, Sep 18, 2015 at 05:56:48PM -0300, Albino B Neto wrote: > 2015-09-18 14:12 GMT-03:00 : > > From: "Felipe F. Tonello" > > Signed-off-by ? this is not a patch -- balbi signature.asc Description: Digital signature

Re: First kernel patch (optimization)

2015-09-18 Thread Theodore Ts'o
On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: > So don't take cleanup patches for your code, that's fine, and I totally > understand why _you_ don't want to do that. But to blow off the effort > as being somehow trivial and not worthy of us, that's totally missing > the point, and makin

Re: [PATCH v3] usb: of: add an api to get dr_mode by the phy node

2015-09-18 Thread Felipe Balbi
Hi, On Fri, Sep 18, 2015 at 03:27:58PM -0500, Bin Liu wrote: > Some USB phy drivers have different handling for the controller in each > dr_mode. But the phy driver does not have visibility to the dr_mode of > the controller. > > This adds an api to return the dr_mode of the controller which > as

Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks

2015-09-18 Thread Sudip Mukherjee
On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > > This amd5536udc was a complete mess. The major problems that i could > > find are: > > > > 1) if udc_pci_probe() fails in any stage then it just calls the > > udc_pc

Re: First kernel patch (optimization)

2015-09-18 Thread Sudip Mukherjee
On Fri, Sep 18, 2015 at 10:26:24PM -0400, Theodore Ts'o wrote: > On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: > > Rather, what concerns me is that we aren't pushing people to go > *beyond* cleanup patches. We have lots of tutorials about how to > create perfectly formed patches; but we

Re: [PATCH v2 0/7] usb: usbtest misc changes

2015-09-18 Thread Greg KH
On Fri, Sep 18, 2015 at 02:30:09PM -0500, Felipe Balbi wrote: > Hi Greg, > > On Tue, Sep 01, 2015 at 09:47:57AM +0800, Peter Chen wrote: > > Alan Stern (1): > > usb: misc: usbtest: format the data pattern according to max packet > > size > > > > Peter Chen (6): > > usb: misc: usbtest: all

Re: [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

2015-09-18 Thread Greg Kroah-Hartman
On Fri, Sep 18, 2015 at 09:14:52PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- > drivers/usb/host/ehci-spear.c | 1 + > 1 file

Re: First kernel patch (optimization)

2015-09-18 Thread Greg KH
On Fri, Sep 18, 2015 at 10:26:24PM -0400, Theodore Ts'o wrote: > On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: > > So don't take cleanup patches for your code, that's fine, and I totally > > understand why _you_ don't want to do that. But to blow off the effort > > as being somehow triv