Re: [PATCH 2/3][v2] drivers: usb: dwc3: Add frame length adjustment quirk

2015-09-01 Thread Felipe Balbi
Hi, On Mon, Aug 17, 2015 at 09:54:56AM +0530, Nikhil Badola wrote: > +static void dwc3_frame_length_adjustment(struct dwc3 *dwc, u32 fladj) > +{ > + if (dwc->revision < DWC3_REVISION_250A) > + return; > + > + if (fladj == 0) > + return; > + > + if (fladj) { rig

Re: [PATCH] xhci: fix warning when CONFIG_PM disabled.

2015-09-01 Thread Mathias Nyman
On 01.09.2015 00:26, Dave Hansen wrote: From: Dave Hansen I have a .config with CONFIG_PM disabled. I get the following whenever compiling the xhci driver: drivers/usb/host/xhci-pci.c:192:13: warning: ‘xhci_pme_quirk’ defined but not used [-Wunused-function] Looks like we just need to m

RE: [PATCH 2/3][v2] drivers: usb: dwc3: Add frame length adjustment quirk

2015-09-01 Thread Badola Nikhil
> -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, September 01, 2015 12:51 PM > To: Badola Nikhil-B46172 > Cc: linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; linux- > o...@vger.kernel.org; ba...@ti.com; gre...@linuxfoundation.org > Subject: Re: [PAT

Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

2015-09-01 Thread Oliver Neukum
On Fri, 2015-08-28 at 11:09 +0300, Eugene Shatokhin wrote: > > Exactly what problem will that result in? The tasklet_kill() will > wait > > for the processing of the single element done queue, and everything > will > > be fine. Or? > > Given enough time, what prevents defer_bh() from calling >

Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

2015-09-01 Thread Oliver Neukum
On Mon, 2015-08-31 at 11:50 +0300, Eugene Shatokhin wrote: > > But I would have liked it much better if the code became simpler > instead > > of more complex. > > Me too, but I can see no other way here. The code is simpler without > locking, indeed, but locking is needed to prevent the problems

RE: [PATCH 1/2] usb: chipidea: add xilinx zynq platform data

2015-09-01 Thread Subbaraya Sundeep Bhatta
Hi, > -Original Message- > From: Peter Chen [mailto:peter.c...@freescale.com] > Sent: Monday, August 31, 2015 7:59 AM > To: Punnaiah Choudary Kalluri > Cc: Nathan Sullivan; sundeep subbaraya; Subbaraya Sundeep Bhatta; > robh...@kernel.org; pawel.m...@arm.com; Mark Rutland; > ijc+devicet...

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-09-01 Thread Sergei Shtylyov
On 8/31/2015 10:21 PM, Sergei Shtylyov wrote: From: Ville Syrjälä This reverts commit 8f2c9544aba636134303105ecb164190a39dece4. As it breaks g_ether on my Baytrail FFRD8 device. Everything starts out fine, but after a bit of data has been transferred it just stops flowing. Note that I do get

Re: [PATCH v6 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller

2015-09-01 Thread chunfeng yun
hi, On Sat, 2015-08-22 at 16:23 +0300, Sergei Shtylyov wrote: > Hello. > > On 8/22/2015 4:45 AM, Chunfeng Yun wrote: > > > add a DT binding documentation of xHCI host controller for the > > MT8173 SoC from Mediatek. > > > Signed-off-by: Chunfeng Yun > > --- > > .../devicetree/bindings/usb/mt

Re: [PATCH v7 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA

2015-09-01 Thread Mathias Nyman
On 31.08.2015 21:58, Duc Dang wrote: On Thu, Aug 20, 2015 at 12:38 PM, Duc Dang wrote: The xhci platform driver needs to work on systems that either only support 64-bit DMA or only support 32-bit DMA. Attempt to set a coherent dma mask for 64-bit DMA, and attempt again with 32-bit DMA if that f

Re: [PATCH v7 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA

2015-09-01 Thread Russell King - ARM Linux
On Tue, Sep 01, 2015 at 02:54:17PM +0300, Mathias Nyman wrote: > On 31.08.2015 21:58, Duc Dang wrote: > >On Thu, Aug 20, 2015 at 12:38 PM, Duc Dang wrote: > >>The xhci platform driver needs to work on systems that > >>either only support 64-bit DMA or only support 32-bit DMA. > >>Attempt to set a

Re: [PATCH v6 4/5] xhci: mediatek: support MTK xHCI host controller

2015-09-01 Thread chunfeng yun
On Wed, 2015-08-26 at 22:18 +0100, Daniel Thompson wrote: > On 22/08/15 02:45, Chunfeng Yun wrote: > > MTK xhci host controller defines some extra SW scheduling > > parameters for HW to minimize the scheduling effort for > > synchronous and interrupt endpoints. The parameters are > > put into resev

Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

2015-09-01 Thread Eugene Shatokhin
01.09.2015 10:58, Oliver Neukum пишет: On Mon, 2015-08-31 at 11:50 +0300, Eugene Shatokhin wrote: But I would have liked it much better if the code became simpler instead of more complex. Me too, but I can see no other way here. The code is simpler without locking, indeed, but locking is nee

[PATCH] usb: dwc3: gadget: move trace_dwc3_ep_queue()

2015-09-01 Thread Felipe Balbi
by moving trace_dwc3_ep_queue() from dwc3_gadget_ep_queue() to __dwc3_gadget_ep_queue() after usb_request is properly initialized, makes for a better output always showing a request with 0 actual and -115 (-EINPROGRESS) status. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 4 ++--

[PATCH] usbnet: Fix a race between usbnet_stop() and the BH

2015-09-01 Thread Eugene Shatokhin
The race may happen when a device (e.g. YOTA 4G LTE Modem) is unplugged while the system is downloading a large file from the Net. Hardware breakpoints and Kprobes with delays were used to confirm that the race does actually happen. The race is on skb_queue ('next' pointer) between usbnet_stop()

Re: [PATCH] usb: core: Fix side effect of clear port feature in hub port reset

2015-09-01 Thread Alan Stern
On Tue, 1 Sep 2015, hyunho747.kim wrote: > After successful port reset by set_port_feature, some devices show > immediate link connection which generates port connect change interrupt. > But, the next step is an unconditional usb_clear_port_feature > and this flow always clears USB_PORT_FEAT_C_CON

Re: [PATCH v2 1/7] usb: misc: usbtest: allocate size of urb array according to user parameter

2015-09-01 Thread Alan Stern
On Tue, 1 Sep 2015, Peter Chen wrote: > Allocate the size of urb pointer array according to testusb's > parameter sglen, and limits the length of sglen as MAX_SGLEN > (128 currently). > > Acked-by: Michal Nazarewicz > Signed-off-by: Peter Chen > --- > drivers/usb/misc/usbtest.c | 9 + >

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-09-01 Thread Ville Syrjälä
y reverting that commit you're just masking the real > > > > > problem > > > > > and I'd rather get that one fixed. > > > > > > > > > > How do you reproduce your issue ? > > > > > > > > Just boot the sys

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-09-01 Thread Felipe Balbi
ou're just masking the real > > > > > > problem > > > > > > and I'd rather get that one fixed. > > > > > > > > > > > > How do you reproduce your issue ? > > > > > > > > > > Just boo

Re: [RESEND PATCH 3/7] usb: phy: isp1301: Export I2C module alias information

2015-09-01 Thread Javier Martinez Canillas
Hello Greg and Felipe, On 08/25/2015 08:31 AM, Javier Martinez Canillas wrote: > The I2C core always reports the MODALIAS uevent as "i2c: regardless if the driver was matched using the I2C id_table or the > of_match_table. So the driver needs to export the I2C table and this > be built into the mo

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-09-01 Thread Ville Syrjälä
> > > > > > > and I'd rather get that one fixed. > > > > > > > > > > > > > > How do you reproduce your issue ? > > > > > > > > > > > > Just boot the system, it gets an IP from dnsmas

Re: PROBLEM: lsusb -v freezes kernel on Acer ES1-111M

2015-09-01 Thread Roland Weber
Hello Alan, > You can try the debugging patch below. It will tell us when the items > on the workqueue get executed, which could be a useful clue. You > should test this from a VT console with the logging level set high > enough so that the log messages show up on the screen. No luck. I've boot

[PATCH 3/5] USB: io_ti: Move download and boot mode code out of download_fw

2015-09-01 Thread Peter E. Berger
From: "Peter E. Berger" Separate the download and boot mode code from download_fw() into two new helper functions: do_download_mode() and do_boot_mode(), and fix formatting in some of the comments. Signed-off-by: Peter E. Berger --- drivers/usb/serial/io_ti.c | 111

[PATCH 2/5] USB: io_ti: use serial->interface for messages in download_fw

2015-09-01 Thread Peter E. Berger
From: "Peter E. Berger" Use serial->interface instead of serial->dev for messages in download_fw(). Signed-off-by: Peter E. Berger --- drivers/usb/serial/io_ti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c index fc

[PATCH 1/5] USB: io_ti: Remove obsolete dev argument from build_i2c_fw_hdr

2015-09-01 Thread Peter E. Berger
From: "Peter E. Berger" Remove unused "dev" argument from build_i2c_fw_hdr() and its caller. Signed-off-by: Peter E. Berger --- drivers/usb/serial/io_ti.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c index 0ac1

[PATCH 4/5] USB: io_ti: Remove leading tabs in do_download_mode

2015-09-01 Thread Peter E. Berger
From: "Peter E. Berger" Remove leading tabs in do_download_mode and fixup problems flagged by checkpatch.pl Signed-off-by: Peter E. Berger --- drivers/usb/serial/io_ti.c | 314 +++-- 1 file changed, 162 insertions(+), 152 deletions(-) diff --git a/drive

[PATCH 5/5] USB: io_ti: Move request_firmware from edge_startup to download_fw

2015-09-01 Thread Peter E. Berger
From: "Peter E. Berger" Move request_firmware from edge_startup to download_fw Signed-off-by: Peter E. Berger --- drivers/usb/serial/io_ti.c | 56 -- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers

[PATCH 0/5] USB: io_ti: Cleanup download_fw and related functions

2015-09-01 Thread Peter E. Berger
From: "Peter E. Berger" While working on a previous patchset for this driver [1] we were hampered by the fact that download_fw() is very long and its return paths are so complicated that we were compelled to the put the request_firmware() call in edge_startup(), when it much more naturally belong

RE: [PATCH v2 1/7] usb: misc: usbtest: allocate size of urb array according to user parameter

2015-09-01 Thread Peter Chen
> > --- > > drivers/usb/misc/usbtest.c | 9 + > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c > > index 9517812..8f294d7 100644 > > --- a/drivers/usb/misc/usbtest.c > > +++ b/drivers/usb/misc/usbtest.c > > @

[RFC PATCH 1/1] usb: misc: usbtest: add bulk queue test

2015-09-01 Thread Peter Chen
The bulk queue tests are used to show 'best performance' for bulk transfer, we are often asked this question by users. It's result should be very close to IC simulation, in order to get that, the device side should also need to prepare enough queue. We have got the 'best performance' (IN: ~41MB,