Re: [PATCH v3 0/5] ARM: dts: OMAP2+: Enable USB dual-role on supported boards

2015-08-04 Thread Tony Lindgren
* Roger Quadros [150727 02:30]: > Tony, > > On 21/07/15 13:54, Tony Lindgren wrote: > > * Roger Quadros [150708 03:45]: > >> Hi, > >> > >> Enables dual-role feaure on supported boards. > >> > >> Depends on > >> [1] - core USB DRD support - > >> http://thread.gmane.org/gmane.linux.kernel/1991413

[PATCH v2] usb: ehci-platform: Fix using multiple controllers from OF

2015-08-04 Thread Alban Bedel
When using OF defined controllers the platform data struct is shared between all devices, so it can't be used for device specific settings. However it is currently used for the OF properties needs-reset-on-resume and has-transaction-translator. To fix this issue move setting hcd->has_tt to the pro

[PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/misc/ftdi-elan.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c index 8

[PATCH 0/9] usb: Simplify return statements

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar This patch series is created using simple_return.cocci coccinelle script. It replaces the redundant instances where variable is first assigned return value from a function call and then used in return statement, by direct function call in the return statement. Saurabh

[PATCH 1/9] usb: phy: phy-mxs-usb: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/phy/phy-mxs-usb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 3fcc

[PATCH 2/9] usb: phy: phy-keystone: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/phy/phy-keystone.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-keystone.c b/drivers/usb/phy/phy-keystone.c index e

[PATCH 4/9] usb: host: ehci-st: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/ehci-st.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c index 7e4bd39..b7c

[PATCH 5/9] usb: host: oxu210hp-hcd: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/oxu210hp-hcd.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c ind

[PATCH 6/9] usb: host: u132-hcd: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/u132-hcd.c | 27 +-- 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u13

[PATCH 8/9] usb: serial: mxuport: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/serial/mxuport.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c index 460a406

[PATCH 3/9] usb: musb: musb_dsps: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/musb/musb_dsps.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 1334a3d

[PATCH 7/9] usb: host: xhci: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/xhci.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 526ebc0..19076fa 10064

Re: [PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement

2015-08-04 Thread Sergei Shtylyov
Hello. On 8/4/2015 12:12 PM, Karajgaonkar, Saurabh (S.) wrote: From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/misc/ftdi-elan.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff

Re: [PATCH 4/9] usb: host: ehci-st: Simplify return statement

2015-08-04 Thread Patrice Chotard
Hi On 08/04/2015 11:10 AM, Karajgaonkar, Saurabh (S.) wrote: From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/ehci-st.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/

[PATCH v2] usb: devio: remove assignment from if condition

2015-08-04 Thread Kris Borer
Fix five occurrences of the checkpatch.pl error: ERROR: do not use assignment in if condition The semantic patch that makes this change is: // @@ identifier i; expression E; statement S1, S2; @@ + i = E; if ( - (i = E) + i ) S1 else S2 @@ identifier i; expression E; statement S; constant

Re: MUSB dual-role on AM335x behaving weirdly

2015-08-04 Thread Gregory CLEMENT
Hi Bin, On 02/07/2015 19:05, Bin Liu wrote: > Hi, > > On Thu, Jul 2, 2015 at 2:16 AM, Gregory CLEMENT > wrote: >> Hi Felipe, >> >> On 27/05/2015 11:42, Alexandre Belloni wrote: >>> Hi, >>> >>> On 26/05/2015 at 09:51:18 -0500, Felipe Balbi wrote : On Thu, May 14, 2015 at 04:36:33PM -0500, Bi

[PATCH v2 1/9] usb: phy: phy-mxs-usb: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/phy/phy-mxs-usb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 3fcc

[PATCH v2 0/9] usb: Simplify return statements

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar This patch series is created using simple_return.cocci coccinelle script. It replaces the redundant instances where variable is first assigned return value from a function call and then used in return statement, by direct function call in the return statement. Changes

[PATCH v2 2/9] usb: phy: phy-keystone: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/phy/phy-keystone.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-keystone.c b/drivers/usb/phy/phy-keystone.c index e

[PATCH v2 3/9] usb: musb: musb_dsps: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/musb/musb_dsps.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 1334a3d

[PATCH v2 5/9] usb: host: oxu210hp-hcd: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/oxu210hp-hcd.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c ind

[PATCH v2 6/9] usb: host: u132-hcd: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/u132-hcd.c | 35 +-- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/

[PATCH v2 9/9] usb: misc: ftdi-elan: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/misc/ftdi-elan.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c inde

[PATCH] usb: musb: omap2430: use *syscon* framework API to write to mailbox register

2015-08-04 Thread Kishon Vijay Abraham I
Deprecate using phy-omap-control driver to write to the mailbox register and start using *syscon* framework to do the same. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt |7 +- drivers/usb/musb/omap2430.c| 115 ++

[PATCH v2 8/9] usb: serial: mxuport: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/serial/mxuport.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c index 4

[PATCH v2 7/9] usb: host: xhci: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/xhci.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 526ebc0..19076fa 10064

[PATCH v2 4/9] usb: host: ehci-st: Simplify return statement

2015-08-04 Thread Karajgaonkar, Saurabh (S.)
From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/ehci-st.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c index 7e4bd39..b7c

Re: [PATCH v3]USB:OHCI: BugFix:Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

2015-08-04 Thread Alan Stern
On Mon, 3 Aug 2015, Greg KH wrote: > On Thu, Jul 23, 2015 at 12:50:26PM +, AMAN DEEP wrote: > > There is a race condition between > > finish_unlinks->finish_urb() function and > > usb_kill_urb() in ohci controller case. The finish_urb > > calls spin_unlock(&ohci->lock) before > > usb_h

Re: [PATCH v2 4/9] usb: host: ehci-st: Simplify return statement

2015-08-04 Thread Alan Stern
On Tue, 4 Aug 2015, Karajgaonkar, Saurabh (S.) wrote: > From: Saurabh Karajgaonkar > > Replace redundant variable use in return statement. > > Signed-off-by: Saurabh Karajgaonkar > --- > drivers/usb/host/ehci-st.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a

Re: MUSB dual-role on AM335x behaving weirdly

2015-08-04 Thread Gregory CLEMENT
Hi again, On 04/08/2015 15:08, Gregory CLEMENT wrote: > Hi Bin, > > On 02/07/2015 19:05, Bin Liu wrote: >> Hi, >> >> On Thu, Jul 2, 2015 at 2:16 AM, Gregory CLEMENT >> wrote: >>> Hi Felipe, >>> >>> On 27/05/2015 11:42, Alexandre Belloni wrote: Hi, On 26/05/2015 at 09:51:18 -0500, F

Re: external USB-Speaker and "Not enough bandwidth for altsetting 1"

2015-08-04 Thread Alan Stern
Please use Reply-To-All, so that your message is sent to the mailing list as well as to me. On Mon, 3 Aug 2015, Jakob Schürz wrote: > Am 2015-08-03 um 16:18 schrieb Alan Stern: > > On Sun, 2 Aug 2015, Jakob Schürz wrote: > > > >> # uname -a > >> Linux aldebaran 4.0.0-2-amd64 #1 SMP Debian 4.0.8-

Re: [PATCH v2] usb: ehci-platform: Fix using multiple controllers from OF

2015-08-04 Thread Alan Stern
On Tue, 4 Aug 2015, Alban Bedel wrote: > When using OF defined controllers the platform data struct is shared > between all devices, so it can't be used for device specific settings. > However it is currently used for the OF properties > needs-reset-on-resume and has-transaction-translator. > > T

Re: [PATCH v8 00/23] usb gadget update for OTG 2.0

2015-08-04 Thread Felipe Balbi
On Tue, Aug 04, 2015 at 08:00:31AM +0800, Li Jun wrote: > On Thu, Jul 30, 2015 at 09:10:06AM -0500, Felipe Balbi wrote: > > On Thu, Jul 30, 2015 at 09:46:58AM +0800, Li Jun wrote: > > > On Wed, Jul 29, 2015 at 09:11:41PM -0500, Felipe Balbi wrote: > > > > On Thu, Jul 30, 2015 at 07:24:03AM +0800, L

[PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe

2015-08-04 Thread Kishon Vijay Abraham I
No functional change. Previously omap_control_phy_power() was used to power off the PHY during probe. But once PIPE3 driver is adapted to use syscon, omap_control_phy_power() cannot be used. Hence used ti_pipe3_power_off to power off the PHY. Signed-off-by: Kishon Vijay Abraham I Acked-by: Roger

[PATCH 4/7] phy: ti-pipe3: use *syscon* framework API to set PCS value of the PHY

2015-08-04 Thread Kishon Vijay Abraham I
Deprecate using phy-omap-control driver to set PCS value of the PHY and start using *syscon* API to do the same. Signed-off-by: Kishon Vijay Abraham I Acked-by: Roger Quadros --- Documentation/devicetree/bindings/phy/ti-phy.txt |2 ++ drivers/phy/phy-ti-pipe3.c | 34

[PATCH 5/7] phy: omap-usb2: use omap_usb_power_off to power off the PHY during probe

2015-08-04 Thread Kishon Vijay Abraham I
No functional change. Previously omap_control_phy_power() was used to power off the PHY during probe. But once phy-omap-usb2 driver is adapted to use syscon, omap_control_phy_power() cannot be used. Hence used omap_usb_power_off to power off the PHY. Signed-off-by: Kishon Vijay Abraham I Acked-by

[PATCH 6/7] phy: omap-usb2: Add a new compatible string for USB2 PHY2

2015-08-04 Thread Kishon Vijay Abraham I
The USB2 PHY2 has a different register map compared to USB2 PHY1 to power on/off the PHY. In order to handle it, add a new "compatible" string. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/phy/ti-phy.txt |2 ++ drivers/phy/phy-omap-usb2.c |

[PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe()

2015-08-04 Thread Kishon Vijay Abraham I
No functional change. Add separate functions for pll, clocks and syscon to make ti_pipe3_probe clean. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/phy-ti-pipe3.c | 165 1 file changed, 104 insertions(+), 61 deletions(-) diff --git a/drivers

[PATCH 0/7] phy: use syscon framework APIs to set ctrl mod reg

2015-08-04 Thread Kishon Vijay Abraham I
This series is split from [1] to include only the PHY patches. This series is basically to deprecate using phy-omap-control and use syscon APIs to program the control module registers. Changes from [1] in PHY patches include *) cleanup ti_pipe3_probe *) have mask, power_on and power_off values in

[PATCH 3/7] phy: ti-pipe3: use *syscon* framework API to power on/off the PHY

2015-08-04 Thread Kishon Vijay Abraham I
Deprecate using phy-omap-control driver to power on/off the PHY and use *syscon* framework to do the same. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/phy/ti-phy.txt | 10 ++- drivers/phy/phy-ti-pipe3.c | 90 ++ 2 file

[PATCH 05/10] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node

2015-08-04 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from USB PHY devicetree nodes. Since "omap_control_usb2phy1", "omap_control_usb3phy1" and "omap_control_usb2phy2" devicetree nodes are no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/b

[PATCH 08/10] ARM: dts: OMAP5: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node

2015-08-04 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from SATA PHY node. Since "omap_control_sata" devicetree node is no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap5.dtsi | 10 +- 1 file changed, 1 insertion(+),

[PATCH 10/10] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node

2015-08-04 Thread Kishon Vijay Abraham I
Add "syscon-otghs" property and remove the deprecated "ctrl-module" property from MUSB devicetree node. Since "omap_control_usbotg" devicetree node is no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 +--- 1 file changed, 1 insertion(+

[PATCH 04/10] ARM: dts: dra7: Use "ti,dra7x-usb2-phy2" compatible string for USB2 PHY2

2015-08-04 Thread Kishon Vijay Abraham I
The USB2 PHY2 has a different register map compared to USB2 PHY1 to power on/off the PHY. In order to handle it, use the new compatible string "ti,dra7x-usb2-phy2" for the second instance of USB2 PHY. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi |2 +- 1 file changed

[PATCH 06/10] ARM: dts: am4372: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node

2015-08-04 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from USB PHY device tree node. Since "am43xx_control_usb2phy1" and "am43xx_control_usb2phy2" devicetree nodes are no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/am4372.dtsi |

[PATCH 02/10] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node

2015-08-04 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from SATA PHY node. Since "omap_control_sata" note is no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-

[PATCH 07/10] ARM: dts: OMAP5: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node

2015-08-04 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from USB PHY devicetree node. Since "omap_control_usb2phy" and "omap_control_usb3phy" devicetree nodes are no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap5.dtsi | 16 ++

[PATCH 7/7] phy: omap-usb2: use *syscon* framework API to power on/off the PHY

2015-08-04 Thread Kishon Vijay Abraham I
Deprecate using phy-omap-control driver to power on/off the PHY, and use *syscon* framework to do the same. This handles powering on/off the PHY for the USB2 PHYs used in various TI SoCs. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/phy/ti-phy.txt |6 +- driver

[PATCH 01/10] ARM: dts: dra7: Add dt node for PCIe registers in sysctrl space

2015-08-04 Thread Kishon Vijay Abraham I
Add new device tree node for the control module register space where PCIe registers are present. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index aa6ab

[PATCH 09/10] ARM: dts: omap4: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node

2015-08-04 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from USB PHY dt node. Since "omap_control_usb2phy" devicetree node is no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 +--- 1 file changed, 1 insertion(+

[PATCH 03/10] ARM: dts: dra7: Use "syscon-phy-power" and "syscon-pcs" in PCIe PHY node

2015-08-04 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and "syscon-pcs" property which can be used to perform the control module initializations and remove the deprecated "ctrl-module" property from PCIe PHY dt nodes. Phandle to "sysclk" clock node is also added to the PCIe PHY node since some of the syscon initializati

[PATCH 00/10] ARM: dts: use syscon property instead of ctrl-module

2015-08-04 Thread Kishon Vijay Abraham I
This series is split from [1] to include only the dt patches. This series is basically to deprecate using ctrl-module property and use corresponding syscon properties to program the control module registers. Changes from [1] in PHY patches include *) series created after applying [2] Did basic e

Re: USB - Generic Serial device : Unable to read more than 4095 bytes

2015-08-04 Thread Peter Hurley
On 08/03/2015 10:47 PM, arun k wrote: > Thank you for the reply > >>> The tty layer is limiting you, just keep reading in a loop until you >>> run out of data, you should not ever expect to read a specific number of >>> bytes from a tty device at a time, the read call will tell you the >>> number

Re: [PATCH] usb: musb: omap2430: use *syscon* framework API to write to mailbox register

2015-08-04 Thread Felipe Balbi
Hi, On Tue, Aug 04, 2015 at 07:36:09PM +0530, Kishon Vijay Abraham I wrote: > Deprecate using phy-omap-control driver to write to the mailbox register > and start using *syscon* framework to do the same. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/usb/oma

Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe()

2015-08-04 Thread Felipe Balbi
On Tue, Aug 04, 2015 at 08:50:40PM +0530, Kishon Vijay Abraham I wrote: > No functional change. Add separate functions for pll, > clocks and syscon to make ti_pipe3_probe clean. > > Signed-off-by: Kishon Vijay Abraham I I think this needs to be splitted into smaller patches. Seems like the very

[PATCH] usb: gadget: f_uac2: fix build warning

2015-08-04 Thread Felipe Balbi
commit 913e4a90b6f9 ("usb: gadget: f_uac2: finalize wMaxPacketSize according to bandwidth") added a possible build warning when calling min(). In order to fix the warning, we just make sure to call min_t() and tell that its arguments should be u16. Cc: Peter Chen Signed-off-by: Felipe Balbi ---

Re: [PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe

2015-08-04 Thread Felipe Balbi
On Tue, Aug 04, 2015 at 08:50:41PM +0530, Kishon Vijay Abraham I wrote: > No functional change. Previously omap_control_phy_power() was used to power there is a slight functional change. You moved PHY power off from before to after pm_runtime_enable(), clk_prepare_enable() and creation of the PHY

Re: [PATCH 5/7] phy: omap-usb2: use omap_usb_power_off to power off the PHY during probe

2015-08-04 Thread Felipe Balbi
On Tue, Aug 04, 2015 at 08:50:44PM +0530, Kishon Vijay Abraham I wrote: > No functional change. Previously omap_control_phy_power() was used to power same comment as before. > off the PHY during probe. But once phy-omap-usb2 driver is adapted to > use syscon, omap_control_phy_power() cannot be us

Re: [PATCH v5 07/46] usb: dwc3: gadget: add ep capabilities support

2015-08-04 Thread Felipe Balbi
On Fri, Jul 31, 2015 at 04:00:19PM +0200, Robert Baldyga wrote: > Convert endpoint configuration to new capabilities model. > > Signed-off-by: Robert Baldyga > --- > drivers/usb/dwc3/gadget.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/drivers/usb/dwc3/gadget.c b/dri

Re: [PATCH v5 00/46] usb: gadget: rework ep matching and claiming mechanism

2015-08-04 Thread Felipe Balbi
Hi, On Fri, Jul 31, 2015 at 04:00:12PM +0200, Robert Baldyga wrote: > Hello, > > This patch series reworks endpoint matching and claiming mechanism in > epautoconf. From v2 there are couple of new patches adding 'ep_match' > to usb_gadget_ops and removing chip-specific quirk handling from generic

Re: [PATCH v8 2/7] usb: interface authorization: Introduces the default interface authorization

2015-08-04 Thread Stefan Koch
Am Montag, den 03.08.2015, 15:06 -0700 schrieb Greg KH: > On Thu, Jul 30, 2015 at 08:19:19AM +0200, Stefan Koch wrote: > > Interfaces are allowed per default. > > This can disabled or enabled (again) by writing 0 or 1 to > > /sys/bus/usb/devices/usbX/interface_authorized_default > > > > Signed-off

Re: [PATCH v5 40/46] usb: gadget: epautoconf: rework ep_matches() function

2015-08-04 Thread Felipe Balbi
On Fri, Jul 31, 2015 at 04:00:52PM +0200, Robert Baldyga wrote: > Rework ep_matches() function to make it shorter and more readable. > > Signed-off-by: Robert Baldyga this regresses at least mass storage. How did you test it ? I'll keep all patches up to this one, please fix the problem, rebase

Re: [PATCH v8 7/7] usb: interface authorization: Use a flag for the default device authorization

2015-08-04 Thread Stefan Koch
Am Montag, den 03.08.2015, 15:11 -0700 schrieb Greg KH: > On Thu, Jul 30, 2015 at 08:19:24AM +0200, Stefan Koch wrote: > > With this patch a flag instead of a variable > > is used for the default device authorization. > > > > Signed-off-by: Stefan Koch > > --- > > drivers/usb/core/hcd.c | 31 ++

Re: [PATCH v8 2/7] usb: interface authorization: Introduces the default interface authorization

2015-08-04 Thread Greg KH
On Tue, Aug 04, 2015 at 08:55:38PM +0200, Stefan Koch wrote: > Am Montag, den 03.08.2015, 15:06 -0700 schrieb Greg KH: > > On Thu, Jul 30, 2015 at 08:19:19AM +0200, Stefan Koch wrote: > > > Interfaces are allowed per default. > > > This can disabled or enabled (again) by writing 0 or 1 to > > > /sy

Re: MUSB dual-role on AM335x behaving weirdly

2015-08-04 Thread Felipe Balbi
On Tue, Aug 04, 2015 at 04:23:02PM +0200, Gregory CLEMENT wrote: > Hi again, > On 04/08/2015 15:08, Gregory CLEMENT wrote: > > Hi Bin, > > > > On 02/07/2015 19:05, Bin Liu wrote: > >> Hi, > >> > >> On Thu, Jul 2, 2015 at 2:16 AM, Gregory CLEMENT > >> wrote: > >>> Hi Felipe, > >>> > >>> On 27/05/2

Re: [PATCH v8 2/7] usb: interface authorization: Introduces the default interface authorization

2015-08-04 Thread Stefan Koch
Am Dienstag, den 04.08.2015, 12:14 -0700 schrieb Greg KH: > On Tue, Aug 04, 2015 at 08:55:38PM +0200, Stefan Koch wrote: > > Am Montag, den 03.08.2015, 15:06 -0700 schrieb Greg KH: > > > On Thu, Jul 30, 2015 at 08:19:19AM +0200, Stefan Koch wrote: > > > > Interfaces are allowed per default. > > > >

[PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-08-04 Thread Hans de Goede
For some unclear reason sometimes we get VBus errors in host-only mode, even though we do not have any vbus-detection then. Ignore these. Signed-off-by: Hans de Goede --- drivers/usb/musb/sunxi.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/

Re: [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-08-04 Thread Felipe Balbi
On Tue, Aug 04, 2015 at 11:25:53PM +0200, Hans de Goede wrote: > For some unclear reason sometimes we get VBus errors in host-only mode, > even though we do not have any vbus-detection then. Ignore these. > > Signed-off-by: Hans de Goede > --- > drivers/usb/musb/sunxi.c | 4 > 1 file change

Re: [PATCH v8 2/7] usb: interface authorization: Introduces the default interface authorization

2015-08-04 Thread Greg KH
On Tue, Aug 04, 2015 at 10:04:13PM +0200, Stefan Koch wrote: > Am Dienstag, den 04.08.2015, 12:14 -0700 schrieb Greg KH: > > On Tue, Aug 04, 2015 at 08:55:38PM +0200, Stefan Koch wrote: > > > Am Montag, den 03.08.2015, 15:06 -0700 schrieb Greg KH: > > > > On Thu, Jul 30, 2015 at 08:19:19AM +0200, S

Re: [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-08-04 Thread Hans de Goede
Hi, On 08/04/2015 11:35 PM, Felipe Balbi wrote: On Tue, Aug 04, 2015 at 11:25:53PM +0200, Hans de Goede wrote: For some unclear reason sometimes we get VBus errors in host-only mode, even though we do not have any vbus-detection then. Ignore these. Signed-off-by: Hans de Goede --- drivers/u

Re: [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-08-04 Thread Felipe Balbi
Hi, On Wed, Aug 05, 2015 at 12:05:02AM +0200, Hans de Goede wrote: > Hi, > > On 08/04/2015 11:35 PM, Felipe Balbi wrote: > >On Tue, Aug 04, 2015 at 11:25:53PM +0200, Hans de Goede wrote: > >>For some unclear reason sometimes we get VBus errors in host-only mode, > >>even though we do not have any

Re: [PATCH] Fix data loss in cdc-acm

2015-08-04 Thread Peter Hurley
On 07/22/2015 11:01 AM, Oliver Neukum wrote: > On Wed, 2015-07-22 at 10:30 -0400, Peter Hurley wrote: >> 3. Pre-allocate space _before_ the data arrives (with >> tty_buffer_request_room()); >>this is applicable to subsystems which know how much data can be >> in-flight >>at any one time. Th

Re: [PATCH] usb: gadget: f_uac2: fix build warning

2015-08-04 Thread Peter Chen
On Tue, Aug 04, 2015 at 11:04:38AM -0500, Felipe Balbi wrote: > commit 913e4a90b6f9 ("usb: gadget: f_uac2: > finalize wMaxPacketSize according to bandwidth") > added a possible build warning when calling > min(). In order to fix the warning, we just > make sure to call min_t() and tell that its > a

Re: USB - Generic Serial device : Unable to read more than 4095 bytes

2015-08-04 Thread arun k
I enabled software flow control like below tty.c_iflag |= (IXON | IXOFF | IXANY); But I still having the data loss issue. Regards Arun On Wed, Aug 5, 2015 at 12:59 AM, Peter Hurley wrote: > On 08/03/2015 10:47 PM, arun k wrote: >> Thank you for the reply >> The tty layer is limiting you,

Re: USB - Generic Serial device : Unable to read more than 4095 bytes

2015-08-04 Thread Peter Hurley
On 08/04/2015 10:00 PM, arun k wrote: > I enabled software flow control like below > > tty.c_iflag |= (IXON | IXOFF | IXANY); Ok, but does the sending device know how to process in-band software flow control and is it set up to respond properly? Also, I doubt software flow control is going to w

Re: [PATCH v2 06/10] usb: chipidea: add ahb burst configuration interface

2015-08-04 Thread Peter Chen
On Mon, Aug 03, 2015 at 09:04:27AM -0500, Rob Herring wrote: > On Sun, Aug 2, 2015 at 11:47 PM, Peter Chen wrote: > > The users can change it through dts or platform data if they > > want to change the default value. > > > > Signed-off-by: Peter Chen > > --- > > drivers/usb/chipidea/bits.h | 3

[PATCH 1/1] usb: chipidea: host: override hcd reset API

2015-08-04 Thread Peter Chen
The system configuration API should be called before the controller run, otherwise, undefined results may occur. So, we override hcd reset API, and add system configuration API after controller reset. Cc: Li Jun Cc: Alan Stern Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 18

Fwd: USB - Generic Serial device : Unable to read more than 4095 bytes

2015-08-04 Thread arun k
-- Forwarded message -- From: arun k Date: Wed, Aug 5, 2015 at 12:57 PM Subject: Re: USB - Generic Serial device : Unable to read more than 4095 bytes To: Peter Hurley Cc: Greg KH , linux-usb@vger.kernel.org > Ok, but does the sending device know how to process in-band software

[PATCH] usb/gadget/function/u_ether.c: Allow jumbo frames

2015-08-04 Thread Mike Looijmans
USB network adapters support Jumbo frames. The only thing blocking that feature is the code in the gadget driver that disposes of packets larger than 1518 bytes, and the limit on the ioctl to set the mtu. This patch relaxes these limits, and allows up to 15k frames sizes. The 15k value was chosen