Re: [PATCH] usb/gadget: make composite gadget meet usb compliance for vbus draw

2015-07-24 Thread Andrzej Pietrasiewicz
Hi, W dniu 24.07.2015 o 06:11, Du, Changbin pisze: Thanks, Pietrasiewicz. From: Andrzej Pietrasiewicz [mailto:andrze...@samsung.com] W dniu 23.07.2015 o 14:34, Du, Changbin pisze: >From 0a8e0d63a9887735c6782d7b0c15c2c1fdf1952a Mon Sep 17 00:00:00 void composite_disconnect(struct usb_gadget

[PATCHv2 0/2] hid & printer fixes

2015-07-24 Thread Andrzej Pietrasiewicz
v1..v2: - addressed Sergei's comment Users should not be able to create more function instances than minor numbers allocated for the functions. The problem is in hid and printer functions. This short series fixes it by enforcing the maximum number of function directories created. Andrzej Pietrasi

[PATCHv2 2/2] usb: gadget: f_printer: actually limit the number of instances

2015-07-24 Thread Andrzej Pietrasiewicz
There is a predefined maximum number of printer instances, currently 4. A chrdev region is allocated accordingly, but with configfs the user can create as many printer function directories as they like. To make the number of printer instances consistent with the number of allocated minors, the lim

[PATCHv2 1/2] usb: gadget: f_hid: actually limit the number of instances

2015-07-24 Thread Andrzej Pietrasiewicz
There is a predefined maximum number of hid instances, currently 4. A chrdev region is allocated accordingly, but with configfs the user can create as many hid function directories as they like. To make the number of hid instances consistent with the number of allocated minors, the limit is enforce

Re: Multiple drives on JMS56x-based sata-usb docking station.

2015-07-24 Thread Giulio Bernardi
This is the trace I got after I used this option: options usb-storage quirks=152d:1567:u 8<--- 33c03f00 0.013617 C Ii:2:001:1 0:2048 2 = 0400 33c03f00 0.013643 S Ii:2:001:1 -:2048 4 < de84e900 0.013877 S Ci:2:001:0 s a3 00 0

Re: [PATCH v2] USB: sierra: add 1199:68AB device ID

2015-07-24 Thread Dirk Behme
On 23.07.2015 19:26, Johan Hovold wrote: On Thu, Jul 23, 2015 at 02:58:03PM +0200, Dirk Behme wrote: On 23.07.2015 12:36, Johan Hovold wrote: On Thu, Jul 23, 2015 at 12:31:55PM +0200, Dirk Behme wrote: Hi Johan, On 20.07.2015 11:24, Johan Hovold wrote: [ +CC: Bjørn and Dan ] On Mon, Jul 20,

RE: [PATCH] usb/gadget: make composite gadget meet usb compliance for vbus draw

2015-07-24 Thread Du, Changbin
Thanks for explanation. I am agree with you that separate changes into two patches. Will send out new patch soon. Regards Du, Changbin > From: Andrzej Pietrasiewicz [mailto:andrze...@samsung.com] > Hi, > > W dniu 24.07.2015 o 06:11, Du, Changbin pisze: > > Thanks, Pietrasiewicz. > >> From: Andr

Re: [PATCH v2] USB: sierra: add 1199:68AB device ID

2015-07-24 Thread Johan Hovold
On Fri, Jul 24, 2015 at 10:17:24AM +0200, Dirk Behme wrote: > On 23.07.2015 19:26, Johan Hovold wrote: > > This is probably the right driver, but I'm confused over the DirectIP > > bits. Those interfaces are lacking AFAICT and still your comment claims > > it's a DirectIP modem (that would also re

Re: [PATCH v2] USB: sierra: add 1199:68AB device ID

2015-07-24 Thread Dirk Behme
On 24.07.2015 10:45, Johan Hovold wrote: On Fri, Jul 24, 2015 at 10:17:24AM +0200, Dirk Behme wrote: On 23.07.2015 19:26, Johan Hovold wrote: This is probably the right driver, but I'm confused over the DirectIP bits. Those interfaces are lacking AFAICT and still your comment claims it's a Di

Re: [PATCH] udc:Remove no longer required varaiable in the function udc_set_halt

2015-07-24 Thread Thomas Dahlmann
ACK and thanks! for your patches. Am 6/27/2015 8:45 PM, schrieb Nicholas Krause: This removes the no longer required variable retval in the function udc_set_halt now due to this variable never being set to a return value after calling another function inside the function udc_set_halt and only b

Re: [PATCH v2] USB: sierra: add 1199:68AB device ID

2015-07-24 Thread Johan Hovold
On Fri, Jul 24, 2015 at 10:59:48AM +0200, Dirk Behme wrote: > On 24.07.2015 10:45, Johan Hovold wrote: > > On Fri, Jul 24, 2015 at 10:17:24AM +0200, Dirk Behme wrote: > >> On 23.07.2015 19:26, Johan Hovold wrote: > > > >>> This is probably the right driver, but I'm confused over the DirectIP > >>>

Re: GPIO support for Silicon Labs cp210x USB serial

2015-07-24 Thread Petr Tesařík
On Thu, 23 Jul 2015 14:59:32 -0700 "John D. Blair" wrote: > On Thu, 2015-07-23 at 18:00 +0200, Johan Hovold wrote: > > The short answer is that we do not want custom driver ioctls. Any gpio > > implementation needs to based on gpiolib, which provides a > > standardised > > interface. > > > I und

Re: GPIO support for Silicon Labs cp210x USB serial

2015-07-24 Thread Johan Hovold
On Fri, Jul 24, 2015 at 01:08:57PM +0200, Petr Tesařík wrote: > On Thu, 23 Jul 2015 14:59:32 -0700 > "John D. Blair" > wrote: > > > On Thu, 2015-07-23 at 18:00 +0200, Johan Hovold wrote: > > > The short answer is that we do not want custom driver ioctls. Any gpio > > > implementation needs to ba

Re: xhci_hcd 0000:00:14.0: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 1

2015-07-24 Thread Mathias Nyman
On 22.07.2015 17:12, Arkadiusz Miskiewicz wrote: > > [sorry, resend from different email - vger postmaster team has stupid filters > in place] > > On Tuesday 21 of July 2015, Mathias Nyman wrote: >> On 20.07.2015 23:13, Arkadiusz Miskiewicz wrote: >>> On Saturday 18 of July 2015, Arkadiusz Miski

Re: [PATCH v2] USB: sierra: add 1199:68AB device ID

2015-07-24 Thread Lars Melin
On 2015-07-24 16:30, Johan Hovold wrote: On Fri, Jul 24, 2015 at 10:59:48AM +0200, Dirk Behme wrote: On 24.07.2015 10:45, Johan Hovold wrote: On Fri, Jul 24, 2015 at 10:17:24AM +0200, Dirk Behme wrote: On 23.07.2015 19:26, Johan Hovold wrote: This is probably the right driver, but I'm confu

Re: [PATCH v2] USB: sierra: add 1199:68AB device ID

2015-07-24 Thread Lars Melin
On 2015-07-24 16:30, Johan Hovold wrote: On Fri, Jul 24, 2015 at 10:59:48AM +0200, Dirk Behme wrote: On 24.07.2015 10:45, Johan Hovold wrote: On Fri, Jul 24, 2015 at 10:17:24AM +0200, Dirk Behme wrote: On 23.07.2015 19:26, Johan Hovold wrote: This is probably the right driver, but I'm confu

Re: [PATCH v2] USB: sierra: add 1199:68AB device ID

2015-07-24 Thread Johan Hovold
On Fri, Jul 24, 2015 at 07:22:45PM +0700, Lars Melin wrote: > The interface layout of 1199:68ab does not look like 1199:68aa does, it > has instead more in common with MC879x modules 1199:683c/683d which also > are composite devices with 7 interfaces (0..6) and also MDM62xx based as > the AR855

Re: [PATCH v2] USB: sierra: add 1199:68AB device ID

2015-07-24 Thread Dirk Behme
On 24.07.2015 14:37, Johan Hovold wrote: On Fri, Jul 24, 2015 at 07:22:45PM +0700, Lars Melin wrote: The interface layout of 1199:68ab does not look like 1199:68aa does, it has instead more in common with MC879x modules 1199:683c/683d which also are composite devices with 7 interfaces (0..6) an

Re: [PATCH v2 4/6] usb: dwc3; ep0: Modify _dwc3_ep0_start_trans_ API to take 'chain' parameter

2015-07-24 Thread Sergei Shtylyov
Hello. On 7/24/2015 9:47 AM, Kishon Vijay Abraham I wrote: No functional change. Added a new parameter in _dwc3_ep0_start_trans_ to indicate whether the TRB is a chained TRB or last TRB. This is in preparation for adding chained TRB support for ep0. Signed-off-by: Kishon Vijay Abraham I ---

Re: [PATCH 1/1] Avoid usb reset crashes by making tty_io cdevs truly dynamic

2015-07-24 Thread Alan Stern
On Thu, 23 Jul 2015, Richard Watts wrote: > When the USB reset happens, we get a bunch of complaints from the > kernel. > > Some of these are to do with races on the kobjects associated with the > sysfs entries for the ttyACM0 device. They turn out not to be fatal, > and have their own patch

Re: xhci_hcd 0000:00:14.0: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 1

2015-07-24 Thread Mathias Nyman
On 24.07.2015 14:59, Mathias Nyman wrote: > On 22.07.2015 17:12, Arkadiusz Miskiewicz wrote: >> >> On Tuesday 21 of July 2015, Mathias Nyman wrote: >>> On 20.07.2015 23:13, Arkadiusz Miskiewicz wrote: On Saturday 18 of July 2015, Arkadiusz Miskiewicz wrote: > Hi. > > I'm on 4.2.0-r

Re: Multiple drives on JMS56x-based sata-usb docking station.

2015-07-24 Thread Alan Stern
On Fri, 24 Jul 2015, Giulio Bernardi wrote: > This is the trace I got after I used this option: > options usb-storage quirks=152d:1567:u This trace is pretty clear; the system does not scan for logical units beyond LUN 0, even though the device contains two logical units. In older kernels this w

Re: xhci_hcd 0000:00:14.0: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 1

2015-07-24 Thread Peter Stuge
Mathias Nyman wrote: > +++ b/drivers/usb/host/xhci-ring.c > @@ -82,7 +82,7 @@ dma_addr_t xhci_trb_virt_to_dma(struct xhci_segment *seg, > return 0; > /* offset in TRBs */ > segment_offset = trb - seg->trbs; > - if (segment_offset > TRBS_PER_SEGMENT) > + i

Re: xhci_hcd 0000:00:14.0: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 1

2015-07-24 Thread Mathias Nyman
On 24.07.2015 16:53, Peter Stuge wrote: > Mathias Nyman wrote: >> +++ b/drivers/usb/host/xhci-ring.c >> @@ -82,7 +82,7 @@ dma_addr_t xhci_trb_virt_to_dma(struct xhci_segment *seg, >> return 0; >> /* offset in TRBs */ >> segment_offset = trb - seg->trbs; >> - if

Re: Several races in "usbnet" module (kernel 4.1.x)

2015-07-24 Thread Eugene Shatokhin
23.07.2015 12:15, Oliver Neukum пишет: On Wed, 2015-07-22 at 21:33 +0300, Eugene Shatokhin wrote: The following part is not necessary, I think. usbnet_bh() does not touch EVENT_NO_RUNTIME_PM bit explicitly and these bit operations are atomic w.r.t. each other. + mpn |= !test_and_clear_bit(

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-07-24 Thread Alan Stern
On Mon, 22 Jun 2015, James Bottomley wrote: > On Mon, 2015-06-22 at 13:48 -0400, Alan Stern wrote: > > On Mon, 22 Jun 2015, James Bottomley wrote: > > > > > On Mon, 2015-06-22 at 13:30 -0400, Alan Stern wrote: > > > > On Mon, 22 Jun 2015, James Bottomley wrote: > > > > > > > > > I'm not sure I e

Re: xhci_hcd 0000:00:14.0: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 1

2015-07-24 Thread Arkadiusz Miskiewicz
On Friday 24 of July 2015, Mathias Nyman wrote: > On 24.07.2015 14:59, Mathias Nyman wrote: > > On 22.07.2015 17:12, Arkadiusz Miskiewicz wrote: > >> On Tuesday 21 of July 2015, Mathias Nyman wrote: > >>> On 20.07.2015 23:13, Arkadiusz Miskiewicz wrote: > On Saturday 18 of July 2015, Arkadiusz

Re: GPIO support for Silicon Labs cp210x USB serial

2015-07-24 Thread John D. Blair
Petr, We will be happy to test, code review, and otherwise contribute to your effort. We're using the cp2105 dual-uart device in our product. It has two logical serial ports and two sets of GPIOs so I think its a good test case. best, John. On Fri, 2015-07-24 at 13:08 +0200, Petr Tesařík wrote:

Re: Several races in "usbnet" module (kernel 4.1.x)

2015-07-24 Thread Eugene Shatokhin
21.07.2015 15:04, Oliver Neukum пишет: On Mon, 2015-07-20 at 21:13 +0300, Eugene Shatokhin wrote: Hi, I have recently found several data races in "usbnet" module, checked on vanilla kernel 4.1.0 on x86_64. The races do actually happen, I have confirmed it by adding delays and using hardware bre

Re: [PATCH 4/4] cp210x: Expose the part number in sysfs

2015-07-24 Thread Greg Kroah-Hartman
On Fri, Jul 24, 2015 at 08:48:11AM +0200, Petr Tesarik wrote: > From: Petr Tesarik > > Make it possible to read the cp210x part number from userspace by making > it a sysfs attribute. > > Signed-off-by: Petr Tesarik All sysfs files need to be documented in Documentation/ABI/ > --- > drivers/

Re: [Patch V4 1/3] usb: Add Xen pvUSB protocol description

2015-07-24 Thread Greg KH
On Fri, Jul 24, 2015 at 05:51:04AM +0200, Juergen Gross wrote: > On 07/23/2015 09:08 PM, Greg KH wrote: > >On Thu, Jul 23, 2015 at 08:46:17AM +0200, Juergen Gross wrote: > >>On 07/23/2015 06:36 AM, Greg KH wrote: > >>>On Thu, Jul 23, 2015 at 06:04:39AM +0200, Juergen Gross wrote: > On 07/23/201

Re: [PATCH V2 1/4] usb: gadget: udc: bdc: Fix a driver crash on disconnect

2015-07-24 Thread Alan Cooper
I'll send a single patch for the minimal bug fix for the rc and I'll send the rest of the changes as a patch set for 4.3. Thanks Al On Thu, Jul 23, 2015 at 4:05 PM, Felipe Balbi wrote: > On Thu, Jul 23, 2015 at 03:23:26PM -0400, Alan Cooper wrote: >> On Wed, Jul 22, 2015 at 10:03 PM, Felipe Balb

Re: [PATCH V2 1/4] usb: gadget: udc: bdc: Fix a driver crash on disconnect

2015-07-24 Thread Felipe Balbi
Hi, (please avoid top-posting) On Fri, Jul 24, 2015 at 03:20:10PM -0400, Alan Cooper wrote: > I'll send a single patch for the minimal bug fix for the rc and I'll > send the rest of the changes as a patch set for 4.3. that's all right -- balbi signature.asc Description: Digital signature

Re: [Patch V4 1/3] usb: Add Xen pvUSB protocol description

2015-07-24 Thread Konrad Rzeszutek Wilk
On Fri, Jul 24, 2015 at 11:57:47AM -0700, Greg KH wrote: > On Fri, Jul 24, 2015 at 05:51:04AM +0200, Juergen Gross wrote: > > On 07/23/2015 09:08 PM, Greg KH wrote: > > >On Thu, Jul 23, 2015 at 08:46:17AM +0200, Juergen Gross wrote: > > >>On 07/23/2015 06:36 AM, Greg KH wrote: > > >>>On Thu, Jul 23

[PATCH] usb: gadget: udc: bdc: Minimal fix for a driver crash on disconnect

2015-07-24 Thread Al Cooper
ep_dequeue() in bdc_ep.c was capturing the hw dequeue pointer incorrectly by reading the wrong register for the upper 32 bits. Signed-off-by: Al Cooper --- drivers/usb/gadget/udc/bdc/bdc_ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c

Re: [PATCH 4/4] cp210x: Expose the part number in sysfs

2015-07-24 Thread Petr Tesarik
On Fri, 24 Jul 2015 11:17:55 -0700 Greg Kroah-Hartman wrote: > On Fri, Jul 24, 2015 at 08:48:11AM +0200, Petr Tesarik wrote: > > From: Petr Tesarik > > > > Make it possible to read the cp210x part number from userspace by making > > it a sysfs attribute. > > > > Signed-off-by: Petr Tesarik >

Re: [PATCH 4/4] cp210x: Expose the part number in sysfs

2015-07-24 Thread Greg Kroah-Hartman
On Fri, Jul 24, 2015 at 11:00:38PM +0200, Petr Tesarik wrote: > On Fri, 24 Jul 2015 11:17:55 -0700 > Greg Kroah-Hartman wrote: > > > On Fri, Jul 24, 2015 at 08:48:11AM +0200, Petr Tesarik wrote: > > > From: Petr Tesarik > > > > > > Make it possible to read the cp210x part number from userspace

Re: [PATCH 4/4] cp210x: Expose the part number in sysfs

2015-07-24 Thread Petr Tesarik
On Fri, 24 Jul 2015 14:33:23 -0700 Greg Kroah-Hartman wrote: > On Fri, Jul 24, 2015 at 11:00:38PM +0200, Petr Tesarik wrote: > > On Fri, 24 Jul 2015 11:17:55 -0700 > > Greg Kroah-Hartman wrote: > > > > > On Fri, Jul 24, 2015 at 08:48:11AM +0200, Petr Tesarik wrote: > > > > From: Petr Tesarik >

Re: [PATCH v3 42/46] usb: gadget: move ep_matches() from epautoconf to udc-core

2015-07-24 Thread Petr Cvek
On 23.7.2015 16:36, Felipe Balbi wrote: > Hi, > > On Thu, Jul 23, 2015 at 06:40:40AM +0200, Petr Cvek wrote: >> Hello, >> >> Is this: >> >> case USB_ENDPOINT_XFER_INT: >> /* Bulk endpoints handle interrupt transfers, >> * except the toggle-quirky iso-synch kind >>

Re: [PATCH v3 42/46] usb: gadget: move ep_matches() from epautoconf to udc-core

2015-07-24 Thread Petr Cvek
On 23.7.2015 21:46, Alan Stern wrote: > On Thu, 23 Jul 2015, Petr Cvek wrote: > >> Hello, >> >> Is this: >> >> case USB_ENDPOINT_XFER_INT: >> /* Bulk endpoints handle interrupt transfers, >> * except the toggle-quirky iso-synch kind >> */ >>