Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

2015-07-15 Thread Axel Lin
2015-06-20 15:39 GMT+08:00 Axel Lin : > Also simplify the code a bit by specify direction and initial value for > output in devm_gpiod_get_optional function. > > Signed-off-by: Axel Lin > Acked-by: Heikki Krogerus > Acked-by: Kishon Vijay Abraham I > --- > Hi > This patch was sent on https://lkm

Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops

2015-07-15 Thread Axel Lin
2015-06-05 8:27 GMT+08:00 Axel Lin : > The ops is never changed in ulpi_phy_create(), so make it const. Hi Kishon, Would you pick up this patch? Without this patch, passing a const struct phy_ops* to ulip_phy_create will have compiler warning. It should be fine to pass a const struct phy_ops* to

Re: [PATCH 2/2] gpio: gpio-ftdi-cbus: add driver for FTDI CBUS GPIOs

2015-07-15 Thread Linus Walleij
On Sun, Jun 21, 2015 at 12:12 AM, Stefan Agner wrote: > This driver allows to use the CBUS pins, e.g. CBUS 0-3 on FT232R > type of devices. Note that the pins need to be configured first > by using I/O mode signal option in the EEPROM. This is _not_ the > factory default configuration of any of t

Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops

2015-07-15 Thread Kishon Vijay Abraham I
Hi Axel, On Wednesday 15 July 2015 12:40 PM, Axel Lin wrote: > 2015-06-05 8:27 GMT+08:00 Axel Lin : >> The ops is never changed in ulpi_phy_create(), so make it const. > > Hi Kishon, > > Would you pick up this patch? yes.. I'll take once I start queuing the patches. Thanks Kishon -- To unsubsc

Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

2015-07-15 Thread Kishon Vijay Abraham I
Hi, On Wednesday 15 July 2015 12:34 PM, Axel Lin wrote: > 2015-06-20 15:39 GMT+08:00 Axel Lin : >> Also simplify the code a bit by specify direction and initial value for >> output in devm_gpiod_get_optional function. >> >> Signed-off-by: Axel Lin >> Acked-by: Heikki Krogerus >> Acked-by: Kishon

Re: About zero-length packet design for EHCI

2015-07-15 Thread Bernd Porr
Thanks Alan, that was very helpful. /Bernd Alan Stern wrote: On Tue, 14 Jul 2015, Bernd Porr wrote: I've got a question regarding ISO transfer. If the firmware is not providing data is the ISO urb returning zero packet length and if yes how can I check that in the driver? I'm working on a s

Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

2015-07-15 Thread Uwe Kleine-König
Hello, On Wed, Jul 15, 2015 at 01:45:44PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 15 July 2015 12:34 PM, Axel Lin wrote: > > 2015-06-20 15:39 GMT+08:00 Axel Lin : > >> Also simplify the code a bit by specify direction and initial value for > >> output in devm_gpiod_get_optiona

Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

2015-07-15 Thread Axel Lin
2015-07-15 16:29 GMT+08:00 Uwe Kleine-König : > Hello, > > On Wed, Jul 15, 2015 at 01:45:44PM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 15 July 2015 12:34 PM, Axel Lin wrote: >> > 2015-06-20 15:39 GMT+08:00 Axel Lin : >> >> Also simplify the code a bit by specify direction and

Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

2015-07-15 Thread Paul Bolle
Just a few nits, I'm afraid. On di, 2015-07-14 at 11:13 +0800, Peter Hung wrote: > --- /dev/null > +++ b/drivers/usb/serial/f81534.c > +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset) > +{ > + [...] > +} static? > +void f81534_gpio_free(struct gpio_chip *chip, unsigned offs

Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

2015-07-15 Thread Peter Hung
Hi Paul & Johan Paul Bolle 於 2015/7/15 下午 04:36 寫道: Just a few nits, I'm afraid. +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset) +{ + [...] +} static? Thanks Paul for point this out. And sorry for Johan. It's seems to make a new patch V5. I'll merge some minor fix w

Re: [PATCH v7 2/4] USB: io_ti: Move request_firmware() calls out of download_fw()

2015-07-15 Thread Johan Hovold
On Sun, Jun 28, 2015 at 01:28:19PM -0500, Peter E. Berger wrote: > From: "Peter E. Berger" > > The io_ti driver fails to download firmware to Edgeport > devices such as the EP/416, even when the on-disk firmware image > (/lib/firmware/edgeport/down3.bin) is more current than the version > on the

Re: [PATCH v7 3/4] USB: io_ti: Add firmware image sanity checks

2015-07-15 Thread Johan Hovold
On Sun, Jun 28, 2015 at 01:28:20PM -0500, Peter E. Berger wrote: > From: "Peter E. Berger" > > Do what we can to verify that the driver's firmware image is valid > (before attempting to download it to the Edgeport) by adding a new > function, check_fw_sanity(), and a call to it in in download_fw(

Re: [PATCH v7 4/4] USB: io_ti: Add heartbeat to keep idle Edgeport ports from disconnecting

2015-07-15 Thread Johan Hovold
On Sun, Jun 28, 2015 at 01:28:21PM -0500, Peter E. Berger wrote: > From: "Peter E. Berger" > > When using newer Edgeport devices such as the EP/416, idle ports are > automatically bounced (disconnected and then reconnected) approximately > every 60 seconds. This breaks programs (e.g: minicom) wh

Re: [PATCH v7 1/4] USB: io_ti: Increase insufficient timeout for firmware downloads

2015-07-15 Thread Johan Hovold
On Sun, Jun 28, 2015 at 01:28:18PM -0500, Peter E. Berger wrote: > From: "Peter E. Berger" > > The io_ti driver fails to download firmware to Edgeport devices such as > the EP/416. One of the problems is that the default 1 second timeout > in ti_vsend_sync() is insufficient for download operatio

Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

2015-07-15 Thread Johan Hovold
On Wed, Jul 15, 2015 at 04:55:19PM +0800, Peter Hung wrote: > Hi Paul & Johan > > Paul Bolle 於 2015/7/15 下午 04:36 寫道: > > Just a few nits, I'm afraid. > >> +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset) > >> +{ > >> + [...] > >> +} > > > > static? > > Thanks Paul for point thi

RE: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

2015-07-15 Thread Subbaraya Sundeep Bhatta
Hi John, > -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, July 14, 2015 12:29 AM > To: John Youn > Cc: ba...@ti.com; Subbaraya Sundeep Bhatta; gre...@linuxfoundation.org; > linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; > sta...@vger.kernel.org > S

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-15 Thread Johan Hovold
[ Please try to avoid top-posting. ] On Tue, Jul 14, 2015 at 07:22:01PM +0200, Michał Pecio wrote: > I managed to reproduce this old issue, both on vanilla v4.1.1 and with > my patch, IF and ONLY if I reverted commit 623c82633 by changing: > > - if (!old_termios || memcmp(buf, priv->line_se

Re: [PATCH v4 0/2] USB OTG PHY driver for NXP LPC18xx family

2015-07-15 Thread Kishon Vijay Abraham I
On Friday 10 July 2015 02:18 AM, Joachim Eastwood wrote: > This patch set adds support for the internal USB OTG PHY found > on NXP LPC18xx and LPC43xx devices. Driver takes care of > enabling the PHY and setting the clock rate which is need for > USB0 support on this platform. > > This version a

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-15 Thread Johan Hovold
On Wed, Jul 08, 2015 at 12:51:03PM +0200, Michał Pecio wrote: > > This commit fixes the following issues: > > 1. The 9th bit of buf was believed to be the LSB of divisor's > exponent, but the hardware interprets it as MSB (9th bit) of the > mantissa. The exponent is actually one bit shorter and a

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-07-15 Thread Kishon Vijay Abraham I
Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: > The usb0 phy is connected to an OTG controller, and as such needs some special > handling: > > 1) It allows explicit control over the pullups, enable these on phy_init and > disable them on phy_exit. > > 2) It has bits to signal id and v

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-07-15 Thread Kishon Vijay Abraham I
On Wednesday 15 July 2015 04:25 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: >> The usb0 phy is connected to an OTG controller, and as such needs some >> special >> handling: >> >> 1) It allows explicit control over the pullups, enable these o

Re: [PATCH v5 0/7] phy-sun4i-usb: Add OTG and newer SoC support

2015-07-15 Thread Kishon Vijay Abraham I
Hi, On Saturday 13 June 2015 06:07 PM, Hans de Goede wrote: > Hi Kishon, > > Here is a patch series with all my oustanding phy-sun4i-usb changes pending > for merging into 4.3. > > This includes the 5th iteration of the OTG support addition, now with the > extcon provider support addition split-

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-15 Thread Michał Pecio
> Looks nice and clean otherwise. > > Were you already going to send a v2 or was this version complete? I didn't intend to change anything. This works fine for me. Maybe proper rounding would be a nice addition, but I'm not sure if it's worth the effort. Now we can at least guarantee that the rat

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-15 Thread Johan Hovold
On Tue, Jul 14, 2015 at 09:29:29PM +0200, Frank Schäfer wrote: > Am 13.07.2015 um 18:47 schrieb Johan Hovold: > > On Mon, Jul 13, 2015 at 06:08:50PM +0200, Michał Pecio wrote: > >>> Commit 57ce61aad748 might be helpful... ;) > >>> > >>> Good luck, > >>> Frank > >>> > >>> > >> Pretty much the same t

[PATCH v2] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-15 Thread Michał Pecio
This commit fixes the following issues: 1. The 9th bit of buf was believed to be the LSB of divisor's exponent, but the hardware interprets it as MSB (9th bit) of the mantissa. The exponent is actually one bit shorter and applies to base 4, not 2 as previously believed. 2. Loop iterations double

Re: [PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect

2015-07-15 Thread Kishon Vijay Abraham I
Hi, On Wednesday 08 July 2015 08:11 PM, Hans de Goede wrote: > sun4i_usb_phy_set_squelch_detect is used by other code, which may be built > as a module, so it should be exported. > > Signed-off-by: Hans de Goede merged this patch to linux-phy tree. Cheers Kishon > --- > Changes in v6: > -New p

[PATCH 4/8][v2]usb:fsl:otg: Signal host drv when host is otg

2015-07-15 Thread Ramneek Mehresh
Set is_otg boolean flag to signal host driver when host is running in context of otg host suspend/resume. Signed-off-by: Ramneek Mehresh --- drivers/usb/phy/phy-fsl-usb.c | 7 ++- include/linux/usb.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/usb/p

[PATCH 7/8][v2]usb:fsl:otg: Remove host drv upon otg bring-up

2015-07-15 Thread Ramneek Mehresh
Change have_hcd variable to remove/suspend host driver on completion of otg initialization for otg auto detect. Signed-off-by: Ramneek Mehresh Reviewed-by: Li Yang-R58472 Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/host/ehci-fsl.c | 2 ++ 1 file cha

[PATCH 1/8][v2]usb:fsl:otg: Make fsl otg driver as tristate

2015-07-15 Thread Ramneek Mehresh
Provide option to load fsl otg driver as loadable module. Signed-off-by: Ramneek Mehresh --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index 869c0cfcad..8a09267 100644 --- a/drivers/usb/phy/Kconfi

[PATCH 5/8][v2]usb:fsl:otg: Modify otg_event to start host drv

2015-07-15 Thread Ramneek Mehresh
Add mechanism to start host driver from inside fsl_otg_even upon each id change interrupt. Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/us

Re: [PATCH v4 0/2] USB OTG PHY driver for NXP LPC18xx family

2015-07-15 Thread Joachim Eastwood
On 15 July 2015 at 12:50, Kishon Vijay Abraham I wrote: > > > On Friday 10 July 2015 02:18 AM, Joachim Eastwood wrote: >> This patch set adds support for the internal USB OTG PHY found >> on NXP LPC18xx and LPC43xx devices. Driver takes care of >> enabling the PHY and setting the clock rate which

Renesas upd7202 (xhci): can't setup

2015-07-15 Thread Jean-Francois SIMON
Hi, We have designed a h/w system with the Renesas USB 3.0 upd7202 controller. We are seeing that sometimes xhci initialization fails with a "can't setup" error message. As a result lsusb doesn't report the USB3.0 ports. Adding traces to the kernel we could see that this is happening in xhci_rese

[PATCH 0/8][v2]Add OTG support for FSL socs

2015-07-15 Thread Ramneek Mehresh
Add support for otg for all freescale socs having internal usb phy. Ramneek Mehresh (8): usb:fsl:otg: Make fsl otg driver as tristate usb:fsl:otg: Add controller version based ULPI and UTMI phy usb:fsl:otg: Add support to add/remove usb host driver usb:fsl:otg: Signal host drv when host

[PATCH 8/8][v2]usb:fsl:otg: Add host-gadget drv sync delay

2015-07-15 Thread Ramneek Mehresh
Resolve synchronization issue between host and gadget drivers upon role-reversal. Signed-off-by: Ramneek Mehresh Reviewed-by: Li Yang-R58472 Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 12 +++- 1 file changed, 11 insertio

[PATCH 2/8][v2]usb:fsl:otg: Add controller version based ULPI and UTMI phy

2015-07-15 Thread Ramneek Mehresh
Add controller version based ULPI and UTMI phy initialization for otg driver. Signed-off-by: Shengzhou Liu Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 20 drivers/usb/phy/phy-fs

[PATCH 6/8][v2]usb:fsl:otg: Combine host/gadget start/resume for ID change

2015-07-15 Thread Ramneek Mehresh
Make call to fsl_otg_event for each id change even. Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/usb/phy/phy-

[PATCH 3/8][v2]usb:fsl:otg: Add support to add/remove usb host driver

2015-07-15 Thread Ramneek Mehresh
Add workqueue to add/remove host driver (outside interrupt context) upon each id change. Signed-off-by: Li Yang Signed-off-by: Ramneek Mehresh --- drivers/usb/host/ehci-fsl.c | 83 ++--- drivers/usb/host/ehci-fsl.h | 20 +++ 2 files changed, 84 in

Re: [PATCH v2 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs

2015-07-15 Thread chunfeng yun
On Tue, 2015-07-14 at 09:45 +0200, Sascha Hauer wrote: > On Tue, Jul 14, 2015 at 02:19:51PM +0800, chunfeng yun wrote: > > hi, > > On Fri, 2015-07-10 at 07:10 +0200, Sascha Hauer wrote: > > > On Wed, Jul 08, 2015 at 05:41:03PM +0800, Chunfeng Yun wrote: > > > > add a DT binding documentation of usb

Re: [PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect

2015-07-15 Thread Kishon Vijay Abraham I
Hi, On Wednesday 08 July 2015 08:11 PM, Hans de Goede wrote: > sun4i_usb_phy_set_squelch_detect is used by other code, which may be built > as a module, so it should be exported. > > Signed-off-by: Hans de Goede > --- > Changes in v6: > -New patch in v6 of the sunxi musb support series > --- >

[PATCH v4 3/3] USB / PM: Allow USB devices to remain runtime-suspended when sleeping

2015-07-15 Thread Tomeu Vizoso
Have dev_pm_ops.prepare return 1 for USB devices and ports so that USB devices can remain runtime-suspended when the system goes to a sleep state, if their wakeup state is correct and they have runtime PM enabled. Signed-off-by: Tomeu Vizoso --- drivers/usb/core/port.c | 6 ++ drivers/usb/

[PATCH v4 0/3]

2015-07-15 Thread Tomeu Vizoso
Hi, this is v4 of an attempt to make easier for devices to remain in runtime PM when the system ges to sleep, mainly to reduce the time spent resuming devices. In this version there's a patch from Alan that relaxes the conditions that allow a device to go directly to the complete phase, thus allo

Re: [PATCH v3 00/11] USB: OTG/DRD Core functionality

2015-07-15 Thread Roger Quadros
On 13/07/15 16:04, Li Jun wrote: > On Mon, Jul 13, 2015 at 01:24:05PM +0300, Roger Quadros wrote: >> Hi, >> >> On 10/07/15 10:58, Li Jun wrote: >>> On Wed, Jul 08, 2015 at 01:19:26PM +0300, Roger Quadros wrote: Hi, This series centralizes OTG/Dual-role functionality in the kernel. >>

Re: [PATCH v3 00/11] USB: OTG/DRD Core functionality

2015-07-15 Thread Roger Quadros
Hi Andrew, On 13/07/15 22:14, Andrew Bresticker wrote: > Hi Roger, > > On Wed, Jul 8, 2015 at 3:19 AM, Roger Quadros wrote: >> Usage model: >> --- >> >> - The OTG controller device is assumed to be the parent of >> the host and gadget controller. It must call usb_otg_register() >> before

Re: [PATCH v3 04/11] otg-fsm: move usb_bus_start_enum into otg-fsm->ops

2015-07-15 Thread Roger Quadros
On 14/07/15 03:34, Peter Chen wrote: > On Mon, Jul 13, 2015 at 01:13:54PM +0300, Roger Quadros wrote: >> Peter, >> >> On 13/07/15 04:58, Peter Chen wrote: >>> On Wed, Jul 08, 2015 at 01:19:30PM +0300, Roger Quadros wrote: This is to prevent missing symbol build error if OTG is enabled (bu

Caro User Account Mail:

2015-07-15 Thread Maria Fernanda Demarchi
Caro User Account Mail: Sua caixa de correio excedeu o limite de armazenamento que é de 20 GB como definido pelo administrador, que está actualmente em execução em 20,9 GB e você pode não ser capaz para enviar ou receber novas mensagens até que volte a validar a sua caixa de correio. Para volta

Re: [PATCH] usb: dwc3: core: avoid NULL pointer dereference

2015-07-15 Thread Murali Karicheri
On 07/02/2015 06:34 PM, Felipe Balbi wrote: commit 3e10a2ce98d1 ("usb: dwc3: add hsphy_interface property") introduced a possible NULL pointer dereference because dwc->hsphy_interface can be NULL. In order to fix it, all we have to do is guard strncmp() against a NULL argument. Fixes: 3e10a2ce9

Re: [PATCH] usb: dwc3: core: avoid NULL pointer dereference

2015-07-15 Thread santosh shilimkar
Felipe, On 7/15/2015 2:56 PM, Murali Karicheri wrote: On 07/02/2015 06:34 PM, Felipe Balbi wrote: commit 3e10a2ce98d1 ("usb: dwc3: add hsphy_interface property") introduced a possible NULL pointer dereference because dwc->hsphy_interface can be NULL. In order to fix it, all we have to do is gu

Re: [PATCH v4 3/3] USB / PM: Allow USB devices to remain runtime-suspended when sleeping

2015-07-15 Thread Rafael J. Wysocki
On Wednesday, July 15, 2015 02:40:08 PM Tomeu Vizoso wrote: > Have dev_pm_ops.prepare return 1 for USB devices and ports so that USB > devices can remain runtime-suspended when the system goes to a sleep > state, if their wakeup state is correct and they have runtime PM enabled. > > Signed-off-by:

Re: detect what type of USB it is connected to

2015-07-15 Thread James
Alan Stern writes: > > On Sat, 11 Jul 2015, James wrote: > > > I have an external drive that has an activity LED. > > It would be nice if it told me if it was connected to a USB2 or USB3 port. > > Is it possible for devices to know what they are connected to? > > How would you expect the drive

Re: [PATCH v3 04/11] otg-fsm: move usb_bus_start_enum into otg-fsm->ops

2015-07-15 Thread Peter Chen
On Wed, Jul 15, 2015 at 04:30:27PM +0300, Roger Quadros wrote: > On 14/07/15 03:34, Peter Chen wrote: > > On Mon, Jul 13, 2015 at 01:13:54PM +0300, Roger Quadros wrote: > >> Peter, > >> > >> On 13/07/15 04:58, Peter Chen wrote: > >>> On Wed, Jul 08, 2015 at 01:19:30PM +0300, Roger Quadros wrote: >