Re: [PATCH v6] usb: common: add API to set usb otg capabilities by device tree

2015-06-23 Thread Roger Quadros
On Mon, 22 Jun 2015 22:36:40 +0800 Li Jun wrote: > On Mon, Jun 22, 2015 at 04:32:56PM +0300, Roger Quadros wrote: > > On Mon, 22 Jun 2015 18:45:37 +0800 > > Li Jun wrote: > > > > > On Mon, Jun 22, 2015 at 12:41:22PM +0300, Roger Quadros wrote: > > > > On Thu, 18 Jun 2015 21:37:04 +0800 > > > >

Re: [PATCH v6] usb: common: add API to set usb otg capabilities by device tree

2015-06-23 Thread Li Jun
On Tue, Jun 23, 2015 at 10:43:28AM +0300, Roger Quadros wrote: > > > > > > If the dr_mode was "otg" for such case and we want OTG disabled then it > > > is really the DT fault. > > > > It's ID pin detect for dual role switch as many current OTG controllers > > have. > > not DT fault, its dt onl

Re: [PATCH 0/2] FTDI CBUS GPIO support

2015-06-23 Thread Johan Hovold
On Mon, Jun 22, 2015 at 10:11:35PM +0200, Stefan Agner wrote: > On 2015-06-22 19:26, Johan Hovold wrote: > > Instead, hang the gpio chip directly off the usb interface (not the > > port), add a new config option, and keep the gpio implementation under > > drivers/usb/serial (possibly in its own fi

Re: [PATCH] usb: dwc3: pci: make better use of gpiod API

2015-06-23 Thread Heikki Krogerus
On Fri, Jun 12, 2015 at 09:10:19AM +0200, Uwe Kleine-König wrote: > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) > which appeared in v3.17-rc1, the gpiod_get* functions take an additional > parameter that allows to specify direction and initial value for output. > > Furt

Re: [PATCH v2 4/7] USB: mos7720: rename DCR

2015-06-23 Thread Johan Hovold
On Thu, Jun 18, 2015 at 05:47:50PM +0530, Sudip Mukherjee wrote: > While building with mn10300 it failed with: > error: expected identifier before '(' token > #define __SYSREG(ADDR, TYPE) (*(volatile TYPE *)(ADDR)) > note: in expansion of macro '__SYSREG' > #define DCR __SYSREG(0xc030, u16)

Re: [PATCH] usb: ulpi: call put_device if device_register fails

2015-06-23 Thread Heikki Krogerus
On Fri, Jun 19, 2015 at 01:12:36AM +0800, ChengYi He wrote: > put_device is required to release the last reference to the device. > > Signed-off-by: ChengYi He > --- > drivers/usb/common/ulpi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/common/ulpi.c

Re: [PATCH v5 00/22] usb: third series of updates for dwc2 driver

2015-06-23 Thread Heiko Stübner
Hi Doug, Am Montag, 22. Juni 2015, 16:00:42 schrieb Doug Anderson: > On Thu, Jun 4, 2015 at 6:12 AM, Kaukab, Yousaf wrote: > >> > Tested-by: Heiko Stuebner > >> > > >> > -- 8< -- > >> > [ 19.799200] BUG: sleeping function called from invalid contex

Re: [PATCH v6] usb: common: add API to set usb otg capabilities by device tree

2015-06-23 Thread Roger Quadros
+ Kukjin, Stephen, for board specific USB question. On Tue, 23 Jun 2015 16:35:49 +0800 Li Jun wrote: > On Tue, Jun 23, 2015 at 10:43:28AM +0300, Roger Quadros wrote: > > > > > > > > If the dr_mode was "otg" for such case and we want OTG disabled then it > > > > is really the DT fault. > > >

[PATCH 14/17] ARM: dts: OMAP5: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node

2015-06-23 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from USB PHY devicetree node. Since "omap_control_usb2phy" and "omap_control_usb3phy" devicetree nodes are no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap5.dtsi | 16 ++

[PATCH 09/17] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node

2015-06-23 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from SATA PHY node. Since "omap_control_sata" note is no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-

[PATCH 17/17] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node

2015-06-23 Thread Kishon Vijay Abraham I
Add "syscon-otghs" property and remove the deprecated "ctrl-module" property from MUSB devicetree node. Since "omap_control_usbotg" devicetree node is no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 +--- 1 file changed, 1 insertion(+

[PATCH 08/17] ARM: dts: dra7: Add dt node for the sycon pcie

2015-06-23 Thread Kishon Vijay Abraham I
Add new device tree node for the control module register space where PCIe registers are present. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 260f3

[PATCH 12/17] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node

2015-06-23 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from USB PHY devicetree nodes. Since "omap_control_usb2phy1", "omap_control_usb3phy1" and "omap_control_usb2phy2" devicetree nodes are no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/b

[PATCH 16/17] ARM: dts: omap4: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node

2015-06-23 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from USB PHY dt node. Since "omap_control_usb2phy" devicetree node is no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 +--- 1 file changed, 1 insertion(+

[PATCH 13/17] ARM: dts: am4372: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node

2015-06-23 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from USB PHY device tree node. Since "am43xx_control_usb2phy1" and "am43xx_control_usb2phy2" devicetree nodes are no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/am4372.dtsi |

[PATCH 15/17] ARM: dts: OMAP5: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node

2015-06-23 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from SATA PHY node. Since "omap_control_sata" devicetree node is no longer used, remove it. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap5.dtsi | 10 +- 1 file changed, 1 insertion(+),

[PATCH 07/17] usb: musb: omap2430: use *syscon* framework to write to mailbox register

2015-06-23 Thread Kishon Vijay Abraham I
Deprecate using phy-omap-control driver to write to the mailbox register and start using *syscon* framework to do the same. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt |7 +- drivers/usb/musb/omap2430.c| 118 ++

[PATCH 02/17] phy: ti-pipe3: use *syscon* framework to power on/off the PHY

2015-06-23 Thread Kishon Vijay Abraham I
Deprecate using phy-omap-control driver to power on/off the PHY and use *syscon* framework to do the same. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/phy/ti-phy.txt | 10 ++- drivers/phy/phy-ti-pipe3.c | 91 ++ 2 file

[PATCH 05/17] phy: omap-usb2: Add a new compatible string for USB2 PHY2

2015-06-23 Thread Kishon Vijay Abraham I
The USB2 PHY2 has a different register map compared to USB2 PHY1 to power on/off the PHY. In order to handle it, add a new "compatible" string. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/phy/ti-phy.txt |2 ++ drivers/phy/phy-omap-usb2.c |

[PATCH 00/17] Deprecate phy-omap-control and use SYSCON

2015-06-23 Thread Kishon Vijay Abraham I
phy-omap-control driver was added when there was no proper infrastructure for doing control module initializations. Now with SYSCON framework being added to the kernel, phy-omap-control shouldn't be needed. This series is about adapting phy-omap-usb2, phy-ti-pipe3 and omap2430 to use SYSCON framew

[PATCH 03/17] phy: ti-pipe3: use *syscon* framework to set PCS value of the PHY

2015-06-23 Thread Kishon Vijay Abraham I
Deprecate using phy-omap-control driver to set PCS value of the PHY and start using *syscon* framework to do the same. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/phy/ti-phy.txt |2 ++ drivers/phy/phy-ti-pipe3.c | 32 +++

[PATCH 01/17] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe

2015-06-23 Thread Kishon Vijay Abraham I
No functional change. Previously omap_control_phy_power() was used to power off the PHY during probe. But once PIPE3 driver is adapted to use syscon, omap_control_phy_power() cannot be used. Hence used ti_pipe3_power_off to power off the PHY. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy

[PATCH 10/17] ARM: dts: dra7: Use "syscon-phy-power" and "syscon-pcs" in PCIe PHY node

2015-06-23 Thread Kishon Vijay Abraham I
Add "syscon-phy-power" property and "syscon-pcs" property which can be used to perform the control module initializations and remove the deprecated "ctrl-module" property from PCIe PHY dt nodes. Phandle to "sysclk" clock node is also added to the PCIe PHY node since some of the syscon initializati

[PATCH 06/17] phy: omap-usb2: use *syscon* framework to power on/off the PHY

2015-06-23 Thread Kishon Vijay Abraham I
Deprecate using phy-omap-control driver to power on/off the PHY, and use *syscon* framework to do the same. This handles powering on/off the PHY for the USB2 PHYs used in various TI SoCs. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/phy/ti-phy.txt |6 +- driver

[PATCH 11/17] ARM: dts: dra7: Use "ti,dra7x-usb2-phy2" compatible string for USB2 PHY2

2015-06-23 Thread Kishon Vijay Abraham I
The USB2 PHY2 has a different register map compared to USB2 PHY1 to power on/off the PHY. In order to handle it, use the new compatible string "ti,dra7x-usb2-phy2" for the second instance of USB2 PHY. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi |2 +- 1 file changed

[PATCH 04/17] phy: omap-usb2: use omap_usb_power_off to power off the PHY during probe

2015-06-23 Thread Kishon Vijay Abraham I
No functional change. Previously omap_control_phy_power() was used to power off the PHY during probe. But once phy-omap-usb2 driver is adapted to use syscon, omap_control_phy_power() cannot be used. Hence used omap_usb_power_off to power off the PHY. Signed-off-by: Kishon Vijay Abraham I --- dri

[PATCH v2] usb: dwc3: pci: make better use of gpiod API

2015-06-23 Thread Uwe Kleine-König
Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) which appeared in v3.17-rc1, the gpiod_get* functions take an additional parameter that allows to specify direction and initial value for output. Use this additional parameter and the _optional variant to simplify the driver a

Re: [PATCH v6] usb: common: add API to set usb otg capabilities by device tree

2015-06-23 Thread Li Jun
On Tue, Jun 23, 2015 at 02:56:06PM +0300, Roger Quadros wrote: > + Kukjin, Stephen, > > for board specific USB question. > > On Tue, 23 Jun 2015 16:35:49 +0800 > Li Jun wrote: > > > On Tue, Jun 23, 2015 at 10:43:28AM +0300, Roger Quadros wrote: > > > > > > > > > > If the dr_mode was "otg" for

re: usb: dwc2: add controller hibernation support

2015-06-23 Thread Dan Carpenter
Hello Gregory Herrero, The patch d17ee77b3044: "usb: dwc2: add controller hibernation support" from Apr 29, 2015, leads to the following static checker warning: drivers/usb/dwc2/core.c:77 dwc2_backup_host_registers() error: scheduling with locks held: 'spin_lock:lock' drivers/usb

[PATCH v3] USB: mos7720: rename registers

2015-06-23 Thread Sudip Mukherjee
Some of the register names defined here are matching with registers defined in other places. Like DCR is defined here and DCR is also a register in mn10300 architecture. So when we are building this with mn10300, build fails. To avoid we rename all the registers. Signed-off-by: Sudip Mukherjee --

Re: [Patch v1] ax88179_178a: add reset functionality in reset_resume

2015-06-23 Thread David Miller
From: Vivek Bhagat Date: Sun, 21 Jun 2015 11:41:43 +0530 > From d178065c9e3cfa8a45ef537fae7412775339beb0 Mon Sep 17 00:00:00 2001 > From: Vivek Kumar Bhagat > Date: Thu, 11 Jun 2015 07:23:46 -0700 > Subject: [PATCH] ax88179_178a: add reset functionality in reset_resume > > Without reset functio

Re: [PATCH v5 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-06-23 Thread Alan Stern
On Tue, 23 Jun 2015, Ruslan Bilovol wrote: > Change behavior during registration of gadgets and > gadget drivers in udc-core. Instead of previous > approach when for successful probe of usb gadget driver > at least one usb gadget should be already registered > use another one where gadget drivers

RE: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-23 Thread David Laight
From: Of James Bottomley > Sent: 22 June 2015 18:36 > To: Alan Stern ... > > > Obviously, for a disk with a writeback cache that can't do flush, that > > > window is much wider and the real solution should be to try to switch > > > the cache to write through. > > > > I agree. Doing the switch manu

Re: [PATCH 01/17] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe

2015-06-23 Thread Roger Quadros
On Tue, 23 Jun 2015 17:28:46 +0530 Kishon Vijay Abraham I wrote: > No functional change. Previously omap_control_phy_power() was used to power > off the PHY during probe. But once PIPE3 driver is adapted to use syscon, > omap_control_phy_power() cannot be used. Hence used ti_pipe3_power_off > to

Re: [PATCH 02/17] phy: ti-pipe3: use *syscon* framework to power on/off the PHY

2015-06-23 Thread Roger Quadros
Hi Kishon, On Tue, 23 Jun 2015 17:28:47 +0530 Kishon Vijay Abraham I wrote: > Deprecate using phy-omap-control driver to power on/off the PHY and > use *syscon* framework to do the same. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/phy/ti-phy.txt | 10

ISO interval in the xhci driver

2015-06-23 Thread Bernd Porr
Hi all, is that right that setting urb->interval does not work for the xhci driver? Seems so that the driver (in my case the usbduxsigma.c) needs to request the xhci_interval and then has to live with that frame rate so essentially 125us? Is that right? /Bernd xhci-ring.c: (I've added a cou

RE: usb: dwc2: add controller hibernation support

2015-06-23 Thread Herrero, Gregory
Hello Dan Carpenter, Yousaf Kaukab did a patch to embed those backup registers in struct dwc2_hsotg. This way, there is no more allocation needed in dwc2_backup_host_registers(). Here is the patch title: "usb: dwc2: embed storage for reg backup in struct dwc2_hsotg" It has been submitted to linu

urb->interval ignored in xhci?

2015-06-23 Thread Bernd Porr
Hi all, is that right that setting urb->interval does not work for the xhci driver? Seems so that the driver (in my case the usbduxsigma.c) needs to request the xhci_interval and then has to live with that frame rate so essentially 125us? Is that right? /Bernd xhci-ring.c: (I've added a cou

Re: [PATCH v5 00/22] usb: third series of updates for dwc2 driver

2015-06-23 Thread John Youn
On 6/22/2015 4:00 PM, Doug Anderson wrote: > Hi, > > On Thu, Jun 4, 2015 at 6:12 AM, Kaukab, Yousaf > wrote: Tested-by: Heiko Stuebner -- 8< -- [ 19.799200] BUG: sleeping function called from invalid context at >>> mm/slab.c:2863

Re: [PATCH v5 00/22] usb: third series of updates for dwc2 driver

2015-06-23 Thread Doug Anderson
John and Felipe, On Tue, Jun 23, 2015 at 10:56 AM, John Youn wrote: > On 6/22/2015 4:00 PM, Doug Anderson wrote: >> Hi, >> >> On Thu, Jun 4, 2015 at 6:12 AM, Kaukab, Yousaf >> wrote: > Tested-by: Heiko Stuebner > > -- 8< -- > [ 19.79920

Re: [PATCH v5 00/22] usb: third series of updates for dwc2 driver

2015-06-23 Thread Felipe Balbi
On Tue, Jun 23, 2015 at 02:56:23PM -0700, Doug Anderson wrote: > John and Felipe, > > On Tue, Jun 23, 2015 at 10:56 AM, John Youn wrote: > > On 6/22/2015 4:00 PM, Doug Anderson wrote: > >> Hi, > >> > >> On Thu, Jun 4, 2015 at 6:12 AM, Kaukab, Yousaf > >> wrote: > > Tested-by: Heiko Stue

Re: [PATCH 0/2] FTDI CBUS GPIO support

2015-06-23 Thread Stefan Agner
On 2015-06-23 11:22, Johan Hovold wrote: > On Mon, Jun 22, 2015 at 10:11:35PM +0200, Stefan Agner wrote: >> On 2015-06-22 19:26, Johan Hovold wrote: > >> > Instead, hang the gpio chip directly off the usb interface (not the >> > port), add a new config option, and keep the gpio implementation unde

Re: [PATCH v5 08/23] usb: chipidea: set usb gadeget's otg capabilities

2015-06-23 Thread Peter Chen
On Wed, Jun 17, 2015 at 07:40:15PM +0800, Li Jun wrote: > Set gadget's otg capabilities according to controller's capability and otg > properties in device tree. > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/core.c | 8 > drivers/usb/chipidea/udc.c | 7 ++- > include/lin

Re: [PATCH v5 08/23] usb: chipidea: set usb gadeget's otg capabilities

2015-06-23 Thread Li Jun
On Wed, Jun 24, 2015 at 11:04:43AM +0800, Peter Chen wrote: > On Wed, Jun 17, 2015 at 07:40:15PM +0800, Li Jun wrote: > > Set gadget's otg capabilities according to controller's capability and otg > > properties in device tree. > > > > Signed-off-by: Li Jun > > --- > > drivers/usb/chipidea/core.

Re: [PATCH v5 08/23] usb: chipidea: set usb gadeget's otg capabilities

2015-06-23 Thread Peter Chen
On Wed, Jun 24, 2015 at 11:34:23AM +0800, Li Jun wrote: > On Wed, Jun 24, 2015 at 11:04:43AM +0800, Peter Chen wrote: > > On Wed, Jun 17, 2015 at 07:40:15PM +0800, Li Jun wrote: > > > Set gadget's otg capabilities according to controller's capability and otg > > > properties in device tree. > > >

Re: [PATCH v6 2/3] USB: io_ti: Move request_firmware() calls out of download_fw()

2015-06-23 Thread Peter Berger
On Mon, 2015-06-22 at 11:43 +0200, Johan Hovold wrote: > On Thu, Jun 18, 2015 at 06:43:35AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > The io_ti driver fails to download firmware to Edgeport > > devices such as the EP/416, even when the on-disk firmware image > > (/lib/firm

Re: [PATCH v6 1/3] USB: io_ti: Increase insufficient timeout for firmware downloads

2015-06-23 Thread Peter Berger
On Mon, 2015-06-22 at 10:45 +0200, Johan Hovold wrote: > On Thu, Jun 18, 2015 at 06:43:34AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > The io_ti driver fails to download firmware to Edgeport devices such as > > the EP/416. One of the problems is that the default 1 second t

Re: [PATCH v6 3/3] USB: io_ti: Add heartbeat to keep idle Edgeport ports from disconnecting

2015-06-23 Thread Peter Berger
On Mon, 2015-06-22 at 12:01 +0200, Johan Hovold wrote: > On Thu, Jun 18, 2015 at 06:43:36AM -0500, Peter E. Berger wrote: > > From: "Peter E. Berger" > > > > When using newer Edgeport devices such as the EP/416, idle ports are > > automatically bounced (disconnected and then reconnected) approxim

[PATCH 1/1] usb: usleep_range is preferred over udelay where wakeup is flexible

2015-06-23 Thread Sunny Kumar
According to Documentation/timers/timers-howto.txt" udelay() is only called once from a place where sleeping is allowed. We can replace it with a call to usleep_range() with a reasonable upper limit. Signed-off-by: Sunny Kumar --- drivers/usb/storage/transport.c | 2 +- 1 file changed, 1 inserti