Re: cdc-acm: use with Android Download Mode?

On Mon, 2015-06-08 at 19:15 +0200, JPT wrote: > this repeats until cdc runs out of some handles (64) > currently it's 8: > $ lsmod|grep cdc_acm > cdc_acm36864 8 > > module cdc_acm cannot be unloaded. > I think this is a bug. It depends on whether file handles are open. > In gen

Re: [PATCH] hid: Add secondary vendor id for the marco, USB_DEVICE_ID_MS_TYPE_COVER_3_V2

On 21 May 2015 at 04:40, Alan Wu wrote: > Hello Jiri, > I believe the patch may work, but I would rename the IDs. Obviously > I can't test Surface 3 non-Pro cover, but the difference is likely due > to the following: > > This is 0x07dc (I do own) > http://www.microsoftstore.com/store/msusa/en_U

[PATCH v2 RESEND 7/9] xhci: remove XHCI_TRUST_TX_LENGTH quirk and handle it as default

Now including Renesas uPD720201 we got four xhci vendors that return Success instead of short transfer when there are still unstraferred bytes left. The driver anyway checks the untransferred bytes and suggest adding the quirk if needed, so we can as well make it default behavior and get rid of the

RE: [PATCH v2 RESEND 7/9] xhci: remove XHCI_TRUST_TX_LENGTH quirk and handle it as default

From: Mathias Nyman > Now including Renesas uPD720201 we got four xhci vendors that return > Success instead of short transfer when there are still unstraferred bytes > left. The driver anyway checks the untransferred bytes and suggest adding > the quirk if needed, so we can as well make it default

Re: Patch Request of option.c module to support Olicard-300 (2020:4000)

Greg KH wrote: > On Tue, Jun 09, 2015 at 01:14:30AM +0200, Joe wrote: >> >> What format do you mean exactly? >> Which part of that document are you exactly referring? > > The sections about the signed-off-by line and the proper description and > subject lines :) > >> Nice to contribute at kernel

Re: [PATCH v2 01/22] usb: add OTG version number in usb_otg_descriptor

Hi, On Mon, 8 Jun 2015 23:01:56 +0800 Li Jun wrote: > From: Macpaul Lin > > OTG 2.0 introduces bcdOTG to identify the OTG and EH supplement release > number with which the OTG device is compliant, so adds it for > usb_otg_descriptor. > > Signed-off-by: Macpaul Lin > Signed-off-by: Li Jun >

Re: [PATCH v2 04/22] usb: gadget: composite: add USB_DT_OTG request handling

Hi, On Mon, 8 Jun 2015 23:01:59 +0800 Li Jun wrote: > From: Macpaul Lin > > Copy usb_otg_descriptor from config's descriptor if host requests > USB_DT_OTG. > > Signed-off-by: Macpaul Lin > Signed-off-by: Li Jun > --- > drivers/usb/gadget/composite.c | 21 + > 1 file cha

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

On Mon, 8 Jun 2015 23:02:00 +0800 Li Jun wrote: > Add otg version, srp, hnp and adp support for usb OTG port, then those OTG > features don't have to be decided by usb gadget drivers. > > Signed-off-by: Li Jun > --- > Documentation/devicetree/bindings/usb/generic.txt | 10 ++ > 1 file

Re: [PATCH v2 06/22] usb: common: add API to get usb otg features from device tree

Hi, On Mon, 8 Jun 2015 23:02:01 +0800 Li Jun wrote: > Check property of usb hardware to get otg version and if SRP, HNP and ADP > are supported. > > Signed-off-by: Li Jun > --- > drivers/usb/common/common.c | 64 > + > include/linux/usb/of.h |

Re: [PATCH v2 01/22] usb: add OTG version number in usb_otg_descriptor

On Mon, 8 Jun 2015 23:01:56 +0800 Li Jun wrote: > From: Macpaul Lin > > OTG 2.0 introduces bcdOTG to identify the OTG and EH supplement release > number with which the OTG device is compliant, so adds it for > usb_otg_descriptor. > > Signed-off-by: Macpaul Lin > Signed-off-by: Li Jun > ---

Re: [PATCH v2 07/22] usb: chipidea: udc: set usb gadeget's otg config

On Mon, 8 Jun 2015 23:02:02 +0800 Li Jun wrote: > Set gadget's otg features according to controller's capability and usb > property in device tree. > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/core.c | 16 > drivers/usb/chipidea/udc.c | 20 +++- >

Re: [PATCH v2 RESEND 7/9] xhci: remove XHCI_TRUST_TX_LENGTH quirk and handle it as default

On 09.06.2015 14:43, David Laight wrote: > From: Mathias Nyman >> Now including Renesas uPD720201 we got four xhci vendors that return >> Success instead of short transfer when there are still unstraferred bytes >> left. The driver anyway checks the untransferred bytes and suggest adding >> the qui

Re: [PATCH v2 09/22] usb: gadget: add usb_otg_descriptor_add interface to init usb_otg_descriptor

On Mon, 8 Jun 2015 23:02:04 +0800 Li Jun wrote: > Allocate usb_otg_descriptor and initialize it according to gadget otg > options, if none of options is not set, keep bmAttributes setting as > current gadget drivers, with this new interface, usb_otg_descriptor can > include bcdOTG if OTG 2.0 or l

Re: [PATCH v2 03/22] usb: add OTG feature options to gadget structure.

On Mon, 8 Jun 2015 23:01:58 +0800 Li Jun wrote: > From: Macpaul Lin > > Add ADP, HNP and SRP feature options and otg version to gadget structure. > > Signed-off-by: Macpaul Lin > Signed-off-by: Li Jun > --- > include/linux/usb/gadget.h | 11 +++ > 1 file changed, 11 insertions(+) >

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: > On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Herring wrote: >> On Mon, Jun 8, 2015 at 10:02 AM, Li Jun wrote: >> > Add otg version, srp, hnp and adp support for usb OTG port, then those OTG >> > features don't have to be decided by usb gadget drive

Re: [PATCH v2 09/22] usb: gadget: add usb_otg_descriptor_add interface to init usb_otg_descriptor

On Mon, 8 Jun 2015 23:02:04 +0800 Li Jun wrote: > Allocate usb_otg_descriptor and initialize it according to gadget otg > options, if none of options is not set, keep bmAttributes setting as > current gadget drivers, with this new interface, usb_otg_descriptor can > include bcdOTG if OTG 2.0 or l

Re: [PATCH v2 10/22] usb: gadget: configfs: init and add usb_otg_descriptor for usb configurations

On Mon, 8 Jun 2015 23:02:05 +0800 Li Jun wrote: > Use usb_otg_descriptor_add to allocate and initialize usb_otg_descriptor, > add it for each usb configurations, free it while composite unbind. > > Signed-off-by: Li Jun > --- > drivers/usb/gadget/configfs.c | 26 +- >

Re: [PATCH RESEND (1-3)/4] Add usb interface authorization

Am Montag, den 08.06.2015, 07:40 -0700 schrieb Greg KH: > On Mon, Jun 08, 2015 at 03:24:26PM +0200, Stefan Koch wrote: > > Hi > > > > This is a patch that introduces an interface authorization for USB devices. > > > > The kernel supports already a device authorization bacause of wireless USB. > >

Re: [PATCH RESEND 4/4] Add usb interface authorization

Am Montag, den 08.06.2015, 07:40 -0700 schrieb Greg KH: > On Mon, Jun 08, 2015 at 03:24:26PM +0200, Stefan Koch wrote: > > Hi > > > > This is a patch that introduces an interface authorization for USB devices. > > > > The kernel supports already a device authorization bacause of wireless USB. > >

Re: [PATCH v2 01/22] usb: add OTG version number in usb_otg_descriptor

On Tue, Jun 09, 2015 at 03:56:44PM +0300, Roger Quadros wrote: > > > On Mon, 8 Jun 2015 23:01:56 +0800 > Li Jun wrote: > > > From: Macpaul Lin > > > > OTG 2.0 introduces bcdOTG to identify the OTG and EH supplement release > > number with which the OTG device is compliant, so adds it for > >

Re: [PATCH v2 04/22] usb: gadget: composite: add USB_DT_OTG request handling

On Tue, Jun 09, 2015 at 03:27:29PM +0300, Roger Quadros wrote: > Hi, > > On Mon, 8 Jun 2015 23:01:59 +0800 > Li Jun wrote: > > > From: Macpaul Lin > > > > Copy usb_otg_descriptor from config's descriptor if host requests > > USB_DT_OTG. > > > > Signed-off-by: Macpaul Lin > > Signed-off-by: L

Re: [PATCH v2 06/22] usb: common: add API to get usb otg features from device tree

On Tue, Jun 09, 2015 at 03:55:29PM +0300, Roger Quadros wrote: > Hi, > > On Mon, 8 Jun 2015 23:02:01 +0800 > Li Jun wrote: > > > Check property of usb hardware to get otg version and if SRP, HNP and ADP > > are supported. > > > > Signed-off-by: Li Jun > > --- > > drivers/usb/common/common.c |

Re: questions about uas

On Tue, 9 Jun 2015, Tom Yan wrote: > Hi all! > > I have the following adapter: > http://www.startech.com/HDD/Adapters/USB-3-SATA-adapter-cable-with-UASP~USB3S2SAT3CB > > which I am using it for: > http://ark.intel.com/products/56604/Intel-SSD-X25-M-Series-80GB-2_5in-SATA-3Gbs-50nm-MLC > > and I

Re: [PATCH v2 01/22] usb: add OTG version number in usb_otg_descriptor

On Tue, 9 Jun 2015, Li Jun wrote: > > > -/* USB_DT_OTG (from OTG 1.0a supplement) */ > > > +/* USB_DT_OTG */ > > > struct usb_otg_descriptor { > > > __u8 bLength; > > > __u8 bDescriptorType; > > > > > > __u8 bmAttributes; /* support for HNP, SRP, etc */ > > > + struct bcdOTG otg_re

Re: UAS problem

On Tue, 9 Jun 2015, James wrote: > Alan Stern writes: > > > > > On Mon, 8 Jun 2015, Oliver Neukum wrote: > > > > A lot of resets with no reason. You need to enable debugging > > > for the storage driver. > > > > A usbmon trace would be easier to read and just as good for debugging. > > > > A

Re: [PATCH v2 06/22] usb: common: add API to get usb otg features from device tree

On Tue, Jun 09, 2015 at 03:55:29PM +0300, Roger Quadros wrote: > Hi, > > On Mon, 8 Jun 2015 23:02:01 +0800 > Li Jun wrote: > > > Check property of usb hardware to get otg version and if SRP, HNP and ADP > > are supported. > > > > Signed-off-by: Li Jun > > --- > > drivers/usb/common/common.c |

Re: [PATCH RESEND (1-3)/4] Add usb interface authorization

On Tue, 9 Jun 2015, Stefan Koch wrote: > Hi > > I think whitespaces should be ok now. I have tested now three mail > clients... > > This patch series enables the interface authorization. The description > is improved now. Is the series correct now? This patch series is much, much more complicat

Re: [PATCH RESEND 4/4] Add usb interface authorization

On Tue, 9 Jun 2015, Stefan Koch wrote: > Hi, > > this is an bugfix for the XHCI driver. It is not needed for the > interface authorization. But there could be NULL pointers if a devices > initialization/registration is not finished. This should not be part of the same series as the other patches

[RFC PATCH] usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes

DWC3 uses bounce buffer to handle non max packet aligned OUT transfers and the size of bounce buffer is 512 bytes. However if the host initiates OUT transfers of size more than 512 bytes (and non max packet aligned), the driver throws a WARN dump but still programs the TRB to receive more than 512

Re: Patch Request of option.c module to support Olicard-300 (2020:4000)

On Tue, Jun 09, 2015 at 02:13:57PM +0200, Joe wrote: > Greg KH wrote: > > > On Tue, Jun 09, 2015 at 01:14:30AM +0200, Joe wrote: > >> > >> What format do you mean exactly? > >> Which part of that document are you exactly referring? > > > > The sections about the signed-off-by line and the proper

Re: [RFC PATCH] usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes

Hi, On Tuesday 09 June 2015 08:09 PM, Michael Trimarchi wrote: Hi On Jun 9, 2015 4:36 PM, "Kishon Vijay Abraham I" mailto:kis...@ti.com>> wrote: > > DWC3 uses bounce buffer to handle non max packet aligned OUT transfers and > the size of bounce buffer is 512 bytes. However if the host initia

Re: [PATCH RESEND (1-3)/4] Add usb interface authorization

On Tue, Jun 09, 2015 at 03:48:47PM +0200, Stefan Koch wrote: > Am Montag, den 08.06.2015, 07:40 -0700 schrieb Greg KH: > > On Mon, Jun 08, 2015 at 03:24:26PM +0200, Stefan Koch wrote: > > > Hi > > > > > > This is a patch that introduces an interface authorization for USB > > > devices. > > > > >

Re: [RFC PATCH] usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes

On Tue, 9 Jun 2015, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 09 June 2015 08:09 PM, Michael Trimarchi wrote: > > Hi > > > > On Jun 9, 2015 4:36 PM, "Kishon Vijay Abraham I" > > wrote: > > > > > > DWC3 uses bounce buffer to handle non max packet aligned OUT trans

Re: UAS problem

On 06/09/15 10:13, Alan Stern wrote: \Good grief, don't use wireshark! It captures every single byte of data transferred, which is enormously more than what we need. Instead, follow the instructions in Documentation/usb/usbmon.txt. Alan Stern That was easier than wireshark. The usbmon t

Re: [RFC PATCH] usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes

Hi, On Tuesday 09 June 2015 08:29 PM, Alan Stern wrote: On Tue, 9 Jun 2015, Kishon Vijay Abraham I wrote: Hi, On Tuesday 09 June 2015 08:09 PM, Michael Trimarchi wrote: Hi On Jun 9, 2015 4:36 PM, "Kishon Vijay Abraham I" mailto:kis...@ti.com>> wrote: > > DWC3 uses bounce buffer to handl

Re: [PATCH v2 01/22] usb: add OTG version number in usb_otg_descriptor

On Tue, 9 Jun 2015 10:16:23 -0400 Alan Stern wrote: > On Tue, 9 Jun 2015, Li Jun wrote: > > > > > -/* USB_DT_OTG (from OTG 1.0a supplement) */ > > > > +/* USB_DT_OTG */ > > > > struct usb_otg_descriptor { > > > > __u8 bLength; > > > > __u8 bDescriptorType; > > > > > > > >

Re: [RFC PATCH] usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes

On Tue, 9 Jun 2015, Kishon Vijay Abraham I wrote: > > Why not just make the bounce buffer size the same as the maxpacket > > size? In other words, 1024 bytes instead of 512, for ep0 on a USB-3 > > device. > > It would still be possible for the host to send data more than 1024 bytes no? Yes. >

Re: [PATCH v2 06/22] usb: common: add API to get usb otg features from device tree

On Tue, 9 Jun 2015 22:15:53 +0800 Li Jun wrote: > On Tue, Jun 09, 2015 at 03:55:29PM +0300, Roger Quadros wrote: > > Hi, > > > > On Mon, 8 Jun 2015 23:02:01 +0800 > > Li Jun wrote: > > > > > Check property of usb hardware to get otg version and if SRP, HNP and ADP > > > are supported. > > > >

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

Rob, On Tue, 9 Jun 2015 08:26:20 -0500 Rob Herring wrote: > On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: > > On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Herring wrote: > >> On Mon, Jun 8, 2015 at 10:02 AM, Li Jun wrote: > >> > Add otg version, srp, hnp and adp support for usb OTG port, then

Re: UAS problem

On Tue, 9 Jun 2015, James wrote: > On 06/09/15 10:13, Alan Stern wrote: > > > > \Good grief, don't use wireshark! It captures every single byte of > > data transferred, which is enormously more than what we need. > > > > Instead, follow the instructions in Documentation/usb/usbmon.txt. > > > > Al

Re: [PATCH RESEND (1-3)/4] Add usb interface authorization

Am Dienstag, den 09.06.2015, 07:49 -0700 schrieb Greg KH: > On Tue, Jun 09, 2015 at 03:48:47PM +0200, Stefan Koch wrote: > > Am Montag, den 08.06.2015, 07:40 -0700 schrieb Greg KH: > > > On Mon, Jun 08, 2015 at 03:24:26PM +0200, Stefan Koch wrote: > > > > Hi > > > > > > > > This is a patch that in

Re: UAS problem

On 06/09/15 11:33, Alan Stern wrote: The usbmon trace is: http://lockie.ca/1.mon.out The trace shows numerous -71 errors. These are low-level communication errors, caused by noise in the USB cable or something of that sort. In each case the system recovered and retried the failed command suc

Re: [PATCH RESEND (1-3)/4] Add usb interface authorization

Am Dienstag, den 09.06.2015, 10:31 -0400 schrieb Alan Stern: > On Tue, 9 Jun 2015, Stefan Koch wrote: > > > Hi > > > > I think whitespaces should be ok now. I have tested now three mail > > clients... > > > > This patch series enables the interface authorization. The description > > is improved

Re: [RFC PATCH] usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes

Hi, On Tuesday 09 June 2015 08:46 PM, Alan Stern wrote: On Tue, 9 Jun 2015, Kishon Vijay Abraham I wrote: Why not just make the bounce buffer size the same as the maxpacket size? In other words, 1024 bytes instead of 512, for ep0 on a USB-3 device. It would still be possible for the host to

Re: UAS problem

On 06/09/15 11:33, Alan Stern wrote: On Tue, 9 Jun 2015, James wrote: On 06/09/15 10:13, Alan Stern wrote: \Good grief, don't use wireshark! It captures every single byte of data transferred, which is enormously more than what we need. Instead, follow the instructions in Documentation/usb/

Re: [PATCH RESEND (1-3)/4] Add usb interface authorization

Hi Stefan, On Tue, Jun 9, 2015 at 6:38 PM, Stefan Koch wrote: > Am Dienstag, den 09.06.2015, 07:49 -0700 schrieb Greg KH: >> On Tue, Jun 09, 2015 at 03:48:47PM +0200, Stefan Koch wrote: >> > Am Montag, den 08.06.2015, 07:40 -0700 schrieb Greg KH: >> > > On Mon, Jun 08, 2015 at 03:24:26PM +0200, S

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

On Tue, Jun 9, 2015 at 10:29 AM, Roger Quadros wrote: > Rob, > > On Tue, 9 Jun 2015 08:26:20 -0500 > Rob Herring wrote: > >> On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: >> > On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Herring wrote: >> >> On Mon, Jun 8, 2015 at 10:02 AM, Li Jun wrote: >> >>

Re: [RFC PATCH] usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes

On Tue, Jun 09, 2015 at 10:59:50AM -0400, Alan Stern wrote: > On Tue, 9 Jun 2015, Kishon Vijay Abraham I wrote: > > > Hi, > > > > On Tuesday 09 June 2015 08:09 PM, Michael Trimarchi wrote: > > > Hi > > > > > > On Jun 9, 2015 4:36 PM, "Kishon Vijay Abraham I" > > > wrote: >

Re: [PATCH RESEND (1-3)/4] Add usb interface authorization

On Tue, 9 Jun 2015, Stefan Koch wrote: > Am Dienstag, den 09.06.2015, 10:31 -0400 schrieb Alan Stern: > > On Tue, 9 Jun 2015, Stefan Koch wrote: > > > > > Hi > > > > > > I think whitespaces should be ok now. I have tested now three mail > > > clients... > > > > > > This patch series enables the

Re: [RFC PATCH] usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes

On Tue, 9 Jun 2015, Kishon Vijay Abraham I wrote: > > But with a bounce buffer that's only 512 bytes long, you can never send > > an entire packet's worth of data. If the bounce buffer is 1024 bytes > > for control endpoint, 512 bytes should be sufficient to send entire packet > right? Yes, yo

Re: [PATCH v3 0/6] Marvell PXA1928 USB support

On Fri, May 29, 2015 at 11:38:40AM -0500, Rob Herring wrote: > This series adds USB PHYs and EHCI host drivers for the Marvell PXA1928 > SOC. > > The OTG block is based on ChipIdea and works with the "chipidea,usb2" > compatible driver as is just by adding the PHY driver. Yay! After more > testin

Re: Patch Request of option.c module to support Olicard-300 (2020:4000)

Greg KH wrote: > On Tue, Jun 09, 2015 at 02:13:57PM +0200, Joe wrote: >> >> So, seems there's no way to maintain my real personal infos anonymous. >> Did I well understand or there's some workaround to post a patch with >> for example, invented Name Surname to prevent real ones to be public? > >

Re: [PATCH 1/3] usb: dwc2: host: allocate qh before atomic enqueue

On 6/5/2015 7:23 AM, Mian Yousaf Kaukab wrote: > To avoid sleep while atomic bugs, allocate qh before calling > dwc2_hcd_urb_enqueue. qh pointer can be used directly now instead of > passing ep->hcpriv as double pointer. > > Signed-off-by: Mian Yousaf Kaukab > --- > drivers/usb/dwc2/hcd.c

Re: Patch Request of option.c module to support Olicard-300 (2020:4000)

Joe wrote: > I'm considering the idea of posting without that tag for now, > so that you can evaluate/add my patch as soon as possible. > However... will it be possible, in case, to correct my previous > subbmitted patch to add the Suggested-by tag? No, that's not possible. Once a commit has been

USB-PHY: type-C power role ??

Hi, With the advent of USB PD over type-C connector, the data_roles and the power_roles can be swapped independently. i.e. now the host for the data need not have to be powering VBUS. Going through the phy code(drivers/usb/phy/phy.c) makes me think that the phy layer assumes that both the DATA_ROL

Re: [PATCH] usb: dwc2: fix unnecessary USB overcurrent condition

Hi Dinh, Responding again to the proper message to add linux-usb. And also added more comments. On 5/26/2015 7:32 PM, dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > For platforms that use a ULPI phy, we should enable the external VbusValid > signal instead. I don't think it shou

Re: [RFC PATCH] usb: dwc3: ep0: Fix mem corruption on OUT transfers of more than 512 bytes

Hi, On Tuesday 09 June 2015 10:54 PM, Alan Stern wrote: On Tue, 9 Jun 2015, Kishon Vijay Abraham I wrote: But with a bounce buffer that's only 512 bytes long, you can never send an entire packet's worth of data. If the bounce buffer is 1024 bytes for control endpoint, 512 bytes should be su

Re: Patch Request of option.c module to support Olicard-300 (2020:4000)

On 2015-06-10 06:20, Peter Stuge wrote: Joe wrote: I'm considering the idea of posting without that tag for now, so that you can evaluate/add my patch as soon as possible. However... will it be possible, in case, to correct my previous subbmitted patch to add the Suggested-by tag? No, that's no