Re: [PATCH v4 0/2] Remaining sunxi musb patches

2015-06-02 Thread Hans de Goede
Hi, On 01-06-15 20:34, Felipe Balbi wrote: On Mon, Jun 01, 2015 at 11:30:45AM -0700, Hans de Goede wrote: Hi, On Sunday, May 31, 2015 at 6:10:32 PM UTC+2, Hans de Goede wrote: Hi Kishon & Felipe, Here is an updated version of the remaining (not yet merged in Felipe's tree) sunxi musb patche

Re: [PATCH 1/2] Bluetooth: Add reset_resume function

2015-06-02 Thread Oliver Neukum
On Mon, 2015-06-01 at 18:14 -0700, Laura Abbott wrote: > Bluetooth devices off of some buses such as USB may lose power across > suspend/resume. When this happens, drivers may need to have the setup > function called again and behave differently than a cold power on. Yes, but what is the point? We

[PATCH 1/1] cdc-acm: Add support of ATOL FPrint fiscal printers

2015-06-02 Thread Alexey Sokolov
ATOL FPrint fiscal printers require usb_clear_halt to be executed to work properly. Add quirk to fix the issue. Signed-off-by: Alexey Sokolov --- drivers/usb/class/cdc-acm.c | 9 + drivers/usb/class/cdc-acm.h | 1 + 2 files changed, 10 insertions(+) diff --git a/drivers/usb/class/cdc-ac

Re: [PATCH 1/1] cdc-acm: Add support of ATOL FPrint fiscal printers

2015-06-02 Thread Ben Dooks
On 02/06/15 11:05, Alexey Sokolov wrote: > ATOL FPrint fiscal printers require usb_clear_halt to be executed > to work properly. Add quirk to fix the issue. > > Signed-off-by: Alexey Sokolov > --- > drivers/usb/class/cdc-acm.c | 9 + > drivers/usb/class/cdc-acm.h | 1 + > 2 files changed

Re: [PATCH 1/1] cdc-acm: Add support of ATOL FPrint fiscal printers

2015-06-02 Thread Oliver Neukum
On Tue, 2015-06-02 at 11:05 +0300, Alexey Sokolov wrote: > ATOL FPrint fiscal printers require usb_clear_halt to be executed > to work properly. Add quirk to fix the issue. > Hi, thank you for this patch. > Signed-off-by: Alexey Sokolov > --- > drivers/usb/class/cdc-acm.c | 9 + > dr

Re: [PATCH 00/21] On-demand device registration

2015-06-02 Thread Linus Walleij
On Mon, May 25, 2015 at 4:53 PM, Tomeu Vizoso wrote: > have looked into ordered probing as a > better way of solving this than moving nodes around in the DT or playing with > initcall levels. > > While reading the thread [1] that Alexander Holler started with his series to > make probing order de

[PATCH 1/1] cdc-acm: Add support of ATOL FPrint fiscal printers

2015-06-02 Thread Alexey Sokolov
ATOL FPrint fiscal printers require usb_clear_halt to be executed to work properly. Add quirk to fix the issue. Signed-off-by: Alexey Sokolov --- drivers/usb/class/cdc-acm.c | 9 + drivers/usb/class/cdc-acm.h | 1 + 2 files changed, 10 insertions(+) diff --git a/drivers/usb/class/cdc-ac

[PATCH RFC 0/2] cdc_ncm refactoring

2015-06-02 Thread Enrico Mioso
I changed my mind, and decided to try in following this new way. This series splits the cdc_ncm_ndp function in two parts: - one that finds NDP blocks already present in the SKB being sent out - one that pushes new ones, starting from where the _find function left. After this splitting it seems mo

[PATCH RFC 2/2] cdc_ncm: split the cdc_ncm_ndp funciton

2015-06-02 Thread Enrico Mioso
Split this function in two new ones: - cdc_ncm_ndp16_find: finds an NDP block in the chain mathcing a supplied signature; a pointer to it is returned in case of success; - cdc_ncm_ndp16_push: create and add to skb a new NDP block; cdc_ncm_ndp16_push refers to the last NDP visited by cdc_ncm_ndp1

[PATCH RFC 1/2] cdc_ncm: add the currently processed NDP frame to global driver data

2015-06-02 Thread Enrico Mioso
This is useful to split up the cdc_ncm_ndp function later on. The resulting code will be anyway stateful. Signed-Off-By: Enrico Mioso --- include/linux/usb/cdc_ncm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/usb/cdc_ncm.h b/include/linux/usb/cdc_ncm.h index 7c9b484..91722

Re: [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open prototype

2015-06-02 Thread Abhishek bist
Yes, I gone through this warning. It is because if i want to make this compilation warning free than i have to change the prototype of a open function pointer described in usb_serial_driver and changing the prototype over there would affect all the device driver lying in usb-serial category , which

Re: [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open prototype

2015-06-02 Thread Johan Hovold
[ Please avoid top-posting. ] On Tue, Jun 02, 2015 at 02:49:30PM +0530, Abhishek bist wrote: > Yes, I gone through this warning. It is because if i want to make this > compilation warning free > than i have to change the prototype of a open function pointer > described in usb_serial_driver > and c

Re: [PATCH 00/21] On-demand device registration

2015-06-02 Thread Tomeu Vizoso
On 2 June 2015 at 10:48, Linus Walleij wrote: > On Mon, May 25, 2015 at 4:53 PM, Tomeu Vizoso > wrote: > >> have looked into ordered probing as a >> better way of solving this than moving nodes around in the DT or playing with >> initcall levels. >> >> While reading the thread [1] that Alexander

Re: USB3 external HDD not recognized [regression]

2015-06-02 Thread Mathias Nyman
Hi On 29.05.2015 15:35, Ralf Jung wrote: > Hi again, > >> Indeed doing "echo 'on' | sudo tee /sys/bus/pci/devices/*/power/control" >> fixes the problem: When I subsequently plug in the disk, it is >> recognized correctly. I confirmed this with an older kernel (the 3.16 >> Debian kernel, to be mor

Re: USB3 external HDD not recognized [regression]

2015-06-02 Thread Ralf Jung
Hi, >>> Indeed doing "echo 'on' | sudo tee /sys/bus/pci/devices/*/power/control" >>> fixes the problem: When I subsequently plug in the disk, it is >>> recognized correctly. I confirmed this with an older kernel (the 3.16 >>> Debian kernel, to be more precise). That's good to know, now I don't >>>

[PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-06-02 Thread Ivan T. Ivanov
On recent Qualcomm platforms VBUS and ID lines are not routed to USB PHY LINK controller. Use extcon framework to receive connect and disconnect ID and VBUS notification. Signed-off-by: Ivan T. Ivanov --- Changes sice v2 [1]. * Simulate IRQ on extcon event - used to trigger OTG state machine. I

Re: [PATCH] USB: ftdi_sio: add GPIO support

2015-06-02 Thread Linus Walleij
On Sat, May 30, 2015 at 10:29 PM, Grant Likely wrote: > On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman > wrote: >>> However is the MFD cell approach acceptable? >> >> Yes it is. > > Going back to this old conversation... Actually, I disagree. There is > absolutely no need to go the MFD appro

Re: [PATCH 1/2] Bluetooth: Add reset_resume function

2015-06-02 Thread Josh Boyer
On Mon, Jun 1, 2015 at 9:28 PM, Marcel Holtmann wrote: > Hi Laura, > >> Bluetooth devices off of some buses such as USB may lose power across >> suspend/resume. When this happens, drivers may need to have the setup >> function called again and behave differently than a cold power on. >> Add a rese

Re: [PATCH v4 0/2] Remaining sunxi musb patches

2015-06-02 Thread Felipe Balbi
Hi, On Tue, Jun 02, 2015 at 09:14:05AM +0200, Hans de Goede wrote: > >>>Here is an updated version of the remaining (not yet merged in Felipe's > >>>tree) > >>>sunxi musb patches. > >>> > >>>The "phy-sun4i-usb: Add full support for usb0 phy / OTG" patch has been > >>>updated with a small bug-fix a

Re: [PATCH v4 2/2] musb: Add support for the Allwinner sunxi musb controller

2015-06-02 Thread Felipe Balbi
On Sun, May 31, 2015 at 06:10:26PM +0200, Hans de Goede wrote: > This is based on initial code to get the Allwinner sunxi musb controller > supported by Chen-Yu Tsai and Roman Byshko. > > This adds support for the Allwinner sunxi musb controller in both host only > and otg mode. Peripheral only mo

Re: [PATCH 1/2] Bluetooth: Add reset_resume function

2015-06-02 Thread Marcel Holtmann
Hi Josh, >>> Bluetooth devices off of some buses such as USB may lose power across >>> suspend/resume. When this happens, drivers may need to have the setup >>> function called again and behave differently than a cold power on. >>> Add a reset_resume function for drivers to call. During the >>> re

integrated bluetooth adapter causes errors in dmesg on boot

2015-06-02 Thread Alexander
Hello. I have got "Asus Z87-Expert" motherboard with integrated bluetooth adapter. It causes the following error on boot: "usb 3-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409" Though there are no real problems with bluetooth, this error is annoying. Here is some information:

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-02 Thread Maxime Ripard
Hi, On Mon, Jun 01, 2015 at 11:28:23AM +0200, Hans de Goede wrote: > On 01-06-15 11:22, Maxime Ripard wrote: > >On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote: > >>+ /* We either want both gpio pins or neither (when in host mode) */ > >>+ if (!data->id_det_gpio != !data->vbus_de

Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

2015-06-02 Thread Laurent Pinchart
On Monday 01 June 2015 16:51:30 Sergei Shtylyov wrote: > Hello. > > On 6/1/2015 1:43 AM, Colin King wrote: > > From: Colin Ian King > > > > If kzalloc returns null then isp1760_ep_alloc_request performs > > a null pointer dereference on req. Check for null to avoid this. > > I told you there's

Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

2015-06-02 Thread Sergei Shtylyov
Hello. On 06/02/2015 06:41 PM, Laurent Pinchart wrote: From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer dereference on req. Check for null to avoid this. I told you there's no dereference and yet you're repeating it again. :-( How abou

Re: integrated bluetooth adapter causes errors in dmesg on boot

2015-06-02 Thread Alan Stern
On Tue, 2 Jun 2015, Alexander wrote: > Hello. I have got "Asus Z87-Expert" motherboard with integrated > bluetooth adapter. It causes the following error on boot: > "usb 3-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409" This means the bluetooth adapter sent an invalid string

[PATCH][V3] usb: isp1760: check for null return from kzalloc

2015-06-02 Thread Colin King
From: Colin Ian King isp1760_ep_alloc_request allocates a structure with kzalloc without checking for NULL and then returns a pointer to one of the structure fields. As the field happens to be the first in the structure the caller can properly check for NULL, but this is risky if the structure

[PATCH v2 1/6] USB: bcma: remove chip id check

2015-06-02 Thread Hauke Mehrtens
I have never seen any bcma device with an USB host core which was not a SoC, the bcma devices have an USB device core with a different core id. Some SoC have IDs with 47XX and 53XX in decimal form which would be rejected by this check. Instead of fixing this check just remove it. Signed-off-by: Ha

[PATCH v2 3/6] USB: bcma: use devm_kzalloc

2015-06-02 Thread Hauke Mehrtens
Instead of manually handling the frees use devm. There was also a free missing in the unregister call which is not needed with devm. Signed-off-by: Hauke Mehrtens --- drivers/usb/host/bcma-hcd.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/bcma

[PATCH v2 0/6] USB: bcma: add support for ARM based SoCs

2015-06-02 Thread Hauke Mehrtens
These patches are fixing minor bugs and are adding support for ARM based Broadcom BCM47XX and BCM53XX SoCs. Changes since: v1: * add patch "USB: bcma: fix error handling in bcma_hcd_create_pdev()" * do not call bcma_core_disable(dev, 0) before enable. Hauke Mehrtens (6): USB: bcma: remove ch

[PATCH v2 6/6] USB: bcma: add support for controlling bus power through GPIO

2015-06-02 Thread Hauke Mehrtens
On some boards a GPIO is needed to activate USB controller. Make it possible to specify such a GPIO in device tree. Signed-off-by: Felix Fietkau Signed-off-by: Hauke Mehrtens --- drivers/usb/host/bcma-hcd.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/us

[PATCH v2 5/6] USB: bcma: add bcm53xx support

2015-06-02 Thread Hauke Mehrtens
The Broadcom ARM SoCs with this usb core need a different initialization and they have a different core id. This patch adds support for these USB 2.0 core. Signed-off-by: Felix Fietkau Signed-off-by: Hauke Mehrtens --- drivers/usb/host/bcma-hcd.c | 70 +++

[PATCH v2 4/6] USB: bcma: fix error handling in bcma_hcd_create_pdev()

2015-06-02 Thread Hauke Mehrtens
This patch makes bcma_hcd_create_pdev() not return NULL, but a prober error code in case of an error. Signed-off-by: Hauke Mehrtens --- drivers/usb/host/bcma-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/bcma-hcd.c b/drivers/usb/host/bcma-hcd.c in

[PATCH v2 2/6] USB: bcma: replace numbers with constants

2015-06-02 Thread Hauke Mehrtens
The constants for these numbers were added long time ago, use them. Signed-off-by: Hauke Mehrtens --- drivers/usb/host/bcma-hcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/bcma-hcd.c b/drivers/usb/host/bcma-hcd.c index 976b4e1..b4ec4ec 100644 --- a/dr

Re: [PATCH v2 0/6] USB: bcma: add support for ARM based SoCs

2015-06-02 Thread Rafał Miłecki
On 2 June 2015 at 21:35, Hauke Mehrtens wrote: > These patches are fixing minor bugs and are adding support for ARM > based Broadcom BCM47XX and BCM53XX SoCs. > > Changes since: > v1: > * add patch "USB: bcma: fix error handling in bcma_hcd_create_pdev()" > * do not call bcma_core_disable(dev, 0

Re: [PATCH][V3] usb: isp1760: check for null return from kzalloc

2015-06-02 Thread Laurent Pinchart
Hi Colin, Thank you for the patch. On Tuesday 02 June 2015 19:05:13 Colin King wrote: > From: Colin Ian King > > isp1760_ep_alloc_request allocates a structure with kzalloc without checking > for NULL and then returns a pointer to one of the structure fields. As the > field happens to be the fi

Re: integrated bluetooth adapter causes errors in dmesg on boot

2015-06-02 Thread Greg KH
On Tue, Jun 02, 2015 at 06:16:20PM +0300, Alexander wrote: > Hello. I have got "Asus Z87-Expert" motherboard with integrated bluetooth > adapter. It causes the following error on boot: > "usb 3-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409" > Though there are no real problems w