Re: [PATCH] usb: core: add usb3 lpm sysfs

2015-04-29 Thread Zhuang Jin Can
On Tue, Apr 28, 2015 at 11:11:10PM +0200, Greg KH wrote: > On Wed, Apr 29, 2015 at 12:51:27AM +0800, Zhuang Jin Can wrote: > > Hi Greg KH, > > > > On Tue, Apr 28, 2015 at 12:42:24PM +0200, Greg KH wrote: > > > On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote: > > > > Some usb3 device

Re: [PATCHv3 08/11] usb: dwc3: add hsphy_interface property

2015-04-29 Thread Heikki Krogerus
> > + /* Select the HS PHY interface */ > > + switch (DWC3_GHWPARAMS3_HSPHY_IFC(dwc->hwparams.hwparams3)) { > > + case DWC3_GHWPARAMS3_HSPHY_IFC_UTMI_ULPI: > > + if (!strncmp(dwc->hsphy_interface, "utmi", 4)) { > > + reg &= ~DWC3_GUSB2PHYCFG_ULPI_UTMI; > > +

Re: [PATCHv3 06/11] usb: dwc3: soft reset to it's own function

2015-04-29 Thread Heikki Krogerus
> > + * dwc3_soft_reset - Issue soft reset > > + * @dwc: Pointer to our controller context structure > > + */ > > +static int dwc3_soft_reset(struct dwc3 *dwc) > > I don't see this being called anywhere else in your series and I would > really like to know when we would need to reset the core agai

[PATCH] usb: host: xhci: add mutex for non-thread-safe data

2015-04-29 Thread Chris Bainbridge
Regression in commit 638139eb95d2d241781330a321e88c8dafe46078 Author: Petr Mladek Date: Fri Sep 19 17:32:24 2014 +0200 usb: hub: allow to process more usb hub events in parallel The regression resulted in intermittent failure to initialise a 10-port hub (with three internal VL812 4-port hu

Re: [PATCHv3 00/12] usb: ulpi bus

2015-04-29 Thread Heikki Krogerus
On Tue, Apr 28, 2015 at 12:17:34PM -0500, Felipe Balbi wrote: > Hi, > > On Tue, Apr 28, 2015 at 04:24:35PM +0300, Heikki Krogerus wrote: > > Hi, > > > > I took the liberty of adding David's ACK to everything except 9/12, > > including to > > the 1/12 (removing the module handling has no function

[PATCHv3 08/12] usb: dwc3: add hsphy_interface property

2015-04-29 Thread Heikki Krogerus
Platforms that have configured DWC_USB3_HSPHY_INTERFACE with value 3, i.e. UTMI+ and ULPI, need to inform the driver of the actual HSPHY interface type with the property. "utmi" if the interface is UTMI+ or "ulpi" if the interface is ULPI. Signed-off-by: Heikki Krogerus Acked-by: David Cohen ---

[PATCHv3 10/12] usb: dwc3: add ULPI interface support

2015-04-29 Thread Heikki Krogerus
Registers DWC3's ULPI interface with the ULPI bus when it's available. Signed-off-by: Heikki Krogerus Acked-by: David Cohen --- drivers/usb/dwc3/Kconfig | 7 drivers/usb/dwc3/Makefile | 4 +++ drivers/usb/dwc3/core.c | 19 +- drivers/usb/dwc3/core.h | 14 drivers/us

[PATCHv3 12/12] phy: add driver for TI TUSB1210 ULPI PHY

2015-04-29 Thread Heikki Krogerus
TUSB1210 ULPI PHY has vendor specific register for eye diagram tuning. On some platforms the system firmware has set optimized value to it. In order to not loose the optimized value, the driver stores it during probe and restores it every time the PHY is powered back on. Signed-off-by: Heikki Krog

[PATCHv3 11/12] phy: helpers for USB ULPI PHY registering

2015-04-29 Thread Heikki Krogerus
ULPI PHYs need to be bound to their controllers with a lookup. This adds helpers that the ULPI drivers can use to do both, the registration of the PHY and the lookup, at the same time. Signed-off-by: Heikki Krogerus Acked-by: David Cohen Cc: Kishon Vijay Abraham I --- drivers/phy/ulpi_phy.h |

[PATCHv3 09/12] usb: dwc3: pci: add quirk for Baytrails

2015-04-29 Thread Heikki Krogerus
On some BYT platforms the USB2 PHY needs to be put into operational mode by the controller driver with GPIOs controlling the PHYs reset and cs signals. Signed-off-by: Heikki Krogerus --- drivers/usb/dwc3/dwc3-pci.c | 36 1 file changed, 36 insertions(+) diff

[PATCH v3] usb: gadget: composite: enable BESL support

2015-04-29 Thread Du, Changbin
>From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 From: Felipe Balbi Date: Tue, 30 Sep 2014 16:08:03 -0500 Subject: [PATCH] usb: gadget: composite: enable BESL support commit a6615937bcd9234e6d6bb817c3701fce44d0a84d upstream. According to USB 2.0 ECN Errata for Link Power M

Re: [PATCH 1/1] USB: cp210x: add ID for KCF Technologies PRN device

2015-04-29 Thread Johan Hovold
On Wed, Apr 15, 2015 at 08:53:34AM +0200, Johan Hovold wrote: > On Tue, Apr 14, 2015 at 08:52:34AM -0400, Mark Edwards wrote: > > Added the USB serial console device ID for KCF Technologies PRN device > > which has a USB port for its serial console. > > > > Signed-off-by: Mark Edwards > > Thanks

Re: [PATCH 2/2] visor: Match I330 phone more precisely

2015-04-29 Thread Johan Hovold
On Wed, Apr 22, 2015 at 04:30:12PM +0200, Johan Hovold wrote: > On Wed, Apr 22, 2015 at 02:35:09PM +0200, Jason A. Donenfeld wrote: > > Samsung has just released a portable USB3 SSD, coming in a very small > > and nice form factor. It's USB ID is 04e8:8001, which unfortunately is > > already used b

Re: [PATCH] usb: host: xhci: add mutex for non-thread-safe data

2015-04-29 Thread Johan Hovold
On Wed, Apr 29, 2015 at 09:18:50AM +0100, Chris Bainbridge wrote: > Regression in commit 638139eb95d2d241781330a321e88c8dafe46078 > Author: Petr Mladek > Date: Fri Sep 19 17:32:24 2014 +0200 > > usb: hub: allow to process more usb hub events in parallel > > The regression resulted in inter

Re: [PATCH] usb: core: add usb3 lpm sysfs

2015-04-29 Thread Zhuang Jin Can
On Wed, Apr 29, 2015 at 11:01:48AM +0200, Greg KH wrote: > On Wed, Apr 29, 2015 at 03:20:04PM +0800, Zhuang Jin Can wrote: > > On Tue, Apr 28, 2015 at 11:11:10PM +0200, Greg KH wrote: > > > On Wed, Apr 29, 2015 at 12:51:27AM +0800, Zhuang Jin Can wrote: > > > > Hi Greg KH, > > > > > > > > On Tue,

[linux-usb] mass storage performance is slow with Windows 7 host

2015-04-29 Thread Xuebing Wang
Hi Community, I am developing a commercial product based on Freescale iMX6, which supports USB slave Mass Storage, command is: modprobe g_mass_storage file=/dev/mmcblk0p4 (it is one partition in eMMC, this partition is formatted as FAT32) (kernel version is 3.10.17, I did not try the latest ma

Re: [PATCH] usb: host: xhci: add mutex for non-thread-safe data

2015-04-29 Thread Petr Mladek
On Wed 2015-04-29 09:18:50, Chris Bainbridge wrote: > Regression in commit 638139eb95d2d241781330a321e88c8dafe46078 > Author: Petr Mladek > Date: Fri Sep 19 17:32:24 2014 +0200 > > usb: hub: allow to process more usb hub events in parallel Anyway, I would suggest to revert this commit. I w

Re: [PATCH v3] usb: gadget: composite: enable BESL support

2015-04-29 Thread Felipe Balbi
On Wed, Apr 29, 2015 at 10:19:13AM +, Du, Changbin wrote: > From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 > From: Felipe Balbi > Date: Tue, 30 Sep 2014 16:08:03 -0500 > Subject: [PATCH] usb: gadget: composite: enable BESL support > > commit a6615937bcd9234e6d6bb817c37

Re: [PATCH 1/2] usb: gadget: add usb_gadget_activate/deactivate functions

2015-04-29 Thread Felipe Balbi
On Wed, Apr 29, 2015 at 11:08:06AM +0200, Robert Baldyga wrote: > Hi Felipe, > > On 04/28/2015 06:40 PM, Felipe Balbi wrote: > > On Tue, Apr 07, 2015 at 10:31:52AM +0200, Robert Baldyga wrote: > >> These functions allows to deactivate gadget to make it not visible to > >> host and make it active a

Re: [linux-usb] mass storage performance is slow with Windows 7 host

2015-04-29 Thread Greg KH
On Wed, Apr 29, 2015 at 10:25:22AM -0500, Felipe Balbi wrote: > Hi, > > On Wed, Apr 29, 2015 at 07:37:34PM +0800, Xuebing Wang wrote: > > Hi Community, > > > > I am developing a commercial product based on Freescale iMX6, which supports > > USB slave Mass Storage, command is: > > modprobe g_mass_

[PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning

2015-04-29 Thread Nizam Haider
Fixed two warnings sizeof name and Blank line after declaration Signed-off-by: Nizam Haider --- drivers/usb/core/buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c index 684ef70..04125b6 100644 --- a/drivers/usb/co

Re: [linux-usb] mass storage performance is slow with Windows 7 host

2015-04-29 Thread Felipe Balbi
On Wed, Apr 29, 2015 at 05:51:44PM +0200, Greg KH wrote: > On Wed, Apr 29, 2015 at 10:25:22AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Wed, Apr 29, 2015 at 07:37:34PM +0800, Xuebing Wang wrote: > > > Hi Community, > > > > > > I am developing a commercial product based on Freescale iMX6, whic

Re: [PATCH] usb: host: xhci: add mutex for non-thread-safe data

2015-04-29 Thread Alan Stern
On Wed, 29 Apr 2015, Petr Mladek wrote: > On Wed 2015-04-29 09:18:50, Chris Bainbridge wrote: > > Regression in commit 638139eb95d2d241781330a321e88c8dafe46078 > > Author: Petr Mladek > > Date: Fri Sep 19 17:32:24 2014 +0200 > > > > usb: hub: allow to process more usb hub events in paralle

Re: [PATCH V7 4/9] mfd: Add binding document for NVIDIA Tegra XUSB

2015-04-29 Thread Andrew Bresticker
On Wed, Apr 29, 2015 at 11:34 AM, Lee Jones wrote: > On Wed, 29 Apr 2015, Andrew Bresticker wrote: > >> Lee, >> >> On Wed, Apr 29, 2015 at 2:25 AM, Lee Jones wrote: >> > On Mon, 27 Apr 2015, Andrew Bresticker wrote: >> > >> >> Add a binding document for the XUSB host complex on NVIDIA Tegra124 >>

Re: [PATCH] usb: core: add usb3 lpm sysfs

2015-04-29 Thread Greg KH
On Thu, Apr 30, 2015 at 12:21:32AM +0800, Zhuang Jin Can wrote: > On Wed, Apr 29, 2015 at 01:06:22PM +0200, Greg KH wrote: > > On Wed, Apr 29, 2015 at 06:57:30PM +0800, Zhuang Jin Can wrote: > > > On Wed, Apr 29, 2015 at 11:01:48AM +0200, Greg KH wrote: > > > > On Wed, Apr 29, 2015 at 03:20:04PM +0

[PATCH v5 04/22] usb: dwc2: implement hibernation during bus suspend/resume

2015-04-29 Thread Mian Yousaf Kaukab
From: Gregory Herrero Allow controller to enter in hibernation during usb bus suspend and inform both phy and gadget about the suspended state. While in hibernation, the controller can't detect the resume condition. An external mechanism must call usb_phy_set_suspend on resume. Exit hibernation w

[PATCH v5 00/22] usb: third series of updates for dwc2 driver

2015-04-29 Thread Mian Yousaf Kaukab
Hi, This patchset consists of some bug fixes and feature enhancements for the dwc2 driver. All the patches are verified on dwc2 v3.0a with dedicated fifos. Main focus of testing was with dma enabled. Although basic testing without dma was also done. This is based on testing/next branch in Felipe's

[PATCH v5 11/22] usb: dwc2: gadget: powerup controller if needed

2015-04-29 Thread Mian Yousaf Kaukab
From: Gregory Herrero During vbus session, usb controller needs to exit hibernation if it was previously in suspend state. Since controller will be resetted and configured, there is no need to restore registers. Moreover, set lx_state to L0 on B session. vbus_session callback may not be used by

[PATCH v5 12/22] usb: dwc2: gadget: enable otg flag in dual role configuration

2015-04-29 Thread Mian Yousaf Kaukab
From: Gregory Herrero Inform that device is otg-capable in case of otg configuration. Acked-by: John Youn Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/gadget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 56a08ac..eb9

[PATCH v5 22/22] usb: dwc2: host: ensure qtb exists before dereferencing it

2015-04-29 Thread Mian Yousaf Kaukab
From: Gregory Herrero dwc2_hc_nak_intr could be called with a NULL qtd. Ensure qtd exists before dereferencing it to avoid kernel panic. This happens when using usb to ethernet adapter. Acked-by: John Youn Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/hcd_intr.c | 10 ++ 1 file

[PATCH v5 14/22] usb: dwc2: host: register handle to the phy

2015-04-29 Thread Mian Yousaf Kaukab
If phy driver is present register hcd handle to it. Acked-by: John Youn Signed-off-by: Mian Yousaf Kaukab --- drivers/usb/dwc2/hcd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index 8757f62..1875f7a 100644 --- a/drivers/usb/dwc2/hcd

[PATCH v4] usb: gadget: composite: enable BESL support

2015-04-29 Thread Du, Changbin
>From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 From: Felipe Balbi Date: Tue, 30 Sep 2014 16:08:03 -0500 Subject: [PATCH] usb: gadget: composite: enable BESL support commit a6615937bcd9234e6d6bb817c3701fce44d0a84d upstream. According to USB 2.0 ECN Errata for Link Power M

Re: [linux-usb] mass storage performance is slow with Windows 7 host

2015-04-29 Thread Felipe Balbi
On Thu, Apr 30, 2015 at 10:46:51AM +0800, Xuebing Wang wrote: > > On 04/30/2015 12:45 AM, Felipe Balbi wrote: > >>>try setting nofua parameter. Windows always sets FUA bit (so all writes > >are*always* flushed to non-volatile media), but telling mass storage > >gadget to ignore FUA bit,