Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-15 Thread Roger Quadros
On 15/04/15 06:27, Peter Chen wrote: > On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote: >> On 04/14/2015 07:38 PM, Roger Quadros wrote: >>> On 14/04/15 13:31, Chanwoo Choi wrote: On 04/14/2015 07:02 PM, Roger Quadros wrote: > Fixed Kishon's id. > > On 14/04/15 13:01, R

Re: [PATCH] genirq: provide dummy set_irq_wake()

2015-04-15 Thread Roger Quadros
Hi Gregory, On 14/04/15 17:02, Gregory CLEMENT wrote: > Hi Roger, > > On 14/04/2015 12:13, Roger Quadros wrote: >> Hi Thomas, >> >> On 30/03/15 16:15, Roger Quadros wrote: >>> Without this system suspend is broken on systems that have >>> drivers calling enable/disable_irq_wake() for interrupts b

[PATCH v2] genirq: Set IRQCHIP_SKIP_SET_WAKE flag for dummy_irq_chip

2015-04-15 Thread Roger Quadros
Without this system suspend is broken on systems that have drivers calling enable/disable_irq_wake() for interrupts based off the dummy irq hook. (e.g. drivers/gpio/gpio-pcf857x.c) http://article.gmane.org/gmane.linux.kernel/1879035 Signed-off-by: Roger Quadros --- kernel/irq/dummychip.c | 1 +

USB3 external HDD not recognized [regression]

2015-04-15 Thread Ralf Jung
Hi all, One of my external hard disks does not work anymore with current kernels, when I plug it into my USB3 port. Steps to reproduce: * Boot the system without the disk being connected * Plug the disk into my Laptop's USB3 port * Watch dmesg and my DE's removable media notification Behavior wi

Re: [PATCH] genirq: provide dummy set_irq_wake()

2015-04-15 Thread Gregory CLEMENT
Hi Roger, On 15/04/2015 10:07, Roger Quadros wrote: > Hi Gregory, > > On 14/04/15 17:02, Gregory CLEMENT wrote: >> Hi Roger, >> >> On 14/04/2015 12:13, Roger Quadros wrote: >>> Hi Thomas, >>> >>> On 30/03/15 16:15, Roger Quadros wrote: Without this system suspend is broken on systems that ha

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-15 Thread Chanwoo Choi
Hi Roger and Peter, On 04/15/2015 04:50 PM, Roger Quadros wrote: > On 15/04/15 06:27, Peter Chen wrote: >> On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote: >>> On 04/14/2015 07:38 PM, Roger Quadros wrote: On 14/04/15 13:31, Chanwoo Choi wrote: > On 04/14/2015 07:02 PM, Roger

Re: [RFC][PATCH v2 05/13] usb: otg: add OTG core

2015-04-15 Thread Paul Bolle
(This will go into a minor detail. That's probably not what you want when posting an RFC. But this patch got caught by an email filter I use and a future, non-RFC, version will get caught too. So I decided to bother you with this now.) On Tue, 2015-04-14 at 13:41 +0300, Roger Quadros wrote: > ---

Re: [PATCH v2] genirq: Set IRQCHIP_SKIP_SET_WAKE flag for dummy_irq_chip

2015-04-15 Thread Gregory CLEMENT
On 15/04/2015 10:14, Roger Quadros wrote: > Without this system suspend is broken on systems that have > drivers calling enable/disable_irq_wake() for interrupts based off > the dummy irq hook. > (e.g. drivers/gpio/gpio-pcf857x.c) > > http://article.gmane.org/gmane.linux.kernel/1879035 > > Signed

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-15 Thread rajeev kumar
On Tue, Apr 14, 2015 at 3:40 AM, Arun Ramamurthy wrote: > Getting phys by index instead of phy names so that we do > not have to create a naming scheme when multiple phys > are present > > Signed-off-by: Arun Ramamurthy > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > --- > drivers/usb/ho

Re: [PATCHv2 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core

2015-04-15 Thread Kishon Vijay Abraham I
Hi, On Tuesday 14 April 2015 03:40 AM, Arun Ramamurthy wrote: Some generic drivers, such as ehci, may use multiple phys and for such drivers referencing phy(s) by name(s) does not make sense. Instead of inventing new naming schemes and using custom code to iterate through them, such drivers are

Re: Video transfer hangs with cx231xx deivce on ASM1042A USB 3.0 Host Controller

2015-04-15 Thread Rodrigo Severo
On Mon, Apr 13, 2015 at 10:15 AM, Mathias Nyman wrote: > > Does this only happend with the ASMedia ASM1042A xHCI controller? > Can you reproduce it with a xHCI controller from another vendor? > I'm not sure. I will try when I came back home next week (travelling). > > Can you add xhci debugging

[PATCH] usbhid: correct PM failure with closed devices

2015-04-15 Thread Oliver Neukum
When usbhid closes a device which was awake only because remote wakeup was required but not provided, the interface must go through a get/put cycle or the core will never reattempt to suspend the device. This brakes runtime PM for all joysticks. Signed-off-by: Oliver Neukum --- drivers/hid/usbhi

Re: [RFC][PATCH v2 05/13] usb: otg: add OTG core

2015-04-15 Thread Roger Quadros
On 15/04/15 12:29, Paul Bolle wrote: > (This will go into a minor detail. That's probably not what you want > when posting an RFC. But this patch got caught by an email filter I use > and a future, non-RFC, version will get caught too. So I decided to > bother you with this now.) > > On Tue, 2015-

[PATCH v2] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-04-15 Thread Ivan T. Ivanov
On recent Qualcomm platforms VBUS and ID lines are not routed to USB PHY LINK controller. Use extcon framework to receive connect and disconnect ID and VBUS notification. Signed-off-by: Ivan T. Ivanov --- Changes since v0 [1], as per Peter Chen suggestions: * Moved external connector parsing co

Re: [PATCH v2] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-04-15 Thread Robert Baldyga
Hi Ivan, On 04/15/2015 03:35 PM, Ivan T. Ivanov wrote: > On recent Qualcomm platforms VBUS and ID lines are not routed to > USB PHY LINK controller. Use extcon framework to receive connect > and disconnect ID and VBUS notification. > > Signed-off-by: Ivan T. Ivanov > --- > > Changes since v0 [1

Re: OTG & EH test driver

2015-04-15 Thread Felipe Balbi
Hi, (no top-posting, please) On Tue, Apr 14, 2015 at 04:57:20PM -0500, Linux mail wrote: > I'm talking about the attached patch. if you found the patch from the mailing list, then you also found Alan Stern's comments which have never been addressed, right ? > BTW, I just double checked and the

Re: SanDisk Ultra Fit (32 GB version) unbbotable

2015-04-15 Thread Alan Stern
On Wed, 15 Apr 2015, frederik.hofe wrote: > > What happens if you unplug the flash drive just after the kernel and > > initramfs image have been loaded, while the kernel is still > > initializing? You could then plug it back in while the kernel is > > searching for the root device. > > > > Alan S

need to get the interface cycled with autopm_get/_put() to let a device sleep

2015-04-15 Thread Oliver Neukum
Hi, I found a problem with the close() function of usbhid. It fails to properly suspend device that don't support remote wake-up. The power core does not retry an autosuspend that failed due to a lack of support for remote wake-up. So there needs to be a _put() if the need for remote wake-up is r

Re: USB3 external HDD not recognized [regression]

2015-04-15 Thread Alan Stern
On Wed, 15 Apr 2015, Ralf Jung wrote: > Hi all, > > One of my external hard disks does not work anymore with current > kernels, when I plug it into my USB3 port. ... > I can do a git bisect when I am back from travel (in ~1 week), but I > would appreciate some guess of which folder I should res

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-15 Thread Alan Stern
On Wed, 15 Apr 2015, rajeev kumar wrote: > > @@ -88,15 +88,13 @@ static int ehci_platform_power_on(struct > > platform_device *dev) > > } > > > > for (phy_num = 0; phy_num < priv->num_phys; phy_num++) { > > - if (priv->phys[phy_num]) { > > - ret

Re: [PATCH v2] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-04-15 Thread Ivan T. Ivanov
Hi Robert, On Wed, 2015-04-15 at 16:11 +0200, Robert Baldyga wrote: > Hi Ivan, > > On 04/15/2015 03:35 PM, Ivan T. Ivanov wrote: > > On recent Qualcomm platforms VBUS and ID lines are not routed to > > USB PHY LINK controller. Use extcon framework to receive connect > > and disconnect ID and VBU

Re: [PATCH] usbhid: correct PM failure with closed devices

2015-04-15 Thread Alan Stern
On Wed, 15 Apr 2015, Oliver Neukum wrote: > When usbhid closes a device which was awake only because remote > wakeup was required but not provided, the interface must go through > a get/put cycle or the core will never reattempt to suspend the device. > This brakes runtime PM for all joysticks. >

Re: need to get the interface cycled with autopm_get/_put() to let a device sleep

2015-04-15 Thread Alan Stern
On Wed, 15 Apr 2015, Oliver Neukum wrote: > Hi, > > I found a problem with the close() function of usbhid. > It fails to properly suspend device that don't support > remote wake-up. The power core does not retry an autosuspend > that failed due to a lack of support for remote wake-up. > > So the

Re: [PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-15 Thread Vivek Gautam
On Thu, Apr 9, 2015 at 8:19 PM, Alan Stern wrote: > On Thu, 9 Apr 2015, Ivan T. Ivanov wrote: > >> This allow same IO space to be shared between HCD and Device >> controller driver. Which can be loaded simultaneously and >> started/stopped on demand by USB OTG PHY driver. Are you sure ? Will ehci

just a cosmetic thing ? :"# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" needed in .config

2015-04-15 Thread Toralf Förster
/me do still wonder, if the 2nd is needed anyway even in a USB-free kernel config or if this is just an artifact whcih should be cleaned up. -- Toralf pgp key: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 0076 E94E -- "; the past is all dirty and cruel in the modern popular imagination, with the ex

Re: just a cosmetic thing ? :"# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" needed in .config

2015-04-15 Thread Greg KH
On Wed, Apr 15, 2015 at 06:10:57PM +0200, Toralf Förster wrote: > /me do still wonder, if the 2nd is needed anyway even in a USB-free kernel > config or if this is just an artifact whcih should be cleaned up. Patches to clean this up if you want to, are welcome :) -- To unsubscribe from this lis

Re: OTG & EH test driver

2015-04-15 Thread Felipe Balbi
Hi, On Wed, Apr 15, 2015 at 10:48:05AM -0500, Linux mail wrote: > Hi Felipe, > > First of all, my apologies about top-posting (though, I'm not sure what it > means), I haven't posted to any mail-list before. top-posting means replying on top of a previous answer :-) Here's a link which might he

Re: just a cosmetic thing ? :"# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" needed in .config

2015-04-15 Thread Alan Stern
On Wed, 15 Apr 2015, Toralf Förster wrote: > /me do still wonder, if the 2nd is needed anyway even in a USB-free > kernel config or if this is just an artifact whcih should be cleaned > up. It's just an artifact; it's not needed. You can clean it up if you want, but I doubt it would be worthwhi

irritating message "defaulting to EHCI.", if USB isn't compiled into the kernel

2015-04-15 Thread Toralf Förster
Hi, the following warning "pci :00:14.0: CONFIG_USB_XHCI_HCD is turned off, defaulting to EHCI." makes no sense, if USB isn't compiled into the kernel. Looks like another cosmetic issue in the same field as already discussed earlier this day, right? -- Toralf pgp key: 7B1A 07F4 EC82 0F9

External USB drives become unresponsive after few hours.

2015-04-15 Thread Dorian Gray
I have tested the following kernel versions: - 3.18.4, 3.18.6, 3.18.7, 3.19.4 [all affected] - 3.17.1 [unaffected] - 3.17.8 [probably the last unaffected version; I'm using it currently] Also, I've been using the very same configuration (hardware) along with 2.6.x, 3.2.x, 3.4.x, 3.10.x and have ne

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-15 Thread Peter Chen
On Wed, Apr 15, 2015 at 06:26:23PM +0900, Chanwoo Choi wrote: > Hi Roger and Peter, > > On 04/15/2015 04:50 PM, Roger Quadros wrote: > > On 15/04/15 06:27, Peter Chen wrote: > >> On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote: > >>> On 04/14/2015 07:38 PM, Roger Quadros wrote: >

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-15 Thread rajeev kumar
On Wed, Apr 15, 2015 at 8:06 PM, Alan Stern wrote: > On Wed, 15 Apr 2015, rajeev kumar wrote: > >> > @@ -88,15 +88,13 @@ static int ehci_platform_power_on(struct >> > platform_device *dev) >> > } >> > >> > for (phy_num = 0; phy_num < priv->num_phys; phy_num++) { >> > -

[PATCH v3 1/5] usb: introduce OTG 2.0 related kernel feature and API.

2015-04-15 Thread Macpaul Lin
Introduce kernel feature CONFIG_USB_OTG20 and related gadget_is_otg20() API for supporting OTG20 compliant drivers. This patch also updated usb_otg_descritpor. Signed-off-by: Macpaul Lin changes for v2: - Add USB_OTG_ADP definition in ch9.h. changes for v3: - ch9.h: replace a tab to space when

[PATCH v3 4/5] usb: legacy/multi add supports OTG 2.0

2015-04-15 Thread Macpaul Lin
add supports OTG 2.0 for multi.c Signed-off-by: Macpaul Lin changes for v2: - no change changes for v3: - multi.c: migrate global static const OTG descriptor with runtime retrived capability information by calling usb_gadget_customize_otg_desc(). --- drivers/usb/gadget/legacy/multi.c |

[PATCH v3 3/5] usb: add options to identify the capabilities of OTG devices

2015-04-15 Thread Macpaul Lin
Add independent options for identify the capabilities of ADP/SRP/HNP feature for OTG devices. Signed-off-by: Macpaul Lin changes for v2: - no change changes for v3: - composite.h: add usb_gadget_customize_otg_desc() declaration. - composite.c: replace static configuration of ADP/SRP/HNP ca

[PATCH v3 5/5] musb_gadget.c: configure OTG 2.0 capabilities in gadget setup

2015-04-15 Thread Macpaul Lin
Replace hardcoded gadget capability from interface setup to gadget setup. Signed-off-by: Macpaul Lin --- drivers/usb/musb/musb_gadget.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index 4c481cd..3445ecc 100644 --- a/dri

[PATCH v3 2/5] usb: add ADP, HNP, and SRP feature options to gadget structure.

2015-04-15 Thread Macpaul Lin
Add ADP, HNP, and SRP feature options to gadget structure. Signed-off-by: Macpaul Lin --- include/linux/usb/gadget.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h index c63a8db..6e44483 100644 --- a/include/linux/usb/gadget.h

[PATCH v4 3/5] usb: add options to identify the capabilities of OTG devices

2015-04-15 Thread Macpaul Lin
Add independent options for identify the capabilities of ADP/SRP/HNP feature for OTG devices. Signed-off-by: Macpaul Lin --- changes for v2: - no change changes for v3: - composite.h: add usb_gadget_customize_otg_desc() declaration. - composite.c: replace static configuration of ADP/SRP/HNP

[PATCH v4 1/5] usb: introduce OTG 2.0 related kernel feature and API.

2015-04-15 Thread Macpaul Lin
Introduce kernel feature CONFIG_USB_OTG20 and related gadget_is_otg20() API for supporting OTG20 compliant drivers. This patch also updated usb_otg_descritpor. Signed-off-by: Macpaul Lin --- changes for v2: - Add USB_OTG_ADP definition in ch9.h. changes for v3: - ch9.h: replace a tab to space w

[PATCH v4 2/5] usb: add ADP, HNP, and SRP feature options to gadget structure.

2015-04-15 Thread Macpaul Lin
Add ADP, HNP, and SRP feature options to gadget structure. Signed-off-by: Macpaul Lin --- changes for v2: - no change changes for v3: - no change changes for v4: - fix description of each git commits. include/linux/usb/gadget.h | 9 + 1 file changed, 9 insertions(+) diff --git a/inc

[PATCH v4 4/5] usb: legacy/multi add supports OTG 2.0

2015-04-15 Thread Macpaul Lin
add supports OTG 2.0 for multi.c Signed-off-by: Macpaul Lin --- changes for v2: - no change changes for v3: - multi.c: migrate global static const OTG descriptor with runtime retrived capability information by calling usb_gadget_customize_otg_desc(). changes for v4: - fix description of

[PATCH v4 5/5] musb_gadget.c: configure OTG 2.0 capabilities in gadget setup

2015-04-15 Thread Macpaul Lin
Replace hardcoded gadget capability from interface setup to gadget setup. Signed-off-by: Macpaul Lin --- changes for v1: - no change changes for v2: - no change changes for v3: - new commit for adapting to musb drivers changes for v4: - fix description of each git commits. drivers/usb/musb/