Re: [PATCH v2 4/4] Documentation: ABI: Fix documentation for mass_storage function

2015-04-09 Thread Krzysztof Opasiak
On 04/09/2015 10:32 AM, Tal Shorer wrote: On Wed, Apr 8, 2015 at 3:06 PM, Krzysztof Opasiak wrote: Luns in mass storage function are identified using their id. While creating lun's directory user cannot choose any arbitrary name other than arabic numeral from 1 to FSG_MAX_LUNS. Signed-off-by

Re: [PATCH 4/5] usb: gadget: mass_storage: Ensure that lun ids are contiguous

2015-04-09 Thread Felipe Balbi
On Wed, Apr 08, 2015 at 01:28:47PM +0200, Krzysztof Opasiak wrote: > Signed-off-by: Krzysztof Opasiak no commit log -- balbi signature.asc Description: Digital signature

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Robert Baldyga
On 04/09/2015 11:59 AM, Roger Quadros wrote: > Hi, > > On 09/04/15 12:24, Robert Baldyga wrote: >> Hi Chanwoo, >> >> On 04/09/2015 11:07 AM, Chanwoo Choi wrote: >>> Hi Robert, >>> >>> On 04/09/2015 04:57 PM, Robert Baldyga wrote: Hi Chanwoo, On 04/09/2015 04:12 AM, Chanwoo Choi wrot

Re: Unable to access USB mass storage device with xhci. okay with ehci

2015-04-09 Thread Hans de Goede
Hi, On 09-04-15 15:27, Steve Bangert wrote: On Wed, 2015-04-08 at 10:56 -0400, Alan Stern wrote: On Wed, 8 Apr 2015, Steve Bangert wrote: What i did was not correct, usb-storage.quirks=174c:55aa:u was added to /etc/default/grub file after GRUB_CMDLINE_LINUX="rhgb quiet", using the grub-config

Re: [PATCH 1/5] fs: configfs: Fix typo in comment

2015-04-09 Thread Felipe Balbi
On Wed, Apr 08, 2015 at 01:28:44PM +0200, Krzysztof Opasiak wrote: > Signed-off-by: Krzysztof Opasiak > --- > fs/configfs/dir.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c > index cf0db00..dee1cb5 100644 > --- a/fs/configfs/di

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Robert Baldyga
Hi Chanwoo, On 04/09/2015 04:12 AM, Chanwoo Choi wrote: > Hi Robert, > > On 04/02/2015 10:13 PM, Robert Baldyga wrote: >> This patch adds VBUS pin detection support to extcon-usb-gpio driver. >> It allows to use this driver with boards which have both VBUS and ID >> pins, or only one of them. >>

Re: [PATCH 3/5] usb: gadget: mass_storage: Store lun_opts in fsg_opts

2015-04-09 Thread Felipe Balbi
On Wed, Apr 08, 2015 at 01:28:46PM +0200, Krzysztof Opasiak wrote: > Signed-off-by: Krzysztof Opasiak no commit log -- balbi signature.asc Description: Digital signature

Re: Unable to access USB mass storage device with xhci. okay with ehci

2015-04-09 Thread Steve Bangert
On Thu, 2015-04-09 at 16:49 +0200, Hans de Goede wrote: > Hi, > > On 09-04-15 15:27, Steve Bangert wrote: > > On Wed, 2015-04-08 at 10:56 -0400, Alan Stern wrote: > >> On Wed, 8 Apr 2015, Steve Bangert wrote: > >> > >>> What i did was not correct, usb-storage.quirks=174c:55aa:u was added to > >>>

Re: [PATCH 1/2] usb: Prefer firmware values when determining whether a port is removable

2015-04-09 Thread Matthew Garrett
On Thu, Apr 9, 2015 at 2:31 AM, Greg KH wrote: > Anyway, is this all a Windows 8 requirement? If so, I'll feel > comfortable making these changes, otherwise we are at the mercy of the > bios people to randomly get things right, and we all know how often that > works... It's covered by System.Fun

[PATCH 2/2] usb: phy: msm: Manual PHY and LINK controller VBUS change notification

2015-04-09 Thread Ivan T. Ivanov
VBUS is not routed to USB PHY on recent Qualcomm platforms. USB controller must see VBUS in order to pull-up DP when setting RS bit. Henc configure USB PHY and LINK registers sense VBUS and enable manual pullup on D+ line. Cc: Vamsi Krishna Cc: Mayank Rana Signed-off-by: Ivan T. Ivanov --- ...

Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()

2015-04-09 Thread Johan Hovold
On Wed, Apr 08, 2015 at 05:29:16PM +, Mark Enstone wrote: > Everyone, thank you for your attention and suggestions. > > Johan, perfect, thank you, that did indeed help and has fixed the > issue I was seeing. > > The change replaced dev_err() with dev_dbg() -- thus not logging (by > default) w

Re: [PATCH] usb: renesas_usbhs: Revise the binding document about the dma-names

2015-04-09 Thread Mark Rutland
On Thu, Apr 09, 2015 at 01:17:44AM +0100, Yoshihiro Shimoda wrote: > Hi Mark, > > > > > On Wed, Apr 08, 2015 at 11:42:24AM +0100, Yoshihiro Shimoda wrote: > > > Since the DT should describe the hardware (not the driver limitation), > > > This patch revises the binding document about the dma-names

[PATCH] usb: chipidea: Use extcon framework for VBUS and ID detection

2015-04-09 Thread Ivan T. Ivanov
On recent Qualcomm platforms VBUS and ID lines are not routed to USB PHY LINK controller. Use extcon framework to receive connect and disconnect ID and VBUS notification. Signed-off-by: Ivan T. Ivanov --- Suggestions for better solution are welcome! .../devicetree/bindings/usb/ci-hdrc-qcom.txt

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Roger Quadros
Hi, On 09/04/15 12:24, Robert Baldyga wrote: > Hi Chanwoo, > > On 04/09/2015 11:07 AM, Chanwoo Choi wrote: >> Hi Robert, >> >> On 04/09/2015 04:57 PM, Robert Baldyga wrote: >>> Hi Chanwoo, >>> >>> On 04/09/2015 04:12 AM, Chanwoo Choi wrote: Hi Robert, >> >> [snip] >> But, I have on

Re: [PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-09 Thread Alan Stern
On Thu, 9 Apr 2015, Ivan T. Ivanov wrote: > This allow same IO space to be shared between HCD and Device > controller driver. Which can be loaded simultaneously and > started/stopped on demand by USB OTG PHY driver. You really should CC the person who wrote the code you are changing. This is al

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Chanwoo Choi
Hi Robert, On 04/09/2015 04:57 PM, Robert Baldyga wrote: > Hi Chanwoo, > > On 04/09/2015 04:12 AM, Chanwoo Choi wrote: >> Hi Robert, >> [snip] >> But, I have one question about case[3] >> >> If id is low and vbus is high, this patch will update the state of both USB >> and USB-HOST cable as at

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Robert Baldyga
Hi Chanwoo, On 04/09/2015 11:07 AM, Chanwoo Choi wrote: > Hi Robert, > > On 04/09/2015 04:57 PM, Robert Baldyga wrote: >> Hi Chanwoo, >> >> On 04/09/2015 04:12 AM, Chanwoo Choi wrote: >>> Hi Robert, >>> > > [snip] > >>> But, I have one question about case[3] >>> >>> If id is low and vbus is hig

[PATCH 1/2] usb: phy: msm: Use extcon framework for VBUS and ID detection

2015-04-09 Thread Ivan T. Ivanov
On recent Qualcomm platforms VBUS and ID lines are not routed to USB PHY LINK controller. Use extcon framework to receive connect and disconnect ID and VBUS notification. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 7 ++ drivers/usb/phy/Kconfig

[PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-09 Thread Ivan T. Ivanov
This allow same IO space to be shared between HCD and Device controller driver. Which can be loaded simultaneously and started/stopped on demand by USB OTG PHY driver. Signed-off-by: Ivan T. Ivanov --- drivers/usb/host/ehci-msm.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-)

Re: [PATCH 1/5] fs: configfs: Fix typo in comment

2015-04-09 Thread Krzysztof Opasiak
On 04/09/2015 03:46 PM, Felipe Balbi wrote: On Wed, Apr 08, 2015 at 01:28:44PM +0200, Krzysztof Opasiak wrote: Signed-off-by: Krzysztof Opasiak --- fs/configfs/dir.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index cf0db00..

Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()

2015-04-09 Thread Johan Hovold
On Thu, Apr 09, 2015 at 02:25:08PM -0400, Alan Stern wrote: > On Thu, 9 Apr 2015, Johan Hovold wrote: > > In my setup, adding a really short udelay (e.g. 100 us) rather than the > > printk is also enough to trigger the lock up when using just two bulk-in > > urbs. > > > > I thought it was the hub

dvb-t usb stick terratec problem

2015-04-09 Thread baumber
Hello, I have the same bug, mentioned in the bugreport, but with a USB TV-Stick DVB-T "Terratec Cinergy DT XS Diversity". https://bugzilla.kernel.org/show_bug.cgi?id=92301 This problem was not in kernel 3.16.x , I use Ubuntu 14.04.x 64bit. Thank you for your help! Best regards, Bernhard A

Re: [PATCH] usb: renesas_usbhs: Revise the binding document about the dma-names

2015-04-09 Thread Geert Uytterhoeven
On Wed, Apr 8, 2015 at 12:42 PM, Yoshihiro Shimoda wrote: > Since the DT should describe the hardware (not the driver limitation), > This patch revises the binding document about the dma-names to change > simple numbering as "ch%d" instead of "tx" and "rx". > > Also this patch fixes the actual cod

[PATCH v3 1/4] fs: configfs: Add unlocked version of configfs_depend_item()

2015-04-09 Thread Krzysztof Opasiak
Sometimes it might be desirable to prohibit removing a directory in configfs. One example is USB gadget (mass_storage function): when gadget is already bound, if lun directory is removed, the gadget must be thrown away, too. A better solution would be to fail with e.g. -EBUSY. Currently configfs h

[PATCH v3 2/4] usb: gadget: mass_storage: Store lun_opts in fsg_opts

2015-04-09 Thread Krzysztof Opasiak
Currently lun_opts are stored only in configfs and accessed using container_of() on config group. This means that in configfs callbacks we can easily access only current lun (config_group). This commit adds an additinal array to fsg_opts which allows to access not only current lun but also all oth

[PATCH v3 0/4] Ensure that lun ids are contiguous

2015-04-09 Thread Krzysztof Opasiak
Dear list, This series fix configfs interface for mass storage function. According to mass storage specification[1]: "Logical Unit Numbers on the device shall be numbered contiguously starting from LUN 0 to a maximum LUN of 15 (Fh)." Currently configfs interface allows to create LUNs with arbit

[PATCH v3 4/4] Documentation: ABI: Fix documentation for mass_storage function

2015-04-09 Thread Krzysztof Opasiak
Luns in mass storage function are identified using their id. While creating lun's directory user cannot choose any arbitrary name other than decimal value from 1 to FSG_MAX_LUNS. Moreover, LUNs ids should be contiguous. This means that user may remove only lun with max id and can create new lun on

[PATCH v3 3/4] usb: gadget: mass_storage: Ensure that lun ids are contiguous

2015-04-09 Thread Krzysztof Opasiak
According to mass storage specification: "Logical Unit Numbers on the device shall be numbered contiguously starting from LUN 0 to a maximum LUN of 15 (Fh)." This commit fix configfs interface adding this restriction. Now user can create luns only with contignous ids and cannot remove lun from t

Re: [PATCH 1/2] usb: Prefer firmware values when determining whether a port is removable

2015-04-09 Thread Greg KH
On Wed, Apr 08, 2015 at 04:36:00PM -0700, Matthew Garrett wrote: > Windows appears to pay more attention to the ACPI values than any hub > configuration, so prefer the firmware's opinion on whether a port is > fixed or removable before falling back to the hub values. > > Signed-off-by: Matthew Gar

Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()

2015-04-09 Thread Alan Stern
On Thu, 9 Apr 2015, Johan Hovold wrote: > On Wed, Apr 08, 2015 at 05:29:16PM +, Mark Enstone wrote: > > Everyone, thank you for your attention and suggestions. > > > > Johan, perfect, thank you, that did indeed help and has fixed the > > issue I was seeing. > > > > The change replaced dev_er

Re: Unable to access USB mass storage device with xhci. okay with ehci

2015-04-09 Thread Steve Bangert
On Thu, 2015-04-09 at 11:07 -0400, Alan Stern wrote: > On Thu, 9 Apr 2015, Hans de Goede wrote: > > > > uas.c was patched (see attached), the quirk line was temporarily removed > > > > Thanks for testing this. > > > > > and i now have access to the drive using xhci and uas. usbmon trace is > > >

Re: [PATCH v2 4/4] Documentation: ABI: Fix documentation for mass_storage function

2015-04-09 Thread Tal Shorer
On Wed, Apr 8, 2015 at 3:06 PM, Krzysztof Opasiak wrote: > Luns in mass storage function are identified using their id. > While creating lun's directory user cannot choose any arbitrary > name other than arabic numeral from 1 to FSG_MAX_LUNS. > > Signed-off-by: Krzysztof Opasiak > --- > .../ABI/

Re: [PATCH 1/5] usb: xhci: cleanup xhci_hcd allocation

2015-04-09 Thread Roger Quadros
Hi, On 07/04/15 17:23, Mathias Nyman wrote: > Hi > > On 02.04.2015 15:23, Roger Quadros wrote: >> HCD core allocates memory for HCD private data in >> usb_create_[shared_]hcd() so make use of that >> mechanism to allocate the struct xhci_hcd. >> >> Introduce struct xhci_driver_overrides to provid

Re: Unable to access USB mass storage device with xhci. okay with ehci

2015-04-09 Thread Alan Stern
On Thu, 9 Apr 2015, Steve Bangert wrote: > > Still, I can imagine the uas-detect.h code setting the > > US_FL_MAX_SECTORS_64 flags bit and then the uas driver calling > > blk_queue_max_hw_sectors() the way we do in > > scsiglue.c:slave_configure(). > > Alan, would this approach create/implement d

Re: Unable to access USB mass storage device with xhci. okay with ehci

2015-04-09 Thread Alan Stern
On Thu, 9 Apr 2015, Hans de Goede wrote: > > uas.c was patched (see attached), the quirk line was temporarily removed > > Thanks for testing this. > > > and i now have access to the drive using xhci and uas. usbmon trace is > > attached. > > What exactly do you mean with "i now have access to t

Re: [GIT PULL] USB resume timeout rework for v4.1

2015-04-09 Thread Grégory Herrero
Hi Felipe, Following patch: usb: dwc2: hcd: use new USB_RESUME_TIMEOUT is not correct. The delay is currently done before the controller drives the resume timeout. Attached patch fix this issue. 2015-04-07 22:49 GMT+00:00 Felipe Balbi : > Hi Greg, > > As promised, here's a pull request with only

Re: [GIT PULL] USB resume timeout rework for v4.1

2015-04-09 Thread Felipe Balbi
On Thu, Apr 09, 2015 at 10:17:08AM +, Grégory Herrero wrote: > Hi Felipe, > > Following patch: usb: dwc2: hcd: use new USB_RESUME_TIMEOUT is not correct. > The delay is currently done before the controller drives the resume timeout. > Attached patch fix this issue. > > 2015-04-07 22:49 GMT+00