Re: [PATCH v2] usb: introduce OTG 2.0 related kernel feature and API.

2015-03-26 Thread Peter Chen
On Thu, Mar 26, 2015 at 11:21:43AM +0800, Macpaul Lin wrote: > Introduce kernel feature CONFIG_USB_OTG20 and related > gadget_is_otg20() API for supporting OTG20 compliant > drivers. > This patch also updated usb_otg_descritpor. > > Signed-off-by: Macpaul Lin > --- > drivers/usb/core/Kconfig

Re: [PATCH v2] usb: introduce OTG 2.0 related kernel feature and API.

2015-03-26 Thread Greg KH
On Thu, Mar 26, 2015 at 11:21:43AM +0800, Macpaul Lin wrote: > Introduce kernel feature CONFIG_USB_OTG20 and related > gadget_is_otg20() API for supporting OTG20 compliant > drivers. > This patch also updated usb_otg_descritpor. > > Signed-off-by: Macpaul Lin > --- > drivers/usb/core/Kconfig

[PATCH v2 1/1] usb: chipidea: otg: remove mutex unlock and lock while stop and start role

2015-03-26 Thread Li Jun
Wrongly release mutex lock during otg_statemachine may result in re-enter otg_statemachine, which is not allowed, we should do next state transtition after previous one completed. Fixes: 826cfe751f3e ("usb: chipidea: add OTG fsm operation functions implementation") Cc: # v3.16+ Signed-off-by: Li

[PATCH 1/1] usb: chipidea: debug: add low power mode check before print registers

2015-03-26 Thread Li Jun
Since the required clock to access registers is gated off in low power mode, add ci->in_lpm check before try to dump registers value. Signed-off-by: Li Jun --- drivers/usb/chipidea/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/debug.c b/drivers/

Re: [PATCH 00/12] USB: chipidea: patchset for performance improvement

2015-03-26 Thread victorascroft
Hello Peter, On 15-03-24 20:21:47, Peter Chen wrote: > On Tue, Mar 24, 2015 at 04:02:53PM +0530, victorascr...@gmail.com wrote: > > Hello Peter, > > > > On 15-03-19 09:19:11, Peter Chen wrote: > > > Hi all, > > > > > > In this patch set, I add some interfaces for tuning the performance > > > of

Re: [PATCH 1/1] usb: chipidea: debug: add low power mode check before print registers

2015-03-26 Thread Peter Chen
On Thu, Mar 26, 2015 at 04:19:52PM +0800, Li Jun wrote: > Since the required clock to access registers is gated off in low power mode, > add ci->in_lpm check before try to dump registers value. > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/debug.c | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH v2 1/1] usb: chipidea: otg: remove mutex unlock and lock while stop and start role

2015-03-26 Thread Peter Chen
On Thu, Mar 26, 2015 at 04:09:46PM +0800, Li Jun wrote: > Wrongly release mutex lock during otg_statemachine may result in re-enter > otg_statemachine, which is not allowed, we should do next state transtition > after previous one completed. > > Fixes: 826cfe751f3e ("usb: chipidea: add OTG fsm ope

Re: [PATCH 1/1] usb: chipidea: udc: bypass pullup DP when gadget connect in OTG fsm mode

2015-03-26 Thread Peter Chen
On Mon, Mar 23, 2015 at 04:03:35PM +0800, Li Jun wrote: > By pass pullup DP in OTG fsm mode when do gadget connect, to let it handled > by OTG state machine. > > Signed-off-by: Li Jun > > This patch can fix the problem you found with my HNP polling patchset after > below 3 patches introduced: >

Re: [PATCH v4 0/8] add HNP polling support for usb otg fsm

2015-03-26 Thread Peter Chen
On Wed, Mar 25, 2015 at 07:25:24PM +0800, Li Jun wrote: > On Wed, Mar 25, 2015 at 02:43:43PM +0800, Chen Peter-B29397 wrote: > > > > > On Wed, Mar 25, 2015 at 02:03:51PM +0800, Peter Chen wrote: > > > > > > > > Hi Jun, > > > > > > > > The above three patches are in Greg's next tree, after I apply

Re: [PATCH v4 3/8] usb: common: otg-fsm: add HNP polling support

2015-03-26 Thread Peter Chen
On Thu, Mar 19, 2015 at 11:11:20AM +0800, Li Jun wrote: > Adds HNP polling timer when transits to host state, the OTG status request > will be sent to peripheral after timeout, if host request flag is set, it will > switch to peripheral state, otherwise it will repeat HNP polling every 1.5s > and

Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

2015-03-26 Thread Greg KH
On Wed, Mar 25, 2015 at 09:53:34PM +0100, Marek Belisko wrote: > From: "H. Nikolaus Schaller" > > While trying to test the Pyra GSM/GPS/3G module I had reconfigured > the USB interface by mistake and therefore needed to run a different > USB driver than CSC-ACM. It turned out that I need the "usb

Re: [PATCH 4/4] usb: legacy/multi add supports OTG 2.0

2015-03-26 Thread Peter Chen
On Thu, Mar 26, 2015 at 03:38:38AM +0800, Macpaul Lin wrote: > add supports OTG 2.0 for multi.c > > Signed-off-by: Macpaul Lin > --- > drivers/usb/gadget/legacy/multi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/gadget/legacy/multi.c > b/drivers/usb/gadget/legacy/m

Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

2015-03-26 Thread Belisko Marek
On Thu, Mar 26, 2015 at 10:53 AM, Greg KH wrote: > On Wed, Mar 25, 2015 at 09:53:34PM +0100, Marek Belisko wrote: >> From: "H. Nikolaus Schaller" >> >> While trying to test the Pyra GSM/GPS/3G module I had reconfigured >> the USB interface by mistake and therefore needed to run a different >> USB

Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

2015-03-26 Thread Dr. H. Nikolaus Schaller
Am 26.03.2015 um 11:41 schrieb Belisko Marek : > On Thu, Mar 26, 2015 at 10:53 AM, Greg KH wrote: >> On Wed, Mar 25, 2015 at 09:53:34PM +0100, Marek Belisko wrote: >>> From: "H. Nikolaus Schaller" >>> >>> While trying to test the Pyra GSM/GPS/3G module I had reconfigured >>> the USB interface

Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

2015-03-26 Thread Greg KH
On Thu, Mar 26, 2015 at 11:41:24AM +0100, Belisko Marek wrote: > On Thu, Mar 26, 2015 at 10:53 AM, Greg KH wrote: > > On Wed, Mar 25, 2015 at 09:53:34PM +0100, Marek Belisko wrote: > >> From: "H. Nikolaus Schaller" > >> > >> While trying to test the Pyra GSM/GPS/3G module I had reconfigured > >>

[RFC 5/6] usb: gadget: atmel_usba: use atmel_io.h to provide on-chip IO

2015-03-26 Thread Ben Dooks
Use to provide IO accessors which work on both AVR32 and ARM for on-chip peripherals. Signed-off-by: Ben Dooks -- CC: Nicolas Ferre CC: Felipe Balbi CC: Greg Kroah-Hartman CC: linux-usb@vger.kernel.org --- drivers/usb/gadget/udc/atmel_usba_udc.c | 1 + drivers/usb/gadget/udc/atmel_usba_udc.

Re: [RFC 5/6] usb: gadget: atmel_usba: use atmel_io.h to provide on-chip IO

2015-03-26 Thread Hans-Christian Egtvedt
Around Thu 26 Mar 2015 11:45:53 + or thereabout, Ben Dooks wrote: > Use to provide IO accessors which work on both > AVR32 and ARM for on-chip peripherals. > > Signed-off-by: Ben Dooks Acked-by: Hans-Christian Egtvedt > -- > CC: Nicolas Ferre > CC: Felipe Balbi > CC: Greg Kroah-Hartman

Re: xhci_hcd error Transfer event TRB DMA ptr not part of current TD ep_index 8 comp_code 1

2015-03-26 Thread Alistair Grant
On Mon, Mar 23, 2015 at 10:14 PM, Devin Heitmueller wrote: > > My guess would be that there's some bug in the cx231xx that > exacerbates an edge case in the XHCI core - like prematurely setting > the USB alternate back to zero when stopping streaming and not > canceling all the URBs first. > > ...

[PATCHv4 01/12] usb: add bus type for USB ULPI

2015-03-26 Thread Heikki Krogerus
UTMI+ Low Pin Interface (ULPI) is a commonly used PHY interface for USB 2.0. The ULPI specification describes a standard set of registers which the vendors can extend for their specific needs. ULPI PHYs provide often functions such as charger detection and ADP sensing and probing. There are two ma

[PATCH] usb: gadget: hid: Fix static variable usage

2015-03-26 Thread Krzysztof Opasiak
If we have multiple instances of hid function, each of them may have different report descriptor, also their length may be different. Currently we are using static hidg_desc varable which is being filled in hidg_bind(). Then we send its content to host in hidg_setup() function. This content may ha

Re: [PATCH] usb: gadget: hid: Fix static variable usage

2015-03-26 Thread Sergei Shtylyov
Hello. On 03/26/2015 06:03 PM, Krzysztof Opasiak wrote: If we have multiple instances of hid function, each of them may have different report descriptor, also their length may be different. Currently we are using static hidg_desc varable which is being filled in hidg_bind(). Then we send its

Need a phy function to enable / disable usb squelch detection

2015-03-26 Thread Hans de Goede
Hi Kishon, I've been debugging why some devices do not work with the musb otg controller found on Allwinner SoC-s, and the conclusion is not good, the Android kernel does a poke to the phy before releasing the usb reset. Now you did not want me to introduce any sunxi specific / private phy funct

Re: [PATCH 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core

2015-03-26 Thread Dmitry Torokhov
On Wed, Mar 25, 2015 at 05:04:32PM -0700, Arun Ramamurthy wrote: > > > On 15-03-25 03:03 PM, Kishon Vijay Abraham I wrote: > >Hi, > > > >On Saturday 21 March 2015 02:59 AM, Arun Ramamurthy wrote: > >> > >> > >>On 15-03-20 02:26 PM, Dmitry Torokhov wrote: > >>>Hi Arun, > >>> > >>>On Fri, Mar 20, 2

[PATCH] usb: Fix warnings in chaoskey driver

2015-03-26 Thread keithp
From: Keith Packard >drivers/usb/misc/chaoskey.c: In function 'chaoskey_read': > >> drivers/usb/misc/chaoskey.c:412:3: error: implicit declaration of function > >> 'copy_to_user' > >> [-Werror=implicit-function-declaration] > remain = copy_to_user(buffer, dev->buf + dev->used, this_tim

RE: Need a phy function to enable / disable usb squelch detection

2015-03-26 Thread Peter Chen
> Hi Kishon, > > I've been debugging why some devices do not work with the musb otg > controller found on Allwinner SoC-s, and the conclusion is not good, the > Android kernel does a poke to the phy before releasing the usb reset. > > Now you did not want me to introduce any sunxi specific / pr

[PATCH] usb: gadget: s3c2410_udc: Remove static char buffer, use vsprintf extension %pV

2015-03-26 Thread Joe Perches
Using unnecessary static char buffers isn't good. Use the %pV extension instead. Miscellanea: o the dprintk return value is unused, make it void o add __printf format and argument verification Signed-off-by: Joe Perches --- This doesn't matter much as it is pretty unusual to enable printk suppo