Re: [PATCH v4 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-18 Thread Mathias Nyman
Hi This looks correct, but if you are still going to make a new series fixing Felipe's comments then the following tiny nitpicks could be fixed as well. Otherwise Acked-by: Mathias Nyman Felipe, Do you want to take this series through your tree? On 17.02.2015 07:41, Sneeker Yeh wrote: > >

Re: default/target product id /vendor id for usb devices

2015-02-18 Thread temp sha
I have a new usb dongle Huawei E3531 trying to support in my h/w having old kernel version 2.6.16. I use usb_modeswitch to change the mode from usb storage to modem manually. As I do not have udev rule support in my h/w, I need an alternative way of mode switching during plugin time automatically.

Re: please can you add my device ?

2015-02-18 Thread faivre.laur...@laposte.net
The ftdi_sio driver is the correct driver for this device, please use that one. OK, I use it now With this same device? No, but for the same application Are you sure you don't have hardware flow control enabled? It's a common mistake with serial devices. no flow control needed, no flow co

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-18 Thread Mika Westerberg
On Tue, Feb 17, 2015 at 11:35:23AM -0800, David Cohen wrote: > Hi, > > Adding Mika. > > On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote: > > Hi, > > > > On Tue, Feb 17, 2015 at 11:18:44AM -0800, David Cohen wrote: > > > > > > > (3) Platform has 2 USB controllers connected to same po

Re: [PATCH] cdc-acm: Add support for Denso cradle CU-321

2015-02-18 Thread Oliver Neukum
On Wed, 2015-02-18 at 07:19 +0100, Björn Gerhart wrote: > In order to support an older USB cradle by Denso, I added its vendor- and > product-ID to the array of usb_device_id acm_ids. In this way cdc-acm feels > responsible for this cradle. The related /dev/ttyACM node is being created > properl

Re: default/target product id /vendor id for usb devices

2015-02-18 Thread Clemens Ladisch
temp sha wrote: > I have a new usb dongle Huawei E3531 trying to support in my h/w > having old kernel version 2.6.16. > I use usb_modeswitch to change the mode from usb storage to modem > manually. As I do not have udev rule > support in my h/w, I need an alternative way of mode switching during >

Re: [PATCHv3 1/5] usb: gadget: bind UDC by name passed via usb_gadget_driver structure

2015-02-18 Thread Sergei Shtylyov
Hello. On 2/18/2015 12:17 AM, Ruslan Bilovol wrote: Introduce new 'udc_name' member to usb_gadget_driver structure. The 'udc_name' is a name of UDC that usb_gadget_driver should be bound to. If udc_name is NULL, it will be bound to any available UDC. Signed-off-by: Ruslan Bilovol --- driv

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2015-02-18 Thread Pali Rohár
On Saturday 31 January 2015 10:53:30 Pali Rohár wrote: > This patch adds removable mass storage support to g_nokia > gadget (for N900). It means that at runtime block device can > be exported or unexported. So it does not export anything by > default and thus allows to use MyDocs partition as befor

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2015-02-18 Thread Pali Rohár
On Saturday 07 February 2015 19:33:53 Ivaylo Dimitrov wrote: > Hi, > > On 7.02.2015 20:01, Ivaylo Dimitrov wrote: > > On 2.02.2015 21:14, Felipe Balbi wrote: > >> On Mon, Feb 02, 2015 at 08:07:51PM +0100, Pali Rohár wrote: > >>> On Monday 02 February 2015 20:01:11 Felipe Balbi wrote: > Hi,

Re: default/target product id /vendor id for usb devices

2015-02-18 Thread temp sha
Yes running usb_modeswitch manually works, but once mode switch is done product id is getting changed from 0x1446 to 0x1506. looking into the help I found 0x1446 is default product id wheres 0x1506 is the target product id. but could not get the idea behind this concept. Yes I do have hotplug but I

Re: default/target product id /vendor id for usb devices

2015-02-18 Thread Peter Stuge
temp sha wrote: > Yes running usb_modeswitch manually works, but once mode switch is > done product id is getting changed from 0x1446 to 0x1506. Look closely in the kernel output and you'll see that no ids change, but that the old device has disconnected and a new device has connected. > looking

Re: XHCI, "brain-dead scanner", and microframe rounding

2015-02-18 Thread Hans-Peter Jansen
Mathias Nyman writes: > > On 27.01.2015 13:57, Hans-Peter Jansen wrote: > > > What about a stable backport? Do you think, it's feasible, too much work, or > > too risky? > > > > This should definitely be backported to 3.18 stable, which should be easy. > Older longterms kernels are a bit tric

Re: default/target product id /vendor id for usb devices

2015-02-18 Thread temp sha
>> Look closely in the kernel output and you'll see that no ids change, >> but that the old device has disconnected and a new device has >> connected. sorry I could not get it completely. what is this new device/ old device ? there is only one device USB dongle. changing usb mode can change the pr

Re: default/target product id /vendor id for usb devices

2015-02-18 Thread Peter Stuge
temp sha wrote: > >> Look closely in the kernel output and you'll see that no ids change, > >> but that the old device has disconnected and a new device has > >> connected. > > sorry I could not get it completely. > what is this new device/ old device ? A USB device as seen by the kernel is a sof

Re: default/target product id /vendor id for usb devices

2015-02-18 Thread temp sha
Thanks Peter and Clemens for your detailed explanations now I got it. On Wed, Feb 18, 2015 at 6:48 PM, Peter Stuge wrote: > temp sha wrote: >> >> Look closely in the kernel output and you'll see that no ids change, >> >> but that the old device has disconnected and a new device has >> >> connect

Re: [PATCH v4 5/5] usb: dwc3: add Fujitsu Specific Glue layer

2015-02-18 Thread Sneeker Yeh
hi Felipe: thanks for the suggestion, 2015-02-18 3:26 GMT+08:00 Felipe Balbi : > On Tue, Feb 17, 2015 at 01:41:37PM +0800, Sneeker Yeh wrote: >> This patch adds support for Synopsis DesignWare USB3 IP Core found >> on Fujitsu Socs. >> >> Signed-off-by: Sneeker Yeh >> --- >> .../devicetree/bindi

Re: [PATCH v4 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-18 Thread Sneeker Yeh
hi Mathias, thanks for reviewing these, 2015-02-18 16:47 GMT+08:00 Mathias Nyman : > Hi > > This looks correct, but if you are still going to make a new series fixing > Felipe's comments then the following tiny nitpicks could be fixed as well. > > Otherwise > > Acked-by: Mathias Nyman > > Felipe

Re: [PATCH v4 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-18 Thread Felipe Balbi
On Wed, Feb 18, 2015 at 10:47:45AM +0200, Mathias Nyman wrote: > Hi > > This looks correct, but if you are still going to make a new series fixing > Felipe's comments then the following tiny nitpicks could be fixed as well. > > Otherwise > > Acked-by: Mathias Nyman > > Felipe, Do you want to

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-18 Thread Felipe Balbi
On Wed, Feb 18, 2015 at 01:44:21PM +0800, zhangfei wrote: > Hi, Kishon > > On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote: > >Hi, > > > >On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote: > >>Add usb phy controller for hi6220 platform > >> > >>Signed-off-by: Zhangfei Gao > >>--- > >

Re: [PATCH v4 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-18 Thread Felipe Balbi
On Wed, Feb 18, 2015 at 10:39:53PM +0800, Sneeker Yeh wrote: > Hi, > 2015/2/18 下午10:34 於 "Felipe Balbi" 寫道: > > > > On Wed, Feb 18, 2015 at 10:47:45AM +0200, Mathias Nyman wrote: > > > Hi > > > > > > This looks correct, but if you are still going to make a new series > fixing > > > Felipe's commen

Re: please can you add my device ?

2015-02-18 Thread Greg KH
On Wed, Feb 18, 2015 at 11:15:57AM +0100, faivre.laur...@laposte.net wrote: > >The ftdi_sio driver is the correct driver for this device, please use that > >one. > OK, I use it now > > >With this same device? > No, but for the same application So a different device works fine, but this specific

Re: cdc_mbim with Huawei E3372, nothing works

2015-02-18 Thread Sami Farin
My kernel had dynamic debug, but it was not enabled for these cdc* modules for i in usbcore usbnet cdc_ether cdc_mbim cdc_wdm cdc_ncm; do echo "module ${i} +p" > /sys/kernel/debug/dynamic_debug/control; done [798439.898210] hub 3-0:1.0: hub_resume [798439.898223] hub 5-0:1.0: state 7 ports 2 chg

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-18 Thread David Cohen
Hi, On Wed, Feb 18, 2015 at 12:17:06PM +0200, Mika Westerberg wrote: > On Tue, Feb 17, 2015 at 11:35:23AM -0800, David Cohen wrote: > > Hi, > > > > Adding Mika. > > > > On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Feb 17, 2015 at 11:18:44AM -0800,

Re: please can you add my device ?

2015-02-18 Thread faivre.laur...@laposte.net
> So a different device works fine, but this specific one does not? Yes, and I just tested under Windows, same results !!! No data seems to come under 115200 bauds. So I think it's a material problem oh the device, not a driver problem (or both drivers, Linux and Windows... I don't think so).

Re: Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-18 Thread Karl Palsson
Johan Hovold wrote: > On Wed, Feb 18, 2015 at 11:32:38AM +0700, Johan Hovold wrote: > > On Tue, Feb 17, 2015 at 10:45:11PM -0500, Nicolas PLANEL wrote: > > > I believe the fix should be implemented slightly differently however. > > Most usb-serial driver call set_termios from open to handle this

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-18 Thread Tim Chen
On Wed, 2015-02-04 at 10:30 -0800, Tim Chen wrote: > On Mon, 2015-02-02 at 19:39 +0300, Sergei Shtylyov wrote: > > > > > > Hi, is this an open-coded version of PAGE_ALIGN? > > > > Yes, it appears so. :-) > > > > WBR, Sergei > > > > Thanks for the suggestion by Jiri. I updated the patch to

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-18 Thread Alan Stern
On Wed, 18 Feb 2015, Tim Chen wrote: > On Wed, 2015-02-04 at 10:30 -0800, Tim Chen wrote: > > On Mon, 2015-02-02 at 19:39 +0300, Sergei Shtylyov wrote: > > > > > > > > > Hi, is this an open-coded version of PAGE_ALIGN? > > > > > > Yes, it appears so. :-) > > > > > > WBR, Sergei > > > > >

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-18 Thread Tim Chen
On Wed, 2015-02-18 at 14:53 -0500, Alan Stern wrote: > On Wed, 18 Feb 2015, Tim Chen wrote: > > > On Wed, 2015-02-04 at 10:30 -0800, Tim Chen wrote: > > > On Mon, 2015-02-02 at 19:39 +0300, Sergei Shtylyov wrote: > > > > > > > > > > > > Hi, is this an open-coded version of PAGE_ALIGN? > > > > >

[PATCH v2 1/1] USB: ch341: set tty baud speed according to tty struct

2015-02-18 Thread Nicolas PLANEL
The ch341_set_baudrate() function initialize the device baud speed according to the value on priv->baud_rate. By default the ch341_open() set it to a hardcoded value (DEFAULT_BAUD_RATE 9600). Unfortunately, the tty_struct is not initialized with the same default value. (usually 56700) This means t

[PATCH v2 0/1] USB: ch341: set tty baud speed according to tty struct

2015-02-18 Thread Nicolas PLANEL
Nicolas PLANEL (1): USB: ch341: set tty baud speed according to tty struct drivers/usb/serial/ch341.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.

Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-18 Thread Nicolas PLANEL
On 02/18/2015 02:05 PM, Karl Palsson wrote: Johan Hovold wrote: On Wed, Feb 18, 2015 at 11:32:38AM +0700, Johan Hovold wrote: On Tue, Feb 17, 2015 at 10:45:11PM -0500, Nicolas PLANEL wrote: I believe the fix should be implemented slightly differently however. Most usb-serial driver call set_t

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-18 Thread Greg Kroah-Hartman
On Wed, Feb 18, 2015 at 12:19:03PM -0800, Tim Chen wrote: > On Wed, 2015-02-18 at 14:53 -0500, Alan Stern wrote: > > On Wed, 18 Feb 2015, Tim Chen wrote: > > > > > On Wed, 2015-02-04 at 10:30 -0800, Tim Chen wrote: > > > > On Mon, 2015-02-02 at 19:39 +0300, Sergei Shtylyov wrote: > > > > > > > >

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-18 Thread Andi Kleen
> > Have you tried doing the experiments I suggested in > > > > http://marc.info/?l=linux-usb&m=142272448620716&w=2 > > > > to determine where the problem occurs? > > > > I was bogged down with other things lately and I haven't got a chance to > test that. But as you said, there's very

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-18 Thread Alan Stern
On Wed, 18 Feb 2015, Tim Chen wrote: > > Have you tried doing the experiments I suggested in > > > > http://marc.info/?l=linux-usb&m=142272448620716&w=2 > > > > to determine where the problem occurs? > > > > I was bogged down with other things lately and I haven't got a chance to > tes

Re: [PATCH] usb: renesas: fix extcon dependency

2015-02-18 Thread Arnd Bergmann
On Thursday 29 January 2015 11:41:58 Russell King - ARM Linux wrote: > On Wed, Jan 28, 2015 at 10:47:18PM +0100, Arnd Bergmann wrote: > > The renesas usbhs driver calls extcon_get_edev_by_phandle(), which > > is defined in drivers/extcon/extcon-class.c, and that can be a > > loadable module. If the

[PATCH v2] usb: renesas: fix extcon dependency

2015-02-18 Thread Arnd Bergmann
The renesas usbhs driver calls extcon_get_edev_by_phandle(), which is defined in drivers/extcon/extcon-class.c, and that can be a loadable module. If the extcon-class support is disabled, usbhs will work correctly for all devices that do not need extcon. However, if extcon-class is a loadable modu

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-18 Thread Alan Stern
On Wed, 18 Feb 2015, Andi Kleen wrote: > > > Have you tried doing the experiments I suggested in > > > > > > http://marc.info/?l=linux-usb&m=142272448620716&w=2 > > > > > > to determine where the problem occurs? > > > > > > > I was bogged down with other things lately and I haven't got

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-18 Thread Tim Chen
On Wed, 2015-02-18 at 15:45 -0500, Alan Stern wrote: > On Wed, 18 Feb 2015, Tim Chen wrote: > > > > Have you tried doing the experiments I suggested in > > > > > > http://marc.info/?l=linux-usb&m=142272448620716&w=2 > > > > > > to determine where the problem occurs? > > > > > > > I was

[PATCH] xhci: use dma_alloc_coherent with fully cleared pages

2015-02-18 Thread Tim Chen
Commit d92ef66c4f8f ("x86: make dma_alloc_coherent() return zeroed memory if CMA is enabled") changed the dma_alloc_coherent page clearance from using an __GFP_ZERO in page allocation to not setting the flag but doing an explicit memory clear at the end. However the memory clear only covered the

Re: [PATCH v2 1/1] USB: ch341: set tty baud speed according to tty struct

2015-02-18 Thread Johan Hovold
On Wed, Feb 18, 2015 at 03:22:30PM -0500, Nicolas PLANEL wrote: > The ch341_set_baudrate() function initialize the device baud speed according > to the value on priv->baud_rate. By default the ch341_open() set it to a > hardcoded value (DEFAULT_BAUD_RATE 9600). Unfortunately, the tty_struct is > no

Re: Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-18 Thread Johan Hovold
On Wed, Feb 18, 2015 at 07:05:41PM -, Karl Palsson wrote: > I've already got most of this working in my branch overhauling this > driver. I agree, the open call shouldn't be doing all the hard > resetting of settings that it currently does. I've implemented more of > set termios / get termio

[PATCH] USB: ch341: remove redundant close from open error path

2015-02-18 Thread Johan Hovold
Remove redundant call to ch341_close from error path when submission of the interrupt urb fails in open. Signed-off-by: Johan Hovold --- drivers/usb/serial/ch341.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index 2d72aa3564a3..79c56

Re: usb serial: pl2303 driver TxD "break" stays after close() bug

2015-02-18 Thread Johan Hovold
On Thu, Feb 05, 2015 at 12:56:20PM +0200, Jari Ruusu wrote: > Tested on 3.10.67 and 3.18.5 kernels with ATEN UC-232A usb-serial adapter. > No patch, sorry. To actually see the stuck "break" signal on TxD line, you > need either some sort of LED or voltmeter connected to the data transmit > line. Ot

cdc_acm driver with Arduino USB2SERIAL problem

2015-02-18 Thread Roberto Bianchi
Hi. I'm writing to you since Johan Hovold addressed me to your email... I don't find a solution to a problem with cdc-acm driver for linux and Arduino USB2SERIAL LIGHT (http://arduino.cc/en/Main/USBSerial). The problem: the "arduino usb2serial light" ISP is not recognized by the driver cdc-acm an