re: usb: gadget: configfs: OS Extended Compatibility descriptors support

Hello Andrzej Pietrasiewicz, The patch da4243145fb1: "usb: gadget: configfs: OS Extended Compatibility descriptors support" from May 8, 2014, leads to the following Smatch warning: drivers/usb/gadget/configfs.c:1195 interf_grp_sub_compatible_id_store() error: buffer overflow 'desc

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

On 12.02.2015 17:18, Alan Stern wrote: > On Thu, 12 Feb 2015, Mathias Nyman wrote: > >> On 25.01.2015 10:13, Sneeker Yeh wrote: >>> This issue is defined by a three-way race at disconnect, between >>> 1) Class driver interrupt endpoint resheduling attempts if the ISR gave an >>> ep >>>error e

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

On 25.01.2015 10:13, Sneeker Yeh wrote: Oh, and one more thing: > > +static void xhci_try_to_clear_csc(struct usb_hcd *hcd, int dev_port_num) > +{ > + int max_ports; > + struct xhci_hcd *xhci = hcd_to_xhci(hcd); > + __le32 __iomem **port_array; > + u32 status; > + > + /* pri

[PATCH v4] USB:ftdi_sio: Added Pids for Actisense Usb Devices

From: Mark Glover Only Email comments have changed since the last version of this patch. These product identifiers (PID) all deal with marine NMEA format data used on motor boats and yachts We supply the programmed devices to Chetco, for use inside their equipment. The PIDs are a direct copy of

Re: usb: gadget: configfs: OS Extended Compatibility descriptors support

W dniu 13.02.2015 o 09:06, Dan Carpenter pisze: Hello Andrzej Pietrasiewicz, Hello Dan, Thank you for finding the problem. The patch da4243145fb1: "usb: gadget: configfs: OS Extended Compatibility descriptors support" from May 8, 2014, leads to the following Smatch warning: drivers

Kernel 3.6.0 works, newer doesn't

Hi there, Sorry, I'm new to this list, so excuse my newbie question. I have Linux 3.6.0-030600-generic #201209302035 SMP Mon Oct 1 00:36:01 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux installed and it works great. My WLAN driver works with this version, but not with any newer version of the kernel. A

[PATCH] usb: gadget: configfs: don't NUL-terminate (sub)compatible ids

The "Extended Compat ID OS Feature Descriptor Specification" does not require the (sub)compatible ids to be NUL-terminated, because they are placed in a fixed-size buffer and only unused parts of it should contain NULs. If the buffer is fully utilized, there is no place for NULs. Consequently, the

Re: [PATCH 1/8] usb: add bus type for USB ULPI

On Thu, Feb 12, 2015 at 05:44:20PM -0800, Stephen Boyd wrote: > On 01/23/15 07:12, Heikki Krogerus wrote: > > diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c > > index e614ef6..753cb08 100644 > > --- a/scripts/mod/file2alias.c > > +++ b/scripts/mod/file2alias.c > > @@ -1176,6 +1176

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

Hi, On Thu, Feb 12, 2015 at 05:52:42PM -0800, David Cohen wrote: > Hi Heikki, > > Sorry I am starting a new branch on this thread. > I need to go back to another topic on this same patch. > > On Fri, Jan 23, 2015 at 05:12:58PM +0200, Heikki Krogerus wrote: > > TUSB1210 ULPI PHY has vendor specif

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: > On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > index a8c9062..66cbf38 100644 > > > > --- a/drivers/usb/dwc3/core.c > > > > +++ b/drivers/us

[PATCH] hso: fix rx parsing logic when skb allocation fails

If skb allocation fails once the IP header has been received, the rx state is being set to WAIT_SYNC. The logic, though, shouldn't directly return, as the buffer may contain a full packet, and therefore the WAIT_SYNC state needs to be processed (resetting state to WAIT_IP, clearing rx_buf_size and

Re: [PATCH] hso: fix rx parsing logic when skb allocation fails

From: Aleksander Morgado Date: Fri, 13 Feb 2015 14:51:02 +0100 > If skb allocation fails once the IP header has been received, the rx state is > being set to WAIT_SYNC. The logic, though, shouldn't directly return, as the > buffer may contain a full packet, and therefore the WAIT_SYNC state needs

Re: Kernel 3.6.0 works, newer doesn't

On Fri, Feb 13, 2015 at 11:20:33PM +1300, Tim-Hinnerk Heuer wrote: > Hi there, > > Sorry, I'm new to this list, so excuse my newbie question. > > I have Linux 3.6.0-030600-generic #201209302035 SMP Mon Oct 1 00:36:01 > UTC 2012 x86_64 x86_64 x86_64 GNU/Linux installed and it works great. > My WLA

[PATCH] USB: usbfs: don't leak kernel data in siginfo

When a signal is delivered, the information in the siginfo structure is copied to userspace. Good security practice dicatates that the unused fields in this structure should be initialized to 0 so that random kernel stack data isn't exposed to the user. This patch adds such an initialization to t

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

On Fri, Feb 13, 2015 at 02:35:16PM +0200, Heikki Krogerus wrote: > Hi, > > On Thu, Feb 12, 2015 at 05:52:42PM -0800, David Cohen wrote: > > Hi Heikki, > > > > Sorry I am starting a new branch on this thread. > > I need to go back to another topic on this same patch. > > > > On Fri, Jan 23, 2015

[PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

Every USB Host controller should use this new macro to define for how long resume signalling should be driven on the bus. Currently, almost every single USB controller is using a 20ms timeout for resume signalling. That's problematic for two reasons: a) sometimes that 20ms timer expires a little

[PATCH 02/13] usb: host: xhci: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index e692e769

[PATCH 00/13] increase resume timeout for all controllers

Hi all, Because every year or so we go through some brokeness related to resume signalling, let's make sure everybody uses a single resume signalling timeout value which is rather large (40ms as of now). The reasons for doing this are explained in patch 1 of the series. Series has been tested wi

[PATCH 05/13] usb: musb: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Based on original work by Bin Liu > Cc: Bin Liu Signed-off-by: Felipe Balbi --- drivers/usb/musb/musb_core.c| 5 +++-- drivers/usb/musb/musb_virthub.c | 2 +- 2 files changed, 4 insertions(+), 3 de

[PATCH 04/13] usb: host: uhci: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Signed-off-by: Felipe Balbi --- drivers/usb/host/uhci-hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/uhci-hub.c b/drivers/usb/host/uhci-hub.c index 93e17b12fb3

[PATCH 07/13] usb: host: fotg210: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Signed-off-by: Felipe Balbi --- drivers/usb/host/fotg210-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index ec

[PATCH 08/13] usb: host: fusbh200: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Signed-off-by: Felipe Balbi --- drivers/usb/host/fusbh200-hcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c ind

[PATCH 06/13] usb: host: isp116x: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Signed-off-by: Felipe Balbi --- drivers/usb/host/isp116x-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 31

[PATCH 03/13] usb: host: ehci: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Signed-off-by: Felipe Balbi --- drivers/usb/host/ehci-hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c index 118edb7bdca

[PATCH 10/13] usb: host: r8a66597: use new USB_RESUME_TIMEOUT

While this driver was already using a 50ms resume timeout, let's make sure everybody uses the same macro so it's easy to fix later should anything go wrong. It also gives a more "stable" expectation to Linux users. Signed-off-by: Felipe Balbi --- drivers/usb/host/r8a66597-hcd.c | 2 +- 1 file c

[PATCH 11/13] usb: host: sl811: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Signed-off-by: Felipe Balbi --- drivers/usb/host/sl811-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c index 25fb1da8

[PATCH 13/13] usb: isp1760: hcd: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Signed-off-by: Felipe Balbi --- drivers/usb/isp1760/isp1760-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.

[PATCH 12/13] usb: dwc2: hcd: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Signed-off-by: Felipe Balbi --- drivers/usb/dwc2/hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index c78c8740db1d..758b7e0380f6

[PATCH 09/13] usb: host: oxu210hp: use new USB_RESUME_TIMEOUT

Make sure we're using the new macro, so our resume signaling will always pass certification. Signed-off-by: Felipe Balbi --- drivers/usb/host/oxu210hp-hcd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > Every USB Host controller should use this new > macro to define for how long resume signalling > should be driven on the bus. > > Currently, almost every single USB controller > is using a 20ms timeout for resume signalling. > > That

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

On Fri, 13 Feb 2015, Felipe Balbi wrote: > Every USB Host controller should use this new > macro to define for how long resume signalling > should be driven on the bus. > > Currently, almost every single USB controller > is using a 20ms timeout for resume signalling. > > That's problematic for t

Re: [PATCH 03/13] usb: host: ehci: use new USB_RESUME_TIMEOUT

On Fri, 13 Feb 2015, Felipe Balbi wrote: > Make sure we're using the new macro, so our > resume signaling will always pass certification. > > Signed-off-by: Felipe Balbi > --- > drivers/usb/host/ehci-hub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/hos

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

On Fri, Feb 13, 2015 at 04:22:12PM -0500, Alan Stern wrote: > On Fri, 13 Feb 2015, Felipe Balbi wrote: > > > Every USB Host controller should use this new > > macro to define for how long resume signalling > > should be driven on the bus. > > > > Currently, almost every single USB controller > >

Re: [PATCH 04/13] usb: host: uhci: use new USB_RESUME_TIMEOUT

On Fri, 13 Feb 2015, Felipe Balbi wrote: > Make sure we're using the new macro, so our > resume signaling will always pass certification. > > Signed-off-by: Felipe Balbi > --- > drivers/usb/host/uhci-hub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/hos

Re: [PATCH 03/13] usb: host: ehci: use new USB_RESUME_TIMEOUT

On Fri, Feb 13, 2015 at 04:25:53PM -0500, Alan Stern wrote: > On Fri, 13 Feb 2015, Felipe Balbi wrote: > > > Make sure we're using the new macro, so our > > resume signaling will always pass certification. > > > > Signed-off-by: Felipe Balbi > > --- > > drivers/usb/host/ehci-hub.c | 2 +- > > 1

Re: [PATCH 04/13] usb: host: uhci: use new USB_RESUME_TIMEOUT

On Fri, Feb 13, 2015 at 04:30:15PM -0500, Alan Stern wrote: > On Fri, 13 Feb 2015, Felipe Balbi wrote: > > > Make sure we're using the new macro, so our > > resume signaling will always pass certification. > > > > Signed-off-by: Felipe Balbi > > --- > > drivers/usb/host/uhci-hub.c | 2 +- > > 1

Re: [PATCH 03/13] usb: host: ehci: use new USB_RESUME_TIMEOUT

On Fri, 13 Feb 2015, Alan Stern wrote: > On Fri, 13 Feb 2015, Felipe Balbi wrote: > > > Make sure we're using the new macro, so our > > resume signaling will always pass certification. > > > > Signed-off-by: Felipe Balbi > > --- > > drivers/usb/host/ehci-hub.c | 2 +- > > 1 file changed, 1 ins

Re: [PATCH 04/13] usb: host: uhci: use new USB_RESUME_TIMEOUT

On Fri, Feb 13, 2015 at 03:38:04PM -0600, Felipe Balbi wrote: > On Fri, Feb 13, 2015 at 04:30:15PM -0500, Alan Stern wrote: > > On Fri, 13 Feb 2015, Felipe Balbi wrote: > > > > > Make sure we're using the new macro, so our > > > resume signaling will always pass certification. > > > > > > Signed-

Re: [PATCH 03/13] usb: host: ehci: use new USB_RESUME_TIMEOUT

On Fri, Feb 13, 2015 at 04:40:09PM -0500, Alan Stern wrote: > On Fri, 13 Feb 2015, Alan Stern wrote: > > > On Fri, 13 Feb 2015, Felipe Balbi wrote: > > > > > Make sure we're using the new macro, so our > > > resume signaling will always pass certification. > > > > > > Signed-off-by: Felipe Balbi

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

Hi Felipe, [snip] > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > index 8d95056..53902ea 100644 > --- a/drivers/usb/dwc3/dwc3-pci.c > +++ b/drivers/usb/dwc3/dwc3-pci.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > > #include "platform_data

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

Hi Heikki, On Fri, Feb 13, 2015 at 03:16:40PM +0200, Heikki Krogerus wrote: > On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: > > On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > > index a

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

On Fri, Feb 13, 2015 at 02:02:11PM -0800, David Cohen wrote: > Hi Felipe, > > [snip] > > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > > index 8d95056..53902ea 100644 > > --- a/drivers/usb/dwc3/dwc3-pci.c > > +++ b/drivers/usb/dwc3/dwc3-pci.c > > @@ -21,6 +21,7 @@ > >

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

On Fri, Feb 13, 2015 at 02:03:45PM -0800, David Cohen wrote: > Hi Heikki, > > On Fri, Feb 13, 2015 at 03:16:40PM +0200, Heikki Krogerus wrote: > > On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote: > > > On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote: > > > > > > diff --

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

On Fri, Feb 13, 2015 at 04:03:57PM -0600, Felipe Balbi wrote: > On Fri, Feb 13, 2015 at 02:02:11PM -0800, David Cohen wrote: > > Hi Felipe, > > > > [snip] > > > > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > > > index 8d95056..53902ea 100644 > > > --- a/drivers/usb/d

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > Every USB Host controller should use this new > macro to define for how long resume signalling > should be driven on the bus. > > Currently, almost every single USB controller > is using a 20ms timeout for resume signalling. > > That

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > > Every USB Host controller should use this new > > macro to define for how long resume signalling > > should be driven on the bus. > > > > Currently, almost every single USB

[no subject]

You were selected for QATAR Foundation 2015 beneficiaries contact RodFalusi(rodrigofalus...@yahoo.co.za) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

On Fri, Feb 13, 2015 at 07:42:22PM -0600, Felipe Balbi wrote: > On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: > > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > > > Every USB Host controller should use this new > > > macro to define for how long resume signalling > > > s

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

Greg, On Fri, Feb 13, 2015 at 8:41 PM, Greg KH wrote: > On Fri, Feb 13, 2015 at 07:42:22PM -0600, Felipe Balbi wrote: >> On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: >> > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: >> > > Every USB Host controller should use this new

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

On Fri, Feb 13, 2015 at 09:07:40PM -0600, Bin Liu wrote: > Greg, > > On Fri, Feb 13, 2015 at 8:41 PM, Greg KH wrote: > > On Fri, Feb 13, 2015 at 07:42:22PM -0600, Felipe Balbi wrote: > >> On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: > >> > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Fel