[PATCH 0/2] usb: udc: Unify dp control

2015-01-12 Thread Peter Chen
Hi Felipe, This is the follow-up: http://marc.info/?l=linux-usb&m=140979297227434&w=2. Sorry for late. In the first patch, it maintains flag 'vbus' as vbus status, and try to connect or disconnect gadget according to vbus status. In the second patch, it maintains count 'deactivations' for connect

[PATCH 2/2] usb: udc: add usb_udc_activation_handler

2015-01-12 Thread Peter Chen
During this API, the deactivation count will be update, and it will try to connect or disconnect gadget. It can be used to enable functions for gadget. Signed-off-by: Peter Chen --- drivers/usb/gadget/udc/udc-core.c | 36 +++- include/linux/usb/gadget.h|

[PATCH 1/2] usb: udc: add usb_udc_vbus_handler

2015-01-12 Thread Peter Chen
This commit updates udc core vbus status, and try to connect or disconnect gadget. Signed-off-by: Peter Chen --- drivers/usb/gadget/udc/udc-core.c | 42 ++- include/linux/usb/gadget.h| 4 2 files changed, 45 insertions(+), 1 deletion(-) diff --g

Re: [PATCH V3 2/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2015-01-12 Thread Linus Walleij
On Wed, Dec 10, 2014 at 9:39 AM, Vivek Gautam wrote: > USB and Power regulator on Exynos7 require gpios available > in BUS1 pin controller block. > So adding the BUS1 pinctrl support. > > Signed-off-by: Naveen Krishna Ch > Signed-off-by: Vivek Gautam > Cc: Tomasz Figa > Cc: Linus Walleij > --

Re: [PATCH 1/2] Documentation: dt-bindings: Add aliases information for Exynos7 pin controllers

2015-01-12 Thread Linus Walleij
On Wed, Dec 10, 2014 at 9:39 AM, Vivek Gautam wrote: > Adding list of aliases for supported Exynos7 pin controller blocks. > > Signed-off-by: Vivek Gautam > Cc: Tomasz Figa > Cc: Linus Walleij Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH v3 1/4] scsi: add ability to adjust module reference for scsi host

2015-01-12 Thread Hannes Reinecke
On 01/11/2015 02:50 PM, Akinobu Mita wrote: > While accessing a scsi_device, the use count of the underlying LLDD module > is incremented. The module reference is retrieved through .module field of > struct scsi_host_template. > > This mapping between scsi_device and underlying LLDD module works

Re: [PATCH v3 0/2] usb: serial: silence non-critical unplug read errors

2015-01-12 Thread Johan Hovold
On Sun, Jan 11, 2015 at 05:42:05AM -0800, Jeremiah Mahler wrote: > If a USB serial device (e.g. /dev/ttyUSB0) with an active program is > unplugged, a bunch of -ENODEV and -EPROTO errors may be produced in the > logs. This patch set quiets these messages without changing the > original behavior.

Re: [PATCH v3 0/4] scsi: ufs & ums-* & esp_scsi: fix module reference counting

2015-01-12 Thread Christoph Hellwig
On Sun, Jan 11, 2015 at 10:50:02PM +0900, Akinobu Mita wrote: > While accessing a scsi_device, the use count of the underlying LLDD module > is incremented. The module reference is retrieved through .module field of > struct scsi_host_template. > > This mapping between scsi_device and underlying

[PATCH 0/3] usb: udc: cleanup pullup operation

2015-01-12 Thread Peter Chen
This patch set cleans up udc drivers which define .pullup API, but still call pullup operation at .udc_start or .udc_stop. In fact, the related pullup operations are covered by udc core. Peter Chen (3): usb: udc: pxa27x_udc: delete pullup operation at .udc_start and .udc_stop usb: pxa27x_u

[PATCH 1/3] usb: udc: pxa27x_udc: delete pullup operation at .udc_start and .udc_stop

2015-01-12 Thread Peter Chen
UDC core has already done it before .udc_stop and after .udc_start. Signed-off-by: Peter Chen --- drivers/usb/gadget/udc/pxa27x_udc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index c61a896..6a855fc 100644 ---

[PATCH 2/3] usb: pxa27x_udc: delete pullup operation at .udc_start and .udc_stop

2015-01-12 Thread Peter Chen
UDC core has already done it before .udc_stop and after .udc_start. Signed-off-by: Peter Chen --- drivers/usb/gadget/udc/pxa25x_udc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c index 8550b2d..f6cbe66 100644 ---

[PATCH 3/3] usb: udc: mv_udc_core: delete pullup operation at .udc_start

2015-01-12 Thread Peter Chen
UDC core has already done it after .udc_start. Signed-off-by: Peter Chen --- drivers/usb/gadget/udc/mv_udc_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index 253f3df..d32160d 100644 --- a/drivers/usb/gad

Re: [PATCH v3 00/30] usb: updates for dwc2 gadget driver

2015-01-12 Thread Robert Baldyga
On 01/09/2015 01:38 PM, Mian Yousaf Kaukab wrote: > Hi, > This patchset consists of various bug fixes and feature enhancements for the > dwc2 gadget driver. All the patches are verified on dwc2 v3.0a with dedicated > fifos. Main focus of testing was with dma enabled. Although basic testing > withou

Re: [PATCH v4 4/4] can: kvaser_usb: Retry first bulk transfer on -ETIMEDOUT

2015-01-12 Thread Ahmed S. Darwish
On Sun, Jan 11, 2015 at 09:51:10PM +0100, Marc Kleine-Budde wrote: > On 01/11/2015 09:45 PM, Ahmed S. Darwish wrote: > > From: Ahmed S. Darwish > > > > (This is a draft patch, I'm not sure if this fixes the USB > > bug or only its psymptom. Feedback from the linux-usb folks > > is really apprecia

Re: [PATCH v4 4/4] can: kvaser_usb: Retry first bulk transfer on -ETIMEDOUT

2015-01-12 Thread Marc Kleine-Budde
On 01/12/2015 11:14 AM, Ahmed S. Darwish wrote: > On Sun, Jan 11, 2015 at 09:51:10PM +0100, Marc Kleine-Budde wrote: >> On 01/11/2015 09:45 PM, Ahmed S. Darwish wrote: >>> From: Ahmed S. Darwish >>> >>> (This is a draft patch, I'm not sure if this fixes the USB >>> bug or only its psymptom. Feedba

[PATCH v3 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling

2015-01-12 Thread Boris Brezillon
at91sam9rl SoC has an erratum forcing us to toggle the BIAS on USB suspend/resume events. This specific handling is only activated when CONFIG_ARCH_AT91SAM9RL is set and this option is only set when building a non-DT kernel, which is problematic since non-DT support for at91sam9rl SoC has been rem

[PATCH v3 4/5] usb: atmel_usba_udc: Mask status with enabled irqs

2015-01-12 Thread Boris Brezillon
Avoid interpreting useless status flags when we're not waiting for such events by masking the status variable with the interrupt enabled register value. Reported-by: Patrice VILCHEZ Signed-off-by: Boris Brezillon Acked-by: Alexandre Belloni --- drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +

[PATCH v3 5/5] usb: gadget: atmel_usba: Cache INT_ENB register value

2015-01-12 Thread Boris Brezillon
Cache INT_ENB register value in order to avoid uncached iomem access, and thus improve access time to INT_ENB value. Signed-off-by: Boris Brezillon Acked-by: Alexandre Belloni --- drivers/usb/gadget/udc/atmel_usba_udc.c | 52 ++--- drivers/usb/gadget/udc/atmel_usba_u

[PATCH v3 0/5] usb: atmel_usba_udc: Rework errata handling

2015-01-12 Thread Boris Brezillon
Hello, Here is a set of patches porting existing at91sam9rl erratum handling to DT and adding new code to handle at91sam9g45/9x5 erratum. It also adds several compatible strings to differentiate those errata. These patches should be backported to 3.17 and 3.18 stable releases but they do not appl

[PATCH v3 2/5] usb: atmel_usba_udc: Add at91sam9g45 and at91sam9x5 errata handling

2015-01-12 Thread Boris Brezillon
at91sam9g45 and at91sam9x5 SoCs have an hardware bug forcing us to generate a pulse on the BIAS signal on "USB end of reset" and "USB end of resume" events. Reported-by: Patrice VILCHEZ Signed-off-by: Boris Brezillon Acked-by: Alexandre Belloni --- drivers/usb/gadget/udc/atmel_usba_udc.c | 28

[PATCH v3 3/5] ARM: at91/dt: update udc compatible strings

2015-01-12 Thread Boris Brezillon
at91sam9g45, at91sam9x5 and sama5 SoCs should not use "atmel,at91sam9rl-udc" for their USB device compatible property since this compatible is attached to a specific hardware bug fix. Signed-off-by: Boris Brezillon Acked-by: Alexandre Belloni --- arch/arm/boot/dts/at91sam9g45.dtsi | 2 +- arch/

Re: [PATCH 0/3] usb: udc: cleanup pullup operation

2015-01-12 Thread Alexander Shishkin
Peter Chen writes: > This patch set cleans up udc drivers which define .pullup API, but > still call pullup operation at .udc_start or .udc_stop. In fact, > the related pullup operations are covered by udc core. Oh, this driver is still around? Are we going to obsolete it with chipidea someday?

Re: [PATCH v3 0/5] usb: atmel_usba_udc: Rework errata handling

2015-01-12 Thread Nicolas Ferre
Le 12/01/2015 11:57, Boris Brezillon a écrit : > Hello, > > Here is a set of patches porting existing at91sam9rl erratum handling to > DT and adding new code to handle at91sam9g45/9x5 erratum. > It also adds several compatible strings to differentiate those errata. > > These patches should be bac

Re: [PATCH 1/2] usb: udc: add usb_udc_vbus_handler

2015-01-12 Thread Alexander Shishkin
Peter Chen writes: > + mutex_lock(&udc_lock); > + list_for_each_entry(udc, &udc_list, list) > + if (udc->gadget == gadget) > + goto found; > + mutex_unlock(&udc_lock); Not entirely specific to this patchset, but this search pattern is copied verbatim i

RE: [PATCH v3 00/30] usb: updates for dwc2 gadget driver

2015-01-12 Thread Kaukab, Yousaf
Hi Robert, > -Original Message- > From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Monday, January 12, 2015 11:00 AM > To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com > Cc: Herrero, Gregory; pa...@synopsys.com; > sergei.shtyl...@cogentembedded.com; dingu...@opensourc

Re: [PATCH v3 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling

2015-01-12 Thread Paul Bolle
On Mon, 2015-01-12 at 11:57 +0100, Boris Brezillon wrote: > at91sam9rl SoC has an erratum forcing us to toggle the BIAS on USB > suspend/resume events. > > This specific handling is only activated when CONFIG_ARCH_AT91SAM9RL is > set and this option is only set when building a non-DT kernel, which

[PATCH 3/3] usb: dwc3: pci: code cleanup

2015-01-12 Thread Heikki Krogerus
Removing a few items that are not needed anymore and adding separate function for quirks. Signed-off-by: Heikki Krogerus Cc: Huang Rui --- drivers/usb/dwc3/dwc3-pci.c | 96 - 1 file changed, 42 insertions(+), 54 deletions(-) diff --git a/drivers/usb/

[PATCH 0/3] usb: dwc3: pci: cleanup

2015-01-12 Thread Heikki Krogerus
Heikki Krogerus (3): usb: dwc3: pci: remove registration of NOP PHYs usb: dwc3: pci: rely on default PM callbacks from PCI driver utility usb: dwc3: pci: code cleanup drivers/usb/dwc3/dwc3-pci.c | 178 1 file changed, 32 insertions(+), 146 delet

[PATCH 2/3] usb: dwc3: pci: rely on default PM callbacks from PCI driver utility

2015-01-12 Thread Heikki Krogerus
There is nothing specific being done in the suspend and resume callbacks that is not already taken care of in PCI driver core, so dropping the functions. Signed-off-by: Heikki Krogerus --- drivers/usb/dwc3/dwc3-pci.c | 34 -- 1 file changed, 34 deletions(-) diff

[PATCH 1/3] usb: dwc3: pci: remove registration of NOP PHYs

2015-01-12 Thread Heikki Krogerus
None of the PCI platforms need the NOP transceivers, and since we can now live without the PHYs, removing registration of the platform devices for them. Signed-off-by: Heikki Krogerus --- drivers/usb/dwc3/dwc3-pci.c | 68 - 1 file changed, 68 deletions

[PATCH] uas: Add no-report-opcodes quirk for Simpletech devices with id 4971:8017

2015-01-12 Thread Hans de Goede
Like some other uas devices these devices hang when a report-opcodes scsi command is send to them. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1124119 Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede --- drivers/usb/storage/unusual_uas.h | 7 +++ 1 file changed, 7 inse

Re: [PATCH] usb/kaweth: use GFP_ATOMIC under spin_lock in usb_start_wait_urb()

2015-01-12 Thread Oliver Neukum
On Sat, 2015-01-10 at 02:16 +0300, Alexey Khoroshilov wrote: > Commit e4c7f259c5be ("USB: kaweth.c: use GFP_ATOMIC under spin_lock") > makes sure that kaweth_internal_control_msg() allocates memory with > GFP_ATOMIC, > but kaweth_internal_control_msg() also calls usb_start_wait_urb() > that still a

Re: [PATCH v3 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling

2015-01-12 Thread Boris Brezillon
Hi Paul, On Mon, 12 Jan 2015 13:15:58 +0100 Paul Bolle wrote: > On Mon, 2015-01-12 at 11:57 +0100, Boris Brezillon wrote: > > at91sam9rl SoC has an erratum forcing us to toggle the BIAS on USB > > suspend/resume events. > > > > This specific handling is only activated when CONFIG_ARCH_AT91SAM9R

Re: [PATCH v3 00/30] usb: updates for dwc2 gadget driver

2015-01-12 Thread Robert Baldyga
On 01/12/2015 01:03 PM, Kaukab, Yousaf wrote: > Hi Robert, > >> -Original Message- >> From: Robert Baldyga [mailto:r.bald...@samsung.com] >> Sent: Monday, January 12, 2015 11:00 AM >> To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com >> Cc: Herrero, Gregory; pa...@synopsys.com; >

[PATCH v4 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling

2015-01-12 Thread Boris Brezillon
at91sam9rl SoC has an erratum forcing us to toggle the BIAS on USB suspend/resume events. This specific handling was only activated when CONFIG_ARCH_AT91SAM9RL was set, but commit bcf8c7e7703b ("ARM: at91: remove at91sam9rl legacy board support") removed this option. Rework the toggle_bias implem

Re: [PATCH v4 4/4] can: kvaser_usb: Retry first bulk transfer on -ETIMEDOUT

2015-01-12 Thread Olivier Sobrie
Hello, On Mon, Jan 12, 2015 at 05:14:07AM -0500, Ahmed S. Darwish wrote: > On Sun, Jan 11, 2015 at 09:51:10PM +0100, Marc Kleine-Budde wrote: > > On 01/11/2015 09:45 PM, Ahmed S. Darwish wrote: > > > From: Ahmed S. Darwish > > > > > > (This is a draft patch, I'm not sure if this fixes the USB >

Re: [PATCH v4 4/4] can: kvaser_usb: Retry first bulk transfer on -ETIMEDOUT

2015-01-12 Thread Ahmed S. Darwish
On Mon, Jan 12, 2015 at 02:33:30PM +0100, Olivier Sobrie wrote: > Hello, > > On Mon, Jan 12, 2015 at 05:14:07AM -0500, Ahmed S. Darwish wrote: > > On Sun, Jan 11, 2015 at 09:51:10PM +0100, Marc Kleine-Budde wrote: > > > On 01/11/2015 09:45 PM, Ahmed S. Darwish wrote: > > > > From: Ahmed S. Darwish

[PATCH resend v3] USB: host: Introduce flag to enable use of 64-bit dma_mask for ehci-platform

2015-01-12 Thread Andreas Herrmann
ehci-octeon driver used a 64-bit dma_mask. With removal of ehci-octeon and usage of ehci-platform ehci dma_mask is now limited to 32 bits (coerced in ehci_platform_probe). Provide a flag in ehci platform data to allow use of 64 bits for dma_mask. Cc: David Daney Cc: Alex Smith Signed-off-by: A

Re: [PATCH 0/3] usb: dwc3: pci: cleanup

2015-01-12 Thread Felipe Balbi
Hi Huang, On Mon, Jan 12, 2015 at 02:20:11PM +0200, Heikki Krogerus wrote: > > Heikki Krogerus (3): > usb: dwc3: pci: remove registration of NOP PHYs > usb: dwc3: pci: rely on default PM callbacks from PCI driver utility > usb: dwc3: pci: code cleanup Can you test this series from Heikki a

Re: [PATCH] usb-storage/SCSI: blacklist FUA on JMicron 152d:2566 USB-SATA controller

2015-01-12 Thread Dmitry Nezhevenko
It looks like FUA support is broken on JMicron 152d:2566 bridge: [223159.885704] sd 7:0:0:0: [sdc] Write Protect is off [223159.885706] sd 7:0:0:0: [sdc] Mode Sense: 47 00 10 08 [223159.885942] sd 7:0:0:0: [sdc] Write cache: enabled, read cache: enabled, supports DPO and FUA [223283.691677] sd 7

Re: [PATCH 3/3] usb: dwc3: add a quirk for device disconnection issue in Synopsis dwc3 core

2015-01-12 Thread Felipe Balbi
Hi, On Sun, Jan 11, 2015 at 11:19:55PM +0800, Sneeker Yeh wrote: > > > > enable the quirk only for you. Isn't there a better way of enabling the > > > > quirk based off of revision detection couple with a look on GHWPARAMS* > > > > registers ? > > > > > > > > What's tricking me is this claim that

Re: [PATCH 3/3] usb: dwc3: add a quirk for device disconnection issue in Synopsis dwc3 core

2015-01-12 Thread Paul Bolle
On Mon, 2015-01-12 at 11:20 -0600, Felipe Balbi wrote: > On Sun, Jan 11, 2015 at 11:19:55PM +0800, Sneeker Yeh wrote: > > in case i express unclearly i also put a pdf: > > https://drive.google.com/file/d/0B18MmcvvKjNNbDF6eEdHSzZCazA/view > > > > This issue is defined by a two-way race at disconnec

Re: [PATCH 3/3] usb: dwc3: add a quirk for device disconnection issue in Synopsis dwc3 core

2015-01-12 Thread Felipe Balbi
On Mon, Jan 12, 2015 at 06:29:43PM +0100, Paul Bolle wrote: > On Mon, 2015-01-12 at 11:20 -0600, Felipe Balbi wrote: > > On Sun, Jan 11, 2015 at 11:19:55PM +0800, Sneeker Yeh wrote: > > > in case i express unclearly i also put a pdf: > > > https://drive.google.com/file/d/0B18MmcvvKjNNbDF6eEdHSzZCaz

[GIT PULL] USB fixes for v3.19-rc5

2015-01-12 Thread Felipe Balbi
Hi Greg, Looks like this will be my last pull request for v3.19. Please consider merging on top of your usb-linus branch. Note that there will be a conflict when merging on that branch, the solution is to use the version from my tree as that's more correct. Here's how the related code should look

Re: [PATCH 1/2] usb: udc: add usb_udc_vbus_handler

2015-01-12 Thread Felipe Balbi
On Mon, Jan 12, 2015 at 01:55:28PM +0200, Alexander Shishkin wrote: > Peter Chen writes: > > > + mutex_lock(&udc_lock); > > + list_for_each_entry(udc, &udc_list, list) > > + if (udc->gadget == gadget) > > + goto found; > > + mutex_unlock(&udc_lock); > > Not enti

Re: [PATCH 0/3] usb: udc: cleanup pullup operation

2015-01-12 Thread Felipe Balbi
On Mon, Jan 12, 2015 at 01:01:49PM +0200, Alexander Shishkin wrote: > Peter Chen writes: > > > This patch set cleans up udc drivers which define .pullup API, but > > still call pullup operation at .udc_start or .udc_stop. In fact, > > the related pullup operations are covered by udc core. > > Oh

Re: [PATCH v3 3/5] ARM: at91/dt: update udc compatible strings

2015-01-12 Thread Felipe Balbi
On Mon, Jan 12, 2015 at 11:57:56AM +0100, Boris Brezillon wrote: > at91sam9g45, at91sam9x5 and sama5 SoCs should not use > "atmel,at91sam9rl-udc" for their USB device compatible property since > this compatible is attached to a specific hardware bug fix. > > Signed-off-by: Boris Brezillon > Acked

Re: [PATCH 2/4] usb: dwc3: gadget: Stop TRB preparation after limit is reached

2015-01-12 Thread Felipe Balbi
Hi, On Tue, Jan 06, 2015 at 11:44:23AM +0530, Amit Virdi wrote: > I can certainly provide the dwc3 specific kernel bootup logs, full > regdump and any loglevel you want me to, if that helps > >>> > >>>Yeah, if you can provide those, then that'll help me verifying. Full > >>>logs from boot

Re: [GIT PULL] USB fixes for v3.19-rc5

2015-01-12 Thread Greg KH
On Mon, Jan 12, 2015 at 12:07:20PM -0600, Felipe Balbi wrote: > Hi Greg, > > Looks like this will be my last pull request for v3.19. Please consider > merging > on top of your usb-linus branch. > > Note that there will be a conflict when merging on that branch, the solution > is > to use the ve

Re: [PATCH v3 3/5] ARM: at91/dt: update udc compatible strings

2015-01-12 Thread Boris Brezillon
Hi Felipe, On Mon, 12 Jan 2015 12:23:49 -0600 Felipe Balbi wrote: > On Mon, Jan 12, 2015 at 11:57:56AM +0100, Boris Brezillon wrote: > > at91sam9g45, at91sam9x5 and sama5 SoCs should not use > > "atmel,at91sam9rl-udc" for their USB device compatible property since > > this compatible is attached

Re: [PATCH v3 3/5] ARM: at91/dt: update udc compatible strings

2015-01-12 Thread Felipe Balbi
On Mon, Jan 12, 2015 at 08:18:16PM +0100, Boris Brezillon wrote: > Hi Felipe, > > On Mon, 12 Jan 2015 12:23:49 -0600 > Felipe Balbi wrote: > > > On Mon, Jan 12, 2015 at 11:57:56AM +0100, Boris Brezillon wrote: > > > at91sam9g45, at91sam9x5 and sama5 SoCs should not use > > > "atmel,at91sam9rl-ud

Re: [PATCH v3 3/5] ARM: at91/dt: update udc compatible strings

2015-01-12 Thread Boris Brezillon
On Mon, 12 Jan 2015 13:31:26 -0600 Felipe Balbi wrote: > On Mon, Jan 12, 2015 at 08:18:16PM +0100, Boris Brezillon wrote: > > Hi Felipe, > > > > On Mon, 12 Jan 2015 12:23:49 -0600 > > Felipe Balbi wrote: > > > > > On Mon, Jan 12, 2015 at 11:57:56AM +0100, Boris Brezillon wrote: > > > > at91sam

Re: [PATCH net-next v2 0/2 RESEND] r8152: adjust r8152_submit_rx

2015-01-12 Thread David Miller
From: Hayes Wang Date: Fri, 9 Jan 2015 10:26:34 +0800 > v2: > Replace the patch #1 with "call rtl_start_rx after netif_carrier_on". > > For patch #2, replace checking tp->speed with netif_carrier_ok. > > v1: > Avoid r8152_submit_rx() from submitting rx during unexpected > moment. This could red

RE: [PATCH v3 00/30] usb: updates for dwc2 gadget driver

2015-01-12 Thread Paul Zimmerman
> From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] > Sent: Friday, January 09, 2015 4:39 AM > > Hi, > This patchset consists of various bug fixes and feature enhancements for the > dwc2 gadget driver. All the patches are verified on dwc2 v3.0a with dedicated > fifos. Main focus of testing

Re: [PATCH v3 00/30] usb: updates for dwc2 gadget driver

2015-01-12 Thread Felipe Balbi
Hi, On Mon, Jan 12, 2015 at 09:20:15PM +, Paul Zimmerman wrote: > > From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] > > Sent: Friday, January 09, 2015 4:39 AM > > > > Hi, > > This patchset consists of various bug fixes and feature enhancements for the > > dwc2 gadget driver. All the

RE: dwc2: problems with IN requests completion in linux-next

2015-01-12 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Monday, December 22, 2014 6:13 AM > > I have recently noticed problem with DWC2 driver in latest linux-next. I > use it in gadget only mode at Samsung platform (Odroid U3) but I believe > the bug can be reproduced at another platforms.

Re: [PATCH 05/11] usb: gadget: at91_udc: Remove non-DT handling code

2015-01-12 Thread Felipe Balbi
On Wed, Dec 03, 2014 at 12:32:04PM +0100, Boris Brezillon wrote: > Since non-DT board support has been removed from the at91 architecture we > can safely remove non-DT handling code. > > Signed-off-by: Boris Brezillon doesn't apply cleanly: checking file drivers/usb/gadget/udc/Kconfig checking

Re: [PATCH] usb/kaweth: use GFP_ATOMIC under spin_lock in usb_start_wait_urb()

2015-01-12 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 10 Jan 2015 02:16:22 +0300 > Commit e4c7f259c5be ("USB: kaweth.c: use GFP_ATOMIC under spin_lock") > makes sure that kaweth_internal_control_msg() allocates memory with > GFP_ATOMIC, > but kaweth_internal_control_msg() also calls usb_start_wait_urb() > that st

Re: [PATCH 2/3] usb: gadget: uac1: struct gaudio is useless for struct f_uac1_opts

2015-01-12 Thread Felipe Balbi
Hi, On Fri, Jan 09, 2015 at 03:09:09PM +0800, Peter Chen wrote: > On Mon, Dec 1, 2014 at 4:09 PM, Peter Chen wrote: > > Since we call gaudio_cleanup at f_audio_free, the f_uac1_opts > > doesn't need to use gaudio any more. > > > > Signed-off-by: Peter Chen > > --- > > drivers/usb/gadget/functio

Re: [PATCH v2 2/3] usb: phy: add lubbock phy driver

2015-01-12 Thread Felipe Balbi
On Sun, Jan 11, 2015 at 10:44:59PM +0400, Dmitry Eremin-Solenikov wrote: > Hello, > > 2015-01-08 19:58 GMT+03:00 Felipe Balbi : > > On Sun, Nov 30, 2014 at 01:02:04AM +0300, Dmitry Eremin-Solenikov wrote: > >> Extract lubbock-specific code from pxa25x_udc driver. As a bonus, phy > >> driver determ

Re: [PATCH 05/11] usb: gadget: at91_udc: Remove non-DT handling code

2015-01-12 Thread Alexandre Belloni
Hi Felipe, I've rebased that patch series but it depends on another one (the mfd: syscon: part of "memory: add Atmel EBI (External Bus Interface) driver") that is not taken yet so applying it now will break the build. I still hope to get it merged for 3.20 and I'll resend it as soon as possible.

New maintainer for dwc2

2015-01-12 Thread Paul Zimmerman
Hi everyone, I will be leaving Synopsys on Friday, Jan 16th, so the dwc2 driver will need a new maintainer. I am recommending John Youn as the new maintainer. On the plus side, John has quite a bit of experience with the dwc2 controller, and has previous experience submitting kernel patches (fo

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-12 Thread Paul Zimmerman
> From: Paul Zimmerman > Sent: Saturday, January 10, 2015 3:52 PM > > > From: Yunzhi Li [mailto:l...@rock-chips.com] > > Sent: Saturday, January 10, 2015 8:07 AM > > > > 在 2015/1/9 10:15, Paul Zimmerman 写道: > > >> [...] > > >> /* > > >> - * Attempt to find a generic PHY, then look

Re: New maintainer for dwc2

2015-01-12 Thread gre...@linuxfoundation.org
On Mon, Jan 12, 2015 at 11:14:54PM +, Paul Zimmerman wrote: > Hi everyone, > > I will be leaving Synopsys on Friday, Jan 16th, so the dwc2 driver > will need a new maintainer. > > I am recommending John Youn as the new > maintainer. > > On the plus side, John has quite a bit of experience w

RE: New maintainer for dwc2

2015-01-12 Thread Paul Zimmerman
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Monday, January 12, 2015 5:02 PM > > On Mon, Jan 12, 2015 at 11:14:54PM +, Paul Zimmerman wrote: > > Hi everyone, > > > > I will be leaving Synopsys on Friday, Jan 16th, so the dwc2 driver > > will need a new mainta

Re: [PATCH 0/3] usb: udc: cleanup pullup operation

2015-01-12 Thread Peter Chen
On Mon, Jan 12, 2015 at 01:01:49PM +0200, Alexander Shishkin wrote: > Peter Chen writes: > > > This patch set cleans up udc drivers which define .pullup API, but > > still call pullup operation at .udc_start or .udc_stop. In fact, > > the related pullup operations are covered by udc core. > > Oh

Re: [PATCH v3 0/5] usb: atmel_usba_udc: Rework errata handling

2015-01-12 Thread Bo Shen
Hi Boris, On 01/12/2015 06:57 PM, Boris Brezillon wrote: Hello, Here is a set of patches porting existing at91sam9rl erratum handling to DT and adding new code to handle at91sam9g45/9x5 erratum. It also adds several compatible strings to differentiate those errata. These patches should be back

Re: New maintainer for dwc2

2015-01-12 Thread Felipe Balbi
On Tue, Jan 13, 2015 at 01:17:48AM +, Paul Zimmerman wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Monday, January 12, 2015 5:02 PM > > > > On Mon, Jan 12, 2015 at 11:14:54PM +, Paul Zimmerman wrote: > > > Hi everyone, > > > > > > I will be leavi

Re: [PATCH 2/4] usb: dwc3: gadget: Stop TRB preparation after limit is reached

2015-01-12 Thread Amit Virdi
On 1/13/2015 12:04 AM, Felipe Balbi wrote: Hi, On Tue, Jan 06, 2015 at 11:44:23AM +0530, Amit Virdi wrote: I can certainly provide the dwc3 specific kernel bootup logs, full regdump and any loglevel you want me to, if that helps Yeah, if you can provide those, then that'll help me verifying.

Re: [PATCH v2 2/3] usb: phy: add lubbock phy driver

2015-01-12 Thread Kishon Vijay Abraham I
Hi, On Tuesday 13 January 2015 03:21 AM, Felipe Balbi wrote: > On Sun, Jan 11, 2015 at 10:44:59PM +0400, Dmitry Eremin-Solenikov wrote: >> Hello, >> >> 2015-01-08 19:58 GMT+03:00 Felipe Balbi : >>> On Sun, Nov 30, 2014 at 01:02:04AM +0300, Dmitry Eremin-Solenikov wrote: Extract lubbock-specif

Re: [PATCH 0/3] usb: dwc3: pci: cleanup

2015-01-12 Thread Huang Rui
Hi Felipe, On Mon, Jan 12, 2015 at 10:52:53AM -0600, Felipe Balbi wrote: > Hi Huang, > > On Mon, Jan 12, 2015 at 02:20:11PM +0200, Heikki Krogerus wrote: > > > > Heikki Krogerus (3): > > usb: dwc3: pci: remove registration of NOP PHYs > > usb: dwc3: pci: rely on default PM callbacks from PCI

Re: [PATCH 3/3] usb: dwc3: pci: code cleanup

2015-01-12 Thread Huang Rui
On Mon, Jan 12, 2015 at 02:20:14PM +0200, Heikki Krogerus wrote: > Removing a few items that are not needed anymore and > adding separate function for quirks. > > Signed-off-by: Heikki Krogerus > Cc: Huang Rui Looks good for me. Acked-by: Huang Rui Thanks, Rui > --- > drivers/usb/dwc3/dwc3

[PATCH 1/4] usb: gadget: u_uac1: fix build issue

2015-01-12 Thread Huang Rui
Since gaudio member is removed at f_uac1_opts, it also needs to remove the cleanup call of gaudio member at f_uac1_opts when the usb function instance is freed. See below error message: CC [M] drivers/gpu/drm/nouveau/core/subdev/vm/nv50.o CC [M] drivers/staging/lustre/lnet/selftest/module.o

[PATCH RESEND 1/2] usb: dwc3: gadget: Fix TRB preparation during SG

2015-01-12 Thread Amit Virdi
When scatter gather (SG) is used, multiple TRBs are prepared from one DWC3 request (dwc3_request). So while preparing TRBs, the 'last' flag should be set only when it is the last TRB being prepared from the last dwc3_request entry. The current implementation uses list_is_last to check if the dwc3_

[PATCH RESEND 0/2] usb: dwc3: gadget: Bug fixes

2015-01-12 Thread Amit Virdi
This is a re-submission of patches [1/4] and [2/4] from: http://www.spinics.net/lists/linux-usb/msg118841.html Commit log of both these patches has been modified for aided clarity. These patches have been rebased on Balbi's testing/next. Patches [3/4] and [4/4] were accepted as they were.

[PATCH RESEND 2/2] usb: dwc3: gadget: Stop TRB preparation after limit is reached

2015-01-12 Thread Amit Virdi
DWC3 gadget sets up a pool of 32 TRBs for each EP during initialization. This means, the max TRBs that can be submitted for an EP is fixed to 32. Since the request queue for an EP is a linked list, any number of requests can be queued to it by the gadget layer. However, the dwc3 driver must not su

RE: [PATCH 1/4] usb: gadget: u_uac1: fix build issue

2015-01-12 Thread Peter Chen
> See below error message: > CC [M] drivers/gpu/drm/nouveau/core/subdev/vm/nv50.o > CC [M] drivers/staging/lustre/lnet/selftest/module.o > drivers/usb/gadget/function/f_uac1.c: In function ‘f_audio_free_inst’: > drivers/usb/gadget/function/f_uac1.c:904:21: error: ‘struct f_uac1_opts’ has >

Re: USB HID Gadget Support for Intel Edison

2015-01-12 Thread Chris McClimans
The upstream sources for platform/intel-mid aren't in any public git repos and are distributed as a tarball. I have been unable to find any platform/intel-mid specific mailing lists, so I created my own repos and tickets to track my progress. I haven't done much work in the kernel, but I'm trying

Re: [PATCH 1/4] usb: gadget: u_uac1: fix build issue

2015-01-12 Thread Huang Rui
On Tue, Jan 13, 2015 at 06:51:40AM +, Peter Chen wrote: > > > See below error message: > > CC [M] drivers/gpu/drm/nouveau/core/subdev/vm/nv50.o > > CC [M] drivers/staging/lustre/lnet/selftest/module.o > > drivers/usb/gadget/function/f_uac1.c: In function ‘f_audio_free_inst’: > > drivers