On 12/18/2014 11:39 AM, Peter Chen wrote:
> On Thu, Dec 18, 2014 at 12:25:41PM +0530, Sanchayan Maity wrote:
>> On 12/18/2014 10:24 AM, Peter Chen wrote:
>>> On Wed, Dec 17, 2014 at 10:04:35AM +0530, Sanchayan Maity wrote:
On 12/17/2014 05:46 AM, Peter Chen wrote:
> On Tue, Dec 16, 2014 at
Hi,
we use gadget driver gadgetfs and implement a high-level protocol over USB.
Our hardware provides an USB WCID device [1]. But the recent state of gadgetfs
is unclear. There are a couple of problems and gadgetfs does not support USB3
SuperSpeed. I guess the driver will be removed from kernel. I
On Wed, Dec 17, 2014 at 09:34:48AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Dec 17, 2014 at 09:30:03AM +0100, Thierry Reding wrote:
> > On Thu, Dec 04, 2014 at 01:06:07PM +0100, Thierry Reding wrote:
> > > From: Thierry Reding
> > >
> > > Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_
Since we can compose gadgets from many functions, there is the problem
related to gadget breakage while FunctionFS daemon being closed. FFS
function is userspace code so there is no way to know when it will close
files (it doesn't matter what is the reason of this situation, it can
be daemon logic,
W dniu 18.12.2014 o 09:16, Mario Schuknecht pisze:
Hi,
we use gadget driver gadgetfs and implement a high-level protocol over USB.
Our hardware provides an USB WCID device [1]. But the recent state of gadgetfs
is unclear. There are a couple of problems and gadgetfs does not support USB3
SuperSpe
Hello.
On 12/18/2014 4:46 AM, yoshihiro shimoda wrote:
[...]
There is a typo ("prove" instead of "probe") in the error message printed when
the platform initialization fails. Replace that word with more fitting "init".
Signed-off-by: Sergei Shtylyov
this actually goes through me, I'll t
Mathias /Guys,
I got the debug log of the xhci_hcd module, during the communication
with the robot kit (Lego brick).
Attached are two files:
brick-boot.log:
The brick is connected to USB port, and press switch ON button.
upload.log:
The brick is already ON, and start the uploading of an applica
When I am checking usb remote wakeup code, I found that usb remote wakeup will
not work after system going to S3 sate and I confirmed with my PC.
During enumeration, usb device will be set as wakeup capable by
usb_set_device_state if it supports. Whether usb driver send
SET_FEATURE(REMOTE_WAKUP)
> >>> usb_gadget_unmap_request(&hwep->ci->gadget, &hwreq->req,
> >>> hwep->dir);
> >>>
> >>> hwreq->req.actual += actual;
> >>>
> >>
> >> Applied and tested the patch. Still the same condition.
> >
> > How about change condition like:
> >
> >>> + if (!hw_read(ci, OP_EN
Le Wed, 17 Dec 2014 20:40:29 +0800,
Peter Chen a écrit :
> On Wed, Dec 17, 2014 at 05:31:40PM +0530, Sanchayan Maity wrote:
> > On 12/17/2014 02:05 PM, Peter Chen wrote:
> > > Hi all,
> > >
> > > At the first two patches, I add identification registers APIs, we can get
> > > controller's revisio
Add PCI IDs for Intel Sunrise Point PCH.
Signed-off-by: Heikki Krogerus
---
drivers/usb/dwc3/dwc3-pci.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 7c4faf7..b642a2f 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/
On Thu, 18 Dec 2014, Udo van den Heuvel wrote:
> On 2014-12-17 18:25, Alan Stern wrote:
> > On Sat, 13 Dec 2014, Udo van den Heuvel wrote:
> > What are we supposed to see? The lsusb output in the bug report lists
> > a bunch of devices, but it's not clear which one is the airspy.
>
> I did not
On Thu, 18 Dec 2014, Udo van den Heuvel wrote:
> On 2014-12-17 18:25, Alan Stern wrote:
> >> Please let me know what info I should add to help find the root cause.
> >
> > What are we supposed to see? The lsusb output in the bug report lists
> > a bunch of devices, but it's not clear which one
Please tell your email client to wrap lines after 72 columns or so.
On Thu, 18 Dec 2014, Du, Changbin wrote:
> When I am checking usb remote wakeup code, I found that usb remote
> wakeup will not work after system going to S3 sate and I confirmed
> with my PC.
USB remote _does_ work.
> During e
On 2014-12-18 16:23, Alan Stern wrote:
>>> The bug report says there should be 10 M samples per second. How many
>>> bytes are in a sample? 2?
>>
>> I and Q samples are two bytes each.
>
> What is an I sample? What is a Q sample?
I and Q samples describe the radio signal received by the airs
On Thu, 18 Dec 2014, Udo van den Heuvel wrote:
> On 2014-12-18 16:23, Alan Stern wrote:
> >>> The bug report says there should be 10 M samples per second. How many
> >>> bytes are in a sample? 2?
> >>
> >> I and Q samples are two bytes each.
> >
> > What is an I sample? What is a Q sample?
>
Hi
On 18.12.2014 13:49, Gustavo Duarte wrote:
> Mathias /Guys,
>
> I got the debug log of the xhci_hcd module, during the communication
> with the robot kit (Lego brick).
>
> Attached are two files:
>
> brick-boot.log:
> The brick is connected to USB port, and press switch ON button.
>
> uploa
On 2014-12-18 17:10, Alan Stern wrote:
> On Thu, 18 Dec 2014, Udo van den Heuvel wrote:
>> In fact the airspy samples at 20 MSPS with 2 bytes per sample, but the
>> host converts that to the I/Q pairs at 10 MSPS, with 2 bytes for each I
>> and Q. (I was explained in #airspy)
>
> I don't know what
Le 17/12/2014 10:18, Bo Shen a écrit :
> According to the datasheet, when transfer using DMA, the control
> setting for IN packet only need END_BUF_EN, END_BUF_IE, CH_EN,
> while for OUT packet, need more two bits END_TR_EN and END_TR_IE
> to be configured.
>
> Signed-off-by: Bo Shen
Seems okay,
Le 17/12/2014 10:18, Bo Shen a écrit :
> When receive data, the RXRDY in status register set by hardware
> after a new packet has been stored in the endpoint FIFO. When it
> is copied from FIFO, this bit is cleared which make the FIFO can
> be accessed again.
>
> In the receive_data() function, th
While unplugging a Logitek Keyboard/mouse micro-receiver, I got the
lockdep splat below.
However, I don't fully understand this splat - I see nothing in
flush_work() nor process_one_work() making use of "intf->reset_ws" -
which seems to be a USB thing. I guess lockdep is being re-used to
validate
On Thu, 18 Dec 2014, Udo van den Heuvel wrote:
> > If the airspy sends 20 million samples per second to the host and each
> > sample is 2 bytes, then the host would have to receive 40 MB/s of data
> > from the airspy. As I mentioned before, the usbmon trace showed that
> > the actual transfer ra
Thanks Mathis for these suggestions, i'm going to try it, and let you
know the results.
i hope you have a nice rest.
Gustavo.
On Thu, Dec 18, 2014 at 2:12 PM, Mathias Nyman
wrote:
> Hi
>
> On 18.12.2014 13:49, Gustavo Duarte wrote:
>> Mathias /Guys,
>>
>> I got the debug log of the xhci_hcd mo
From: Gregory Herrero
Signed-off-by: Gregory Herrero
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 200168e..0b3c571 100644
--- a/drivers/u
When using DMA keep fifo empty interrupt disabled. Otherwise
core is flooded by interrupts.
Signed-off-by: Gregory Herrero
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/
When using DMA, data of the previous setup packet can be read back
from cache because ep0 and ctrl buffers are embedded in struct s3c_hsotg.
Allocate buffers instead of embeddeding them.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/core.h | 7 +--
drivers/usb/dwc2/gadget.c | 20
-20141218.
Thank you,
Best regards,
Yousaf
Gregory Herrero (13):
usb: dwc2: gadget: register gadget handle to the phy
usb: dwc2: gadget: write correct value in ahbcfg register
usb: dwc2: gadget: don't erase gahbcfg register when enabling dma
usb: dwc2: gadget: add device tree proper
When selecting different alt setting, s3c_hsotg_ep_enable can be
called with fifo already allocated. Allocate fifo again only if
required and after deallocating the previous fifo.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 13 -
1 file changed, 12 insertions(+)
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/core.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index 7c0b995..b5e50e7 100644
--- a/drivers/usb/dwc2/core.h
+++ b/drivers/usb/dwc2/core.h
@@ -158,14 +158,10 @@ struct s3c_hsotg_e
From: Gregory Herrero
As fifo size can vary between SOCs, add possibility to configure
them from device tree. Fifo sizes used by the legacy driver will
be used If they are not provided by the device tree.
Signed-off-by: Gregory Herrero
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/co
DOEPINTn.SetUp also indicates an OUT token for the data stage, so
instead use DOEPINTn.StupPktRcvd. Moreover, check
DOEPINTn.StupPktRcvd on DOEPINTn.XferComp as described in programming
guide.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 83 --
GHWCFG1 provides hardware configuration of each endpoint. Use
it to configure the endpoints instead of assuming all even
endpoint are OUT and all odd endpoints are IN.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/core.h | 3 +-
drivers/usb/dwc2/gadget.c | 324 ++
From: Gregory Herrero
* Add an of specific function to parse device node properties.
* Enable dma usage only if device tree property 'g_use_dma' is present.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/core.h | 2 ++
drivers/usb/dwc2/gadget.c | 26 --
2 files
From: Gregory Herrero
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 5de3a3a..0b08d4a 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadge
kill_all_requests() can flush the fifo. Call it after disabling the
endpoint. Moreover, remove even the current IN request so that next
IN request after s3c_hsotg_ep_enable can be properly handled.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 5 +++--
1 file changed, 3 inser
Manage ep0 state in software to add handling of status OUT stage.
Just toggling hsotg->setup in s3c_hsotg_handle_outdone leaves it in
wrong state in 2-stage control transfers.
Moreover, there is no need to handle SetupDone as requests can be
complete on XferCmpl of status stage.
Signed-off-by: Mia
< 15 check doesn't show debug information for endpoint 15.
It is possible to have less than 15 endpoints so use limit
provided by hardware configuration.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dr
From: Gregory Herrero
When booting with id pin grounded, dwc2 default to host mode.
Thus, force device mode prior initializing gadget part.
Else fifo init will fail since fifo values are not correct
in host mode.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/gadget.c | 16 +++
This flag is set before sending the zlp. So use present tense instead
of the past tense.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/core.h | 4 ++--
drivers/usb/dwc2/gadget.c | 8
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/dwc2/core.h b/driv
According to programming guide, zero length packet should be
programmed on its own and should not be counted in DIEPTSIZ.PktCnt
with other packets.
For ep0, this is the zlp for DATA IN stage (if required) and not for
the STATUS stage.
Signed-off-by: Gregory Herrero
Signed-off-by: Mian Yousaf Kau
Current code does not check endpoint 15 interrupt. Use number
of endpoint configured in hardware instead of the hardcoded value.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/d
From: Gregory Herrero
This callback informs the driver about the total amount of current it
is allowed to draw. Share this information with the phy so that
current limits can be set for charging for example.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/gadget.c | 17 +
1
From: Gregory Herrero
Can't stay in the loop forever. Break it after timeout.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/gadget.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index bf1b209..0261d6b 100644
--- a/drivers/usb/d
From: Gregory Herrero
Signed-off-by: Gregory Herrero
---
Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt
b/Documentation/devicetree/bindings/usb/dwc2.txt
index 5e9712f..6da4393 100644
--- a/Doc
If usb bus is reset without a physical disconnection, all endpoints
will remain open. Call s3c_hsotg_disconnect() from reset handler to
report a disconnect to gadget framework. hsotg->connected is checked
in s3c_hsotg_disconnect() before processing disconnect.
In some cases, USBRst is seen before
When matching tx fifo to endpoint, consider all fifos instead of
hard limiting to 8
Moreover, print error in case no fifo could be found.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gad
From: Gregory Herrero
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 0b08d4a..58699c3 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/g
The warning is probably good but it has false positives in both dma and non-dma
cases. So its not very helpful in either.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dw
From: Gregory Herrero
Enable phy driver to report vbus session. This allows us to remove
D+ pullup when vbus is not present.
Signed-off-by: Gregory Herrero
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 24
1 file changed, 24 insertions(+)
diff --g
Current algorithm picks the first fifo which is equal to or greater
than the required size. This can result in bigger fifos assigned to
endpoints with smaller maxps. Change the algorithm to pick the
smallest fifo which is greater than or equal to the required size.
Moreover, only use signed variab
From: Gregory Herrero
Indicate if gadget driver must use dma for usb transfers.
Signed-off-by: Gregory Herrero
---
Documentation/devicetree/bindings/usb/dwc2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt
b/Documentation/devicetree/bindi
From: Gregory Herrero
Gadget must be informed about disconnection when pullup is
removed.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/gadget.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index a77fb3e..f8e928e 100644
--- a/d
From: Gregory Herrero
After all endpoints are disabled, fifo_map should have reached 0.
Its a bug if if didn't, so warn about it and reset it to 0 so that
driver can continue using all the fifos.
Signed-off-by: Gregory Herrero
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c |
2 v3.0a with dedicated
> fifos. Main focus of testing was with dma enabled. Although basic testing
> without dma was also done.
>
> It is based on linux-next tag next-20141218.
>
> Thank you,
>
> Best regards,
> Yousaf
>
> Gregory Herrero (13):
> usb: dwc2: gadg
On Thu, 18 Dec 2014, Russell King - ARM Linux wrote:
> While unplugging a Logitek Keyboard/mouse micro-receiver, I got the
> lockdep splat below.
>
> However, I don't fully understand this splat - I see nothing in
> flush_work() nor process_one_work() making use of "intf->reset_ws" -
> which seem
On Thu, Dec 18, 2014 at 02:40:48PM -0500, Alan Stern wrote:
> On Thu, 18 Dec 2014, Russell King - ARM Linux wrote:
>
> > While unplugging a Logitek Keyboard/mouse micro-receiver, I got the
> > lockdep splat below.
> >
> > However, I don't fully understand this splat - I see nothing in
> > flush_w
Hello,
> -Original Message-
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
> Sent: Thursday, December 18, 2014 8:32 PM
>
> Hello.
>
> On 12/18/2014 4:46 AM, yoshihiro shimoda wrote:
>
> [...]
>
> > There is a typo ("prove" instead of "probe") in the error messa
From: Rafael J. Wysocki
Having switched over all of the users of CONFIG_PM_RUNTIME to use
CONFIG_PM directly, turn the latter into a user-selectable option
and drop the former entirely from the tree.
Signed-off-by: Rafael J. Wysocki
---
arch/arm/configs/ape6evm_defconfig |2 +-
arc
hi all:
For HW bug, we have to mdelay(100) in getting root hub port status.
But it suffer system performance.
(The place we need to add is like below)
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index 388cfd8..9a6b841 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers
On 12/18/2014 06:47 PM, Matthieu CASTET wrote:
> Le Wed, 17 Dec 2014 20:40:29 +0800,
> Peter Chen a écrit :
>
>> On Wed, Dec 17, 2014 at 05:31:40PM +0530, Sanchayan Maity wrote:
>>> On 12/17/2014 02:05 PM, Peter Chen wrote:
Hi all,
At the first two patches, I add identification reg
> >> On Wed, Dec 17, 2014 at 05:31:40PM +0530, Sanchayan Maity wrote:
> >>> On 12/17/2014 02:05 PM, Peter Chen wrote:
> Hi all,
>
> At the first two patches, I add identification registers APIs, we
> can get controller's revision by using this APIs. Since I don't
> have e
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, November 27, 2014 4:34 AM
[...]
> >> > Looks like a candidate for ndo_gso_check(), so that we do not drop, but
> >> > instead segment from netif_needs_gso()/validate_xmit_skb()
> >>
> >> You mean have the bridge implement the ndo
> On 12/18/2014 06:47 PM, Matthieu CASTET wrote:
> > Le Wed, 17 Dec 2014 20:40:29 +0800,
> > Peter Chen a écrit :
> >
> >> On Wed, Dec 17, 2014 at 05:31:40PM +0530, Sanchayan Maity wrote:
> >>> On 12/17/2014 02:05 PM, Peter Chen wrote:
> Hi all,
>
> At the first two patches, I add
> There's a simple solution: Call device_set_wakeup_enable() for the device!
> You can do this from the command line by:
>
> echo auto >/sys/bus/usb/devices/.../power/control
>
> where the "..." is the pathname for your device.
>
Yes, this can enable auto-suspend for usb device like a mous
The first two patches are bug fixes in TRB preparation when scatter gather is
used. The next two patches are basically trivial and part of code cleanup.
The patches are rebased on Balbi's testing/next branch.
Amit Virdi (4):
usb: dwc3: gadget: Fix TRB preparation during SG
usb: dwc3: gadget:
When scatter gather is used, multiple TRBs are prepared from one DWC3 request.
Hence, we must set the 'last' flag when the SG is last as well as the TRB is
last. The current implementation uses list_is_last to check if the dwc3_request
is the last request in the request_list.
This doesn't work whe
This field was introduced but never used. So, remove it.
Signed-off-by: Amit Virdi
---
drivers/usb/dwc3/core.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 4bb9aa696ede..0842aa80976f 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drive
dwc3_gadget_init_hw_endpoints calls dwc3_alloc_trb_pool only if epnum is not
equal to 0 or 1. Hence, rechecking it in the called function is redundant.
Signed-off-by: Amit Virdi
---
drivers/usb/dwc3/gadget.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/driver
When SG is used, there are two loops iterating to prepare TRBs:
- Outer loop over the request_list
- Inner loop over the SG list
The driver must stop preparing TRBs when the max TRBs have been prepared. The
code was missing break to get out of the outer loop.
Signed-off-by: Amit Virdi
---
dri
On 19 December 2014 at 03:03, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> Having switched over all of the users of CONFIG_PM_RUNTIME to use
> CONFIG_PM directly, turn the latter into a user-selectable option
> and drop the former entirely from the tree.
>
> Signed-off-by: Rafael J. Wys
70 matches
Mail list logo
