And...why in Windows we have this line?
0050 75 76 77 61 62 63 64 65 66 67 68 69 6e 63 6d 30 uvwabcdefghincm0
Is this just padding stuff before the "ncm0" string?
So in particular a simple line needs to be modified in practice in the driver,
or am I totally misguised?
Is our "offset" parameter
It's an ping packet. Windows pads it with 'abcdef...'.
Regards,
Kevin
On 11/28/2014 04:17 PM, Enrico Mioso wrote:
> And...why in Windows we have this line?
> 0050 75 76 77 61 62 63 64 65 66 67 68 69 6e 63 6d 30 uvwabcdefghincm0
> Is this just padding stuff before the "ncm0" string?
> So in par
The driver effectively uses the wNdpOutDivisor indirectly - see standard
cdc_ncm deriver as in kernel git tree, line 490.
On Fri, 28 Nov 2014, Kevin Zhu wrote:
==Date: Fri, 28 Nov 2014 07:24:49
==From: Kevin Zhu
==To: Alex Strizhevsky , Bjørn Mork ,
==Midge Shaojun Tan
==Cc: Enrico Mioso
As the remainder (wNdpOutPayloadRemainder) is overwritten by the
following lines, whose finally value is 0, I modified the code not to
change it. Let it remain 2. And now the capture shows the Ethernet
header offset is the same as windows, however, it's not working yet.
/* adjust TX-remainder
Bj-rn, you where right.
I was thinking this was the classic compulsory switch from a bitness to an
higher one.
Sorry.
On Fri, 28 Nov 2014, Kevin Zhu wrote:
==Date: Fri, 28 Nov 2014 09:23:16
==From: Kevin Zhu
==To: Enrico Mioso
==Cc: Alex Strizhevsky , Bjørn Mork ,
==Midge Shaojun Tan ,
=
But you are still in 16-bit mode, right?
Have you tried by chance in 32-bit mode? I am convinced this is not the problem
... but, justi n case?
thank you Kevin for your work - and sorry for being not so helpful...
On Fri, 28 Nov 2014, Kevin Zhu wrote:
==Date: Fri, 28 Nov 2014 09:37:30
==From: K
To test our 32-bit driver, you need at least Ubuntu 14.04 and install the 3.16
kernel; or install a kernel >= 3.16 anyway, as our modification is based on the
cdc_ncm.c file from the git tree for logical reason.
On Fri, 28 Nov 2014, Kevin Zhu wrote:
==Date: Fri, 28 Nov 2014 09:37:30
==From: Ke
No. I also tried the 32bit version. The result is the same.
Regards,
Kevin
On 11/28/2014 04:42 PM, Enrico Mioso wrote:
> But you are still in 16-bit mode, right?
> Have you tried by chance in 32-bit mode? I am convinced this is not the
> problem
> ... but, justi n case?
> thank you Kevin for you
You have been helping a lot. Thanks!
Regards,
Kevin
On 11/28/2014 04:42 PM, Enrico Mioso wrote:
> But you are still in 16-bit mode, right?
> Have you tried by chance in 32-bit mode? I am convinced this is not the
> problem
> ... but, justi n case?
> thank you Kevin for your work - and sorry for
This is an ARP packet from Linux 32bit driver. See if anyone can tell
any mistake.
6e 63 6d 68 10 00 a9 00 94 01 00 00 10 00 00 00 ncmh
0010 6e 63 6d 30 20 00 00 00 00 00 00 00 00 00 00 00 ncm0 ...
0020 6a 01 00 00 2a 00 00 00 00 00 00 00 00 00 00 00 j...*..
Sorry - resending message to all.
Is the MAC right? In my case it was, but ... you never know.
And - have you tried the promisc mode, just in case... don't know if this might
even be implementedi n the driver, think not, but...
I don't know what to think anymore.
this ARP packet seems the same as
Yes. The MACs are right. When I started Wireshark, promisc mode was set.
Regards,
Kevin
On 11/28/2014 05:17 PM, Enrico Mioso wrote:
> Sorry - resending message to all.
> Is the MAC right? In my case it was, but ... you never know.
> And - have you tried the promisc mode, just in case... don't kno
The only difference I can tell now is windows does not pack the NDP with
zeros, it just sends whatever the skb buffer has, except the alignment.
Regards,
Kevin
On 11/28/2014 05:17 PM, Enrico Mioso wrote:
> Sorry - resending message to all.
> Is the MAC right? In my case it was, but ... you never
Enrico Mioso writes:
> What I suspect, is that all this mess started when Huawei introduce new
> firmware releases that changed something in the IPV6 support.
> Bjorn - do you remember when a guy called Thomas reported us a problem about
> an
> LTE huawei modem that wasn't working with huawei_
... and what do you think regarding the last arp packet Kevin shared with us
after having changed the remainder fixed value.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/
On Wed, Nov 19, 2014 at 6:53 PM, Tony Lindgren wrote:
> * Enric Balletbo Serra [141119 03:14]:
>> 2014-11-18 16:42 GMT+01:00 Tony Lindgren :
>>
>> Checked again, and no luck. It's very weird because from the OTG point
>> of view, OTG is exactly the same between Beagleboard-XM and IGEPv2.
>>
>> Ca
On Fri, Nov 21, 2014 at 4:43 PM, Felipe Balbi wrote:
> On Sun, Nov 09, 2014 at 01:23:07PM +0100, Robert Jarzmik wrote:
>>
>> Change internal gpio handling from integer gpios into gpio
>> descriptors. This change only addresses the internal API and
>> device-tree/ACPI, while the legacy platform dat
On Mon, 2014-11-17 at 08:50 +0800, Peter Chen wrote:
> On Thu, Nov 13, 2014 at 05:59:47PM +0200, Andy Shevchenko wrote:
> > There is no message when PHY is not enabled, IRQ line can't be acquired, or
> > debugfs registration fails. This patch adds the messages.
> >
[]
> Yes, I find the probe doe
On Fri, 2014-11-14 at 09:09 -0600, Felipe Balbi wrote:
> On Fri, Nov 14, 2014 at 04:33:22PM +0200, Andy Shevchenko wrote:
> > Since PHY for Chipidea is optional (not all SoCs having PHY for Chipidea
> > should
> > be programmed), we register 'nop' PHY for platforms that does not have
>
> s/does n
On Mon, 2014-11-17 at 09:46 +0800, Peter Chen wrote:
> On Fri, Nov 14, 2014 at 04:33:22PM +0200, Andy Shevchenko wrote:
> > Since PHY for Chipidea is optional (not all SoCs having PHY for Chipidea
> > should
> > be programmed), we register 'nop' PHY for platforms that does not have
> > programmabl
On Mon, Nov 24, 2014 at 8:05 PM, Tony Lindgren wrote:
> This allows setting the correct fifo_mode when multiple
> MUSB glue layers are built-in.
>
> Cc: Fabio Baltieri
> Cc: Lee Jones
> Cc: Linus Walleij
> Cc: Apelete Seketeli
> Cc: Lars-Peter Clausen
> Signed-off-by: Tony Lindgren
Reviewe
On Mon, Nov 24, 2014 at 8:05 PM, Tony Lindgren wrote:
> This allows the endpoints to work when multiple MUSB glue
> layers are built in.
>
> Cc: Fabio Baltieri
> Cc: Lee Jones
> Cc: Linus Walleij
> Cc: Apelete Seketeli
> Cc: Lars-Peter Clausen
> Signed-off-by: Tony Lindgren
Acked-by: Linus
ASSERT_OUT_NAKING was only called by out_flush and was hidden behind a
ifdef.
This patch moves the inline function into out_flush and remove the
ifdef. The user can decide to print the debug message or not via dynamic
printk
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2
Some debug messages were not build due to unconditional #if 0.
These messages are very useful for debugging and the user can enable
them on demand via dynamic debug.
If they are not enabled the performance is not affected.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net22
Once the defect 7374 is patched, there is no reason the keep reading the
idx scratch register.
Cache the content of the scratch idx register on device flag.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 153 +--
drivers/usb/gad
Function resume_dma is not used, remove it.
The reason the compiler did not catch this dead code is the inline
modifier.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers
After fix superspeed dma_done was applied we can simplify the code by
removing the duplicated dma_done and letting the function check if there
are more completed dma transactions.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 5 ++---
1 file changed, 2 insertions(
The function is very simple, does not declare any variable and it is
called in the irq path.
The counterpart for net228x is already declared as inline.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
ep_stdrsp was only called by handle_stat0_irqs_superspeed and with
always the same flags.
Remove the function and replace the call by the code inside the
function, since it is very simple once the dead code is removed.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c
Do not duplicate the code for the else branch of the condition.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net228
We can use the same function for both families of chips and also remove
the ep_stop_dma() function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 23 ++-
1 file changed, 2 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2
Field is_halt is never used by any function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 6 +-
drivers/usb/gadget/udc/net2280.h | 1 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net
irqs_superspeed calls ep_stall instead of set/clear_halt, due to a
workaround for SS seqnum. Create a function with the workaround and
call set/clear_halt instead.
This way we can compare the code of super/normal speed and it is easier
to follow the code.
Signed-off-by: Ricardo Ribalda Delgado
-
restart_dma is not used before it is declaration. Therefore we can
remove this definition.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index 03
Remove dma_started field from net2280_ep structure, since it is not used
by any function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 4
drivers/usb/gadget/udc/net2280.h | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/usb/gadge
use_dma parameter was designed to enable the dma on the chip. It was
enabled by default.
It comes from the time when the dma was not reliable. Now it has been
working ok in production.
This patch removes this parameter.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.
use_dma_chaining module parameter was designed to avoid creating one irq
per package on a group of packages (with the help of the driver's flag
no_interrupt).
Unfortunately, when this parameter is enabled, the driver fails to work
on both net2280 and 3380 chips.
This patch removes this parameter,
Parameter use_msi was used to enable msi irq on usb338x chips, it was
enabled by default.
There is no reason to prefer non-msi irq on usb338x, and it falls back
to non msi on error.
Therefore remove this option.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 6 ++
This patch removes the full_speed parameter used force full-speed
operation.
It was designed exclusively for testing purposes, and there is no
reason to maintain this in a production kernel.
Reverts: 2f0760774711c957c395b31131b848043af98edf
Suggested-by: Alan Stern
Signed-off-by: Ricardo Ribalda
This set of patches removes broken parameter use_dma_chaining, and the
unneeded full_speed,use_dma and use_msi.
Then does some code cleanout by removing duplicated and dead code.
Finally it removes the unconditional removed debug messages, since
they can be enabled by the user via dynamic printk.
Summary of how to test ECM function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 34 ++
1 file changed, 34 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
in
This series adds a documentation file whith a summary of how to do basic
testing of functions provided by USB gadgets.
@Greg: Felipe's tree is closed, so can you consider this series for 3.19?
It does not add any code. It documents what is already in your tree.
It is mostly a compilation of inform
Summary of how to test FFS (FunctionFS) function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 24
1 file changed, 24 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
Summary of how to test RNDIS function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 36
1 file changed, 36 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.tx
Summary of how to test EEM function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 34 ++
1 file changed, 34 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
in
Summary of how to test PHONET function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 64
1 file changed, 64 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.t
Summary of how to test MIDI function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 84
1 file changed, 84 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
Summary of how to test MASS STORAGE function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 54
1 file changed, 54 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-tes
Summary of how to test ECM subset function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 34 ++
1 file changed, 34 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing
The newly added file will be used to provide descriptions of how to test
the functions of USB gadgets.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 34 ++
1 file changed, 34 insertions(+)
create mode 100644 Documentation/usb/gad
Summary of how to test UAC1 function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 27 +++
1 file changed, 27 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
index 6e
Summary of how to test SOURCESINK function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 27 +++
1 file changed, 27 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
in
Summary of how to test SERIAL function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 30 ++
1 file changed, 30 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
ind
Summary of how to test HID function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 47
1 file changed, 47 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
Summary of how to test NCM function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 34 ++
1 file changed, 34 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
in
Summary of how to test LOOPBACK function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 23 +++
1 file changed, 23 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
index e7
Summary of how to test OBEX function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 29 +
1 file changed, 29 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
index
Summary of how to test UAC2 function of USB gadget.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/usb/gadget-testing.txt | 27 +++
1 file changed, 27 insertions(+)
diff --git a/Documentation/usb/gadget-testing.txt
b/Documentation/usb/gadget-testing.txt
index a0
Hello.
On 11/28/2014 04:50 PM, Ricardo Ribalda Delgado wrote:
restart_dma is not used before it is declaration. Therefore we can
s/it is/its/.
remove this definition.
You're removing the declaration, not definition.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/
Hello
Thanks for reviewing. I will fix it and resend it on the next version
of the patchset to avoid spamming the ML
I guess it is ok to add your Reviewed-by
Thanks!
On Fri, Nov 28, 2014 at 3:46 PM, Sergei Shtylyov
wrote:
> Hello.
>
> On 11/28/2014 04:50 PM, Ricardo Ribalda Delgado wrote:
>
>
On Fri, Nov 28, 2014 at 02:57:47PM +0100, Andrzej Pietrasiewicz wrote:
> Summary of how to test SERIAL function of USB gadget.
> +Testing the SERIAL function
> +---
> +
> +On host: insmod usbserial vendor= product=
You should use the sysfs interface to add the IDs dynamica
On Fri, Nov 28, 2014 at 4:39 AM, Vivek Gautam wrote:
> On Fri, Nov 28, 2014 at 9:05 AM, Vivek Gautam
> wrote:
>>> On Mon, Nov 24, 2014 at 6:32 PM, Vivek Gautam
>>> wrote:
USB and Power regulator on Exynos7 require gpios available
in BUS1 pin controller block.
So adding the BUS1
On Fri, 28 Nov 2014, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
> Subject: USB / PM: Drop CONFIG_PM_RUNTIME from the USB core
>
> After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is
> selected) PM_RUNTIME is always set if PM is set, so quite a few
> #ifdef blocks depend
On 11/28/2014 06:21 PM, Ricardo Ribalda Delgado wrote:
Thanks for reviewing. I will fix it and resend it on the next version
of the patchset to avoid spamming the ML
I guess it is ok to add your Reviewed-by
Yes, if you like.
Thanks!
Not at all. :-)
[...]
On 11/28/2014 04:50 PM,
If usb_hub_claim_port() fails, no resources are deallocated and
if stub_add_files() fails, port is not released.
The patch fixes these issues and rearranges error handling code.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
---
drivers/usb/usb
The following changes since commit 206c5f60a3d902bc4b56dab2de3e88de5eb06108:
Linux 3.18-rc4 (2014-11-09 14:55:29 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/
tags/usb-3.18-rc7
for you to fetch changes up to 263e80b43559a6103e1
On Friday, November 28, 2014 11:09:11 AM Alan Stern wrote:
> On Fri, 28 Nov 2014, Rafael J. Wysocki wrote:
>
> > From: Rafael J. Wysocki
> > Subject: USB / PM: Drop CONFIG_PM_RUNTIME from the USB core
> >
> > After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is
> > selected) PM_
On Fri, Nov 28, 2014 at 11:12:05PM -0500, nick wrote:
> Greetings Greg and others,
You were banned from vger.kernel.org for a reason, do not try to go
around that ban by emailing kernel developers directly, it's rude and
just makes us want to blacklist you longer.
--
To unsubscribe from this list:
Adds support for USB-I2C/GPIO interfaces of Cypress Semiconductor
CYUSBS234 USB-Serial Bridge controller.
Details about the device can be found at:
http://www.cypress.com/?rID=84126
Signed-off-by: Muthu Mani
Signed-off-by: Rajaram Regupathy
---
Changes since v3:
* Added devm_* allocation functi
Adds support for USB-I2C interface of Cypress Semiconductor
CYUSBS234 USB-Serial Bridge controller.
The read/write operation is setup using vendor command through control endpoint
and actual data transfer happens through bulk in/out endpoints.
Details about the device can be found at:
http://www.
Adds support for USB-GPIO interface of Cypress Semiconductor
CYUSBS234 USB-Serial Bridge controller.
The GPIO get/set can be done through vendor command on control endpoint
for the configured gpios.
Details about the device can be found at:
http://www.cypress.com/?rID=84126
Signed-off-by: Muthu
71 matches
Mail list logo
