[PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-14 Thread George Cherian
Disable the MUSB interrupts till MUSB is recovered fully from BABBLE condition. There are chances that we could get multiple interrupts till the time the babble recover work gets scheduled. Sometimes this could even end up in an endless loop making MUSB itself unusable. Reported-by: Felipe Balbi

Re: [RFC/PATCH v2] usb: host: xhci: issue 'Reset Endpoint' for !CONTROL EPs from finish_td()

2014-11-14 Thread Mathias Nyman
On 13.11.2014 20:46, Felipe Balbi wrote: > On Thu, Nov 13, 2014 at 12:31:28PM -0600, Felipe Balbi wrote: >> Hi, >> >> (your mailing is un-wrapping emails, I always end up with pretty long >> lines and have to rewrap them) >> >> On Thu, Nov 13, 2014 at 07:58:28PM +0200, Mathias Nyman wrote: The

Re: [PATCH v2 1/3] usb: chipidea: add controller reset API

2014-11-14 Thread Peter Chen
On Thu, Nov 13, 2014 at 09:55:34PM -0600, Felipe Balbi wrote: > Hi, > > On Fri, Nov 14, 2014 at 08:03:15AM +0800, Peter Chen wrote: > > Add controller reset API, it may be used for host/otg driver in future. > > you need a better commit log here. How would it be used ? when ? And, > more importan

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-14 Thread Sebastian Andrzej Siewior
On 11/14/2014 09:24 AM, George Cherian wrote: > Disable the MUSB interrupts till MUSB is recovered fully from BABBLE > condition. There are chances that we could get multiple interrupts > till the time the babble recover work gets scheduled. Sometimes > this could even end up in an endless loop mak

Re: [PATCH 2/3] usb: chipidea: parameter 'mode' isn't needed for hw_device_reset

2014-11-14 Thread Peter Chen
On Thu, Nov 13, 2014 at 09:56:58PM -0600, Felipe Balbi wrote: > On Fri, Nov 14, 2014 at 08:03:16AM +0800, Peter Chen wrote: > > The hw_device_reset is dedicated to be used at device mode initializaiton, > > so delete the parameter 'mode'. For host driver, the ehci driver will > > all things. > > t

Re: [PATCH v4 0/3] Rework "xhci: clear root port wake on bits if controller isn't wake-up capable"

2014-11-14 Thread Mathias Nyman
On 14.11.2014 05:14, Lu, Baolu wrote: > Hi Mathias, > > This patch series has been acked by Alan Stern. There seems no further > comments from others. Can you please pull in it? > > Thanks, > -baolu > Ah, yes, thanks for reminding, I'll pull them in and send them forward. -Mathias -- To unsu

Re: [PATCH 3/3] USB: host: Introduce flag to enable use of 64-bit dma_mask for ehci-platform

2014-11-14 Thread Andreas Herrmann
On Thu, Nov 13, 2014 at 08:44:17PM -0800, Florian Fainelli wrote: > 2014-11-13 13:36 GMT-08:00 Andreas Herrmann > : > > ehci-octeon driver used a 64-bit dma_mask. With removal of ehci-octeon > > and usage of ehci-platform ehci dma_mask is now limited to 32 bits > > (coerced in ehci_platform_probe).

Re: [PATCH v1] chipidea: issue message when some calls fail in ->probe()

2014-11-14 Thread Peter Chen
On Thu, Nov 13, 2014 at 05:59:47PM +0200, Andy Shevchenko wrote: > There is no message when PHY is not enabled, IRQ line can't be acquired, or > debugfs registration fails. This patch adds the messages. > But you get the error return value from probe, it indicates the probe has failed, usually, w

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-14 Thread Oliver Neukum
On Thu, 2014-11-13 at 12:16 -0800, Benson Leung wrote: > In usbhid_open, usb_autopm_get_interface is called > before setting the needs_remote_wakeup flag, and > usb_autopm_put_interface is called after hid_start_in. > > However, when the device is closed in usbhid_close, the same > protection isn

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-14 Thread George Cherian
On 11/14/2014 02:12 PM, Sebastian Andrzej Siewior wrote: On 11/14/2014 09:24 AM, George Cherian wrote: Disable the MUSB interrupts till MUSB is recovered fully from BABBLE condition. There are chances that we could get multiple interrupts till the time the babble recover work gets scheduled. So

Re: [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-11-14 Thread Marek Szyprowski
Hello, On 2014-11-13 21:55, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Thursday, November 13, 2014 7:18 AM On 2014-10-31 19:46, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, October 31, 2014 3:13 AM This

Re: [PATCH 1/3] USB: host: Remove ehci-octeon and ohci-octeon drivers

2014-11-14 Thread Ralf Baechle
On Thu, Nov 13, 2014 at 10:36:28PM +0100, Andreas Herrmann wrote: > From: Alan Stern > > From: Alan Stern Is there an echo? Is there an echo? > Remove special-purpose octeon drivers and instead use ehci-platform > and ohci-platform as suggested with > http://marc.info/?l=linux-mips&m=1401396

Re: [PATCH 2/3] USB: host: Remove hard-coded octeon platform information for ehci/ohci

2014-11-14 Thread Ralf Baechle
On Thu, Nov 13, 2014 at 10:36:29PM +0100, Andreas Herrmann wrote: > Instead rely on device tree information for ehci and ohci. > > This was suggested with > http://www.linux-mips.org/archives/linux-mips/2014-05/msg00307.html > > "The device tree will *always* have correct ehci/ohci clock > c

Re: [PATCH v1] chipidea: issue message when some calls fail in ->probe()

2014-11-14 Thread Andy Shevchenko
On Fri, 2014-11-14 at 15:58 +0800, Peter Chen wrote: > On Thu, Nov 13, 2014 at 05:59:47PM +0200, Andy Shevchenko wrote: > > There is no message when PHY is not enabled, IRQ line can't be acquired, or > > debugfs registration fails. This patch adds the messages. > > > > But you get the error retur

Re: [PATCH 1/3] USB: host: Remove ehci-octeon and ohci-octeon drivers

2014-11-14 Thread Andreas Herrmann
On Fri, Nov 14, 2014 at 10:31:51AM +0100, Ralf Baechle wrote: > On Thu, Nov 13, 2014 at 10:36:28PM +0100, Andreas Herrmann wrote: > > > From: Alan Stern > > > > From: Alan Stern > > Is there an echo? Oops. > Is there an echo? LOL. > > Remove special-purpose octeon drivers and instead use

Re: [GIT PULL] Immutable branch between MFD, GPIO and I2C

2014-11-14 Thread Linus Walleij
On Mon, Nov 10, 2014 at 6:43 PM, Lee Jones wrote: >> Please don't pull this -- it is missing a patch. >> >> Will fix. > > Okay, dependency fixed. Sorry for the fuss. Pull when ready. Letting it just sit around unless there are conflicts coming up... Seems like this can go through MFD alone from

Re: [PATCH 2/2] usb: musb: musb_cppi41: revert to old timer poll intervals

2014-11-14 Thread Sebastian Reimers
Maybe I`ve found a nice old patch: https://github.com/Angstrom-distribution/meta-ti/blob/master/recipes-kernel/linux/linux-ti33x-psp-3.2/psp/0010-usb-musb-cppi41-enable-txfifo-empty-interrupt-logic.patch Is "tx fifo empty interrupt" logic already used? So maybe for ISOC we can avoid the busy hrti

Re: [PATCH v3] usb: dwc2/gadget: report disconnect event from 'end session' irq

2014-11-14 Thread Marek Szyprowski
On 2014-11-13 21:50, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Thursday, November 13, 2014 5:40 AM On 2014-10-31 19:15, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, October 31, 2014 1:04 AM To: linux-usb

Re: Understanding what's going on when using a Huawei E173 USB 3G web-stick (UMTS/HSPA)

2014-11-14 Thread Sedat Dilek
On Wed, Nov 12, 2014 at 2:21 PM, Sedat Dilek wrote: > On Tue, Nov 4, 2014 at 5:55 PM, Dan Williams wrote: >> On Tue, 2014-11-04 at 16:11 +0100, Sedat Dilek wrote: >>> Hi, >>> >>> I wanted to understand what is going on the kernel-side when >>> connecting to the Internet via a Huawei E173 USB web-

Re: [PATCH 0/3] USB: host: Misc patches to remove hard-coded octeon platform information

2014-11-14 Thread Andreas Herrmann
On Thu, Nov 13, 2014 at 05:13:36PM -0500, Alan Stern wrote: > On Thu, 13 Nov 2014, Andreas Herrmann wrote: > > > Hi Alan, > > > > With following patches I want to base octeon ehci/ohci device > > configuration on device tree information. > > > > I picked up patches that were submitted in May. Se

Re: [PATCH 2/2] usb: musb: musb_cppi41: revert to old timer poll intervals

2014-11-14 Thread Sebastian Andrzej Siewior
On 11/14/2014 11:19 AM, Sebastian Reimers wrote: > Maybe I`ve found a nice old patch: > > https://github.com/Angstrom-distribution/meta-ti/blob/master/recipes-kernel/linux/linux-ti33x-psp-3.2/psp/0010-usb-musb-cppi41-enable-txfifo-empty-interrupt-logic.patch > > Is "tx fifo empty interrupt" logic

Re: [PATCH v2 1/3] usb: chipidea: add controller reset API

2014-11-14 Thread Sergei Shtylyov
Hello. On 11/14/2014 3:03 AM, Peter Chen wrote: Add controller reset API, it may be used for host/otg driver in future. Signed-off-by: Peter Chen --- Changes for v2: - Add return value check for controller reset at hw_device_reset drivers/usb/chipidea/core.c | 30 +++

Re: [PATCH v3] usb: dwc2/gadget: report disconnect event from 'end session' irq

2014-11-14 Thread Marek Szyprowski
Hello, On 2014-11-13 21:50, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Thursday, November 13, 2014 5:40 AM On 2014-10-31 19:15, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, October 31, 2014 1:04 AM To: li

[PATCH v4] usb: dwc2/gadget: rework disconnect event handling

2014-11-14 Thread Marek Szyprowski
This patch adds a call to s3c_hsotg_disconnect() from 'end session' interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem about unplugged usb cable. DISCONNINT interrupt cannot be used for this purpose, because it is asserted only in host mode. To avoid reporting disconnect event mo

Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-14 Thread Heikki Krogerus
Hi Vivek, On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote: > Hi Heikki, Kishon, > > How about adding the change in attached patch [1] on top of this patch. > Just introduced the phy pointer in "phy_lookup" structure, and > modified phy_find() accordingly. > > [1] Attachment: > 0

[PATCH v1] chipidea: pci: register nop PHY

2014-11-14 Thread Andy Shevchenko
Since PHY for Chipidea is optional (not all SoCs having PHY for Chipidea should be programmed), we register 'nop' PHY for platforms that does not have programmable PHY. Signed-off-by: Andy Shevchenko --- drivers/usb/chipidea/ci_hdrc_pci.c | 32 +--- 1 file changed, 25

Re: [RFC/PATCH v2] usb: host: xhci: issue 'Reset Endpoint' for !CONTROL EPs from finish_td()

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 10:39:15AM +0200, Mathias Nyman wrote: > On 13.11.2014 20:46, Felipe Balbi wrote: > > On Thu, Nov 13, 2014 at 12:31:28PM -0600, Felipe Balbi wrote: > >> Hi, > >> > >> (your mailing is un-wrapping emails, I always end up with pretty long > >> lines and have to rewrap them) >

Re: [PATCH 2/3] usb: chipidea: parameter 'mode' isn't needed for hw_device_reset

2014-11-14 Thread Felipe Balbi
Hi, On Fri, Nov 14, 2014 at 03:40:55PM +0800, Peter Chen wrote: > > > @@ -1660,7 +1660,7 @@ static int ci_udc_start(struct usb_gadget *gadget, > > > pm_runtime_get_sync(&ci->gadget.dev); > > > if (ci->vbus_active) { > > > spin_lock_irqsave(&ci->lock, flags); > > > - hw_device

Re: [PATCH v2 1/3] usb: chipidea: add controller reset API

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 03:33:44PM +0800, Peter Chen wrote: > On Thu, Nov 13, 2014 at 09:55:34PM -0600, Felipe Balbi wrote: > > Hi, > > > > On Fri, Nov 14, 2014 at 08:03:15AM +0800, Peter Chen wrote: > > > Add controller reset API, it may be used for host/otg driver in future. > > > > you need a

Re: [PATCH v1] chipidea: pci: register nop PHY

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 04:33:22PM +0200, Andy Shevchenko wrote: > Since PHY for Chipidea is optional (not all SoCs having PHY for Chipidea > should > be programmed), we register 'nop' PHY for platforms that does not have s/does not/do not/ > @@ -73,20 +83,27 @@ static int ci_hdrc_pci_probe(stru

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-14 Thread Alan Stern
On Thu, 13 Nov 2014, Benson Leung wrote: > Hi Alan, > > On Thu, Nov 13, 2014 at 2:11 PM, Alan Stern wrote: > > Wait a minute -- in your previous email you said this approach didn't > > work. So does it work or doesn't it? > > Sorry for the confusion. The approach *does* work. > > That was act

Re: [PATCH 3/3] USB: host: Introduce flag to enable use of 64-bit dma_mask for ehci-platform

2014-11-14 Thread Alan Stern
On Fri, 14 Nov 2014, Andreas Herrmann wrote: > On Thu, Nov 13, 2014 at 08:44:17PM -0800, Florian Fainelli wrote: > > 2014-11-13 13:36 GMT-08:00 Andreas Herrmann > > : > > > ehci-octeon driver used a 64-bit dma_mask. With removal of ehci-octeon > > > and usage of ehci-platform ehci dma_mask is now

[PATCH v7 05/13] phy: add the Berlin USB PHY driver

2014-11-14 Thread Antoine Tenart
Add the driver driving the Marvell Berlin USB PHY. This allows to initialize the PHY and to use it from the USB driver later. Signed-off-by: Antoine Tenart --- drivers/phy/Kconfig | 7 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-berlin-usb.c | 224

[PATCH v7 13/13] ARM: dts: berlin: enable USB on the Google Chromecast

2014-11-14 Thread Antoine Tenart
From: Sebastian Hesselbarth Enable usb1 on Google Chromecast which is connected to micro-USB plug used for external power supply, too. Signed-off-by: Sebastian Hesselbarth Signed-off-by: Antoine Tenart --- arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 4 1 file changed, 4 insertion

[PATCH v7 08/13] usb: chipidea: add a usb2 driver for ci13xxx

2014-11-14 Thread Antoine Tenart
Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock and DMA mask, to support USB2 ChipIdea controllers that don't need specific functions. Tested on the Marvell Berlin SoCs USB controllers. Signed-off-by: Antoine Tenart --- drivers/usb/chipidea/Makefile | 1 + drivers/usb/c

[PATCH v7 12/13] ARM: dts: berlin: add BG2CD nodes for USB support

2014-11-14 Thread Antoine Tenart
From: Sebastian Hesselbarth Adds nodes describing the Marvell Berlin BG2CD USB PHY and USB. The BG2CD SoC has 2 USB ChipIdea controllers, with usb0 host-only and usb1 dual-role capable. Signed-off-by: Sebastian Hesselbarth Signed-off-by: Antoine Tenart --- arch/arm/boot/dts/berlin2cd.dtsi | 3

[PATCH v7 11/13] ARM: dts: Berlin: enable USB on the BG2Q DMP

2014-11-14 Thread Antoine Tenart
Enable the 2 available USB PHY and USB nodes on the Marvell Berlin BG2Q DMP. Signed-off-by: Antoine Tenart --- arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 53 ++ 1 file changed, 53 insertions(+) diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boo

[PATCH v7 06/13] Documentation: bindings: add doc for the Berlin USB PHY

2014-11-14 Thread Antoine Tenart
Document the bindings of the Marvell Berlin USB PHY driver. Signed-off-by: Antoine Tenart --- Documentation/devicetree/bindings/phy/berlin-usb-phy.txt | 16 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/berlin-usb-phy.txt diff --git

[PATCH v7 10/13] ARM: dts: berlin: add BG2Q nodes for USB support

2014-11-14 Thread Antoine Tenart
Adds nodes describing the Marvell Berlin BG2Q USB PHY and USB. The BG2Q SoC has 3 USB host controller, compatible with ChipIdea. Signed-off-by: Antoine Tenart --- arch/arm/boot/dts/berlin2q.dtsi | 55 + 1 file changed, 55 insertions(+) diff --git a/arch/a

[PATCH v7 09/13] Documentation: bindings: add doc for the USB2 ChipIdea USB driver

2014-11-14 Thread Antoine Tenart
Document the USB2 ChipIdea driver (ci13xxx) bindings. Signed-off-by: Antoine Tenart --- .../devicetree/bindings/usb/ci-hdrc-usb2.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt diff --git a/Docume

[PATCH v7 03/13] ARM: Berlin: select the reset controller

2014-11-14 Thread Antoine Tenart
The Marvell Berlin SoCs now has a reset controller. Add the needed configuration. Signed-off-by: Antoine Tenart --- arch/arm/mach-berlin/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig index 24f85be71671..5803f773a065 1006

[PATCH v7 04/13] ARM: dts: berlin: add a required reset property in the chip controller node

2014-11-14 Thread Antoine Tenart
The chip controller node now also describes the Marvell Berlin reset controller. Add the required 'reset-cells' property. Signed-off-by: Antoine Tenart Acked-by: Philipp Zabel --- arch/arm/boot/dts/berlin2.dtsi | 1 + arch/arm/boot/dts/berlin2cd.dtsi | 1 + arch/arm/boot/dts/berlin2q.dtsi |

[PATCH v7 02/13] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs

2014-11-14 Thread Antoine Tenart
Add the reset binding documentation to the SoC binding documentation as the reset driver in Marvell Berlin SoC is part of the chip/system control registers. This patch adds the required properties to configure the reset controller. Signed-off-by: Antoine Tenart Acked-by: Philipp Zabel --- Docum

[PATCH v7 07/13] usb: chipidea: fix phy handling

2014-11-14 Thread Antoine Tenart
The generic platform device for CI drivers is probed by calling ci_hdrc_probe. This is not the same device as the one for the specific driver, so the of_node isn't the one we're looking into. This result in not being able to probe the phys. Since all CI driver are retrieving their phys in the spec

[PATCH v7 01/13] reset: add the Berlin reset controller driver

2014-11-14 Thread Antoine Tenart
Add a reset controller for Marvell Berlin SoCs which is used by the USB PHYs drivers (for now). Signed-off-by: Antoine Tenart Signed-off-by: Sebastian Hesselbarth Acked-by: Philipp Zabel --- drivers/reset/Makefile | 1 + drivers/reset/reset-berlin.c | 131 ++

Re: [PATCH v7 03/13] ARM: Berlin: select the reset controller

2014-11-14 Thread Arnd Bergmann
On Friday 14 November 2014 16:25:53 Antoine Tenart wrote: > menuconfig ARCH_BERLIN > bool "Marvell Berlin SoCs" if ARCH_MULTI_V7 > + select ARCH_HAS_RESET_CONTROLLER > select ARCH_REQUIRE_GPIOLIB > select ARM_GIC > select GENERIC_IRQ_CHIP > select DW_A

[PATCH v7 00/13] ARM: berlin: USB support

2014-11-14 Thread Antoine Tenart
This series adds the support for ChipIdea USB2 (ci13xxx) controllers, the USB PHYs of the Marvell Berlin SoCs and also adds a reset controller for these SoCs. The reset controller is used by the PHY driver and shares the existing chip controller node with the clocks and one pin controller. The Ma

Re: [PATCH v7 03/13] ARM: Berlin: select the reset controller

2014-11-14 Thread Sebastian Hesselbarth
On 11/14/2014 04:33 PM, Arnd Bergmann wrote: On Friday 14 November 2014 16:25:53 Antoine Tenart wrote: menuconfig ARCH_BERLIN bool "Marvell Berlin SoCs" if ARCH_MULTI_V7 + select ARCH_HAS_RESET_CONTROLLER select ARCH_REQUIRE_GPIOLIB select ARM_GIC sele

Re: [RFC/PATCH v2] usb: host: xhci: issue 'Reset Endpoint' for !CONTROL EPs from finish_td()

2014-11-14 Thread Felipe Balbi
Hi, On Fri, Nov 14, 2014 at 09:04:16AM -0600, Felipe Balbi wrote: > On Fri, Nov 14, 2014 at 10:39:15AM +0200, Mathias Nyman wrote: > > On 13.11.2014 20:46, Felipe Balbi wrote: > > > On Thu, Nov 13, 2014 at 12:31:28PM -0600, Felipe Balbi wrote: > > >> Hi, > > >> > > >> (your mailing is un-wrapping

Re: [PATCH 1/6] usb: chipidea: add a core function to setup ci_hdrc_platform_data

2014-11-14 Thread Antoine Tenart
Peter, On Fri, Nov 14, 2014 at 09:16:55AM +0800, Peter Chen wrote: > > Ok, Antoine, I find this patch set may not have many benefits due to > below reasons: > - There is already function ci_get_platdata to do the similar things > - If the PHY can't get from the DT, it will use devm_phy_get or > d

Re: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2014-11-14 Thread Alan Stern
On Thu, 13 Nov 2014, Julius Werner wrote: > Another thing might be that the port connect interrupt does not > correctly resume the root hub. I don't really know many details about > how that works, and it seems pretty complicated. But I can see that > all other HCDs seem to call usb_hcd_resume_roo

Re: Understanding what's going on when using a Huawei E173 USB 3G web-stick (UMTS/HSPA)

2014-11-14 Thread Dan Williams
On Fri, 2014-11-14 at 11:56 +0100, Sedat Dilek wrote: > On Wed, Nov 12, 2014 at 2:21 PM, Sedat Dilek wrote: > > On Tue, Nov 4, 2014 at 5:55 PM, Dan Williams wrote: > >> On Tue, 2014-11-04 at 16:11 +0100, Sedat Dilek wrote: > >>> Hi, > >>> > >>> I wanted to understand what is going on the kernel-s

Re: [RFC/PATCH v2] usb: host: xhci: issue 'Reset Endpoint' for !CONTROL EPs from finish_td()

2014-11-14 Thread Mathias Nyman
On 14.11.2014 17:49, Felipe Balbi wrote: > Hi, > > On Fri, Nov 14, 2014 at 09:04:16AM -0600, Felipe Balbi wrote: >> On Fri, Nov 14, 2014 at 10:39:15AM +0200, Mathias Nyman wrote: >>> On 13.11.2014 20:46, Felipe Balbi wrote: On Thu, Nov 13, 2014 at 12:31:28PM -0600, Felipe Balbi wrote: > H

[no subject]

2014-11-14 Thread Angelo Dureghello
unsubscribe linux-usb angel...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH v2] usb: host: xhci: issue 'Reset Endpoint' for !CONTROL EPs from finish_td()

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 06:37:33PM +0200, Mathias Nyman wrote: > On 14.11.2014 17:49, Felipe Balbi wrote: > > Hi, > > > > On Fri, Nov 14, 2014 at 09:04:16AM -0600, Felipe Balbi wrote: > >> On Fri, Nov 14, 2014 at 10:39:15AM +0200, Mathias Nyman wrote: > >>> On 13.11.2014 20:46, Felipe Balbi wrote:

Re: Bug 88151 - PCI device intel xhci with 64-bit bar address can NOT work on x86_32 PAE kernel

2014-11-14 Thread Greg KH
On Fri, Nov 14, 2014 at 01:20:41PM +0800, Aaron Ma wrote: > x86_32 kernel config > > This is associated with [Bug 88131] > The bootlog is already in Bug 88131. You aren't saying where that "bug" is, please provide the full details in an email, this doesn't help us very much :( thanks, greg k-h

[PATCH 1/4] xhci: don't start a halted endpoint before its new dequeue is set

2014-11-14 Thread Mathias Nyman
A halted endpoint ring must first be reset, then move the ring dequeue pointer past the problematic TRB. If we start the ring too early after reset, but before moving the dequeue pointer we will end up executing the same problematic TRB again. As we always issue a set transfer dequeue command afte

[PATCH 0/4] xhci fixes for 3.18-rc

2014-11-14 Thread Mathias Nyman
Hi Greg These patches for usb-linus solve two xhci issues, fixing xhci halted endpoint handling to now follow the specification, and pass testusb control message tests The other one reverts a faulty xhci controller wakeup solution, and writes a new proper solution. Lu Baolu (2): Revert "xhci:

[PATCH 4/4] usb: xhci: rework root port wake bits if controller isn't allowed to wakeup

2014-11-14 Thread Mathias Nyman
From: Lu Baolu When system is being suspended, if host device is not allowed to do wakeup, xhci_suspend() needs to clear all root port wake on bits. Otherwise, some platforms may generate spurious wakeup, even if PCI PME# is disabled. The initial commit ff8cbf250b44 ("xhci: clear root port wake

[PATCH 2/4] xhci: Reset a halted endpoint immediately when we encounter a stall.

2014-11-14 Thread Mathias Nyman
If a device is halted and reuturns a STALL, then the halted endpoint needs to be cleared both on the host and device side. The host side halt is cleared by issueing a xhci reset endpoint command. The device side is cleared with a ClearFeature(ENDPOINT_HALT) request, which should be issued by the de

[PATCH 3/4] Revert "xhci: clear root port wake on bits if controller isn't wake-up capable"

2014-11-14 Thread Mathias Nyman
From: Lu Baolu commit ff8cbf250b44 ("xhci: clear root port wake on bits if controller isn't") can cause device detection error if runtime PM is enabled, and S3 wake is disabled. Revert it. https://bugzilla.kernel.org/show_bug.cgi?id=85701 This commit got into stable and should be reverted from t

Re: [PATCH v7 03/13] ARM: Berlin: select the reset controller

2014-11-14 Thread Antoine Tenart
Sebastian, On Fri, Nov 14, 2014 at 04:36:50PM +0100, Sebastian Hesselbarth wrote: > On 11/14/2014 04:33 PM, Arnd Bergmann wrote: > >On Friday 14 November 2014 16:25:53 Antoine Tenart wrote: > >> menuconfig ARCH_BERLIN > >> bool "Marvell Berlin SoCs" if ARCH_MULTI_V7 > >>+ select ARC

Re: [PATCH 1/4] xhci: don't start a halted endpoint before its new dequeue is set

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 07:23:49PM +0200, Mathias Nyman wrote: > A halted endpoint ring must first be reset, then move the ring > dequeue pointer past the problematic TRB. If we start the ring too > early after reset, but before moving the dequeue pointer we > will end up executing the same problem

Re: [PATCH 3/4] Revert "xhci: clear root port wake on bits if controller isn't wake-up capable"

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 07:23:51PM +0200, Mathias Nyman wrote: > From: Lu Baolu > > commit ff8cbf250b44 ("xhci: clear root port wake on bits if controller isn't") > can cause device detection error if runtime PM is enabled, and S3 wake > is disabled. Revert it. > https://bugzilla.kernel.org/show_

Re: [PATCH 4/4] usb: xhci: rework root port wake bits if controller isn't allowed to wakeup

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 07:23:52PM +0200, Mathias Nyman wrote: > From: Lu Baolu > > When system is being suspended, if host device is not allowed to do wakeup, > xhci_suspend() needs to clear all root port wake on bits. Otherwise, some > platforms may generate spurious wakeup, even if PCI PME# is

Re: [PATCH 3/3] USB: host: Introduce flag to enable use of 64-bit dma_mask for ehci-platform

2014-11-14 Thread Florian Fainelli
On 11/14/2014 07:23 AM, Alan Stern wrote: > On Fri, 14 Nov 2014, Andreas Herrmann wrote: > >> On Thu, Nov 13, 2014 at 08:44:17PM -0800, Florian Fainelli wrote: >>> 2014-11-13 13:36 GMT-08:00 Andreas Herrmann >>> : ehci-octeon driver used a 64-bit dma_mask. With removal of ehci-octeon and

Re: [PATCH 1/4] xhci: don't start a halted endpoint before its new dequeue is set

2014-11-14 Thread Mathias Nyman
On 14.11.2014 19:29, Felipe Balbi wrote: > On Fri, Nov 14, 2014 at 07:23:49PM +0200, Mathias Nyman wrote: >> A halted endpoint ring must first be reset, then move the ring >> dequeue pointer past the problematic TRB. If we start the ring too >> early after reset, but before moving the dequeue point

Re: [PATCH 3/4] Revert "xhci: clear root port wake on bits if controller isn't wake-up capable"

2014-11-14 Thread Mathias Nyman
On 14.11.2014 19:30, Felipe Balbi wrote: > On Fri, Nov 14, 2014 at 07:23:51PM +0200, Mathias Nyman wrote: >> From: Lu Baolu >> >> commit ff8cbf250b44 ("xhci: clear root port wake on bits if controller >> isn't") >> can cause device detection error if runtime PM is enabled, and S3 wake >> is disab

Re: [PATCH 3/4] Revert "xhci: clear root port wake on bits if controller isn't wake-up capable"

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 07:40:01PM +0200, Mathias Nyman wrote: > On 14.11.2014 19:30, Felipe Balbi wrote: > > On Fri, Nov 14, 2014 at 07:23:51PM +0200, Mathias Nyman wrote: > >> From: Lu Baolu > >> > >> commit ff8cbf250b44 ("xhci: clear root port wake on bits if controller > >> isn't") > >> can c

[PATCHv2 1/4] xhci: don't start a halted endpoint before its new dequeue is set

2014-11-14 Thread Mathias Nyman
A halted endpoint ring must first be reset, then move the ring dequeue pointer past the problematic TRB. If we start the ring too early after reset, but before moving the dequeue pointer we will end up executing the same problematic TRB again. As we always issue a set transfer dequeue command afte

[PATCHv2 2/4] xhci: Reset a halted endpoint immediately when we encounter a stall.

2014-11-14 Thread Mathias Nyman
If a device is halted and reuturns a STALL, then the halted endpoint needs to be cleared both on the host and device side. The host side halt is cleared by issueing a xhci reset endpoint command. The device side is cleared with a ClearFeature(ENDPOINT_HALT) request, which should be issued by the de

[PATCHv2 3/4] Revert "xhci: clear root port wake on bits if controller isn't wake-up capable"

2014-11-14 Thread Mathias Nyman
From: Lu Baolu commit ff8cbf250b44 ("xhci: clear root port wake on bits if controller isn't") can cause device detection error if runtime PM is enabled, and S3 wake is disabled. Revert it. https://bugzilla.kernel.org/show_bug.cgi?id=85701 This commit got into stable and should be reverted from t

[PATCHv2 0/4] xhci fixes for 3.18-rc

2014-11-14 Thread Mathias Nyman
Hi Greg second try, correcting a wrong fixes commit ID, and missing stable version in previous try. These patches for usb-linus solve two xhci issues, fixing xhci halted endpoint handling to now follow the specification, and pass testusb control message tests The other one reverts a faulty xhci

[PATCHv2 4/4] usb: xhci: rework root port wake bits if controller isn't allowed to wakeup

2014-11-14 Thread Mathias Nyman
From: Lu Baolu When system is being suspended, if host device is not allowed to do wakeup, xhci_suspend() needs to clear all root port wake on bits. Otherwise, some platforms may generate spurious wakeup, even if PCI PME# is disabled. The initial commit ff8cbf250b44 ("xhci: clear root port wake

Re: [PATCH v7 11/13] ARM: dts: Berlin: enable USB on the BG2Q DMP

2014-11-14 Thread Sergei Shtylyov
Hello. On 11/14/2014 06:26 PM, Antoine Tenart wrote: Enable the 2 available USB PHY and USB nodes on the Marvell Berlin BG2Q DMP. Signed-off-by: Antoine Tenart --- arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 53 ++ 1 file changed, 53 insertions(+) diff --g

RE: [PATCH v4] usb: dwc2/gadget: rework disconnect event handling

2014-11-14 Thread Paul Zimmerman
> -Original Message- > From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] > Sent: Friday, November 14, 2014 4:20 AM > > This patch adds a call to s3c_hsotg_disconnect() from 'end session' > interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem > about unplugged usb cab

Re: [PATCH v4] usb: dwc2/gadget: rework disconnect event handling

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 07:01:37PM +, Paul Zimmerman wrote: > > -Original Message- > > From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] > > Sent: Friday, November 14, 2014 4:20 AM > > > > This patch adds a call to s3c_hsotg_disconnect() from 'end session' > > interrupt (GOTGINT

Re: [PATCH v7 03/13] ARM: Berlin: select the reset controller

2014-11-14 Thread Sebastian Hesselbarth
On 14.11.2014 18:28, Antoine Tenart wrote: Sebastian, On Fri, Nov 14, 2014 at 04:36:50PM +0100, Sebastian Hesselbarth wrote: On 11/14/2014 04:33 PM, Arnd Bergmann wrote: On Friday 14 November 2014 16:25:53 Antoine Tenart wrote: menuconfig ARCH_BERLIN bool "Marvell Berlin SoCs" if A

RE: [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-11-14 Thread Paul Zimmerman
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] > Sent: Friday, November 14, 2014 1:19 AM > > On 2014-11-13 21:55, Paul Zimmerman wrote: > >> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] > >> Sent: Thursday, November 13, 2014 7:18 AM > >> > >> On 2014-10-31 19:46, Paul Zimme

Re: [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-11-14 Thread Felipe Balbi
Hi, On Fri, Nov 14, 2014 at 07:43:23PM +, Paul Zimmerman wrote: > > @@ -3699,6 +3717,8 @@ static int s3c_hsotg_resume(struct > > platform_device *pdev) > > s3c_hsotg_core_connect(hsotg); > > spin_unlock_irqrestore(&hsotg->lock, flags); > > > > +

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2014-11-14 Thread Paul Zimmerman
> From: jwer...@google.com [mailto:jwer...@google.com] On Behalf Of Julius > Werner > Sent: Thursday, November 13, 2014 8:50 PM > > > I will figure out how to make dwc2 detect the device connect after auto > > suspend, > > or disable the auto suspend feature for the dwc2 hcd. > > I think auto-su

Re: [RESUBMIT] [PATCH] Replace mentions of "list_struct" to "list_head"

2014-11-14 Thread Mauro Carvalho Chehab
Em Thu, 13 Nov 2014 20:48:41 -0500 Steven Rostedt escreveu: > On Fri, 14 Nov 2014 05:09:55 +0400 > Andrey Utkin wrote: > > > There's no such thing as "list_struct". > > I guess there isn't. Indeed ;) > > > > > Signed-off-by: Andrey Utkin > > Acked-by: Steven Rostedt Acked-by: Mauro Carv

Re: [PATCH 0/3] USB: host: Misc patches to remove hard-coded octeon platform information

2014-11-14 Thread Aaro Koskinen
On Fri, Nov 14, 2014 at 12:47:14PM +0100, Andreas Herrmann wrote: > On Thu, Nov 13, 2014 at 05:13:36PM -0500, Alan Stern wrote: > > At a very quick first glance, it looks great. Have you tested it > > thoroughly? > > [sorry have to use another mail account, so far your mail didn't show > up a

RE: [PATCHv7 3/8] usb: dwc2: convert to use dev_pm_ops API

2014-11-14 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, November 11, 2014 9:14 AM > > From: Dinh Nguyen > > Update suspend/resume to use dev_pm_ops API. > > Signed-off-by: Dinh Nguyen > --- > drivers/usb/dwc2/platform.c | 15 +-- > 1 file ch

RE: [PATCHv7 5/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-11-14 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, November 11, 2014 9:14 AM > > From: Dinh Nguyen > > Make dwc2_handle_common_intr call the gadget interrupt function when operating > in peripheral mode. Remove the spinlock functions in s3c_hsotg_irq

RE: [PATCHv7 7/8] usb: dwc2: move usb_disabled() call to host driver only

2014-11-14 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, November 11, 2014 9:14 AM > > From: Dinh Nguyen > > Since platform.c will get built for both Host and Gadget, if we leave the > usb_disabled() call in platform.c, it results in the following build err

RE: [PATCHv7 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-14 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, November 11, 2014 9:14 AM > > From: Dinh Nguyen > > Since the dwc2 hcd driver is currently not looking for a clock node during > init, we should not completely fail if there isn't a clock provided. >

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 02:41:57PM +0530, George Cherian wrote: > > On 11/14/2014 02:12 PM, Sebastian Andrzej Siewior wrote: > >On 11/14/2014 09:24 AM, George Cherian wrote: > >>Disable the MUSB interrupts till MUSB is recovered fully from BABBLE > >>condition. There are chances that we could get

Re: [PATCH v7 08/13] usb: chipidea: add a usb2 driver for ci13xxx

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 04:25:58PM +0100, Antoine Tenart wrote: > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock > and DMA mask, to support USB2 ChipIdea controllers that don't need > specific functions. > > Tested on the Marvell Berlin SoCs USB controllers. > > Signed-off-by: A

Re: [PATCHv7 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 09:01:49PM +, Paul Zimmerman wrote: > > From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > > Sent: Tuesday, November 11, 2014 9:14 AM > > > > From: Dinh Nguyen > > > > Since the dwc2 hcd driver is currently not looking for a clock node duri

Re: [PATCH v7 08/13] usb: chipidea: add a usb2 driver for ci13xxx

2014-11-14 Thread Antoine Tenart
Felipe, On Fri, Nov 14, 2014 at 03:08:32PM -0600, Felipe Balbi wrote: > On Fri, Nov 14, 2014 at 04:25:58PM +0100, Antoine Tenart wrote: > > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock > > and DMA mask, to support USB2 ChipIdea controllers that don't need > > specific functions

Re: [PATCH v7 08/13] usb: chipidea: add a usb2 driver for ci13xxx

2014-11-14 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 10:10:52PM +0100, Antoine Tenart wrote: > Felipe, > > On Fri, Nov 14, 2014 at 03:08:32PM -0600, Felipe Balbi wrote: > > On Fri, Nov 14, 2014 at 04:25:58PM +0100, Antoine Tenart wrote: > > > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock > > > and DMA mask,

Re: [PATCH v7 11/13] ARM: dts: Berlin: enable USB on the BG2Q DMP

2014-11-14 Thread Antoine Tenart
Hi, On Fri, Nov 14, 2014 at 09:47:11PM +0300, Sergei Shtylyov wrote: > On 11/14/2014 06:26 PM, Antoine Tenart wrote: > > >Enable the 2 available USB PHY and USB nodes on the Marvell Berlin BG2Q > >DMP. > > >Signed-off-by: Antoine Tenart > >--- > > arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 5

RE: [PATCH v4] usb: dwc2/gadget: rework disconnect event handling

2014-11-14 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Friday, November 14, 2014 11:05 AM > > On Fri, Nov 14, 2014 at 07:01:37PM +, Paul Zimmerman wrote: > > > -Original Message- > > > From: Marek Szyprowski [mailto:m.szypr

RE: [PATCH v4] usb: dwc2/gadget: rework disconnect event handling

2014-11-14 Thread Paul Zimmerman
> From: Paul Zimmerman > Sent: Friday, November 14, 2014 1:21 PM > > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > > Sent: Friday, November 14, 2014 11:05 AM > > > > On Fri, Nov 14, 2014 at 07:01:37PM +, Paul Zimmerman wrote:

Re: [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver

2014-11-14 Thread Sean O. Stalley
On Wed, Nov 12, 2014 at 05:03:18PM -0500, Alan Stern wrote: > On Wed, 12 Nov 2014, Sean O. Stalley wrote: > > Our plan to support multiple MA devices is to have them all connected > > to the same virtual host controller, so only 1 would be needed. > > > > Would you prefer we have 1 host controller

RE: [RESUBMIT] [PATCH] Replace mentions of "list_struct" to "list_head"

2014-11-14 Thread Deucher, Alexander
> -Original Message- > From: Andrey Utkin [mailto:andrey.krieger.ut...@gmail.com] > Sent: Thursday, November 13, 2014 8:10 PM > To: linux-usb@vger.kernel.org; linux-kbu...@vger.kernel.org; linux- > me...@vger.kernel.org; linux-ker...@vger.kernel.org; dri- > de...@lists.freedesktop.org; kern

Re: [RESUBMIT] [PATCH] Replace mentions of "list_struct" to "list_head"

2014-11-14 Thread Paul E. McKenney
On Fri, Nov 14, 2014 at 05:09:55AM +0400, Andrey Utkin wrote: > There's no such thing as "list_struct". > > Signed-off-by: Andrey Utkin May as well get group rates on the acks... ;-) Acked-by: Paul E. McKenney > --- > drivers/gpu/drm/radeon/mkregtable.c | 24 > dri