Re: [PATCH] usb: misc: Add driver for ALVA Nanoface

2014-11-11 Thread Greg Kroah-Hartman
On Tue, Nov 11, 2014 at 09:17:03AM +0200, Lauri Niskanen wrote: > On 11/11/14 09:07, Greg Kroah-Hartman wrote: > >Any reason this can't be a simple userspace program that writes the > >needed command to the device using libusb instead of being a kernel > >driver? This seems like overkill for a ker

Re: [net-next PATCH 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with netdev_alloc_page

2014-11-11 Thread Jeff Kirsher
On Mon, 2014-11-10 at 11:52 -0800, Alexander Duyck wrote: > The Intel drivers were pretty much just using the plain vanilla GFP > flags > in their calls to __skb_alloc_page so this change makes it so that > they use > netdev_alloc_page which just uses GFP_ATOMIC for the gfp_flags value. > > Cc: Je

Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-11 Thread Vivek Gautam
On Tue, Nov 11, 2014 at 12:12 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 31 October 2014 06:03 PM, Vivek Gautam wrote: >> Hi Heikki, >> >> >> On Fri, Oct 17, 2014 at 8:09 PM, Heikki Krogerus >> wrote: >>> Removes the need for the phys to be aware of their users >>> even when not using

[PATCH v2] usbnet: smsc95xx: dereferencing NULL pointer

2014-11-11 Thread Sudip Mukherjee
we were dereferencing dev to initialize pdata. but just after that we have a BUG_ON(!dev). so we were basically dereferencing the pointer first and then tesing it for NULL. Signed-off-by: Sudip Mukherjee --- change in v2: suspend_flags is initialised after pdata is initialised. v1 had a very sil

Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-11 Thread Kishon Vijay Abraham I
Hi, On Tuesday 11 November 2014 02:07 PM, Vivek Gautam wrote: > On Tue, Nov 11, 2014 at 12:12 PM, Kishon Vijay Abraham I > wrote: >> Hi, >> >> On Friday 31 October 2014 06:03 PM, Vivek Gautam wrote: >>> Hi Heikki, >>> >>> >>> On Fri, Oct 17, 2014 at 8:09 PM, Heikki Krogerus >>> wrote: Remo

Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-11 Thread Vivek Gautam
Hi Kishon, On Tue, Nov 11, 2014 at 2:20 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 11 November 2014 02:07 PM, Vivek Gautam wrote: >> On Tue, Nov 11, 2014 at 12:12 PM, Kishon Vijay Abraham I >> wrote: >>> Hi, >>> >>> On Friday 31 October 2014 06:03 PM, Vivek Gautam wrote: Hi He

Re: [RFC v5] usb: phy: Hold wakeupsource when USB is enumerated in peripheral mode

2014-11-11 Thread Kishon Vijay Abraham I
Hi Felipe, On Monday 10 November 2014 08:56 PM, Felipe Balbi wrote: > Hi, > > On Tue, Nov 04, 2014 at 03:30:54PM +0530, Kiran Kumar Raparthy wrote: >> @@ -1469,6 +1484,7 @@ static int ab8500_usb_probe(struct platform_device >> *pdev) >> >> abx500_usb_link_status_update(ab); >> >> +u

[PATCH] usb: phy: fix twl4030 build regression

2014-11-11 Thread Arnd Bergmann
Recent changes to the common OTG handling broke building the twl4030 OTG driver as found during an allmodconfig build of linux-next: drivers/phy/phy-twl4030-usb.c: In function 'twl4030_set_peripheral': drivers/phy/phy-twl4030-usb.c:609:11: error: 'struct phy' has no member named 'state' drivers/p

Re: btusb_intr_complete returns -EPIPE

2014-11-11 Thread Naveen Kumar Parna
On Mon, Nov 10, 2014 at 10:26 PM, Alan Stern wrote: > On Mon, 10 Nov 2014, Naveen Kumar Parna wrote: > >> I am sorry for the late response. >> >> I applied the patch and here is the dmesg log: >> >> [ 713.125709] ehci-pci :00:1a.0: split intr info2 42821c01 token >> 80108d46 overlay token 801

Re: [PATCH 1/1] x86: Surface Pro 3 Type Cover 3

2014-11-11 Thread Jiri Kosina
On Mon, 3 Nov 2014, Alan Wu wrote: > Surface Pro 3 Type Cover that works with Ubuntu (and possibly Arch) from this > thread. Both trackpad and keyboard work after compiling my own kernel. > http://ubuntuforums.org/showthread.php?t=2231207&page=2&s=44910e0c56047e4f93dfd9fea58121ef > > Also includ

Re: [PATCH -next 1/2] seq_puts: Convert to return void and convert uses too.

2014-11-11 Thread Petr Mladek
On Mon 2014-11-10 10:58:56, Joe Perches wrote: > diff --git a/ipc/util.c b/ipc/util.c > index 106bed0..4f726b7 100644 > --- a/ipc/util.c > +++ b/ipc/util.c > @@ -837,8 +837,10 @@ static int sysvipc_proc_show(struct seq_file *s, void > *it) > struct ipc_proc_iter *iter = s->private; > s

[no subject]

2014-11-11 Thread Haibo Zhang
Hello, We know that dwc2 is the USB2.0 driver for DesignWare IP. But it only has host’s code without device’s code. So I have two questions: 1. Will I develop or port the part of device’s code if I want to use dwc2 to support both host and device’s functions? 2. Another question, I kno

Two questions about dwc2 driver

2014-11-11 Thread Haibo Zhang
Hello, We know that dwc2 is the USB2.0 driver for DesignWare IP. But it only has host’s code without device’s code. So I have two questions: 1. Will I develop or port the part of device’s code if I want to use dwc2 to support both host and device’s functions? 2. Another question, I kno

Re: [PATCH] usb: phy: fix twl4030 build regression

2014-11-11 Thread Felipe Balbi
On Tue, Nov 11, 2014 at 08:52:17AM -0600, Felipe Balbi wrote: > On Tue, Nov 11, 2014 at 10:36:09AM +0100, Arnd Bergmann wrote: > > Recent changes to the common OTG handling broke building the twl4030 > > OTG driver as found during an allmodconfig build of linux-next: > > > > drivers/phy/phy-twl403

Re: [PATCH] usb: phy: fix twl4030 build regression

2014-11-11 Thread Felipe Balbi
On Tue, Nov 11, 2014 at 10:36:09AM +0100, Arnd Bergmann wrote: > Recent changes to the common OTG handling broke building the twl4030 > OTG driver as found during an allmodconfig build of linux-next: > > drivers/phy/phy-twl4030-usb.c: In function 'twl4030_set_peripheral': > drivers/phy/phy-twl4030

Re: [PATCHv2] phy: omap-usb2: Enable runtime PM of omap-usb2 phy properly

2014-11-11 Thread Enric Balletbo Serra
Hi all, 2014-11-04 0:29 GMT+01:00 Greg KH : > On Mon, Nov 03, 2014 at 04:51:41PM +0530, Kishon Vijay Abraham I wrote: >> Hi Greg, >> >> On Tuesday 07 October 2014 04:32 PM, Oussama Ghorbel wrote: >> > The USB OTG port does not work since v3.16 on omap platform. >> > This is a regression introduced

Re: [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver

2014-11-11 Thread Alan Stern
On Mon, 10 Nov 2014, Stephanie Wallick wrote: > +static struct mausb_hcd mhcd; Only one statically-allocated structure? What if somebody wants to have more than one of these things in their system? > +/** > + * @maurb: Media agnostic structure with URB to release. > + * @status: Status for

Re: btusb_intr_complete returns -EPIPE

2014-11-11 Thread Alan Stern
On Tue, 11 Nov 2014, Naveen Kumar Parna wrote: > I am really glad we reached to a conclusion on this. > Thanks for all your help, without which I could not have seen this through. You're welcome. > Now I am confronted with many of these controllers in my lab, with > this hardware issue. > I am n

Patch for 3.18-rc4 to add OLIMEX ISP500 AVR Programmer

2014-11-11 Thread Sid Boyce
Results --- root@sdrbox:~# lsusb Bus 002 Device 004: ID 13fd:1840 Initio Corporation INIC-1608 SATA bridge Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 004 Device 003: ID 15ba:000c Olimex Ltd. The failure due to AtMega32 not attached. root@sdrbox:~# avrdude -p m32 -F

[net-next PATCH v2 0/5] Replace __skb_alloc_pages with simpler function

2014-11-11 Thread Alexander Duyck
This patch series replaces __skb_alloc_pages with a much simpler function, __dev_alloc_pages. The main difference between the two is that __skb_alloc_pages had an sk_buff pointer that was being passed as NULL in call places where it was called. In a couple of cases the NULL was passed by variable

[net-next PATCH v2 3/5] phonet: Replace calls to __skb_alloc_page with __netdev_alloc_page

2014-11-11 Thread Alexander Duyck
Replace the calls to __skb_alloc_page that are passed NULL with calls to __netdev_alloc_page. In addition remove __GFP_COLD flag from allocations as we only want it for the Rx buffer which is taken care of by __dev_alloc_skb, not for any secondary allocations such as the queue element transmit des

[net-next PATCH v2 1/5] net: Add device Rx page allocation function

2014-11-11 Thread Alexander Duyck
This patch implements __dev_alloc_pages and __dev_alloc_page. These are meant to replace the __skb_alloc_pages and __skb_alloc_page functions. The reason for doing this is that it occurred to me that __skb_alloc_page is supposed to be passed an sk_buff pointer, but it is NULL in all cases where i

Re: xHCI bug

2014-11-11 Thread Mathias Nyman
On 10.11.2014 17:24, Felipe Balbi wrote: > Hi, > > On Fri, Nov 07, 2014 at 03:40:01PM +0200, Mathias Nyman wrote: >> On 07.11.2014 00:25, Felipe Balbi wrote: >>> On Thu, Nov 06, 2014 at 10:36:30AM -0600, Felipe Balbi wrote: On Thu, Nov 06, 2014 at 06:31:20PM +0200, Mathias Nyman wrote: >

[PATCHv7 0/8] usb: dwc2: Add support for dual-role

2014-11-11 Thread dinguyen
From: Dinh Nguyen Hello, This is version 7 of the patch series that combines the dwc2 gadget and host driver into a single dual role driver. Here are the main differences from V6: - patch 1/8: Addressed Felipe's comment on which variables should not be just limited to gadget(phy, uphy, regula

[PATCHv7 8/8] usb: dwc2: Update Kconfig to support dual-role

2014-11-11 Thread dinguyen
From: Dinh Nguyen Update DWC2 kconfig and makefile to support dual-role mode. The platform file will always get compiled for the case where the controller is directly connected to the CPU. So for loadable modules, dwc2.ko is built for host, peripheral, and dual-role mode. The PCI bus interface wi

[net-next PATCH v2 5/5] net: Remove __skb_alloc_page and __skb_alloc_pages

2014-11-11 Thread Alexander Duyck
Remove the two functions which are now dead code. Signed-off-by: Alexander Duyck --- include/linux/skbuff.h | 43 --- 1 file changed, 43 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 2e5221f..73c370e 100644 --- a/includ

[PATCHv7 7/8] usb: dwc2: move usb_disabled() call to host driver only

2014-11-11 Thread dinguyen
From: Dinh Nguyen Since platform.c will get built for both Host and Gadget, if we leave the usb_disabled() call in platform.c, it results in the following build error when (!USB && USB_GADGET) condition is met. ERROR: "usb_disabled" [drivers/usb/dwc2/dwc2_platform.ko] undefined! Since usb_disab

[net-next PATCH v2 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with netdev_alloc_page

2014-11-11 Thread Alexander Duyck
The Intel drivers were pretty much just using the plain vanilla GFP flags in their calls to __skb_alloc_page so this change makes it so that they use netdev_alloc_page which just uses GFP_ATOMIC for the gfp_flags value. Cc: Jeff Kirsher Cc: Matthew Vick Cc: Don Skidmore Signed-off-by: Alexander

[net-next PATCH v2 2/5] cxgb4/cxgb4vf: Replace __skb_alloc_page with __netdev_alloc_page

2014-11-11 Thread Alexander Duyck
Drop the bloated use of __skb_alloc_page and replace it with __netdev_alloc_page. In addition update the one other spot that is allocating a page so that it allocates with the correct flags. Cc: Hariprasad S Cc: Casey Leedom Signed-off-by: Alexander Duyck --- drivers/net/ethernet/chelsio/cxgb

[PATCHv7 5/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-11-11 Thread dinguyen
From: Dinh Nguyen Make dwc2_handle_common_intr call the gadget interrupt function when operating in peripheral mode. Remove the spinlock functions in s3c_hsotg_irq as dwc2_handle_common_intr() already has the spinlocks. Move the registeration of the IRQ to common code for platform and PCI. Remo

[PATCHv7 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-11 Thread dinguyen
From: Dinh Nguyen Since the dwc2 hcd driver is currently not looking for a clock node during init, we should not completely fail if there isn't a clock provided. By assigning clk = NULL, this allows the driver, when configured for dual-role mode, to be able to continue loading the host portion of

[PATCHv7 1/8] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-11-11 Thread dinguyen
From: Dinh Nguyen Adds the gadget data structure and appropriate data structure pointers to the common dwc2_hsotg data structure. To keep the driver data dereference code looking clean, the gadget variable declares are only available for peripheral and dual-role mode. This is needed so that the d

[PATCHv7 4/8] usb: dwc2: Initialize the USB core for peripheral mode

2014-11-11 Thread dinguyen
From: Dinh Nguyen Initialize the USB driver to peripheral mode when a B-Device connector is attached. Signed-off-by: Dinh Nguyen Acked-by: Paul Zimmerman --- v7: s3c_hsotg_core_init became s3c_hsotg_core_init_disconnected v5: move the export of s3c_hsotg_core_init into this patch --- drivers/

[PATCHv7 2/8] usb: dwc2: Move gadget probe function into platform code

2014-11-11 Thread dinguyen
From: Dinh Nguyen This patch will aggregate the probing of gadget/hcd driver into platform.c. The gadget probe funtion is converted into gadget_init that is now only responsible for gadget only initialization. All the gadget resources are now handled by platform.c Since the host workqueue will n

Re: [net-next PATCH v2 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with netdev_alloc_page

2014-11-11 Thread Cong Wang
On Tue, Nov 11, 2014 at 9:11 AM, Alexander Duyck wrote: > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c > b/drivers/net/ethernet/intel/fm10k/fm10k_main.c > index e645af4..73457ed 100644 > --- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c > +++ b/drivers/net/ethernet/intel/fm10k/fm1

[PATCHv7 3/8] usb: dwc2: convert to use dev_pm_ops API

2014-11-11 Thread dinguyen
From: Dinh Nguyen Update suspend/resume to use dev_pm_ops API. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/platform.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index eeba8a4..b94867b 100644

[net-next PATCH v3 2/5] cxgb4/cxgb4vf: Replace __skb_alloc_page with __dev_alloc_page

2014-11-11 Thread Alexander Duyck
Drop the bloated use of __skb_alloc_page and replace it with __dev_alloc_page. In addition update the one other spot that is allocating a page so that it allocates with the correct flags. Cc: Hariprasad S Cc: Casey Leedom Signed-off-by: Alexander Duyck --- drivers/net/ethernet/chelsio/cxgb4/s

[net-next PATCH v3 5/5] net: Remove __skb_alloc_page and __skb_alloc_pages

2014-11-11 Thread Alexander Duyck
Remove the two functions which are now dead code. Signed-off-by: Alexander Duyck --- include/linux/skbuff.h | 43 --- 1 file changed, 43 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 2e5221f..73c370e 100644 --- a/includ

Re: [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page

2014-11-11 Thread Jeff Kirsher
On Tue, 2014-11-11 at 09:26 -0800, Alexander Duyck wrote: > The Intel drivers were pretty much just using the plain vanilla GFP > flags > in their calls to __skb_alloc_page so this change makes it so that > they use > dev_alloc_page which just uses GFP_ATOMIC for the gfp_flags value. > > Cc: Jeff

Re: [net-next PATCH v2 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with netdev_alloc_page

2014-11-11 Thread Alexander Duyck
On 11/11/2014 09:15 AM, Cong Wang wrote: On Tue, Nov 11, 2014 at 9:11 AM, Alexander Duyck wrote: diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c index e645af4..73457ed 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c +++ b/d

[net-next PATCH v3 0/5] Replace __skb_alloc_pages with simpler function

2014-11-11 Thread Alexander Duyck
This patch series replaces __skb_alloc_pages with a much simpler function, __dev_alloc_pages. The main difference between the two is that __skb_alloc_pages had an sk_buff pointer that was being passed as NULL in call places where it was called. In a couple of cases the NULL was passed by variable

[net-next PATCH v3 3/5] phonet: Replace calls to __skb_alloc_page with __dev_alloc_page

2014-11-11 Thread Alexander Duyck
Replace the calls to __skb_alloc_page that are passed NULL with calls to __dev_alloc_page. In addition remove __GFP_COLD flag from allocations as we only want it for the Rx buffer which is taken care of by __dev_alloc_skb, not for any secondary allocations such as the queue element transmit descri

Re: [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page

2014-11-11 Thread David Miller
From: Jeff Kirsher Date: Tue, 11 Nov 2014 09:28:24 -0800 > On Tue, 2014-11-11 at 09:26 -0800, Alexander Duyck wrote: >> The Intel drivers were pretty much just using the plain vanilla GFP >> flags >> in their calls to __skb_alloc_page so this change makes it so that >> they use >> dev_alloc_page

Re: [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page

2014-11-11 Thread Jeff Kirsher
On Tue, 2014-11-11 at 12:48 -0500, David Miller wrote: > From: Jeff Kirsher > Date: Tue, 11 Nov 2014 09:28:24 -0800 > > > On Tue, 2014-11-11 at 09:26 -0800, Alexander Duyck wrote: > >> The Intel drivers were pretty much just using the plain vanilla GFP > >> flags > >> in their calls to __skb_allo

Re: [net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page

2014-11-11 Thread David Miller
From: Jeff Kirsher Date: Tue, 11 Nov 2014 09:56:34 -0800 > On Tue, 2014-11-11 at 12:48 -0500, David Miller wrote: >> I think this entire series will need to go via my tree, because the >> conversions are all required for patch #5 which removes the replaced >> interface altogether. > > That is fi

[net-next PATCH v3 4/5] fm10k/igb/ixgbe: Replace __skb_alloc_page with dev_alloc_page

2014-11-11 Thread Alexander Duyck
The Intel drivers were pretty much just using the plain vanilla GFP flags in their calls to __skb_alloc_page so this change makes it so that they use dev_alloc_page which just uses GFP_ATOMIC for the gfp_flags value. Cc: Jeff Kirsher Cc: Matthew Vick Cc: Don Skidmore Signed-off-by: Alexander Du

[net-next PATCH v3 1/5] net: Add device Rx page allocation function

2014-11-11 Thread Alexander Duyck
This patch implements __dev_alloc_pages and __dev_alloc_page. These are meant to replace the __skb_alloc_pages and __skb_alloc_page functions. The reason for doing this is that it occurred to me that __skb_alloc_page is supposed to be passed an sk_buff pointer, but it is NULL in all cases where i

RE: Two questions about dwc2 driver

2014-11-11 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Haibo Zhang > Sent: Tuesday, November 11, 2014 6:37 AM > > We know that dwc2 is the USB2.0 driver for DesignWare IP. But it only > has host’s code without device’s code. So I have two questions: > 1.

Re: [PATCH 2/2] usb: musb: musb_cppi41: revert to old timer poll intervals

2014-11-11 Thread Sebastian Reimers
Hi Sebastian, Hi Daniel, after some debugging the 25 microseconds loop only catches <1% of early_tx transfers (with your patch #1). Most of them are catched in the hrtimer (incl. re-loop) between 30-60 microseconds. Any debug code suggestions to get reliable values? I`m not sure if my current a

Re: Patch for 3.18-rc4 to add OLIMEX ISP500 AVR Programmer

2014-11-11 Thread Johan Hovold
On Tue, Nov 11, 2014 at 04:43:52PM +, Sid Boyce wrote: > Results > --- > root@sdrbox:~# lsusb > Bus 002 Device 004: ID 13fd:1840 Initio Corporation INIC-1608 SATA bridge > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > Bus 004 Device 003: ID 15ba:000c Olimex Ltd. > >

Status update on xhci controllers with broken streams

2014-11-11 Thread Hans de Goede
Hi All, So when I send the patches to blacklist via xhci controllers with a product-id of 3432, as well as asmedia 1042 xhci controllers, I promised I would spend some quality time with both once I actually got one of each in my hands, and see if I could come up with a workaround rather then outri

Re: [PATCH 2/2] usb: musb: musb_cppi41: revert to old timer poll intervals

2014-11-11 Thread Sebastian Andrzej Siewior
On 11/11/2014 08:20 PM, Sebastian Reimers wrote: > Hi Sebastian, > Hi Daniel, > > after some debugging the 25 microseconds loop only catches <1% of early_tx > transfers (with your patch #1). Most of them are catched in the hrtimer > (incl. re-loop) > between 30-60 microseconds. Any debug code su

Re: [PATCH v2] usbnet: smsc95xx: dereferencing NULL pointer

2014-11-11 Thread David Miller
From: Sudip Mukherjee Date: Tue, 11 Nov 2014 14:10:47 +0530 > we were dereferencing dev to initialize pdata. but just after that we > have a BUG_ON(!dev). so we were basically dereferencing the pointer > first and then tesing it for NULL. > > Signed-off-by: Sudip Mukherjee > --- > > change in

Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling

2014-11-11 Thread Sean O. Stalley
On Tue, Nov 11, 2014 at 01:38:21PM +0900, Greg KH wrote: > On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote: > Intel has a whole group of very experienced Linux kernel developers who > will review code before you sent it out publicly. Please take advantage > of them and run this a

Re: Patch for 3.18-rc4 to add OLIMEX ISP500 AVR Programmer

2014-11-11 Thread Sid Boyce
On 11/11/14 19:46, Johan Hovold wrote: On Tue, Nov 11, 2014 at 04:43:52PM +, Sid Boyce wrote: Results --- root@sdrbox:~# lsusb Bus 002 Device 004: ID 13fd:1840 Initio Corporation INIC-1608 SATA bridge Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 004 Device 003:

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-11 Thread Ben Hutchings
On Tue, 2014-11-04 at 20:09 +, Charles Keepax wrote: > On Tue, Nov 04, 2014 at 11:23:06AM +0100, Stam, Michel [FINT] wrote: > > Hello Riku, > > > > >Fixing a bug (ethtool support) must not cause breakage elsewhere (in > > this case on arndale). This is now a regression of functionality from >

Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling

2014-11-11 Thread Greg KH
On Tue, Nov 11, 2014 at 02:42:22PM -0800, Sean O. Stalley wrote: > On Tue, Nov 11, 2014 at 01:38:21PM +0900, Greg KH wrote: > > On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote: > > Intel has a whole group of very experienced Linux kernel developers who > > will review code before

Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling

2014-11-11 Thread steph
On Wed, Nov 12, 2014 at 10:14:38AM +0900, Greg KH wrote: > On Tue, Nov 11, 2014 at 02:42:22PM -0800, Sean O. Stalley wrote: > > On Tue, Nov 11, 2014 at 01:38:21PM +0900, Greg KH wrote: > > > On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote: > > > Yes, I am holding you to a higher s

[PATCH net-next v3 0/3] Code adjustment

2014-11-11 Thread Hayes Wang
v3: Remove the test_bit for patch #2. v2: Correct the spelling error for the comment of patch #3. v1: Adjust some codes to make them more reasonable. Hayes Wang (3): r8152: remove the duplicate init for the list of rx_done r8152: clear the flag of SCHEDULE_TASKLET in tasklet r8152: check

[PATCH net-next v3 3/3] r8152: check RTL8152_UNPLUG and netif_running before autoresume

2014-11-11 Thread Hayes Wang
If the device is unplugged or !netif_running(), the workqueue doesn't need to wake the device, and could return directly. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r

[PATCH net-next v3 2/3] r8152: clear the flag of SCHEDULE_TASKLET in tasklet

2014-11-11 Thread Hayes Wang
Clear the flag of SCHEDULE_TASKLET in bottom_half() to avoid re-schedule the tasklet again by workqueue. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index a300467..ad9dd7d 100644 ---

[PATCH net-next v3 1/3] r8152: remove the duplicate init for the list of rx_done

2014-11-11 Thread Hayes Wang
The INIT_LIST_HEAD(&tp->rx_done) would be done in rtl_start_rx(), so remove the unnecessary one in alloc_all_mem(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 66b139a..a300467 10

Re: [PATCH v8 0/7] usb: add support for the generic PHY framework

2014-11-11 Thread Peter Chen
On Fri, Nov 07, 2014 at 12:08:52PM -0600, Felipe Balbi wrote: > On Fri, Nov 07, 2014 at 12:08:20PM -0600, Felipe Balbi wrote: > > Hi, > > > > On Fri, Nov 07, 2014 at 01:33:25PM +, Peter Chen wrote: > > > > > > > > > > > > > > > > > Antoine Tenart (7): > > > > usb: move the OTG state fro

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang Date: Wed, 12 Nov 2014 01:45:08 + > David Miller [mailto:da...@davemloft.net] >> Sent: Saturday, November 08, 2014 12:35 AM > [...] >> Does this even work? >> >> If you leave a hole in the ring, the device is going to stop there >> anyways. >> >> So better to replenish the

RE: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread Hayes Wang
David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, November 12, 2014 10:20 AM [...] > I haven't had time to process your original reply, please be patient. I am sorry for bothering you, and thanks for your reply. Best Regards, Hayes -- To unsubscribe from this list: send the line "uns

Re: [PATCH v8 0/7] usb: add support for the generic PHY framework

2014-11-11 Thread Peter Chen
On Fri, Nov 07, 2014 at 12:08:52PM -0600, Felipe Balbi wrote: > On Fri, Nov 07, 2014 at 12:08:20PM -0600, Felipe Balbi wrote: > > Hi, > > > > On Fri, Nov 07, 2014 at 01:33:25PM +, Peter Chen wrote: > > > > > > > > > > > > > > > > > Antoine Tenart (7): > > > > usb: move the OTG state fro

RE: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread Hayes Wang
David Miller [mailto:da...@davemloft.net] > Sent: Saturday, November 08, 2014 12:35 AM [...] > Does this even work? > > If you leave a hole in the ring, the device is going to stop there > anyways. > > So better to replenish the next time you call into this function > rather than leaving gaps in

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang Date: Mon, 10 Nov 2014 03:29:27 + > The behavior is different for PCI(e) and USB ethernet device. > The PCI nic could know the ring buffer by certain way, so > the device could fill the data into the buffer one by one > automatically. However, for usb nic, the driver has to >

RE: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread Hayes Wang
David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, November 12, 2014 10:51 AM [...] > Ok, but if we are looping here in rtl_start_rx() and r8152_submit_rx() > fails due to a memory allocation failure, there is nothing which is > going to make such a memory allocation succeed in the next

Re: [net-next PATCH v3 0/5] Replace __skb_alloc_pages with simpler function

2014-11-11 Thread David Miller
From: Alexander Duyck Date: Tue, 11 Nov 2014 09:26:26 -0800 > This patch series replaces __skb_alloc_pages with a much simpler function, > __dev_alloc_pages. The main difference between the two is that > __skb_alloc_pages had an sk_buff pointer that was being passed as NULL in > call places wher

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang Date: Wed, 12 Nov 2014 05:07:40 + > How about that when a error occurs, add the remaining rx > to the list without submission? Then, the remianing rx > could be re-submitted later, and the rtl_start_rx() could > be completed as soon as possible. I really want to know why you

RE: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread Hayes Wang
David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, November 12, 2014 1:13 PM [...] > I really want to know why you are spending so much effort on this. > > Is there a real situation that happened very often, which you > diagnosed in detail, and therefore you want to address? No. I just

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang Date: Wed, 12 Nov 2014 05:23:03 + > David Miller [mailto:da...@davemloft.net] >> Sent: Wednesday, November 12, 2014 1:13 PM > [...] >> I really want to know why you are spending so much effort on this. >> >> Is there a real situation that happened very often, which you >> d

Re: Patch for 3.18-rc4 to add OLIMEX ISP500 AVR Programmer

2014-11-11 Thread Lars Melin
On 2014-11-12 13:05, Lars Melin wrote: On 2014-11-11 23:43, Sid Boyce wrote: Results --- root@sdrbox:~# lsusb Bus 002 Device 004: ID 13fd:1840 Initio Corporation INIC-1608 SATA bridge Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 004 Device 003: ID 15ba:000c Olimex

RE: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread Hayes Wang
David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, November 12, 2014 1:44 PM [...] > What do other USB network drivers do in similar situations? According to the usbnet.c, it would make sure to submit the number of min(10, RX_QLEN(dev)) rx buffers. If there are not enough rx buffers, it

[RFC v6 1/3] usb: phy: introduce usb_phy_set_event interface

2014-11-11 Thread Kiran Kumar Raparthy
From: Todd Poynor usb: phy: introduce usb_phy_set_event interface PHY drivers require a generic interface to handle per-PHY events. usb_phy_set_event interface sets event to phy event. PHY drivers call this interface for each phy event. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-ker..

[RFC v6 2/3] usb: phy: handle per-PHY connect and disconnect events

2014-11-11 Thread Kiran Kumar Raparthy
From: Todd Poynor usb: phy: handle per-PHY connect and disconnect events When usb is connected and enumerated in device mode or when usb is disconnected,call usb_phy_set_event from phy drivers to handle per-PHY event. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-ker...@vger.kernel.org Cc

[RFC v6 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

2014-11-11 Thread Kiran Kumar Raparthy
From: Todd Poynor usb: phy: hold wakeupsource when USB is enumerated in peripheral mode Some systems require a mechanism to prevent system to enter into suspend state when USB is connected and enumerated in peripheral mode. This patch provides an interface to hold a wakeupsource to prevent susp