> It's entirely possible that the stall packets are created by the hub.
> When a full-speed device is connected to a USB-2 hub, and the device
> fails to respond to a packet sent by the host, the hub reports this
> failure as a stall.
Here I don’t think device fails to respond to a packet sent by
modified the function to have a single return statement at the end
instead of multiple return statement in the middle of the function
to improve the readability of the code.
Signed-off-by: Sudip Mukherjee
---
drivers/usb/dwc2/gadget.c | 11 ---
1 file changed, 8 insertions(+), 3 deletion
sparse was giving the following warning:
warning: context imbalance in 's3c_hsotg_ep_enable'
- different lock contexts for basic block
we were returning ENOMEM while still holding the spinlock.
The sparse warning was fixed by releasing the spinlock before return.
This patc
On Tue, Oct 14, 2014 at 09:27:40AM -0500, Felipe Balbi wrote:
> On Tue, Oct 14, 2014 at 10:08:39AM +0200, Greg KH wrote:
> > On Tue, Oct 14, 2014 at 03:55:54PM +0800, Peter Chen wrote:
> > > Hi Greg,
> > >
> > > Fabio Estevam posted the similar patches for chipidea, I think the cleanup
> > > may a
>
> That must be a relatively recent addition to the spec. In the original
> v1.0 spec, only bits 31:27 are specified for this.
>
> --
> Paul
>
That explains it, thanks. I could only find v1.1 when I noticed this.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body
Please check below
15.10.2014 18:00, Johan Hovold пишет:
[ Adding linux-usb to CC. ]
On Wed, Oct 15, 2014 at 03:55:15PM +0400, Victor Ashik wrote:
Hello Johan,
Sorry for asking you directly, I found your address in the top comment of
ftdi_sio.c in Linux sources. I think that you know a short
On Thu, Oct 16, 2014 at 12:47:05PM +0400, Victor Ashik wrote:
> Wed, Oct 15, 2014 at 6:00 PM, Johan Hovold wrote:
> > No, we're still supposed to support the legacy SIO type of devices,
> > although that code doesn't get much testing I'm afraid.
> >
> > But let's start with verifying that the ty
On Wed, 2014-10-15 at 12:11 -0400, Alan Stern wrote:
> > If the hub is the problem… what will be the better solution? Is it
> > possible to change internal hub?
>
> No, it is not possible.
Indeed. However, it is possible to use an additional in between your
devices and the internal hub.
This series aims at integrating configfs into hid, the way
it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet,
mass_storage, FunctionFS, loopback, sourcesink, uac1, uac2, uvc and hid.
It concludes converting functions explicitly available as f_xyz.c files
to configfs.
Rebased
Converting midi to the new function interface requires converting
the USB midi's function code and its users.
This patch converts the f_midi.c to the new function interface.
The file can now be compiled into a separate usb_f_midi.ko module.
The old function interface is provided by means of a pre
There are no old f_midi interface users left, so remove it.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/function/f_midi.c | 122 ---
1 file changed, 122 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c
b/drivers/usb/gadget/function/
Use the new f_midi interface so that the old can be removed.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/legacy/Kconfig | 1 +
drivers/usb/gadget/legacy/gmidi.c | 44 ---
2 files changed, 38 insertions(+), 7 deletions(-)
diff --git a/drivers/
kstrdup() might fail, so check its return value and react appropriately.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/function/f_midi.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c
b/drivers/usb/
In order to add configfs support the usb_gstrings_attach must be used.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/function/f_midi.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c
b/drivers/usb/gadget/functi
The soundcard index to use for the ALSA device creation is passed as a
parameter to f_midi_bind_config(), but is assigned to midi->index only
after the call to f_midi_register_card(midi). So no matter what is passed
to f_midi_bind_config(), the actual index for snd_card_new() is always 0.
This prob
Make the midi function available for gadgets composed with configfs.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/ABI/testing/configfs-usb-gadget-midi | 12 ++
drivers/usb/gadget/Kconfig | 13 ++
drivers/usb/gadget/function/f_midi.c | 161 +++
On Thu, Oct 16, 2014 at 2:45 PM, Oliver Neukum wrote:
>
> On Wed, 2014-10-15 at 12:11 -0400, Alan Stern wrote:
> > > If the hub is the problem… what will be the better solution? Is it
> > > possible to change internal hub?
> >
> > No, it is not possible.
>
> Indeed. However, it is possible to use
16.10.2014 14:02, Johan Hovold пишет:
On Thu, Oct 16, 2014 at 12:47:05PM +0400, Victor Ashik wrote:
Wed, Oct 15, 2014 at 6:00 PM, Johan Hovold wrote:
No, we're still supposed to support the legacy SIO type of devices,
although that code doesn't get much testing I'm afraid.
But let's start
16.10.2014 14:02, Johan Hovold пишет:
On Thu, Oct 16, 2014 at 12:47:05PM +0400, Victor Ashik wrote:
Wed, Oct 15, 2014 at 6:00 PM, Johan Hovold wrote:
No, we're still supposed to support the legacy SIO type of devices,
although that code doesn't get much testing I'm afraid.
But let's start
uac1 and uac2 functions are available through the configfs interface
and it should be possible to build them without building their legacy
gadgets.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/Kconfig | 31 +++
1 file changed, 31 insertions(+)
diff --g
The soundcard index to use for the ALSA device creation is passed as a
parameter to f_midi_bind_config(), but is assigned to midi->index only
after the call to f_midi_register_card(midi). So no matter what is passed
to f_midi_bind_config(), the actual index for snd_card_new() is always 0.
This prob
This series aims at integrating configfs into hid, the way
it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet,
mass_storage, FunctionFS, loopback, sourcesink, uac1, uac2, uvc and hid.
It concludes converting functions explicitly available as f_xyz.c files
to configfs.
Rebased
Converting midi to the new function interface requires converting
the USB midi's function code and its users.
This patch converts the f_midi.c to the new function interface.
The file can now be compiled into a separate usb_f_midi.ko module.
The old function interface is provided by means of a pre
Make the midi function available for gadgets composed with configfs.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/ABI/testing/configfs-usb-gadget-midi | 12 ++
drivers/usb/gadget/Kconfig | 14 ++
drivers/usb/gadget/function/f_midi.c | 161 +++
Use the new f_midi interface so that the old can be removed.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/legacy/Kconfig | 1 +
drivers/usb/gadget/legacy/gmidi.c | 44 ---
2 files changed, 38 insertions(+), 7 deletions(-)
diff --git a/drivers/
There are no old f_midi interface users left, so remove it.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/function/f_midi.c | 122 ---
1 file changed, 122 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c
b/drivers/usb/gadget/function/
kstrdup() might fail, so check its return value and react appropriately.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/function/f_midi.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c
b/drivers/usb/
In order to add configfs support the usb_gstrings_attach must be used.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/function/f_midi.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c
b/drivers/usb/gadget/functi
Hi,
v2: Minor change as suggested
Some mass storage devices return a bogus value in response to a Get Max LUN
request. The Iomega Jaz USB Adapter responds with 0x10, hence my recent
patch to use the US_FL_SINGLE_LUN quirk for it.
The USB MSC Bulk Only Transport document says "The device shall re
On Thu, Oct 16, 2014 at 02:55:22PM +0400, Victor Ashik wrote:
> 16.10.2014 14:02, Johan Hovold пишет:
> > On Thu, Oct 16, 2014 at 12:47:05PM +0400, Victor Ashik wrote:
> >> Wed, Oct 15, 2014 at 6:00 PM, Johan Hovold wrote:
> >
> >>> No, we're still supposed to support the legacy SIO type of devi
Excessive debug messages might cause timing issues that prevent correct
usb enumeration. This patch hides information about USB bus reset to let
driver enumerate fast enough to avoid making host angry. This fixes
endless enumeration and usb reset loop observed with some Linux hosts.
Signed-off-by:
Hi!
This patchset contains a set of fixes to solve vaious minor issues
related to cable connect/disconnect events, pull-up control,
soft-disconnect mode, proper usb phy operation and restoring gadget
state after suspend/resume cycle.
Best regards
Marek Szyprowski, PhD
Samsung R&D Institute Poland
This patch moves PHY enable and disable calls from pullup method to
udc_start/stop functions and adds calls to recently introduces soft
disconnect mode in pullup method. This improves dwc2 gadget driver
compatibility with gadget API requirements (now pullup method really
forces soft disconnect mode
This patch changes s3c_hsotg_core_init function to leave hardware in
soft disconnect mode, so the actual moment of coupling the hardware to
the usb bus can be later controlled by the driver in the more accurate
way. For this purpose, separate functions for enabling and disabling
soft disconnect mod
Enabling and disabling usb gadget by writing to
/sys/class/udc/*hsotg/soft_connect results in calling udc_start/udc_stop
functions with the same usb gadget driver, so the driver should not WARN
about such case.
Signed-off-by: Marek Szyprowski
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed,
This patch fixes probe function to match the pattern used elsewhere in
the driver, where power regulators are turned off as the last element in
the device shutdown procedure.
Signed-off-by: Marek Szyprowski
---
drivers/usb/dwc2/gadget.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
di
Suspend/resume code assumed that the gadget was always enabled and
connected to usb bus. This means that the actual state of the gadget
(soft-enabled/disabled or connected/disconnected) was not correctly
preserved on suspend/resume cycle. This patch fixes this issue.
Signed-off-by: Marek Szyprowsk
This patch adds a call to s3c_hsotg_disconnect() from 'end session'
interrupt to correctly notify gadget subsystem about unplugged usb
cable.
Signed-off-by: Marek Szyprowski
---
drivers/usb/dwc2/gadget.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/dwc2/gadget.c b/driver
This patch moves calls to phy enable/disable out of spinlock protected
blocks in device suspend/resume to fix incorrect caller context. Phy
related functions must not be called from atomic context.
Signed-off-by: Marek Szyprowski
---
drivers/usb/dwc2/gadget.c | 9 ++---
1 file changed, 6 ins
This patch removes duplicated code and sets last_rst variable in the
function which does the hardware reset.
Signed-off-by: Marek Szyprowski
---
drivers/usb/dwc2/gadget.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.
HI,
On Thu, Oct 16, 2014 at 01:11:10PM +0530, Sudip Mukherjee wrote:
> sparse was giving the following warning:
> warning: context imbalance in 's3c_hsotg_ep_enable'
> - different lock contexts for basic block
>
> we were returning ENOMEM while still holding the spinlock.
>
Hi,
On Wed, Oct 15, 2014 at 10:46:17PM -0700, Kever Yang wrote:
> This patch move clock init out of gadget into platform,
> make both hcd and gadget can use the clock
>
> Signed-off-by: Kever Yang
> ---
>
> drivers/usb/dwc2/gadget.c | 16 ++--
> drivers/usb/dwc2/hcd.c | 3 +
On Thu, Oct 16, 2014 at 02:57:57PM +0200, Marek Szyprowski wrote:
> This patch adds a call to s3c_hsotg_disconnect() from 'end session'
> interrupt to correctly notify gadget subsystem about unplugged usb
> cable.
>
> Signed-off-by: Marek Szyprowski
> ---
> drivers/usb/dwc2/gadget.c | 6 ++
>
On Wed, Oct 15, 2014 at 10:46:18PM -0700, Kever Yang wrote:
> This patch add suspend/resume for dwc2 hcd controller.
adds
> Signed-off-by: Kever Yang
> ---
>
> drivers/usb/dwc2/hcd.c | 71
> ++
> 1 file changed, 60 insertions(+), 11 deletions(-)
On Thu, Oct 16, 2014 at 02:57:58PM +0200, Marek Szyprowski wrote:
> Excessive debug messages might cause timing issues that prevent correct
> usb enumeration. This patch hides information about USB bus reset to let
> driver enumerate fast enough to avoid making host angry. This fixes
> endless enum
Hi,
On Thu, Oct 16, 2014 at 02:57:59PM +0200, Marek Szyprowski wrote:
> Enabling and disabling usb gadget by writing to
> /sys/class/udc/*hsotg/soft_connect results in calling udc_start/udc_stop
> functions with the same usb gadget driver, so the driver should not WARN
> about such case.
>
> Sign
On Thu, Oct 16, 2014 at 02:58:02PM +0200, Marek Szyprowski wrote:
> This patch changes s3c_hsotg_core_init function to leave hardware in
> soft disconnect mode, so the actual moment of coupling the hardware to
> the usb bus can be later controlled by the driver in the more accurate
what is this "m
Hi,
your subject line is wrong. ->pullup() is already implemented, you're
moving unnecessary code from ->pullup() to other places.
On Thu, Oct 16, 2014 at 02:58:03PM +0200, Marek Szyprowski wrote:
> This patch moves PHY enable and disable calls from pullup method to
> udc_start/stop functions and
Hi,
On Thu, Oct 16, 2014 at 02:58:04PM +0200, Marek Szyprowski wrote:
> This patch moves calls to phy enable/disable out of spinlock protected
> blocks in device suspend/resume to fix incorrect caller context. Phy
> related functions must not be called from atomic context.
>
> Signed-off-by: Mare
Dear USB Linux developers,
I found a problem with external USB 3 enclosure.
I hope that enough information is provided to start analysis of the
problem. I can provide more details if necessary or try patches.
Regards,
Matej
Dear usb-linux developers,
I found a problem with an external USB 3
On Thu, 16 Oct 2014, Lu, Baolu wrote:
>
> On 10/15/2014 6:07 PM, Dmitry Nezhevenko wrote:
> > On Sat, Oct 11, 2014 at 03:51:47PM +0800, Lu, Baolu wrote:
> >> Hi Dmitry,
> >>
> >> Can you please try to disable wakeup of root hub instead of host
> >> controller?
> >>
> > Hi,
> >
> > Sorry for dela
On Thu, 16 Oct 2014, Naveen Kumar Parna wrote:
> > Indeed. However, it is possible to use an additional in between your
> > devices and the internal hub.
> >
> > Regards
> > Oliver
> >
> >
>
>
> Tested with this configuration(external hubs Dev 3, Dev 4, Dev 17, Dev
> 10)
On Thu, 16 Oct 2014, Naveen Kumar Parna wrote:
> > It's entirely possible that the stall packets are created by the hub.
> > When a full-speed device is connected to a USB-2 hub, and the device
> > fails to respond to a packet sent by the host, the hub reports this
> > failure as a stall.
>
> Her
On Thu, Oct 16, 2014 at 08:21:55AM -0500, Felipe Balbi wrote:
> HI,
>
> On Thu, Oct 16, 2014 at 01:11:10PM +0530, Sudip Mukherjee wrote:
> > sparse was giving the following warning:
> > warning: context imbalance in 's3c_hsotg_ep_enable'
> > - different lock contexts for basic
On Thu, Oct 16, 2014 at 08:22:08PM +0530, Sudip Mukherjee wrote:
> On Thu, Oct 16, 2014 at 08:21:55AM -0500, Felipe Balbi wrote:
> > HI,
> >
> > On Thu, Oct 16, 2014 at 01:11:10PM +0530, Sudip Mukherjee wrote:
> > > sparse was giving the following warning:
> > > warning: context imbalance
On Thu, 2014-10-16 at 15:58 +0200, Matej Kenda wrote:
> Dear USB Linux developers,
>
> I found a problem with external USB 3 enclosure.
>
> I hope that enough information is provided to start analysis of the
> problem. I can provide more details if necessary or try patches.
Is this a regression?
Ok, I will do this and update you.
But Currently I am on long leave and I can update you on 27th Oct.
Thanks,
Naveen
On Thu, Oct 16, 2014 at 7:39 PM, Alan Stern wrote:
> On Thu, 16 Oct 2014, Naveen Kumar Parna wrote:
>
>> > Indeed. However, it is possible to use an additional in between your
>>
Hi,
usb_stor_euscsi_init() enables multi-target mode for SCM eUSB SCSI bridge
devices. The control message it sends has wLength = 1 and the byte sent is
0x01. While that works, the SCM driver does it with wLength = 0. We may as
well match what the SCM driver does.
This also includes the change fr
Hi Oliver,
> On 16. okt. 2014, at 17:02, Oliver Neukum wrote:
>
>> On Thu, 2014-10-16 at 15:58 +0200, Matej Kenda wrote:
>> Dear USB Linux developers,
>>
>> I found a problem with external USB 3 enclosure.
>
> Is this a regression? Did you test any (older) other kernel?
The problem was origin
On Thu, Oct 16, 2014 at 7:46 PM, Alan Stern wrote:
> On Thu, 16 Oct 2014, Naveen Kumar Parna wrote:
>
>> > It's entirely possible that the stall packets are created by the hub.
>> > When a full-speed device is connected to a USB-2 hub, and the device
>> > fails to respond to a packet sent by the h
Hi,
While investigating a USB performance problem, I observed the same
issue as described in [1], which is that xHCI takes 10-15 times longer
than EHCI to send the IN packet after received NAK - 20-30us vs. 2us.
Does anyone have any comment? I am wondering if the xHCI IPD is sw
configurable? Migh
Remove unnecessary mach/* headers to be able to converge to a multiplatform
kernel.
Signed-off-by: Alexandre Belloni
---
drivers/usb/host/ohci-at91.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index e49eb4f90f5d..6181549883a
Hi,
I apologise for a typo.
On 16. okt. 2014, at 17:15, Matej Kenda wrote:
> The problem was originaly discovered on 3.13, then I tested on 3.14, 3.16 and
> 3.17.
>
> It did work on any of these kernels.
Correction:
It did *not work* on any of these kernels.
Regards,
Matej
--
To unsubs
Hi Felipe,
Thank for comment.
On 10/16/2014 06:23 AM, Felipe Balbi wrote:
Hi,
On Wed, Oct 15, 2014 at 10:46:17PM -0700, Kever Yang wrote:
This patch move clock init out of gadget into platform,
make both hcd and gadget can use the clock
Signed-off-by: Kever Yang
---
drivers/usb/dwc2/
Hi Felipe,
On 10/16/2014 06:30 AM, Felipe Balbi wrote:
On Wed, Oct 15, 2014 at 10:46:18PM -0700, Kever Yang wrote:
This patch add suspend/resume for dwc2 hcd controller.
adds
Signed-off-by: Kever Yang
---
drivers/usb/dwc2/hcd.c | 71 ++
1
On Thu, Oct 16, 2014 at 05:52:38PM +0200, Alexandre Belloni wrote:
> Remove unnecessary mach/* headers to be able to converge to a multiplatform
> kernel.
>
> Signed-off-by: Alexandre Belloni
Very nice
Reviewed-by: Felipe Balbi
> ---
> drivers/usb/host/ohci-at91.c | 4
> 1 file changed,
On Thu, Oct 16, 2014 at 09:41:27AM -0700, Kever Yang wrote:
> Hi Felipe,
>
> Thank for comment.
>
> On 10/16/2014 06:23 AM, Felipe Balbi wrote:
> >Hi,
> >
> >On Wed, Oct 15, 2014 at 10:46:17PM -0700, Kever Yang wrote:
> >>This patch move clock init out of gadget into platform,
> >>make both h
Hi,
On Thu, Oct 16, 2014 at 09:51:38AM -0700, Kever Yang wrote:
> >>This patch add suspend/resume for dwc2 hcd controller.
> >adds
> >
> >>Signed-off-by: Kever Yang
> >>---
> >>
> >> drivers/usb/dwc2/hcd.c | 71
> >> ++
> >> 1 file changed, 60 ins
Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e,
"USB: kobil_sct: fix control requests without data stage", removed
the bogus data buffer arguments, but still allocate transfer
buffers which are not used.
Cc: Johan Hovold
Signed-off-by: Peter Hurley
---
drivers/usb/serial/kobil_sct.c | 15 -
On 10/16/2014 01:59 PM, Peter Hurley wrote:
> Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e,
> "USB: kobil_sct: fix control requests without data stage", removed
> the bogus data buffer arguments, but still allocate transfer
> buffers which are not used.
>
> Cc: Johan Hovold
> Signed-off-by: Pe
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> Sent: Thursday, October 16, 2014 7:52 AM
>
> On Thu, Oct 16, 2014 at 08:21:55AM -0500, Felipe Balbi wrote:
> > HI,
> >
> > On Thu, Oct 16, 2014 at 01:11:10PM +0530, Sudip Mukherjee wrote:
> > > sparse was giving the following warning:
>
We need this for dwc2 to work on older ralink SoC like the rt3052. Without, we
see the following when loading the driver:
[0.76] dwc2 101c.usb: Bad value for GSNPSID: 0x
Signed-off-by: John Crispin
---
Changes since V1
* move the OF lookup call into the platform code
* add co
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of John Crispin
> Sent: Thursday, October 16, 2014 1:34 PM
>
> We need this for dwc2 to work on older ralink SoC like the rt3052. Without, we
> see the following when loading the driver:
>
> [0.76000
Hi,
This patch does two things for SCM eUSCSI USB-SCSI converters:
1. SCM eUSCSI bridge devices are hard-wired to use SCSI ID 7. On connecting
the converter, access to that ID is attempted during the bus scan. Asking
the converter to issue INQUIRY commands to itself isn't very polite and
wastes t
Is there a move afoot to write a checker utility that determines if the
usb device its pointed at is vulnerable, and can therefore be reliably
blacklisted?
>From what I've read, the real fix will be a standards rewrite, and once
fixed units are in the supply chains, replace what we have. The ma
On Thu, Oct 16, 2014 at 06:12:48PM -0400, Gene Heskett wrote:
> Is there a move afoot to write a checker utility that determines if the
> usb device its pointed at is vulnerable, and can therefore be reliably
> blacklisted?
What do you mean by a "vulnerable" USB device?
--
To unsubscribe from t
On Thursday 16 October 2014 18:28:16 Greg KH did opine
And Gene did reply:
> On Thu, Oct 16, 2014 at 06:12:48PM -0400, Gene Heskett wrote:
> > Is there a move afoot to write a checker utility that determines if
> > the usb device its pointed at is vulnerable, and can therefore be
> > reliably black
sparse was giving the following warning:
warning: context imbalance in 's3c_hsotg_ep_enable'
- different lock contexts for basic block
we were returning ENOMEM while still holding the spinlock.
The sparse warning was fixed by releasing the spinlock before return.
S
modified the function to have a single return statement at the end
instead of multiple return statement in the middle of the function
to improve the readability of the code.
This patch depends on the previous patch of the series.
Signed-off-by: Sudip Mukherjee
---
drivers/usb/dwc2/gadget.c | 4
It would cause dead lock for runtime suspend, when the workqueue
is running and runtime suspend occurs before the workqueue wakes
up the device. The rtl8152_suspend() waits the workqueue to finish
because of calling cancel_delayed_work_sync(). The workqueue waits
the suspend function to finish for
Gene Heskett wrote:
> On Thursday 16 October 2014 18:28:16 Greg KH did opine
> And Gene did reply:
>> On Thu, Oct 16, 2014 at 06:12:48PM -0400, Gene Heskett wrote:
>>> Is there a move afoot to write a checker utility that determines if
>>> the usb device its pointed at is vulnerable, and can theref
81 matches
Mail list logo
