Re: xhci_hcd can't detect new devices after enabling runtime PM and disabling S3 wake (bug #85701)

2014-10-11 Thread Lu, Baolu
Hi Dmitry, Can you please try to disable wakeup of root hub instead of host controller? Regards, -baolu On 10/10/2014 3:16 PM, Dmitry Nezhevenko wrote: On Wed, Oct 08, 2014 at 12:38:35PM -0400, Alan Stern wrote: Dmitry, this gave me another idea. Can you test the patch below, _without_ the p

How to verify xhci command ring abort behavior

2014-10-11 Thread Huang Rui
Hi Mathias, Alan, I would like to verify the cmd abort sequence. As you know, it should create a scenario to make the CMD execution timeout. Then driver will handle xhci_handle_command_timeout. But it is hard to make a CMD execution timeout, so I find a area of command execution such as "enable sl

[PATCH] usb: serial: Fix indentation style issue

2014-10-11 Thread Philip Munksgaard
Fix a style issue Signed-off-by: Philip Munksgaard --- drivers/usb/serial/option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index d1a3f60..d88998d 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/seria

Re: RCU bug with v3.17-rc3 ?

2014-10-11 Thread Russell King - ARM Linux
On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote: > On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote: > > We can blacklist these GCC versions quite easily. We already have GCC > > 3.3 blacklisted, and it's trivial to add others. I would want to include > > some proper details ab

Re: RCU bug with v3.17-rc3 ?

2014-10-11 Thread Russell King - ARM Linux
On Sat, Oct 11, 2014 at 11:54:32AM +0800, Peter Chen wrote: > On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote: > > On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote: > > > > > > Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and > > > it seems that this has b

Re: [PATCH] usb: serial: Fix indentation style issue

2014-10-11 Thread Greg KH
On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: > Fix a style issue > > Signed-off-by: Philip Munksgaard > --- > drivers/usb/serial/option.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > in

Re: [PATCH v3 1/2] usb: ehci: add port_power callback and override

2014-10-11 Thread Alan Stern
On Sat, 11 Oct 2014, Peter Chen wrote: > > > + u32 __iomem *status_reg = &ehci->regs->port_status[portnum]; > > > + u32 status = ehci_readl(ehci, status_reg); > > > + > > > + if (enable) > > > + ehci_writel(ehci, status | PORT_POWER, status_reg); > > > + else > > > + ehci_writel(eh

Re: [PATCH] usb: serial: Fix indentation style issue

2014-10-11 Thread Lars Melin
On 2014-10-11 21:20, Greg KH wrote: On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: Fix a style issue Signed-off-by: Philip Munksgaard --- drivers/usb/serial/option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/option.c b/drivers

Re: RCU bug with v3.17-rc3 ?

2014-10-11 Thread Otavio Salvador
Hello Russell, On Sat, Oct 11, 2014 at 11:16 AM, Russell King - ARM Linux wrote: > On Sat, Oct 11, 2014 at 11:54:32AM +0800, Peter Chen wrote: >> On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote: >> > On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote: >> > > >> > > Right, so GCC

Re: [PATCH 1/2] USB: OHCI: Eliminate platform-specific test in ohci.h

2014-10-11 Thread Alan Stern
On Fri, 10 Oct 2014, Kevin Cernekee wrote: > OHCI_QUIRK_FRAME_NO is currently set under either of the following > conditions: > > 1) If a ppc-of-ohci DT node indicates a compatible string of > "fsl,mpc5200-ohci" or "mpc5200-ohci" > > 2) If usb_ohci_pdata->no_big_frame_no is set > > For #1, the

Re: [PATCH 2/2] USB: ohci-platform: Expose no_big_frame_no and num_ports in DT

2014-10-11 Thread Alan Stern
On Fri, 10 Oct 2014, Kevin Cernekee wrote: > These quirks are currently set through platform_data; allow DT-based SoCs > to use them too. It looks strange to have the platform_data version of the quirks set in one routine and the DT version set in a different routine. Is there any reason not t

[PATCH v2] usb: serial: Fix indentation style issue

2014-10-11 Thread Philip Munksgaard
Fix a style issue. Signed-off-by: Philip Munksgaard --- drivers/usb/serial/option.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index d1a3f60..64ddc00 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/se

Re: [PATCH 1/2] USB: OHCI: Eliminate platform-specific test in ohci.h

2014-10-11 Thread Kevin Cernekee
On Sat, Oct 11, 2014 at 7:58 AM, Alan Stern wrote: > On Fri, 10 Oct 2014, Kevin Cernekee wrote: > >> OHCI_QUIRK_FRAME_NO is currently set under either of the following >> conditions: >> >> 1) If a ppc-of-ohci DT node indicates a compatible string of >> "fsl,mpc5200-ohci" or "mpc5200-ohci" >> >> 2)

Re: [PATCH 1/2] USB: OHCI: Eliminate platform-specific test in ohci.h

2014-10-11 Thread Alan Stern
On Sat, 11 Oct 2014, Kevin Cernekee wrote: > On Sat, Oct 11, 2014 at 7:58 AM, Alan Stern wrote: > > On Fri, 10 Oct 2014, Kevin Cernekee wrote: > > > >> OHCI_QUIRK_FRAME_NO is currently set under either of the following > >> conditions: > >> > >> 1) If a ppc-of-ohci DT node indicates a compatible

Re: [PATCH] usb: serial: Fix indentation style issue

2014-10-11 Thread Joe Perches
On Sat, 2014-10-11 at 07:20 -0700, Greg KH wrote: > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: > > Fix a style issue [] > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c [] > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {

Re: [PATCH 2/2] USB: ohci-platform: Expose no_big_frame_no and num_ports in DT

2014-10-11 Thread Kevin Cernekee
On Sat, Oct 11, 2014 at 8:09 AM, Alan Stern wrote: > On Fri, 10 Oct 2014, Kevin Cernekee wrote: > >> These quirks are currently set through platform_data; allow DT-based SoCs >> to use them too. > > It looks strange to have the platform_data version of the quirks set in > one routine and the DT ve

[PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Jonas Brunsgaard
Signed-off-by: Jonas Brunsgaard --- drivers/usb/atm/ueagle-atm.c | 95 1 file changed, 42 insertions(+), 53 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 5a45937..eedb217 100644 --- a/drivers/usb/atm/ueagl

[PATCH 00/12] dmaengine: remove users of device_control

2014-10-11 Thread Vinod Koul
The recent discussion [1] on the API have resulted in moving away from device_control ioctl method to proper channel APIs. There are still few users on the device_control which should use the wrappers existing rather than access device_control. This will aid us in deprecating and removing device_co

[PATCH 10/12] usb: musb: ux500_dma: use dmaengine_xxx() APIs

2014-10-11 Thread Vinod Koul
The drivers should use dmaengine_terminate_all() or dmaengine_slave_config() API instead of accessing the device_control which will be deprecated soon Signed-off-by: Vinod Koul --- drivers/usb/musb/ux500_dma.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers

Re: [PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Lars Melin
On 2014-10-11 23:02, Jonas Brunsgaard wrote: Signed-off-by: Jonas Brunsgaard --- drivers/usb/atm/ueagle-atm.c | 95 1 file changed, 42 insertions(+), 53 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 5a

Re: [PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Joe Perches
On Sun, 2014-10-12 at 00:00 +0700, Lars Melin wrote: > On 2014-10-11 23:02, Jonas Brunsgaard wrote: > > Signed-off-by: Jonas Brunsgaard [] > > diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c [ 15 KB of quoted stuff ] > Read: > https://www.kernel.org/doc/Documentation/Cod

Re: [PATCH 2/2] USB: ohci-platform: Expose no_big_frame_no and num_ports in DT

2014-10-11 Thread Alan Stern
On Sat, 11 Oct 2014, Kevin Cernekee wrote: > On Sat, Oct 11, 2014 at 8:09 AM, Alan Stern wrote: > > On Fri, 10 Oct 2014, Kevin Cernekee wrote: > > > >> These quirks are currently set through platform_data; allow DT-based SoCs > >> to use them too. > > > > It looks strange to have the platform_dat

Re: [PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Jonas Brunsgaard
On Sat, Oct 11, 2014 at 7:00 PM, Lars Melin wrote: > On 2014-10-11 23:02, Jonas Brunsgaard wrote: >> >> Signed-off-by: Jonas Brunsgaard >> --- >> drivers/usb/atm/ueagle-atm.c | 95 >> >> 1 file changed, 42 insertions(+), 53 deletions(-) >> >> diff -

Re: [PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Lars Melin
On 2014-10-12 00:28, Jonas Brunsgaard wrote: Could you be more specific, what is it you dislike? After this patch the checkpatch script only come up with a couple of warnings, all due to the line length limit, and these warnings are all acceppable as they improve the ability to grep for user read

[PATCH v2 1/3] USB: OHCI: Eliminate platform-specific test in ohci.h

2014-10-11 Thread Kevin Cernekee
The bcm63xx and bcm3384 platforms need to set OHCI_QUIRK_FRAME_NO, but they are non-PPC platforms and don't enable CONFIG_PPC_MPC52xx. Therefore this patch changes the code that uses OHCI_QUIRK_FRAME_NO, making it not depend on CONFIG_PPC_MPC52xx. Also, rephrase the comments describing OHCI_QUIRK_

[PATCH v2 2/3] USB: ohci-platform: Expose no_big_frame_no and num_ports in DT

2014-10-11 Thread Kevin Cernekee
These quirks are currently set through platform_data; allow DT-based SoCs to use them too. Signed-off-by: Kevin Cernekee --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 2 ++ drivers/usb/host/ohci-platform.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/Do

[PATCH v2 3/3] USB: ohci-platform: Move platform_data checks into the probe function

2014-10-11 Thread Kevin Cernekee
This puts all of the platform_data checks in the same place, and removes the need for a custom drv->reset() callback. Signed-off-by: Kevin Cernekee --- drivers/usb/host/ohci-platform.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/usb/host/ohci-

Re: RCU bug with v3.17-rc3 ?

2014-10-11 Thread Peter Hurley
On 10/11/2014 10:51 AM, Otavio Salvador wrote: > Hello Russell, > > On Sat, Oct 11, 2014 at 11:16 AM, Russell King - ARM Linux > wrote: >> On Sat, Oct 11, 2014 at 11:54:32AM +0800, Peter Chen wrote: >>> On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote: On 10/10/2014 11:25 AM, Rus

Re: RCU bug with v3.17-rc3 ?

2014-10-11 Thread Nathan Lynch
On 10/10/2014 08:44 PM, Nathan Lynch wrote: > On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote: >> >> Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and >> it seems that this has been known about for some time.) > > Looking at http://gcc.gnu.org/PR58854 it seems that all

Please reply

2014-10-11 Thread Jose Calvache
Dear Sir/Madam, Here is a pdf attachment of my proposal to you. Please read and reply I would be grateful. Jose Calvache -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majo

Re: [PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Greg KH
On Sat, Oct 11, 2014 at 06:02:48PM +0200, Jonas Brunsgaard wrote: > Signed-off-by: Jonas Brunsgaard > --- > drivers/usb/atm/ueagle-atm.c | 95 > > 1 file changed, 42 insertions(+), 53 deletions(-) Your Subject: doesn't seem to make sense, please fix

Re: [PATCH] usb: serial: Fix indentation style issue

2014-10-11 Thread Greg KH
On Sat, Oct 11, 2014 at 08:36:33AM -0700, Joe Perches wrote: > On Sat, 2014-10-11 at 07:20 -0700, Greg KH wrote: > > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: > > > Fix a style issue > [] > > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > [] > >

Re: [PATCH 10/12] usb: musb: ux500_dma: use dmaengine_xxx() APIs

2014-10-11 Thread Greg Kroah-Hartman
On Sat, Oct 11, 2014 at 09:10:38PM +0530, Vinod Koul wrote: > The drivers should use dmaengine_terminate_all() or dmaengine_slave_config() > API instead of accessing the device_control which will be deprecated soon > > Signed-off-by: Vinod Koul Acked-by: Greg Kroah-Hartman -- To unsubscribe fro

[PATCH v2] usb: atm: fix style issues

2014-10-11 Thread Jonas Brunsgaard
Signed-off-by: Jonas Brunsgaard --- drivers/usb/atm/ueagle-atm.c | 95 1 file changed, 42 insertions(+), 53 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 5a45937..eedb217 100644 --- a/drivers/usb/atm/ueagl

Re: [PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Jonas Brunsgaard
On Sat, Oct 11, 2014 at 10:17 PM, Greg KH wrote: > On Sat, Oct 11, 2014 at 06:02:48PM +0200, Jonas Brunsgaard wrote: >> Signed-off-by: Jonas Brunsgaard >> --- >> drivers/usb/atm/ueagle-atm.c | 95 >> >> 1 file changed, 42 insertions(+), 53 deletions(

Re: [PATCH 10/12] usb: musb: ux500_dma: use dmaengine_xxx() APIs

2014-10-11 Thread Felipe Balbi
Hi, On Sat, Oct 11, 2014 at 09:10:38PM +0530, Vinod Koul wrote: > The drivers should use dmaengine_terminate_all() or dmaengine_slave_config() > API instead of accessing the device_control which will be deprecated soon > > Signed-off-by: Vinod Koul awesome. It looks like it doesn't have a direc

Re: [PATCH] usb: serial: Fix indentation style issue

2014-10-11 Thread Joe Perches
On Sat, 2014-10-11 at 13:19 -0700, Greg KH wrote: > On Sat, Oct 11, 2014 at 08:36:33AM -0700, Joe Perches wrote: > > On Sat, 2014-10-11 at 07:20 -0700, Greg KH wrote: > > > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: > > > > Fix a style issue > > [] > > > > diff --git a/drive

xhci locks up kernel with NULL pointer dereference when waking external USB3 hard drive from standby

2014-10-11 Thread rocko r
Since kernel 3.15-rc5 (rc4 is good), my laptop locks up completely when trying to wake my WD 1230 USB3 external hard drive from its default 10-minute standby. The bug is still present in 3.17. The system tries to wake up the drive, which is unsuccessful, and after a few seconds uas_eh_abort_handle