Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Arnd Bergmann
On Wednesday 24 September 2014 10:27:52 Peter Chen wrote: > > Antoine is adding a generic chipdea glue layer driver, which like ehci generic > platform driver: drivers/usb/host/ehci-platform.c, since other architectures > like MIPS (Someone submitted mips chipidea driver before) may not have devic

[resend PATCH] usb: dwc3: pci: Add PCI ID for Intel Braswell

2014-09-24 Thread Heikki Krogerus
From: Alan Cox The device controller is the same but it has different PCI ID. Add this new ID to the driver's list of supported IDs. Signed-off-by: Alan Cox Signed-off-by: Mika Westerberg Signed-off-by: Heikki Krogerus --- drivers/usb/dwc3/dwc3-pci.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH 0/2] USB: core: add add device-qualifier quirk

2014-09-24 Thread Greg Kroah-Hartman
On Tue, Sep 23, 2014 at 05:27:22PM +0200, Johan Hovold wrote: > On Tue, Sep 23, 2014 at 08:21:51AM -0700, Greg Kroah-Hartman wrote: > > On Tue, Sep 23, 2014 at 04:56:24PM +0200, Johan Hovold wrote: > > > On Mon, Aug 25, 2014 at 05:51:25PM +0200, Johan Hovold wrote: > > > > This is quirk is indeed n

[resend PATCH 2/3] usb: dwc3: core: only setting the dma_mask when needed

2014-09-24 Thread Heikki Krogerus
If the probe drivers have already set the dma_mask, not replacing the value. Signed-off-by: Heikki Krogerus --- drivers/usb/dwc3/core.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index b0f4d52..d08cac5 100644 ---

[resend PATCH 1/3] ACPI / platform: provide default DMA mask

2014-09-24 Thread Heikki Krogerus
Most devices are configured for 32-bit DMA addresses. Setting the mask to 32-bit here removes the need for the drivers to do it separately. Signed-off-by: Heikki Krogerus Cc: "Rafael J. Wysocki" --- drivers/acpi/acpi_platform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/acpi/

[resend PATCH 0/3] usb: dwc3: ACPI support

2014-09-24 Thread Heikki Krogerus
Hi, The original series included patch that adds Braswell PCI ID, but I send it separately. The DMA mask caused a problem as our acpi platform code does not provide anything for us. Instead of trying to fix it in dwc3 I decided to suggest the first patch in this series where I provide default DMA

[resend PATCH 3/3] usb: dwc3: add ACPI support

2014-09-24 Thread Heikki Krogerus
Adds ACPI ID used on newer Intel SoCs. Signed-off-by: Heikki Krogerus --- drivers/usb/dwc3/core.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index d08cac5..c2cf2d8 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/c

Re: [PATCH] drivers: usb: fsl: Check IP version 2.4 for mph USB controller

2014-09-24 Thread Greg KH
On Thu, Aug 21, 2014 at 12:43:30PM +0530, Nikhil Badola wrote: > Check 2.4 IP version for multi port host USB controller and > return FSL_USB_VER_2_4 macro > > Signed-off-by: Nikhil Badola > --- > drivers/usb/host/fsl-mph-dr-of.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drive

Re: [PATCH] drivers: usb :fsl: Add support for USB controller version-2.5

2014-09-24 Thread Greg KH
On Thu, Aug 21, 2014 at 12:56:22PM +0530, Nikhil Badola wrote: > Add support for USB controller version-2.5 used in > T4240 rev2.0, T1024, B3421, T1040, T2080, LS1021A. > > Signed-off-by: Nikhil Badola > --- > - Depends on commit 990c2c7829d98517228f2b2ff14919c83b75e124 > drivers: u

Re: [PATCH] drivers: usb :fsl: Add support for USB controller version-2.5

2014-09-24 Thread Greg KH
On Thu, Aug 21, 2014 at 12:56:22PM +0530, Nikhil Badola wrote: > Add support for USB controller version-2.5 used in > T4240 rev2.0, T1024, B3421, T1040, T2080, LS1021A. > > Signed-off-by: Nikhil Badola > --- > - Depends on commit 990c2c7829d98517228f2b2ff14919c83b75e124 > drivers: u

Re: [PATCH fix for 3.17 v5] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-24 Thread Greg Kroah-Hartman
On Mon, Sep 15, 2014 at 04:13:52PM +0200, Hans de Goede wrote: > Hi, > > On 09/15/2014 04:08 PM, Greg Kroah-Hartman wrote: > > On Mon, Sep 15, 2014 at 04:04:12PM +0200, Hans de Goede wrote: > >> And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one > >> seems to hang upon rece

Re: [PATCH 1/1] Added support for Seluxit USB dongle to cp210x driver.

2014-09-24 Thread Greg KH
On Mon, Sep 22, 2014 at 10:52:56AM +0200, Johan Hovold wrote: > On Mon, Sep 22, 2014 at 09:50:43AM +0200, Andreas Bomholtz wrote: > > Added the Seluxit ApS USB Serial Dongle to cp210x driver. > > > > Signed-off-by: Andreas Bomholtz > > --- > > Thanks for resending. Applied just fine now. Was th

Re: [RFC PATCH 2/2] usb-core: Remove the local_irq_save/local_irq_restore around complete

2014-09-24 Thread Greg KH
On Mon, Sep 15, 2014 at 10:22:49AM -0500, dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > When enabling HCD_BH for the DWC2 HCD, these local_irq_save/local_irq_restore > was causing a timeout with a webcam. > > Signed-off-by: Dinh Nguyen > --- > drivers/usb/core/hcd.c | 2 -- > 1

Re: [PATCH v5 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Greg KH
On Fri, Sep 05, 2014 at 01:42:09AM +0400, Sergei Shtylyov wrote: > From: Antoine Tenart > > The USB PHY member of the HCD structure is renamed to 'usb_phy' and > modifications are done in all drivers accessing it. > This is in preparation to adding the generic PHY support. > > Signed-off-by: Ant

Re: [PATCH] Replace a single-value sscanf() call with a call to kstrtou32(), as recommended by checkpatch.pl.

2014-09-24 Thread Greg KH
On Sat, Sep 06, 2014 at 11:12:27PM -0400, Lars R. Damerow wrote: > Signed-off-by: Lars R. Damerow No changelog body? Also, the subject should have usb and vhci_sysfs somewhere in there, right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: [PATCH] storage: Replace magic number with define in usb_stor_euscsi_init()

2014-09-24 Thread Greg KH
On Sun, Sep 21, 2014 at 07:59:42PM +0100, Mark wrote: > Hi, > > usb_stor_euscsi_init() calls usb_stor_control_msg() with timeout argument > 5000. USB_CTRL_SET_TIMEOUT is defined to be 5000 in usb.h, so would it make > sense to use that instead? Patch below if it would. > > Signed-off-by: Mark Kni

Re: [PATCH v3 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard

2014-09-24 Thread Greg Kroah-Hartman
On Fri, Sep 19, 2014 at 10:13:50AM +0800, Lu Baolu wrote: > This full-speed USB device generates spurious remote wakeup event > as soon as USB_DEVICE_REMOTE_WAKEUP feature is set. As the result, > Linux can't enter system suspend and S0ix power saving modes once > this keyboard is used. > > This p

Re: [PATCH v3 0/6] usb: hub: convert khubd into workqueue

2014-09-24 Thread Greg Kroah-Hartman
On Sat, Sep 20, 2014 at 08:41:21PM +, Paul Zimmerman wrote: > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern > > Sent: Friday, September 19, 2014 12:39 PM > > > > On Fri, 19 Sep 2014, Petr Mladek wrote: > > > > > The 3rd version o

Re: [PATCH v2] usb: core: downgrade log severity to info when descriptor unavailable

2014-09-24 Thread Greg Kroah-Hartman
On Tue, Sep 23, 2014 at 07:12:40PM +, Scot Doyle wrote: > According to commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0 > USB: fix LANGID=0 regression > > usb devices are not required to report string descriptors. Since they are > optional, log an info message instead of an error message. >

Re: [RFC PATCH] usb: core: log more general message on malformed LANGID descriptor

2014-09-24 Thread Greg Kroah-Hartman
On Tue, Sep 23, 2014 at 10:28:49PM +, Scot Doyle wrote: > I'd like to change this error message: > [3.325837] usb 1-4: string descriptor 0 malformed (err = -61), defaulting > to 0x0409 > > into an error message followed by a debug message: > [3.324726] usb 1-4: malformed string descri

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Arnd Bergmann
On Wednesday 24 September 2014 09:44:19 Arnd Bergmann wrote: > > We can also gradually move in some of the other glue drivers into > the main driver if the differences are small enough. > FWIW, I've just looked at the other glue drivers that already exist: - zevio can just get merged into the c

[GIT PULL] USB-serial fixes for v3.17-final

2014-09-24 Thread Johan Hovold
Hi Greg, Here are two more device ids for v3.17-final. Thanks, Johan The following changes since commit 9e82bf014195d6f0054982c463575cdce24292be: Linux 3.17-rc5 (2014-09-14 17:50:12 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-ser

Re: [PATCH 1/1] Added support for Seluxit USB dongle to cp210x driver.

2014-09-24 Thread Johan Hovold
On Tue, Sep 23, 2014 at 09:44:48PM -0700, Greg Kroah-Hartman wrote: > On Mon, Sep 22, 2014 at 10:52:56AM +0200, Johan Hovold wrote: > > On Mon, Sep 22, 2014 at 09:50:43AM +0200, Andreas Bomholtz wrote: > > > Added the Seluxit ApS USB Serial Dongle to cp210x driver. > > > > > > Signed-off-by: Andre

Re: [PATCH v5 3/4] gpiolib: add irq_not_threaded flag to gpio_chip

2014-09-24 Thread Linus Walleij
On Fri, Sep 19, 2014 at 10:22 PM, Octavian Purdila wrote: > Some GPIO chips (e.g. the DLN2 USB adapter) have blocking get/set > operation but do not need a threaded irq handler. > > Signed-off-by: Octavian Purdila Usually I don't apply patches adding interfaces with no users, but this seems ver

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Michal Nazarewicz
On Wed, Sep 24 2014, Heiko Schocher wrote: > use the values for RNDIS over Ethernet as defined in > http://www.usb.org/developers/defined_class > (search for RDNIS): > > - baseclass: 0xef (miscellaneous) > - subclass: 0x04 > - protocol: 0x01 > > with this setings the file in Documentation/usb/linu

Re: [PATCH 2/6] phy: improved lookup method

2014-09-24 Thread Kishon Vijay Abraham I
Hi, On Tuesday 23 September 2014 05:13 PM, Heikki Krogerus wrote: > On Tue, Sep 23, 2014 at 04:33:09PM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 23 September 2014 04:23 PM, Heikki Krogerus wrote: >>> On Mon, Sep 22, 2014 at 05:07:55PM +0530, Kishon Vijay Abraham I wrote: On

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Lee Jones
On Mon, 22 Sep 2014, Octavian Purdila wrote: > Currently the I/O buffer is allocated part of the device status > structure, potentially sharing the same cache line with other members > in this structure. > > Allocate the buffer separately, to avoid the I/O operations corrupting > the device statu

Re: [PATCH v2 2/2] mfd: viperboard: remove redundant OOM message and NULL pointer check

2014-09-24 Thread Lee Jones
On Mon, 22 Sep 2014, Octavian Purdila wrote: > Signed-off-by: Octavian Purdila > --- > drivers/mfd/viperboard.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) Looks fine, but won't apply without patch 1. > diff --git a/drivers/mfd/viperboard.c b/drivers/mfd/viperboard.c >

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: > On Mon, 22 Sep 2014, Octavian Purdila wrote: > > > Currently the I/O buffer is allocated part of the device status > > structure, potentially sharing the same cache line with other members > > in this structure. > > > > Allocate the buf

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Johan Hovold
On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote: > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > Master Adapter DLN-2. Details about the device can be found here: > > https://www.diolan.com/i2c/i2c_interface.html. > > Information about the USB protocol can b

Re: [PATCH v5 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-24 Thread Johan Hovold
On Fri, Sep 19, 2014 at 11:22:43PM +0300, Octavian Purdila wrote: > +struct dln2_i2c { > + struct platform_device *pdev; > + struct i2c_adapter adapter; > + u32 freq; > + u32 min_freq; > + u32 max_freq; > + /* > + * Buffer to hold the packet for read or write transfers

Re: [PATCH v5 3/4] gpiolib: add irq_not_threaded flag to gpio_chip

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 10:54:51AM +0200, Linus Walleij wrote: > On Fri, Sep 19, 2014 at 10:22 PM, Octavian Purdila > wrote: > > > Some GPIO chips (e.g. the DLN2 USB adapter) have blocking get/set > > operation but do not need a threaded irq handler. > > > > Signed-off-by: Octavian Purdila > >

[PATCH] USB: Remove .owner field for driver

2014-09-24 Thread Kiran Padwal
There is no need to init .owner field. Based on the patch from Peter Griffin "mmc: remove .owner field for drivers using module_platform_driver" This patch removes the superflous .owner field for drivers which use the module_platform_driver API, as this is overriden in platform_driver_register a

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Peter Chen
On Wed, Sep 24, 2014 at 10:30:41AM +0200, Arnd Bergmann wrote: > On Wednesday 24 September 2014 09:44:19 Arnd Bergmann wrote: > > > > We can also gradually move in some of the other glue drivers into > > the main driver if the differences are small enough. > > > > FWIW, I've just looked at the o

Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-09-24 Thread Mark Knibbs
Hi, I did some benchmarks to check the maximum transfer rate of a USB-to-SCSI converter. The converter is USB 1.1, so limited to the 12Mbps full speed rate. The performance when connected to a USB 3.0 port is significantly worse than when connected to a USB 2.0 port, about 26.5% slower (0.63MB/sec

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Lee Jones
On Wed, 24 Sep 2014, Johan Hovold wrote: > On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: > > On Mon, 22 Sep 2014, Octavian Purdila wrote: > > > > > Currently the I/O buffer is allocated part of the device status > > > structure, potentially sharing the same cache line with other memb

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Arnd Bergmann
On Wednesday 24 September 2014 19:29:05 Peter Chen wrote: > > So, it is IP CORE LIB (you suggest) vs IP CORE Platform Driver > (dwc3, musb, chipidea) you are talking about, right? Except for > creating another platform driver as well as related DT node (optional), > are there any advantages compar

[PATCH][RFC] storage: Simplify condition to reject bad target in usb_stor_control_thread()

2014-09-24 Thread Mark Knibbs
Hi, This follows on from something I mentioned in my recent post "[PATCH] storage: Don't scan target 7 for SCM USB-SCSI converters". In drivers/usb/storage/usb.c, usb_stor_control_thread(): /* reject if target != 0 or if LUN is higher than * the maximum known LUN */

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Lars Melin
On 2014-09-24 13:48, Heiko Schocher wrote: use the values for RNDIS over Ethernet as defined in http://www.usb.org/developers/defined_class (search for RDNIS): - baseclass: 0xef (miscellaneous) - subclass: 0x04 - protocol: 0x01 That is usb class, it is not the same thing as communication devic

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 01:00:02PM +0100, Lee Jones wrote: > On Wed, 24 Sep 2014, Johan Hovold wrote: > > > On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: > > > On Mon, 22 Sep 2014, Octavian Purdila wrote: > > > > > > > Currently the I/O buffer is allocated part of the device status >

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Octavian Purdila
On Wed, Sep 24, 2014 at 3:26 PM, Johan Hovold wrote: > On Wed, Sep 24, 2014 at 01:00:02PM +0100, Lee Jones wrote: >> On Wed, 24 Sep 2014, Johan Hovold wrote: >> >> > On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: >> > > On Mon, 22 Sep 2014, Octavian Purdila wrote: >> > > >> > > > Curre

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 03:34:08PM +0300, Octavian Purdila wrote: > I can follow-up with a v3 3 patch series: first for the fix, second > for the OOM & error path cleanup, third for devm conversion. I'd include the error-path clean up bit in the devres conversion as that is what it's really all a

Re: [PATCH v5 4/4] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-24 Thread Johan Hovold
On Fri, Sep 19, 2014 at 11:22:45PM +0300, Octavian Purdila wrote: > +struct dln2_gpio { > + struct platform_device *pdev; > + struct gpio_chip gpio; > + > + /* > + * Cache pin direction to save us one transfer, since the > + * hardware has separate commands to read the in and

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Heiko Schocher
Hello Michal, Am 24.09.2014 11:38, schrieb Michal Nazarewicz: On Wed, Sep 24 2014, Heiko Schocher wrote: use the values for RNDIS over Ethernet as defined in http://www.usb.org/developers/defined_class (search for RDNIS): - baseclass: 0xef (miscellaneous) - subclass: 0x04 - protocol: 0x01 wi

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Heiko Schocher
Hello Lars, Am 24.09.2014 14:25, schrieb Lars Melin: On 2014-09-24 13:48, Heiko Schocher wrote: use the values for RNDIS over Ethernet as defined in http://www.usb.org/developers/defined_class (search for RDNIS): - baseclass: 0xef (miscellaneous) - subclass: 0x04 - protocol: 0x01 That is usb

[PATCH 0/2] Equivalent of g_webcam with configfs

2014-09-24 Thread Andrzej Pietrasiewicz
This series aims at integrating configfs into uvc, the way it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet, mass_storage, FunctionFS, loopback, sourcesink, uac1 and uac2. The preparation series is already on Felipe's next, so this series in fact consists of a small prepara

[PATCH 1/2] usb: gadget: f_uvc: rename a macro to avoid conflicts

2014-09-24 Thread Andrzej Pietrasiewicz
When configfs is integrated, CONFIGFS_ATTR_STRUCT and CONFIGFS_ATTR_OPS macros should be used, but the latter expects that tere is a to_f_uvc_opts function accepting a config_item, whereas the macro being changed can be applied to a different type of argument. Signed-off-by: Andrzej Pietrasiewicz

[PATCH 2/2] usb: gadget: uvc: configfs support in uvc function

2014-09-24 Thread Andrzej Pietrasiewicz
Add support for using the uvc function as a component of USB gadgets composed with configfs. Signed-off-by: Andrzej Pietrasiewicz --- Documentation/ABI/testing/configfs-usb-gadget-uvc | 264 +++ drivers/usb/gadget/Kconfig| 11 + drivers/usb/gadget/function/Makefile

Re: [resend PATCH 1/3] ACPI / platform: provide default DMA mask

2014-09-24 Thread Rafael J. Wysocki
On Wednesday, September 24, 2014 11:00:37 AM Heikki Krogerus wrote: > Most devices are configured for 32-bit DMA addresses. > Setting the mask to 32-bit here removes the need for the > drivers to do it separately. > > Signed-off-by: Heikki Krogerus > Cc: "Rafael J. Wysocki" ACK > --- > driver

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Octavian Purdila
On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold wrote: > On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote: >> + * dln2_dev.mod_rx_slots and then the echo header field to index the >> + * slots field and find the receive context for a particular >> + * request. >> + */ >> +struct d

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote: > On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold wrote: > > On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote: > > > > >> + * dln2_dev.mod_rx_slots and then the echo header field to index the > >> + * slots field an

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Lars Melin
On 2014-09-24 20:12, Heiko Schocher wrote: Hello Lars, Am 24.09.2014 14:25, schrieb Lars Melin: On 2014-09-24 13:48, Heiko Schocher wrote: use the values for RNDIS over Ethernet as defined in http://www.usb.org/developers/defined_class (search for RDNIS): - baseclass: 0xef (miscellaneous) - s

Re: [resend PATCH 3/3] usb: dwc3: add ACPI support

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:00:39AM +0300, Heikki Krogerus wrote: > Adds ACPI ID used on newer Intel SoCs. > > Signed-off-by: Heikki Krogerus > --- > drivers/usb/dwc3/core.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > i

Re: [PATCH v5 1/3] usb: gadget: Refactor request completion

2014-09-24 Thread Felipe Balbi
Hi, On Tue, Sep 23, 2014 at 10:09:22AM +0200, Michal Sojka wrote: > >> +/** > >> + * usb_gadget_giveback_request - give the request back to the gadget layer > >> + * Context: in_interrupt() > >> + * > >> + * This is called by device controller drivers in order to return the > >> + * completed requ

Re: [PATCH v5 1/3] usb: gadget: Refactor request completion

2014-09-24 Thread Alan Stern
On Tue, 23 Sep 2014, Michal Sojka wrote: > >> +/** > >> + * usb_gadget_giveback_request - give the request back to the gadget layer > >> + * Context: in_interrupt() > >> + * > >> + * This is called by device controller drivers in order to return the > >> + * completed request back to the gadget la

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Tue, 23 Sep 2014, Felipe Balbi wrote: > Hi Alan, > > Need your help looking over this detail here. When I run g_mass_storage > with stall=0 everything works fine. As soon as I remove it, things go > bonkers. > > Looking at the bulk-only spec, I see: > > "6.7.2 Hi - Host expects to receive da

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Octavian Purdila
On Wed, Sep 24, 2014 at 4:54 PM, Johan Hovold wrote: > On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote: >> On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold wrote: >> > On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote: >> >> >> >> >> + * dln2_dev.mod_rx_slots and the

Re: [PATCH][RFC] storage: Simplify condition to reject bad target in usb_stor_control_thread()

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Mark Knibbs wrote: > Hi, > > This follows on from something I mentioned in my recent post "[PATCH] > storage: Don't scan target 7 for SCM USB-SCSI converters". > > In drivers/usb/storage/usb.c, usb_stor_control_thread(): > /* reject if target != 0 or if LUN is higher t

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 05:54:15PM +0300, Octavian Purdila wrote: > On Wed, Sep 24, 2014 at 4:54 PM, Johan Hovold wrote: > > On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote: > >> On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold wrote: > >> > On Fri, Sep 19, 2014 at 11:22:42PM +0300,

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Alan Stern wrote: > > Case (6) is when Hi == Di, looking at my logs, I have: > > > > 720 [ 286.843965] SCSI CDB: 1a 00 3f 00 c0 00 > > 721 [ 286.844000] g_mass_storage gadget: SCSI command: MODE SENSE(6); > > Dc=6, Di=192; Hc=6, Hi=192 > > 722 [ 286.844018] g_mass_storag

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 11:05:58AM -0400, Alan Stern wrote: > On Tue, 23 Sep 2014, Felipe Balbi wrote: > > > Hi Alan, > > > > Need your help looking over this detail here. When I run g_mass_storage > > with stall=0 everything works fine. As soon as I remove it, things go > > bonkers. > > >

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Octavian Purdila
On Wed, Sep 24, 2014 at 6:07 PM, Johan Hovold wrote: > On Wed, Sep 24, 2014 at 05:54:15PM +0300, Octavian Purdila wrote: >> On Wed, Sep 24, 2014 at 4:54 PM, Johan Hovold wrote: >> > On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote: >> >> On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovo

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:17:18AM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Alan Stern wrote: > > > > Case (6) is when Hi == Di, looking at my logs, I have: > > > > > > 720 [ 286.843965] SCSI CDB: 1a 00 3f 00 c0 00 > > > 721 [ 286.844000] g_mass_storage gadget: SCSI command: MODE SENSE(6

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 10:30:17AM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 11:17:18AM -0400, Alan Stern wrote: > > On Wed, 24 Sep 2014, Alan Stern wrote: > > > > > > Case (6) is when Hi == Di, looking at my logs, I have: > > > > > > > > 720 [ 286.843965] SCSI CDB: 1a 00 3f 00 c0 00

Re: Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Mark Knibbs wrote: > Hi, > > I did some benchmarks to check the maximum transfer rate of a USB-to-SCSI > converter. The converter is USB 1.1, so limited to the 12Mbps full speed > rate. The performance when connected to a USB 3.0 port is significantly > worse than when connec

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

2014-09-24 Thread Alan Stern
On Mon, 22 Sep 2014, Michal Simek wrote: > Hi Alan and Greg, > > On 09/20/2014 06:19 AM, Chen Gang wrote: > > Hello Maintainers: > > > > Please help check this patch, when you have time. > > > > Thanks. > > > > On 09/08/2014 01:20 PM, Michal Simek wrote: > >> On 09/03/2014 05:50 PM, Chen Gang

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Felipe Balbi wrote: > > Therefore stalling is appropriate. Why it causes it problem for your > > system is a different matter. Is your UDC hardware capable of halting > > bulk endpoints? > > yeah, that part is just fine; I also verified with my sniffer that bulk > halt is

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 11:40:54AM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > Therefore stalling is appropriate. Why it causes it problem for your > > > system is a different matter. Is your UDC hardware capable of halting > > > bulk endpoints? > > > > ye

[PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper

2014-09-24 Thread Vinod Koul
This patch series adds a simple macro pm_runtime_last_busy_and_autosuspend() which invokes pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend() sequentially. Then we do a tree wide update of current patterns which are present. As evident from log below this pattern is frequent in the kernel

[PATCH 26/27] usb: musb: omap2430: use pm_runtime_last_busy_and_autosuspend helper

2014-09-24 Thread Vinod Koul
Use the new pm_runtime_last_busy_and_autosuspend helper instead of open coding the same code Signed-off-by: Vinod Koul --- drivers/usb/musb/omap2430.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index d36

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 11:20:31AM -0500, Felipe Balbi wrote: > > > > > Therefore stalling is appropriate. Why it causes it problem for your > > > > > system is a different matter. Is your UDC hardware capable of > > > > > halting > > > > > bulk endpoints? > > > > > > > > yeah, that part

[PATCH v2] storage: Don't scan target 7 for SCM USB-SCSI converters

2014-09-24 Thread Mark Knibbs
Hi, Regarding the patch I posted to prevent the bus scan of SCM USB-SCSI converters attempting to scan the converter itself, there is probably a neater way. In drivers/scsi/scsi_scan.c, function __scsi_scan_target(), there is: if (shost->this_id == id) /*

Re: [RFC PATCH] usb: core: log more general message on malformed LANGID descriptor

2014-09-24 Thread Scot Doyle
On Tue, 23 Sep 2014, Greg Kroah-Hartman wrote: > On Tue, Sep 23, 2014 at 10:28:49PM +, Scot Doyle wrote: >> I'd like to change this error message: >> [3.325837] usb 1-4: string descriptor 0 malformed (err = -61), >> defaulting to 0x0409 >> >> into an error message followed by a debug mess

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 12:19:13PM -0500, Felipe Balbi wrote: > Hi, > > On Wed, Sep 24, 2014 at 11:20:31AM -0500, Felipe Balbi wrote: > > > > > > Therefore stalling is appropriate. Why it causes it problem for > > > > > > your > > > > > > system is a different matter. Is your UDC hardware capa

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Felipe Balbi wrote: > > I'll capture usbmon and send here shortly. > > here it is... Interesting part starts at line 73 (114 on this email) > where the data transport received EPIPE (due to Stall). This time > however, I was eventually able to talk to the device and managed t

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Felipe Balbi wrote: > so here's sequence of events so far: > > - Enumration goes fine > - Get Max Lun -> 0 (single lun) > - Inquiry -> Passed > - Test Unit Ready -> Failed > - Request Sense (Unit Attentio

Re: [PATCH v2] usb: core: downgrade log severity to info when descriptor unavailable

2014-09-24 Thread Scot Doyle
On Tue, 23 Sep 2014, Greg Kroah-Hartman wrote: On Tue, Sep 23, 2014 at 07:12:40PM +, Scot Doyle wrote: According to commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0 USB: fix LANGID=0 regression usb devices are not required to report string descriptors. Since they are optional, log an inf

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 01:56:21PM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > so here's sequence of events so far: > > > > - Enumration goes fine > > - Get Max Lun -> 0 (single lun) > > - Inquiry -> Passed

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 01:53:31PM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > I'll capture usbmon and send here shortly. > > > > here it is... Interesting part starts at line 73 (114 on this email) > > where the data transport received EPIPE (due to Stall). This t

MUSB: extra cppi irq?

2014-09-24 Thread Bin Liu
Hi Felipe and all, The musb driver musb_host_tx() has the following: 1244 /* with CPPI, DMA sometimes triggers "extra" irqs */ 1245 if (!urb) { 1246 dev_dbg(musb->controller, "extra TX%d ready, csr %04x\n", epnum, tx_csr); 1247 return; 1248

Re: [PATCH v5 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Sergei Shtylyov
hello. On 09/24/2014 09:11 AM, Greg KH wrote: From: Antoine Tenart The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. This is in preparation to adding the generic PHY support. Signed-off-by: Antoine Tenart [Sergei: add

[PATCH v6 0/2] Add generic PHY support to USB HCD

2014-09-24 Thread Sergei Shtylyov
Hello. This patchset is against the usb-next' branch of Greg KH's 'usb.git' repo. Here I add support for the generic PHY to the 'struct usb_hcd' (having to rename the existing 'phy' field to 'usb_phy' beforehand). This was mainly intended to be used with the PCI OHCI/EHCI drivers and also xHCI

[PATCH v6 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Sergei Shtylyov
From: Antoine Tenart The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. This is in preparation to adding the generic PHY support. Signed-off-by: Antoine Tenart [Sergei: added missing 'drivers/usb/misc/lvstest.c' file, resolved

[PATCH v6 2/2] usb: hcd: add generic PHY support

2014-09-24 Thread Sergei Shtylyov
Add the generic PHY support, analogous to the USB PHY support. Intended it to be used with the PCI EHCI/OHCI drivers and the xHCI platform driver. Signed-off-by: Sergei Shtylyov Signed-off-by: Yoshihiro Shimoda --- Changes in version 5: - renamed the new 'gen_phy' field of 'struct usb_phy' back

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 01:08:15PM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 01:53:31PM -0400, Alan Stern wrote: > > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > > > I'll capture usbmon and send here shortly. > > > > > > here it is... Interesting part starts at line 73 (114 on

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 02:18:14PM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 01:08:15PM -0500, Felipe Balbi wrote: > > On Wed, Sep 24, 2014 at 01:53:31PM -0400, Alan Stern wrote: > > > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > > > > > I'll capture usbmon and send here shortl

Re: [PATCH v6 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:05:50PM +0400, Sergei Shtylyov wrote: > From: Antoine Tenart > > The USB PHY member of the HCD structure is renamed to 'usb_phy' and > modifications are done in all drivers accessing it. > This is in preparation to adding the generic PHY support. > > Signed-off-by: Ant

Re: [PATCH v6 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Sergei Shtylyov
Hello. On 09/24/2014 11:28 PM, Felipe Balbi wrote: From: Antoine Tenart The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. This is in preparation to adding the generic PHY support. Signed-off-by: Antoine Tenart [Sergei

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > According to the kerneldoc for usb_ep_set_halt: > > > > > > * Attempts to halt IN endpoints will fail (returning -EAGAIN) if any > > > * transfer requests are still queued, or if the controller hardware > > > * (usually a FIFO) still holds bytes t

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 03:31:13PM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > > According to the kerneldoc for usb_ep_set_halt: > > > > > > > > * Attempts to halt IN endpoints will fail (returning -EAGAIN) if any > > > > * transfer requests are still queued, or

Re: [PATCH v6 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:31:11PM +0400, Sergei Shtylyov wrote: > Hello. > > On 09/24/2014 11:28 PM, Felipe Balbi wrote: > > >>From: Antoine Tenart > > >>The USB PHY member of the HCD structure is renamed to 'usb_phy' and > >>modifications are done in all drivers accessing it. > >>This is in p

[PATCH v6 partial 0/2] pxa27x_udc port to device-tree and gpio_desc

2014-09-24 Thread Robert Jarzmik
Hi Felipe and Linus, As you requested, Felipe, I made the translation for the driver's probing from gpio to gpio_desc. Even if the code is functional, I'm pretty unhappy about my patch 1, because I lost the "active_low" notion in the transformation. I have not found in the gpiolib anything for a

[PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Robert Jarzmik
For this preparation, a preliminary cleanup is done : - convert the probing of pxa27x_udc to gpio_desc. The conversion is partial because : - the platform data still provides a gpio number, not a gpio desc - the "invert" attribute is lost, hence a loss in the translation - convert

[PATCH v6 2/2] usb: gadget: pxa27x_udc: add devicetree support

2014-09-24 Thread Robert Jarzmik
Add support for device-tree device discovery. If devicetree is not provided, fallback to legacy platform data "discovery". Signed-off-by: Robert Jarzmik Cc: devicet...@vger.kernel.org --- Since V1: change OF id mrvl,pxa27x_udc -> marvell,pxa27x-udc This is a consequence of other DT rev

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Felipe Balbi wrote: > > alright fixed. Below you can see a combined diff which I'll still split > > into patches so they can be applied properly. > > OTOH, there's really no way to split it. It's all needed to fix a single > bug. Do you want me to add Reported-by: Alan Stern

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 03:48:29PM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > alright fixed. Below you can see a combined diff which I'll still split > > > into patches so they can be applied properly. > > > > OTOH, there's really no way to split it. It's all need

Re: [PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 09:41:12PM +0200, Robert Jarzmik wrote: > For this preparation, a preliminary cleanup is done : > - convert the probing of pxa27x_udc to gpio_desc. > The conversion is partial because : > - the platform data still provides a gpio number, not a gpio desc > - t

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 02:40:12PM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 03:31:13PM -0400, Alan Stern wrote: > > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > > > > According to the kerneldoc for usb_ep_set_halt: > > > > > > > > > > * Attempts to halt IN endpoints will fail (re

Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper

2014-09-24 Thread Rafael J. Wysocki
On Wednesday, September 24, 2014 09:44:50 PM Vinod Koul wrote: > This patch series adds a simple macro pm_runtime_last_busy_and_autosuspend() > which invokes pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend() > sequentially. Then we do a tree wide update of current patterns which are > pr

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 03:06:15PM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 02:40:12PM -0500, Felipe Balbi wrote: > > On Wed, Sep 24, 2014 at 03:31:13PM -0400, Alan Stern wrote: > > > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > > > > > > According to the kerneldoc for usb_ep_set_h

  1   2   >