Re: [PATCH v4 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-19 Thread Johan Hovold
On Thu, Sep 18, 2014 at 06:54:34PM +0300, Octavian Purdila wrote: > On Thu, Sep 18, 2014 at 3:46 PM, Johan Hovold wrote: > > On Thu, Sep 18, 2014 at 03:43:07PM +0300, Octavian Purdila wrote: > >> On Thu, Sep 18, 2014 at 1:54 PM, Johan Hovold wrote: > >> > On Tue, Sep 09, 2014 at 10:24:46PM +0300,

[PATCH net] r8152: disable ALDPS

2014-09-19 Thread Hayes Wang
If the hw is in ALDPS mode, the hw may have no response for accessing the most registers. Therefore, the ALDPS should be disabled before accessing the hw in rtl_ops.init(), rtl_ops.disable(), rtl_ops.up(), and rtl_ops.down(). Regardless of rtl_ops.enable(), because the hw wouldn't enter ALDPS mode

[PATCH] phy: exynos5-drd: Fix PCS_TXDEEMPH mask

2014-09-19 Thread Anton Tikhomirov
According to user manual, pcs_tx_deemph_3p5db field in PHYPARAM1 register is 6bits wide, so mask value should be 0x3f instead of 0x1f. Signed-off-by: Anton Tikhomirov --- drivers/phy/phy-exynos5-usbdrd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-exyno

Re: [PATCH] phy: exynos5-drd: Fix PCS_TXDEEMPH mask

2014-09-19 Thread Jingoo Han
On Friday, September 19, 2014 4:36 PM, Anton Tikhomirov wrote: > > According to user manual, pcs_tx_deemph_3p5db field in PHYPARAM1 > register is 6bits wide, so mask value should be 0x3f instead > of 0x1f. > > Signed-off-by: Anton Tikhomirov Reviewed-by: Jingoo Han Best regards, Jingoo Han >

Re: [PATCH] phy: exynos5-drd: Fix PCS_TXDEEMPH mask

2014-09-19 Thread Vivek Gautam
Hi Anton, On Fri, Sep 19, 2014 at 1:05 PM, Anton Tikhomirov wrote: > According to user manual, pcs_tx_deemph_3p5db field in PHYPARAM1 > register is 6bits wide, so mask value should be 0x3f instead > of 0x1f. > > Signed-off-by: Anton Tikhomirov > --- > drivers/phy/phy-exynos5-usbdrd.c |2 +-

Re: OMAP3/AM3517 EHCI USB Issue

2014-09-19 Thread Roger Quadros
Hi Michael, On 08/04/2014 06:27 PM, Michael Welling wrote: > On Mon, Aug 04, 2014 at 12:34:16PM +0300, Roger Quadros wrote: >> On 08/02/2014 02:51 AM, Michael Welling wrote: >>> On Fri, Aug 1, 2014 at 6:04 PM, Michael Welling >>> wrote: On Wed, Jul 30, 2014 at 12:03:22PM +0300, Roger Quadro

Re: OMAP3/AM3517 EHCI USB Issue

2014-09-19 Thread Michael Trimarchi
Hi Roger On Fri, Sep 19, 2014 at 11:22 AM, Roger Quadros wrote: > Hi Michael, > > On 08/04/2014 06:27 PM, Michael Welling wrote: >> On Mon, Aug 04, 2014 at 12:34:16PM +0300, Roger Quadros wrote: >>> On 08/02/2014 02:51 AM, Michael Welling wrote: On Fri, Aug 1, 2014 at 6:04 PM, Michael Wellin

Your E-MAIL ADDRESS WON £1,000,000.00GBP IN 2014 CNN AWARD PROMOTION. For claims process, send (Full Name,Mobile Number) to Email: cnn.depp...@outlook.com

2014-09-19 Thread Amelia Holtsoi
-- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: OMAP3/AM3517 EHCI USB Issue

2014-09-19 Thread Roger Quadros
On 09/19/2014 12:37 PM, Michael Trimarchi wrote: > Hi Roger > > On Fri, Sep 19, 2014 at 11:22 AM, Roger Quadros wrote: >> Hi Michael, >> > > It should be noted that the external HUB must be prevented from > autosuspend > otherwise the resume fails. OK. I was able to

[PATCH 1/1] cp210x: Add support for Seluxit USB Dongle

2014-09-19 Thread Andreas Bomholtz
We have a USB dongle with the cp210x chip on. And we have put our own USB id into it. Signed-off-by: Andreas Bomholtz --- diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index e4bb622..abd7577 100644 --- a/drivers/usb/serial/cp210x.c +++ b/drivers/usb/serial/cp210x.c @@ -1

Re: [PATCH 1/1] cp210x: Add support for Seluxit USB Dongle

2014-09-19 Thread Johan Hovold
On Fri, Sep 19, 2014 at 01:23:03PM +0200, Andreas Bomholtz wrote: > We have a USB dongle with the cp210x chip on. > And we have put our own USB id into it. > > Signed-off-by: Andreas Bomholtz Thanks for the patch. There are just two minor issues. Your patch appear to have been line wrapped by yo

Re: [PATCHv4 08/12] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-09-19 Thread Dinh Nguyen
On 9/12/14, 11:28 AM, Bartlomiej Zolnierkiewicz wrote: > > [ added linux-kernel ML to cc: ] > > Hi, > > On Tuesday, August 26, 2014 11:19:59 AM dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Since the dwc2 hcd driver is currently not looking for a clock node during >> init,

Re: [PATCHv4 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-09-19 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday, September 18, 2014 10:54:24 AM Dinh Nguyen wrote: > Hi Bartlomiej, > > On 09/12/2014 10:49 AM, Bartlomiej Zolnierkiewicz wrote: > > > > [ added linux-kernel ML to cc: ] > > > > Hi, > > > > On Tuesday, August 26, 2014 11:19:52 AM dingu...@opensource.altera.com > > wrote: > >>

Re: [PATCH] Revert "usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup"

2014-09-19 Thread Li Jun
On Thu, Sep 18, 2014 at 09:31:32AM -0500, Felipe Balbi wrote: > This reverts commit f2267089ea17fa97b796b1b4247e3f8957655df3. > > That commit causes more problem than fixes. Firstly, kfree() > should be called after usb_ep_dequeue() and secondly, the way > things are, we will try to dequeue a requ

[PATCH v3 2/6] usb: hub: rename hub_events() to hub_event() and handle only one event there

2014-09-19 Thread Petr Mladek
We would like to convert khubd kthread to a workqueue. As a result hub_events() will handle only one event per call. In fact, we could do this already now because there is another cycle in hub_thread(). It calls hub_events() until hub_event_list is empty. This patch renames the function to hub_ev

[PATCH v3 1/6] usb: hub: keep hub->dev reference all the time when struct usb_hub lives

2014-09-19 Thread Petr Mladek
This is just a small optimization of the fix from the commit c605f3cdff53a743f6 ("usb: hub: take hub->hdev reference when processing from eventlist). We do not need to take the reference for each event. Instead we could get it when struct usb_hub is allocated and put it when it is released. By oth

[PATCH v3 6/6] usb: hub: allow to process more usb hub events in parallel

2014-09-19 Thread Petr Mladek
It seems that only choose_devnum() was not ready to process more hub events at the same time. All should be fine if we take bus->usb_address0_mutex there. It will make sure that more devnums will not be chosen for the given bus and the related devices at the same time. Signed-off-by: Petr Mladek

[PATCH v3 5/6] usb: hub: rename khubd to hub_wq in documentation and comments

2014-09-19 Thread Petr Mladek
USB hub has started to use a workqueue instead of kthread. Let's update the documentation and comments here and there. This patch mostly just replaces "khubd" with "hub_wq". There are only few exceptions where the whole sentence was updated. These more complicated changes can be found in the follo

[PATCH v3 3/6] usb: hub: convert khubd into workqueue

2014-09-19 Thread Petr Mladek
There is no need to have separate kthread for handling USB hub events. It is more elegant to use the workqueue framework. The workqueue is allocated as freezable because the original thread was freezable as well. Also it is allocated as ordered because the code is not ready for parallel processin

[PATCH v3 4/6] usb: hub: rename usb_kick_khubd() to usb_kick_hub_wq()

2014-09-19 Thread Petr Mladek
USB hub started to use a workqueue instead of kthread. Let's make it clear from the function names. Signed-off-by: Petr Mladek --- drivers/usb/core/hcd.c | 4 ++-- drivers/usb/core/hub.c | 2 +- drivers/usb/core/usb.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v3 0/6] usb: hub: convert khubd into workqueue

2014-09-19 Thread Petr Mladek
The 3rd version of the patchset is slightly reordered and refactored as suggested earlier. See below for more details. IMHO, the result is more clean. But feel free to ask me to revert it. I do not want to make the review more complicated. Well, I double checked the diff of patches files between v

RE: [PATCHv4 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-09-19 Thread Paul Zimmerman
> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Friday, September 19, 2014 7:50 AM > > Unfortunately after second look there are even more problems with Kconfig > changes, please see below. > > > > > > >> if USB_DWC2 > > >> > > >> +choice > > >> +bool "DWC2 Mo

Re: [PATCH v3 0/6] usb: hub: convert khubd into workqueue

2014-09-19 Thread Alan Stern
On Fri, 19 Sep 2014, Petr Mladek wrote: > The 3rd version of the patchset is slightly reordered and refactored > as suggested earlier. See below for more details. > > IMHO, the result is more clean. But feel free to ask me to revert it. > I do not want to make the review more complicated. Well, I

[PATCH v6 5/5] usb: gadget: pxa27x_udc: fix clock prepare and enable

2014-09-19 Thread Robert Jarzmik
As the udc clock controls both the output signals and the internal IP, it must be enabled before any UDC register is touched. The bug is revealed when the clock framework disables the clock for a couple of milliseconds during the boot sequence, and the endpoint configuration is lost. The bug is hi

[PATCH v6 4/5] usb: gadget: pxa27x_udc: use devm_* helpers

2014-09-19 Thread Robert Jarzmik
Use devm_* helpers in the probe function to simplify the error path and the remove path. Signed-off-by: Robert Jarzmik Cc: Sergei Shtylyov --- Since V1: Addressed Sergei's comments Since V2: Addressed Sergei's comments on includes Since V4: Addressed Sergei's comment on clk_uprepare in probe()

[PATCH v6 2/5] usb: gadget: pxa27x_udc: add devicetree support

2014-09-19 Thread Robert Jarzmik
Add support for device-tree device discovery. If devicetree is not provided, fallback to legacy platform data "discovery". Signed-off-by: Robert Jarzmik Cc: devicet...@vger.kernel.org --- Since V1: change OF id mrvl,pxa27x_udc -> marvell,pxa27x-udc This is a consequence of other DT rev

[PATCH v6 3/5] usb: gadget: pxa27x_udc device-tree documentation

2014-09-19 Thread Robert Jarzmik
Add documentation for device-tree binding of arm PXA 27x udc (usb device) driver. Signed-off-by: Robert Jarzmik Cc: devicet...@vger.kernel.org --- Since V1: change OF id mrvl,pxa27x_udc -> marvell,pxa27x-udc This is a consequence of other DT reviews on the marvell namings. Si

[PATCH v6 1/5] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-19 Thread Robert Jarzmik
The pxa27x_udc should support 2 modes of initialization : - one through legacy platform data - one new through device-tree Prepare the double support by moving the initialization data, ie. the gpios, into the udc control structure. Signed-off-by: Robert Jarzmik --- Since v5: This new patch, s

[PATCH v5 0/4] mfd: add support for Diolan DLN-2

2014-09-19 Thread Octavian Purdila
This patch series adds support for Diolan USB-I2C/GPIO Master Adapter DLN-2. Details about device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Changes since v4: * Add a new gpiolib chip flag to allow blocking chips with non threaded IRQ handlers * MFD: set GPLv2 as licens

[PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-19 Thread Octavian Purdila
This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Information about the USB protocol can be found in the Programmer's Reference Manual [1], see section 1.7. Because th

[PATCH v5 3/4] gpiolib: add irq_not_threaded flag to gpio_chip

2014-09-19 Thread Octavian Purdila
Some GPIO chips (e.g. the DLN2 USB adapter) have blocking get/set operation but do not need a threaded irq handler. Signed-off-by: Octavian Purdila --- drivers/gpio/gpiolib.c | 2 +- include/linux/gpio/driver.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/g

[PATCH v5 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-19 Thread Octavian Purdila
From: Laurentiu Palcu This patch adds support for the Diolan DLN-2 I2C master module. Due to hardware limitations it does not support SMBUS quick commands. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 6.2.2 for the I2C master mod

[PATCH v5 4/4] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-19 Thread Octavian Purdila
From: Daniel Baluta This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 2.9 for the GPIO module commands and responses. [1] https://www.diolan.com/downloads/dln-api

Re: [PATCH v6 1/5] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-19 Thread Felipe Balbi
Hi, On Fri, Sep 19, 2014 at 09:46:22PM +0200, Robert Jarzmik wrote: > The pxa27x_udc should support 2 modes of initialization : > - one through legacy platform data > - one new through device-tree > > Prepare the double support by moving the initialization data, ie. the > gpios, into the udc co

Re: [PATCH v6 1/5] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-19 Thread Robert Jarzmik
Felipe Balbi writes: > On Fri, Sep 19, 2014 at 09:46:22PM +0200, Robert Jarzmik wrote: >> Since v5: This new patch, split out of the first DT patch > > please resend once v3.18-rc1 is out. But... There are 2 -rc left for v3.17, can't this serie make it for 3.18 merge window ? >> +if

Take dwc2 driver through Felipe's tree?

2014-09-19 Thread Paul Zimmerman
Hi Greg, How would you feel about Felipe taking the dwc2 driver into his tree? There has been quite a bit of increased activity with dwc2 lately, and I know you already have more than enough stuff on your plate already. So this would mean one less thing for you to worry about. Plus it would mean a

Re: Take dwc2 driver through Felipe's tree?

2014-09-19 Thread gre...@linuxfoundation.org
On Fri, Sep 19, 2014 at 08:52:07PM +, Paul Zimmerman wrote: > Hi Greg, > > How would you feel about Felipe taking the dwc2 driver into his tree? > There has been quite a bit of increased activity with dwc2 lately, and > I know you already have more than enough stuff on your plate already. > So

Re: [PATCH v6 1/5] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-19 Thread Felipe Balbi
Hi, On Fri, Sep 19, 2014 at 10:48:25PM +0200, Robert Jarzmik wrote: > Felipe Balbi writes: > > > On Fri, Sep 19, 2014 at 09:46:22PM +0200, Robert Jarzmik wrote: > >> Since v5: This new patch, split out of the first DT patch > > > > please resend once v3.18-rc1 is out. But... > There are 2 -rc le

Re: Take dwc2 driver through Felipe's tree?

2014-09-19 Thread Felipe Balbi
On Fri, Sep 19, 2014 at 02:01:50PM -0700, gre...@linuxfoundation.org wrote: > On Fri, Sep 19, 2014 at 08:52:07PM +, Paul Zimmerman wrote: > > Hi Greg, > > > > How would you feel about Felipe taking the dwc2 driver into his tree? > > There has been quite a bit of increased activity with dwc2 la

[PATCH] usb: dwc2: add T: line to MAINTAINERS showing Felipe's tree

2014-09-19 Thread Paul Zimmerman
Starting with v3.18-rc, patches for dwc2 will go through Felipe's tree. Add a T: line to MAINTAINERS to document this. Signed-off-by: Paul Zimmerman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 809ecd6..bffd59c 100644 --- a/MAINTAINERS +++ b

Re: [GIT PULL v2] USB changes for v3.18 merge window

2014-09-19 Thread Greg KH
On Thu, Sep 18, 2014 at 09:46:11AM -0500, Felipe Balbi wrote: > Hi Greg, > > Here you go. This one should be good to go. Sorry for the last minute > change but it was better to revert those patches than having a broken > v3.17 final. Let me know if you want any changes. > > cheers > > The follow

Re: [PATCH] usb: dwc2: add T: line to MAINTAINERS showing Felipe's tree

2014-09-19 Thread Greg KH
On Fri, Sep 19, 2014 at 02:49:36PM -0700, Paul Zimmerman wrote: > Starting with v3.18-rc, patches for dwc2 will go through Felipe's > tree. Add a T: line to MAINTAINERS to document this. > > Signed-off-by: Paul Zimmerman Now applied. I've caught up with all pending dwc2 patches that I know of.

Re: [PATCH v5 4/4] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-19 Thread Arnd Bergmann
On Friday 19 September 2014, Octavian Purdila wrote: > +struct dln2_gpio_pin { > + __le16 pin; > +} __packed; This does not need to be marked packed, since it is never embedded in another structure. > +struct dln2_gpio_pin_val { > + __le16 pin; > + u8 value; > +} __packed; It's enoug

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

2014-09-19 Thread Chen Gang
Hello Maintainers: Please help check this patch, when you have time. Thanks. On 09/08/2014 01:20 PM, Michal Simek wrote: > On 09/03/2014 05:50 PM, Chen Gang wrote: >> Need include it for irq_of_parse_and_map(), the related error with >> allmodconfig under microblaze: >> >> drivers/usb/host/ehc

Re: [PATCH v5 4/4] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-19 Thread Octavian Purdila
On Sat, Sep 20, 2014 at 5:48 AM, Arnd Bergmann wrote: > On Friday 19 September 2014, Octavian Purdila wrote: >> +struct dln2_gpio_pin { >> + __le16 pin; >> +} __packed; > > This does not need to be marked packed, since it is never embedded in another > structure. > Will do. >> +struct dln2_g