[PATCH v5 2/3] usb: Rename usb-common.c

2014-09-17 Thread Michal Sojka
In the next commit, we will want the usb-common module to be composed of two object files. Since Kbuild cannot "append" another object to an existing one, we need to rename usb-common.c to something else (common.c) and create usb-common.o by linking the wanted objects together. Currently, usb-commo

[PATCH v5 3/3] usb: Add LED triggers for USB activity

2014-09-17 Thread Michal Sojka
With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both triggers should work with all host/device controllers. Tested only with musb. Performace: I measured performance overheads on ARM Cortex-A8 (TI AM335x

[PATCH v5 0/3] LED triggers for USB host and device

2014-09-17 Thread Michal Sojka
(this is resend of a patch series from about three weeks ago) This adds LED triggers for USB host and device. First patch refactors UDC drivers as requested by Felipe Balbi, second is a preparation for the third, which adds the LED triggers. Changes from v4: - Added performance numbers to the com

[PATCH v5 1/3] usb: gadget: Refactor request completion

2014-09-17 Thread Michal Sojka
All USB peripheral controller drivers called completion routines directly. This patch moves the completion call from drivers to usb_gadget_giveback_request(), in order to have a place where common functionality can be added. All places in drivers/usb/ matching "[-.]complete(" were replaced with a

Re: [PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-17 Thread Octavian Purdila
On Wed, Sep 17, 2014 at 2:21 AM, Lee Jones wrote: > > On Tue, 09 Sep 2014, Octavian Purdila wrote: > > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > > Master Adapter DLN-2. Details about the device can be found here: > > > > https://www.diolan.com/i2c/i2c_interface.html. >

Re: [PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-17 Thread Johan Hovold
On Wed, Sep 17, 2014 at 10:25:18AM +0300, Octavian Purdila wrote: > On Wed, Sep 17, 2014 at 2:21 AM, Lee Jones wrote: > > > > On Tue, 09 Sep 2014, Octavian Purdila wrote: > > > > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > > > Master Adapter DLN-2. Details about the devic

[PATCH fix for 3.17] uas: Add US_FL_NO_ATA_1X quirk for Seagate (0bc2:ab20) drives

2014-09-17 Thread Hans de Goede
https://bbs.archlinux.org/viewtopic.php?pid=1457492 Signed-off-by: Hans de Goede --- drivers/usb/storage/unusual_uas.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index 3e62437..94fb09f 100644 --- a/drivers/usb

Re: [PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-17 Thread Johan Hovold
On Tue, Sep 09, 2014 at 10:24:44PM +0300, Octavian Purdila wrote: > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > Master Adapter DLN-2. Details about the device can be found here: > > https://www.diolan.com/i2c/i2c_interface.html. > > Information about the USB protocol can b

Re: [PATCH v4 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-17 Thread Johan Hovold
On Tue, Sep 09, 2014 at 10:24:45PM +0300, Octavian Purdila wrote: > From: Laurentiu Palcu > > This patch adds support for the Diolan DLN-2 I2C master module. Due > to hardware limitations it does not support SMBUS quick commands. > > Information about the USB protocol interface can be found in t

Re: [PATCH v4 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-17 Thread Octavian Purdila
On Wed, Sep 17, 2014 at 12:44 PM, Johan Hovold wrote: >> + /* >> + * Buffer to hold the packet for read or write transfers. One >> + * is enough since we can't have multiple transfers in >> + * parallel on the i2c adapter. >> + */ >> + union { >> + struct

[PATCH v3 2/2] usb: host: ohci-exynos: Remove unnecessary usb-phy support

2014-09-17 Thread Vivek Gautam
Now that we have completely moved from older USB-PHY drivers to newer GENERIC-PHY drivers for PHYs available with USB controllers on Exynos series of SoCs, we can remove the support for the same in our host drivers too. Signed-off-by: Vivek Gautam --- drivers/usb/host/ohci-exynos.c | 89 ++

[PATCH v3 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-17 Thread Vivek Gautam
Now that we have completely moved from older USB-PHY drivers to newer GENERIC-PHY drivers for PHYs available with USB controllers on Exynos series of SoCs, we can remove the support for the same in our host drivers too. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-exynos.c | 81 ++

[PATCH v3 0/2] usb: host: ehci/ohci-exynos: phy cleanup

2014-09-17 Thread Vivek Gautam
Cleaning up the phy getting sequence in ehci-exynos and ohci-exynos drivers. Hi Alan, Jingoo, I have not imported the Acked-by and Reviewed-by from you guys, from V2 version of this patch series, since this version is now rebased on the already available commit in usb-next - "usb: ehci/ohci-exyno

Re: [PATCH v3 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-17 Thread Jingoo Han
On Wednesday, September 17, 2014 8:18 PM, Vivek Gautam wrote: > > Now that we have completely moved from older USB-PHY drivers > to newer GENERIC-PHY drivers for PHYs available with USB controllers > on Exynos series of SoCs, we can remove the support for the same > in our host drivers too. > > S

Re: [PATCH v3 2/2] usb: host: ohci-exynos: Remove unnecessary usb-phy support

2014-09-17 Thread Jingoo Han
On Wednesday, September 17, 2014 8:18 PM, Vivek Gautam wrote: > > Now that we have completely moved from older USB-PHY drivers > to newer GENERIC-PHY drivers for PHYs available with USB controllers > on Exynos series of SoCs, we can remove the support for the same > in our host drivers too. > > S

Re: [PATCH 0/7] xhci: patches for usb-next

2014-09-17 Thread Mathias Nyman
Ping, Any plan on taking these to your usb-next branch? They still apply nicely on latest 3.17-rc5 based usb-next -Mathias On 08/20/2014 04:41 PM, Mathias Nyman wrote: > Hi Greg > > These xhci patches are for usb-next and apply on top of 3.17-rc1 > > It contains Hans De Goede's xhci cleanups,

Re: [PATCH v3 0/9] Tegra xHCI support

2014-09-17 Thread Mikko Perttunen
On 09/17/2014 01:40 AM, Stephen Warren wrote: That's a huge time-sink, unless I work out NFS root, which probably isn't properly or easily supported by any distro. FWIW, this is how I've been working, and it hasn't been /that/ difficult to get working. The Tegra side is trivial, just append so

Re: Hitting "unused qh not empty" BUG in qh_destroy

2014-09-17 Thread Joe Lawrence
On Tue, 16 Sep 2014 15:29:20 -0400 Alan Stern wrote: > ... And now I see the problem. It's these two lines just before the > "switch": > > if (ehci->rh_state < EHCI_RH_RUNNING) > qh->qh_state = QH_STATE_IDLE; > > That undoubtedly caused us to destroy the QH directly withou

Re: Ability to specify SCM_MULT_TARG quirk on command line

2014-09-17 Thread Alan Stern
On Tue, 16 Sep 2014, Mark wrote: > > Do you know what product ID the ethernet adapter actually uses? > > Sadly, I think versions exist with *both* IDs 0411:0001 and 0411:0005, and > the Windows INF file mentions both. > > Some searching gave related results... > > Post to linux-usb on 2000-04-0

Re: [PATCH v3 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-17 Thread Alan Stern
On Wed, 17 Sep 2014, Vivek Gautam wrote: > Now that we have completely moved from older USB-PHY drivers > to newer GENERIC-PHY drivers for PHYs available with USB controllers > on Exynos series of SoCs, we can remove the support for the same > in our host drivers too. > > Signed-off-by: Vivek Gau

Re: [PATCH 00/17] usb: gadget: convert udc driver to use udc-core's reset notifier

2014-09-17 Thread Alan Stern
On Wed, 17 Sep 2014, Peter Chen wrote: > Hi Felipe, > > In this series, I convert udc driver to use udc-core's reset notifier > which has added recently, I only change the drivers which has > bus reset handler and call usb_gadget_driver's ->disconnect in it. > > For five you and Alan's patches,

[PATCH v2 0/4] usb: hub: convert khubd into workqueue

2014-09-17 Thread Petr Mladek
The workqueue API is well defined and tested. It has many options that could be used to tune the scheduling. The code is usually easier and thus more safe. It allows to avoid the extra thread in most cases. It has has clearly defined behavior vrt. system suspend. This patchset converts khubd into

[PATCH v2 3/4] usb: hub: rename usb_kick_khubd() to usb_kick_hub_wq()

2014-09-17 Thread Petr Mladek
USB hub started to use a workqueue instead of kthread. Let's make it clear from the function names. Signed-off-by: Petr Mladek --- drivers/usb/core/hcd.c | 4 ++-- drivers/usb/core/hub.c | 2 +- drivers/usb/core/usb.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v2 1/4] usb: hub: convert khubd into workqueue

2014-09-17 Thread Petr Mladek
There is no need to have separate kthread for handling USB hub events. It is more elegant to use the workqueue framework. The workqueue is allocated as freezable because the original thread was freezable as well. struct usb_hub is passed via the work item. Therefore we do not need hub_event_list.

[PATCH v2 4/4] usb: hub: rename khubd to hub_wq in documentation and comments

2014-09-17 Thread Petr Mladek
USB hub has started to use a workqueue instead of kthread. Let's update the documentation and comments here and there. This patch mostly just replaces "khubd" with "hub_wq". There are only few exceptions where the whole sentence was updated. These more complicated changes can be found in the follo

[PATCH] USB: EHCI: unlink QHs even after the controller has stopped

2014-09-17 Thread Alan Stern
Old code in ehci-hcd tries to expedite disabling endpoints after the controller has stopped, by destroying the endpoint's associated QH without first unlinking the QH. This was necessary back when the driver wasn't so careful about keeping track of the controller's state. But now we are careful a

Re: [PATCH 2/4] usb: hub: remove obsolete while cycle in hub_event()

2014-09-17 Thread Petr Mládek
On Fri 12-09-14 10:23:26, Alan Stern wrote: > On Fri, 12 Sep 2014, Petr Mladek wrote: > > > The USB hub events are proceed by workqueue instead of kthread now. > > The result is that hub_event() function processes only one event. > > The while cycle was not removed earlier to show the real changes

Re: Hitting "unused qh not empty" BUG in qh_destroy

2014-09-17 Thread Alan Stern
On Wed, 17 Sep 2014, Joe Lawrence wrote: > On Tue, 16 Sep 2014 15:29:20 -0400 > Alan Stern wrote: > > > ... And now I see the problem. It's these two lines just before the > > "switch": > > > > if (ehci->rh_state < EHCI_RH_RUNNING) > > qh->qh_state = QH_STATE_IDLE; > > > > Th

Re: am335x musb_hdrc broken(?)

2014-09-17 Thread Felipe Balbi
On Wed, Sep 17, 2014 at 10:46:57AM +0400, Matwey V. Kornilov wrote: > 2014-09-16 22:39 GMT+04:00 Felipe Balbi : > > Hi, > > > > (man, talk about trimming... leave some context ;-) > > > > On Tue, Sep 16, 2014 at 10:06:33PM +0400, Matwey V. Kornilov wrote: > >> Ok. What is about musb_io.h? What does

[PATCH v2 2/4] usb: hub: remove obsolete while cycle in hub_event()

2014-09-17 Thread Petr Mladek
The USB hub events are proceed by workqueue instead of kthread now. The result is that hub_event() function processes only one event. The block from the while cycle was not removed earlier to show the real changes when switching to the workqueue. When touching the code, it fixes also formatting o

Re: [PATCH v5 1/3] usb: gadget: Refactor request completion

2014-09-17 Thread Felipe Balbi
On Wed, Sep 17, 2014 at 09:21:11AM +0200, Michal Sojka wrote: > All USB peripheral controller drivers called completion routines > directly. This patch moves the completion call from drivers to > usb_gadget_giveback_request(), in order to have a place where common > functionality can be added. > >

Re: am335x musb_hdrc broken(?)

2014-09-17 Thread Matwey V. Kornilov
2014-09-17 19:25 GMT+04:00 Felipe Balbi : > On Wed, Sep 17, 2014 at 10:46:57AM +0400, Matwey V. Kornilov wrote: >> 2014-09-16 22:39 GMT+04:00 Felipe Balbi : >> > Hi, >> > >> > (man, talk about trimming... leave some context ;-) >> > >> > On Tue, Sep 16, 2014 at 10:06:33PM +0400, Matwey V. Kornilov

Re: [PATCH v3 0/9] Tegra xHCI support

2014-09-17 Thread Stephen Warren
On 09/16/2014 05:51 PM, Andrew Bresticker wrote: On Tue, Sep 16, 2014 at 4:15 PM, Stephen Warren wrote: On 09/16/2014 04:46 PM, Andrew Bresticker wrote: On Tue, Sep 16, 2014 at 9:57 AM, Andrew Bresticker wrote: On Tue, Sep 16, 2014 at 8:26 AM, Stephen Warren wrote: On 09/15/2014 01:30 P

Re: am335x musb_hdrc broken(?)

2014-09-17 Thread Felipe Balbi
On Wed, Sep 17, 2014 at 07:35:14PM +0400, Matwey V. Kornilov wrote: > 2014-09-17 19:25 GMT+04:00 Felipe Balbi : > > On Wed, Sep 17, 2014 at 10:46:57AM +0400, Matwey V. Kornilov wrote: > >> 2014-09-16 22:39 GMT+04:00 Felipe Balbi : > >> > Hi, > >> > > >> > (man, talk about trimming... leave some con

Re: [PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-17 Thread Lee Jones
On Wed, 17 Sep 2014, Johan Hovold wrote: > On Tue, Sep 09, 2014 at 10:24:44PM +0300, Octavian Purdila wrote: > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > > Master Adapter DLN-2. Details about the device can be found here: > > > > https://www.diolan.com/i2c/i2c_interface.

Re: [PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-17 Thread Lee Jones
On Wed, 17 Sep 2014, Octavian Purdila wrote: > On Wed, Sep 17, 2014 at 2:21 AM, Lee Jones wrote: > > > > On Tue, 09 Sep 2014, Octavian Purdila wrote: > > > > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > > > Master Adapter DLN-2. Details about the device can be found here:

Re: [PATCH 2/4] usb: hub: remove obsolete while cycle in hub_event()

2014-09-17 Thread Alan Stern
On Wed, 17 Sep 2014, Petr [iso-8859-1] Ml�dek wrote: > On Fri 12-09-14 10:23:26, Alan Stern wrote: > > On Fri, 12 Sep 2014, Petr Mladek wrote: > > > > > The USB hub events are proceed by workqueue instead of kthread now. > > > The result is that hub_event() function processes only one event. > >

Re: [PATCH v2 1/4] usb: hub: convert khubd into workqueue

2014-09-17 Thread Alan Stern
On Wed, 17 Sep 2014, Petr Mladek wrote: > There is no need to have separate kthread for handling USB hub events. > It is more elegant to use the workqueue framework. > > The workqueue is allocated as freezable because the original thread was > freezable as well. I've got a few comments about st

Re: [PATCH v2 2/4] usb: hub: remove obsolete while cycle in hub_event()

2014-09-17 Thread Alan Stern
On Wed, 17 Sep 2014, Petr Mladek wrote: > The USB hub events are proceed by workqueue instead of kthread now. > The result is that hub_event() function processes only one event. > The block from the while cycle was not removed earlier to show the real > changes when switching to the workqueue. >

Re: [PATCH v2 4/4] usb: hub: rename khubd to hub_wq in documentation and comments

2014-09-17 Thread Alan Stern
On Wed, 17 Sep 2014, Petr Mladek wrote: > USB hub has started to use a workqueue instead of kthread. Let's update > the documentation and comments here and there. > > This patch mostly just replaces "khubd" with "hub_wq". There are only few > exceptions where the whole sentence was updated. These

Re: [PATCH v3 0/9] Tegra xHCI support

2014-09-17 Thread Andrew Bresticker
On Wed, Sep 17, 2014 at 8:41 AM, Stephen Warren wrote: > On 09/16/2014 05:51 PM, Andrew Bresticker wrote: >> >> On Tue, Sep 16, 2014 at 4:15 PM, Stephen Warren >> wrote: >>> >>> On 09/16/2014 04:46 PM, Andrew Bresticker wrote: On Tue, Sep 16, 2014 at 9:57 AM, Andrew Bresticker

[GIT PULL] USB changes for v3.18 merge window

2014-09-17 Thread Felipe Balbi
Hi Greg, Here's my pull request for v3.18. Now I'll ignore linux-usb for a while and get a beer or two. Anyway, let me know if you want anything to be changed, but I tested these patches with beaglebone black and am437x SK. cheers The following changes since commit 9e82bf014195d6f0054982c463575

[PATCH] storage: Add quirks for Entrega/Xircom USB to SCSI converters

2014-09-17 Thread Mark
Hi, This should be applied instead of the previous patch I sent, "storage: Add quirk for Entrega/PortGear USB to SCSI Converter" This patch adds quirks for Entrega Technologies (later Xircom PortGear) USB- SCSI converters. They use Shuttle Technology EUSB-01/EUSB-S1 chips. The US_FL_SCM_MULT_TAR

[PATCH] usb: Fixed a few typos

2014-09-17 Thread Mickael Maison
Signed-off-by: Mickael Maison --- drivers/usb/core/hcd.c | 2 +- drivers/usb/musb/musb_regs.h | 2 +- drivers/usb/storage/realtek_cr.c | 4 ++-- drivers/usb/storage/scsiglue.c | 2 +- drivers/usb/storage/usb.c| 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff -

Re: [PATCH 3/3] uwb: remove UWB build dependency on PCI

2014-09-17 Thread Sergei Shtylyov
On 9/16/2014 11:40 PM, Thomas Pugliese wrote: UWB does not require PCI to be enabled so remove build dependency. Signed-off-by: Thomas Pugliese --- drivers/uwb/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/uwb/Kconfig b/drivers/uwb/Kconfig index 2431eed..c204094 100

Re: [PATCH] usb: Fixed a few typos

2014-09-17 Thread Felipe Balbi
On Wed, Sep 17, 2014 at 09:16:25PM +0200, Mickael Maison wrote: you really wanna add a commit log here, even if obvious. Also, scripts/get_maintainer.pl would've told you to Cc me as the MUSB maintainer :-) No harm done though, just keep that in mind next time ;-) > Signed-off-by: Mickael Maison

[PATCH v4 3/9] of: Update Tegra XUSB pad controller binding for USB

2014-09-17 Thread Andrew Bresticker
Add new bindings used for USB support by the Tegra XUSB pad controller. This includes additional PHY types, USB-specific pinconfig properties, etc. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren --- Changes from v2: - Added nvidia,otg-hs-curr-level-offset property. - Dropped "-ot

[PATCH v4 5/9] of: Add NVIDIA Tegra xHCI controller binding

2014-09-17 Thread Andrew Bresticker
Add device-tree binding documentation for the xHCI controller present on Tegra124 and later SoCs. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren --- No changes from v3. Changes from v2: - Added mbox-names property. Changes from v1: - Updated to use common mailbox bindings. - Add

[PATCH v4 6/9] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver

2014-09-17 Thread Andrew Bresticker
Add support for the on-chip xHCI host controller present on Tegra SoCs. The driver is currently very basic: it loads the controller with its firmware, starts the controller, and is able to service messages sent by the controller's firmware. The hardware also supports device mode as well as powerg

[PATCH v4 9/9] ARM: tegra: venice2: Add xHCI support

2014-09-17 Thread Andrew Bresticker
Assign ports previously owned by the EHCI controllers to the xHCI controller. There are two external USB ports (UTMI ports 0/2 and USB3 ports 0/1) and an internal USB port (UTMI port 1). PCIe lanes 0 and 1 are used by the USB3 ports. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren

[PATCH v4 7/9] ARM: tegra: Add Tegra124 XUSB mailbox and xHCI controller

2014-09-17 Thread Andrew Bresticker
Add nodes for the Tegra XUSB mailbox and Tegra xHCI controller and add the PHY mailbox channel to the XUSB padctl node. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren --- No changes from v3. Changes from v2: - Dropped channel specifier from mailbox bindings. - Added mbox-names pr

[PATCH v4 8/9] ARM: tegra: jetson-tk1: Add xHCI support

2014-09-17 Thread Andrew Bresticker
Assign USB ports previously owned by the EHCI controllers to the xHCI controller. There is a mini-PCIe USB port (UTMI port 1) and a USB A connector (UTMI port 2, USB3 port 0). PCIe lane 0 is used for USB3 port 0. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren --- Changes from v3:

[PATCH v4 1/9] of: Add NVIDIA Tegra XUSB mailbox binding

2014-09-17 Thread Andrew Bresticker
Add device-tree bindings for the Tegra XUSB mailbox which will be used for communication between the Tegra xHCI controller's firmware and the host processor. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren --- No changes from v3. Changes from v2: - Dropped channel specifier. - Add

[PATCH v4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-09-17 Thread Andrew Bresticker
In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is mapped to one of the three UTMI ports. The xHCI controller will also send messages intended for the PHY driver, so request and listen

[PATCH v4 0/9] Tegra xHCI support

2014-09-17 Thread Andrew Bresticker
This series adds support for xHCI on NVIDIA Tegra SoCs. This includes: - patches 1 and 2: adding a driver for the mailbox used to communicate with the xHCI controller's firmware, - patches 3 and 4: extending the XUSB pad controller driver to support the USB PHY types (UTMI, HSIC, and USB3)

[PATCH v4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-09-17 Thread Andrew Bresticker
The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single physical channel, messages sent by the controller can be divided into two groups: those intended for the PHY driver and those intended for the host-controller

Re: [PATCH 0/7] xhci: patches for usb-next

2014-09-17 Thread Greg KH
On Wed, Sep 17, 2014 at 04:35:41PM +0300, Mathias Nyman wrote: > Ping, > > Any plan on taking these to your usb-next branch? Yes, I plan to, been on the road, and am typing this from a conference. Hope to get to all of my pending patches "soon"... thanks, greg k-h -- To unsubscribe from this li

Re: [PATCHv4 04/12] usb: dwc2: Add the appropriate init calls in platform code

2014-09-17 Thread Dinh Nguyen
Hi Robert, On 9/12/14, 7:13 AM, Robert Baldyga wrote: > Hi Dinh, > > On 08/26/2014 06:19 PM, dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Add the proper init calls for either host, gadget or both in platform.c >> >> Signed-off-by: Dinh Nguyen >> Acked-by: Paul Zimmerman >>

Re: [PATCHv4 04/12] usb: dwc2: Add the appropriate init calls in platform code

2014-09-17 Thread Stephen Warren
On 09/17/2014 02:47 PM, Dinh Nguyen wrote: Hi Robert, On 9/12/14, 7:13 AM, Robert Baldyga wrote: Hi Dinh, On 08/26/2014 06:19 PM, dingu...@opensource.altera.com wrote: From: Dinh Nguyen Add the proper init calls for either host, gadget or both in platform.c Signed-off-by: Dinh Nguyen Acke

Re: [PATCH v2 4/4] usb: hub: rename khubd to hub_wq in documentation and comments

2014-09-17 Thread Tejun Heo
Hello, Alan, Petr. On Wed, Sep 17, 2014 at 01:36:26PM -0400, Alan Stern wrote: > > - /* If khubd ever becomes multithreaded, this will need a lock */ > > + /* If hub_wq ever becomes multithreaded, this will need a lock */ > > if (udev->wusb) { > > devnum = udev->portnum + 1; >

Re: [PATCHv4 06/12] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-09-17 Thread Dinh Nguyen
On 9/12/14, 7:50 AM, Robert Baldyga wrote: > Hi, > > On 08/26/2014 06:19 PM, dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Make dwc2_handle_common_intr call the gadget interrupt function when >> operating >> in peripheral mode. Remove the spinlock functions in s3c_hsotg_irq

Re: [PATCHv4 09/12] usb: dwc2: initialize the spin_lock for both host and gadget

2014-09-17 Thread Dinh Nguyen
On 9/12/14, 8:09 AM, Robert Baldyga wrote: > Hi, > > On 08/26/2014 06:20 PM, dingu...@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Move spin_lock_init to common location for both host and gadget. >> >> Signed-off-by: Dinh Nguyen >> --- >> v4: move spin_lock_init up to make sure sure

Re: [PATCH v3 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-17 Thread Vivek Gautam
Hi Alan, On Wed, Sep 17, 2014 at 8:27 PM, Alan Stern wrote: > On Wed, 17 Sep 2014, Vivek Gautam wrote: > >> Now that we have completely moved from older USB-PHY drivers >> to newer GENERIC-PHY drivers for PHYs available with USB controllers >> on Exynos series of SoCs, we can remove the support

[PATCH v4 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-17 Thread Vivek Gautam
Now that we have completely moved from older USB-PHY drivers to newer GENERIC-PHY drivers for PHYs available with USB controllers on Exynos series of SoCs, we can remove the support for the same in our host drivers too. We also defer the probe for our host in case we end up getting EPROBE_DEFER er

[PATCH v4 2/2] usb: host: ohci-exynos: Remove unnecessary usb-phy support

2014-09-17 Thread Vivek Gautam
Now that we have completely moved from older USB-PHY drivers to newer GENERIC-PHY drivers for PHYs available with USB controllers on Exynos series of SoCs, we can remove the support for the same in our host drivers too. We also defer the probe for our host in case we end up getting EPROBE_DEFER er

Re: [PATCH v2 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard

2014-09-17 Thread Lu Baolu
Hi Greg and Alan, Do you have any comments for this patch? I was working on system suspend/resume on T100 tablet. I found once the T100 base station keyboard has been stroked, system will not be able to enter freeze or S3 mode. I narrowed down this issue as "keyboard generates spurious remo