Re: Updated linux uas driver, please test

2014-09-11 Thread Hans de Goede
Hi, On 09/10/2014 10:54 PM, Douglas Gilbert wrote: > On 14-09-10 08:13 AM, Hans de Goede wrote: >> Hi All, >> >> I'm mailing all of you because you've reported various problems >> with the new uas support in kernel 3.16 and later. >> >> I've been working on making the uas driver more resilient to

[PATCH] uas: Add missing le16_to_cpu calls to asm1051 / asm1053 usb-id check

2014-09-11 Thread Hans de Goede
Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede --- drivers/usb/storage/uas-detect.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h index 1e298ec..8a6f371 100644 --- a/drivers/usb/storage/u

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-11 Thread Hans de Goede
Hi, On 09/10/2014 05:45 PM, Christoph Hellwig wrote: > On Wed, Sep 10, 2014 at 09:21:24AM +0200, Hans de Goede wrote: >> I've applied the patch, this results in the following new dmesg output >> when using uas: >> >> [ 120.602632] initialized host-wide tag map! >> >> Thank you for looking into th

Re: [PATCH] uas: Add missing le16_to_cpu calls to asm1051 / asm1053 usb-id check

2014-09-11 Thread Bjørn Mork
Hans de Goede writes: > --- a/drivers/usb/storage/uas-detect.h > +++ b/drivers/usb/storage/uas-detect.h > @@ -73,8 +73,8 @@ static int uas_use_uas_driver(struct usb_interface *intf, >* broken on the ASM1051, use the number of streams to differentiate. >* New ASM1053-s also support

[PATCH 1/3] xhci: Fix null pointer dereference if xhci initialization fails

2014-09-11 Thread Mathias Nyman
If xhci initialization fails before the roothub bandwidth domains (xhci->rh_bw[i]) are allocated it will oops when trying to access rh_bw members in xhci_mem_cleanup(). Reported-by: Manuel Reimer Cc: stable Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-mem.c | 2 +- 1 file changed, 1

[PATCH 2/3] usb: xhci: Fix OOPS in xhci error handling code

2014-09-11 Thread Mathias Nyman
From: Al Cooper The xhci driver will OOPS on resume from S2/S3 if dma_alloc_coherent() is out of memory. This is a result of two things: 1. xhci_mem_cleanup() in xhci-mem.c free's xhci->lpm_command if it's not NULL, but doesn't set it to NULL after the free. 2. xhci_mem_cleanup() is called twice

[PATCH 0/3] xhci fixes for usb-linus 3.17-rc

2014-09-11 Thread Mathias Nyman
Hi Greg These 3 xhci patches for usb-linus fix null pointer issues discovered lately. All of them are small and simple, and marked for stable as well. -Mathias Al Cooper (1): usb: xhci: Fix OOPS in xhci error handling code Mathias Nyman (2): xhci: Fix null pointer dereference if xhci initi

[PATCH 3/3] xhci: fix oops when xhci resumes from hibernate with hw lpm capable devices

2014-09-11 Thread Mathias Nyman
Resuming from hibernate (S4) will restart and re-initialize xHC. The device contexts are freed and will be re-allocated later during device reset. Usb core will disable link pm in device resume before device reset, which will try to change the max exit latency, accessing the device contexts befor

Re: 3.15.6 USB issue with pwc cam

2014-09-11 Thread Udo van den Heuvel
On 2014-08-14 15:23, Mathias Nyman wrote: > The error: > [53009.847233] xhci_hcd :02:00.0: ERROR: unexpected command completion > code 0x11. > > Means we got a parameter error, one of the values the xhci driver sends to > the controller > in the configure endpoint command is invalid. Are my

[PATCH] storage: Add single-LUN quirk for Jaz USB Adapter

2014-09-11 Thread Mark
Hi, The Iomega Jaz USB Adapter is a SCSI-USB converter cable. The hardware seems to be identical to e.g. the Microtech XpressSCSI, using a Shuttle/ SCM chip set. However its firmware restricts it to only work with Jaz drives. On connecting the cable a message like this appears four times in the l

[PATCH net-next] r8152: support VLAN

2014-09-11 Thread Hayes Wang
Support hw VLAN for tx and rx. And enable them by default. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 85 + 1 file changed, 71 insertions(+), 14 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 2130c75

Re: [PATCHv3 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-09-11 Thread Robert Baldyga
Hi Dinh, On 08/08/2014 11:13 PM, dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > Update DWC2 kconfig and makefile to support dual-role mode. The platform > file will always get compiled for the case where the controller is directly > connected to the CPU. So for loadable modules, o

Re: [PATCHv4 02/12] usb: dwc2: move "samsung,s3c6400-hsotg" into common platform

2014-09-11 Thread Robert Baldyga
On 08/26/2014 06:19 PM, dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > Move the "samsung,s3c6400-hsotg" binding as the probe function in the gadget > driver will get removed when the dual-role driver is implemented. > > Signed-off-by: Dinh Nguyen > Acked-by: Paul Zimmerman > ---

[PATCH 2/2] Revert "usb: dwc2: move "samsung,s3c6400-hsotg" into common platform"

2014-09-11 Thread Robert Baldyga
This reverts commit 8df438571cdbd5c4fcd1b25b19eea1ad5c3cf777. This patch breaks building dwc2 driver in gadget mode at samsung platforms. --- drivers/usb/dwc2/gadget.c | 1 + drivers/usb/dwc2/platform.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.

[PATCH 1/2] Revert "usb: dwc2: Update Kconfig to support dual-role"

2014-09-11 Thread Robert Baldyga
This reverts commit e006fee6ecfed5b957bdd41c236aad751ab29042. This patch causes build break. Modifications in Makefile and Kconfig have no connection with driver code. Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/Kconfig | 63 --- drivers/usb/d

[PATCH 0/2] usb: dwc2: Revert patches causing problems

2014-09-11 Thread Robert Baldyga
These two patches breaks dwc2 driver. The first one causes build break, the second breaks gadget at Samsung platforms. Best regards Robert Baldyga Robert Baldyga (2): Revert "usb: dwc2: Update Kconfig to support dual-role" Revert "usb: dwc2: move "samsung,s3c6400-hsotg" into common platform"

Re: [PATCH net-next] r8152: support VLAN

2014-09-11 Thread David Miller
From: Hayes Wang Date: Thu, 11 Sep 2014 20:16:24 +0800 > - ocp_data = ocp_read_word(tp, MCU_TYPE_PLA, PLA_CPCR); > - ocp_data &= ~CPCR_RX_VLAN; > - ocp_write_word(tp, MCU_TYPE_PLA, PLA_CPCR, ocp_data); > + if (tp->netdev->features & NETIF_F_HW_VLAN_CTAG_RX) > + rtl_rx_

Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

2014-09-11 Thread Kishon Vijay Abraham I
Hi, On Thursday 21 August 2014 05:03 PM, Heikki Krogerus wrote: > On some platforms a PHY may need to be handled also in the > host controller driver. Exynos5420 SoC requires some "PHY > tuning" based on the USB speed. This patch delivers dwc3's > PHYs to the xhci platform device when it's created

Re: [PATCH 3/6] arm: omap3: twl: use the new lookup method with usb phy

2014-09-11 Thread Kishon Vijay Abraham I
Hi, On Thursday 21 August 2014 05:03 PM, Heikki Krogerus wrote: > Provide complete association for the phy and it's user > (musb) with the new phy lookup method. > > Signed-off-by: Heikki Krogerus > --- > arch/arm/mach-omap2/twl-common.c | 18 -- > 1 file changed, 8 insertions(+

Re: [PATCH v4 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-11 Thread Antoine Tenart
Peter, On Thu, Sep 11, 2014 at 09:07:10AM +0800, Peter Chen wrote: > On Wed, Sep 03, 2014 at 09:48:26AM +0200, Antoine Tenart wrote: > > + > > +static int ci_hdrc_usb2_dt_probe(struct device *dev, > > +struct ci_hdrc_platform_data *ci_pdata) > > +{ > > + ci_pdata->phy

Re: [PATCH 2/6] phy: improved lookup method

2014-09-11 Thread Kishon Vijay Abraham I
Hi, On Thursday 21 August 2014 05:03 PM, Heikki Krogerus wrote: > Removes the need for the phys to be aware of their users > even when not using DT. The method is copied from clkdev.c. > > Signed-off-by: Heikki Krogerus > Tested-by: Vivek Gautam > --- > . . . . > > diff --git a/drivers/phy/

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-11 Thread Kishon Vijay Abraham I
Hi, On Wednesday 10 September 2014 01:26 PM, Vivek Gautam wrote: > On Wed, Sep 10, 2014 at 10:53 AM, Vivek Gautam > wrote: >> On Wed, Sep 10, 2014 at 10:23 AM, Felipe Balbi wrote: >>> On Wed, Sep 10, 2014 at 09:09:57AM +0530, Vivek Gautam wrote: On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gauta

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-11 Thread Antoine Tenart
Peter, On Thu, Sep 11, 2014 at 08:54:47AM +0800, Peter Chen wrote: > On Wed, Sep 03, 2014 at 09:40:40AM +0200, Antoine Tenart wrote: > > @@ -595,23 +639,27 @@ static int ci_hdrc_probe(struct platform_device *pdev) > > return -ENODEV; > > } > > > > - if (ci->platdata->usb_phy) >

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-11 Thread Christoph Hellwig
On Thu, Sep 11, 2014 at 12:01:13PM +0200, Hans de Goede wrote: > > So we're initializing the tag map, but scsi_activate_tcq doesn't pick it > > up. I can't really come up with a good explanation for it, but there > > even without that there is an elephant in the room: as part of the > > scsi-mq s

[PATCHv2] usb: f_fs: replace BUG in dead-code with less serious WARN_ON

2014-09-11 Thread Michal Nazarewicz
Even though the BUG() in __ffs_event_add is a dead-code, it is still better to warn rather then crash the system if that code ever gets executed. Reported-by: Felipe Balbi Signed-off-by: Michal Nazarewicz --- drivers/usb/gadget/function/f_fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-11 Thread Felipe Balbi
Hi, On Thu, Sep 11, 2014 at 09:10:21PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 10 September 2014 01:26 PM, Vivek Gautam wrote: > > On Wed, Sep 10, 2014 at 10:53 AM, Vivek Gautam > > wrote: > >> On Wed, Sep 10, 2014 at 10:23 AM, Felipe Balbi wrote: > >>> On Wed, Sep 10, 2014

Re: [PATCHv2] usb: f_fs: replace BUG in dead-code with less serious WARN_ON

2014-09-11 Thread Felipe Balbi
On Thu, Sep 11, 2014 at 06:52:49PM +0200, Michal Nazarewicz wrote: > Even though the BUG() in __ffs_event_add is a dead-code, it is still > better to warn rather then crash the system if that code ever gets > executed. > > Reported-by: Felipe Balbi > Signed-off-by: Michal Nazarewicz > --- > dri

RE: [PATCHv3 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-09-11 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Thursday, September 11, 2014 5:43 AM > > On 08/08/2014 11:13 PM, dingu...@opensource.altera.com wrote: > > From: Dinh Nguyen > > > > Update DWC2 kconfig and makefile to support dual-role mode. The platform > > file will always get comp

RE: [PATCH 0/2] usb: dwc2: Revert patches causing problems

2014-09-11 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Thursday, September 11, 2014 5:53 AM > > These two patches breaks dwc2 driver. The first one causes build break, > the second breaks gadget at Samsung platforms. > > Best regards > Robert Baldyga > > Robert Baldyga (2): > Revert "us

Hitting "unused qh not empty" BUG in qh_destroy

2014-09-11 Thread Joe Lawrence
Hi Alan, I've got another USB bug to report that manifests during automated device removal testing on RHEL7. This one hits the BUG() inside qh_destroy: PID: 139TASK: 881054101960 CPU: 22 COMMAND: "kworker/u66:0" #0 [881054113540] machine_kexec at 810411b1 #1 [88105411

RE: [PATCH 0/2] usb: dwc2: Revert patches causing problems

2014-09-11 Thread Paul Zimmerman
> From: Paul Zimmerman > Sent: Thursday, September 11, 2014 12:11 PM > > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > > Sent: Thursday, September 11, 2014 5:53 AM > > > > These two patches breaks dwc2 driver. The first one causes build break, > > the second breaks gadget at Samsung plat

Re: [PATCH 0/2] usb: dwc2: Revert patches causing problems

2014-09-11 Thread gre...@linuxfoundation.org
On Thu, Sep 11, 2014 at 07:11:20PM +, Paul Zimmerman wrote: > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > > Sent: Thursday, September 11, 2014 5:53 AM > > > > These two patches breaks dwc2 driver. The first one causes build break, > > the second breaks gadget at Samsung platforms.

RE: [PATCH 0/2] usb: dwc2: Revert patches causing problems

2014-09-11 Thread Paul Zimmerman
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Thursday, September 11, 2014 1:20 PM > > On Thu, Sep 11, 2014 at 07:11:20PM +, Paul Zimmerman wrote: > > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > > > Sent: Thursday, September 11, 2014 5:53 AM > > > >

RE: [PATCH 0/2] usb: dwc2: Revert patches causing problems

2014-09-11 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Paul Zimmerman > Sent: Thursday, September 11, 2014 1:10 PM > > > From: Paul Zimmerman > > Sent: Thursday, September 11, 2014 12:11 PM > > > > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > >

Re: [PATCH] uas: Add missing le16_to_cpu calls to asm1051 / asm1053 usb-id check

2014-09-11 Thread Greg Kroah-Hartman
On Thu, Sep 11, 2014 at 11:06:12AM +0200, Hans de Goede wrote: > Cc: sta...@vger.kernel.org # 3.16 > Signed-off-by: Hans de Goede > --- > drivers/usb/storage/uas-detect.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) You forgot the reported-by line, I'll go add it... -- To unsubscr

[GIT PULL] USB fixes for v3.17-rc4

2014-09-11 Thread Felipe Balbi
Hi Greg, Here's another set of fixes for v3.17. By the looks of things, I suppose this is my last pull request for v3.17. I should have my v3.18 pull ready by end of next week. Let me know if you need anything to be changed. cheers The following changes since commit 9ce9ec95fb9b82e09b55a52f1bb8

Re: [GIT PULL] USB fixes for v3.17-rc4

2014-09-11 Thread Greg KH
On Thu, Sep 11, 2014 at 05:02:10PM -0500, Felipe Balbi wrote: > Hi Greg, > > Here's another set of fixes for v3.17. By the looks of things, I suppose > this is my last pull request for v3.17. I should have my v3.18 pull > ready by end of next week. > > Let me know if you need anything to be chang

[PATCH] usb: dwc2: make the scheduler handle excessive NAKs better

2014-09-11 Thread Paul Zimmerman
From: Nick Hudson I'm seeing problems with a d-link dwcl-g122 wifi dongle that someone sent me. There are reports of other wifi dongles with the same/similar problem. The devices appear to be NAKing to the point of confusing the dwc2 driver completely. The attached patch helps with my d-link dwl

Re: [PATCH] usb: dwc2: make the scheduler handle excessive NAKs better

2014-09-11 Thread Greg KH
On Thu, Sep 11, 2014 at 03:22:48PM -0700, Paul Zimmerman wrote: > From: Nick Hudson > > I'm seeing problems with a d-link dwcl-g122 wifi dongle that > someone sent me. There are reports of other wifi dongles with the > same/similar problem. The devices appear to be NAKing to the point > of confus

RE: [PATCH] usb: dwc2: make the scheduler handle excessive NAKs better

2014-09-11 Thread Paul Zimmerman
> From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, September 11, 2014 3:27 PM > > On Thu, Sep 11, 2014 at 03:22:48PM -0700, Paul Zimmerman wrote: > > From: Nick Hudson > > > > I'm seeing problems with a d-link dwcl-g122 wifi dongle that > > someone sent me. There are reports of

RE: [PATCH v4 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-11 Thread Peter Chen
> On Thu, Sep 11, 2014 at 09:07:10AM +0800, Peter Chen wrote: > > On Wed, Sep 03, 2014 at 09:48:26AM +0200, Antoine Tenart wrote: > > > + > > > +static int ci_hdrc_usb2_dt_probe(struct device *dev, > > > + struct ci_hdrc_platform_data *ci_pdata) { > > > + ci_pdata->phy =

RE: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-11 Thread Peter Chen
> On Thu, Sep 11, 2014 at 08:54:47AM +0800, Peter Chen wrote: > > On Wed, Sep 03, 2014 at 09:40:40AM +0200, Antoine Tenart wrote: > > > @@ -595,23 +639,27 @@ static int ci_hdrc_probe(struct platform_device > *pdev) > > > return -ENODEV; > > > } > > > > > > - if (ci->platdata->usb_phy

[PATCH 1/1] usb: gadget: udc-core: add utility for bus reset

2014-09-11 Thread Peter Chen
The udc driver can notify the udc core that bus reset occurs by calling this utility, the core will notify gadget driver this information and update gadget state accordingly. Signed-off-by: Peter Chen --- drivers/usb/gadget/udc/udc-core.c | 17 + include/linux/usb/gadget.h

[PATCH net-next v2] r8152: support VLAN

2014-09-11 Thread Hayes Wang
Support hw VLAN for tx and rx. And enable them by default. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 79 - 1 file changed, 65 insertions(+), 14 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 2130c75

Re: usb sound cannot get frequency from enpoind

2014-09-11 Thread vichy
hi all: I get the same message on kernel 3.16.0 and attach the device information as well. (from the description, the ep 0x82 did have different sample rate configuration, but why uac cannot get it?) appreciate your help, Interface Descriptor: bLength 9 bDescriptorT

Re: usb sound cannot get frequency from enpoind

2014-09-11 Thread Clemens Ladisch
vichy wrote: >> ALSA sound/usb/clock.c:237 2:3:1: cannot get freq at ep 0x82 >> ALSA sound/usb/mixer.c:929 5:2: cannot get min/max values for control 2 (id >> 5) >> ALSA sound/usb/mixer.c:929 5:2: cannot get min/max values for control 2 (id >> 5) > > (from the description, the ep 0x82 did have di