Re: [RFC v2 2/2] usb: phy: Temporarily hold wakeupsource on charger connect and disconnect events

2014-09-05 Thread Todd Poynor
On Tue, Sep 2, 2014 at 7:54 AM, Felipe Balbi wrote: > Hi, > > On Tue, Sep 02, 2014 at 05:19:18PM +0530, Kiran Kumar Raparthy wrote: ... >> diff --git a/drivers/usb/phy/otg-wakeupsource.c >> b/drivers/usb/phy/otg-wakeupsource.c >> index fca2010..70fa05e 100644 >> --- a/drivers/usb/phy/otg-wakeupso

Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

2014-09-05 Thread Linus Walleij
On Thu, Sep 4, 2014 at 11:57 PM, Benjamin Henrion wrote: > On Thu, Sep 4, 2014 at 7:35 PM, Wang YanQing wrote: >> On Sun, Aug 31, 2014 at 11:24:56PM +0800, Wang YanQing wrote: >>> PL2303 USB Serial devices may has GPIOs, this patch add >>> basic PL2303 gpio support. >>> >>> Known issue: >>> If gp

RE: ax88179_178a hang over xhci

2014-09-05 Thread David Laight
> On Wed, Aug 20, 2014 at 04:12:49PM +0200, Andrea Arcangeli wrote: > > Hi Sarah, > > > > just a short followup on this. I still had 1gbps hangs with the > > 0b95:1790 ASIX Electronics Corp device using xhci. But it seems now > > stable for the last 12 hours under heavy load after I removed all > >

Re: [rfc]your patch to deal with devices that need continous data traffic

2014-09-05 Thread Oliver Neukum
On Thu, 2014-09-04 at 13:36 +0200, Johan Hovold wrote: > I got side-tracked with other stuff, but I should be able to submit the > patch this week (just want to look through it once more first). > > Not sure the mark-last-busy needs to be moved, though. The device has > already been woken up, and

Re: [rfc]your patch to deal with devices that need continous data traffic

2014-09-05 Thread Johan Hovold
On Fri, Sep 05, 2014 at 11:05:46AM +0200, Oliver Neukum wrote: > On Thu, 2014-09-04 at 13:36 +0200, Johan Hovold wrote: > > > I got side-tracked with other stuff, but I should be able to submit the > > patch this week (just want to look through it once more first). > > > > Not sure the mark-last-

Re: [rfc]your patch to deal with devices that need continous data traffic

2014-09-05 Thread Johan Hovold
On Thu, Sep 04, 2014 at 03:40:03PM +0200, Oliver Neukum wrote: > On Thu, 2014-09-04 at 13:36 +0200, Johan Hovold wrote: > > On Thu, Sep 04, 2014 at 12:44:37PM +0200, Oliver Neukum wrote: > > > Hi, > > > > > > I also got a problem with such a device and I took your patch > > > and applied it to thi

Re: [rfc]your patch to deal with devices that need continous data traffic

2014-09-05 Thread Oliver Neukum
On Fri, 2014-09-05 at 12:15 +0200, Johan Hovold wrote: > On Fri, Sep 05, 2014 at 11:05:46AM +0200, Oliver Neukum wrote: > > on second thought I think that your moving of remote_wakeup is not good. > > If we'd discard input anyway, we don't need to wake up devices for them. > > I'm afraid we have

Re: gadget serial driver - configuration value

2014-09-05 Thread Anjana V Kumar
On Thu, Sep 4, 2014 at 7:38 PM, Alan Stern wrote: > On Thu, 4 Sep 2014, Anjana V Kumar wrote: > >> >> We see that, the three configurations listed in serial driver (CDC >> >> ACM, CDC OBEX, generic serial) cannot be present together as per the >> >> current implementation. Is there a specific reas

usb_acpi_set_power_state() and usb_queue_reset_device()

2014-09-05 Thread Oliver Neukum
Hi, looking at your patch for resetting HID devices it occurred to me that there's a race between a queued reset and a port power switch. Switching a port's power state implies to a reset for for all interfaces of the device connected to that port. As a reset is quite disruptive it seems to me th

Re: [PATCH v5 1/2] usb: rename phy to usb_phy in HCD

2014-09-05 Thread Felipe Balbi
On Fri, Sep 05, 2014 at 01:42:09AM +0400, Sergei Shtylyov wrote: > From: Antoine Tenart > > The USB PHY member of the HCD structure is renamed to 'usb_phy' and > modifications are done in all drivers accessing it. > This is in preparation to adding the generic PHY support. > > Signed-off-by: Ant

Re: [PATCH v3 0/6] usb: host: change TPL support behaviour

2014-09-05 Thread Alan Stern
On Fri, 5 Sep 2014, Peter Chen wrote: > On Thu, Sep 04, 2014 at 11:12:42AM -0400, Alan Stern wrote: > > On Thu, 4 Sep 2014, Peter Chen wrote: > > > > > On Wed, Sep 03, 2014 at 09:48:15PM -0400, Alan Stern wrote: > > > > On Thu, 4 Sep 2014, Peter Chen wrote: > > > > > > > > > > > > Hi Greg & Alan

Re: usb_acpi_set_power_state() and usb_queue_reset_device()

2014-09-05 Thread Alan Stern
On Fri, 5 Sep 2014, Oliver Neukum wrote: > Hi, > > looking at your patch for resetting HID devices > it occurred to me that there's a race between > a queued reset and a port power switch. Switching > a port's power state implies to a reset for for > all interfaces of the device connected to that

[PATCH 1/1] for HID core dot c

2014-09-05 Thread Hans Petter Selasky
See attachment. Thank you! --HPS commit 862e8673263b82652b5738ccda4f8367959fa234 Author: Hans Petter Selasky Date: Fri Sep 5 11:07:15 2014 +0200 Correct argument for Module parameter description. Signed-off-by: Hans Petter Selasky diff --git a/drivers/hid/hid-core.c b/drivers/

[PATCH] usb: dwc3: fix TRB completion when multiple TRBs are started

2014-09-05 Thread Felipe Balbi
After commit 2ec2a8be (usb: dwc3: gadget: always enable IOC on bulk/interrupt transfers) we created a situation where it was possible to hang a bulk/interrupt endpoint if we had more than one pending request in our queue and they were both started with a single Start Transfer command. The problems

Re: [RFC v2 2/2] usb: phy: Temporarily hold wakeupsource on charger connect and disconnect events

2014-09-05 Thread Felipe Balbi
On Fri, Sep 05, 2014 at 12:40:22AM -0700, Todd Poynor wrote: > On Tue, Sep 2, 2014 at 7:54 AM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Sep 02, 2014 at 05:19:18PM +0530, Kiran Kumar Raparthy wrote: > ... > >> diff --git a/drivers/usb/phy/otg-wakeupsource.c > >> b/drivers/usb/phy/otg-wakeupsour

Re: [PATCH 1/1] for HID core dot c

2014-09-05 Thread Frans Klaver
Hi, On Fri, Sep 5, 2014 at 4:07 PM, Hans Petter Selasky wrote: > See attachment. It's preferred that you send your patches in the body of the email. Please read Documentation/SubmittingPatches. Frans -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a messag

[PATCH 0/1] for HID core dot c

2014-09-05 Thread Hans Petter Selasky
Hi, Looks like the first argument for MODULE_PARAM_DESC() is incorrect. --HPS commit 862e8673263b82652b5738ccda4f8367959fa234 Author: Hans Petter Selasky Date: Fri Sep 5 11:07:15 2014 +0200 Correct argument for Module parameter description. Signed-off-by: Hans Petter Selasky

Re: [PATCH 1/1] for HID core dot c

2014-09-05 Thread Hans Petter Selasky
On 09/05/14 16:20, Frans Klaver wrote: Hi, On Fri, Sep 5, 2014 at 4:07 PM, Hans Petter Selasky wrote: See attachment. It's preferred that you send your patches in the body of the email. Please read Documentation/SubmittingPatches. Frans -- To unsubscribe from this list: send the line "unsub

[PATCH 1/4] usb: dwc3: move all string helper functions to debug.h

2014-09-05 Thread Felipe Balbi
Those functions are only using within debugging messages, grouping them into debug.h makes sense. While at that, also add missing multiple inclusion guard. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/debug.h | 164 +- drivers/usb/dwc3/ep0.c|

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-09-05 Thread Felipe Balbi
On Wed, Sep 03, 2014 at 11:58:26AM +0530, Pratyush Anand wrote: > On Wed, Aug 27, 2014 at 05:26:37AM +0800, Felipe Balbi wrote: > > Hi Felipe, > > > Hi, > > > > On Tue, Aug 26, 2014 at 09:21:55PM +, Paul Zimmerman wrote: > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Tuesday,

[PATCH 2/4] usb: dwc3: debug: add dwc3_gadget_event_type_string

2014-09-05 Thread Felipe Balbi
this new helper will return a pretty string for DWC3 Gadget Events. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/debug.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/usb/dwc3/debug.h b/drivers/usb/dwc3/debug.h index e35a3d1..12ff4c9 100644 -

[PATCH] USB: storage: use %*ph specifier to dump small buffers

2014-09-05 Thread Andy Shevchenko
Instead of dereference each byte let's use %*ph specifier in the printk() calls. Signed-off-by: Andy Shevchenko --- drivers/usb/storage/alauda.c | 11 --- drivers/usb/storage/sddr09.c | 3 +-- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/

[PATCH 3/4] usb: dwc3: gadget: cmd argument should always be unsigned

2014-09-05 Thread Felipe Balbi
No functional changes, just making sure we're dealing with unsigned ints. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.h | 2 +- drivers/usb/dwc3/gadget.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 48f

[PATCH 4/4] usb: dwc3: add tracepoints to aid debugging

2014-09-05 Thread Felipe Balbi
When we're debugging hard-to-reproduce and time-sensitive use cases, printk() poses too much overhead. That's when the kernel's tracing infrastructure comes into play. This patch implements a few initial tracepoints for the dwc3 driver. More traces can be added as necessary in order to ease the ta

[PATCH v3 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-05 Thread Octavian Purdila
This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Information about the USB protocol can be found in the Programmer's Reference Manual [1], see section 1.7. Because th

[PATCH v3 0/3] mfd: add support for Diolan DLN-2

2014-09-05 Thread Octavian Purdila
This patch series adds support for Diolan USB-I2C/GPIO Master Adapter DLN-2. Details about device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Changes since v2: * MFD driver: fix a few obsolete comments for the DLN2 I/O API * GPIO driver: retry the chip remove call if -EB

[PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-05 Thread Octavian Purdila
From: Daniel Baluta This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 2.9 for the GPIO module commands and responses. [1] https://www.diolan.com/downloads/dln-api

[PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-05 Thread Octavian Purdila
From: Laurentiu Palcu This patch adds support for the Diolan DLN-2 I2C master module. Due to hardware limitations it does not support SMBUS quick commands. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 6.2.2 for the I2C master mod

[PATCH v6 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-09-05 Thread Peter Griffin
This patch adds the new dwc3-st.c glue driver found on STMicroelectronics stih407 consumer electronics SoC's into the STI arch section of the maintainers file. Signed-off-by: Peter Griffin Acked-by: Lee Jones --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAIN

[PATCH v6 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-09-05 Thread Peter Griffin
This patch adds the ST glue logic to manage the DWC3 HC on STiH407 SoC family. It manages the powerdown signal, and configures the internal glue logic and syscfg registers. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones --- drivers/usb/dwc3/Kconfig | 9 +

[PATCH v6 0/3] Add ST dwc3 glue layer driver

2014-09-05 Thread Peter Griffin
This series adds support for the ST glue logic which wraps the DWC3 controller on STiH407 SoC family chipsets. Changes since v5 - Use of_platform_depopulate Changes since v4 - Fix bug with setting bits in usb control register - Remove superflous '\n' - Change default Kconfig to make default s

[PATCH v6 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-09-05 Thread Peter Griffin
This patch documents the device tree documentation required for the ST usb3 controller glue layer found in STiH407 devices. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Peter Griffin Acked-by: Lee Jones --- Documentation/devicetree/bindings/usb/dwc3-st.txt | 68 +++ 1 f

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-05 Thread Johan Hovold
On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > +static int dln2_do_remove(struct dln2_gpio *dln2) > +{ > + /* When removing the DLN2 USB device, gpiochip_remove may fail > + * due to i2c drivers holding a GPIO pin. However, the i2c bus > + * will eventually be re

Re: [PATCH v6 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-09-05 Thread Felipe Balbi
Hi, On Fri, Sep 05, 2014 at 04:36:30PM +0100, Peter Griffin wrote: > +static int st_dwc3_remove_child(struct device *dev, void *c) > +{ > + struct platform_device *pdev = to_platform_device(dev); > + > + of_device_unregister(pdev); > + > + return 0; > +} > + > +static int st_dwc3_remov

Re: [PATCH v6 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-09-05 Thread Felipe Balbi
On Fri, Sep 05, 2014 at 10:47:01AM -0500, Felipe Balbi wrote: > Hi, > > On Fri, Sep 05, 2014 at 04:36:30PM +0100, Peter Griffin wrote: > > +static int st_dwc3_remove_child(struct device *dev, void *c) > > +{ > > + struct platform_device *pdev = to_platform_device(dev); > > + > > + of_device_un

Re: [PATCH v5 1/4] usb: gadget: pxa27x_udc: add devicetree support

2014-09-05 Thread Felipe Balbi
Hi, On Sun, Aug 31, 2014 at 09:02:09PM +0200, Robert Jarzmik wrote: > Add support for device-tree device discovery. If devicetree is not > provided, fallback to legacy platform data "discovery". > > Signed-off-by: Robert Jarzmik > Cc: devicet...@vger.kernel.org please split this patch. First ad

Re: [RFC PATCH 0/7] usb: gadget: add reset API at usb_gadget_driver

2014-09-05 Thread Felipe Balbi
On Fri, Sep 05, 2014 at 08:44:08AM +0800, Peter Chen wrote: > On Thu, Sep 04, 2014 at 11:04:38AM -0400, Alan Stern wrote: > > On Thu, 4 Sep 2014, Peter Chen wrote: > > > > > Hi Felipe & Alan, how about using below steps for this reset/vbus/pullup > > > changes? It mainly uses Alan's suggestion. >

Re: ax88179_178a hang over xhci

2014-09-05 Thread Andrea Arcangeli
On Fri, Sep 05, 2014 at 08:53:59AM +, David Laight wrote: > > On Wed, Aug 20, 2014 at 04:12:49PM +0200, Andrea Arcangeli wrote: > > > Hi Sarah, > > > > > > just a short followup on this. I still had 1gbps hangs with the > > > 0b95:1790 ASIX Electronics Corp device using xhci. But it seems now >

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-05 Thread Octavian Purdila
On Fri, Sep 5, 2014 at 6:38 PM, Johan Hovold wrote: > On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > >> +static int dln2_do_remove(struct dln2_gpio *dln2) >> +{ >> + /* When removing the DLN2 USB device, gpiochip_remove may fail >> + * due to i2c drivers holding a GPI

[PATCH 1/2] HID: usbhid: add always-poll quirk

2014-09-05 Thread Johan Hovold
Add quirk to make sure that a device is always polled for input events even if it hasn't been opened. This is needed for devices that disconnects from the bus unless the interrupt endpoint has been polled at least once or when not responding to an input event (e.g. after having shut down X). Sign

[PATCH 0/2] HID: usbhid: fix Elan touchscreen disconnects

2014-09-05 Thread Johan Hovold
Here's the always-poll quirk that is needed to prevent the Elan touchscreen from disconnecting itself from the bus. These patches are against v3.16.1, but applies fine to hid-next. Note that this series is not dependent on the device-qualifier quirk [1], which is needed to get the same device to

[PATCH 2/2] HID: usbhid: enable always-poll quirk for Elan Touchscreen

2014-09-05 Thread Johan Hovold
Enable the always-poll quirk for Elan Touchscreens found on some recent Samsung laptops. Without this quirk the device keeps disconnecting from the bus (and is re-enumerated) unless opened (and kept open, should an input event occur). Note that while the device can be run-time suspended, the auto

Re: Similar Elan Touchscreen reset behaviour

2014-09-05 Thread Johan Hovold
On Thu, Sep 04, 2014 at 02:54:23PM -0700, Greg KH wrote: > On Thu, Sep 04, 2014 at 02:30:40PM -0700, Sarah Sharp wrote: > > On Sat, Aug 16, 2014 at 12:37:19AM -0700, Eric Decker wrote: > > > Hi Sarah, > > > > > > I talked to you a while back about the ELAN touchscreen in my ASUS laptop > > > doing

Re: [PATCH 0/2] USB: core: add add device-qualifier quirk

2014-09-05 Thread Johan Hovold
On Mon, Aug 25, 2014 at 05:51:25PM +0200, Johan Hovold wrote: > This is quirk is indeed needed to get the Elan Touchscreen found on some > Samsung laptops to enumerate reliably. > > I'm still looking into the disconnects I've been experiencing. For some > reason I cannot reproduce the repeated dis

Re: [PATCH v6 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-09-05 Thread Peter Griffin
Hi Felipe, On Fri, 05 Sep 2014, Felipe Balbi wrote: > > > + > > > + device_for_each_child(&pdev->dev, NULL, st_dwc3_remove_child); > > > > same as before, of_platform_depopulate(). I can fix this one myself this > > time. Oh sorry, not sure what happened there, thanks for fixing it up:-) > > it

Re: [PATCH v6 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-09-05 Thread Felipe Balbi
On Fri, Sep 05, 2014 at 05:55:20PM +0100, Peter Griffin wrote: > Hi Felipe, > > On Fri, 05 Sep 2014, Felipe Balbi wrote: > > > > + > > > > + device_for_each_child(&pdev->dev, NULL, st_dwc3_remove_child); > > > > > > same as before, of_platform_depopulate(). I can fix this one myself this >

[PATCH RESEND v5 5/5] MAINTAINERS: Add ehci-st.c and ohci-st.c to ARCH/STI architecture

2014-09-05 Thread Peter Griffin
This patch adds the ehci-st.c and ohci-st.c files for the usb 2.0 & usb1.1 host controller drivers found on stih41x and stih4xx STMicroelectronics SoC's into the STI arch section of the maintainers file. Signed-off-by: Peter Griffin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff -

[PATCH RESEND v5 3/5] usb: host: ehci-st: Add ehci-st devicetree bindings documentation

2014-09-05 Thread Peter Griffin
This patch documents the device tree bindings required for the ehci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ehci-st.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 Doc

[PATCH RESEND v5 4/5] usb: host: ohci-st: Add ohci-st devicetree bindings documentation

2014-09-05 Thread Peter Griffin
This patch documents the device tree bindings required for the ohci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ohci-st.txt | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 Doc

[PATCH RESEND v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-09-05 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip EHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Griffin ---

[PATCH RESEND v5 2/5] usb: host: ohci-st: Add OHCI driver support for ST STB devices

2014-09-05 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip OHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Griffin ---

[PATCH RESEND v5 0/5] Add EHCI and OHCI drivers for STi SoC's

2014-09-05 Thread Peter Griffin
Hi, As part of the RESEND I've rebased this series on top of 3.17-rc3. I believe all feedback has been addressed. The series was re-worked from v2 onwards to split out the ehci and ohci parts into their own drivers / devices like most other ARM platforms based on feedback from Arnd Bergmann (see

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with >2TB HDDs)

2014-09-05 Thread Alan Stern
On Wed, 3 Sep 2014, James Bottomley wrote: > On Wed, 2014-09-03 at 16:30 -0400, Alan Stern wrote: > > On Wed, 3 Sep 2014, James Bottomley wrote: > > > > > Before we embark on elaborate hacks, why don't we just make the capacity > > > writeable (by root) in sysfs from userspace (will require block

Re: [PATCH v7 2/2] usb: gadget: f_fs: virtual endpoint address mapping

2014-09-05 Thread Felipe Balbi
On Thu, Sep 04, 2014 at 08:32:18AM +0200, Robert Baldyga wrote: > This patch introduces virtual endpoint address mapping. It separates > function logic form physical endpoint addresses making it more hardware > independent. > > Following modifications changes user space API, so to enable them user

Re: [PATCH RESEND v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-09-05 Thread Arnd Bergmann
On Friday 05 September 2014 18:23:45 Peter Griffin wrote: > +struct st_platform_priv { > + struct clk *clks[USB_MAX_CLKS]; > + struct clk *clk48; > + struct reset_control *rst; > + struct reset_control *pwr; > + struct phy *phy; > +}; Any reason why this is in a share

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-05 Thread Felipe Balbi
On Thu, Sep 04, 2014 at 12:01:19PM +0530, Vivek Gautam wrote: > > Don't we have phy_power_on() > > for that ? It looks like you could just as well do this from > > phy_power_on() ? > > No, unfortunately keeping these calibration settings in phy_power_on() > doesn't help, since we need to do this a

Re: [PATCH RESEND v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-09-05 Thread Peter Griffin
Hi Arnd, On Fri, 05 Sep 2014, Arnd Bergmann wrote: > On Friday 05 September 2014 18:23:45 Peter Griffin wrote: > > +struct st_platform_priv { > > + struct clk *clks[USB_MAX_CLKS]; > > + struct clk *clk48; > > + struct reset_control *rst; > > + struct reset_control *pwr; >

RE: [PATCH 1/4] usb: dwc3: move all string helper functions to debug.h

2014-09-05 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, September 05, 2014 7:56 AM > > Those functions are only using within debugging > messages, grouping them into debug.h makes sense. > > While at that, also add missing multiple inclusion > guard. > > Signed-off-by: Felipe Balbi > --- >

Re: [PATCH RESEND v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-09-05 Thread Arnd Bergmann
On Friday 05 September 2014 19:16:36 Peter Griffin wrote: > On Fri, 05 Sep 2014, Arnd Bergmann wrote: > > > On Friday 05 September 2014 18:23:45 Peter Griffin wrote: > > > +struct st_platform_priv { > > > + struct clk *clks[USB_MAX_CLKS]; > > > + struct clk *clk48; > > > + struct

Re: [PATCH 1/4] usb: dwc3: move all string helper functions to debug.h

2014-09-05 Thread Felipe Balbi
Hi, On Fri, Sep 05, 2014 at 06:23:24PM +, Paul Zimmerman wrote: > > +static inline const char *dwc3_ep_event_string(u8 event) > > +{ > > + switch (event) { > > + case DWC3_DEPEVT_XFERCOMPLETE: > > + return "Transfer Complete"; > > + case DWC3_DEPEVT_XFERINPROGRESS: > > +

Re: [PATCH v5] phy: Renesas R-Car Gen2 PHY driver

2014-09-05 Thread Sergei Shtylyov
Hello. On 08/20/2014 06:42 PM, Kishon Vijay Abraham I wrote: Sorry for the delayed reply, I was busy in other kernel areas. Should have replied yesterday though... [...] Index: linux-phy/drivers/phy/phy-rcar-gen2.c === --- /

Re: [PATCH net-next v3 0/2] r8152: random MAC address

2014-09-05 Thread David Miller
From: Hayes Wang Date: Thu, 4 Sep 2014 16:15:40 +0800 > If the interface has invalid MAC address, it couldn't > be used. In order to let it work normally, give a > random one. > > v3: > Remove > ether_addr_copy(dev->perm_addr, dev->dev_addr); > > v2: > Use "%pM" format specifier for p

Re: [PATCH 0/1] for HID core dot c

2014-09-05 Thread Frans Klaver
Hi, You're almost there. You may specifically want to read section 1.15. Also have a look at how other people submit their patches. Using git send-email[1] may also help. It's also the custom to reply to all, instead of just to the mailing list. Thanks, Frans [1] http://git-scm.com/docs/git-sen

Re: [rfc]your patch to deal with devices that need continous data traffic

2014-09-05 Thread Johan Hovold
On Fri, Sep 05, 2014 at 01:07:11PM +0200, Oliver Neukum wrote: > On Fri, 2014-09-05 at 12:15 +0200, Johan Hovold wrote: > > On Fri, Sep 05, 2014 at 11:05:46AM +0200, Oliver Neukum wrote: > > > > on second thought I think that your moving of remote_wakeup is not good. > > > If we'd discard input an

[PATCH] Correct argument for Module parameter description.

2014-09-05 Thread Hans Petter Selasky
Signed-off-by: Hans Petter Selasky --- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 12b6e67..1956c72 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -52,7 +52,7 @@ EXPORT_SYMB

Re: [PATCH 0/1] for HID core dot c

2014-09-05 Thread Greg KH
On Fri, Sep 05, 2014 at 04:30:27PM +0200, Hans Petter Selasky wrote: > Hi, > > Looks like the first argument for MODULE_PARAM_DESC() is incorrect. > > --HPS > > commit 862e8673263b82652b5738ccda4f8367959fa234 > Author: Hans Petter Selasky > Date: Fri Sep 5 11:07:15 2014 +0200 > > Correct

Re: RCU bug with v3.17-rc3 ?

2014-09-05 Thread Paul E. McKenney
On Thu, Sep 04, 2014 at 03:04:03PM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Sep 04, 2014 at 02:25:35PM -0500, Felipe Balbi wrote: > > On Thu, Sep 04, 2014 at 12:16:42PM -0700, Paul E. McKenney wrote: > > > On Thu, Sep 04, 2014 at 01:40:21PM -0500, Felipe Balbi wrote: > > > > Hi, > > > > > > >

Re: Linux xHCI compartmentalization

2014-09-05 Thread Sarah Sharp
On Wed, Sep 03, 2014 at 09:20:28PM +, Gary Cordelli wrote: > Sarah: > > Thank you for all the great work you put into providing the xHCI driver for > USB 3.0 host hardware support in Linux. > > Alas, I am stuck with an installed base of platforms that run a 2.6.29.6 > kernel that has just a

Re: ax88179_178a hang over xhci

2014-09-05 Thread Sarah Sharp
On Fri, Sep 05, 2014 at 06:04:19PM +0200, Andrea Arcangeli wrote: > On Fri, Sep 05, 2014 at 08:53:59AM +, David Laight wrote: > > > On Wed, Aug 20, 2014 at 04:12:49PM +0200, Andrea Arcangeli wrote: > > > > Hi Sarah, > > > > > > > > just a short followup on this. I still had 1gbps hangs with the

RE: [RFC PATCH 0/7] usb: gadget: add reset API at usb_gadget_driver

2014-09-05 Thread Peter Chen
> On Fri, Sep 05, 2014 at 08:44:08AM +0800, Peter Chen wrote: > > On Thu, Sep 04, 2014 at 11:04:38AM -0400, Alan Stern wrote: > > > On Thu, 4 Sep 2014, Peter Chen wrote: > > > > > > > Hi Felipe & Alan, how about using below steps for this > > > > reset/vbus/pullup changes? It mainly uses Alan's s