Hi,
I found that in the Baytrail-m platform if the "USB3.0 Configuration
in Pre-OS" is set to Auto in the BIOS, the system will boot with
EHCI-enabled. And test reboot 200 times. It sometimes hang in the
shutdown process "ehci-pci :00:1d.0: shutdown." I also found that
sometimes hang in the bo
On 25/08/14 22:22, Stephen Warren wrote:
On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
In addition to the PCIe and SATA PHYs, the XUSB pad controller also
supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single
PCIe or SATA lane and is mapped to one of the three UTMI ports.
Th
On Mon, Aug 25, 2014 at 11:27:47AM -0400, Alan Stern wrote:
> On Mon, 25 Aug 2014, Peter Chen wrote:
>
> > Hi Felipe & Alan,
> >
> > It is the follow-up for:
> > http://www.spinics.net/lists/linux-usb/msg112193.html
> >
> > This patchset adds reset API at usb_gadget_driver, the UDC driver
> > ca
Hi,
On 08/25/2014 08:14 PM, Greg Kroah-Hartman wrote:
> On Mon, Aug 25, 2014 at 12:21:56PM +0200, Hans de Goede wrote:
>> This is a bit bigger hammer then I would like to use for this, but for now
>> it will have to make do. I'm working on getting my hands on one of these so
>> that I can try to g
On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote:
> On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote:
> > On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
> [...]
> > >+static int tegra_xusb_mbox_probe(struct platform_device *pdev)
> >
> > >+res = platform_get_resource(pde
On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote:
> On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote:
> > On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote:
> > > On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
> > [...]
> > > >+static int tegra_xusb_mbox_probe(str
On 08/25/2014 07:22 PM, Jassi Brar wrote:
> On Mon, Aug 25, 2014 at 9:30 PM, Daniel Mack wrote:
>> @@ -187,7 +189,7 @@ agdev_iso_complete(struct usb_ep *ep, struct usb_request
>> *req)
>>
>> if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
>> src = prm->dma_area + pr
On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote:
> On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote:
> > On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote:
> > > On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote:
> > > > On 08/18/2014 11:08 AM, Andrew Brestic
With packet sizes other than 512, payloads in the packets may wrap
around the ALSA dma buffer partially, which leads to memory corruption
and audible clicks and pops in the audio stream at the moment, because
there is no boundary check before the memcpy().
In preparation to an implementation for s
Hi,
this is v3 of the f_uac2 timing fixup series.
Changes from v2:
* swap path 3 and 4, so that the ALSA buffer wrap around fix
comes in first. It's not actually a bug fix for the current
code, but more a preparation to allow for smaller packets.
* use the p_s
The UAC2 function driver currently responds to all packets at all times
with wMaxPacketSize packets. That results in way too fast audio
playback as the function driver (which is in fact supposed to define
the audio stream pace) delivers as fast as it can.
Fix this by pre-calculating the size of ea
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple
times. Adding a short-hand for them makes lines shorter so we can
remove some line wraps.
No functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 29 +++--
1 file c
Restructure some code to make it easier to read.
While at it, return -ENOMEM instead of -EINVAL if
usb_ep_alloc_request() fails, and omit the logging in such cases
(the mm core will complain loud enough).
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 39 +++--
The users of the old method are now converted to the new one.
Signed-off-by: Heikki Krogerus
Tested-by: Vivek Gautam
---
drivers/phy/phy-bcm-kona-usb2.c | 2 +-
drivers/phy/phy-berlin-sata.c| 2 +-
drivers/phy/phy-core.c | 45 +++-
dr
From: Thierry Reding
...
> > Is _nocache required? I don't see other drivers using it. I assume there's
> > nothing special about the mbox registers.
>
> Most drivers should be using devm_ioremap_resource() which will use the
> _nocache variant of devm_ioremap() when appropriate. Usually the regio
On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote:
> On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote:
> > On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote:
> > > On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote:
> > > > On Mon, Aug 25, 2014 at 01:01:52PM -060
On Mon, Aug 25, 2014 at 03:26:01PM +0300, Ivan T. Ivanov wrote:
> Initialize USB PHY after every Link controller reset
>
> Signed-off-by: Ivan T. Ivanov
> ---
> drivers/usb/chipidea/ci_hdrc_msm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c
> b/dr
On Tuesday 26 August 2014 11:08:11 Thierry Reding wrote:
> On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote:
> > On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote:
> > > On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote:
> > > > On Tuesday 26 August 2014 08:57:31 Thie
From: Alan Stern
> On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote:
>
> > Well, it is causing problems anyway... from user perspective, it's a
> > Linux compatibility issue, as it works "fine" on Windows. I'm not an
> > expert, but I'm wondering that if usb-storage could set capacity as
> > "UND
On Tuesday 26 August 2014 08:54:53 David Laight wrote:
> From: Thierry Reding
> ...
> > > Is _nocache required? I don't see other drivers using it. I assume there's
> > > nothing special about the mbox registers.
> >
> > Most drivers should be using devm_ioremap_resource() which will use the
> > _
On Fri, Aug 22, 2014 at 05:50:18PM +0200, Antoine Ténart wrote:
> This patch prepares the introduction of the generic PHY support in the
> USB ChipIdea common functions. The USB PHY member of the ChipIdea
> structure ('transceiver') is renamed to 'usb_phy', the 'phy' member of
> the ChipIdea pdata
On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote:
> On Tuesday 26 August 2014 11:08:11 Thierry Reding wrote:
> > On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote:
> > > On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote:
> > > > On Tue, Aug 26, 2014 at 09:43:50AM +020
On Fri, Aug 22, 2014 at 05:50:19PM +0200, Antoine Ténart wrote:
> Move the usb_otg member from struct usb_phy to struct ci_hdrc. Rework
> its initialization taking in account this modification.
>
If the common usb_otg and usb_phy struct still has another's pointer, you
may not need to add this pa
From: Alan Stern
> On Fri, 22 Aug 2014, Dan Williams wrote:
>
> > v1.0 hosts require that TD-fragments (portions of a TD that do not end
> > on a MPB boundary) not cross a TRB segment boundary. This constraint is
> > in addition to the constraint that a TRB may not specify a transfer that
> > cro
From: Dan Williams
> It's confusing (to me at least) to keep on remembering the differences
> between event rings (managed by the hardware) and non-event rings
> managed by the host. Replace "if (ring->type == FOO)" branches with
> ring ops that are specific to the type of ring.
>
> This is a tra
On Fri, Aug 22, 2014 at 05:50:20PM +0200, Antoine Ténart wrote:
> This patch adds support of the PHY framework for ChipIdea drivers.
> Changes are done in both the ChipIdea common code and in the drivers
> accessing the PHY. This is done by adding a new PHY member in
> ChipIdea's structures and by
From: Dan Williams
> Sending as an RFC primarily to get feedback on the unit testing approach
> while there's still time to yell at me in person at LinuxCon. Including
> Rusty in pursuit of comments on how to do mocked interfaces for testing
> purposes in-tree.
>
> ===
>
> This series updates th
From: Dan Williams
> v1.0 hosts require that TD-fragments (portions of a TD that do not end
> on a MPB boundary) not cross a TRB segment boundary. This constraint is
> in addition to the constraint that a TRB may not specify a transfer that
> crosses a 64K boundary. This enabling permits the driver
On Tuesday 26 August 2014 12:20:13 Thierry Reding wrote:
> On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: >
> > I'm not sure if it's really worth it. One thing we might do is just
> > remove all definitions of ioremap_nocache and add a wrapper to
> > include/linux/io.h, to make it
On Tue, Aug 26, 2014 at 01:35:34PM +0200, Arnd Bergmann wrote:
> On Tuesday 26 August 2014 12:20:13 Thierry Reding wrote:
> > On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: >
> > > I'm not sure if it's really worth it. One thing we might do is just
> > > remove all definitions of i
Hello David S. Miller,
The patch 4798248e4e02: "net: Add ops->ndo_xmit_flush()" from Aug 22,
2014, leads to the following static checker warning:
drivers/usb/gadget/function/f_ncm.c:1104 ncm_tx_tasklet()
error: NULL dereference inside function.
drivers/usb/gadget/function/f_ncm.c
On Tue, 2014-08-26 at 09:58 +, David Laight wrote:
> > Part of the problem is that usb-storage has no way to know that
> > anything strange is going on. It's normal for READ CAPACITY(16) to
> > fail (this depend on the SCSI level), and it's normal for the READ
> > CAPACITY(10) to report a valu
Hi,
> Sebastian, could you give these patches a try? They seem to work well
> on a BBB setup here.
Patch v3 works great on BBB as well with a Audio Loop and 48kHz/16 bit.
No noise or clicks. Tomorrow I have time to test other combinations
(sample-/rate/size).
Sebastian
signature.asc
Descript
From Oliver Neukum [mailto:oneu...@suse.de]
> On Tue, 2014-08-26 at 09:58 +, David Laight wrote:
> > > Part of the problem is that usb-storage has no way to know that
> > > anything strange is going on. It's normal for READ CAPACITY(16) to
> > > fail (this depend on the SCSI level), and it's n
This was promoted out of staging and there wasn't an email to the
staging list. Normally I like to go through any remaining questions
before the code is moved. The code looks pretty good, I just had one
question.
drivers/usb/usbip/usbip_common.c:712 usbip_pad_iso()
warn: why is z
On Mon, 26 Aug 2014, David Leight wrote:
> I wonder what the manufacturer would saw in response the bug where
> windows shows the incorrect size when trying to partition the disk?
I contacted enclosure manufacturer (Welland) some weeks ago, they are supposed
to escalate my questions to enginee
On Mon, 25 Aug 2014, Oliver Neukum wrote:
> On Mon, 2014-08-25 at 16:21 -0400, Alan Stern wrote:
> > On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote:
> >
> > > Well, it is causing problems anyway... from user perspective, it's a
> > > Linux compatibility issue, as it works "fine" on Windows. I'
On Tue, 26 Aug 2014, Jassi Brar wrote:
> Cool... we can avoid runtime calculations by maybe picking the
> pre-defined 'length pattern' at module load time to match the rate
> selected. And have those many usb requests allocated and their
> 'length' initialized to the pattern. Then the rest of code
On 08/26/2014 05:08 PM, Alan Stern wrote:
> The normal approach is to perform a simple runtime calculation (no
> pre-allocated pattern). It's not complex.
>
> Let S be the number of samples per second at the nominal transfer rate
> (for example, S = 44100). Let R be the number of packets per s
On Tue, 26 Aug 2014, Gavin Guo wrote:
> Hi,
>
> I found that in the Baytrail-m platform if the "USB3.0 Configuration
> in Pre-OS" is set to Auto in the BIOS, the system will boot with
> EHCI-enabled. And test reboot 200 times. It sometimes hang in the
> shutdown process "ehci-pci :00:1d.0: sh
On Tue, 26 Aug 2014, Daniel Mack wrote:
> On 08/26/2014 05:08 PM, Alan Stern wrote:
> > The normal approach is to perform a simple runtime calculation (no
> > pre-allocated pattern). It's not complex.
> >
> > Let S be the number of samples per second at the nominal transfer rate
> > (for examp
While testing a usb gadget I managed to crash completely the host
computer. This was due to a NULL pointer derefence.
This patch avoids the crash although the kernel still outputs some
warnings.
Without this patch, kernels from (at least) 3.14 can be crashed with
mass storage gadgets.
Affected h
Without this patch, some hosts keeps restarting indefinitely the target.
Bug added on ae8e530a7e5d87592cb23996bee7fd6f1eb202ed usb: gadget:
net2280: Code Cleanup
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/udc/net2280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On Tue, Aug 26, 2014 at 05:50:12PM +0200, Ricardo Ribalda Delgado wrote:
> Without this patch, some hosts keeps restarting indefinitely the target.
>
> Bug added on ae8e530a7e5d87592cb23996bee7fd6f1eb202ed usb: gadget:
> net2280: Code Cleanup
this should be just above you Signed-off-by on the for
Without this patch, some hosts keep restarting indefinitely the target.
Fixes: ae8e530 (usb: gadget: net2280: Code Cleanup)
Signed-off-by: Ricardo Ribalda Delgado
---
v2: Request by Felipe Balbi
Use Fixes: on commit message
drivers/usb/gadget/udc/net2280.c | 2 +-
1 file changed, 1 insertion(
On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter wrote:
> This was promoted out of staging and there wasn't an email to the
> staging list. Normally I like to go through any remaining questions
> before the code is moved. The code looks pretty good, I just had one
> question.
>
I didn't know I sho
On Tue, Aug 26, 2014 at 3:37 AM, David Laight wrote:
> From: Dan Williams
>> It's confusing (to me at least) to keep on remembering the differences
>> between event rings (managed by the hardware) and non-event rings
>> managed by the host. Replace "if (ring->type == FOO)" branches with
>> ring o
From: Dinh Nguyen
Hello,
This is version 4 of the patch series that combines the dwc2 gadget and host
driver into a single dual role driver. Here are the main differences from V2:
- Patch 9/12 : Move spin_lock_init() earlier up in the function to guarantee
no locks can be taken before the ini
From: Dan Williams [mailto:dan.j.willi...@intel.com]
> On Tue, Aug 26, 2014 at 3:37 AM, David Laight wrote:
> > From: Dan Williams
> >> It's confusing (to me at least) to keep on remembering the differences
> >> between event rings (managed by the hardware) and non-event rings
> >> managed by the
From: Dinh Nguyen
Adds the gadget data structure and appropriate data structure pointers
to the common dwc2_hsotg data structure. To keep the driver data
dereference code looking clean, the gadget variable declares are only available
for peripheral and dual-role mode. This is needed so that the d
From: Dinh Nguyen
Update DWC2 kconfig and makefile to support dual-role mode. The platform
file will always get compiled for the case where the controller is directly
connected to the CPU. So for loadable modules, only dwc2.ko is needed.
Signed-off-by: Dinh Nguyen
Acked-by: Paul Zimmerman
---
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
Add a check for a valid clock before calling clock functions.
Signed-off-by: Dinh Nguyen
Acked-by: Paul Zimmerman
---
drivers/usb/d
From: Dinh Nguyen
Make dwc2_handle_common_intr call the gadget interrupt function when operating
in peripheral mode. Remove the spinlock functions in s3c_hsotg_irq as
dwc2_handle_common_intr() already has the spinlocks.
Remove duplicate interrupt conditions that was in gadget, as those are handl
From: Dinh Nguyen
Update the dwc2 wakeup and suspend interrupt functions to use call_gadget
when the IP is in peripheral mode.
Signed-off-by: Dinh Nguyen
Acked-by: Paul Zimmerman
---
drivers/usb/dwc2/core_intr.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc2/core_intr.
From: Dinh Nguyen
Move spin_lock_init to common location for both host and gadget.
Signed-off-by: Dinh Nguyen
---
v4: move spin_lock_init up to make sure sure no locks can be taken before
the init.
---
drivers/usb/dwc2/hcd.c | 1 -
drivers/usb/dwc2/platform.c | 1 +
2 files changed, 1
From: Dinh Nguyen
Initialize the USB driver to peripheral mode when a B-Device connector
is attached.
Signed-off-by: Dinh Nguyen
Acked-by: Paul Zimmerman
---
drivers/usb/dwc2/hcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 4d918e
From: Dinh Nguyen
Move suspend/resume code to common platform code.
Signed-off-by: Dinh Nguyen
Acked-by: Paul Zimmerman
---
drivers/usb/dwc2/core.h | 6 ++
drivers/usb/dwc2/gadget.c | 4 ++--
drivers/usb/dwc2/platform.c | 23 +++
3 files changed, 31 insertions(
From: Dinh Nguyen
Initialize the spinlock here as the original spinlock in the host driver
has been removed.
Signed-off-by: Dinh Nguyen
---
v4: moved spin_lock_init() up to make sure no locks can be taken before
the init.
---
drivers/usb/dwc2/pci.c | 1 +
1 file changed, 1 insertion(+)
di
From: Dinh Nguyen
The Host workqueue will not get initialized if the driver is configured for
peripheral mode only. Thus we need to check for wq_otg before calling
queue_work().
Signed-off-by: Dinh Nguyen
Acked-by: Paul Zimmerman
---
drivers/usb/dwc2/core_intr.c | 8 +---
1 file changed,
On Tue, Aug 26, 2014 at 3:55 AM, David Laight wrote:
> From: Dan Williams
>> v1.0 hosts require that TD-fragments (portions of a TD that do not end
>> on a MPB boundary) not cross a TRB segment boundary. This constraint is
>> in addition to the constraint that a TRB may not specify a transfer that
On Tue, Aug 26, 2014 at 9:21 AM, David Laight wrote:
> From: Dan Williams [mailto:dan.j.willi...@intel.com]
>> On Tue, Aug 26, 2014 at 3:37 AM, David Laight
>> wrote:
>> > From: Dan Williams
>> >> It's confusing (to me at least) to keep on remembering the differences
>> >> between event rings (m
I have a j5 create (JUA210) USB 2 video device and adding it device id
to SIS USB video gets it to work.
Signed-off-by: Stephen Hemminger
--- a/drivers/usb/misc/sisusbvga/sisusb.c 2014-08-25 21:00:51.398586614
-0700
+++ b/drivers/usb/misc/sisusbvga/sisusb.c 2014-08-25 21:01:52.1105
From: Dinh Nguyen
Move the "samsung,s3c6400-hsotg" binding as the probe function in the gadget
driver will get removed when the dual-role driver is implemented.
Signed-off-by: Dinh Nguyen
Acked-by: Paul Zimmerman
---
drivers/usb/dwc2/gadget.c | 1 -
drivers/usb/dwc2/platform.c | 1 +
2 file
On Tue, Aug 26, 2014 at 9:18 PM, Alan Stern wrote:
> On Tue, 26 Aug 2014, Daniel Mack wrote:
>
>> On 08/26/2014 05:08 PM, Alan Stern wrote:
>> > The normal approach is to perform a simple runtime calculation (no
>> > pre-allocated pattern). It's not complex.
>> >
>> > Let S be the number of sampl
From: Dinh Nguyen
Add the proper init calls for either host, gadget or both in platform.c
Signed-off-by: Dinh Nguyen
Acked-by: Paul Zimmerman
---
drivers/usb/dwc2/core.h | 13 +
drivers/usb/dwc2/gadget.c | 2 +-
drivers/usb/dwc2/platform.c | 28
On Tue, Aug 26, 2014 at 10:00 PM, Jassi Brar wrote:
> On Tue, Aug 26, 2014 at 9:18 PM, Alan Stern wrote:
>> On Tue, 26 Aug 2014, Daniel Mack wrote:
>>
>>> On 08/26/2014 05:08 PM, Alan Stern wrote:
>>> > The normal approach is to perform a simple runtime calculation (no
>>> > pre-allocated pattern
On Tue, Aug 26, 2014 at 1:46 PM, Daniel Mack wrote:
>
> +static void
> +afunc_set_p_pktsize(struct usb_gadget *gadget, struct audio_dev *agdev)
> +{
> + unsigned i, residue, rate, factor, interval, framesize, pktsize, len;
> + struct snd_uac2_chip *uac2 = &agdev->uac2;
> + struct
Hi Alan,
On Tue, Aug 26, 2014 at 11:38 PM, Alan Stern wrote:
> On Tue, 26 Aug 2014, Gavin Guo wrote:
>
>> Hi,
>>
>> I found that in the Baytrail-m platform if the "USB3.0 Configuration
>> in Pre-OS" is set to Auto in the BIOS, the system will boot with
>> EHCI-enabled. And test reboot 200 times.
On Tue, Aug 26, 2014 at 1:38 PM, Daniel Mack wrote:
> On 08/25/2014 07:22 PM, Jassi Brar wrote:
>> On Mon, Aug 25, 2014 at 9:30 PM, Daniel Mack wrote:
>
>>> @@ -187,7 +189,7 @@ agdev_iso_complete(struct usb_ep *ep, struct
>>> usb_request *req)
>>>
>>> if (substream->stream == SNDRV_PCM_S
On Wed, 27 Aug 2014, Gavin Guo wrote:
> >> And IIRC, there is only one host controller within
> >> EHCI and XHCI can be enabled in the Baytrail platform. I'm also trying
> >> to find out the kernel parameters to disable the EHCI driver, but
> >> currently there is no available one.
> >
> > It's n
On Tue, 26 Aug 2014, Jassi Brar wrote:
> On Tue, Aug 26, 2014 at 10:00 PM, Jassi Brar wrote:
> > On Tue, Aug 26, 2014 at 9:18 PM, Alan Stern
> > wrote:
> >> On Tue, 26 Aug 2014, Daniel Mack wrote:
> >>
> >>> On 08/26/2014 05:08 PM, Alan Stern wrote:
> >>> > The normal approach is to perform a s
On Tue, Aug 26, 2014 at 11:07 PM, Alan Stern wrote:
> On Tue, 26 Aug 2014, Jassi Brar wrote:
>
>> On Tue, Aug 26, 2014 at 10:00 PM, Jassi Brar
>> wrote:
>> > On Tue, Aug 26, 2014 at 9:18 PM, Alan Stern
>> > wrote:
>> >> On Tue, 26 Aug 2014, Daniel Mack wrote:
>> >>
>> >>> On 08/26/2014 05:08 P
Hi,
I have been trying to set several USB Video Grabbers on a few
machines. The Video Grabbers are "Oner Touch Video Capture" dongles
from Diammond Multimedia, a Connexant device with device ID 1f4d:0102.
On an old machine with "Advanced Micro Devices, Inc. [AMD/ATI]
SB7x0/SB8x0/SB9x0 USB EHCI C
On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote:
> On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter
> wrote:
> >707 /*
> >708 * loop over all packets from last to first (to prevent
> > overwritting
> >709 * memory when padding) and move them
On Tue, Aug 26, 2014 at 09:35:32AM +0200, Hans de Goede wrote:
> Hi,
>
> On 08/25/2014 08:14 PM, Greg Kroah-Hartman wrote:
> > On Mon, Aug 25, 2014 at 12:21:56PM +0200, Hans de Goede wrote:
> >> This is a bit bigger hammer then I would like to use for this, but for now
> >> it will have to make do
On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote:
> On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter
> wrote:
> > This was promoted out of staging and there wasn't an email to the
> > staging list. Normally I like to go through any remaining questions
> > before the code is moved. T
On Tue, Aug 26, 2014 at 11:47 AM, Dan Carpenter
wrote:
> On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote:
>> On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter
>> wrote:
>> >707 /*
>> >708 * loop over all packets from last to first (to prevent
>> > overwri
This is almost certainly a form of the problem reported in
"AS2105-based enclosure size issues with >2TB HDDs". I'm repeating my
original message here so linux-usb can see it, and so it can be
connected to the older thread. I'll address it in another message.
I've appended James Bottomley's resp
On Tue, 2014-08-26 at 15:39 -0400, Dale R. Worley wrote:
> This is almost certainly a form of the problem reported in
> "AS2105-based enclosure size issues with >2TB HDDs". I'm repeating my
> original message here so linux-usb can see it, and so it can be
> connected to the older thread. I'll add
The xhci driver will OOPS on resume from S2/S3 if dma_alloc_coherent()
is out of memory. This is a result of two things:
1. xhci_mem_cleanup() in xhci-mem.c free's xhci->lpm_command if
it's not NULL, but doesn't set it to NULL after the free.
2. xhci_mem_cleanup() is called twice on resume, once fo
Hi,
On Fri, Aug 22, 2014 at 04:56:46PM -0500, Felipe Balbi wrote:
> > > diff --git a/drivers/usb/dwc3/debug.c b/drivers/usb/dwc3/debug.c
> > > new file mode 100644
> > > index 000..6d01e0c
> > > --- /dev/null
> > > +++ b/drivers/usb/dwc3/debug.c
> > > @@ -0,0 +1,33 @@
> > > +/**
> > > + * debu
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Tuesday, August 26, 2014 1:42 PM
>
> On Fri, Aug 22, 2014 at 04:56:46PM -0500, Felipe Balbi wrote:
...
> yeah, it took longer than expected (been busy lately), but here's an
> example trace with all trace points enabled:
>
> # tracer: nop
> #
>
Hi,
On Tue, Aug 26, 2014 at 09:21:55PM +, Paul Zimmerman wrote:
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Tuesday, August 26, 2014 1:42 PM
> >
> > On Fri, Aug 22, 2014 at 04:56:46PM -0500, Felipe Balbi wrote:
>
> ...
>
> > yeah, it took longer than expected (been busy lately),
Hi,
this is v4 of the f_uac2 timing fixup series.
Changes from v3:
* add another patch (3/5) to introduce agdev_to_uac2_opts()
which is also needed in 5/5
* patch 5/5 only:
move from a pre-calculated sequence of packet lengths to
an accumulator that
Restructure some code to make it easier to read.
While at it, return -ENOMEM instead of -EINVAL if
usb_ep_alloc_request() fails, and omit the logging in such cases
(the mm core will complain loud enough).
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 39 +++--
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple
times. Adding a short-hand for them makes lines shorter so we can
remove some line wraps.
No functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 29 +++--
1 file c
Add a simple container_of() wrapper to get a struct f_uac2_opts from a
struct struct audio_dev. Use it in two places where it is currently
open-coded.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
The UAC2 function driver currently responds to all packets at all times
with wMaxPacketSize packets. That results in way too fast audio
playback as the function driver (which is in fact supposed to define
the audio stream pace) delivers as fast as it can.
Fix this by sizing each packet correctly w
With packet sizes other than 512, payloads in the packets may wrap
around the ALSA dma buffer partially, which leads to memory corruption
and audible clicks and pops in the audio stream at the moment, because
there is no boundary check before the memcpy().
In preparation to an implementation for s
Hi Alan,
On Wed, Aug 27, 2014 at 1:26 AM, Alan Stern wrote:
> On Wed, 27 Aug 2014, Gavin Guo wrote:
>
>> >> And IIRC, there is only one host controller within
>> >> EHCI and XHCI can be enabled in the Baytrail platform. I'm also trying
>> >> to find out the kernel parameters to disable the EHCI
Fine. Sounds good. I just wanted to make sure.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday, August 21, 2014 11:55 PM, Vivek Gautam wrote:
>
> Adding phy calibrate callback, which facilitates setting certain
> PHY settings post initialization of the PHY controller.
> Exynos5420 and Exynos5800 have 28nm USB 3.0 DRD PHY for which
> the Loss-of-Signal (LOS) Detector Threshold Le
On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack wrote:
> The UAC2 function driver currently responds to all packets at all times
> with wMaxPacketSize packets. That results in way too fast audio
> playback as the function driver (which is in fact supposed to define
> the audio stream pace) delivers a
On 08/26/2014 08:50 PM, Sebastian Reimers wrote:
Hi,
Sebastian, could you give these patches a try? They seem to work well
on a BBB setup here.
Patch v3 works great on BBB as well with a Audio Loop and 48kHz/16 bit.
No noise or clicks. Tomorrow I have time to test other combinations
(sample-
On 08/27/2014 06:08 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack wrote:
>> + uac2->p_interval = (1 << (ep_desc->bInterval - 1)) * factor;
>> + req_len = rate / uac2->p_interval;
>>
> + if (opts->p_srate % uac2->p_interval)
> +
95 matches
Mail list logo
