On Mon, Aug 11, 2014 at 11:25:44AM +0530, Pratyush Anand wrote:
> Hi Peter,
>
> On Thu, Aug 07, 2014 at 02:45:15PM +0800, Peter Chen wrote:
> > According to On-The-Go and Embedded Host Supplement to the USB Revision
> > 2.0 Specification, the targeted hosts (non-PC hosts) include both
> > embedded
HID IR device will not response to any command send from host when it
is finishing paring and tring to reset itself.
During this period of time, usb_cleaer_halt will be fail and if hid_start_in
soon again, we has the possibility trap in infinite loop.
Signed-off-by: CheChun Kuo
---
dri
On Fri, 22 Aug 2014, CheChun Kuo wrote:
> HID IR device will not response to any command send from host when
> it is finishing paring and tring to reset itself. During this period of
> time, usb_cleaer_halt will be fail and if hid_start_in soon again, we
> has the possibility trap in infi
On Tue, Aug 19, 2014 at 12:24:37AM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 08/19/2014 12:07 AM, Stefan Agner wrote:
>
> >Add USB support for Freescale Vybrid tower. The USB hosts over-current
> >protection signal is not connected is not connected to the PHY's over-
>
>Yes, we all under
On Mon, Aug 18, 2014 at 10:07:10PM +0200, Stefan Agner wrote:
> Stefan Agner (7):
> ARM: dts: vf610: Add USB PHY and controller
> ARM: imx: clk-vf610: Add USBPHY clocks
...
> ARM: dts: vf610: Add usbmisc for non-core registers
...
> ARM: dts: vf610-colibri: Add USB support
> ARM: dts: vf6
Hi Community,
I finally fix the UAC1 on Windows 7 host issue. Thanks for your help. I
will submit patches after more testing.
On 08/22/2014 10:43 AM, Xuebing Wang wrote:
On 08/21/2014 04:24 PM, Sebastian Andrzej Siewior wrote:
On 08/20/2014 02:13 AM, Peter Chen wrote:
Thanks, so Xunbing,
This patchset adds support for interrupt EP and the corresponding test cases to
gadget zero. The code has been rebased and tested on Kernel v3.15-rc5
V4 -> V5
- Rebased on Felipe Balbi's testing/next
- Build tested
- No other change
V3 -> V4
- Edited the commit message to provide more informa
Two simple test cases for interrupt endpoints are added to the usbtest.c file.
These are simple non-queued interrupt IN and interrupt OUT transfers. Currently,
only gadget zero is capable of executing the interrupt EP test cases. However,
extending the same to other gadgets is extremely simple and
Interrupt endpoints behave quite similar to the bulk endpoints with the
difference that the endpoints expect data sending/reception request at
particular intervals till the whole data has not been transmitted.
The interrupt EP support is added to gadget zero. A new alternate setting (=2)
has been
On Tue, Aug 19, 2014 at 09:51:51AM +0800, Peter Chen wrote:
> Changes for v3:
> - Add possible role switch for unsupported HNP capable OTG B-peripheral,
> see USB OTG & EH 2.0 spec page 38, this feature was deleted wrongly
> at previous revision patches.
>
> Changes for v2:
> - Move TPL support ju
From: Todd Poynor
USB: OTG: Hold wakeupsource when VBUS present
Enabled by default, can disable with:
echo N > /sys/module/otg_wakeupsource/parameters/enabled
This is one of the number of patches from the Android AOSP common.git tree,
which is used on almost all Android devices. so I wanted
From: Todd Poynor
usb: otg: Temporarily hold wakeupsource on charger and disconnect events
Allow other parts of the system to react to the charger connect/disconnect
event without allowing the system to suspend before the other parts can process
the event. This wakeup_source times out after 2 se
hi Jiri:
2014-08-22 15:45 GMT+08:00 Jiri Kosina :
> On Fri, 22 Aug 2014, CheChun Kuo wrote:
>
>> HID IR device will not response to any command send from host when
>> it is finishing paring and tring to reset itself. During this period of
>> time, usb_cleaer_halt will be fail and if hid_star
Hi,
s/Caibrate/Calibrate/
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vge
If we tested this driver as gadget and g_ncm driver using iperf,
some issues below happened:
- Oops happened.
- A transaction didn't finish in PIO mode.
- A transaction didn't finish in DMA mode if the "zero" flag is set.
- The driver didn't cancel a transaction if dequeue() is called.
This pa
Some gadget drivers will call usb_ep_queue() more than once before
the first queue doesn't finish. However, this driver didn't handle
it correctly. So, this patch fixes the behavior of some
usbhs_pkt_handle using the "running" flag. Otherwise, the oops below
happens if we use g_ncm driver and when
This patch fixes the condition of is_done in usbhsf_dma_push_done().
This function will be called after a transmission finished by DMAC.
So, the function should check if the transmission packet is short packet
or not. Also the function should call try_run to send the zero packet
by the pio handler
This patch protects the mod->irq_bempsts and mod->irq_brdysts by
spin lock in the usbhs_status_get_each_irq() because other functions
will write them during spin lock. Otherwise, the driver will clears
the BRDYSTS and/or BEMPSTS wrongly, and then, the transaction will not
finish.
Also since the dri
This patch fixes the usb_pkt_pop(). If a gadget driver calls
usb_ep_dequeue(), this driver will call the usb_pkt_pop().
So, the usb_pkt_pop() should cancel the transaction.
Signed-off-by: Yoshihiro Shimoda
---
drivers/usb/renesas_usbhs/fifo.c | 30 +++---
1 file changed
On 21 August 2014 19:26, Andrew Bresticker wrote:
> On Thu, Aug 21, 2014 at 6:34 AM, Tomeu Vizoso wrote:
>> On 18 August 2014 19:08, Andrew Bresticker wrote:
>>>
>>> Tested on Venice2, Jetson TK1, and Big with a variety of USB2.0 and
>>> USB3.0 memory sticks and ethernet dongles using controller
Dear Matt,
This is a small series which fix usbg_set_function_attrs()
which previously tried to set attributes which are read only
on configfs.
I have also went through code and marked attributes which should not
change during function calls with const qualifiers.
Third patch is a small enhancem
Some of function attributes are read only on configfs, so library
should not try to set them and accept only empty values in functions
which set multiple attributes at single call.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 26 +++---
1 file changed, 19 insertions(+)
Const qualifers should be placed in all functions which
don't need to modify provided buffers to allow caller to
pass literals or pointers to non-modifable space.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 28 +++---
src/usbg.c | 79 ++
ether_aton() and ether_ntoa() use static buffers which are
overwritten by next call of this function so those functions
should not be used in multithread environment.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h |1 +
src/usbg.c | 16 ++--
2 files changed,
Dear Matt,
This quite big series adds new part of libusbg API which allows to
import/export gadget/function/configuration from/to file.
Motivation:
Libusbg allows to create a binary file which set up custom
gadget. This is useful but if we have to create custom binary for
each gadget we wast a l
Changes sent to libcofngi has not been merged yet,
so add compatibility defines to make all compile and work.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c |9 +
1 file changed, 9 insertions(+)
diff --git a/src/usbg.c b/src/usbg.c
index b1b5f44..dfaf66c 100644
--- a/src/usbg.c
+++
Configuration may have several functions if we add
strings and some attributes it gives a few shell commands
to set it up. To avoid this add export cofiguration
which allows to store usb configuration in a file.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h |8 ++
src/usbg.c
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h |4
src/usbg.c | 24
2 files changed, 28 insertions(+)
diff --git a/include/usbg/usbg.h b/include/usbg/usbg.h
index 3a66ae3..3d3cba0 100644
--- a/include/usbg/usbg.h
+++ b/include/usbg/usbg.h
@@
Whole gadget setting process take a lot of simple
commands (or lines of code). Those shell commands
may take a while or require dedicated script and
hard-coding gadget configuration. To avoid such
situation add to library ability to export a whole
gadget into file.
Signed-off-by: Krzysztof Opasiak
Add some field where additional label for function can be stored.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/usbg.c b/src/usbg.c
index dfaf66c..e5ed240 100644
--- a/src/usbg.c
+++ b/src/usbg.c
@@ -84,7 +84,8 @@ s
Function settings may be complicated and their configuration
may take a long while. To save time it would be convenient
to allow for storing function settings in a file.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 11
src/usbg.c | 156 +
Add sample C code which shows how to use new functionality
of libusbg - gadget export. This program allows to export
chosen gadget from configfs to a file.
Signed-off-by: Krzysztof Opasiak
---
examples/Makefile.am |3 +-
examples/gadget-export.c | 81 +++
This library is used to import and export
gadget/function/config to and from file.
Signed-off-by: Krzysztof Opasiak
---
configure.ac|1 +
libusbg.pc.in |2 +-
src/Makefile.am |4 +++-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
ind
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 43 +++
src/usbg.c | 48
2 files changed, 91 insertions(+)
diff --git a/include/usbg/usbg.h b/include/usbg/usbg.h
index 23783eb..a934a7
If error occurred during parsing user should have
an oportunity to get details about place and type
of error.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c |8
1 file changed, 8 insertions(+)
diff --git a/src/usbg.c b/src/usbg.c
index 74f6bfd..929f1c7 100644
--- a/src/usbg.c
+++
Whole gadget can be exported to file using usbg_export_gadget().
This commit adds complementary API function usbg_import_gadget()
which allows to import whole gadget (including attrs, strings,
configs, functions and bindings) from file to configfs.
Signed-off-by: Krzysztof Opasiak
---
include/us
Functions can be exported to file using usbg_export_function().
This commit adds complementary API function usbg_import_function()
which allows to import function from file to configfs.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 13
src/usbg.c | 188 +
Configurations can be exported to file using usbg_export_config().
This commit adds complementary API function usbg_import_config()
which allows to import configuration (with attrs, strings and
bindings) from file to chosen gadget.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 11
Signed-off-by: Krzysztof Opasiak
---
examples/Makefile.am |3 +-
examples/gadget-import.c | 79 ++
src/usbg.c |6 ++--
3 files changed, 84 insertions(+), 4 deletions(-)
create mode 100644 examples/gadget-import.c
diff --git
If error occurred during parsing user should have
an opportunity to get details about place and type
of error.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/src/usbg.c b/src/usbg.c
index 3e4725d..3527c1b 100644
--- a/src/usbg.c
+++
Add document which clarify reasons of implementing
gadget schemes and also describes syntax of such files.
Signed-off-by: Krzysztof Opasiak
---
doc/gadget_schemes.txt | 301
1 file changed, 301 insertions(+)
create mode 100644 doc/gadget_schemes
Hello.
On 8/22/2014 3:59 PM, Krzysztof Opasiak wrote:
Changes sent to libcofngi has not been merged yet,
Perhaps libconfig?
so add compatibility defines to make all compile and work.
Signed-off-by: Krzysztof Opasiak
[...]
WBR, Sergei
--
To unsubscribe from this list: send the line
With this patch, USB host activity can be signaled by blinking a LED.
This should work with all host controllers. Tested only with musb.
Signed-off-by: Michal Sojka
---
drivers/leds/trigger/Kconfig | 8 ++
drivers/leds/trigger/Makefile | 1 +
drivers/leds/trigger/ledtri
With this patch, USB gadget activity can be signaled by blinking a LED.
Since there is no generic code where to put the trigger for all USB
controllers, each USB controller needs to call the trigger individually.
This patch adds the call only for the musb controller where I can test
it.
Signed-of
Signed-off-by: Rasmus Villemoes
---
drivers/usb/gadget/udc/fusb300_udc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fusb300_udc.h
b/drivers/usb/gadget/udc/fusb300_udc.h
index ae811d8..ad39f89 100644
--- a/drivers/usb/gadget/udc/fusb300_udc.h
+++ b/
Hi,
On Thu, Aug 21, 2014 at 7:48 PM, Tony Lindgren wrote:
> Commit 249751f22380 ("usb: phy: twl4030-usb: poll for ID disconnect")
> added twl4030_id_workaround_work() to deal with lost interrupts
> after ID pin goes down. However, this currently only works for the
> insertion. The PHY interrupts
On Fri, 22 Aug 2014, vichy wrote:
> hi Jiri:
>
> 2014-08-22 15:45 GMT+08:00 Jiri Kosina :
> > On Fri, 22 Aug 2014, CheChun Kuo wrote:
> >
> >> HID IR device will not response to any command send from host when
> >> it is finishing paring and tring to reset itself. During this period of
> >>
On Fri, Aug 22, 2014 at 02:59:32PM +0200, Rasmus Villemoes wrote:
you need a commit log. Has this always been there ? Which commit are you
fixing ?
> Signed-off-by: Rasmus Villemoes
> ---
> drivers/usb/gadget/udc/fusb300_udc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --
On Fri, 22 Aug 2014, Kiran Kumar Raparthy wrote:
> From: Todd Poynor
>
> USB: OTG: Hold wakeupsource when VBUS present
>
> Enabled by default, can disable with:
>echo N > /sys/module/otg_wakeupsource/parameters/enabled
>
> This is one of the number of patches from the Android AOSP common.g
Clearly this was meant to be an include guard, but a trailing
underscore was missing. It has been this way since the file was
introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver").
Signed-off-by: Rasmus Villemoes
---
drivers/usb/gadget/udc/fusb300_udc.h | 2 +-
1 file changed, 1 insert
On Thu, 21 Aug 2014, Christoph Hellwig wrote:
> On Thu, Aug 21, 2014 at 05:43:41PM -0400, Martin K. Petersen wrote:
> > Alan> Okay, here's a patch that implements the suggestion, except that I
> > Alan> put the flag in the Scsi_Host structure instead of the template.
> > Alan> This was to minimize
On Fri, Aug 22, 2014 at 04:44:33PM +0200, Rasmus Villemoes wrote:
> Clearly this was meant to be an include guard, but a trailing
> underscore was missing. It has been this way since the file was
> introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver").
>
right here you need to have:
Fi
On Fri, Aug 22, 2014 at 10:53:42AM -0400, Alan Stern wrote:
> Good idea. An enhanced patch is below. If I can get a Tested-By: from
> Tiziano and one or two Acked-By: responses, I'll submit this for the
> current and stable kernels.
>
> Sending the initial INQUIRY command to LUNs larger than 0 i
> "Alan" == Alan Stern writes:
Alan> Sending the initial INQUIRY command to LUNs larger than 0 involves
Alan> a chicken-and-egg problem -- we don't know whether to fill in the
Alan> LUN bits in the command until we know the SCSI level, and we don't
Alan> know the SCSI level until the INQUIRY
Felipe Balbi writes:
> On Fri, Aug 22, 2014 at 04:44:33PM +0200, Rasmus Villemoes wrote:
>> Clearly this was meant to be an include guard, but a trailing
>> underscore was missing. It has been this way since the file was
>> introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver").
>>
>
>
On Fri, 22 Aug 2014, Christoph Hellwig wrote:
> On Fri, Aug 22, 2014 at 10:53:42AM -0400, Alan Stern wrote:
> > Good idea. An enhanced patch is below. If I can get a Tested-By: from
> > Tiziano and one or two Acked-By: responses, I'll submit this for the
> > current and stable kernels.
> >
> >
Renesas uPD720202 USB 3.0 chip needs XHCI_TRUST_TX_LENGTH quirk workaround as
per below logs
produced when using a Diammond video capture dongle:
Aug 21 18:07:33 [kernel] handle_tx_event: 67 callbacks suppressed
Aug 21 18:07:33 [kernel] xhci_hcd :01:00.0: WARN Successful completion on
short
On Fri, 2014-08-22 at 10:53 -0400, Alan Stern wrote:
> On Thu, 21 Aug 2014, Christoph Hellwig wrote:
>
> > On Thu, Aug 21, 2014 at 05:43:41PM -0400, Martin K. Petersen wrote:
> > > Alan> Okay, here's a patch that implements the suggestion, except that I
> > > Alan> put the flag in the Scsi_Host s
This patch adds support of the PHY framework for ChipIdea drivers.
Changes are done in both the ChipIdea common code and in the drivers
accessing the PHY. This is done by adding a new PHY member in
ChipIdea's structures and by taking care of it in the code.
Signed-off-by: Antoine Ténart
---
driv
Move the usb_otg member from struct usb_phy to struct ci_hdrc. Rework
its initialization taking in account this modification.
Signed-off-by: Antoine Ténart
---
drivers/usb/chipidea/ci.h | 1 +
drivers/usb/chipidea/host.c| 8 +++-
drivers/usb/chipidea/otg_fsm.c | 15 ++-
This patch prepares the introduction of the generic PHY support in the
USB OTG common functions. The USB PHY member of the OTG structure is
renamed to 'usb_phy' and modifications are done in all drivers accessing
it. Renaming this pointer will allow to keep the compatibility for USB
PHY drivers.
S
This patch adds support of the PHY framework in OTG and keeps the USB
PHY compatibility. Here the only modification is to add PHY member in
the OTG structure, along with the USB PHY one.
Signed-off-by: Antoine Ténart
---
include/linux/usb/otg.h | 3 +++
1 file changed, 3 insertions(+)
diff --gi
This patch prepares the introduction of the generic PHY support in the
USB ChipIdea common functions. The USB PHY member of the ChipIdea
structure ('transceiver') is renamed to 'usb_phy', the 'phy' member of
the ChipIdea pdata structure is renamed to 'usb_phy' and modifications
are done in all driv
The patch adding support to the generic PHY framework introduced a
'gen_phy' member in the HCD structure. Rename it to 'phy' to have a
consistent USB framework.
Signed-off-by: Antoine Ténart
Acked-by: Alan Stern
---
drivers/usb/core/hcd.c | 22 +++---
include/linux/usb/hcd.h |
The USB PHY member of the HCD structure is renamed to 'usb_phy' and
modifications are done in all drivers accessing it.
Signed-off-by: Antoine Ténart
Acked-by: Alan Stern
---
drivers/usb/chipidea/host.c | 2 +-
drivers/usb/core/hcd.c| 20 ++--
drivers/usb/core/hub.c
Hi all,
This is an attempt to add more common USB code aware of the generic PHY
framework, while keeping the compatibility for the USB PHY one. It does
not add the full support, some USB PHY specific functions not being
available currently in the generic PHY subsystem (e.g. usb_phy_set_power()).
B
This patch modify the generic code handling PHYs to allow them to be
supplied from the drivers. This adds checks to ensure no PHY was already
there when looking for one in the generic code. This also makes sure we
do not modify its state in the generic HCD functions, it was provided by
the driver.
Before using the PHY framework instead of the USB PHY one, we need to
move the OTG state into another place, since it won't be available when
USB PHY isn't used. This patch moves the OTG state into the OTG
structure, and makes all the needed modifications in the drivers
using the OTG state.
Signed
Hi,
On Fri, Aug 22, 2014 at 05:21:12PM +0200, Rasmus Villemoes wrote:
> Felipe Balbi writes:
>
> > On Fri, Aug 22, 2014 at 04:44:33PM +0200, Rasmus Villemoes wrote:
> >> Clearly this was meant to be an include guard, but a trailing
> >> underscore was missing. It has been this way since the file
Hi,
* Grazvydas Ignotas [140822 06:21]:
> Hi,
>
> On Thu, Aug 21, 2014 at 7:48 PM, Tony Lindgren wrote:
> > Commit 249751f22380 ("usb: phy: twl4030-usb: poll for ID disconnect")
> > added twl4030_id_workaround_work() to deal with lost interrupts
> > after ID pin goes down. However, this current
* Kishon Vijay Abraham I [140821 21:52]:
> >
> > Kishon, this regression fix would be nice to get into the v3.17-rc
> > series if no objections. If you don't have other fixes, I can also
> > queue via arm-soc with proper acks.
>
> I can queue this one up once put_autosuspend() is used.
Great, t
Hello.
On 08/22/2014 07:50 PM, Antoine Ténart wrote:
This patch modify the generic code handling PHYs to allow them to be
supplied from the drivers. This adds checks to ensure no PHY was already
there when looking for one in the generic code. This also makes sure we
do not modify its state in t
drivers/usb/phy/phy-samsung-usb[2,3] drivers got replaced by
drivers/phy/phy-samsung-usb[2,3] ones and the old common Samsung
USB PHY code is no longer used.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon Vija
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one and is no longer used.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon Vijay Abraham I
Cc: Kamil Debski
---
drivers/us
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one. Remove the leftover
USB2 PHY node (EHCI/OHCI USB nodes are using the new one
already) from Exynos5250 dtsi file.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one. Remove the leftover hook
from Arndale dts file.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon Vijay Abraham I
Cc: Ma
drivers/usb/phy/phy-samsung-usb3 driver got replaced by
drivers/phy/phy-samsung-usb3 one and is no longer used.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon Vijay Abraham I
Cc: Kamil Debski
---
drivers/us
Hi,
This patch series removes the old Samsung USB PHY drivers that
got replaced by the new ones using the generic PHY layer.
Depends on:
- v3.17-rc1 branch of Linus' kernel
Changes since v1 (https://lkml.org/lkml/2014/8/14/241):
- rebased on v3.17-rc1 kernel
- added Acked-by-s from Kishon Vijay
On 08/22/2014 08:53 PM, Sergei Shtylyov wrote:
This patch modify the generic code handling PHYs to allow them to be
supplied from the drivers. This adds checks to ensure no PHY was already
there when looking for one in the generic code. This also makes sure we
do not modify its state in the gene
Hi,
On Fri, Aug 22, 2014 at 03:19:32PM +0530, Kiran Kumar Raparthy wrote:
> From: Todd Poynor
>
> USB: OTG: Hold wakeupsource when VBUS present
>
> Enabled by default, can disable with:
I would turn this around and make it disabled by default so that it
doesn't change behavior for distro kerne
These can simply be toggled via xor.
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-ring.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 749fc68eb5c1..0efbbf0b6233 100644
--- a/drivers/
An xhci controller device is a pci or a platform device, never a
usb_device.
Cc: Xenia Ragiadakou
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-trace.h |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trac
by Kukjin Kim.
> Are we deleting the phy drivers or not ?
Yes, we are deleting them. It has been agreed on by Kishon and
Vivek.
> Please rebase on v3.17-rc1 and resend with all Acks in place.
Done:
https://lkml.org/lkml/2014/8/22/446
Please note that if you want to apply it t
TRB segments are allocated relatively infrequently and would benefit
from being larger (to reduce probability of overrunning a segment in a
TD fragment). We already burn a page satisfying a single segment
allocation, so there's little reason to not allocate in page-sized
chunks in the first instan
Break the assumption that link-trbs are always located at the end of a
segment. Introduce ->link to struct xhci_segment and use that every
place that looks up the link-trb for a segment. This is meant to be
functionally equivalent to the existing driver and is just a search and
replace for hard c
Replace many occurrences of xhci_to_hcd(xhci)->self.controller with a
helper.
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-mem.c | 29 -
drivers/usb/host/xhci.c |6 +++---
drivers/usb/host/xhci.h | 13 +
3 files changed, 24 inserti
In prepartion for converting ring management from pointers to power-of-2
indexes, introduce xhci_ring_dequeue(), xhci_ring_enqueue(),
xhci_ring_set_dequeue(), and xhci_ring_set_enqueue().
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-dbg.c | 16 ++--
drivers/usb/host/xhci-mem.c | 1
last_trb() can simply distinguish event rings by the ring ->type. With
this in place the 'xhci' parameter can be removed from
last_trb_on_last_seg(), next_trb(), and inc_deq().
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-ring.c | 75 --
1 file
In preparation for dynamic ring expansion while walking scatterlists for
v1.0+ xhci hosts make it possible to walk backwards through ring
segments. Certainly this could be done in an open-coded fashion, but it
improves readability to use established list manipulation helper
routines.
Signed-off-b
There are two locations where we advance the enqueue pointer through a
chain of link trbs, in inc_enq() and prepare_ring(). Factor that into a
common advance_enq(). Also, in preparation for per-ring operations
factor out the differences between the event-rings, chain-quirk-rings
and normal endpoi
Consolidate ring pointer tracking variables into their own type. This
simplifies the calling convention of some routines and allows for the
later introduction of integer ring index variables.
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-dbg.c |8 +
drivers/usb/host/xhci-mem.c |
Clean up verbose (unsigned long long) casts.
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-dbg.c | 70 -
drivers/usb/host/xhci-mem.c | 46 ---
drivers/usb/host/xhci-ring.c | 41 +++-
drivers/us
It's confusing (to me at least) to keep on remembering the differences
between event rings (managed by the hardware) and non-event rings
managed by the host. Replace "if (ring->type == FOO)" branches with
ring ops that are specific to the type of ring.
This is a tradeoff of direct code readabilit
Sending as an RFC primarily to get feedback on the unit testing approach
while there's still time to yell at me in person at LinuxCon. Including
Rusty in pursuit of comments on how to do mocked interfaces for testing
purposes in-tree.
===
This series updates the xhci driver to honor all the rule
All rings have ->dequeue = ->enqueue = "first trb in first segment", so
it is redundant to check if ->dequeue is NULL when ->ring is set.
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-hub.c |5 ++---
drivers/usb/host/xhci-ring.c |2 +-
2 files changed, 3 insertions(+), 4 deletio
The only difference between these two routines is that the latter
handles a scatterlist of more than one entry. Fake a single entry
scatterlist for the non-sg case, and delete the duplicate code.
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-ring.c | 158 +--
In preparation for honoring xhci-v1.0+ td-fragment handling rules break
out the subroutines of prepare_transfer(). Rather than calculating the
number of trbs required and expanding the ring, v1.0+ hosts will
dynamically resize the ring as it discovers td-fragments that end up
straddling a segment
TDs from endpoint rings are open-coded cleaned up in a duplicate fashion
in two places. Provide common helper. This is later used to as a place
to inject ring-type-specific post-reap operations.
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-ring.c | 17 +
1 files chan
In preparation for dynamic ring expansion while walking scatterlists for
v1.0+ xhci hosts force the ring sizes to be a power-of-2. This property
combined with the conversion of segments to a doubly linked list allows
for translating ring pointers to integers enabling simple math to
interrogate the
This can simply be done inline in xhci_queue_isoc_tx().
Signed-off-by: Dan Williams
---
drivers/usb/host/xhci-ring.c |6 +++---
drivers/usb/host/xhci.h |1 -
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
in
1 - 100 of 128 matches
Mail list logo
