[PATCH] drivers: usb: fsl: Check IP version 2.4 for mph USB controller

2014-08-21 Thread Nikhil Badola
Check 2.4 IP version for multi port host USB controller and return FSL_USB_VER_2_4 macro Signed-off-by: Nikhil Badola --- drivers/usb/host/fsl-mph-dr-of.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c index 9162d1b..e03

[PATCH] drivers: usb :fsl: Add support for USB controller version-2.5

2014-08-21 Thread Nikhil Badola
Add support for USB controller version-2.5 used in T4240 rev2.0, T1024, B3421, T1040, T2080, LS1021A. Signed-off-by: Nikhil Badola --- - Depends on commit 990c2c7829d98517228f2b2ff14919c83b75e124 drivers: usb: fsl: Check IP version 2.4 for mph USB controller drivers/usb/host/f

Re: [PATCH 1/3] usb: add support for Diolan DLN-2 devices

2014-08-21 Thread Johan Hovold
On Wed, Aug 20, 2014 at 02:24:45PM +0300, Daniel Baluta wrote: > From: Octavian Purdila > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > Master Adapter DLN-2. Details about the device can be found here: > > https://www.diolan.com/i2c/i2c_interface.html. > > Information ab

Re: [linux-usb] USB Gadget drivers Windows 7/8 support and .bAlternateSetting in interface descriptor

2014-08-21 Thread Sebastian Andrzej Siewior
On 08/20/2014 02:13 AM, Peter Chen wrote: > > Thanks, so Xunbing, the imx6 hardware (chipidea core) have 8 endpoints, > and support all four transfer type, it should be no problem to support > RNDIS. But you shouldn't use RNDIS on Windows 7 or 8. As far as I recall they do not bring the RNDIS dri

[PATCH v2 RESEND] usb: gadget/uvc: remove DRIVER_VERSION{,_NUMBER}

2014-08-21 Thread Michael Grzeschik
As the driver is mainline we can remove the version numbers. Signed-off-by: Michael Grzeschik Acked-by: Laurent Pinchart --- Rebased on v3.17-rc1 drivers/usb/gadget/function/uvc.h | 3 --- drivers/usb/gadget/function/uvc_v4l2.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff

Re: USB reset xhci_hcd for ELAN touchscreen

2014-08-21 Thread Johan Hovold
On Wed, Aug 20, 2014 at 08:20:43AM -0500, Jiri Kosina wrote: > On Mon, 14 Jul 2014, Johan Hovold wrote: > > > From 8101c0dfd42a232f1d2872de4f412d8d61d5646f Mon Sep 17 00:00:00 2001 > > From: Johan Hovold > > Date: Mon, 14 Jul 2014 18:43:31 +0200 > > Subject: [PATCH] HID: usbhid: add HID_QUIRK_IN

[PATCH 4/6] phy: remove the old lookup method

2014-08-21 Thread Heikki Krogerus
The users of the old method are now converted to the new one. Signed-off-by: Heikki Krogerus Tested-by: Vivek Gautam --- drivers/phy/phy-bcm-kona-usb2.c | 2 +- drivers/phy/phy-core.c | 45 +++-- drivers/phy/phy-exynos-dp-video.c | 2 +- driv

[PATCH 5/6] base: platform: name the device already during allocation

2014-08-21 Thread Heikki Krogerus
The device name is needed when assigning resources like clocks or GPIOs to devices using lookups. If PLATFORM_DEVICE_AUTO is used, the device name is not know before platform_device_add is called after which it's too late to assign that kind of resources as the drivers most likely have already requ

[PATCH 2/6] phy: improved lookup method

2014-08-21 Thread Heikki Krogerus
Removes the need for the phys to be aware of their users even when not using DT. The method is copied from clkdev.c. Signed-off-by: Heikki Krogerus Tested-by: Vivek Gautam --- Documentation/phy.txt | 66 --- drivers/phy/phy-core.c | 135 ++

[PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

2014-08-21 Thread Heikki Krogerus
On some platforms a PHY may need to be handled also in the host controller driver. Exynos5420 SoC requires some "PHY tuning" based on the USB speed. This patch delivers dwc3's PHYs to the xhci platform device when it's created. Signed-off-by: Heikki Krogerus Tested-by: Vivek Gautam Acked-by: Fel

[PATCHv3 0/6] phy: simplified phy lookup

2014-08-21 Thread Heikki Krogerus
Hi, So the idea with these is that they should help to make it possible to request phys without caring about how they are mapped to the consumers, meaning, was is the mapping done in DT, ACPI, etc. Mapping phys to consumers can be now done with lookups similarly how clocks can be mapped in clkdev.

[PATCH 3/6] arm: omap3: twl: use the new lookup method with usb phy

2014-08-21 Thread Heikki Krogerus
Provide complete association for the phy and it's user (musb) with the new phy lookup method. Signed-off-by: Heikki Krogerus --- arch/arm/mach-omap2/twl-common.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/ma

[PATCH 1/6] phy: safer to_phy() macro

2014-08-21 Thread Heikki Krogerus
This makes to_phy() macro work with other variable names besides "dev". Signed-off-by: Heikki Krogerus Tested-by: Vivek Gautam --- include/linux/phy/phy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index 8cb6f81..9fda683

[PATCH v2 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-08-21 Thread Vivek Gautam
Now that we have completely moved from older USB-PHY drivers to newer GENERIC-PHY drivers for PHYs available with USB controllers on Exynos series of SoCs, we can remove the support for the same in our host drivers too. This should fix the issue on ehci-exynos, wherein in the absence of SAMSUNG_USB

[PATCH v2 2/2] usb: host: ohci-exynos: Remove unnecessary usb-phy support

2014-08-21 Thread Vivek Gautam
Now that we have completely moved from older USB-PHY drivers to newer GENERIC-PHY drivers for PHYs available with USB controllers on Exynos series of SoCs, we can remove the support for the same in our host drivers too. This should fix the issue on ohci-exynos, wherein in the absence of SAMSUNG_USB

[PATCH v5 1/3] usb: gadget: f_fs: fix the redundant ep files problem

2014-08-21 Thread Robert Baldyga
Up to now, when endpoint addresses in descriptors were non-consecutive, there were created redundant files, which could cause problems in kernel, when user tryed to read/write to them. It was result of fact that maximum endpoint address was taken as total number of endpoints in funciton. This patc

[PATCH v5 0/3] usb: gadget: f_fs: userspace API fixes and improvements

2014-08-21 Thread Robert Baldyga
This patchset contains changes in FunctionFS making it easier and safer to use. It fixes bug in endpoint files handling code, adds new ioctl allowing to obtain endpoint descriptor, and introduces virtual address mapping which allows to separate endpoint address space in function from physical endpo

[PATCH v5 3/3] usb: gadget: f_fs: virtual endpoint address mapping

2014-08-21 Thread Robert Baldyga
This patch introduces virtual endpoint address mapping. It separates function logic form physical endpoint addresses making it more hardware independent. Following modifications changes user space API, so to enable them user have to switch on the FUNCTIONFS_VIRTUAL_ADDR flag in descriptors. Endpo

[PATCH v5 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor

2014-08-21 Thread Robert Baldyga
This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which returns endpoint descriptor to userspace. It works only if function is active. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/function/f_fs.c | 21 + include/uapi/linux/usb/functionfs.h | 6 ++ 2 fi

Re: [PATCH v3] usb: hcd: add generic PHY support

2014-08-21 Thread Vivek Gautam
On Fri, May 30, 2014 at 7:46 PM, Sergei Shtylyov wrote: > Hello. > > On 05/30/2014 06:12 PM, Yoshihiro Shimoda wrote: > >> From Sergei Shtylyov > > >Should be "From:". > > >> Add the generic PHY support, analogous to the USB PHY support. Intended it >> to be >> used with the PCI EHCI/OHCI dr

Re: [PATCH v3] usb: hcd: add generic PHY support

2014-08-21 Thread Sergei Shtylyov
Hello. On 08/21/2014 04:44 PM, Vivek Gautam wrote: From Sergei Shtylyov Should be "From:". Add the generic PHY support, analogous to the USB PHY support. Intended it to be used with the PCI EHCI/OHCI drivers and the xHCI platform driver. Signed-off-by: Sergei Shtylyov Signed-of

Re: [PATCH v4 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-08-21 Thread Peter Griffin
Hi Felipe, Will fix the commit log and rebase onto 3.17-rc1 for the next iteration. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] usb: hcd: add generic PHY support

2014-08-21 Thread Vivek Gautam
Hi Sergei, On Thu, Aug 21, 2014 at 6:37 PM, Sergei Shtylyov wrote: > Hello. > > > On 08/21/2014 04:44 PM, Vivek Gautam wrote: > From Sergei Shtylyov > > >>> Should be "From:". > > Add the generic PHY support, analogous to the USB PHY support. Intended it to be use

Re: [PATCH v4 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-08-21 Thread Peter Griffin
Hi Felipe, Thanks for reviewing, see my comments below: - On Wed, 20 Aug 2014, Felipe Balbi wrote: > > + dwc3: dwc3@990 { > > + compatible = "snps,dwc3"; > > + reg = <0x0990 0x10>; > > + interrupts = ; > > + dr_mode

Re: [PATCH v2 0/9] Tegra xHCI support

2014-08-21 Thread Tomeu Vizoso
On 18 August 2014 19:08, Andrew Bresticker wrote: > > Tested on Venice2, Jetson TK1, and Big with a variety of USB2.0 and > USB3.0 memory sticks and ethernet dongles using controller firmware from > the ChromiumOS tree [2]. Hi Andrew, do you have any information regarding the port assignments fo

Re: [PATCH v4 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-08-21 Thread Felipe Balbi
On Thu, Aug 21, 2014 at 02:33:40PM +0100, Peter Griffin wrote: > Hi Felipe, > > Thanks for reviewing, see my comments below: - > > On Wed, 20 Aug 2014, Felipe Balbi wrote: > > > > + dwc3: dwc3@990 { > > > + compatible = "snps,dwc3"; > > > + reg = <0x0990

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-08-21 Thread Felipe Balbi
On Thu, Aug 21, 2014 at 12:19:03PM +0530, sundeep subbaraya wrote: > Hi Daniel, > > On Tue, Aug 19, 2014 at 3:26 PM, Daniel Mack wrote: > > Hi, > > > > On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote: > >> This patch adds xilinx usb2 device driver support > > > > Add some more information

Re: [PATCH v4 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-08-21 Thread Peter Griffin
Hi Felipe, On Thu, 21 Aug 2014, Felipe Balbi wrote: > > Currently (in the vendor tree) one of the phys lives in > > drivers/usb/phy and the other in drivers/phy. > > I believe that is because one is only a usb phy and the other is a > > multi function phy which can drive PCI-E or USB3. > > right

Re: [PATCH v4 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-08-21 Thread Felipe Balbi
Hi Peter, On Thu, Aug 21, 2014 at 03:03:47PM +0100, Peter Griffin wrote: > Hi Felipe, > > On Thu, 21 Aug 2014, Felipe Balbi wrote: > > > > Currently (in the vendor tree) one of the phys lives in > > > drivers/usb/phy and the other in drivers/phy. > > > I believe that is because one is only a usb

Re: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-21 Thread Alan Stern
On Thu, 21 Aug 2014, Peter Chen wrote: > On Wed, Aug 20, 2014 at 03:18:47PM -0400, Alan Stern wrote: > > On Wed, 20 Aug 2014, Felipe Balbi wrote: > > > > > > > > --- a/drivers/usb/gadget/composite.c > > > > > > +++ b/drivers/usb/gadget/composite.c > > > > > > @@ -1956,6 +1956,7 @@ void composite_

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-21 Thread Christoph Hellwig
On Thu, Aug 21, 2014 at 10:41:02AM -0400, Douglas Gilbert wrote: > Perhaps we could add another bit flag in struct > scsi_host_template such as: > unsigned int transport_says_dont_scsi2_lun_cmd:1; > > then drivers/usb/storage/scsiglue.c could set that > bit in its usb_stor_host_template and >

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-21 Thread Douglas Gilbert
On 14-08-20 03:15 PM, Alan Stern wrote: On Tue, 19 Aug 2014, Christoph Hellwig wrote: On Thu, Aug 07, 2014 at 11:58:37AM -0400, Alan Stern wrote: On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: I doubt either of them forces users to hack up flags for these cases. Why was this ch

[PATCH 3/4] usb: gadget: f_uvc: fix potential memory leak

2014-08-21 Thread Laurent Pinchart
From: Andrzej Pietrasiewicz If uvc->control_buf is successfuly allocated but uvc->control_req is not, uvc->control_buf is not freed in the error recovery path. With this patch applied uvc->control_buf is freed unconditionally; if it happens to be NULL kfree on it is safe anyway. Signed-off-by: A

[PATCH 2/4] usb: gadget/uvc: Add support for DMABUF importing

2014-08-21 Thread Laurent Pinchart
From: Philipp Zabel Activate the videobuf2 DMABUF support. As vb2-vmalloc supports the importer role only, exporting buffers isn't supported yet. When the exporter role will be implemented in vb2-vmalloc the UVC gadget driver will automatically gain support for it. Signed-off-by: Philipp Zabel

[PATCH 4/4] usb: gadget/uvc: remove DRIVER_VERSION{,_NUMBER}

2014-08-21 Thread Laurent Pinchart
From: Michael Grzeschik As the driver is mainline we can remove the version numbers. Signed-off-by: Michael Grzeschik Signed-off-by: Laurent Pinchart --- drivers/usb/gadget/function/uvc.h | 3 --- drivers/usb/gadget/function/uvc_v4l2.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions

[PATCH 0/4] UVC gadget patches for v3.18

2014-08-21 Thread Laurent Pinchart
Hi Felipe, These patches have previously been posted to linux-usb. I've rebased them on top of your master branch. Could you please apply them to your tree for v3.18 ? Andrzej Pietrasiewicz (1): usb: gadget: f_uvc: fix potential memory leak Michael Grzeschik (2): usb: gadget/uvc: Change KERN

[PATCH 1/4] usb: gadget/uvc: Change KERN_INFO to KERN_DEBUG on request shutdown

2014-08-21 Thread Laurent Pinchart
From: Michael Grzeschik The disconnect of the USB Device is a common pattern for an UVC Camera. In many cases this will give us an meaningless information for all buffers that couldn't be enqueued. That patch changes this to KERN_DEBUG. Signed-off-by: Michael Grzeschik Signed-off-by: Laurent Pi

[PATCH v5 3/4] usb: hcd: Caibrate PHY post hcd reset

2014-08-21 Thread Vivek Gautam
Some quirky PHYs may require to be calibrated post the hcd initialization. The USB 3.0 DRD PHY on Exynos5420/5800 systems, coming along with Synopsys's DWC3 controller, is one such PHY which needs to be calibrated post xhci's reset at initialization time and at resume time, to get the controller wo

[PATCH v5 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-08-21 Thread Vivek Gautam
Adding phy calibrate callback, which facilitates setting certain PHY settings post initialization of the PHY controller. Exynos5420 and Exynos5800 have 28nm USB 3.0 DRD PHY for which the Loss-of-Signal (LOS) Detector Threshold Level as well as Tx-Vboost-Level should be controlled for Super-Speed op

[PATCH v5 2/4] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-08-21 Thread Vivek Gautam
The host controller by itself may sometimes need to handle PHY and/or calibrate some of the PHY settings to get full support out of the PHY controller. The PHY core provides a calibration funtionality now to do so. Therefore, facilitate getting the two possible PHYs, viz. USB 2.0 type (UTMI+) and U

[PATCH v5 1/4] phy: Add provision for calibrating phy.

2014-08-21 Thread Vivek Gautam
Some PHY controllers may need to calibrate certain PHY settings after initialization of the controller and sometimes even after initializing the PHY-consumer too. Add support for the same in order to let consumers do so in need. Signed-off-by: vivek Gautam --- drivers/phy/phy-core.c | 36

[PATCH v5 0/4] Fine tune USB 3.0 PHY on exynos5420

2014-08-21 Thread Vivek Gautam
This series is based on Heikki's patches for simpliefied phy lookup table: [PATCHv3 0/6] phy: simplified phy lookup [1], applied against 'usb-next' branch alongwith Sergei's patch for adding generic phy support to usb hcd [2]. Changes since v4: - Rebased on latest patches by Heikki. - Took care

RE: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-21 Thread Peter Chen
> > > On Wed, Aug 20, 2014 at 03:18:47PM -0400, Alan Stern wrote: > > > On Wed, 20 Aug 2014, Felipe Balbi wrote: > > > > > > > > > > --- a/drivers/usb/gadget/composite.c > > > > > > > +++ b/drivers/usb/gadget/composite.c > > > > > > > @@ -1956,6 +1956,7 @@ void composite_dev_cleanup(struct > u

RE: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-21 Thread Alan Stern
On Thu, 21 Aug 2014, Peter Chen wrote: > > > > > dequeue should cause the transfer to be cancelled and given back. > > > > > There's a slight possible race window because we release the > > > > > controller lock in order to call gadget driver's ->complete(). > > > > > > > > > > > The dp has alread

[PATCH] usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps

2014-08-21 Thread Tony Lindgren
Commit 30a70b026b4cd ("usb: musb: fix obex in g_nokia.ko causing kernel panic") attempted to fix runtime PM handling for PHYs that are on the I2C bus. Commit 3063a12be2b0 (usb: musb: fix PHY power on/off) then changed things around to enable of PHYs that rely on runtime PM. These changes however b

[PATCH] usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down

2014-08-21 Thread Tony Lindgren
Commit 249751f22380 ("usb: phy: twl4030-usb: poll for ID disconnect") added twl4030_id_workaround_work() to deal with lost interrupts after ID pin goes down. However, this currently only works for the insertion. The PHY interrupts are not working after disconnecting an USB-A device from the board,

Re: [PATCH] usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps

2014-08-21 Thread Felipe Balbi
On Thu, Aug 21, 2014 at 09:43:46AM -0700, Tony Lindgren wrote: > Commit 30a70b026b4cd ("usb: musb: fix obex in g_nokia.ko causing kernel > panic") attempted to fix runtime PM handling for PHYs that are on the > I2C bus. Commit 3063a12be2b0 (usb: musb: fix PHY power on/off) then > changed things aro

Re: [PATCH] usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down

2014-08-21 Thread Felipe Balbi
On Thu, Aug 21, 2014 at 09:48:04AM -0700, Tony Lindgren wrote: > Commit 249751f22380 ("usb: phy: twl4030-usb: poll for ID disconnect") > added twl4030_id_workaround_work() to deal with lost interrupts > after ID pin goes down. However, this currently only works for the > insertion. The PHY interrup

Re: [PATCH] usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps

2014-08-21 Thread Tony Lindgren
* Felipe Balbi [140821 10:09]: > On Thu, Aug 21, 2014 at 09:43:46AM -0700, Tony Lindgren wrote: > > @@ -744,6 +778,9 @@ static int twl4030_usb_probe(struct platform_device > > *pdev) > > return status; > > } > > > > + pm_runtime_mark_last_busy(&pdev->dev); > > + pm_runtime_p

Re: [PATCH v2 0/9] Tegra xHCI support

2014-08-21 Thread Andrew Bresticker
On Thu, Aug 21, 2014 at 6:34 AM, Tomeu Vizoso wrote: > On 18 August 2014 19:08, Andrew Bresticker wrote: >> >> Tested on Venice2, Jetson TK1, and Big with a variety of USB2.0 and >> USB3.0 memory sticks and ethernet dongles using controller firmware from >> the ChromiumOS tree [2]. > > Hi Andrew,

Re: [PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-21 Thread Sergei Shtylyov
On 08/21/2014 06:12 AM, Hayes Wang wrote: [...] r8152b_disable_aldps(tp); - rtl_clear_bp(tp); Why leave 2 empty lines? One is enough. The next patch would use another fucntion at the same location. I skip removing the empty line and re-adding it again. Is that better

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-21 Thread Alan Stern
On Thu, 21 Aug 2014, Christoph Hellwig wrote: > On Thu, Aug 21, 2014 at 10:41:02AM -0400, Douglas Gilbert wrote: > > Perhaps we could add another bit flag in struct > > scsi_host_template such as: > > unsigned int transport_says_dont_scsi2_lun_cmd:1; > > > > then drivers/usb/storage/scsiglue.

Re: USB reset xhci_hcd for ELAN touchscreen

2014-08-21 Thread Jiri Kosina
On Thu, 21 Aug 2014, Johan Hovold wrote: > > It's not really super-nice, but if no other way around it has been found > > to be possible in USB core, I am willing to take this. > > Agreed, it's not that nice, but I'm not aware of any other way to > prevent the device firmware from disconnecting.

RE: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-21 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern > Sent: Thursday, August 21, 2014 8:38 AM > > On Thu, 21 Aug 2014, Peter Chen wrote: > > > > > > > dequeue should cause the transfer to be cancelled and given back. > > > > > > There's a sl

RE: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-21 Thread Alan Stern
On Thu, 21 Aug 2014, Paul Zimmerman wrote: > AFAIK, it has always been a requirement that usb_ep_dequeue() release > the data buffer and call the urb's completion routine before it returns. Hmmm. I don't know if that really has been a requirement, but it does seem to be true in the UDC drivers

RE: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-21 Thread Paul Zimmerman
> From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Thursday, August 21, 2014 12:16 PM > > On Thu, 21 Aug 2014, Paul Zimmerman wrote: > > > AFAIK, it has always been a requirement that usb_ep_dequeue() release > > the data buffer and call the urb's completion routine before it returns.

RE: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-21 Thread Alan Stern
On Thu, 21 Aug 2014, Paul Zimmerman wrote: > > From: Alan Stern [mailto:st...@rowland.harvard.edu] > > Sent: Thursday, August 21, 2014 12:16 PM > > > > On Thu, 21 Aug 2014, Paul Zimmerman wrote: > > > > > AFAIK, it has always been a requirement that usb_ep_dequeue() release > > > the data buffer

Re: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-21 Thread Felipe Balbi
On Thu, Aug 21, 2014 at 03:55:13PM -0400, Alan Stern wrote: > On Thu, 21 Aug 2014, Paul Zimmerman wrote: > > > > From: Alan Stern [mailto:st...@rowland.harvard.edu] > > > Sent: Thursday, August 21, 2014 12:16 PM > > > > > > On Thu, 21 Aug 2014, Paul Zimmerman wrote: > > > > > > > AFAIK, it has a

[PATCH] usb: gadget: document a usb_ep_dequeue() requirement

2014-08-21 Thread Paul Zimmerman
Document the requirement that the request be dequeued and its completion routine called before usb_ep_dequeue() returns. Also fix some capitalization issues in the existing text. Signed-off-by: Paul Zimmerman Acked-by: Alan Stern --- include/linux/usb/gadget.h | 9 + 1 file changed, 5 i

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-21 Thread Martin K. Petersen
> "Alan" == Alan Stern writes: Alan> Okay, here's a patch that implements the suggestion, except that I Alan> put the flag in the Scsi_Host structure instead of the template. Alan> This was to minimize the impact of the change. Among the various Alan> SCSI-over-USB transports, only the Bulk-

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-21 Thread Christoph Hellwig
On Thu, Aug 21, 2014 at 05:43:41PM -0400, Martin K. Petersen wrote: > Alan> Okay, here's a patch that implements the suggestion, except that I > Alan> put the flag in the Scsi_Host structure instead of the template. > Alan> This was to minimize the impact of the change. Among the various > Alan> S

Re: [PATCH 1/3] usb: add support for Diolan DLN-2 devices

2014-08-21 Thread Octavian Purdila
On Thu, Aug 21, 2014 at 11:07 AM, Johan Hovold wrote: > On Wed, Aug 20, 2014 at 02:24:45PM +0300, Daniel Baluta wrote: >> From: Octavian Purdila >> >> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO >> Master Adapter DLN-2. Details about the device can be found here: >> > > I t

RE: [PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-21 Thread Hayes Wang
Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] [...] > >> Why leave 2 empty lines? One is enough. > > > The next patch would use another fucntion at the > > same location. I skip removing the empty line and > > re-adding it again. Is that better to do so? I would > > resend the

Re: [linux-usb] USB Gadget drivers Windows 7/8 support and .bAlternateSetting in interface descriptor

2014-08-21 Thread Xuebing Wang
On 08/21/2014 04:24 PM, Sebastian Andrzej Siewior wrote: On 08/20/2014 02:13 AM, Peter Chen wrote: Thanks, so Xunbing, the imx6 hardware (chipidea core) have 8 endpoints, and support all four transfer type, it should be no problem to support RNDIS. But you shouldn't use RNDIS on Windows 7 or 8

Re: [PATCH v3 4/6] usb: common: add API to get if the platform supports TPL

2014-08-21 Thread Peter Chen
On Thu, Aug 21, 2014 at 12:14:42AM +0800, Felipe Balbi wrote: > Hi, > > On Tue, Aug 19, 2014 at 09:51:55AM +0800, Peter Chen wrote: > > The TPL (Targeted Peripheral List) is used for targeted hosts > > (non-PC hosts), and it can be used at USB OTG & EH certification > > and some specific products

Re: [PATCH] usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps

2014-08-21 Thread Kishon Vijay Abraham I
Hi, On Thursday 21 August 2014 10:13 PM, Tony Lindgren wrote: > Commit 30a70b026b4cd ("usb: musb: fix obex in g_nokia.ko causing kernel > panic") attempted to fix runtime PM handling for PHYs that are on the > I2C bus. Commit 3063a12be2b0 (usb: musb: fix PHY power on/off) then > changed things aro