[linux-usb] Is UAC1 (USB Audio Class 1.0) broken?

2014-08-17 Thread Xuebing Wang
Hi Community, Felipe, I am trying to get UAC1 working on Freescale i.MX6SL EVK board (as USB peripheral device), which is based on kernel 3.10.17. In order to get UAC1 working with my Ubuntu 12.04 LTS host, I have to make a few changes to driver/usb/gadget/f_uac1.c I check Mr. Torvald's mas

[PATCH] usb: phy: return -ENODEV on failure of try_module_get

2014-08-17 Thread Arjun Sreedharan
When __usb_find_phy_dev() does not return error and try_module_get() fails, return -ENODEV Signed-off-by: Arjun Sreedharan --- drivers/usb/phy/phy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 36b6bce..8ad3638 100644 --- a/drivers/usb/p

[PATCH] usb: gadget: remove $(PWD) in ccflags-y

2014-08-17 Thread Philippe Reynes
The variable $(PWD) is useless, and it may break the compilation. For example, it breaks the kernel compilation when it's done with buildroot : /home/trem/Codes/armadeus/armadeus/buildroot/output/host/usr/bin/ccache /home/trem/Codes/armadeus/armadeus/buildroot/output/host/usr/bin/arm-buildroot-l

Re: [PATCH 1/7] usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver

2014-08-17 Thread Jingoo Han
On Thursday, August 14, 2014 11:24 PM, Vivek Gautam wrote: > > Removing this older USB 3.0 DRD controller PHY driver, since > a new driver based on generic phy framework is now available. > > Signed-off-by: Vivek Gautam Reviewed-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/usb/ph

Re: [PATCH RFC 6/7] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-08-17 Thread Jingoo Han
On Thursday, August 14, 2014 11:24 PM, Vivek Gautam wrote: > > Now that we have completely moved from older USB-PHY drivers > to newer GENERIC-PHY drivers for PHYs available with USB controllers > on Exynos series of SoCs, we can remove the support for the same > in our host drivers too. > This sh

Re: [PATCH RFC 7/7] usb: host: ohci-exynos: Remove unnecessary usb-phy support

2014-08-17 Thread Jingoo Han
On Thursday, August 14, 2014 11:24 PM, Vivek Gautam wrote: > > Now that we have completely moved from older USB-PHY drivers > to newer GENERIC-PHY drivers for PHYs available with USB controllers > on Exynos series of SoCs, we can remove the support for the same > in our host drivers too. > This sh

Re: [PATCH] usb: gadget: remove $(PWD) in ccflags-y

2014-08-17 Thread Greg KH
On Mon, Aug 18, 2014 at 12:08:07AM +0200, Philippe Reynes wrote: > The variable $(PWD) is useless, and it may break the compilation. > For example, it breaks the kernel compilation when it's done with > buildroot : > > /home/trem/Codes/armadeus/armadeus/buildroot/output/host/usr/bin/ccache > /ho

Re: [PATCH] usb: phy: return -ENODEV on failure of try_module_get

2014-08-17 Thread Greg KH
On Mon, Aug 18, 2014 at 12:04:42AM +0530, Arjun Sreedharan wrote: > When __usb_find_phy_dev() does not return error and > try_module_get() fails, return -ENODEV > > Signed-off-by: Arjun Sreedharan > --- > drivers/usb/phy/phy.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb

[PATCH 2/2v v2] USB: ftdi_sio: fix some coding style issues

2014-08-17 Thread Jaša Bartelj
Changes two simple if statements to switch statements. Fixes some issues reported by checkpatch.pl like whitespace. Bracing changes so all arms of a statement have consistent bracing. Signed-off-by: Jaša Bartelj --- drivers/usb/serial/ftdi_sio.c | 48 +--

[PATCH 01/13] usb: gadget: introduce .connect gadget driver API

2014-08-17 Thread Peter Chen
We introduce the connect API at usb_gadget_driver, the udc driver uses it to tell gadget driver that it is ready to CONNECT, and the dp can be pulled up from now on. Meanwhile, we introduce an API usb_udc_ready_to_connect to encapsulate above operation. Signed-off-by: Peter Chen --- include/lin

[PATCH 02/13] usb: udc: set the udc is ready to pullup dp when it needs

2014-08-17 Thread Peter Chen
Except for chipidea driver, all other udc drivers will tell the gadget driver that they are ready to pullup dp at udc_start, it is the default behaviour. The chipidea driver is ready to pullup dp when the vbus is there, and isn't ready to pullup dp when the vbus is not there. Other udc drivers whi

[PATCH 00/13] usb: gadget: change pullup dp stratery

2014-08-17 Thread Peter Chen
We have a discussion at http://www.spinics.net/lists/linux-usb/msg111860.html about current pullup dp limitations, this patchset is intended to fix two problems in discussion, they are: - Some function drivers (uvc, obex) can't pullup on demand, they needs to pullup dp after app loads. - Some udc d

[PATCH 05/13] usb: gadget: gadgetfs: add .connect API for its usb_gadget_driver

2014-08-17 Thread Peter Chen
It is used for udc to pullup dp when necessary Signed-off-by: Peter Chen --- drivers/usb/gadget/legacy/inode.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index 2e4ce77..1166e77 100644 --- a/drivers/us

[PATCH 06/13] usb: gadget: dbgp: add .connect API for its usb_gadget_driver

2014-08-17 Thread Peter Chen
It is used for udc to pullup dp when necessary Signed-off-by: Peter Chen --- drivers/usb/gadget/legacy/dbgp.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/usb/gadget/legacy/dbgp.c b/drivers/usb/gadget/legacy/dbgp.c index 986fc51..bcc780b 100644 --- a/drivers/usb/ga

[PATCH 04/13] usb: gadget: configfs: add .connect API for its usb_gadget_driver

2014-08-17 Thread Peter Chen
Define .connect for configfs_driver_template, and export composite_connect for configfs. Signed-off-by: Peter Chen --- drivers/usb/gadget/composite.c |2 +- drivers/usb/gadget/configfs.c |1 + include/linux/usb/composite.h |1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 03/13] usb: gadget: composite: add .connect API for its usb_gadget_driver

2014-08-17 Thread Peter Chen
It is used for udc to pullup dp when necessary Signed-off-by: Peter Chen --- drivers/usb/gadget/composite.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 6935a82..c4ce977 100644 --- a/drivers/usb/gadget/

[PATCH 10/13] usb: gagdet: f_obex: delete the deactivate function operation at bind

2014-08-17 Thread Peter Chen
The deactivate function has already done by composite.c for every function. Signed-off-by: Peter Chen --- drivers/usb/gadget/function/f_obex.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/gadget/function/f_obex.c b/drivers/usb/gadget/function/f_obe

[PATCH 11/13] usb: gagdet: f_uvc: delete the deactivate function operation at bind

2014-08-17 Thread Peter Chen
The deactivate function has already done by composite.c for every function. Signed-off-by: Peter Chen --- drivers/usb/gadget/function/f_uvc.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c index e2a1f50..716c

[PATCH 12/13] usb: gadget: udc-core: change dp pullup/pulldown strategy

2014-08-17 Thread Peter Chen
Currently, the dp pullup will according to whether udc is available to pullup up and the function driver's requirement, so, delete the unconditional dp pullup operation at udc-core. But we still need to pulldown up unconditionally when the gadget driver is unloaded no matter the connection is ther

[PATCH 13/13] usb: gadget: udc-core: change dp pullup/pulldown strategy for soft_connect

2014-08-17 Thread Peter Chen
Currently, the dp pullup will according to whether udc is available to pullup up and the function driver's requirement, so, delete the unconditional dp pullup operation at udc-core. But we still need to pulldown up unconditionally when the gadget driver is unloaded no matter the connection is ther

[PATCH 08/13] usb: gadget: composite: deactivate function default

2014-08-17 Thread Peter Chen
Each function driver should activate itself at its function driver when necessary. Most of functions would like to activate them just after binding, but some may have special requirements for when to activate themselves, eg, uvc, it needs the app to open video device first. We do not need to consi

[PATCH 09/13] usb: gadget: function: activate function at bind

2014-08-17 Thread Peter Chen
For these functions, it has no special requirement when to activate them, so activate their function at function.bind. Signed-off-by: Peter Chen --- drivers/usb/gadget/function/f_acm.c |2 ++ drivers/usb/gadget/function/f_ecm.c |1 + drivers/usb/gadget/function/f_eem.c

[PATCH 07/13] usb: gadget: composite: change pullup/pulldown dp strategy

2014-08-17 Thread Peter Chen
- If the udc is ready to pullup dp and all functions at gadget driver want to pullup dp, it will pullup dp. - If the udc doesn't want to pullup dp or one of functions at gadget driver doesn't want to pullup up. it will pull down dp. Signed-off-by: Peter Chen --- drivers/usb/gadget/composite.c |

[PATCH] usb: phy: return -ENODEV on failure of try_module_get

2014-08-17 Thread Arjun Sreedharan
When __usb_find_phy_dev() does not return error and try_module_get() fails, return -ENODEV. Signed-off-by: Arjun Sreedharan --- drivers/usb/phy/phy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 36b6bce..fd0d7f1 100644 --- a/drivers/u