Re: XHCI_TRUST_TX_LENGTH quirk?

2014-08-12 Thread Mathias Nyman
On 08/11/2014 05:36 PM, Evan Langlois wrote: > I thought there was some reason why the code didn't already trust the > length. I even made a comment to the fact that the system already > tells me that its needed, so my patch to turn it on seems silly. I > just assumed there was a reason it didn't

RE: [RFC PATCH] Revert "usb: chipidea: udc: .pullup is valid only when vbus is there"

2014-08-12 Thread Peter Chen
> On Mon, 11 Aug 2014, Peter Chen wrote: > > > > Hello Peter, > > > > > > I have seen this call is still returning EOPNOTSUPP which is also > > > returned by usb_gadget_connect and usb_gadget_disconnect if the > > > pullup function is not available. Should it not handle that case > somehow spec

Re: xhci_hcd FAILS after one scan

2014-08-12 Thread Stéphane Lavergne
Sarah Sharp writes: > This is a known issue. We have it tracked in our bug tracker, and > Mathias is working on a fix on top of the global command queue patches > to address this issue. Mathias will contact you when he gets a fix in > place. (First-time poster here, I hope I'm doing this right.

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-12 Thread Johan Hovold
On Sat, Aug 09, 2014 at 02:46:56AM +0800, Wang YanQing wrote: > On Fri, Aug 08, 2014 at 09:54:42AM +0200, Johan Hovold wrote: > > On Fri, Aug 08, 2014 at 03:10:34AM +0800, Wang YanQing wrote: > > > On Tue, Aug 05, 2014 at 03:54:08PM +0200, Johan Hovold wrote: > > > > > > I noticed that setting dire

RE: [RFC PATCH] Revert "usb: chipidea: udc: .pullup is valid only when vbus is there"

2014-08-12 Thread Alan Stern
On Tue, 12 Aug 2014, Peter Chen wrote: > > > I did this for possible pullup dp without connection (eg load gadget > > > driver before vbus connect), it breaks USB spec, see 7.1.7.3 Connect > > and Disconnect Signaling at USB 2.0 spec. > > > > 7.1.7.3 doesn't say anything about enabling the D+ pul

Re: [RFC 3/3] usb/gadget: f_uvc: add configfs support

2014-08-12 Thread Michael Grzeschik
Hi Andrzej, On Thu, Jul 17, 2014 at 02:42:19PM +0200, Andrzej Pietrasiewicz wrote: > Add support for using uvc as a component of a composite gadget > set up with configfs. > > Signed-off-by: Andrzej Pietrasiewicz > --- > Documentation/ABI/testing/configfs-usb-gadget-uvc | 11 + > drivers/usb/

[PATCH] usb: xhci: amd chipset also needs short TX quirk

2014-08-12 Thread Huang Rui
AMD xHC also needs short tx quirk after tested on most of chipset generations. That's because there is the same incorrect behavior like Fresco Logic host. Please see below message with on USB webcam attached on xHC host: [ 139.262944] xhci_hcd :00:10.0: WARN Successful completion on short TX:

Re: [PATCH v7] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-12 Thread Johan Hovold
On Sat, Aug 09, 2014 at 01:28:28PM +0800, Wang YanQing wrote: > PL2303 USB Serial devices always has GPIOs, Always? Are you sure? It's probably better to write "might have" as they are unlikely to be accessible even if the pins exist. > this patch add > generic gpio support interfaces for pl2303

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Hans de Goede
Hi Udo, On 08/07/2014 04:49 PM, Udo van den Heuvel wrote: > On 2014-08-04 11:17, Laurent Pinchart wrote: >> (CC'ing Hans de Goede, the pwc maintainer, and the linux-media mailing list) Thanks for the bug report. I've been looking into this, and there seem to be 2 problems: 1: xhci_hcd :02:00

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Udo van den Heuvel
On 2014-08-12 17:07, Hans de Goede wrote: > lspci -nn # lspci -nn 00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Family 15h (Models 10h-1fh) Processor Root Complex [1022:1410] 00:00.2 IOMMU [0806]: Advanced Micro Devices, Inc. [AMD] Family 15h (Models 10h-1fh) I/O Memory Management

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Hans Verkuil
On 08/12/2014 05:07 PM, Hans de Goede wrote: > Hi Udo, > > On 08/07/2014 04:49 PM, Udo van den Heuvel wrote: >> On 2014-08-04 11:17, Laurent Pinchart wrote: >>> (CC'ing Hans de Goede, the pwc maintainer, and the linux-media mailing list) > > Thanks for the bug report. I've been looking into this,

usbserial_generic

2014-08-12 Thread Kirk Madsen
After a great deal of searching, I discovered that instead of doing a simple "/sbin/modprobe usbserial vendor=0x09d7 product=0x0100", with fedora 20 you now have to edit your grub2 config to add a generic serial device.  Dmesg reported the following, so I am following directions.  Please add thi

Re: To otg-fsm or not to otg-fsm? That is the question.

2014-08-12 Thread Tim Bird
On Mon, Aug 11, 2014 at 5:28 PM, Peter Chen wrote: > The OTG FSM at /usb/common/usb-otg-fsm.c is a software OTG FSM implementation > which follows On-The-Go and Embedded Host Supplement to the USB Revision 2.0 > Specification > (Revision 2.0 version 1.1a) Chapter 7 State Diagrams. > > If the plat

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Laurent Pinchart
Hi Hans, On Tuesday 12 August 2014 17:38:55 Hans Verkuil wrote: > On 08/12/2014 05:07 PM, Hans de Goede wrote: > > On 08/07/2014 04:49 PM, Udo van den Heuvel wrote: > >> On 2014-08-04 11:17, Laurent Pinchart wrote: > >>> (CC'ing Hans de Goede, the pwc maintainer, and the linux-media mailing > >>>

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Hans Verkuil
On 08/12/2014 06:21 PM, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 12 August 2014 17:38:55 Hans Verkuil wrote: >> On 08/12/2014 05:07 PM, Hans de Goede wrote: >>> On 08/07/2014 04:49 PM, Udo van den Heuvel wrote: On 2014-08-04 11:17, Laurent Pinchart wrote: > (CC'ing Hans de Goede,

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Udo van den Heuvel
On 2014-08-12 18:27, Hans Verkuil wrote: > It was a bit confusing, but he has two problems: one pwc, one (the warning) > for > uvc. Indeed. Do I need to provide additional info to help find the root cause(s)? Kind regards, Udo -- To unsubscribe from this list: send the line "unsubscribe linux-u

Re: detected XactErr

2014-08-12 Thread Alexei P
Alan Stern writes: > > On Mon, 11 Aug 2014, Alexei P wrote: > > > I believe the focus of this thread has gone in wrong direction. The question > > should not be about how to disable the flood of "detected XactErr" messages, > > but (a) why does it occur in this particular case, and (b) why ther

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Laurent Pinchart
On Tuesday 12 August 2014 18:27:03 Hans Verkuil wrote: > On 08/12/2014 06:21 PM, Laurent Pinchart wrote: > > Hi Hans, > > > > On Tuesday 12 August 2014 17:38:55 Hans Verkuil wrote: > >> On 08/12/2014 05:07 PM, Hans de Goede wrote: > >>> On 08/07/2014 04:49 PM, Udo van den Heuvel wrote: > On 2

[PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Bin Liu
CPPI TX does not transmit ZLP for TX transfers which - transfer size is multiple of EP packet size, - and URB_ZERO_PACKET is set in urb->transfer_flags. The fix is transmitting the ZLP using PIO mode after the CPPI TX is done. Validated using the following usbtest write case for MUSB host mode.

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Felipe Balbi
On Tue, Aug 12, 2014 at 11:46:32AM -0500, Bin Liu wrote: > CPPI TX does not transmit ZLP for TX transfers which > - transfer size is multiple of EP packet size, > - and URB_ZERO_PACKET is set in urb->transfer_flags. > > The fix is transmitting the ZLP using PIO mode after the CPPI TX is > done. >

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Bin Liu
Hi Daniel, On Tue, Aug 12, 2014 at 11:58 AM, Daniel Mack wrote: > Hi Bin, > > On 08/12/2014 06:46 PM, Bin Liu wrote: >> drivers/usb/musb/musb_cppi41.c | 15 +-- >> 1 file changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/m

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Daniel Mack
Hi Bin, On 08/12/2014 06:46 PM, Bin Liu wrote: > drivers/usb/musb/musb_cppi41.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/musb_cppi41.c > index 5989def..e9a0e54 100644 > --- a/drivers/usb/musb/musb_

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Sergei Shtylyov
Hello. On 08/12/2014 08:46 PM, Bin Liu wrote: CPPI TX does not transmit ZLP for TX transfers which - transfer size is multiple of EP packet size, - and URB_ZERO_PACKET is set in urb->transfer_flags. The fix is transmitting the ZLP using PIO mode after the CPPI TX is done. Validated using

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Bin Liu
Sergei, On Tue, Aug 12, 2014 at 12:10 PM, Sergei Shtylyov wrote: > Hello. > > > On 08/12/2014 08:46 PM, Bin Liu wrote: > >> CPPI TX does not transmit ZLP for TX transfers which >> - transfer size is multiple of EP packet size, >> - and URB_ZERO_PACKET is set in urb->transfer_flags. > > >> The fix

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Daniel Mack
On 08/12/2014 07:05 PM, Bin Liu wrote: >> Don't you need to check for (urb->transfer_flags & URB_ZERO_PACKET) >> somewhere here? I'd not expect an extra 0-byte packet at the end of a >> transfer unless this flag is set. > > mode is set to 1 when (urb->transfer_flags & URB_ZERO_PACKET), in > musb_t

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Kimmo Taskinen
Hi, I have seen similar dmesg message in some other situations (still with 3.15.6 at least): Jul 31 00:08:38 daphile user.err kernel: xhci_hcd :02:00.0: ERROR: unexpected command completion code 0x11. Jul 31 00:08:38 daphile user.info kernel: usb 6-2: Not enough bandwidth for altsettin

Re: detected XactErr

2014-08-12 Thread Alan Stern
On Tue, 12 Aug 2014, Alexei P wrote: > So, you say that protocol errors occur either to "noise", or "device crash". > If it is the "device crash", no amount of transaction retires will lead to > recovery. So it leaves the "noise". > > Under normal definition of "noise", in USB specifications, Sec

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Udo van den Heuvel
On 2014-08-12 17:07, Hans de Goede wrote: > for you. Might be fixed by this commit: > https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host?h=usb-next&id=3213b151387df0b95f4eada104f68eb1c1409cb3 That commit already appears to be in my kernel tree. Kind regards, Udo

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Bin Liu
Daniel, On Tue, Aug 12, 2014 at 12:15 PM, Daniel Mack wrote: > On 08/12/2014 07:05 PM, Bin Liu wrote: >>> Don't you need to check for (urb->transfer_flags & URB_ZERO_PACKET) >>> somewhere here? I'd not expect an extra 0-byte packet at the end of a >>> transfer unless this flag is set. >> >> mode

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Bin Liu
Felipe, On Tue, Aug 12, 2014 at 11:55 AM, Felipe Balbi wrote: > On Tue, Aug 12, 2014 at 11:46:32AM -0500, Bin Liu wrote: >> CPPI TX does not transmit ZLP for TX transfers which >> - transfer size is multiple of EP packet size, >> - and URB_ZERO_PACKET is set in urb->transfer_flags. >> >> The fix

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Daniel Mack
On 08/12/2014 07:32 PM, Bin Liu wrote: > 633 #if defined(CONFIG_USB_INVENTRA_DMA) || defined(CONFIG_USB_UX500_DMA) > ... > 658 #else > 659 if (!is_cppi_enabled() && !tusb_dma_omap()) > 660 return false; > ... > 668 mode = (urb->transfer_flags & URB_ZERO_PACKET) ?

Re: 3.15.6 USB issue with pwc cam

2014-08-12 Thread Kimmo Taskinen
Hi, I have seen similar dmesg message in some other situations (still with 3.15.6 at least): Jul 31 00:08:38 daphile user.err kernel: xhci_hcd :02:00.0: ERROR: unexpected command completion code 0x11. Jul 31 00:08:38 daphile user.info kernel: usb 6-2: Not enough bandwidth for altsettin

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Sergei Shtylyov
On 08/12/2014 09:13 PM, Bin Liu wrote: CPPI TX does not transmit ZLP for TX transfers which - transfer size is multiple of EP packet size, - and URB_ZERO_PACKET is set in urb->transfer_flags. The fix is transmitting the ZLP using PIO mode after the CPPI TX is done. Validated using the foll

Re: [PATCH] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Bin Liu
Sergei, On Tue, Aug 12, 2014 at 1:30 PM, Sergei Shtylyov wrote: > On 08/12/2014 09:13 PM, Bin Liu wrote: > CPPI TX does not transmit ZLP for TX transfers which - transfer size is multiple of EP packet size, - and URB_ZERO_PACKET is set in urb->transfer_flags. > > The fix is tr

[PATCH v2] usb: musb: cppi41: fix not transmitting zero length packet issue

2014-08-12 Thread Bin Liu
CPPI TX does not transmit ZLP for TX transfers which - transfer size is multiple of EP packet size, - and URB_ZERO_PACKET is set in urb->transfer_flags. The fix is transmitting the ZLP using PIO mode after the CPPI TX is done. Validated using the following usbtest write case in MUSB host mode.

RE: [RFC PATCH] Revert "usb: chipidea: udc: .pullup is valid only when vbus is there"

2014-08-12 Thread Peter Chen
> On Tue, 12 Aug 2014, Peter Chen wrote: > > > > > I did this for possible pullup dp without connection (eg load > > > > gadget driver before vbus connect), it breaks USB spec, see > > > > 7.1.7.3 Connect > > > and Disconnect Signaling at USB 2.0 spec. > > > > > > 7.1.7.3 doesn't say anything ab

RE: [RFC PATCH] Revert "usb: chipidea: udc: .pullup is valid only when vbus is there"

2014-08-12 Thread Peter Chen
> On Mon, Aug 11, 2014 at 02:34:33PM +0200, Michael Grzeschik wrote: > > Hi Peter, > > > > On Mon, Aug 11, 2014 at 12:56:47AM +, Peter Chen wrote: > > > > I have seen this call is still returning EOPNOTSUPP which is also > > > > returned by usb_gadget_connect and usb_gadget_disconnect if the

[PATCH] pl2303: use divisors for unsupported baud rates

2014-08-12 Thread Lauri Hintsala
This change has been tested to work with PL-2303HX at 115200, 50, 100, 200, 250, 300 and 400 baud rates. Signed-off-by: Lauri Hintsala --- CC: Johan Hovold CC: Greg Kroah-Hartman CC: linux-usb@vger.kernel.org drivers/usb/serial/pl2303.c | 10 -- 1 file changed,

Re: [PATCH v7] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-12 Thread Hannes Petermaier
> > > > Known issue: > > If gpios are in use(export to userspace through sysfs interface, etc), > > then call pl2303_release(unplug usb-serial convertor, modprobe -r, etc), > > will cause trouble, so we need to make sure there is no gpio user before > > call pl2303_release. > > This is a real p