Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Boris BREZILLON
Adding USB and Atmel Maintainers in Cc. On Thu, 7 Aug 2014 09:52:31 +0200 Boris BREZILLON wrote: > Hi Ronald, > > On Wed, 6 Aug 2014 15:11:42 +0200 > Ronald Wahl wrote: > > > Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock preparation in > > interrupt context. This is not allowed

[PATCH v4 2/4] usb: dwc2: add compatible data for rockchip soc

2014-08-07 Thread Kever Yang
This patch add compatible data for dwc2 controller found on rk3066, rk3188 and rk3288 processors from rockchip. Signed-off-by: Kever Yang Acked-by: Paul Zimmerman --- Changes in v4: - max_transfer_size change to 65536, this should be enough for most transfer, the hardware auto-detect will set

[PATCH v4 0/4] Patches to add support for Rockchip dwc2 controller

2014-08-07 Thread Kever Yang
These patches to add support for dwc2 controller found in Rockchip processors rk3066, rk3188 and rk3288, and enable dts for rk3288 evb. Changes in v4: - max_transfer_size change to 65536, this should be enough for most transfer, the hardware auto-detect will set this to 0x7 which may make

Re: [PATCH] rtl8150: Prefix macros with RTL8150 to avoid collides

2014-08-07 Thread Petko Manolov
ACK On 14-08-07 08:04:21, Nick Krause wrote: > Avoid collides in global namespaces by prefixing macros with RTL8150 as > suggested by David Miller. Collides as follows: > > drivers/net/usb/rtl8150.c:30:0: warning: "RSR" redefined > arch/xtensa/include/asm/processor.h:189:0: note: this is the loc

Re: [PATCHv2 01/13] usb: dwc2: Update Kconfig to support dual-role

2014-08-07 Thread Dinh Nguyen
On 8/1/14, 4:41 PM, Dinh Nguyen wrote: > On Fri, 2014-08-01 at 20:42 +, Paul Zimmerman wrote: >>> From: linux-usb-ow...@vger.kernel.org >>> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of dingu...@altera.com >>> Sent: Wednesday, July 30, 2014 8:21 AM >>> >>> Update DWC2 kconfig and mak

Re: [PATCH V2] usb: xhci_suspend is not stopping the root hub timer for the shared HCD

2014-08-07 Thread Mathias Nyman
On 08/06/2014 09:05 PM, Al Cooper wrote: > V2 - Restart polling (which will restart the timer) for the shared > HCD in xhci_resume(). > > xhci_suspend() will stop the primary HCD's root hub timer, but leaves > the shared HCD's timer running. This change adds stopping of the > shared HCD timer. >

Re: [PATCH v2 0/7] xhci: various fixes and cleanups

2014-08-07 Thread Mathias Nyman
On 08/04/2014 07:00 PM, Hans de Goede wrote: > Hi All, > > Here is a resend of my pending xhci fixes / cleanups. > > Note the first one is a bug-fix which really should go into > 3.17-rc2 (too late for rc1 I assume) the rest can wait I think. > > Changes in v2: > -rebased on top of usb-next > -m

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Ronald Wahl
On 07.08.2014 09:59, Boris BREZILLON wrote: On Thu, 7 Aug 2014 09:52:31 +0200 Boris BREZILLON wrote: On Wed, 6 Aug 2014 15:11:42 +0200 Ronald Wahl wrote: Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock preparation in interrupt context. This is not allowed as it might sleep. Move

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Boris BREZILLON
On Thu, 07 Aug 2014 14:43:32 +0200 Ronald Wahl wrote: > On 07.08.2014 09:59, Boris BREZILLON wrote: > > On Thu, 7 Aug 2014 09:52:31 +0200 > > Boris BREZILLON wrote: > >> On Wed, 6 Aug 2014 15:11:42 +0200 > >> Ronald Wahl wrote: > >> > >>> Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added c

[PATCH 2/4] USB: zte_ev: remove duplicate Gobi PID

2014-08-07 Thread Johan Hovold
Remove dublicate Gobi PID 0x9008 which is already handled by the qcserial driver since commit f05932c0caf4 ("USB: qcserial: Add extra device IDs"). Fixes: 799ee9243d89 ("USB: serial: add zte_ev.c driver") Cc: Signed-off-by: Johan Hovold --- drivers/usb/serial/zte_ev.c | 1 - 1 file changed, 1 d

[PATCH 3/4] USB: zte_ev: remove duplicate Qualcom PID

2014-08-07 Thread Johan Hovold
Remove dublicate Qualcom PID 0x3197 which is already handled by the moto-modem driver since commit 6986a978eec7 ("USB: add new moto_modem driver for some Morotola phones"). Fixes: 799ee9243d89 ("USB: serial: add zte_ev.c driver") Cc: Signed-off-by: Johan Hovold --- drivers/usb/serial/zte_ev.c |

[PATCH 1/4] Revert "USB: option,zte_ev: move most ZTE CDMA devices to zte_ev"

2014-08-07 Thread Johan Hovold
This reverts commit 73228a0538a70ebc4547bd09dee8971360dc1d87 ("USB: option,zte_ev: move most ZTE CDMA devices to zte_ev"). Move the IDs of the devices that were previously driven by the option driver back to that driver. As several users have reported, the zte_ev driver is causing random disconne

[PATCH 0/4] USB: serial: remove zte_ev driver

2014-08-07 Thread Johan Hovold
These patches move the ZTE PIDs that were originally handled by the option driver back to that driver, remove two PIDs from zte_ev that were already claimed by other drivers, and finally removes the zte_ev driver completely (and moves the sole remaining PID over to option). The zte_ev driver is ba

[PATCH 4/4] Revert "USB: serial: add zte_ev.c driver"

2014-08-07 Thread Johan Hovold
This reverts commit 799ee9243d892ad959c8e5f4549593ece59f1c80 ("USB: serial: add zte_ev.c driver"). The zte_ev driver is based on code (once) distributed by ZTE that still appears to originally have been reverse-engineered and bolted onto the generic driver. A closer analysis of the zte_ev setup c

Re: [PATCH v3 2/6] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-08-07 Thread Peter Griffin
Hi Arnd, Thanks for reviewing, see my comments below: - > > +static int st_ehci_platform_reset(struct usb_hcd *hcd) > > +{ > > + struct platform_device *pdev = to_platform_device(hcd->self.controller); > > + struct usb_ehci_pdata *pdata = dev_get_platdata(&pdev->dev); > > + struct ehci_hcd

Re: [PATCH v3 1/6] usb: host: usb-st-common: Add common code required by ohci-st and ehci-st

2014-08-07 Thread Peter Griffin
Hi Arnd, Thanks for reviewing, see my comments below: - > > + if (priv->rst) { > > + ret = > > (priv->rst); > > + if (ret) > > + goto err_assert_power; > > + } > > I wouldn't make these optional, just call the functions > unconditionally and fail the pr

Re: [PATCH v3 1/6] usb: host: usb-st-common: Add common code required by ohci-st and ehci-st

2014-08-07 Thread Peter Griffin
Hi Arnd, > > > (priv->rst); > > > + if (ret) > > > + goto err_assert_power; > > > + } > > > > I wouldn't make these optional, just call the functions > > unconditionally and fail the probe function if they are > > not available. Also I've also done as you suggest and made

Re: [PATCH v3 0/6] Add EHCI and OHCI drivers for STi SoC's

2014-08-07 Thread Peter Griffin
Hi Arnd, Thanks for reviewing, see my comments below: - > > Changes since v2: > > - Based on Arnd Berghman feedback, split out into 2 devices / drivers > > - Base drivers oh ehci-platform.c & ohci-platform.c with required > > extensions > >to allow possible re-merge in the furture. > > Hi

Re: 3.15.6 USB issue with pwc cam

2014-08-07 Thread Udo van den Heuvel
On 2014-08-04 11:17, Laurent Pinchart wrote: > (CC'ing Hans de Goede, the pwc maintainer, and the linux-media mailing list) > > On Saturday 02 August 2014 15:10:01 Udo van den Heuvel wrote: >> Hello, >> >> I moved a PWC webcam to a USB3 port, and this happened: I get similar stuff when trying to

[PATCH v4 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

2014-08-07 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip EHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Griffin ---

[PATCH v4 0/5] Add EHCI and OHCI drivers for STi SoC's

2014-08-07 Thread Peter Griffin
The series has been re-worked from v2 onwards to split out the ehci and ohci parts into their own drivers / devices like most other ARM platforms based on feedback from Arnd Bergmann (see here http://www.spinics.net/lists/linux-usb/msg24.html. The ehci-platform & ohci-platform have been use

[PATCH v4 4/5] usb: host: ohci-st: Add ohci-st devicetree bindings documentation

2014-08-07 Thread Peter Griffin
This patch documents the device tree bindings required for the ohci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ohci-st.txt | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 Doc

[PATCH v4 5/5] MAINTAINERS: Add ehci-st.c and ohci-st.c to ARCH/STI architecture

2014-08-07 Thread Peter Griffin
Signed-off-by: Peter Griffin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c2066f4..89aef87 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1356,6 +1356,8 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F: driv

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Ronald Wahl
Hi, actually this should have been patch v3 and not v2. Anyway, the major difference is that I moved setting the clock rate into process context as well as it may also sleep. - ron On 07.08.2014 17:11, Ronald Wahl wrote: Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock preparatio

[PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Ronald Wahl
Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock preparation in interrupt context. This is not allowed as it might sleep. Move clock preparation and setting clock rate into process context (at91udc_probe). Signed-off-by: Ronald Wahl --- drivers/usb/gadget/udc/at91_udc.c | 44 +

[PATCH v4 2/5] usb: host: ohci-st: Add OHCI driver support for ST STB devices

2014-08-07 Thread Peter Griffin
This patch adds the glue code required to ensure the on-chip OHCI controller works on STi consumer electronics SoC's from STMicroelectronics. It mainly manages the setting and enabling of the relevant clocks and manages the reset / power signals to the IP block. Signed-off-by: Peter Griffin ---

[PATCH v4 3/5] usb: host: ehci-st: Add ehci-st devicetree bindings documentation

2014-08-07 Thread Peter Griffin
This patch documents the device tree bindings required for the ehci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ehci-st.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 Doc

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-07 Thread Alan Stern
On Wed, 6 Aug 2014, Christoph Hellwig wrote: > On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: > > > I doubt either of them forces users to hack up flags for these cases. > > > > Why was this change needed in the first place? There's no explanation > > in the patch itself. > > Whic

Re: [PATCH] staging: usbip: vhci_sysfs.c: Fix a style issue

2014-08-07 Thread Sergei Shtylyov
Hello. On 08/07/2014 10:22 AM, Lars R. Damerow wrote: Replace a single-value sscanf() call with a call to kstrtou32(), as recommended by checkpatch.pl. Signed-off-by: Lars R. Damerow --- drivers/staging/usbip/vhci_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Sergei Shtylyov
Hello. On 08/07/2014 07:11 PM, Ronald Wahl wrote: Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock preparation in Please also specify that commit's summary in parens. interrupt context. This is not allowed as it might sleep. Move clock preparation and setting clock rate into p

Re: [PATCH] staging: usbip: vhci_sysfs.c: Fix a style issue

2014-08-07 Thread Lars R. Damerow
Oops--you're right, I didn't check. I'll correct the patch and resubmit. Sorry about that, -lars -- Lars R. Damerow l...@grandstreet.us On Thu, Aug 7, 2014, at 09:08 AM, Sergei Shtylyov wrote: > Hello. > > On 08/07/2014 10:22 AM, Lars R. Damerow wrote: > > > Replace a single-value sscanf(

[PATCH resend] staging: usbip: vhci_sysfs.c: Fix a style issue

2014-08-07 Thread Lars R. Damerow
Replace a single-value sscanf() call with a call to kstrtou32(), as recommended by checkpatch.pl. Signed-off-by: Lars R. Damerow --- drivers/staging/usbip/vhci_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/vhci_sysfs.c b/drivers/staging/usbip/

RE: [PATCH v4 2/4] usb: dwc2: add compatible data for rockchip soc

2014-08-07 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang > Sent: Thursday, August 07, 2014 2:35 AM > > This patch add compatible data for dwc2 controller found on > rk3066, rk3188 and rk3288 processors from rockchip. > > Signed-off-by: Kever Yang > Acked-by: Paul Zimmerman > ---

Re: [PATCH resend] staging: usbip: vhci_sysfs.c: Fix a style issue

2014-08-07 Thread Sergei Shtylyov
On 08/07/2014 09:38 PM, Lars R. Damerow wrote: Concerning the subject: it's not resend, it's version 2. Replace a single-value sscanf() call with a call to kstrtou32(), as recommended by checkpatch.pl. Signed-off-by: Lars R. Damerow --- You're supposed to describe the differences be

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-07 Thread Wang YanQing
On Tue, Aug 05, 2014 at 03:54:08PM +0200, Johan Hovold wrote: > > > I noticed that setting direction to output and setting the gpio high has > > > no effect on the read-back value (i.e. I still read back 0) for my > > > pl2303hx (note that my device has no easily accessible gpios so I > > > haven't

Re: [PATCH 0/3] usbip: move usbip out of staging

2014-08-07 Thread Valentina Manea
On Wed, Aug 6, 2014 at 10:33 PM, Greg KH wrote: > On Thu, Aug 07, 2014 at 08:10:25AM +0300, Valentina Manea wrote: >> This is a resend of the patch series from March. >> >> After migrating userspace code to libudev, converting usbip-host >> to a device driver and various bug fixes and enhancements

[PATCH] usb: dwc2: Read GNPTXFSIZ when in forced HOST mode.

2014-08-07 Thread Doug Anderson
The documentation for GNPTXFSIZ says that "For host mode, this field is always valid." Since we're already switching to host mode for HPTXFSIZ, let's also read GNPTXFSIZ in host mode. On an rk3288 SoC, without this change we see this at bootup: dwc2 ff58.usb: gnptxfsiz=00100400 dwc2 ff580

Re: [PATCH 0/3] usbip: move usbip out of staging

2014-08-07 Thread Shuah Khan
On Thu, Aug 7, 2014 at 1:36 PM, Valentina Manea wrote: > On Wed, Aug 6, 2014 at 10:33 PM, Greg KH wrote: >> On Thu, Aug 07, 2014 at 08:10:25AM +0300, Valentina Manea wrote: >>> This is a resend of the patch series from March. >>> >>> After migrating userspace code to libudev, converting usbip-hos

Re: [PATCH 0/3] usbip: move usbip out of staging

2014-08-07 Thread Greg KH
On Thu, Aug 07, 2014 at 12:36:06PM -0700, Valentina Manea wrote: > On Wed, Aug 6, 2014 at 10:33 PM, Greg KH wrote: > > On Thu, Aug 07, 2014 at 08:10:25AM +0300, Valentina Manea wrote: > >> This is a resend of the patch series from March. > >> > >> After migrating userspace code to libudev, convert

RE: [PATCH] usb: dwc2: Read GNPTXFSIZ when in forced HOST mode.

2014-08-07 Thread Paul Zimmerman
> From: Doug Anderson [mailto:diand...@chromium.org] > Sent: Thursday, August 07, 2014 12:48 PM > > The documentation for GNPTXFSIZ says that "For host mode, this field > is always valid." Since we're already switching to host mode for > HPTXFSIZ, let's also read GNPTXFSIZ in host mode. > > On a

[PATCH] uwb: init beacon cache entry before registering uwb device

2014-08-07 Thread Thomas Pugliese
Make sure the uwb_dev->bce entry is set before calling uwb_dev_add in uwbd_dev_onair so that usermode will only see the device after it is properly initialized. This fixes a kernel panic that can occur if usermode tries to access the IEs sysfs attribute of a UWB device before the driver has ha

Re: [PATCH v4 2/4] usb: dwc2: add compatible data for rockchip soc

2014-08-07 Thread Doug Anderson
Paul, On Thu, Aug 7, 2014 at 11:26 AM, Paul Zimmerman wrote: >> From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang >> Sent: Thursday, August 07, 2014 2:35 AM >> >> This patch add compatible data for dwc2 controller found on >> rk3066, rk3188 and rk3288 processors from rockchip

RE: [PATCHv2 01/13] usb: dwc2: Update Kconfig to support dual-role

2014-08-07 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] > Sent: Thursday, August 07, 2014 5:12 AM > > On 8/1/14, 4:41 PM, Dinh Nguyen wrote: > > On Fri, 2014-08-01 at 20:42 +, Paul Zimmerman wrote: > >>> From: linux-usb-ow...@vger.kernel.org > >>> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf

[PATCH 0/4] fix error return code

2014-08-07 Thread Julia Lawall
The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // // identify a function that returns a negative return value at least once. @ok exists@ identifier f,ret,i; expression e; constant c; @@ f(...) { ... when any ( return -c@i; | ret = -c@i; ... when !

Re: [PATCHv2 01/13] usb: dwc2: Update Kconfig to support dual-role

2014-08-07 Thread Dinh Nguyen
On Thu, Aug 7, 2014 at 3:55 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] >> Sent: Thursday, August 07, 2014 5:12 AM >> >> On 8/1/14, 4:41 PM, Dinh Nguyen wrote: >> > On Fri, 2014-08-01 at 20:42 +, Paul Zimmerman wrote: >> >>> From: linux-usb-ow...@vger.kernel.or

[PATCH 4/4] usb: gadget: fix error return code

2014-08-07 Thread Julia Lawall
From: Julia Lawall Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\

RE: [PATCH v4 2/4] usb: dwc2: add compatible data for rockchip soc

2014-08-07 Thread Paul Zimmerman
> From: diand...@google.com [mailto:diand...@google.com] On Behalf Of Doug > Anderson > Sent: Thursday, August 07, 2014 1:53 PM > > On Thu, Aug 7, 2014 at 11:26 AM, Paul Zimmerman > wrote: > >> From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang > >> Sent: Thursday, August 07,

RE: [PATCHv2 01/13] usb: dwc2: Update Kconfig to support dual-role

2014-08-07 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] > Sent: Thursday, August 07, 2014 2:01 PM > > On Thu, Aug 7, 2014 at 3:55 PM, Paul Zimmerman > wrote: > >> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] > >> Sent: Thursday, August 07, 2014 5:12 AM > >> > >> On 8/1/14, 4:41 PM, Dinh Nguyen wrote

Re: [PATCH 0/4] USB: serial: remove zte_ev driver

2014-08-07 Thread Greg Kroah-Hartman
On Thu, Aug 07, 2014 at 04:00:12PM +0200, Johan Hovold wrote: > These patches move the ZTE PIDs that were originally handled by the > option driver back to that driver, remove two PIDs from zte_ev that were > already claimed by other drivers, and finally removes the zte_ev driver > completely (and

Re: [PATCHv2 01/13] usb: dwc2: Update Kconfig to support dual-role

2014-08-07 Thread Dinh Nguyen
On Thu, Aug 7, 2014 at 4:04 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] >> Sent: Thursday, August 07, 2014 2:01 PM >> >> On Thu, Aug 7, 2014 at 3:55 PM, Paul Zimmerman >> wrote: >> >> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] >> >> Sent: Thursday, August 07,

Re: [PATCH 4/4] usb: gadget: fix error return code

2014-08-07 Thread Jeff Moyer
Julia Lawall writes: > diff --git a/drivers/usb/gadget/udc/fusb300_udc.c > b/drivers/usb/gadget/udc/fusb300_udc.c > index d40255f..5c5d1ad 100644 > --- a/drivers/usb/gadget/udc/fusb300_udc.c > +++ b/drivers/usb/gadget/udc/fusb300_udc.c > @@ -1398,13 +1398,17 @@ static int fusb300_probe(struct pl

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Alexandre Belloni
Hi, For the next revision, please include the changelog after the --- marker and before the diffstat. Else, this looks good to me, with the same comment as Boris on the PLLB gating. We will take care of that later. Regards On 07/08/2014 at 17:23:58 +0200, Ronald Wahl wrote : > Hi, > > actually

Re: [PATCH] usb: dwc2: Read GNPTXFSIZ when in forced HOST mode.

2014-08-07 Thread Doug Anderson
Paul, On Thu, Aug 7, 2014 at 1:18 PM, Paul Zimmerman wrote: >> From: Doug Anderson [mailto:diand...@chromium.org] >> Sent: Thursday, August 07, 2014 12:48 PM >> >> The documentation for GNPTXFSIZ says that "For host mode, this field >> is always valid." Since we're already switching to host mode

Re: [PATCH v4 2/4] usb: dwc2: add compatible data for rockchip soc

2014-08-07 Thread Kever Yang
Paul, On 08/08/2014 02:26 AM, Paul Zimmerman wrote: From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang Sent: Thursday, August 07, 2014 2:35 AM This patch add compatible data for dwc2 controller found on rk3066, rk3188 and rk3288 processors from rockchip. Signed-off-by: Keve

RE: [PATCH] usb: dwc2: Read GNPTXFSIZ when in forced HOST mode.

2014-08-07 Thread Paul Zimmerman
> From: diand...@google.com [mailto:diand...@google.com] On Behalf Of Doug > Anderson > Sent: Thursday, August 07, 2014 5:12 PM > > On Thu, Aug 7, 2014 at 1:18 PM, Paul Zimmerman > wrote: > >> From: Doug Anderson [mailto:diand...@chromium.org] > >> Sent: Thursday, August 07, 2014 12:48 PM > >> >

Re: [PATCH] usb: dwc2: Read GNPTXFSIZ when in forced HOST mode.

2014-08-07 Thread Kever Yang
Doug: On 08/08/2014 03:48 AM, Doug Anderson wrote: The documentation for GNPTXFSIZ says that "For host mode, this field is always valid." Since we're already switching to host mode for HPTXFSIZ, let's also read GNPTXFSIZ in host mode. On an rk3288 SoC, without this change we see this at bootup

driver option create ttyUSB

2014-08-07 Thread w
https://bugzilla.kernel.org/show_bug.cgi?id=81801          Bug ID: 81801    Summary: driver option create ttyUSB N�r��yb�X��ǧv�^�)޺{.n�+{��^n�r���z���h�&���G���h�(�階�ݢj"���m��z�ޖ���f���h���~�m�

Re: [PATCH v4 2/4] usb: dwc2: add compatible data for rockchip soc

2014-08-07 Thread Kever.Yang
On 08/08/2014 04:52 AM, Doug Anderson wrote: Paul, On Thu, Aug 7, 2014 at 11:26 AM, Paul Zimmerman wrote: From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang Sent: Thursday, August 07, 2014 2:35 AM This patch add compatible data for dwc2 controller found on rk3066, rk3188

Re: driver option create ttyUSB

2014-08-07 Thread Greg KH
On Fri, Aug 08, 2014 at 09:24:22AM +0800, w wrote: > > > https://bugzilla.kernel.org/show_bug.cgi?id=81801 >          > Bug ID: 81801 >    > Summary: driver option create ttyUSB I don't understand the problem, the kernel is working properly here, right? What userspace program is keeping your de

Re:Re: driver option create ttyUSB

2014-08-07 Thread w
If use symlinks it can work well. But why program in userspace can prevent driver release the node? The program just open the node, nothing else. At 2014-08-08 10:08:59, "Greg KH" wrote: >On Fri, Aug 08, 2014 at 09:24:22AM +0800, w wrote: >> >> >> https://bugzilla.kernel.org/show_bug.cgi?id=

Re: Re: driver option create ttyUSB

2014-08-07 Thread Greg KH
On Fri, Aug 08, 2014 at 10:56:57AM +0800, w wrote: > > If use symlinks it can work well. > > But why program in userspace can prevent driver release the node? > The program just open the node, nothing else. If it holds the node open, of course the kernel can't release it, the resource is still i

[PATCH v5 2/4] usb: dwc2: add compatible data for rockchip soc

2014-08-07 Thread Kever Yang
This patch add compatible data for dwc2 controller found on rk3066, rk3188 and rk3288 processors from rockchip. Signed-off-by: Kever Yang Acked-by: Paul Zimmerman --- Changes in v5: - max_transfer_size change to 65535 to met the requirement of header file Changes in v4: - max_transfer_size c

[PATCH v5 0/4] Patches to add support for Rockchip dwc2 controller

2014-08-07 Thread Kever Yang
These patches to add support for dwc2 controller found in Rockchip processors rk3066, rk3188 and rk3288, and enable dts for rk3288 evb. Changes in v5: - max_transfer_size change to 65535 to met the requirement of header file - change the sort order of dwc2 in rk3288.dtsi - don't enable otg port

Re: [PATCH resend] Revert "usb: gadget: u_ether: synchronize with transmit when stopping queue"

2014-08-07 Thread Li RongQing
Thanks. where can I find this patch status? like netdev from http://patchwork.ozlabs.org/project/netdev/list/ -Roy On Tue, Aug 5, 2014 at 8:57 AM, Greg KH wrote: > On Tue, Aug 05, 2014 at 08:47:33AM +0800, Li RongQing wrote: >> On Fri, Jul 25, 2014 at 2:22 PM, wrote: >> > From: Li RongQing >>

Re:Re: Re: driver option create ttyUSB

2014-08-07 Thread w
I got a patch from git log,this patch is about the cdc-acm. But what should i do to solve my problem? Patch as below: From 051522bb47797f7168a617a0752d7ddc1a2f6f24 Mon Sep 17 00:00:00 2001 From: Francesco Lavra Date: Tue, 3 Nov 2009 10:53:07 + Subject: [PATCH] USB: cdc_acm: Fix memory leak

Re: [PATCH resend] Revert "usb: gadget: u_ether: synchronize with transmit when stopping queue"

2014-08-07 Thread Greg KH
On Fri, Aug 08, 2014 at 12:15:14PM +0800, Li RongQing wrote: > Thanks. where can I find this patch status? like netdev from > http://patchwork.ozlabs.org/project/netdev/list/ I don't think any of the usb developers use patchwork, sorry. Just relax and wait, Felipe will handle it eventually. greg

Re: Re: Re: driver option create ttyUSB

2014-08-07 Thread Greg KH
On Fri, Aug 08, 2014 at 01:42:53PM +0800, w wrote: > > I got a patch from git log,this patch is about the cdc-acm. >From 2009? > But what should i do to solve my problem? I don't understand, are you using a kernel older than 2009? What kernel version are you using? confused, greg k-h -- To u

Re:Re: Re: Re: driver option create ttyUSB

2014-08-07 Thread w
My kernel version is 3.0. I just want to get some useful information from this patch. Because the patch seems solved the same problem as mine. At 2014-08-08 01:56:52, "Greg KH" wrote: >On Fri, Aug 08, 2014 at 01:42:53PM +0800, w wrote: >> >> I got a patch from git log,this patch is about the