[PATCH V2] USB: Fix persist resume of some SS USB devices

Problem Summary: Problem has been observed generally with PM states where VBUS goes off during suspend. There are some SS USB devices which take longer time for link training compared to many others. Such devices fail to reconnect with same old address which was associated with it before suspend.

Re: [RFC PATCH] usb: dwc3: core: allow vendor drivers to check probe status

On Thu, 17 Jul 2014, Felipe Balbi wrote: > Hi, > > On Thu, Jul 17, 2014 at 06:13:33PM +0100, Lee Jones wrote: > > This patch provides mechanism for subordinate devices to check > > whether the DWC3 core probed successfully or otherwise. Useful > > if PHYs are required to configure controllers, b

[PATCH] usb: gadget: serial: replace {V,}DBG macro with dev_{v,}dbg

Replace the VDBG and DBG macro with the kernels "proper" debug macros (dev_vdbg and dev_dbg) in f_acm.c, f_obex.c & f_serial.c Signed-off-by: Richard Leitner --- drivers/usb/gadget/f_acm.c| 41 - drivers/usb/gadget/f_obex.c | 22 ++---

Re: [PATCH] usbcore: don't log on consecutive debounce failures of the same port

On Thu, 2014-07-17 at 17:13 -0700, Greg KH wrote: > On Mon, Jul 14, 2014 at 10:47:55PM +0200, Oliver Neukum wrote: > > I see no sane way to come up with numbers. > > Unless you want to measure the time between spurious event. > > But that would really be overkill. I'd rather fix a concrete > > iss

[PATCH 3/9] usb: musb_am335x: source cleanup

- remove comma after end of list delimiter The empty entry must always be the last item in the list, thus there is no point in having a trailing comma to facilitate adding succeding entries. Remove the comma, so that inadvertedly adding an entry after the end of list sentinel will produce

[PATCH 6/9] usb: musb: core: properly setup the HW before registering it to the USB core

Without this patch overriding the USBOTG_ID pin by setting the iddig bit in the USB_MODE register doesn't work because it happens too late to be recognized correctly. Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_core.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(

[PATCH 7/9] usb: phy: am335x: setup the gen_phy function pointers _before_ adding the phy

Make sure all parameters are correctly set up before registering the PHY with the USB framework. Signed-off-by: Lothar Waßmann --- drivers/usb/phy/phy-am335x.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c

[PATCH 9/9] usb: musb: musb_am335x: reinstate module loading/unloading support

There is no need to throw the baby out with the bath due to a bad failure analysis. The commit: 7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal came to a wrong conclusion about the cause of the crash it was "fixing". The real culprit was the phy-am335x module that was removed from

[PATCH 1/9] usb: musb: core: cleanup - remove some useless 'break's from switch statements

Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_core.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index b841ee0..8623112 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c @@ -680,7 +680,

[PATCH 2/9] usb: phy: am335x: group the #includes by subdirs

Signed-off-by: Lothar Waßmann --- drivers/usb/phy/phy-am335x.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c index b70e055..91c71ab 100644 --- a/drivers/usb/phy/phy-am335x.c +++ b/drivers/usb/phy/phy-am335

[PATCH 0/9] usb: musb: several bugfixes for the musb driver

The first three patches do some source code cleanup in the files that are modified in the subsequent patches. Patch 4 carries the proper fix reported in commit: 7adb5c876e9c ("usb: musb: Fix panic upon musb_am335x module removal") Patch 6 makes the USBOTG_ID pin override via the USB_MODE

[PATCH 5/9] usb: musb: print error message with dev_err() instead of dev_dbg()

Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 8623112..f867b44 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c @@

[PATCH 4/9] usb: phy: am335x-control: prevent module from being unloaded when in use

This patch fixes the real cause of the crash that was "fixed" by commit 7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal Signed-off-by: Lothar Waßmann --- drivers/usb/phy/phy-am335x-control.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/phy/phy-a

[PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown()

This patch makes it possible to use the musb driver with HW that requires external regulators or clocks. Signed-off-by: Lothar Waßmann --- drivers/usb/phy/phy-am335x.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c index 6522f

[RFC] usb: gadget: serial: remove PREFIX macro

Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with the hardcoded ttyGS string. This macro was mostly used in a few debug/warning messages and a lot of hardcoded ttyGS existed beneath. It may have been used for renaming the tty, but if done so most debug messages would ha

re: usb: gadget: NCM: Add transmit multi-frame.

Hello Jim Baxter, This is a semi-automatic email about new static checker warnings. The patch 6d3865f9d41f: "usb: gadget: NCM: Add transmit multi-frame." from Jul 7, 2014, leads to the following Smatch complaint: drivers/usb/gadget/function/u_ether.c:564 eth_start_xmit() error: we prev

Re: [PATCH v2] usb: phy: msm: Make phy_reset clk and reset line optional.

tested-by: Prakash Burla This driver tested on IFC6410 with USB Driver. On Fri, Jul 18, 2014 at 1:46 AM, Srinivas Kandagatla wrote: > This patch makes the phy reset clk and reset line optional as this clk > is not available on boards like IFC6410 with APQ8064. > > phy-reset clk is only used as a

Re: [PATCH v2 10/12] usb: dwc2/gadget: assign TX FIFO dynamically

On 07/16/2014 09:58 PM, Paul Zimmerman wrote: >> From: Robert Baldyga [mailto:r.bald...@samsung.com] >> Sent: Wednesday, July 16, 2014 3:22 AM >> >> Because we have not enough memory to have each TX FIFO of size at least 3072 >> bytes (the maximum single packet size), we create four FIFOs of lenght

[PATCH v3 11/12] usb: dwc2/gadget: disable clock when it's not needed

When device is stopped or suspended clock is not needed so we can disable it for this time. Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index e74094a..11f038e 100644

[PATCH v3 12/12] usb: dwc2/gadget: avoid disabling ep0

Endpoint 0 should not be disabled, so we start loop counter from number 1. Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 11f038e..cc31088 100644 --- a/dri

[PATCH v3 09/12] usb: dwc2/gadget: delay enabling irq once hardware is configured properly

From: Marek Szyprowski This patch fixes kernel panic/interrupt storm/etc issues if bootloader left s3c-hsotg module in enabled state. Now interrupt handler is enabled only after proper configuration of hardware registers. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drive

[PATCH v3 07/12] usb: dwc2/gadget: break infinite loop in endpoint disable code

From: Marek Szyprowski This patch fixes possible freeze caused by infinite loop in interrupt context. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/ga

[PATCH v3 10/12] usb: dwc2/gadget: assign TX FIFO dynamically

Because we have not enough memory to have each TX FIFO of size at least 3072 bytes (the maximum single packet size with 3 transactions per microframe), we create four FIFOs of lenght 1024, and four of length 3072 bytes, and assing them to endpoints dynamically according to maxpacket size value of g

[PATCH v3 08/12] usb: dwc2/gadget: do not call disconnect method in pullup

From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --

[PATCH v3 01/12] usb: dwc2/gadget: fix phy disable sequence

From: Kamil Debski When the driver is removed s3c_hsotg_phy_disable is called three times instead of once. This results in decreasing of the phy reference counter below zero and thus consecutive inserts of the module fails. This patch removes calls to s3c_hsotg_phy_disable from s3c_hsotg_remove

[PATCH v3 00/12] usb: dwc2/gadget: fix series

Hello, This patchset contains fixes for dwc2 gadget driver. It touches PHY, FIFO configuration, initialization sequence and adds many other small fixes. Best regards Robert Baldyga Samsung R&D Institute Poland Changelog: v3: - use endpoint index instead of FIFO index for EPFIFO - extend patch

[PATCH v3 02/12] usb: dwc2/gadget: fix phy initialization sequence

From: Kamil Debski In the Generic PHY Framework a NULL phy is considered to be a valid phy thus the "if (hsotg->phy)" check does not give us the information whether the Generic PHY Framework is used. In addition to the above this patch also removes phy_init from probe and phy_exit from remove. T

[PATCH v3 06/12] usb: dwc2/gadget: ensure that all fifos have correct memory buffers

From: Marek Szyprowski Print warning if FIFOs are configured in such a way that they don't fit into the SPRAM available on the s3c hsotg module. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/gadget.c | 15 ++-

[PATCH v3 05/12] usb: dwc2/gadget: hide some not really needed debug messages

From: Marek Szyprowski Some DWC2/s3c-hsotg debug messages are really useless for typical user, so hide them behind dev_dbg(). Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH v3 04/12] usb: dwc2/gadget: Fix comment text

From: Andrzej Pietrasiewicz Adjust the debug text to the name of the printed variable. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/d

[PATCH v3 03/12] usb: dwc2/gadget: move phy bus legth initialization

From: Kamil Debski This patch moves the part of code that initializes the PHY bus width. This results in simpler code and removes the need to check whether the Generic PHY Framework is used. Signed-off-by: Kamil Debski Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers

[PATCH] usb: gadget: f_fs: virtual address mapping

This patch adds virtual endpoint address mapping to functionfs. So far endpoint addresses given by user through endpoint descriptors were ignored, and replaced by physical endpoint addresses. Endpoint address in wIndex field of setup requesti, addressed to endpoint, was the physical endpoint addre

Re: [PATCH] usb: core: allow zero packet flag for interrupt urbs

On 7/17/2014 8:25 PM, Alan Stern wrote: I can't say this is actually wrong, but have you ever encountered a situation where this would be needed? How often does anyone need to do a multi-packet transfer over an interrupt endpoint? Honestly, I haven't found any such real device yet. I did this

Re: [PATCH 1/9] usb: musb: core: cleanup - remove some useless 'break's from switch statements

HI, On Fri, Jul 18, 2014 at 11:31:22AM +0200, Lothar Waßmann wrote: > no commit log == no commit, also the worst thing you can do is have your bug fixes depend on cleanups. This is *not* a bug fix by any stretch of the imagination. > Signed-off-by: Lothar Waßmann > --- > drivers/usb/musb/musb

Re: [PATCH 2/9] usb: phy: am335x: group the #includes by subdirs

On Fri, Jul 18, 2014 at 11:31:23AM +0200, Lothar Waßmann wrote: > no commit log. Not a bug fix. > Signed-off-by: Lothar Waßmann > --- > drivers/usb/phy/phy-am335x.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy

Re: [PATCH 3/9] usb: musb_am335x: source cleanup

On Fri, Jul 18, 2014 at 11:31:24AM +0200, Lothar Waßmann wrote: > - remove comma after end of list delimiter > The empty entry must always be the last item in the list, thus there > is no point in having a trailing comma to facilitate adding > succeding entries. > Remove the comma, so that

Re: [PATCH 4/9] usb: phy: am335x-control: prevent module from being unloaded when in use

On Fri, Jul 18, 2014 at 11:31:25AM +0200, Lothar Waßmann wrote: > This patch fixes the real cause of the crash that was "fixed" by > commit 7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal > > Signed-off-by: Lothar Waßmann what is the "real cause of the crash" ? You don't explai

Re: [PATCH 5/9] usb: musb: print error message with dev_err() instead of dev_dbg()

On Fri, Jul 18, 2014 at 11:31:26AM +0200, Lothar Waßmann wrote: > no commit log. Not a bug fix. > Signed-off-by: Lothar Waßmann > --- > drivers/usb/musb/musb_core.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb

Re: [PATCH 6/9] usb: musb: core: properly setup the HW before registering it to the USB core

On Fri, Jul 18, 2014 at 11:31:27AM +0200, Lothar Waßmann wrote: > Without this patch overriding the USBOTG_ID pin by setting the iddig > bit in the USB_MODE register doesn't work because it happens too late > to be recognized correctly. and how did you test this ? Why is it too late ? What was you

Re: [PATCH 7/9] usb: phy: am335x: setup the gen_phy function pointers _before_ adding the phy

On Fri, Jul 18, 2014 at 11:31:28AM +0200, Lothar Waßmann wrote: > Make sure all parameters are correctly set up before registering the > PHY with the USB framework. > > Signed-off-by: Lothar Waßmann > --- > drivers/usb/phy/phy-am335x.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions

Re: [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown()

Hi, On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Waßmann wrote: > This patch makes it possible to use the musb driver with HW that > requires external regulators or clocks. can you provide an example of such HW ? Are you not using the internal PHYs ? > Signed-off-by: Lothar Waßmann > --- >

Re: xhci error: Transfer event TRB DMA ptr not part of current TD

Hi, On 07/10/2014 01:17 PM, Hans de Goede wrote: > Hi Sarah, Matthias, et al, > > I've been running a full Linux distro from an uas enclosure with a ssd > for testing purposes (mostly for testing the distro on different > hardware but also for uas testing). > > While testing this on a Thinkpad T

Re: xhci throws EPROTO errors under load with CONFIG_DMA_API_DEBUG=Y

Hi, On 07/17/2014 06:08 PM, Hans de Goede wrote: > Hi all, > > It has cost me quite some time to get to the bottom of this (which is > not even the real bottom). > > When I generate heavy-io (make -j4 modules or cp -pr a git clone > of the kernel), urbs start completing with EPROTO errors when u

[BUG] Lockdep splat in usb network gadget

On a Intel E660/EG20T system I can observe the following lockdep splats: [ 10.154920] = [ 10.156026] [ INFO: inconsistent lock state ] [ 10.156026] 3.16.0-rc5+ #13 Not tainted [ 10.156026] - [ 10.156026] inconsistent {IN-HAR

Re: [PATCH 9/9] usb: musb: musb_am335x: reinstate module loading/unloading support

On Fri, Jul 18, 2014 at 11:31:30AM +0200, Lothar Waßmann wrote: > There is no need to throw the baby out with the bath due to a bad > failure analysis. The commit: > 7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal > came to a wrong conclusion about the cause of the crash it was >

[PATCH 0/3] xhci: Treat not finding the event_seg on COMP_STOP the same as COMP_STOP_INVAL

Hi All, Here is a small patch-set fixing the following error: xhci error: Transfer event TRB DMA ptr not part of current TD Being logged when using uas on a Haswell chipset xhci controller. The first 2 patches just add some debugging output which I've found to be helpful to solve this bug and I

[PATCH 1/3] xhci: Print hcc params, version and quirks on init

To help debugging xhci problems. Signed-off-by: Hans de Goede --- drivers/usb/host/xhci.c | 4 drivers/usb/host/xhci.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 7436d5f..7d02e1b 100644 --- a/drivers/usb/host/xhci.c +++ b/d

[PATCH 3/3] xhci: Treat not finding the event_seg on COMP_STOP the same as COMP_STOP_INVAL

When using a Renesas uPD720231 chipset usb-3 uas to sata bridge with a 120G Crucial M500 ssd, model string: Crucial_ CT120M500SSD1, together with a the integrated Intel xhci controller on a Haswell laptop: 00:14.0 USB controller [0c03]: Intel Corporation 8 Series USB xHCI HC [8086:9c31] (rev 04)

[PATCH 2/3] xhci: Log ep-index and comp-code on TRB DMA ptr not part of current TD

These errors should never happen, so lets add some extra info when they happen to make figuring out what is going on easier. Signed-off-by: Hans de Goede --- drivers/usb/host/xhci-ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers

RE: [PATCH 2/3] xhci: Log ep-index and comp-code on TRB DMA ptr not part of current TD

From: Hans de Goede > These errors should never happen, so lets add some extra info when they happen > to make figuring out what is going on easier. I've previously posted a patch that include the 'DMA ptr' itself. IIRC I was generating one of the error events where the pointer is the address of a

RE: [PATCH 1/3] xhci: Print hcc params, version and quirks on init

From: Hans de Goede > To help debugging xhci problems. > > Signed-off-by: Hans de Goede > --- > drivers/usb/host/xhci.c | 4 > drivers/usb/host/xhci.h | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index 7436d5f..7d02e1b 1006

Re: [PATCH 2/3] USB: OHCI: fix bugs in debug routines

On Thu, 17 Jul 2014, Greg KH wrote: > On Thu, Jul 17, 2014 at 04:32:26PM -0400, Alan Stern wrote: > > The debug routine fill_async_buffer() in ohci-hcd is buggy: It never > > produces any output because it forgets to initialize the output buffer > > size. Also, the debug routine ohci_dump() has a

Re: [PATCH 1/3] xhci: Print hcc params, version and quirks on init

Hi, On 07/18/2014 04:13 PM, David Laight wrote: > From: Hans de Goede >> To help debugging xhci problems. >> >> Signed-off-by: Hans de Goede >> --- >> drivers/usb/host/xhci.c | 4 >> drivers/usb/host/xhci.h | 2 ++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/drivers/usb/host/xhci

Re: [PATCH] usb: core: allow zero packet flag for interrupt urbs

On Thu, 17 Jul 2014, Steve Calfee wrote: > Hi Alan, > > It has been a few years since I was doing this, but here is my > understanding. If a device descriptor says x bytes should be reserved > (1 to 3072), the host will allocate that much bandwidth. If the sender > sends some number of bytes betw

Re: [PATCH] usb: core: allow zero packet flag for interrupt urbs

On Fri, 18 Jul 2014, Amit Virdi wrote: > On 7/17/2014 8:25 PM, Alan Stern wrote: > > I can't say this is actually wrong, but have you ever encountered a > > situation where this would be needed? How often does anyone need to do > > a multi-packet transfer over an interrupt endpoint? > > Honestly

Re: [RFC PATCH] usb: dwc3: core: allow vendor drivers to check probe status

Hi, On Fri, Jul 18, 2014 at 08:11:15AM +0100, Lee Jones wrote: > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > index eb69eb9..171ca52 100644 > > > --- a/drivers/usb/dwc3/core.c > > > +++ b/drivers/usb/dwc3/core.c > > > @@ -47,6 +47,14 @@ > > > > > > /* > > > -

Re: [PATCH] usb: lvstest: Fix sparse warnings generated by kbuild test bot

On Fri, 18 Jul 2014, Pratyush Anand wrote: > Following sparse warnings were reported by kbuild test bot > > drivers/usb/misc/lvstest.c:314:28: sparse: incorrect type in assignment > (different base types) >drivers/usb/misc/lvstest.c:314:28:expected unsigned short [unsigned] > [usertype]

Re: hcd.c Fix me statements

On Fri, 18 Jul 2014, Nick Krause wrote: > I am assuming this is a stupid question but since I am new I will ask it > anyway. > Can the usb_bus structure be Null? If can I will send it a patch removing > the > fix mes on lines 854 and 878 of hcd.c . Line numbers in a source file usually aren'

Re: [PATCH V2] USB: Fix persist resume of some SS USB devices

On Fri, 18 Jul 2014, Pratyush Anand wrote: > Problem Summary: Problem has been observed generally with PM states > where VBUS goes off during suspend. There are some SS USB devices which > take longer time for link training compared to many others. Such > devices fail to reconnect with same old a

Re: [PATCH net,stable] net: huawei_cdc_ncm: add "subclass 3" devices

Seems interesting That's fine. Acked-By: Enrico Mioso On Thu, 17 Jul 2014, Bjørn Mork wrote: ==Date: Thu, 17 Jul 2014 13:34:09 ==From: Bjørn Mork ==To: net...@vger.kernel.org ==Cc: linux-usb@vger.kernel.org, Bjørn Mork , ==Enrico Mioso ==Subject: [PATCH net,stable] net: huawei_cdc_ncm: ad

Re: [PATCH 0/9] usb: musb: several bugfixes for the musb driver

Hi Lothar, On 18 Jul 11:31 AM, Lothar Waßmann wrote: > The first three patches do some source code cleanup in the files that > are modified in the subsequent patches. > I've applied patches 4 and 9 on a recent -next, after fixing a conflict due to patch 3 ("usb: musb_am335x: source cleanup"): >

Re: [PATCH 0/9] usb: musb: several bugfixes for the musb driver

Hi, On Fri, Jul 18, 2014 at 01:16:36PM -0300, Ezequiel Garcia wrote: > Hi Lothar, > > On 18 Jul 11:31 AM, Lothar Waßmann wrote: > > The first three patches do some source code cleanup in the files that > > are modified in the subsequent patches. > > > > I've applied patches 4 and 9 on a recent

[PATCH 1/6] ARM: dts: vf610: add USB PHY and controller

This adds USB PHY and USB controller nodes. Vybrid SoCs have two independent USB cores which each supports DR (dual role). However, real OTG is not supported since the OTG ID pin is not available. The PHYs are located within the anadig register range, hence we need to change the length of the anad

[PATCH 5/6] usb: phy: mxs: Add VF610 USB PHY support

This adds support for the USB PHY in Vybrid VF610. We assume that the disconnection without VBUS is also needed for Vybrid. For all other flags, the presumption of innocence applies. Signed-off-by: Stefan Agner --- drivers/usb/phy/phy-mxs-usb.c | 5 + 1 file changed, 5 insertions(+) diff --

[PATCH 2/6] ARM: imx: clk-vf610: add USBPHY clocks

This commit adds PLL7 which is required for USBPHY1. It also adds the USB PHY and USB Controller clocks and the gates to enable them. Signed-off-by: Stefan Agner --- All the main PLLs are currently turned on by boot ROM or boot loader, within the kernel we only set the fixed factor. Altough, the

[PATCH 6/6] ARM: dts: vf610-colibri: add USB support

Add USB support for Colibri VF61 modules. Due to lack of pinmux options, the USB hosts over-current protection signal of the Colibri standard could not be connected to the PHY's over-current protection, hence we need to disable it. Signed-off-by: Stefan Agner --- arch/arm/boot/dts/vf610-colibri.

[PATCH 4/6] chipidea: usbmisc_imx: Add USB support for VF610 SoCs

This adds Vybrid VF610 SoC support. The IP is very similar to i.MX6, however the non-core registers are spread in two different register areas. Hence we support multiple registers which are addressed by the index of usbmisc. Signed-off-by: Stefan Agner --- I tried first to create two usbmisc node

[PATCH 0/6] vf610: Add USB support

This patchset adds USB support for Vybrid VF610 SoC. It extends the clock framework to support the USB PHY cocks, extends the device tree files and adds support for the non-core registers in the usbmisc_imx driver. This patchset needs the eSDHC length fix available in Shawn's for-next branch. The

[PATCH 3/6] ARM: dts: vf610: Add usbmisc for non-core registers

Add device tree node for usbmisc which controls the non-core USB registers. This is required to use the property to disable the over- current detection. Signed-off-by: Stefan Agner --- arch/arm/boot/dts/vf610.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ar

Re: Iso trbs for xhci arrangement

hi Paul: >> Driver prepare ep ring like below >> xhci.0: @2796e150 279cfb04 000404fc 80021415 //xx >> xhci.0: @2796e160 279d 06f8 0625 //normal >> xhci.0: @2796e170 279d06f8 0bf4 80021625 >> >> but event ring g

Re: hcd.c Fix me statements

On Fri, Jul 18, 2014 at 10:45 AM, Alan Stern wrote: > On Fri, 18 Jul 2014, Nick Krause wrote: > >> I am assuming this is a stupid question but since I am new I will ask it >> anyway. >> Can the usb_bus structure be Null? If can I will send it a patch removing >> the >> fix mes on lines 854 an

[PATCH] usb-core: Remove Fix mes in file hcd.c

I am removing two fix mes in this file as after dicussing then it seems there is no reason to check against Null for usb_device as it can never be NULL and this is check is therefore not needed. Signed-off-by: Nicholas Krause --- drivers/usb/core/hcd.c | 4 1 file changed, 4 deletions(-)

Re: Build Errors when building usb directory

On 07/18/2014 10:45 AM, Nick Krause wrote: > Hey Greg and others, > When I built the usb directory today to check a patch I am also > sending to. I seem to hitting > a few compiler errors and a lot of warnings. I am going to attach a > file of my log of this build. > Cheers Nick > Hi, What comm

RE: Iso trbs for xhci arrangement

> From: vichy [mailto:vichy@gmail.com] > Sent: Friday, July 18, 2014 10:13 AM > >>> Driver prepare ep ring like below >>> xhci.0: @2796e150 279cfb04 000404fc 80021415 //xx >>> xhci.0: @2796e160 279d 06f8 0625 //normal >>> xhci.0:

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

On Fri, 18 Jul 2014, Nicholas Krause wrote: > I am removing two fix mes in this file as after dicussing then it seems > there is no reason to check against Null for usb_device as it can never > be NULL and this is check is therefore not needed. > > Signed-off-by: Nicholas Krause > --- > driver

RE: [PATCH v3 00/12] usb: dwc2/gadget: fix series

> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Friday, July 18, 2014 4:39 AM > > This patchset contains fixes for dwc2 gadget driver. It touches PHY, > FIFO configuration, initialization sequence and adds many other small fixes. > > Best regards > Robert Baldyga > Samsung R&D Insti

Re: [PATCH 2/3] USB: OHCI: fix bugs in debug routines

On Fri, Jul 18, 2014 at 10:17:20AM -0400, Alan Stern wrote: > On Thu, 17 Jul 2014, Greg KH wrote: > > > On Thu, Jul 17, 2014 at 04:32:26PM -0400, Alan Stern wrote: > > > The debug routine fill_async_buffer() in ohci-hcd is buggy: It never > > > produces any output because it forgets to initialize

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

On Fri, Jul 18, 2014 at 3:09 PM, Alan Stern wrote: > On Fri, 18 Jul 2014, Nicholas Krause wrote: > >> I am removing two fix mes in this file as after dicussing then it seems >> there is no reason to check against Null for usb_device as it can never >> be NULL and this is check is therefore not ne

Re: Build Errors when building usb directory

On Fri, Jul 18, 2014 at 2:10 PM, Randy Dunlap wrote: > On 07/18/2014 10:45 AM, Nick Krause wrote: >> Hey Greg and others, >> When I built the usb directory today to check a patch I am also >> sending to. I seem to hitting >> a few compiler errors and a lot of warnings. I am going to attach a >> f

[PATCH 1/6] USB: OHCI: revert the ZF Micro orphan-TD quirk

This patch reverts the important parts of commit 89a0fd18a96e (USB: OHCI handles more ZFMicro quirks), namely, the parts related to handling orphan TDs for interrupt endpoints. A later patch in this series will introduce a more general mechanism that applies to all endpoint types and all controlle

[PATCH 2/6] USB: OHCI: no shortcut for unlinking URBS from a dead controller

When an URB is unlinked from a dead controller, ohci-hcd gives back the URB with no regard for cleaning up the internal data structures. This won't play nicely with the upcoming changes to the TD done list. Therefore make ohci_urb_dequeue() call finish_unlinks(), which uses td_done() to do a prope

[PATCH 3/6] USB: OHCI: redesign the TD done list

This patch changes the way ohci-hcd handles the TD done list. In addition to relying on the TD pointers stored by the controller hardware, we need to handle TDs that the hardware has forgotten about. This means the list has to exist even while the dl_done_list() routine isn't running. That funct

[PATCH 0/6] USB: OHCI: work with controllers that lose TDs

Some OHCI controllers (most notably those made by NVIDIA, but others too) sometimes lose track of completed Transfer Descriptors. When a TD completes, the controller is supposed to add it to the start of the Done Queue, to let the driver know the transfer is finished. The buggy controllers oc

[PATCH 4/6] USB: OHCI: make URB completions single-threaded

URBs for a particular endpoint should complete sequentially. That is, we shouldn't call the completion handler for one URB until the handler for the previous URB has returned. When the OHCI watchdog routine is added, there will be two paths for completing URBs: interrupt handler and watchdog rout

[PATCH 6/6] USB: OHCI: add check for stopped frame counter

This patch adds an extra check to ohci-hcd's I/O watchdog routine. If the controller stops updating the frame counter, we will assume it is dead. But there has to be an exception: Some controllers stop the frame counter when no ports are connected. Check to make sure there is at least one active

[PATCH 5/6] USB: OHCI: add I/O watchdog for orphan TDs

Some OHCI controllers have a bug: They fail to add completed TDs to the done queue. Examining this queue is the only method ohci-hcd has for telling when a transfer is complete; failure to add a TD can result in an URB that never completes and cannot be unlinked. This patch adds a watchdog routin

Re: [PATCH] usbcore: don't log on consecutive debounce failures of the same port

On Fri, Jul 18, 2014 at 08:48:19AM +0200, Oliver Neukum wrote: > On Thu, 2014-07-17 at 17:13 -0700, Greg KH wrote: > > On Mon, Jul 14, 2014 at 10:47:55PM +0200, Oliver Neukum wrote: > > > > I see no sane way to come up with numbers. > > > Unless you want to measure the time between spurious event.

Re: Build Errors when building usb directory

On 07/18/2014 12:59 PM, Nick Krause wrote: > On Fri, Jul 18, 2014 at 2:10 PM, Randy Dunlap wrote: >> On 07/18/2014 10:45 AM, Nick Krause wrote: >>> Hey Greg and others, >>> When I built the usb directory today to check a patch I am also >>> sending to. I seem to hitting >>> a few compiler errors a

Re: [PATCH 0/6] USB: OHCI: work with controllers that lose TDs

On Fri, Jul 18, 2014 at 04:25:23PM -0400, Alan Stern wrote: > Some OHCI controllers (most notably those made by NVIDIA, but others > too) sometimes lose track of completed Transfer Descriptors. When a TD > completes, the controller is supposed to add it to the start of the > Done Queue, to let

Re: Build Errors when building usb directory

On Fri, Jul 18, 2014 at 7:29 PM, Randy Dunlap wrote: > On 07/18/2014 12:59 PM, Nick Krause wrote: >> On Fri, Jul 18, 2014 at 2:10 PM, Randy Dunlap wrote: >>> On 07/18/2014 10:45 AM, Nick Krause wrote: Hey Greg and others, When I built the usb directory today to check a patch I am also >

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

On 07/18/2014 01:34 PM, Nicholas Krause wrote: > I am removing two fix mes in this file as after dicussing then it seems > there is no reason to check against Null for usb_device as it can never > be NULL and this is check is therefore not needed. > > Signed-off-by: Nicholas Krause Please expla

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

Sorry didn't run spell check. I will resend this patch with the correct information as needed. Thanks for the advice, Sasha. Cheers Nick On Fri, Jul 18, 2014 at 10:36 PM, Sasha Levin wrote: > On 07/18/2014 01:34 PM, Nicholas Krause wrote: >> I am removing two fix mes in this file as after dicuss

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

On Fri, Jul 18, 2014 at 10:45 PM, Nick Krause wrote: > Sorry didn't run spell check. I will resend this patch with the > correct information > as needed. Thanks for the advice, Sasha. > > Cheers Nick > > On Fri, Jul 18, 2014 at 10:36 PM, Sasha Levin wrote: >> On 07/18/2014 01:34 PM, Nicholas Krau

3.14.12 and USB option_instat_callback with 3G DONGLE

Since upgrading from 3.12.24 kernel to 3.14.10, and today, .12 kernel log and dmesg are flooded with constant messages option1 ttyUSB0: option_instat_callback: error -2 The device still works, it sends and receives SMS's as well, I tried setting verbose usb debug to see if it offers any more e