Re: uas regression in 3.15 with Lacie Rugged USB3 and NEC uPD720200

2014-07-16 Thread Oliver Neukum
On Tue, 2014-07-15 at 22:23 +0200, Julian Sikorski wrote: > [ 54.017997] sd 6:0:0:0: [sdb] Write cache: enabled, read cache: > enabled, doesn't support DPO or FUA > [ 54.018119] sd 6:0:0:0: uas_sense_old: urb length 26 disagrees with > IU sense data length 510, using 18 bytes of sense data > [

Re: [PATCHv2] usb: gadget: composite: Provide a list of available functions

2014-07-16 Thread Sebastian Andrzej Siewior
On 07/14/2014 12:36 PM, Andrzej Pietrasiewicz wrote: > W dniu 14.07.2014 11:50, Sebastian Andrzej Siewior pisze: >> On 07/14/2014 11:35 AM, Andrzej Pietrasiewicz wrote: >>> A userland tool for assembling gadgets with configfs needs to know what >>> it can or cannot do, that is, what usb functions a

[PATCH v4 2/4] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-07-16 Thread Vivek Gautam
The host controller by itself may sometimes need to handle PHY and/or calibrate some of the PHY settings to get full support out of the PHY controller. The PHY core provides a calibration funtionality now to do so. Therefore, facilitate getting the two possible PHYs, viz. USB 2.0 type (UTMI+) and U

[PATCH v3 00/12] ARM: berlin: USB support

2014-07-16 Thread Antoine Ténart
This series adds the support for ChipIdea USB2 (ci13xxx) controllers, the USB PHYs of the Marvell Berlin SoCs and also adds a reset controller for these SoCs. The reset controller is used by the PHY driver and shares the existing chip controller node with the clocks and one pin controller. The Ma

[PATCH v3 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs

2014-07-16 Thread Antoine Ténart
Add the reset binding documentation to the SoC binding documentation as the reset driver in Marvell Berlin SoC is part of the chip/system control registers. This patch adds the required properties to configure the reset controller. Signed-off-by: Antoine Ténart Acked-by: Philipp Zabel --- Docum

[PATCH v3 11/12] ARM: dts: berlin: add BG2CD nodes for USB support

2014-07-16 Thread Antoine Ténart
From: Sebastian Hesselbarth Adds nodes describing the Marvell Berlin BG2CD USB PHY and USB. The BG2CD SoC has 2 USB ChipIdea controllers, with usb0 host-only and usb1 dual-role capable. Signed-off-by: Sebastian Hesselbarth Signed-off-by: Antoine Ténart --- arch/arm/boot/dts/berlin2cd.dtsi | 3

[PATCH v3 12/12] ARM: dts: berlin: enable USB on the Google Chromecast

2014-07-16 Thread Antoine Ténart
From: Sebastian Hesselbarth Enable usb1 on Google Chromecast which is connected to micro-USB plug used for external power supply, too. Signed-off-by: Sebastian Hesselbarth --- arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boo

[PATCH v3 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP

2014-07-16 Thread Antoine Ténart
Enable the 2 available USB PHY and USB nodes on the Marvell Berlin BG2Q DMP. Signed-off-by: Antoine Ténart --- arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 53 ++ 1 file changed, 53 insertions(+) diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boo

[PATCH v3 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver

2014-07-16 Thread Antoine Ténart
Document the USB2 ChipIdea driver (ci13xxx) bindings. Signed-off-by: Antoine Ténart --- .../devicetree/bindings/usb/ci-hdrc-usb2.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt diff --git a/Docume

[PATCH v3 01/12] reset: add the Berlin reset controller driver

2014-07-16 Thread Antoine Ténart
Add a reset controller for Marvell Berlin SoCs which is used by the USB PHYs drivers (for now). Signed-off-by: Antoine Ténart Signed-off-by: Sebastian Hesselbarth Acked-by: Philipp Zabel --- drivers/reset/Makefile | 1 + drivers/reset/reset-berlin.c | 131 ++

[PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-07-16 Thread Antoine Ténart
Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock and DMA mask, to support USB2 ChipIdea controllers that don't need specific functions. Needed for the Marvell Berlin SoCs USB controllers. Signed-off-by: Antoine Ténart --- drivers/usb/chipidea/Makefile | 1 + drivers/usb/

[PATCH v3 09/12] ARM: dts: berlin: add BG2Q nodes for USB support

2014-07-16 Thread Antoine Ténart
Adds nodes describing the Marvell Berlin BG2Q USB PHY and USB. The BG2Q SoC has 3 USB host controller, compatible with ChipIdea. Signed-off-by: Antoine Ténart --- arch/arm/boot/dts/berlin2q.dtsi | 52 + 1 file changed, 52 insertions(+) diff --git a/arch/a

[PATCH v3 06/12] Documentation: bindings: add doc for the Berlin USB PHY

2014-07-16 Thread Antoine Ténart
Document the bindings of the Marvell Berlin USB PHY driver. Signed-off-by: Antoine Ténart --- Documentation/devicetree/bindings/phy/berlin-usb-phy.txt | 16 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/berlin-usb-phy.txt diff --git

[PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Antoine Ténart
Add the driver driving the Marvell Berlin USB PHY. This allows to initialize the PHY and to use it from the USB driver later. Signed-off-by: Antoine Ténart --- drivers/phy/Kconfig | 7 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-berlin-usb.c | 223

[PATCH v3 04/12] ARM: dts: berlin: add a required reset property in the chip controller node

2014-07-16 Thread Antoine Ténart
The chip controller node now also describes the Marvell Berlin reset controller. Add the required 'reset-cells' property. Signed-off-by: Antoine Ténart Acked-by: Philipp Zabel --- arch/arm/boot/dts/berlin2.dtsi | 1 + arch/arm/boot/dts/berlin2cd.dtsi | 1 + arch/arm/boot/dts/berlin2q.dtsi |

[PATCH v3 03/12] ARM: Berlin: select the reset controller

2014-07-16 Thread Antoine Ténart
The Marvell Berlin SoCs now has a reset controller. Add the needed configuration. Signed-off-by: Antoine Ténart --- arch/arm/mach-berlin/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig index 2631cfc5ab0d..3a4fd1e41801 1006

Re: [PATCH v3 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver

2014-07-16 Thread Arnd Bergmann
On Wednesday 16 July 2014 10:26:02 Antoine Ténart wrote: > + > +Required properties: > +- compatible: should be "chipidea,usb2" > +- reg: base address and length of the registers > +- interrupts: interrupt for the USB controller > + > +Optional properties: > +- clocks: reference to the USB clock >

Re: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-07-16 Thread Arnd Bergmann
On Wednesday 16 July 2014 10:26:01 Antoine Ténart wrote: > + > + if (priv->dma_mask) { > + ret = dma_coerce_mask_and_coherent(&pdev->dev, > priv->dma_mask); > + if (ret) > + return ret; > + } > + > As mentioned in my comment for the b

Re: uas regression in 3.15 with Lacie Rugged USB3 and NEC uPD720200

2014-07-16 Thread Hans de Goede
Hi, On 07/16/2014 08:45 AM, Oliver Neukum wrote: > On Tue, 2014-07-15 at 22:23 +0200, Julian Sikorski wrote: >> [ 54.017997] sd 6:0:0:0: [sdb] Write cache: enabled, read cache: >> enabled, doesn't support DPO or FUA >> [ 54.018119] sd 6:0:0:0: uas_sense_old: urb length 26 disagrees with >> IU

Re: [PATCH v3 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver

2014-07-16 Thread Antoine Ténart
Hi Arnd, On Wed, Jul 16, 2014 at 10:39:36AM +0200, Arnd Bergmann wrote: > On Wednesday 16 July 2014 10:26:02 Antoine Ténart wrote: > > + > > +Required properties: > > +- compatible: should be "chipidea,usb2" > > +- reg: base address and length of the registers > > +- interrupts: interrupt for the

Re: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-07-16 Thread Antoine Ténart
Hi Arnd, On Wed, Jul 16, 2014 at 10:41:10AM +0200, Arnd Bergmann wrote: > On Wednesday 16 July 2014 10:26:01 Antoine Ténart wrote: > > + > > + if (priv->dma_mask) { > > + ret = dma_coerce_mask_and_coherent(&pdev->dev, > > priv->dma_mask); > > + if (ret) > > +

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const struct of_device_id phy_berlin_sata_of_match[] = { + { + .compatible = "marvell,berlin2-usb-phy", + .data = &phy_berlin_pll_dividers[0], + }, + { + .compatible = "marvell,berlin

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Antoine Ténart
Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: > On 07/16/2014 01:55 PM, Antoine Ténart wrote: > >+static const struct of_device_id phy_berlin_sata_of_match[] = { > >+{ > >+.compatible = "marvell,berlin2-usb-phy", > >+.data = &phy_berlin_pll_di

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 02:55 PM, Antoine Ténart wrote: Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const struct of_device_id phy_berlin_sata_of_match[] = { + { + .compatible = "marvell,berlin2-usb-phy

Re: uas regression in 3.15 with Lacie Rugged USB3 and NEC uPD720200

2014-07-16 Thread Oliver Neukum
On Wed, 2014-07-16 at 10:44 +0200, Hans de Goede wrote: > Hi, > > On 07/16/2014 08:45 AM, Oliver Neukum wrote: > > On Tue, 2014-07-15 at 22:23 +0200, Julian Sikorski wrote: > >> [ 54.017997] sd 6:0:0:0: [sdb] Write cache: enabled, read cache: > >> enabled, doesn't support DPO or FUA > >> [ 54

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Antoine Ténart
On Wed, Jul 16, 2014 at 03:03:14PM +0530, Varka Bhadram wrote: > On 07/16/2014 02:55 PM, Antoine Ténart wrote: > >Hi Varka, > > > >On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: > >>On 07/16/2014 01:55 PM, Antoine Ténart wrote: > >>>+static const struct of_device_id phy_berlin_sata_

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 03:17 PM, Antoine Ténart wrote: On Wed, Jul 16, 2014 at 03:03:14PM +0530, Varka Bhadram wrote: On 07/16/2014 02:55 PM, Antoine Ténart wrote: Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const stru

Re: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-07-16 Thread Arnd Bergmann
On Wednesday 16 July 2014 11:15:33 Antoine Ténart wrote: > > On Wed, Jul 16, 2014 at 10:41:10AM +0200, Arnd Bergmann wrote: > > On Wednesday 16 July 2014 10:26:01 Antoine Ténart wrote: > > > + > > > + if (priv->dma_mask) { > > > + ret = dma_coerce_mask_and_coherent(&pdev->dev,

[PATCH v2 01/12] usb: dwc2/gadget: fix phy disable sequence

2014-07-16 Thread Robert Baldyga
From: Kamil Debski When the driver is removed s3c_hsotg_phy_disable is called three times instead of once. This results in decreasing of the phy reference counter below zero and thus consecutive inserts of the module fails. This patch removes calls to s3c_hsotg_phy_disable from s3c_hsotg_remove

[PATCH v2 11/12] usb: dwc2/gadget: disable clock when it's not needed

2014-07-16 Thread Robert Baldyga
When device is stopped or suspended clock is not needed so we can disable it for this time. Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 1b5e9ff..68b764e 100644

[PATCH v2 06/12] usb: dwc2/gadget: ensure that all fifos have correct memory buffers

2014-07-16 Thread Robert Baldyga
From: Marek Szyprowski Print warning if FIFOs are configured in such a way that they don't fit into the SPRAM available on the s3c hsotg module. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/gadget.c | 15 ++-

[PATCH v2 08/12] usb: dwc2/gadget: do not call disconnect method in pullup

2014-07-16 Thread Robert Baldyga
From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --

[PATCH v2 04/12] usb: dwc2/gadget: Fix comment text

2014-07-16 Thread Robert Baldyga
From: Andrzej Pietrasiewicz Adjust the debug text to the name of the printed variable. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/d

[PATCH v2 09/12] usb: dwc2/gadget: delay enabling irq once hardware is configured properly

2014-07-16 Thread Robert Baldyga
From: Marek Szyprowski This patch fixes kernel panic/interrupt storm/etc issues if bootloader left s3c-hsotg module in enabled state. Now interrupt handler is enabled only after proper configuration of hardware registers. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drive

[PATCH v2 12/12] usb: dwc2/gadget: avoid disabling ep0

2014-07-16 Thread Robert Baldyga
Endpoint 0 should not be disabled, so we start loop counter from number 1. Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 68b764e..3e4c3b9 100644 --- a/dri

[PATCH v2 07/12] usb: dwc2/gadget: break infinite loop in endpoint disable code

2014-07-16 Thread Robert Baldyga
From: Marek Szyprowski This patch fixes possible freeze caused by infinite loop in interrupt context. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/ga

[PATCH v2 10/12] usb: dwc2/gadget: assign TX FIFO dynamically

2014-07-16 Thread Robert Baldyga
Because we have not enough memory to have each TX FIFO of size at least 3072 bytes (the maximum single packet size), we create four FIFOs of lenght 1024, and four of length 3072 bytes, and assing them to endpoints dynamically according to maxpacket size value of given endpoint. It needed to do som

[PATCH v2 05/12] usb: dwc2/gadget: hide some not really needed debug messages

2014-07-16 Thread Robert Baldyga
From: Marek Szyprowski Some DWC2/s3c-hsotg debug messages are really useless for typical user, so hide them behind dev_dbg(). Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH v2 02/12] usb: dwc2/gadget: fix phy initialization sequence

2014-07-16 Thread Robert Baldyga
From: Kamil Debski In the Generic PHY Framework a NULL phy is considered to be a valid phy thus the "if (hsotg->phy)" check does not give us the information whether the Generic PHY Framework is used. In addition to the above this patch also removes phy_init from probe and phy_exit from remove. T

[PATCH v2 03/12] usb: dwc2/gadget: move phy bus legth initialization

2014-07-16 Thread Robert Baldyga
From: Kamil Debski This patch moves the part of code that initializes the PHY bus width. This results in simpler code and removes the need to check whether the Generic PHY Framework is used. Signed-off-by: Kamil Debski Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers

[PATCH v2 00/12] usb: dwc2/gadget: fix series

2014-07-16 Thread Robert Baldyga
Hello, This patchset contains fixes for dwc2 gadget driver. It touches PHY, FIFO configuration, initialization sequence and adds many other small fixes. Best regards Robert Baldyga Samsung R&D Institute Poland Changelog: v2: - add patch usb: dwc2/gadget: avoid disabling ep0 - fix FIFO flushing

Re: uas regression in 3.15 with Lacie Rugged USB3 and NEC uPD720200

2014-07-16 Thread Hans de Goede
Hi, On 07/16/2014 11:42 AM, Oliver Neukum wrote: > > On Wed, 2014-07-16 at 10:44 +0200, Hans de Goede wrote: >> Hi, >> >> On 07/16/2014 08:45 AM, Oliver Neukum wrote: >>> On Tue, 2014-07-15 at 22:23 +0200, Julian Sikorski wrote: [ 54.017997] sd 6:0:0:0: [sdb] Write cache: enabled, read cac

RE: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-07-16 Thread Peter Chen
> > > > Some people wanted the possibility to set the DMA mask as this USB2 CI > > driver does not do specific Berlin operation and can be reused later. > > I don't particularly need to call dma_coerce_mask_and_coherent() in my > > case, as far as I know. > > Ok, just remove the call then and re

Re: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-07-16 Thread Arnd Bergmann
On Wednesday 16 July 2014 11:58:14 Peter Chen wrote: > > > > > > Some people wanted the possibility to set the DMA mask as this USB2 CI > > > driver does not do specific Berlin operation and can be reused later. > > > I don't particularly need to call dma_coerce_mask_and_coherent() in my > > > case

[PATCH v7 1/4] usb: musb: core: Handle Babble condition only in HOST mode

2014-07-16 Thread George Cherian
BABBLE and RESET share the same interrupt. The interrupt is considered to be RESET if MUSB is in peripheral mode and as a BABBLE if MUSB is in HOST mode. Handle babble condition iff MUSB is in HOST mode. Signed-off-by: George Cherian Tested-by: Bin Liu --- drivers/usb/musb/musb_core.c | 2 +-

[PATCH v7 0/4] Add support for SW babble Control

2014-07-16 Thread George Cherian
Hi Felipe, Series add support for SW babble control logic found in new silicon versions of AM335x. Runtime differentiation of silicon version is done by checking the BABBLE_CTL register. For newer silicon the register default value read is 0x4 and for older versions its 0x0. Patch 1 -> Handle Ba

[PATCH v7 2/4] usb: musb: core: Convert babble recover work to delayed work

2014-07-16 Thread George Cherian
During babble condition both first disconnect of devices are initiated. Make sure MUSB controller is reset and re-initialized after all disconnects. To acheive this schedule a delayed work for babble recovery. While at that convert udelay to usleep_range. Refer Documentation/timers/timers-howto.t

[PATCH v7 4/4] usb: musb: dsps: Add the sw_babble_control() and Enable for newer silicon

2014-07-16 Thread George Cherian
Add sw_babble_control() logic to differentiate between transient babble and real babble condition. Also add the SW babble control register definitions. Babble control register logic is implemented in the latest revision of AM335x. Find whether we are running on newer silicon. The babble control r

[PATCH v7 3/4] usb: musb: core: Convert the musb_platform_reset to have a return value.

2014-07-16 Thread George Cherian
Currently musb_platform_reset() is only used by dsps. In case of BABBLE interrupt for other platforms the musb_platform_reset() is a NOP. In such situations no need to re-initialize the endpoints. Also in the latest silicon revision of AM335x, we do have a babble recovery mechanism without resetti

[RESEND PATCH v3 0/4] Cleanup for dwc3-omap

2014-07-16 Thread George Cherian
The series does some refactoring on dwc3_probe() Patch 1 - Now that we use driver compatible for revision check, remove the unnecessary logic. Patch 2-4 - reduce the size of dwc3_probe() George Cherian (4): usb: dwc3: dwc3-omap: Remove x_major calculation from revision register usb: dwc3

[RESEND PATCH v3 3/4] usb: dwc3: dwc3-omap: Add dwc3_omap_set_utmi_mode() function

2014-07-16 Thread George Cherian
Move find and set the utmi mode to its own seperate function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian --- drivers/usb/dwc3/dwc3-omap.c | 44 +--- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git

[RESEND PATCH v3 1/4] usb: dwc3: dwc3-omap: Remove x_major calculation from revision register

2014-07-16 Thread George Cherian
Remove the x_major calculation logic from the wrapper revision register to differentiate between OMAP5 and AM437x. This was done to find the register offsets of wrapper register. Now that We do it using dt compatible, remove the whole logic. Signed-off-by: George Cherian --- drivers/usb/dwc3/dwc

[RESEND PATCH v3 4/4] usb: dwc3: dwc3-omap: Add dwc3_omap_extcon_register function

2014-07-16 Thread George Cherian
Move the extcon related code to its own function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian --- drivers/usb/dwc3/dwc3-omap.c | 65 ++-- 1 file changed, 39 insertions(+), 26 deletions(-) diff --git a/drivers/us

[RESEND PATCH v3 2/4] usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset() function

2014-07-16 Thread George Cherian
Move map offset to its own seperate function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian --- drivers/usb/dwc3/dwc3-omap.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-oma

Re: [RESEND PATCH v3 2/4] usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset() function

2014-07-16 Thread Sergei Shtylyov
Hello. On 07/16/2014 05:07 PM, George Cherian wrote: Move map offset to its own seperate function. /seperate/separate/. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian --- drivers/usb/dwc3/dwc3-omap.c | 33 -

Re: [PATCHv4 0/3] Gadget directory cleanup

2014-07-16 Thread Andrzej Pietrasiewicz
W dniu 15.07.2014 22:12, Felipe Balbi pisze: Hi, On Tue, Jul 15, 2014 at 01:09:43PM +0200, Andrzej Pietrasiewicz wrote: This is a follow-up to this thread: v3..v4: changed the sequence modules are built so that for example g_ether is not initialized before libcomposite and functions if c

Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-16 Thread Pratyush Anand
On Wed, Jul 16, 2014 at 01:25:21PM +0800, Pratyush Anand wrote: > Hi Alan, > > Thanks a lot for your review. > > On Tue, Jul 15, 2014 at 10:46:00PM +0800, Alan Stern wrote: > > On Tue, 15 Jul 2014, Pratyush Anand wrote: > > > > > Problem Summary: Problem has been observed generally with PM states

[GIT PULL] USB-serial updates for v3.17

2014-07-16 Thread Johan Hovold
Hi Greg, Due to upcoming vacations, here's an early pull request for v3.17-rc1. Only a few small changes this time, and all have been in linux-next. Thanks, Johan The following changes since commit cd3de83f147601356395b57a8673e9c5ff1e59d1: Linux 3.16-rc4 (2014-07-06 12:37:51 -0700) are av

Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-16 Thread Alan Stern
On Wed, 16 Jul 2014, Pratyush Anand wrote: > Hu..May be this solution is not perfect. Have been reported with > at least one device which failed with this patch too. A print of > link_state for that device(sleep changed to 2ms) shows that for a long > time link was in rxDetect. May be I will t

Re: [PATCHv2] usb: gadget: composite: Provide a list of available functions

2014-07-16 Thread Felipe Balbi
On Wed, Jul 16, 2014 at 09:58:31AM +0200, Sebastian Andrzej Siewior wrote: > On 07/14/2014 12:36 PM, Andrzej Pietrasiewicz wrote: > > W dniu 14.07.2014 11:50, Sebastian Andrzej Siewior pisze: > >> On 07/14/2014 11:35 AM, Andrzej Pietrasiewicz wrote: > >>> A userland tool for assembling gadgets with

Re: [PATCH v4 2/4] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-07-16 Thread Felipe Balbi
On Wed, Jul 16, 2014 at 01:51:40PM +0530, Vivek Gautam wrote: > The host controller by itself may sometimes need to handle PHY > and/or calibrate some of the PHY settings to get full support out > of the PHY controller. The PHY core provides a calibration > funtionality now to do so. > Therefore, f

[PATCH 0/7] g_webcam: Preparation for configfs

2014-07-16 Thread Andrzej Pietrasiewicz
This patch series prepares the webcam gadget for supporting configfs. Compared to the RFC: http://www.spinics.net/lists/linux-usb/msg103301.html - the patch fixing potential memory leak has been removed, because it is already in Laurent's tree. - a patch changing function names to avoid conflict

[PATCH 1/7] usb: gadget: uvc: move module parameters from f_uvc

2014-07-16 Thread Andrzej Pietrasiewicz
When configfs support is integrated the future uvc function module must not take any parameters. Move parameters to webcam. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_uvc.c | 26 +- drivers/usb/gadget/function/f_uvc.h | 6 +- drivers/usb/g

[PATCH 4/7] usb: gadget: f_uvc: convert f_uvc to new function interface

2014-07-16 Thread Andrzej Pietrasiewicz
Use the new function registration interface. It is required in order to integrate configfs support. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/Kconfig | 3 + drivers/usb/gadget/function/Makefile | 2 + drivers/usb/gadget/function/f_uvc.c | 205

[PATCH 3/7] usb: gadget: uvc: separately compile some components of f_uvc

2014-07-16 Thread Andrzej Pietrasiewicz
Compile uvc_queue, uvc_v4l2, uvc_video separately so that later they can be all combined in a separately compiled f_uvc. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_uvc.c | 2 ++ drivers/usb/gadget/function/f_uvc.h | 8 +++ drivers/usb/gadget/function/uvc

[PATCH 5/7] usb: gadget: webcam: convert webcam to new interface of f_uvc

2014-07-16 Thread Andrzej Pietrasiewicz
Use the new function interface of f_uvc. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Laurent Pinchart --- drivers/usb/gadget/legacy/Kconfig | 1 + drivers/usb/gadget/legacy/Makefile | 2 +- drivers/usb/gadget/legacy/webcam.c | 53 +++--- 3 files changed, 40

[PATCH 7/7] usb: gadget: f_uvc: use usb_gstrings_attach

2014-07-16 Thread Andrzej Pietrasiewicz
Attach strings to gadget with usb_strings_attach. It is required for correct instantiation of functions more than once: instead of modifying the local uvc_en_us_strings a function instance specific copy is created with usb_gstrings_attach. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gad

[PATCH 6/7] usb: gadget: f_uvc: remove compatibility layer

2014-07-16 Thread Andrzej Pietrasiewicz
There are no users of the old interface left. Remove it. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Laurent Pinchart --- drivers/usb/gadget/function/f_uvc.c | 167 drivers/usb/gadget/function/f_uvc.h | 11 --- 2 files changed, 178 deletions(-) diff --g

[PATCH 2/7] usb: gadget: uvc: rename functions to avoid conflicts with host uvc

2014-07-16 Thread Andrzej Pietrasiewicz
Prepare for separate compilation of uvc function's components. Some symbols will have to be exported, so rename to avoid conflicts with functions of the same name in host uvc. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_uvc.c | 2 +- drivers/usb/gadget/function/uv

Re: [PATCH 1/4] usb: move the OTG state from the USB PHY to the OTG structure

2014-07-16 Thread Felipe Balbi
On Thu, Jul 10, 2014 at 03:47:58PM +0200, Antoine Ténart wrote: > Hi Felipe, > > On Thu, Jul 10, 2014 at 08:40:23AM -0500, Felipe Balbi wrote: > > On Wed, Jul 09, 2014 at 12:17:13PM +0200, Antoine Ténart wrote: > > > Before using the PHY framework instead of the USB PHY one, we need to > > > move

Re: [PATCH v4 4/4] usb: gadget: pxa27x_udc: trivial include fix

2014-07-16 Thread Felipe Balbi
Hi, On Mon, Jul 14, 2014 at 07:05:32PM +0200, Robert Jarzmik wrote: > Remove mach specific includes and use platform_data includes. > > Signed-off-by: Robert Jarzmik > --- > drivers/usb/gadget/pxa27x_udc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/g

Re: [PATCH v2 4/8] usb: rename phy to usb_phy in HCD

2014-07-16 Thread Felipe Balbi
On Tue, Jul 15, 2014 at 07:55:51PM +0400, Sergei Shtylyov wrote: > Hello. > > On 07/15/2014 06:39 PM, Antoine Ténart wrote: > > >The USB PHY member of the HCD structure is renamed to 'usb_phy' and > >modifications are done in all drivers accessing it. > > >Signed-off-by: Antoine Ténart > >

Re: [GIT PULL] USB-serial updates for v3.17

2014-07-16 Thread Greg Kroah-Hartman
On Wed, Jul 16, 2014 at 04:01:31PM +0200, Johan Hovold wrote: > Hi Greg, > > Due to upcoming vacations, here's an early pull request for v3.17-rc1. > > Only a few small changes this time, and all have been in linux-next. > > Thanks, > Johan > > > The following changes since commit cd3de83f147

Re: [PATCH v3 01/12] reset: add the Berlin reset controller driver

2014-07-16 Thread Andrew Lunn
On Wed, Jul 16, 2014 at 10:25:55AM +0200, Antoine Ténart wrote: > Add a reset controller for Marvell Berlin SoCs which is used by the > USB PHYs drivers (for now). > > Signed-off-by: Antoine Ténart > Signed-off-by: Sebastian Hesselbarth > Acked-by: Philipp Zabel > --- > drivers/reset/Makefile

Re: [PATCH v2 4/8] usb: rename phy to usb_phy in HCD

2014-07-16 Thread Sergei Shtylyov
Hello. On 07/16/2014 07:09 PM, Felipe Balbi wrote: The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. Signed-off-by: Antoine Ténart I've been thru that and such change has been turned down already. OK, maybe no

[ANNOUNCE] about to close my tree

2014-07-16 Thread Felipe Balbi
hi folks, We're close to -rc6 and I want to send my pull request to Greg this friday. Whatever is not in linux-usb by now, will *not* get pulled for v3.17. I still have two or three series to go through, but they're looking like they won't make it because I'm still waiting for Acks. regards --

Re: [PATCH v4 4/4] usb: gadget: pxa27x_udc: trivial include fix

2014-07-16 Thread Robert Jarzmik
Felipe Balbi writes: > Hi, > > On Mon, Jul 14, 2014 at 07:05:32PM +0200, Robert Jarzmik wrote: >> Remove mach specific includes and use platform_data includes. >> >> Signed-off-by: Robert Jarzmik >> --- >> drivers/usb/gadget/pxa27x_udc.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(

[PATCH 3/3] usb: gadget: udc: fsl_mxc_udc: fix sparse error

2014-07-16 Thread Felipe Balbi
No functional changes, just fixing one easy to spot sparse error. While fixing that sparse error, I had to add two includes to a header to avoid a build error. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/udc/fsl_mxc_udc.c | 2 ++ drivers/usb/gadget/udc/fsl_usb2_udc.h | 3 +++ 2 files ch

Re: [PATCH 0/7] g_webcam: Preparation for configfs

2014-07-16 Thread Felipe Balbi
Hi, On Wed, Jul 16, 2014 at 04:54:10PM +0200, Andrzej Pietrasiewicz wrote: > This patch series prepares the webcam gadget for supporting configfs. > Compared to the RFC: > > http://www.spinics.net/lists/linux-usb/msg103301.html > > - the patch fixing potential memory leak has been removed, > bec

[PATCH 2/3] usb: gadget: udc: net2280: fix sparse error

2014-07-16 Thread Felipe Balbi
No functional changes, just fixing one easy to spot sparse error. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/udc/net2280.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c index 248dccb..f4eac11 100644

[PATCH 1/3] usb: gadget: udc: fsl_udc_core: fix sparse errors

2014-07-16 Thread Felipe Balbi
No functional changes, just fixing some easy to spot sparse errors. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/udc/fsl_udc_core.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.

Re: [PATCH v2 0/8] usb: add support for the generic PHY framework

2014-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 15, 2014 at 04:39:08PM +0200, Antoine Ténart wrote: > Hi all, > > This is an attempt to add more common USB code aware of the generic PHY > framework, while keeping the compatibility for the USB PHY one. It does > not add the full support, some USB PHY specific functions not being

Re: [PATCH v4 4/4] usb: gadget: pxa27x_udc: trivial include fix

2014-07-16 Thread Felipe Balbi
On Wed, Jul 16, 2014 at 07:39:46PM +0200, Robert Jarzmik wrote: > Felipe Balbi writes: > > > Hi, > > > > On Mon, Jul 14, 2014 at 07:05:32PM +0200, Robert Jarzmik wrote: > >> Remove mach specific includes and use platform_data includes. > >> > >> Signed-off-by: Robert Jarzmik > >> --- > >> driv

Re: [PATCH] usb: gadget: f_rndis: fix interface id for OS descriptors

2014-07-16 Thread Felipe Balbi
On Tue, Jul 01, 2014 at 03:47:47PM +0200, Andrzej Pietrasiewicz wrote: > f->os_desc_table[0].if_id is zero by default. If the actual id happens > to be different then no Feature Descriptors will be returned to the host > for this interface, so assign if_id as soon as it is known. > > Signed-off-by

[ANNOUNCE] tree closed for v3.17 (was: Re: [ANNOUNCE] about to close my tree)

2014-07-16 Thread Felipe Balbi
hi, On Wed, Jul 16, 2014 at 12:04:51PM -0500, Felipe Balbi wrote: > hi folks, > > We're close to -rc6 and I want to send my pull request to Greg this > friday. Whatever is not in linux-usb by now, will *not* get pulled for > v3.17. I still have two or three series to go through, but they're > loo

[PATCH 1/1] Removing unncessary `usb_reset_device` on startup

2014-07-16 Thread Preston Fick
From: Preston Fick This `usb_reset_device` command has been around since the driver was originally reverse engineered. It doesn't cause much issue on single interface CP210x devices, but on the CP2105 and CP2108 with 2 and 4 interfaces respectively it will cause instability on enumeration and del

Re: [PATCH] usb: gadget: fix the sequence modules are built

2014-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 15, 2014 at 01:09:23PM +0200, Andrzej Pietrasiewicz wrote: > If gadget g_*.ko modules are built-in their initialization happens before > libcomposite is initialized. This results in e.g. g_ether not initializing > if compiled-in. This patch fixes the order modules are > built, so t

RE: [PATCH v2 10/12] usb: dwc2/gadget: assign TX FIFO dynamically

2014-07-16 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Wednesday, July 16, 2014 3:22 AM > > Because we have not enough memory to have each TX FIFO of size at least 3072 > bytes (the maximum single packet size), we create four FIFOs of lenght 1024, > and four of length 3072 bytes, and assing

RE: [PATCH v2 10/12] usb: dwc2/gadget: assign TX FIFO dynamically

2014-07-16 Thread Paul Zimmerman
> With a TX FIFO size of 3072, an entire microframe worth of Isoc data > (when MaxBurst=2) can fit in the FIFO. I guess that is why you chose s/MaxBurst/Mult/ i.e. bits 12..11 of wMaxPacketSize. -- Paul > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behal

[PATCH 08/12] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-07-16 Thread dinguyen
From: Dinh Nguyen Since the dwc2 hcd driver is currently not looking for a clock node during init, we should not completely fail if there isn't a clock provided. Add a check for a valid clock before calling clock functions. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/gadget.c | 15 ++

[PATCH 05/12] usb: dwc2: Add the appropriate init calls in platform code

2014-07-16 Thread dinguyen
From: Dinh Nguyen Add the proper init calls for either host, gadget or both in platform.c Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/core.h |3 +++ drivers/usb/dwc2/gadget.c |2 +- drivers/usb/dwc2/platform.c | 29 + 3 files changed, 29 insertio

[PATCH 12/12] usb: dwc2: pci: Update pci portion of the dwc2 driver

2014-07-16 Thread dinguyen
From: Dinh Nguyen Initialize the spinlock here as the original spinlock in the host driver has been removed. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/pci.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c index c291fca..faacac9 10064

[PATCH 02/12] usb: dwc2: Moves s3c_hsotg gadget data structure into dwc2_hsotg

2014-07-16 Thread dinguyen
From: Dinh Nguyen Adds the gadget data structure and appropriate data structure pointers to the common dwc2_hsotg data structure. This is needed so that the dwc2_hsotg data structure can be used by the hcd and gadget drivers. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/core.h |6 ++

[PATCH 07/12] usb: dwc2: Move gadget interrupts to common interrupt handler

2014-07-16 Thread dinguyen
From: Dinh Nguyen Update dwc2_handle_common_intr() to handle both hcd and gadget interrupts. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/core_intr.c | 116 +- drivers/usb/dwc2/gadget.c| 188 -- 2 files changed, 114 inser

[PATCH 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-07-16 Thread dinguyen
From: Dinh Nguyen Update DWC2 kconfig and makefile to support dual-role mode. The platform file will always get compiled for the case where the controller is directly connected to the CPU. So for loadable modules, only dwc2.ko is needed. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/Kconfig

[PATCH 04/12] usb: dwc2: Add DTS compatible string to dwc2_of_match_table

2014-07-16 Thread dinguyen
From: Dinh Nguyen Puts back "samsung,s3c6400-hsotg" into the dwc2_of_match_table[]. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/platform.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 5785fd6..53e6c90 100644 --- a/dr

[PATCH 09/12] usb: dwc2: initialize the spin_lock for both host and gadget

2014-07-16 Thread dinguyen
From: Dinh Nguyen Move spin_lock_init to common location for both host and gadget. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/hcd.c |1 - drivers/usb/dwc2/platform.c |1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/h

[PATCH 06/12] usb: dwc2: Initialize the USB core for peripheral mode

2014-07-16 Thread dinguyen
From: Dinh Nguyen Initialize the USB driver to peripheral mode when a B-Device connector is attached. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/hcd.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index e6acb17..1936544 100644 --- a

[PATCH 10/12] usb: dwc2: Add suspend/resume for gadget

2014-07-16 Thread dinguyen
From: Dinh Nguyen Move suspend/resume code to common platform code. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/platform.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index dfadf5a..69136cc 100644

[PATCH 00/12] usb: dwc2: Add support for dual role

2014-07-16 Thread dinguyen
From: Dinh Nguyen Hello, This patch series combines the dwc2 gadget and host driver into a single dual role driver. Here is a breakdown of what each patch does: 1/2 : usb: dwc2: Update Kconfig to support dual-role - Changes the Kconfig and Makefile to build a single dwc2.ko for all

  1   2   >