[PATCH] USB: oxu210hp-hcd.c: use devm_ functions

2014-06-29 Thread Himangi Saraogi
This patch introduces the use of devm_ioremap_resource instead of request_mem_region and ioremap. The error handling on platform_get_resource and the error message for ioremap are removed. The function devm_kzalloc replaces memory allocation by unmanaged kzalloc. The function calls to free the allo

Re: [PATCH v2 2/3] usb: gadget: pxa27x_udc device-tree documentation

2014-06-29 Thread Robert Jarzmik
Mark Rutland writes: > On Wed, Jun 25, 2014 at 08:54:01PM +0100, Robert Jarzmik wrote: >> > The name of the clock input doesn't make sense. >> I don't understand. With [1] does it make any more sense ? If not you'll >> have to >> expand a bit more the "doesn't make sense". > > My concern is that

[PATCH v3 4/4] usb: gadget: pxa27x_udc: use devm_* helpers

2014-06-29 Thread Robert Jarzmik
Use devm_* helpers in the probe function to simplify the error path and the remove path. Signed-off-by: Robert Jarzmik Cc: Sergei Shtylyov --- Since V1: Addressed Sergei's comments --- drivers/usb/gadget/pxa27x_udc.c | 57 +++-- 1 file changed, 15 insertions

[PATCH v3 1/4] usb: gadget: pxa27x_udc: prepare and unprepare the clock

2014-06-29 Thread Robert Jarzmik
Add clock prepare and unprepare as required by clock framework. Signed-off-by: Robert Jarzmik --- drivers/usb/gadget/pxa27x_udc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/gadget/pxa27x_udc.c b/drivers/usb/gadget/pxa27x_udc.c index cdf4d67..597d39f 100644 --- a/driver

[PATCH v3 3/4] usb: gadget: pxa27x_udc device-tree documentation

2014-06-29 Thread Robert Jarzmik
Add documentation for device-tree binding of arm PXA 27x udc (usb device) driver. Signed-off-by: Robert Jarzmik Cc: devicet...@vger.kernel.org --- Since V1: change OF id mrvl,pxa27x_udc -> marvell,pxa27x-udc This is a consequence of other DT reviews on the marvell namings. Si

[PATCH v3 2/4] usb: gadget: pxa27x_udc: add devicetree support

2014-06-29 Thread Robert Jarzmik
Add support for device-tree device discovery. If devicetree is not provided, fallback to legacy platform data "discovery". Signed-off-by: Robert Jarzmik Cc: devicet...@vger.kernel.org --- Since V1: change OF id mrvl,pxa27x_udc -> marvell,pxa27x-udc This is a consequence of other DT rev

Re: [PATCH v6 1/1] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-06-29 Thread Magnus Damm
On Sat, Jun 28, 2014 at 12:40 AM, Felipe Balbi wrote: > On Wed, Jun 18, 2014 at 02:15:42PM +0900, Magnus Damm wrote: >> Hi Felipe, >> >> On Fri, Jun 13, 2014 at 11:25 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Fri, Jun 13, 2014 at 09:20:31PM +0900, Yoshihiro Shimoda wrote: >> >> The R-Car H2 a

Re: [PATCH v3 4/4] usb: gadget: pxa27x_udc: use devm_* helpers

2014-06-29 Thread Sergei Shtylyov
Hello. On 06/29/2014 06:01 PM, Robert Jarzmik wrote: Use devm_* helpers in the probe function to simplify the error path and the remove path. Signed-off-by: Robert Jarzmik Cc: Sergei Shtylyov --- Since V1: Addressed Sergei's comments --- drivers/usb/gadget/pxa27x_udc.c | 57 ++

Kernel 3.15.2-1.gfb7c781 + USB3 (xhci_hcd) card throws CALL TRACE, completes boot

2014-06-29 Thread grantksupport
Hi, I'd recently reported an issue with kernel 3.14.4-1 'vs' USB3 -- call trace & no boot. A resolution was found, with patches Re: Fwd: xHCI regression for VIA USB 3.0 controller in handle_cmd_completion http://www.spinics.net/lists/linux-usb/msg108520.html I reported the problem to my dist

[PATCH] usb: usb3503: return correct error return on failure

2014-06-29 Thread Colin King
From: Colin Ian King Fix warning: drivers/usb/misc/usb3503.c:195:11: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] err is not initialized, the error return should be PTR_ERR(clk) Signed-off-by: Colin Ian King --- drivers/usb/misc/usb3503.c | 3 ++- 1 file

Re: [PATCH] usb: dwc2: fix sparse warning in platform.c

2014-06-29 Thread Jingoo Han
On Saturday, June 28, 2014 3:31 AM, Paul Zimmerman wrote: > On Friday, June 27, 2014 11:00 AM, Sergei Shtylyov wrote: > > On 06/27/2014 07:09 PM, dingu...@altera.com wrote: > > > >> From: Dinh Nguyen > > > >> This patch fixes this sparse warning: > > > >> drivers/usb/dwc2/platform.c:168:25: warnin

Re: [PATCH] usb: usb3503: return correct error return on failure

2014-06-29 Thread Jingoo Han
On Monday, June 30, 2014 6:43 AM, Colin King wrote: > > From: Colin Ian King > > Fix warning: drivers/usb/misc/usb3503.c:195:11: warning: 'err' > may be used uninitialized in this function [-Wmaybe-uninitialized] > > err is not initialized, the error return should be PTR_ERR(clk) > > Signed-

Re: [PATCH v2 1/2] usb: chipidea: zynq: Add device tree binding information

2014-06-29 Thread punnaiah choudary kalluri
On Fri, Jun 27, 2014 at 5:53 PM, Sergei Shtylyov wrote: > Hello. > > > On 06/27/2014 03:23 PM, Punnaiah Choudary Kalluri wrote: > >> Document device tree binding information as required by >> the ZYNQ USB controller. > > >> Signed-off-by: Punnaiah Choudary Kalluri > > [...] > > >> diff --git a/Do

Re: [PATCH v2 2/2] usb: chipidea: Add support for zynq usb host and device controller

2014-06-29 Thread punnaiah choudary kalluri
On Fri, Jun 27, 2014 at 6:25 PM, Michael Grzeschik wrote: > Hi, > > On Fri, Jun 27, 2014 at 04:53:53PM +0530, Punnaiah Choudary Kalluri wrote: >> Zynq soc uses Chipidea/Synopsys usb IP core(CI13612). This patch adds >> necessary glue to allow the chipidea driver to work on zynq soc. >> > > Did you

Re: [PATCH v2 2/2] usb: chipidea: Add support for zynq usb host and device controller

2014-06-29 Thread punnaiah choudary kalluri
On Sat, Jun 28, 2014 at 11:16 AM, Peter Chen wrote: > On Fri, Jun 27, 2014 at 02:55:15PM +0200, Michael Grzeschik wrote: >> Hi, >> >> On Fri, Jun 27, 2014 at 04:53:53PM +0530, Punnaiah Choudary Kalluri wrote: >> > Zynq soc uses Chipidea/Synopsys usb IP core(CI13612). This patch adds >> > necessary

[PATCH 0/1] Chipidea fix for v3.16

2014-06-29 Thread Peter Chen
Hi Greg, This bug is found during the USB Certification test, and the fix is needed for stable tree, thanks. Peter Chen (1): usb: chipidea: udc: delete td from req's td list at ep_dequeue drivers/usb/chipidea/udc.c |8 1 files changed, 8 insertions(+), 0 deletions(-) -- 1.7.8

[PATCH 1/1] usb: chipidea: udc: delete td from req's td list at ep_dequeue

2014-06-29 Thread Peter Chen
We need to delete un-finished td from current request's td list at ep_dequeue API, otherwise, this non-user td will be remained at td list before this request is freed. So if we do ep_queue-> ep_dequeue->ep_queue sequence, when the complete interrupt for the second ep_queue comes, we search td list

Re: [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-29 Thread Richard Leitner
Hello, thanks for your reply! On Fri, 27 Jun 2014 10:46:28 -0700 Greg Kroah-Hartman wrote: > On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote: > > Replace all hardcoded ttyGS strings with the PREFIX macro. > > Why? Because IMHO if PREFIX is available it should be used everywhere

Re: [PATCH v3 3/4] usb: gadget: pxa27x_udc device-tree documentation

2014-06-29 Thread Arnd Bergmann
On Sunday 29 June 2014 16:01:12 Robert Jarzmik wrote: > +Required properties: > + - compatible: Should be "marvell,pxa270-udc" for USB controllers > + used in device mode. > + - reg: usb device MMIO address space > + - interrupts: single interrupt generated by the UDC IP > + - clocks: input clock