From: Kamil Debski
This patch moves the part of code that initializes the PHY bus width.
This results in simpler code and removes the need to check whether
the Generic PHY Framework is used.
Signed-off-by: Kamil Debski
Signed-off-by: Marek Szyprowski
Signed-off-by: Robert Baldyga
---
drivers
From: Kamil Debski
In the Generic PHY Framework a NULL phy is considered to be a valid phy
thus the "if (hsotg->phy)" check does not give us the information whether
the Generic PHY Framework is used.
In addition to the above this patch also removes phy_init from probe and
phy_exit from remove. T
From: Kamil Debski
When the driver is removed s3c_hsotg_phy_disable is called three times
instead of once. This results in decreasing of the phy reference counter
below zero and thus consecutive inserts of the module fails.
This patch removes calls to s3c_hsotg_phy_disable from s3c_hsotg_remove
From: Andrzej Pietrasiewicz
Adjust the debug text to the name of the printed variable.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Robert Baldyga
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/d
Because we have not enough memory to have each TX FIFO of size at least 3072
bytes (the maximum single packet size), we create four FIFOs of lenght 1024,
and four of length 3072 bytes, and assing them to endpoints dynamically
according to maxpacket size value of given endpoint.
Signed-off-by: Robe
From: Marek Szyprowski
This leads to potential spinlock recursion in composite framework, other
udc drivers also don't call it directly from pullup method.
Signed-off-by: Marek Szyprowski
Signed-off-by: Robert Baldyga
---
drivers/usb/dwc2/gadget.c | 1 -
1 file changed, 1 deletion(-)
diff --
From: Marek Szyprowski
This patch fixes possible freeze caused by infinite loop in interrupt
context.
Signed-off-by: Marek Szyprowski
Signed-off-by: Robert Baldyga
---
drivers/usb/dwc2/gadget.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/ga
When device is stopped or suspended clock is not needed so we
can disable it for this time.
Signed-off-by: Robert Baldyga
---
drivers/usb/dwc2/gadget.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 2a7c014..0523bc3 100644
From: Marek Szyprowski
This patch fixes kernel panic/interrupt storm/etc issues if bootloader
left s3c-hsotg module in enabled state. Now interrupt handler is enabled
only after proper configuration of hardware registers.
Signed-off-by: Marek Szyprowski
Signed-off-by: Robert Baldyga
---
drive
From: Marek Szyprowski
Some DWC2/s3c-hsotg debug messages are really useless for typical user,
so hide them behind dev_dbg().
Signed-off-by: Marek Szyprowski
Signed-off-by: Robert Baldyga
---
drivers/usb/dwc2/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dri
Hello,
This patchset contains fixes for dwc2 gadget driver. It touches PHY,
FIFO configuration, initialization sequence and adds many other small fixes.
Best regards
Robert Baldyga
Samsung R&D Institute Poland
Andrzej Pietrasiewicz (1):
usb: dwc2/gadget: Fix comment text
Kamil Debski (3):
u
From: Marek Szyprowski
Print warning if FIFOs are configured in such a way that they don't fit
into the SPRAM available on the s3c hsotg module.
Signed-off-by: Marek Szyprowski
Signed-off-by: Robert Baldyga
---
drivers/usb/dwc2/core.h | 1 +
drivers/usb/dwc2/gadget.c | 15 ++-
On Fri, 2014-06-20 at 22:40 +0200, Fabian Frederick wrote:
> inline this one line function used in driver_info structure
That precisely is this the reason not to inline this.
It is used as a function pointer. gcc must generate
a non-inlined version of the function.
Your patch has zero effect and
On Fri, Jun 20, 2014 at 06:30:23PM +0800, 刘磊 wrote:
> patch2: Modify the parameter from 0x0003 to 0x. you must submit patch1 at
> first.
> Reason:In the USB serial protocol, if set the control state
> (SET_CONTROL_LINE_STATE(22h)) and the parameter of RTS must be 0x
> that make the carri
Refactor and use the usb-serial infrastructure for line-control
handling.
This driver has been implemented based on sniffed traffic. A closer look
at the requests sent during open and close reveals that these request
appear to be standard CDC requests. If this is the case, then the
control request
Clean up control requests sent during open and close.
This driver has been implemented based on sniffed traffic. A closer look
at the requests sent during open and close reveals that these request
appear to be standard CDC requests. If this is the case, then the
control requests lack the interface
>Could you try the first patch (only) and see if it fixes the problem?
>Does it also fix the problem you're having with PID 0xfffe?
yes, the first patch could solve the problem with pid 0xfffe.
>When you you have tested the first patch, could you test the second one
>as well and see if everythi
I'll be using my kernel.org address for upstream work from now on so
update my MAINTAINERS entry.
Signed-off-by: Johan Hovold
---
Greg, I intend to include this one in my upcoming v3.16-rc pull request.
Johan
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAI
On Tue, May 20, 2014 at 04:27:40PM +0200, oneu...@suse.de wrote:
> From: Oliver Neukum
>
> Reported by Alif Mubarak Ahmad:
>
> This device vendor and product id is 1c9e:9800
> It is working as serial interface with generic usbserial driver.
> I thought it is more suitable to use usbserial option
On Tue, Jun 03, 2014 at 02:01:57PM +0200, Matthias Urlichs wrote:
> Hi,
>
> Matthias Urlichs:
> > Fine by me.
>
> or, in other words:
>
> Signed-Off-By: Matthias Urlichs
I've now applied this to my usb-linus branch with yours and Oliver's
signed-offs.
Thanks,
Johan
--
To unsubscribe from this
On Fri, Jun 06, 2014 at 05:25:56PM +0200, Bjørn Mork wrote:
> Adding a couple of Olivetti modems and blacklisting the net
> function on a couple which are already supported.
>
> Reported-by: Lars Melin
> Cc:
> Signed-off-by: Bjørn Mork
Applied, thanks!
Johan
--
To unsubscribe from this list:
On Mon, Jun 23, 2014 at 06:15:52PM +0800, 刘磊 wrote:
>
> >Could you try the first patch (only) and see if it fixes the problem?
> >Does it also fix the problem you're having with PID 0xfffe?
>
> yes, the first patch could solve the problem with pid 0xfffe.
Did you test my first patch ("USB: zte_e
My drive is working again with:
options usb-storage quirks=174c:55aa:u
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Sehr geehrter Kunde,
Bitte beachten Sie, dass Ihre E-Banking-Zugang abl?uft bald. dies
Weiter zum Service k?nnen zu verwenden, auf den Button unten klicken Sie
bitte
Ihr Zugang manuell mit unseren Sicherheitsupdate auf Link-
Update: Sparkasse Online-Banking Update: folgen Sie dem Link unten
kli
hi all:
when i trace xhci source, I found in skip_isoc_td, there is a
possibility to increase de-queue pointer twice.
in skip_isoc_td:
/* Update ring dequeue pointer */
while (ep_ring->dequeue != td->last_trb)
inc_deq(xhci, ep_ring);
inc_deq(xhci, ep_ring);
w
From: vichy
> hi all:
> when i trace xhci source, I found in skip_isoc_td, there is a
> possibility to increase de-queue pointer twice.
>
> in skip_isoc_td:
> /* Update ring dequeue pointer */
> while (ep_ring->dequeue != td->last_trb)
> inc_deq(xhci, ep_ring);
>
Sehr geehrter Kunde,
Bitte beachten Sie, dass Ihre E-Banking-Zugang ablдuft bald. dies
Weiter zum Service kцnnen zu verwenden, auf den Button unten klicken Sie
bitte
Ihr Zugang manuell mit unseren Sicherheitsupdate auf Link-
Update: Sparkasse Online-Banking Update: folgen Sie dem Link unten
kli
On 06/22/2014 05:33 PM, Alan Stern wrote:
> On Sun, 22 Jun 2014, Wang, Yu wrote:
>
>> From: "Wang, Yu"
>>
>> The system suspend flow as following:
>> 1, Freeze all user processes and kenrel threads.
>>
>> 2, Trying to suspend all devices.
>>
>> 2.1, If pci device under RPM suspended state, then p
On Mon, 23 Jun 2014, Jonathan wrote:
> My drive is working again with:
>
> options usb-storage quirks=174c:55aa:u
Are you aware that this option causes the uas driver not to be used?
So if there is a bug in uas, this merely hides it. Nothing is fixed.
Alan Stern
--
To unsubscribe from this
On Wed, 2014-06-18 at 19:05 +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exists in
> MSI GT683R laptop
>
> +static int gt683r_led_probe(struct hid_device *hdev,
> + const struct hid_device_id *id)
> +{
> + int i;
> + int
Hi,
On Sun, Jun 22, 2014 at 10:39:07AM -0400, Alan Stern wrote:
> > What happens if you attach the full-speed device to a high-speed hub
> > and plug that hub into the MUSB?
> >
> >
> > That's a very interesting test i will definitely do. Unfortunately, even
> > if that solves the problem, we c
On Mon, 2014-06-23 at 18:15 +0800, 刘磊 wrote:
> >Could you try the first patch (only) and see if it fixes the problem?
> >Does it also fix the problem you're having with PID 0xfffe?
>
> yes, the first patch could solve the problem with pid 0xfffe.
>
>
> >When you you have tested the first patch,
On Mon, Jun 23, 2014 at 04:35:13PM +0200, Oliver Neukum wrote:
> On Wed, 2014-06-18 at 19:05 +0300, Janne Kanniainen wrote:
> > This driver adds support for USB controlled led panels that exists in
> > MSI GT683R laptop
> >
>
> > +static int gt683r_led_probe(struct hid_device *hdev,
> > +
On Mon, Jun 23, 2014 at 09:42:08AM -0500, Dan Williams wrote:
> On Mon, 2014-06-23 at 18:15 +0800, 刘磊 wrote:
> > >Could you try the first patch (only) and see if it fixes the problem?
> > >Does it also fix the problem you're having with PID 0xfffe?
> >
> > yes, the first patch could solve the prob
On Mon, Jun 23, 2014 at 04:42:55PM +0200, Johan Hovold wrote:
> On Mon, Jun 23, 2014 at 04:35:13PM +0200, Oliver Neukum wrote:
> > On Wed, 2014-06-18 at 19:05 +0300, Janne Kanniainen wrote:
> > > This driver adds support for USB controlled led panels that exists in
> > > MSI GT683R laptop
> > >
>
On Mon, Jun 23, 2014 at 11:47:35AM +0530, Tushar Behera wrote:
> On 06/17/2014 04:54 PM, Marek Szyprowski wrote:
> > Hello,
> >
> > On 2014-06-17 13:08, Tushar Behera wrote:
> >> 'err' is uninitialized, rather print the error code directly.
> >>
> >> This also fixes following warning.
> >> drivers
>> Sorry for noticing this thread late.
No problem. Good that you noticed it now! Thank you.
> Just move the initialisation of the lock and work to the other private
> data initialisations directly after it's allocated.
>
> Can you send a follow up patch, Janne?
Yes I can. Just a moment.
Janne
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
Signed-off-by: Janne Kanniainen
---
Changes in v2:
- sorted headers to alphabetic order
- using devm_kzalloc
- using BIT(n)
- using usb_control_msg instead of usb_submit_urb
On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote:
> This driver adds support for USB controlled led panels that exists in
> MSI GT683R laptop
>
> Signed-off-by: Janne Kanniainen
> ---
> Changes in v2:
> - sorted headers to alphabetic order
> - using devm_kzalloc
>
On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote:
> On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote:
> > + ret = sysfs_create_group(&led->hdev->dev.kobj, >683r_attribute_group);
> > + if (ret) {
> > + hid_err(hdev, "failed to create sysfs attributes\n");
> > +
Hi,
On Mon, Jun 23, 2014 at 08:07:43AM +0200, Robert Baldyga wrote:
> On 06/19/2014 05:08 PM, Felipe Balbi wrote:
> > On Mon, Jun 16, 2014 at 10:20:36AM +0200, Robert Baldyga wrote:
> >> This field allows to mark ep as claimed in more clear way. Claiming
> >> endpoint by setting driver_data to non
On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote:
> + ret = sysfs_create_group(&led->hdev->dev.kobj, >683r_attribute_group);
> + if (ret) {
> + hid_err(hdev, "failed to create sysfs attributes\n");
> + goto fail;
> + }
No, you need to set the att
At probe time, the musb_am335x driver register its childs by
calling of_platform_populate(), which registers all childs in
the devicetree hierarchy recursively.
On the other side, the driver's remove() function uses of_device_unregister()
to remove each child of musb_am335x's.
However, when musb_
> From: Robert Baldyga [mailto:r.bald...@samsung.com]
> Sent: Monday, June 23, 2014 12:51 AM
>
> From: Marek Szyprowski
>
> Print warning if FIFOs are configured in such a way that they don't fit
> into the SPRAM available on the s3c hsotg module.
>
> Signed-off-by: Marek Szyprowski
> Signed-o
> From: Robert Baldyga [mailto:r.bald...@samsung.com]
> Sent: Monday, June 23, 2014 12:51 AM
>
> Because we have not enough memory to have each TX FIFO of size at least 3072
> bytes (the maximum single packet size), we create four FIFOs of lenght 1024,
> and four of length 3072 bytes, and assing t
> From: Robert Baldyga [mailto:r.bald...@samsung.com]
> Sent: Monday, June 23, 2014 12:51 AM
>
> Hello,
>
> This patchset contains fixes for dwc2 gadget driver. It touches PHY,
> FIFO configuration, initialization sequence and adds many other small fixes.
Hi Robert,
I have a couple of questions
On Fri, Jun 20 2014, Felipe Balbi wrote:
> Here's my first set of fixes for this -rc cycle. Please consider merging
> to your usb-linus branch.
So… About that…
> Michal Nazarewicz (2):
I'm not sure if you want to include them later on, but those two, which
I think should be in 3.16, are missin
On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote:
> On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote:
> > On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote:
> > > + ret = sysfs_create_group(&led->hdev->dev.kobj, >683r_attribute_group);
> > > + if (ret) {
> > > +
On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote:
> On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote:
> > On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote:
> > > On Mon, Jun 23, 2014 at 08:16:48PM +0300, Janne Kanniainen wrote:
> > > > + ret = sysfs_create_group(&led
On Mon, Jun 23, 2014 at 03:40:59PM -0400, Greg KH wrote:
> On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote:
> > On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote:
> > > On Mon, Jun 23, 2014 at 02:23:24PM -0400, Greg KH wrote:
> > > > On Mon, Jun 23, 2014 at 08:16:48PM +0300, Jann
On Mon, Jun 23, 2014 at 09:52:12PM +0200, Johan Hovold wrote:
> On Mon, Jun 23, 2014 at 03:40:59PM -0400, Greg KH wrote:
> > On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote:
> > > On Mon, Jun 23, 2014 at 02:24:32PM -0400, Greg KH wrote:
> > > > On Mon, Jun 23, 2014 at 02:23:24PM -0400,
On Mon, Jun 23, 2014 at 04:24:48PM -0400, Greg KH wrote:
> On Mon, Jun 23, 2014 at 09:52:12PM +0200, Johan Hovold wrote:
> > On Mon, Jun 23, 2014 at 03:40:59PM -0400, Greg KH wrote:
> > > On Mon, Jun 23, 2014 at 09:31:34PM +0200, Johan Hovold wrote:
> > > > On Mon, Jun 23, 2014 at 02:24:32PM -0400,
On Sun, Jun 22, 2014 at 7:33 AM, Alan Stern wrote:
> On Sun, 22 Jun 2014, Wang, Yu wrote:
>
>> From: "Wang, Yu"
>>
>> The system suspend flow as following:
>> 1, Freeze all user processes and kenrel threads.
>>
>> 2, Trying to suspend all devices.
>>
>> 2.1, If pci device under RPM suspended stat
On Fri, 2014-06-20 at 23:10 +, Paul Zimmerman wrote:
> > From: dingu...@altera.com [mailto:dingu...@altera.com]
> > Sent: Friday, June 20, 2014 8:35 AM
> >
> > From: Dinh Nguyen
> >
> > Apologies for the noise, but I got Paul Zimmerman's address wrong on the
> > first send.
> >
> > Hi,
> >
> From: Dinh Nguyen [mailto:dingu...@altera.com]
> Sent: Monday, June 23, 2014 3:44 PM
>
> On Fri, 2014-06-20 at 23:10 +, Paul Zimmerman wrote:
...
>> Also, please do not post a patch series titled "[PATCH]" if you know
>> that it should not be applied as-is. At least put an "RFC" in there s
sorry for the delay.
Won't you need to add some GPIOLIB logic to the Kconfig entry for this
driver?
I don't think so. As far as I understand, the standard approach is to
make sure that the driver with optional GPIOs works well with no GPIOLIB
selected.
Examples: tty/serial/max310x.c, input/tou
Hi Robert,
When I trace the s3c-gadget driver, I found that the driver did not use
DMA mode because of the 32bit align problem. Have you solved this
problem ? I think just do one more time copy when meet the unalign
buffer address can make the DMA mode work correctly. Does any body have
more sugge
Please do not post updated patches in this way.
Instead, make a new, fresh, list posting with a formal commit
message and signoff just as you would otherwise properly submit
a new change.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...
Hi,
On Sat, Jun 7, 2014 at 4:22 AM, Thierry Reding wrote:
> On Fri, Jun 06, 2014 at 06:32:42PM +0530, Vivek Gautam wrote:
>> On Wed, Jun 4, 2014 at 6:43 PM, Thierry Reding
>> wrote:
>> > On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote:
>> >> On Sat, May 10, 2014 at 5:30 PM, Vivek
Hello,
On 2014-06-23 20:40, Paul Zimmerman wrote:
From: Robert Baldyga [mailto:r.bald...@samsung.com]
Sent: Monday, June 23, 2014 12:51 AM
From: Marek Szyprowski
Print warning if FIFOs are configured in such a way that they don't fit
into the SPRAM available on the s3c hsotg module.
Signed-o
Hi,
On Tue, Jun 10, 2014 at 1:52 AM, Julius Werner wrote:
>> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
>> index 9ffecd5..453d89e 100644
>> --- a/drivers/usb/host/xhci.h
>> +++ b/drivers/usb/host/xhci.h
>> @@ -1582,6 +1582,9 @@ struct xhci_hcd {
>> u32
Ping
Thanks,
Sundeep.B.S.
On Tue, Jun 10, 2014 at 5:34 PM, wrote:
> From: Subbaraya Sundeep Bhatta
>
> Add devicetree bindings for Xilinx axi udc driver.
>
> Signed-off-by: Subbaraya Sundeep Bhatta
> ---
> Changes for v3:
> - None
> Changes for v2:
> - replaced xlnx,include-dm
62 matches
Mail list logo
