Re: [PATCH 5/5] usb: gadget: net2280: Use pr_* function

Hello Alan I really think that setting/unsetting DEBUG and VERBOSE is not a good idea, and the generic functions are there to be used. What do you think that makes it more difficult to read? The GETDEV macro? Cheers On Mon, May 19, 2014 at 9:44 PM, Alan Stern wrote: > On Mon, 19 May 2014, Rica

Re: [PATCH 2/5] usb: gadget: net2280: Use S_I macros

On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote: > Hello Alan > > What about using octal notation in all the file and merge the patch > with the other big patch of the series? I am trying to have some > consistency in the file :) Program files don't have to be consistent. You shouldn't waste

Re: [PATCH 5/5] usb: gadget: net2280: Use pr_* function

On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote: > Hello Alan > > I really think that setting/unsetting DEBUG and VERBOSE is not a good > idea, and the generic functions are there to be used. You could change the definitions of DEBUG and VDEBUG to make them use the generic functions. > What

Re: [PATCH 5/5] usb: gadget: net2280: Use pr_* function

On Mon, 2014-05-19 at 16:17 -0400, Alan Stern wrote: > On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote: > > I really think that setting/unsetting DEBUG and VERBOSE is not a good > > idea, and the generic functions are there to be used. > You could change the definitions of DEBUG and VDEBUG to ma

[patch] usb: phy: msm: fix bug in probe()

My previous patch introduced a bug which prevented this driver from loading. devm_ioremap_resource() has a call to devm_request_mem_region() which will fail because the address space is shared between this PHY driver and CI device controller driver. Fixes: 10f0577aa5cb ('usb: phy: msm: change dev

Re: [PATCH 5/5] usb: gadget: net2280: Use pr_* function

Good idea. I am going to define ep_* and use them. btw, DEBUG cannot be used if not unset, because there is a namespace collision. Regards! On Mon, May 19, 2014 at 10:29 PM, Joe Perches wrote: > On Mon, 2014-05-19 at 16:17 -0400, Alan Stern wrote: >> On Mon, 19 May 2014, Ricardo Ribalda Del

[PATCH 8/9 v2] usb: gadget: net2280: Code Cleanup

- Move logical continuations to end of line - Improve spacing v2: Comments by Alan Stern -Use octal notation istead of S_I Signed-off-by: Ricardo Ribalda Delgado --- drivers/usb/gadget/net2280.c | 155 +-- drivers/usb/gadget/net2280.h | 4 +- 2

[PATCH 2/9] usb: gadget: net2280: Dont use magic numbers

Instead of using magic numbers use #defines Signed-off-by: Ricardo Ribalda Delgado --- drivers/usb/gadget/net2280.c | 68 +++- drivers/usb/gadget/net2280.h | 1 + 2 files changed, 36 insertions(+), 33 deletions(-) diff --git a/drivers/usb/gadget/net2280.

[PATCH 6/9] usb: gadget: net2280: Refactor queues_show

Replace a long and ugly expresion with an already available function. Signed-off-by: Ricardo Ribalda Delgado --- drivers/usb/gadget/net2280.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index bd851de..c

[PATCH 3/9] usb: gadget: net2280: Use BIT() macro

Improves readability of the code Signed-off-by: Ricardo Ribalda Delgado --- drivers/usb/gadget/net2280.c | 572 +-- drivers/usb/gadget/net2280.h | 65 ++--- 2 files changed, 318 insertions(+), 319 deletions(-) diff --git a/drivers/usb/gadget/net2280.c b/

[PATCH 9/9 v2] usb: gadget: net2280: Use pr_* function

Driver was using custom functions WARNING, ERROR, DEBUG, instead of pr_err, pr_dgb... New ep_* macros have been created that use standard pr_* functions. v2: Comment by Joe Perches and Alan Stern -Use ep_* instead of custom DETDEV macro Signed-off-by: Ricardo Ribalda Delgado --- drivers/usb

[PATCH 5/9] usb: gadget: net2280: Use module_pci_driver macro

Signed-off-by: Ricardo Ribalda Delgado --- drivers/usb/gadget/net2280.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index b43725a..bd851de 100644 --- a/drivers/usb/gadget/net2280.c +++ b/drive

[PATCH 4/9] usb: gadget: net2280: Use true/false instead of 1/0

For bool variables Signed-off-by: Ricardo Ribalda Delgado --- drivers/usb/gadget/net2280.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index 5b9368d..b43725a 100644 --- a/drivers/usb/gadget/net2280.c +++

[PATCH 0/9] net2280: Support for PLX USB338x and cleanout code

The USB 3380 is a PCI Express Gen 2 to USB 3.0 SuperSpeed Peripheral Controller. It shares a lot functionatily with the net228x family. This series of patches includes some resend of previous patches. Please check the changelog for every patch. Ricardo Ribalda Delgado (9): usb: gadget: net2280

Re: [PATCH 0/9] net2280: Support for PLX USB338x and cleanout code

Hello I have just realized that I havent moved the changleg information under the tear line. I will resend the patchset with this fixed once I have received comments about this patchset. Sorry and thanks for your patience. On Mon, May 19, 2014 at 11:20 PM, Ricardo Ribalda Delgado wrote: > The

Re: [PATCH 0/4] Add Gadget Bus

On Mon, May 19, 2014 at 05:40:29PM +0200, Andrzej Pietrasiewicz wrote: > Hi Peter, > > W dniu 16.05.2014 11:00, Peter Chen pisze: > >Hi Felipe & Alan, > > > >To continue with topic discussed at > >http://www.spinics.net/lists/linux-usb/msg105279.html, > >I implement the gadget bus to bind udc to g

Re: [PATCH 03/10] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

On Mon, May 12, 2014 at 06:01:02PM +0300, Mathias Nyman wrote: > On 05/08/2014 07:21 PM, Dan Williams wrote: > > On Thu, May 8, 2014 at 9:25 AM, Mathias Nyman > > wrote: > >> From: Dan Williams > >> > >> Save someone else the debug cycles of figuring out why a driver's > >> transfer request is fa

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

On Thu, May 08, 2014 at 07:25:55PM +0300, Mathias Nyman wrote: > From: Dan Williams > > Add a command line switch for disabling ehci port switchover. Useful > for working around / debugging xhci incompatibilities where ehci > operation is available. > > Reference: http://marc.info/?l=linux-usb&

Re: [PATCH 00/10] xhci: features for usb-next

On Thu, May 08, 2014 at 07:25:53PM +0300, Mathias Nyman wrote: > Hi Greg > > These following xhci patches are for usb-next and hopefully for 3.16 > > This patcheseries includes a bigger change in xhci command queue code, > (last four patches), a task that I've been working on for a longer time. >

Re: [PATCH 0/4] Add Gadget Bus

On Mon, May 19, 2014 at 10:44:09AM -0500, Felipe Balbi wrote: > On Mon, May 19, 2014 at 05:40:29PM +0200, Andrzej Pietrasiewicz wrote: > > Hi Peter, > > > > W dniu 16.05.2014 11:00, Peter Chen pisze: > > >Hi Felipe & Alan, > > > > > >To continue with topic discussed at > > >http://www.spinics.net/

Re: [PATCH v4 1/6] usb: musb: core: Handle Babble condition only in HOST mode

Hi Bin, On 5/19/2014 9:24 PM, Bin Liu wrote: Hi, On Mon, May 19, 2014 at 8:39 AM, George Cherian wrote: BABBLE and RESET share the same interrupt. The interrupt is considered to be RESET if MUSB is in peripheral mode and as a BABBLE if MUSB is in HOST mode. Handle babble condition iff MUSB is

ASMedia AS2105 interface on USB 3.0 corrupts data

Hi, the use of the ASMedia AS2105 controller on USB 3.0 leads to the syslog being spammed with a lot of entries like this: usb 9-2: reset SuperSpeed USB device number 3 using xhci_hcd [ 232.682214] usb 9-2: Parent hub missing LPM exit latency info. Power management will be impacted. [ 232.6834

Re: [PATCH 0/4] Add Gadget Bus

Hi Peter, W dniu 20.05.2014 01:38, Peter Chen pisze: On Mon, May 19, 2014 at 05:40:29PM +0200, Andrzej Pietrasiewicz wrote: Hi Peter, W dniu 16.05.2014 11:00, Peter Chen pisze: Hi Felipe & Alan, To continue with topic discussed at http://www.spinics.net/lists/linux-usb/msg105279.html, I impl

Re: [PATCH 0/4] Add Gadget Bus

On Tue, May 20, 2014 at 08:25:41AM +0200, Andrzej Pietrasiewicz wrote: > Hi Peter, > > W dniu 20.05.2014 01:38, Peter Chen pisze: > >On Mon, May 19, 2014 at 05:40:29PM +0200, Andrzej Pietrasiewicz wrote: > >>Hi Peter, > >> > >>W dniu 16.05.2014 11:00, Peter Chen pisze: > >>>Hi Felipe & Alan, > >>>

<    1   2