Re: Fw: [Bug 75001] New: belkin USB Ethernet adapter intermittent network issue

2014-04-29 Thread Petko Manolov
On 14-04-28 20:16:12, Greg KH wrote: > On Mon, Apr 28, 2014 at 05:28:38PM -0700, Stephen Hemminger wrote: > > Kernel Version: 3.0.94 > > That is a many year old obsolete kernel, there's nothing we can do about > that release, sorry. Please try 3.14 I've fixed a few important bugs in 3.10 so

Re: [PATCH v2 3/7] phy: omap-usb2: Use generic clock names "wkupclk" and "refclk"

2014-04-29 Thread Roger Quadros
+Nishant Hi, On 04/28/2014 07:03 PM, Felipe Balbi wrote: > Hi, > > On Mon, Apr 28, 2014 at 05:01:23PM +0300, Roger Quadros wrote: >> As clocks might be named differently on multiple platforms, use a generic >> name in the driver and allow device tree node to specify the platform >> specific cloc

Re: [PATCH v2 5/7] phy: omap-usb2: Add clock names to Documentation binding

2014-04-29 Thread Roger Quadros
Hi Sergei, On 04/28/2014 08:23 PM, Sergei Shtylyov wrote: > Hello. > > On 04/28/2014 06:01 PM, Roger Quadros wrote: > >> Add "wkupclk" and "refclk" information to DT binding information. > >> Signed-off-by: Roger Quadros >> --- >> Documentation/devicetree/bindings/phy/ti-phy.txt | 7 +++

RE: [PATCH v8 08/18] usb: make usb_port flags atomic

2014-04-29 Thread David Laight
From: Dan Williams > Before we add another 2 bitfields to the port state, convert it to an > unsigned long and use bitops helpers to manipulate it. This later > enables setting bits to request action without worrying about colliding > updates. In particular, a flag to request that the child devic

Re: [PATCH] usb: dwc3: debugfs: add snapshot to dump requests trbs events

2014-04-29 Thread Zhuang Jin Can
On Mon, Apr 28, 2014 at 10:55:36AM -0500, Felipe Balbi wrote: > On Mon, Apr 28, 2014 at 04:49:23PM -0400, Zhuang Jin Can wrote: > > Adds a debugfs file "snapshot" to dump dwc3 requests, trbs and events. > > you need to explain what are you trying to provide to our users here. > > What "problem" a

[RFC] usb: storage: shuttle_usbat: fix discs being detected twice

2014-04-29 Thread Daniele Forsi
Even if the USB-to-ATAPI converter supported multiple LUNs, this driver would always detect the same physical device or media because it doesn't use srb->device->lun in any way. Tested with an Hewlett-Packard CD-Writer Plus 8200e. Signed-off-by: Daniele Forsi --- drivers/usb/storage/shuttle_usba

Re: problem with resume after s2ram

2014-04-29 Thread Peter Münster
On Mon, Apr 28 2014, Alan Stern wrote: > That's interesting. Here's another test you should try with that same > kernel. Start moving the mouse before you wake up the system, and keep > moving it until the system has fully resumed. When you do this, does > it work right? That is, when the scre

Re: [PATCH v7 14/16] usb: resume (wakeup) child device when port is powered on

2014-04-29 Thread Alan Stern
On Mon, 28 Apr 2014, Dan Williams wrote: > > Can you include a brief description of situations in which this would > > be needed, i.e., when something would runtime-resume the port without > > also resuming the child device? Testing, sure, but not much else comes > > to mind. > > I guess it coul

RE: [PATCH v8 08/18] usb: make usb_port flags atomic

2014-04-29 Thread Alan Stern
On Tue, 29 Apr 2014, David Laight wrote: > From: Dan Williams > > Before we add another 2 bitfields to the port state, convert it to an > > unsigned long and use bitops helpers to manipulate it. This later > > enables setting bits to request action without worrying about colliding > > updates. I

Re: problem with resume after s2ram

2014-04-29 Thread Alan Stern
On Tue, 29 Apr 2014, Peter Münster wrote: > On Mon, Apr 28 2014, Alan Stern wrote: > > > That's interesting. Here's another test you should try with that same > > kernel. Start moving the mouse before you wake up the system, and keep > > moving it until the system has fully resumed. When you d

Re: [PATCH] usb: dwc3: debugfs: add snapshot to dump requests trbs events

2014-04-29 Thread Felipe Balbi
Hi, On Tue, Apr 29, 2014 at 05:21:42PM -0400, Zhuang Jin Can wrote: > On Mon, Apr 28, 2014 at 10:55:36AM -0500, Felipe Balbi wrote: > > On Mon, Apr 28, 2014 at 04:49:23PM -0400, Zhuang Jin Can wrote: > > > Adds a debugfs file "snapshot" to dump dwc3 requests, trbs and events. > > > > you need to

Re: [PATCH v2 2/2] usb: common: rename phy-fsm-usb.c to usb-otg-fsm.c

2014-04-29 Thread Felipe Balbi
On Tue, Apr 29, 2014 at 08:35:59AM +0800, Peter Chen wrote: > Since usb otg fsm implementation is not related to usb phy. > We move it from usb/phy/ to usb/common/, and rename it to > reflect its real meaning. > > Cc: Felipe Balbi > Signed-off-by: Peter Chen fine by me too, that's not related t

Re: [PATCH v2 1/2] usb: move usb/usb-common.c to usb/common/usb-common.c

2014-04-29 Thread Felipe Balbi
On Tue, Apr 29, 2014 at 08:35:58AM +0800, Peter Chen wrote: > Since we will have more usb-common things, and it will let > usb-common.c be larger and larger, we create a folder named usb/common > for all usb common things. > > Cc: Felipe Balbi > Signed-off-by: Peter Chen I'm ok with this if Gre

Re: [PATCH 1/3] usb: chipidea: udc: update gadget states according to ch9

2014-04-29 Thread Felipe Balbi
On Tue, Apr 29, 2014 at 01:26:27PM +0800, Peter Chen wrote: > Update device states according to ch9 in USB 2.0 specification > > Signed-off-by: Peter Chen Acked-by: Felipe Balbi > --- > drivers/usb/chipidea/udc.c | 10 -- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff

Re: [PATCH v2 3/7] phy: omap-usb2: Use generic clock names "wkupclk" and "refclk"

2014-04-29 Thread Felipe Balbi
On Tue, Apr 29, 2014 at 10:50:39AM +0300, Roger Quadros wrote: > +Nishant > > Hi, > > On 04/28/2014 07:03 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Apr 28, 2014 at 05:01:23PM +0300, Roger Quadros wrote: > >> As clocks might be named differently on multiple platforms, use a generic > >> nam

Re: [PATCH v2 3/7] phy: omap-usb2: Use generic clock names "wkupclk" and "refclk"

2014-04-29 Thread Felipe Balbi
On Tue, Apr 29, 2014 at 11:14:20AM -0500, Felipe Balbi wrote: > On Tue, Apr 29, 2014 at 10:50:39AM +0300, Roger Quadros wrote: > > +Nishant > > > > Hi, > > > > On 04/28/2014 07:03 PM, Felipe Balbi wrote: > > > Hi, > > > > > > On Mon, Apr 28, 2014 at 05:01:23PM +0300, Roger Quadros wrote: > > >>

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Mathias Nyman
On 04/29/2014 06:11 AM, Julius Werner wrote: *bump* Sarah, Mathias, can we decide how to proceed with this? I think the section Alan quoted is a pretty good argument in favor of my interpretation (although of course this would not be the first time that two sections of a spec contradict each oth

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Julius Werner
Okay, thanks, sounds good. I personally don't care that much about the stable backport. Let me respin this with a fixed commit message and the type change Felipe suggested. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

[PATCH v2] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Julius Werner
The current XHCI driver recalculates the Context Entries field in the Slot Context on every add_endpoint() and drop_endpoint() call. In the case of drop_endpoint(), it seems to assume that the add_flags will always contain every endpoint for the new configuration, which is not necessarily correct i

Re: [PATCH v8 08/18] usb: make usb_port flags atomic

2014-04-29 Thread Dan Williams
On Tue, Apr 29, 2014 at 8:14 AM, Alan Stern wrote: > On Tue, 29 Apr 2014, David Laight wrote: > >> From: Dan Williams >> > Before we add another 2 bitfields to the port state, convert it to an >> > unsigned long and use bitops helpers to manipulate it. This later >> > enables setting bits to requ

Re: [PATCH v7 14/16] usb: resume (wakeup) child device when port is powered on

2014-04-29 Thread Dan Williams
On Tue, Apr 29, 2014 at 8:12 AM, Alan Stern wrote: > On Mon, 28 Apr 2014, Dan Williams wrote: > >> > Can you include a brief description of situations in which this would >> > be needed, i.e., when something would runtime-resume the port without >> > also resuming the child device? Testing, sure,

Re: [PATCH v8 08/18] usb: make usb_port flags atomic

2014-04-29 Thread Alan Stern
On Tue, 29 Apr 2014, Dan Williams wrote: > > Another way to avoid the waste is to move the flags into the usb_hub > > structure. > > > > I don't see how that avoids waste? We need a long per flag. In the > struct usb_port we can combine status and requests in the same > storage. As it is, we h

Re: [PATCH v7 14/16] usb: resume (wakeup) child device when port is powered on

2014-04-29 Thread Alan Stern
On Tue, 29 Apr 2014, Dan Williams wrote: > > However, either way we still have bad interactions between > > hub_{quiesce|activate}() and usb_port_runtime_{suspend|resume}(). > > Consider, for example, what happens to the ports' power states when the > > hub is reset. > > > > You mean in terms of

Re: problem with resume after s2ram

2014-04-29 Thread Peter Münster
On Tue, Apr 29 2014, Alan Stern wrote: > It's noticeable that your logs include resets of the affected devices, > whereas the older kernels did not need any resets. This suggests that > these OHCI controllers will always have problems with global suspend, > and therefore a controller-specific fix

Re: [PATCH v7 14/16] usb: resume (wakeup) child device when port is powered on

2014-04-29 Thread Dan Williams
On Tue, Apr 29, 2014 at 12:25 PM, Alan Stern wrote: > On Tue, 29 Apr 2014, Dan Williams wrote: > >> > However, either way we still have bad interactions between >> > hub_{quiesce|activate}() and usb_port_runtime_{suspend|resume}(). >> > Consider, for example, what happens to the ports' power state

usblcd still valid? url update?

2014-04-29 Thread Karl P
I was turning off kernel options, and found the usblcd option, CONFIG_USB_LCD, under device drivers -> USB. The help text refers to a webpage for more information, http://www.usblcd.de but that website no longer exists. The wayback machine has it still existing in 2007, with the page indicat

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-29 Thread Vivek Gautam
Hi Kishon, Tomasz, On Mon, Apr 28, 2014 at 11:47 AM, Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > Thereby, removing old phy-samsu

Re: [PATCH v3 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
Hi, On Mon, Apr 28, 2014 at 9:11 PM, Alan Stern wrote: > On Mon, 28 Apr 2014, Vivek Gautam wrote: > >> Add support to consume phy provided by Generic phy framework. >> Keeping the support for older usb-phy intact right now, in order >> to prevent any functionality break in absence of relevant >>

[PATCH v10 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
From: Kamil Debski Add the phy provider, supplied by new Exynos-usb2phy using Generic phy framework. Keeping the support for older USB phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ehci-exynos. Once we move to new phy in the d

[PATCH v2 1/4] usb: ohci-exynos: Use struct device instead of platform_device

2014-04-29 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Cc: Alan Stern Acked-by: Jingoo Han --- Changes from v1: - none drivers/usb/host/ohci-exynos.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-)

[PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ohci-exynos. Once we move to new phy in the device nodes for ohci, we can remove the s

[PATCH v2 2/4] usb: ehci-exynos: Use struct device instead of platform_device

2014-04-29 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Cc: Alan Stern Acked-by: Jingoo Han --- Changes from v1: - none drivers/usb/host/ehci-exynos.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dri