Re: [PATCH v7 05/20] usb: phy: msm: Migrate to Managed Device Resource allocation

2014-04-28 Thread Ivan T. Ivanov
On Fri, 2014-04-25 at 15:53 -0500, Felipe Balbi wrote: > On Thu, Apr 24, 2014 at 01:49:38PM -0300, Fabio Estevam wrote: > > On Thu, Apr 24, 2014 at 12:48 PM, Ivan T. Ivanov wrote: > > > > > + motg->vddcx = devm_regulator_get(motg->phy.dev, "HSUSB_VDDCX"); > > > + if (IS_ERR(motg->vddc

Re: [PATCH v7 20/20] usb: phy: msm: Use usb_add_phy_dev() to register device

2014-04-28 Thread Ivan T. Ivanov
On Fri, 2014-04-25 at 15:53 -0500, Felipe Balbi wrote: > On Thu, Apr 24, 2014 at 09:06:24PM +0400, Sergei Shtylyov wrote: > > Hello. > > > > On 04/24/2014 07:48 PM, Ivan T. Ivanov wrote: > > > > >From: "Ivan T. Ivanov" > > > > >They could be more than one USB2.0 PHY's on the platform. > > > >

[PATCH 1/1] usb: core: remove the Kconfig entry for USB_DEBUG

2014-04-28 Thread Peter Chen
Since we have already removed the usage of CONFIG_USB_DEBUG, it is meaningless that there is still a configuration entry for CONFIG_USB_DEBUG. Signed-off-by: Peter Chen --- drivers/usb/core/Kconfig |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/usb/core/Kc

[PATCH v9 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-04-28 Thread Vivek Gautam
From: Kamil Debski Add the phy provider, supplied by new Exynos-usb2phy using Generic phy framework. Keeping the support for older USB phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ehci-exynos. Once we move to new phy in the d

[PATCH 2/4] usb: ehci-exynos: Use struct device instead of platform_device

2014-04-28 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Cc: Jingoo Han Cc: Alan Stern --- drivers/usb/host/ehci-exynos.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/dri

[PATCH v3 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-28 Thread Vivek Gautam
Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ohci-exynos. Once we move to new phy in the device nodes for ohci, we can remove the s

[PATCH 1/4] usb: ohci-exynos: Use struct device instead of platform_device

2014-04-28 Thread Vivek Gautam
Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam Cc: Jingoo Han Cc: Alan Stern --- drivers/usb/host/ohci-exynos.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/ohc

[PATCH v3 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-04-28 Thread Vivek Gautam
Based and tested on 'usb-next' branch of Greg's usb tree, with relevant device tree patches[1] Changes from v2: - Added two patches in the series for some cleanup. usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device

[PATCH v3 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-04-28 Thread Vivek Gautam
Based and tested on 'usb-next' branch of Greg's usb tree, with relevant device tree patches[1] Changes from v2: - Added two patches in the series for some cleanup. usb: ohci-exynos: Use struct device instead of platform_device usb: ehci-exynos: Use struct device instead of platform_device

RE: [PATCH 2/3] usb: dwc3: gadget: pretty print link states

2014-04-28 Thread David Laight
From: Felipe Balbi ... > +static const char *dwc3_gadget_link_string(enum dwc3_link_state link_state) > +{ > + switch (link_state) { > + case DWC3_LINK_STATE_U0: > + return "U0"; > + case DWC3_LINK_STATE_U1: > + return "U1"; > + case DWC3_LINK_STATE_U2: > +

Re: [PATCH v3 0/4] usb: ehci/ohci-exynos: Move to generic phy framework

2014-04-28 Thread Vivek Gautam
On Mon, Apr 28, 2014 at 2:55 PM, Vivek Gautam wrote: > Based and tested on 'usb-next' branch of Greg's usb tree, with relevant > device tree patches[1] [1] [PATCH v7 0/2] dts: Add usb2phy to Exynos 5250 http://www.spinics.net/lists/linux-usb/msg106427.html > > Changes from v2: > - Added t

Re: [PATCH v2 00/13] extcon: major rework

2014-04-28 Thread Robert Baldyga
On 04/24/2014 09:52 PM, Greg KH wrote: > On Mon, Apr 14, 2014 at 01:46:11PM +0200, Robert Baldyga wrote: >> This patchset adds many improvements to extcon class driver and extcon >> provider drivers. It changes extcon API to faster and safer by replaceing >> function taking extcon and cable names w

[PATCH 2/2] usb: common: rename phy-fsm-usb.c to usb-otg-fsm.c

2014-04-28 Thread Peter Chen
Since usb otg fsm implementation is not related to usb phy. We move it from usb/phy/ to usb/common/, and rename it to reflect its real meaning. Signed-off-by: Peter Chen --- drivers/usb/common/Makefile|1 + .../{phy/phy-fsm-usb.c => common/usb-otg-fsm.c}|0 dr

[PATCH 0/2] Re-organize usb common

2014-04-28 Thread Peter Chen
Hi Greg, This patch set creates usb/common for usb common things, and moves otg fsm implementation from usb/phy/ to usb/common/. I have a discussion with Felipe about it at below link: http://www.spinics.net/lists/linux-usb/msg106357.html Thanks. Peter Chen (2): usb: move usb/usb-common.c to u

[PATCH 1/2] usb: move usb/usb-common.c to usb/common/usb-common.c

2014-04-28 Thread Peter Chen
Since we will have more usb-common things, and it will let usb-common.c be larger and larger, we create a folder named usb/common for all usb common things. Signed-off-by: Peter Chen --- drivers/usb/Makefile |2 +- drivers/usb/common/Makefile |5 + drivers/

Re: [PATCH 1/4] usb: ohci-exynos: Use struct device instead of platform_device

2014-04-28 Thread Jingoo Han
On Monday, April 28, 2014 6:25 PM, Vivek Gautam wrote: > > Change to use struct device instead of struct platform_device > for some static functions. > > Signed-off-by: Vivek Gautam > Cc: Jingoo Han Acked-by: Jingoo Han Best regards, Jingoo Han > Cc: Alan Stern > --- > drivers/usb/host/oh

Re: [PATCH 2/4] usb: ehci-exynos: Use struct device instead of platform_device

2014-04-28 Thread Jingoo Han
On Monday, April 28, 2014 6:26 PM, Vivek Gautam wrote: > > Change to use struct device instead of struct platform_device > for some static functions. > > Signed-off-by: Vivek Gautam > Cc: Jingoo Han Acked-by: Jingoo Han Best regards, Jingoo Han > Cc: Alan Stern > --- > drivers/usb/host/eh

[PATCH] usb: remove redundant D0 power state set

2014-04-28 Thread Yijing Wang
Pci_enable_device() will set device power state to D0, so it's no need to do it again after call pci_enable_device(). Signed-off-by: Yijing Wang --- drivers/usb/core/hcd-pci.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/h

Re: /sys/bus/usb/devices

2014-04-28 Thread Mathias Nyman
On 04/27/2014 11:11 AM, John Freed wrote: I hope you don't mind me writing you directly, and if someone else can handle this better please let me know. I'm trying to do some backend work on libusb and I notice that the kernel keeps all the information on the Device Descriptors except for the v

Re: [PATCH v5] tools: usb: aio example applications

2014-04-28 Thread Robert Baldyga
Hi Felipe, Are you going to merge this examples, or should they be merged through another tree? Best regards Robert Baldyga Samsung R&D Institute Poland On 02/11/2014 11:43 AM, Robert Baldyga wrote: > This patch adds two example applications showing usage of Asynchronous I/O API > of FunctionFS.

Re: [PATCH 1/1] usb: core: remove the Kconfig entry for USB_DEBUG

2014-04-28 Thread Greg KH
On Mon, Apr 28, 2014 at 02:12:38PM +0800, Peter Chen wrote: > Since we have already removed the usage of CONFIG_USB_DEBUG, it is > meaningless that there is still a configuration entry for CONFIG_USB_DEBUG. We finally did it? Nice, I didn't realize that last bits were now gone, thanks for remindi

Re: [PATCH 3/4] dwc3: host: Set xhci lpm support quirk

2014-04-28 Thread Pratyush Anand
On Sat, Apr 26, 2014 at 02:10:21AM +0800, Felipe Balbi wrote: > On Fri, Apr 25, 2014 at 02:27:11PM +0530, Pratyush Anand wrote: > > On Tue, Apr 22, 2014 at 10:41:06PM +0800, Felipe Balbi wrote: > > > On Tue, Apr 22, 2014 at 10:46:13AM +0530, Pratyush Anand wrote: > > > > On Tue, Apr 22, 2014 at 12:

Re: [PATCH v2 0/4] xhci: fixes for 3.15-rc usb-linus

2014-04-28 Thread Mathias Nyman
On 04/25/2014 07:35 PM, Greg KH wrote: On Fri, Apr 25, 2014 at 07:20:12PM +0300, Mathias Nyman wrote: Hi Greg Second try at this xhci fixes series for 3.15-rc usb-linus. Most of them are very small fixes that didn't make it to 3.14, sitting and waiting for 3.15-rc1 to come out. Only the "Prefe

[PATCH v8 03/20] usb: phy: msm: Move global regulators variables to driver state

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Eliminating global variables allows driver to handle multiple device instances. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 82 --- include/linux/usb/msm_hsusb.h | 3 ++ 2 files changed, 42 insertions(+), 43

[PATCH v8 19/20] usb: phy: msm: Vote for corner of VDD CX instead of voltage of VDD CX

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" New platform uses RBCPR hardware feature, with that voting for absolute voltage of VDD CX is not required. Hence vote for corner of VDD CX which uses nominal corner voltage on VDD CX. Signed-off-by: Ivan T. Ivanov Cc: Mayank Rana --- .../devicetree/bindings/usb/msm-hsus

[PATCH v8 17/20] usb: phy: msm: Select secondary PHY via TCSR

2014-04-28 Thread Ivan T. Ivanov
From: Tim Bird Select the secondary PHY using the TCSR register, if phy-num=1 in the DTS (or phy_number is set in the platform data). The SOC has 2 PHYs which can be used with the OTG port, and this code allows configuring the correct one. Note: This resolves the problem I was seeing where I co

[PATCH v8 14/20] usb: phy: msm: Add support for secondary PHY control

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allow support to use 2nd HSPHY with USB2 Core. Some platforms may have configuration to allow USB controller work with any of the two HSPHYs present. By default driver configures USB core to use primary HSPHY. Add support to allow user select 2nd HSPHY using DT parameter.

[PATCH v8 02/20] usb: phy: msm: Remove __init macro from driver probe method

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes following: WARNING: drivers/usb/phy/built-in.o(.data+0x68): Section mismatch in reference from the variable msm_otg_driver to the function .init.text:msm_otg_probe() The variable msm_otg_driver references the function __init msm_otg_probe() Signed-off-by: Ivan

[PATCH v8 20/20] usb: phy: msm: Use usb_add_phy_dev() to register device

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" There could be more than one USB2.0 PHY's on the platform. This will allow all of them to be registered successfully. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy

[PATCH v8 18/20] usb: phy: msm: Handle disconnect events

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Put the transceiver in non-driving mode. Otherwise host may not detect soft-disconnection. Signed-off-by: Ivan T. Ivanov Cc: Pavankumar Kondeti --- drivers/usb/phy/phy-msm-usb.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/usb/phy/phy-

[PATCH v8 16/20] usb: phy: msm: Fix PTS definitions for MSM USB controller

2014-04-28 Thread Ivan T. Ivanov
From: Tim Bird Fix the value used for Parallel Transceiver Select (PTS) for the MSM USB controller. This is a standard chipidea PORTSC definition, where a PHY_TYPE of 10b (<<30) is ULPI and 11b (<<30) is SERIAL. Fix the definitions and use them correctly in the driver code. Signed-off-by: Tim B

[PATCH v8 09/20] usb: phy: msm: Remove unused pclk_src_name

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" There are no references to 'pclk_src_name' in plaform code, so it is unused. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 26 +- include/linux/usb/msm_hsusb.h | 5 - 2 files changed, 1 insertion(+), 30 deletions(-) diff

[PATCH v8 07/20] usb: phy: msm: Fix checkpatch.pl warnings

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes following: WARNING: quoted string split across lines WARNING: Prefer seq_puts to seq_printf Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 39 ++- 1 file changed, 14 insertions(+), 25 deletions(-) diff -

[PATCH v8 15/20] usb: phy: msm: Correct USB PHY Reset sequence for newer platform

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" On few legacy platforms, USB PHY is having dedicated reset clk. It is used to reset USB PHY after putting USB PHY into low power mode and for calibration of USB PHY. Putting USB PHY into low power mode is causing ulpi read/write timeout as expected. USB PHY reset clk is not

[PATCH v8 11/20] usb: phy: msm: Properly check result from platform_get_irq()

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Function return negative code on error. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index bd9e286..7e968aa 100644 --- a/d

Re: /sys/bus/usb/devices

2014-04-28 Thread Greg KH
On Mon, Apr 28, 2014 at 02:59:16PM +0300, Mathias Nyman wrote: > > > On 04/27/2014 11:11 AM, John Freed wrote: > > I hope you don't mind me writing you directly, and if someone else can > > handle this better please let me know. > > > > I'm trying to do some backend work on libusb and I notice th

[PATCH v8 05/20] usb: phy: msm: Migrate to Managed Device Resource allocation

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Move memory, regulators, clocks and irq allocation to devm_* variants. Properly check for valid clk handles. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 187 +++--- 1 file changed, 68 insertions(+), 119 deletions(

[PATCH v8 06/20] usb: phy: msm: Remove unnecessarily check for valid regulators.

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 10 -- 1 file changed, 10 deletions(-) dif

[PATCH v8 04/20] usb: phy: msm: Enable deferred driver probing

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Using platform_driver_probe() prevent driver from requesting probe deferral. Fix this. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/ph

[PATCH v8 08/20] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Use enum usb_dr_mode and drop default usb_dr_mode from platform data. USB DT bindings states: dr_mode: "...In case this attribute isn't passed via DT, USB DRD controllers should default to OTG...", so remove redundand field. Signed-off-by: Ivan T. Ivanov Acked-by: David

[PATCH v8 01/20] usb: phy: msm: Make driver selectable on ARCH_QCOM

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Controller could be found on APQ and MSM platforms, make configuration description more generic. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/

[PATCH v8 12/20] usb: phy: msm: Add device tree support and binding information

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows controller to be specified via device tree. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 67 drivers/usb/phy/phy-msm-usb.c | 113 + include/linux/usb/msm_hsusb.h

[PATCH v8 13/20] usb: phy: msm: Use reset framework for LINK and PHY resets

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Using reset framework eliminate need of platform specific callbacks and enable reset lines to be specified in DT files. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 29 + include/linux/usb/msm_hsusb.h | 3 +++ 2 files cha

[PATCH v8 00/20] usb: phy: msm: Fixes, cleanups and DT support

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This is a new version of patches posted earlier[1]. Changes since v7 - Use bulk regulator request function in patch #05 - Fix errors in patch #20 commit message [1] http://www.spinics.net/lists/linux-arm-msm/msg08997.html Ivan T. Ivanov (18): usb: phy: msm: Mak

[PATCH v8 10/20] usb: phy: msm: Remove HSUSB prefix from regulator names

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Prefix did not bring any useful information. Currently none of the MSM platforms define these regulators, so it is safe to rename them. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 2/7] ARM: DRA7: hwmod: Add SYSCONFIG for usb_otg_ss

2014-04-28 Thread Roger Quadros
Add the sysconfig class bits for the Super Speed USB controllers Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c ind

[PATCH v2 1/7] ARM: dts: dra7-clock: Add "l3init_960m_gfclk" clock gate

2014-04-28 Thread Roger Quadros
This clock gate description is missing in the older Reference manuals. It is present on the SoC to provide 960MHz reference clock to the internal USB PHYs. Reference: DRA75x_DRA74x_ES1.1_NDA_TRM_vO.pdf, pg. 900, Table 3-812. CM_COREAON_L3INIT_60M_GFCLK_CLKCTRL Use l3init_960m_gfclk as parent of u

[PATCH v2 5/7] phy: omap-usb2: Add clock names to Documentation binding

2014-04-28 Thread Roger Quadros
Add "wkupclk" and "refclk" information to DT binding information. Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/phy/ti-phy.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy

[PATCH v2 7/7] dts: dra7-evm: add USB support

2014-04-28 Thread Roger Quadros
Add USB pinmux information and USB modes for the USB controllers. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7-evm.dts | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts index 5babba0..1d77815 1

[PATCH v2 0/7] USB support for DRA7-evm

2014-04-28 Thread Roger Quadros
Hi, This series enables the 2 USB ports on the DRA7-evm. NOTE: USB1 port is hard coded to work in peripheral mode and USB2 port in host mode. This is due to missing ID pin interrupt in pre ver.E boards. USB1 port doesn't in peripheral mode out of the box due to missing VBUS detection and mailbo

[PATCH v2 6/7] ARM: dts: dra7: Add USB related nodes

2014-04-28 Thread Roger Quadros
Add nodes for the Super Speed USB controllers, omap-control-usb, USB2 PHY and USB3 PHY devices. Remove ocp2scp1 address space from hwmod data as it is now provided via device tree. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7.dtsi | 149 ++ a

[PATCH v2 4/7] ARM: dts: omap4+: Add clocks to USB2 PHY node

2014-04-28 Thread Roger Quadros
The USB2 PHY driver expects named clocks for wakeup clock and reference clock. Provide this information for USB2 PHY nodes in OMAP4 and OMAP5 SoC DTS. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap4.dtsi | 2 ++ arch/arm/boot/dts/omap5.dtsi | 2 ++ 2 files changed, 4 insertions(+) diff

[PATCH v2 3/7] phy: omap-usb2: Use generic clock names "wkupclk" and "refclk"

2014-04-28 Thread Roger Quadros
As clocks might be named differently on multiple platforms, use a generic name in the driver and allow device tree node to specify the platform specific clock name. Signed-off-by: Roger Quadros --- drivers/phy/phy-omap-usb2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --

Re: [PATCH v4 0/3] usb: chipidea: msm: Clean and fix glue layer driver

2014-04-28 Thread Ivan T. Ivanov
On Fri, 2014-04-25 at 03:10 +, Peter Chen wrote: > > > > > On Thu, 2014-04-24 at 08:38 +0800, Peter Chen wrote: > > > On Wed, Apr 23, 2014 at 03:28:01PM +0300, Ivan T. Ivanov wrote: > > > > From: "Ivan T. Ivanov" > > > > > > > > This series intend to fix driver, which was broken for a while

Re: [RESEND PATCHv5] usb: dwc2: Add function to calculate correct FIFO sizes

2014-04-28 Thread Dinh Nguyen
On 4/14/14 4:11 PM, dingu...@altera.com wrote: > From: Dinh Nguyen > > The dwc2 IP on the SOCFPGA cannot use the default HW configured > FIFO sizes. The total FIFO depth as read from GHWCFG3 reports 0x1f80 or 8064 > 32-bit words. But the GRXFSIZ, GNPTXFSIZ, and HPTXFSIZ register defaults > to 0x2

[PATCH] Nokia 5300 should be treated as unusual dev

2014-04-28 Thread Daniele Forsi
Signed-off-by: Daniele Forsi --- This patch depends on the patch sent by Victor A. Santos on April 27th with commit message "Nokia 305 should be treated as unusual dev". drivers/usb/storage/unusual_devs.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_dev

Re: what code calls the gadget composite driver's setup method?

2014-04-28 Thread Alan Stern
On Sun, 27 Apr 2014, Larry Martin wrote: > Alan is right, the code I wanted is in gadget/omap_udc.c. How/where is > that code linked? > > I put in some printks and do not get the output. My new printk strings > are not in g_printer.ko, but other strings from composite.c and > printer.c are t

Re: [PATCH 2/2] usb: common: rename phy-fsm-usb.c to usb-otg-fsm.c

2014-04-28 Thread Alan Stern
On Mon, 28 Apr 2014, Peter Chen wrote: > Since usb otg fsm implementation is not related to usb phy. > We move it from usb/phy/ to usb/common/, and rename it to > reflect its real meaning. > > Signed-off-by: Peter Chen > --- > drivers/usb/common/Makefile|1 + > .../{

Re: [PATCH] usb: remove redundant D0 power state set

2014-04-28 Thread Alan Stern
On Mon, 28 Apr 2014, Yijing Wang wrote: > Pci_enable_device() will set device power state to D0, > so it's no need to do it again after call pci_enable_device(). > > Signed-off-by: Yijing Wang > --- > drivers/usb/core/hcd-pci.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > d

Re: /sys/bus/usb/devices

2014-04-28 Thread Alan Stern
On Mon, 28 Apr 2014, Mathias Nyman wrote: > > > On 04/27/2014 11:11 AM, John Freed wrote: > > I hope you don't mind me writing you directly, and if someone else can > > handle this better please let me know. > > > > I'm trying to do some backend work on libusb and I notice that the > > kernel ke

Re: [PATCH v3 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-28 Thread Alan Stern
On Mon, 28 Apr 2014, Vivek Gautam wrote: > Add support to consume phy provided by Generic phy framework. > Keeping the support for older usb-phy intact right now, in order > to prevent any functionality break in absence of relevant > device tree side change for ohci-exynos. > Once we move to new p

Re: problem with resume after s2ram

2014-04-28 Thread Alan Stern
On Sat, 26 Apr 2014, Peter Münster wrote: > On Tue, Apr 22 2014, Alan Stern wrote: > > > Here's diag5; it's essentially a subset of diag4. Test it in the same > > way. > > > > (Not being able to wake up the system from the keyboard is expected > > for diag4. With diag5, you may or may not be ab

Re: [PATCH] usb: dwc3: debugfs: add snapshot to dump requests trbs events

2014-04-28 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 04:49:23PM -0400, Zhuang Jin Can wrote: > Adds a debugfs file "snapshot" to dump dwc3 requests, trbs and events. you need to explain what are you trying to provide to our users here. What "problem" are you trying to solve ? > As ep0 requests are more complex than others.

[PATCH] fsl-usb: do not test for PHY_CLK_VALID bit on controller version 1.6

2014-04-28 Thread Nikita Yushchenko
Per reference manuals of Freescale P1020 and P2020 SoCs, USB controller present in these SoCs has bit 17 of USBx_CONTROL register marked as Reserved - there is no PHY_CLK_VALID bit there. Testing for this bit in ehci_fsl_setup_phy() behaves differently on two P1020RDB boards available here - on on

Re: [PATCH v2 4/7] ARM: dts: omap4+: Add clocks to USB2 PHY node

2014-04-28 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 05:01:24PM +0300, Roger Quadros wrote: > The USB2 PHY driver expects named clocks for wakeup clock > and reference clock. Provide this information for USB2 PHY > nodes in OMAP4 and OMAP5 SoC DTS. > > Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi > --- > arch/a

Re: [PATCH v2 3/7] phy: omap-usb2: Use generic clock names "wkupclk" and "refclk"

2014-04-28 Thread Felipe Balbi
Hi, On Mon, Apr 28, 2014 at 05:01:23PM +0300, Roger Quadros wrote: > As clocks might be named differently on multiple platforms, use a generic > name in the driver and allow device tree node to specify the platform > specific clock name. > > Signed-off-by: Roger Quadros > --- > drivers/phy/phy-

Re: [PATCH v2 5/7] phy: omap-usb2: Add clock names to Documentation binding

2014-04-28 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 05:01:25PM +0300, Roger Quadros wrote: > Add "wkupclk" and "refclk" information to DT binding information. > > Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi > --- > Documentation/devicetree/bindings/phy/ti-phy.txt | 7 +++ > 1 file changed, 7 insertions(+)

Re: [PATCH v2 6/7] ARM: dts: dra7: Add USB related nodes

2014-04-28 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 05:01:26PM +0300, Roger Quadros wrote: > Add nodes for the Super Speed USB controllers, omap-control-usb, > USB2 PHY and USB3 PHY devices. > > Remove ocp2scp1 address space from hwmod data as it is > now provided via device tree. > > Signed-off-by: Roger Quadros Reviewed

Re: [PATCH 2/2] usb: common: rename phy-fsm-usb.c to usb-otg-fsm.c

2014-04-28 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 04:29:24PM +0800, Peter Chen wrote: > Since usb otg fsm implementation is not related to usb phy. > We move it from usb/phy/ to usb/common/, and rename it to > reflect its real meaning. > > Signed-off-by: Peter Chen > --- > drivers/usb/common/Makefile

Re: [PATCH v2 7/7] dts: dra7-evm: add USB support

2014-04-28 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 05:01:27PM +0300, Roger Quadros wrote: > Add USB pinmux information and USB modes > for the USB controllers. > > Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi > --- > arch/arm/boot/dts/dra7-evm.dts | 24 > 1 file changed, 24 insertions

Re: [PATCH] staging: octeon-usb: prevent memory corruption

2014-04-28 Thread Sergey Popov
24.03.2014 01:18, Aaro Koskinen пишет: > Hi, > > On Sat, Mar 22, 2014 at 01:13:52PM +0400, Sergey Popov wrote: >> scsi 0:0:0:0: Direct-Access SanDisk Cruzer Facet 1.26 PQ: 0 ANSI: 5 >> sd 0:0:0:0: [sda] 15633408 512-byte logical blocks: (8.00 GB/7.45 GiB) >> usb 1-1: reset high-speed USB

Re: [PATCH v8 02/20] usb: phy: msm: Remove __init macro from driver probe method

2014-04-28 Thread Ivan T. Ivanov
On Mon, 2014-04-28 at 12:03 -0500, Felipe Balbi wrote: > On Mon, Apr 28, 2014 at 09:00:43PM +0400, Sergei Shtylyov wrote: > > Hello. > > > > On 04/28/2014 05:34 PM, Ivan T. Ivanov wrote: > > > > >From: "Ivan T. Ivanov" > > > > >This fixes following: > > > > >WARNING: drivers/usb/phy/built-in.o

LOAN

2014-04-28 Thread Bakker, K.
Dear valued customer, Do you need an urgent loan to pay of your bills, invest more on your business, if yes PREMIUM CAPITAL LOAN offer loan at 3% interest rate. We are fast and reliable when it comes to loan lending contact email: premiumcapitall...@hotmail.co.uk for more information. Contact

Re: [RESEND PATCH v2] documentation: docbook: document process of writing an musb glue layer

2014-04-28 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 07:30:26PM +0200, Apelete Seketeli wrote: > Hi Felipe, > > On Mon, Apr-14-2014 at 10:12:56 PM +0200, Apelete Seketeli wrote: > > Document the process of writing an musb glue layer by taking the > > Ingenic JZ4740 glue layer as an example, as it seems more simple than > > mo

Re: [PATCH v8 02/20] usb: phy: msm: Remove __init macro from driver probe method

2014-04-28 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 08:52:48PM +0300, Ivan T. Ivanov wrote: > On Mon, 2014-04-28 at 12:03 -0500, Felipe Balbi wrote: > > On Mon, Apr 28, 2014 at 09:00:43PM +0400, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 04/28/2014 05:34 PM, Ivan T. Ivanov wrote: > > > > > > >From: "Ivan T. Ivanov"

Re: [PATCH v2 5/7] phy: omap-usb2: Add clock names to Documentation binding

2014-04-28 Thread Sergei Shtylyov
Hello. On 04/28/2014 06:01 PM, Roger Quadros wrote: Add "wkupclk" and "refclk" information to DT binding information. Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/phy/ti-phy.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bi

Re: [PATCH v7 12/16] usb: synchronize port poweroff and khubd

2014-04-28 Thread Dan Williams
On Mon, Apr 28, 2014 at 11:25 AM, Alan Stern wrote: > On Fri, 25 Apr 2014, Dan Williams wrote: > >> >> @@ -4892,11 +4897,17 @@ static void hub_events(void) >> >> >> >> /* deal with port status changes */ >> >> for (i = 1; i <= hdev->maxchild; i++) { >> >> +

Re: [PATCH v7 11/16] usb: refactor port handling in hub_events()

2014-04-28 Thread Alan Stern
On Fri, 25 Apr 2014, Dan Williams wrote: > > Here's a second question. I don't know if there's any definitive > > answer. What do you think of passing values like hdev, hcd, and > > port_dev as arguments, as opposed to re-deriving them from the other > > values? > > > > In theory, it could resul

Re: [PATCH v7 12/16] usb: synchronize port poweroff and khubd

2014-04-28 Thread Alan Stern
On Fri, 25 Apr 2014, Dan Williams wrote: > >> @@ -4892,11 +4897,17 @@ static void hub_events(void) > >> > >> /* deal with port status changes */ > >> for (i = 1; i <= hdev->maxchild; i++) { > >> + struct usb_port *port_dev = hub->ports[i - 1]; > >> +

Re: [PATCH v8 02/20] usb: phy: msm: Remove __init macro from driver probe method

2014-04-28 Thread Ivan T. Ivanov
On Mon, 2014-04-28 at 12:54 -0500, Felipe Balbi wrote: > On Mon, Apr 28, 2014 at 08:52:48PM +0300, Ivan T. Ivanov wrote: > > On Mon, 2014-04-28 at 12:03 -0500, Felipe Balbi wrote: > > > On Mon, Apr 28, 2014 at 09:00:43PM +0400, Sergei Shtylyov wrote: > > > > Hello. > > > > > > > > On 04/28/2014 05

[PATCH 0/3] uwb: formatting and compile warning fixes

2014-04-28 Thread Thomas Pugliese
This set contains a few fixes for formatting issues and compile warnings in UWB. Some of the changes for lines over 80 chars required pulling deeply nested code into separate functions which makes that patch look more significant than it really is. Thomas Pugliese (3): uwb: whitespace and li

[PATCH 3/3] uwb: fix variable set but not used warnings

2014-04-28 Thread Thomas Pugliese
Fix variable set but not used warnings in UWB. Signed-off-by: Thomas Pugliese --- drivers/uwb/beacon.c | 3 --- drivers/uwb/est.c| 2 -- drivers/uwb/ie-rcv.c | 2 -- 3 files changed, 7 deletions(-) diff --git a/drivers/uwb/beacon.c b/drivers/uwb/beacon.c index b476187..f40745f 100644 --- a/

[PATCH 2/3] uwb: comment typo fix

2014-04-28 Thread Thomas Pugliese
Comment typo fix. Signed-off-by: Thomas Pugliese --- drivers/uwb/radio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/uwb/radio.c b/drivers/uwb/radio.c index fd23d98..2427e94 100644 --- a/drivers/uwb/radio.c +++ b/drivers/uwb/radio.c @@ -115,7 +115,7 @@ int uwb_rad

[PATCH 1/3] uwb: whitespace and line length cleanups

2014-04-28 Thread Thomas Pugliese
Fix whitespace and line length issues reported by checkpatch. Signed-off-by: Thomas Pugliese --- drivers/uwb/drp.c | 294 ++ 1 file changed, 166 insertions(+), 128 deletions(-) diff --git a/drivers/uwb/drp.c b/drivers/uwb/drp.c index 468c89f..

Re: [RESEND PATCH v2] documentation: docbook: document process of writing an musb glue layer

2014-04-28 Thread Apelete Seketeli
Hi Felipe, On Mon, Apr-14-2014 at 10:12:56 PM +0200, Apelete Seketeli wrote: > Document the process of writing an musb glue layer by taking the > Ingenic JZ4740 glue layer as an example, as it seems more simple than > most glue layers due to the basic feature set of the JZ4740 USB device > control

RE: [PATCH] usb: dwc3: debugfs: add snapshot to dump requests trbs events

2014-04-28 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Monday, April 28, 2014 8:56 AM > > On Mon, Apr 28, 2014 at 04:49:23PM -0400, Zhuang Jin Can wrote: > > Adds a debugfs file "snapshot" to dump dwc3 requests, trbs and events. < sni

Re: what code calls the gadget composite driver's setup method?

2014-04-28 Thread Larry Martin
Alan and Rajaram, thanks for your help. I have not looked at Linux kernel builds in this detail before. I have been trying to recompile modules for the Linaro 3.5 kernel that we adopted last year. I can see now there is no choice but to start building kernels and modules together. I have

Re: [PATCH v7 14/16] usb: resume (wakeup) child device when port is powered on

2014-04-28 Thread Alan Stern
On Wed, 19 Mar 2014, Dan Williams wrote: > Unconditionally wake up the child device when the power session is > recovered. > > This address the following scenarios: > > 1/ The device may need a reset on power-session loss, without this >change port power-on recovery exposes khubd to scenario

Re: [PATCH v7 14/16] usb: resume (wakeup) child device when port is powered on

2014-04-28 Thread Dan Williams
On Mon, Apr 28, 2014 at 1:29 PM, Alan Stern wrote: > On Wed, 19 Mar 2014, Dan Williams wrote: > >> Unconditionally wake up the child device when the power session is >> recovered. >> >> This address the following scenarios: >> >> 1/ The device may need a reset on power-session loss, without this >

Re: [PATCH v7 14/16] usb: resume (wakeup) child device when port is powered on

2014-04-28 Thread Dan Williams
On Mon, Apr 28, 2014 at 2:00 PM, Dan Williams wrote: > On Mon, Apr 28, 2014 at 1:29 PM, Alan Stern wrote: >> On Wed, 19 Mar 2014, Dan Williams wrote: [..] >> But this got me thinking... It looks like the reference to >> port_dev->child in usb_port_runtime_resume() already races with the >> line

[PATCH v8 03/18] usb: cleanup setting udev->removable from port_dev->connect_type

2014-04-28 Thread Dan Williams
Once usb-acpi has set the port's connect type the usb_device's ->removable attribute can be set in the standard location set_usb_port_removable(). This also changes behavior in the case where the firmware says that the port connect type is unknown. In that case just use the default setting determ

[PATCH v8 01/18] usb: disable port power control if not supported in wHubCharacteristics

2014-04-28 Thread Dan Williams
A hub indicates whether it supports per-port power control via the wHubCharacteristics field in its descriptor. If it is not supported a hub will still emulate ClearPortPower(PORT_POWER) requests by stopping the link state machine. However, since this does not save power do not bother suspending.

[PATCH v8 00/18] port power control reworks

2014-04-28 Thread Dan Williams
Changes since v7 [1]: * Added patch 8 "usb: make usb_port flags atomic" * Added patch 15 "usb: hub_handle_remote_wakeup() depends on CONFIG_PM_RUNTIME=y" * Fixed patch 16 "usb: resume (wakeup) child device when port is powered on" - added USB_PORTDEV_WAKE flag to force usb_remote_wakeup() i

[PATCH v8 02/18] usb: rename usb_port device objects

2014-04-28 Thread Dan Williams
The current port name "portX" is ambiguous. Before adding more port messages rename ports to "-portX" This is an ABI change, but the suspicion is that it will go unnoticed as the port power control implementation has been broken since its introduction. If however, someone was relying on the old

[PATCH v8 05/18] usb: assign usb3 external hub port peers

2014-04-28 Thread Dan Williams
Given that root hub port peers are already established, external hub peer ports can be determined by traversing the device topology: 1/ ascend to the parent hub and find the upstream port_dev 2/ walk ->peer to find the peer port 3/ descend to the peer hub via ->child 4/ find the port with the m

[PATCH v8 06/18] usb: find internal hub tier mismatch via acpi

2014-04-28 Thread Dan Williams
ACPI identifies peer ports by setting their 'group_token' and 'group_position' _PLD data to the same value. If a platform has tier mismatch [1] , ACPI can override the default (USB3 defined) peer port association for internal hubs. External hubs follow the default peer association scheme. Locati

[PATCH v8 07/18] usb: sysfs link peer ports

2014-04-28 Thread Dan Williams
The usb topology after this change will have symlinks between usb3 ports and their usb2 peers, for example: usb2/2-1/2-1:1.0/2-1-port1/peer => ../../../../usb3/3-1/3-1:1.0/3-1-port1 usb2/2-1/2-1:1.0/2-1-port2/peer => ../../../../usb3/3-1/3-1:1.0/3-1-port2 usb2/2-1/2-1:1.0/2-1-port3/peer => ../../.

[PATCH v8 16/18] usb: resume (wakeup) child device when port is powered on

2014-04-28 Thread Dan Williams
Unconditionally wake up the child device when the power session is recovered. This address the following scenarios: 1/ The device may need a reset on power-session loss, without this change port power-on recovery exposes khubd to scenarios that usb_port_resume() is set to handle. Prior to

[PATCH v8 10/18] usb: don't clear FEAT_C_ENABLE on usb_port_runtime_resume failure

2014-04-28 Thread Dan Williams
Three reasons: 1/ It's an invalid operation on usb3 ports 2/ There's no guarantee of when / if a usb2 port has entered an error state relative to PORT_POWER request 3/ The port is active / powered at this point, so khubd will clear it as a matter of course Acked-by: Alan Stern Signed-off-by

[PATCH v8 08/18] usb: make usb_port flags atomic

2014-04-28 Thread Dan Williams
Before we add another 2 bitfields to the port state, convert it to an unsigned long and use bitops helpers to manipulate it. This later enables setting bits to request action without worrying about colliding updates. In particular, a flag to request that the child device be woken up when the port

  1   2   >