Fixed the product id typo and replace whitespace with tab.
Signed-off-by: AceLan Kao
---
drivers/usb/serial/sierra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index a9eb622..b78fd4e 100644
--- a/drivers/usb/seria
This patch adds support for Dell Computer Corp. Wireless 5808e 4G LTE
Mobile Broadband Card.
Signed-off-by: AceLan Kao
---
drivers/usb/serial/sierra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index b78fd4e..961d586 100644
--- a
Hello Hans de Goede,
The patch e36e64930cff: "uas: Use GFP_NOIO rather then GFP_ATOMIC
where possible" from Nov 7, 2013, leads to the following static
checker warning:
drivers/usb/storage/uas.c:806 uas_eh_task_mgmt()
error: scheduling with locks held: 'spin_lock:lock'
drivers/usb
From: Oliver Neukum
Quote Dan:
The patch e36e64930cff: "uas: Use GFP_NOIO rather then GFP_ATOMIC
where possible" from Nov 7, 2013, leads to the following static
checker warning:
drivers/usb/storage/uas.c:806 uas_eh_task_mgmt()
error: scheduling with locks held: 'spin_lock:lock'
Hi,
On 03/28/2014 09:45 AM, oli...@neukum.org wrote:
> From: Oliver Neukum
>
> Quote Dan:
>
> The patch e36e64930cff: "uas: Use GFP_NOIO rather then GFP_ATOMIC
> where possible" from Nov 7, 2013, leads to the following static
> checker warning:
>
> drivers/usb/storage/uas.c:806 uas_eh_
Hi Laurent,
I have a few comments:
On 03/23/2014 04:32 PM, Laurent Pinchart wrote:
> The wall time clock isn't useful for applications as it can jump around
> due to time adjustement. Switch to the monotonic clock.
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/usb/gadget/uvc_queue.c | 12
On 03/23/2014 04:32 PM, Laurent Pinchart wrote:
> The vb2 queue timestamp_flags field must be set by drivers, as enforced
> by a WARN_ON in vb2_queue_init. The UVC gadget driver failed to do so.
> This resulted in the following warning.
>
> [2.104371] g_webcam gadget: uvc_function_bind
> [
From: Oliver Neukum
There is an allocation with GFP_NOIO with a spinlock
held that the checker didn't catch.
There are also two allocations with GFP_KERNEL in the pre-/post_reset
code paths. That is no good because that is a part of the SCSI error handler.
Signed-off-by: Oliver Neukum
---
driv
On Wed, Mar 26, 2014 at 08:43:09PM +, Sanders, Aaron wrote:
> Hi Johan,
>
> I found you name on the list of Maintainers for Linux for
> "drivers/usb/serial/". I have never submitted change before so I am
> looking for your help. I would like to submit a very simple patch to
> add some USB I
Hans,
it seems to me that there is a problem.
uas_pre_reset() calls flush_work(). uas_do_work(), however
can reschedule itself if usb_submit_urb() fails. That opens
up the possibility that there's a permanent problem with
the device which causes an attempt to reset it and makes
usb_submit_urb() f
Hi,
On 03/28/2014 10:27 AM, oli...@neukum.org wrote:
> From: Oliver Neukum
>
> There is an allocation with GFP_NOIO with a spinlock
> held that the checker didn't catch.
ACK, my bad. When I wrote this commit:
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/usb/sto
[ +CC: Dan and Bjørn ]
On Fri, Mar 28, 2014 at 03:25:06PM +0800, AceLan Kao wrote:
> This patch adds support for Dell Computer Corp. Wireless 5808e 4G LTE
> Mobile Broadband Card.
Shouldn't this device be handled by the option driver?
In fact, PID 0x8133 for 5720 VZW (which your clean-up patch t
Hi,
On 03/28/2014 10:45 AM, Oliver Neukum wrote:
> Hans,
>
> it seems to me that there is a problem.
>
> uas_pre_reset() calls flush_work(). uas_do_work(), however
> can reschedule itself if usb_submit_urb() fails. That opens
> up the possibility that there's a permanent problem with
> the devic
From: Oliver Neukum
Quote Dan:
The patch e36e64930cff: "uas: Use GFP_NOIO rather then GFP_ATOMIC
where possible" from Nov 7, 2013, leads to the following static
checker warning:
drivers/usb/storage/uas.c:806 uas_eh_task_mgmt()
error: scheduling with locks held: 'spin_lock:lock'
Hi,
On 03/28/2014 11:10 AM, oli...@neukum.org wrote:
> From: Oliver Neukum
>
> Quote Dan:
>
> The patch e36e64930cff: "uas: Use GFP_NOIO rather then GFP_ATOMIC
> where possible" from Nov 7, 2013, leads to the following static
> checker warning:
>
> drivers/usb/storage/uas.c:806 uas_eh_
From: Oliver Neukum
There is an allocation with GFP_NOIO with a spinlock
held that the checker didn't catch.
There are also two allocations with GFP_KERNEL in the pre-/post_reset
code paths. That is no good because that is a part of the SCSI error handler.
Signed-off-by: Oliver Neukum
---
driv
On Tue, Mar 25, 2014 at 07:00:51PM +, Michele Baldessari wrote:
> Custom VID/PID for Brainboxes VX-001 ExpressCard RS232 as reported in
> https://bugzilla.redhat.com/show_bug.cgi?id=1071914
Thanks for the patch.
How about including the other PIDs listed in the report (in the attached
udev-ru
Hi,
On 03/28/2014 11:14 AM, oli...@neukum.org wrote:
> From: Oliver Neukum
>
> There is an allocation with GFP_NOIO with a spinlock
> held that the checker didn't catch.
I hate to be a PITA, but this above part of the commit message is no longer
correct, can you amend the commit message and res
From: Oliver Neukum
There are also two allocations with GFP_KERNEL in the pre-/post_reset
code paths. That is no good because that is a part of the SCSI error handler.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
Johan Hovold writes:
> [ +CC: Dan and Bjørn ]
>
> On Fri, Mar 28, 2014 at 03:25:06PM +0800, AceLan Kao wrote:
>> This patch adds support for Dell Computer Corp. Wireless 5808e 4G LTE
>> Mobile Broadband Card.
>
> Shouldn't this device be handled by the option driver?
>
> In fact, PID 0x8133 for 5
From: Oliver Neukum
intfdata is set only after scsi_scan(). uas_pre_reset() however
needs intfdata to be valid and will follow the NULL pointer
killing khubd. intfdata must be preemptively set before the
host is registered and undone in the error case.
Signed-off-by: Oliver Neukum
---
drivers/
On Fri, 2014-03-28 at 11:15 +0100, Hans de Goede wrote:
> Hi,
>
> On 03/28/2014 11:14 AM, oli...@neukum.org wrote:
> > From: Oliver Neukum
> >
> > There is an allocation with GFP_NOIO with a spinlock
> > held that the checker didn't catch.
>
> I hate to be a PITA, but this above part of the com
Hi,
On 03/28/2014 11:29 AM, oli...@neukum.org wrote:
> From: Oliver Neukum
>
> intfdata is set only after scsi_scan(). uas_pre_reset() however
> needs intfdata to be valid and will follow the NULL pointer
> killing khubd. intfdata must be preemptively set before the
> host is registered and undo
Hi Hans,
On Friday 28 March 2014 09:50:42 Hans Verkuil wrote:
> On 03/23/2014 04:32 PM, Laurent Pinchart wrote:
> > The wall time clock isn't useful for applications as it can jump around
> > due to time adjustement. Switch to the monotonic clock.
> >
> > Signed-off-by: Laurent Pinchart
> > ---
On 03/27/2014 12:31 PM, Keerthy V wrote:
Hi,
I am trying to send data to a USB device connected to a USB3.0 port over a USB
bulk end point using libusb APIs . It is failing failed with error ERROR_IO.
The same device and the test program works fine on a USB2.0 port.
After enabling the XHCI de
Hi,
I am looking at uas_disconnect() calling uas_free_streams()
unconditionally. I wonder what this does if a device has
morphed. It seems to me we'd try to free streams of endpoints
that might not even exist.
Regards
Oliver
--
To unsubscribe from this list: send the lin
Hi,
On 03/28/2014 01:53 PM, Oliver Neukum wrote:
> Hi,
>
> I am looking at uas_disconnect() calling uas_free_streams()
> unconditionally. I wonder what this does if a device has
> morphed. It seems to me we'd try to free streams of endpoints
> that might not even exist.
If a device morphs we wil
Add device ids to pl2303 for the Hewlett-Packard HP POS pole displays:
LD960: 03f0:0B39
LCM220: 03f0:3139
LCM960: 03f0:3239
Signed-off-by: Aaron Sanders
diff -uNr old/pl2303.c new/pl2303.c
--- old/pl2303.c2014-03-26 11:06:20.526852963 -0700
+++ new/pl2303.c2014-03-26 11:06:32.
On Fri, Mar 28, 2014 at 01:36:51PM +, Sanders, Aaron wrote:
> Add device ids to pl2303 for the Hewlett-Packard HP POS pole displays:
> LD960: 03f0:0B39
> LCM220: 03f0:3139
> LCM960: 03f0:3239
>
> Signed-off-by: Aaron Sanders
Almost there. :)
Please add a "USB: " prefix to the subject abo
On Thu, 27 Mar 2014, Peter Münster wrote:
> Hi Alan,
>
> These are my commands:
>
> echo 8 >/proc/sys/kernel/printk
> echo on >/sys/bus/usb/devices/4-2/power/control
> sleep 1
> echo 0 >/sys/bus/usb/devices/4-2/bConfigurationValue
> sleep 1
> echo auto >/sys/bus/pci/devices/:00:12.1/power/co
The wall time clock isn't useful for applications as it can jump around
due to time adjustement. Switch to the monotonic clock.
Signed-off-by: Laurent Pinchart
---
drivers/usb/gadget/uvc_queue.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
Changes since v1:
- Replace ktime_ge
Hi,
On Tue, Mar 25, 2014 at 11:42:43AM -0700, Julius Werner wrote:
> @@ -2723,8 +2697,19 @@ int xhci_check_bandwidth(struct usb_hcd *hcd, struct
> usb_device *udev)
> ctrl_ctx->drop_flags == 0)
> return 0;
>
> - xhci_dbg(xhci, "New Input Control Context:\
This reverts commit 1ebca9dad5abe8b2ed4dbd186cd657fb47c1f321.
This device was erroneously added to the sierra driver even though it's
not a Sierra device and was already handled by the option driver.
Cc: Richard Farina
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/usb/seri
On Thu, 2014-03-20 at 15:49 -0400, Alan Stern wrote:
> On Thu, 20 Mar 2014, James Bottomley wrote:
>
> > On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote:
> > > On Thu, 20 Mar 2014, James Bottomley wrote:
> > >
> > > > OK, so I think we have three things to do
> > > >
> > > > 1. Investig
On 03/28/2014 05:02 PM, Laurent Pinchart wrote:
> The wall time clock isn't useful for applications as it can jump around
> due to time adjustement. Switch to the monotonic clock.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/usb/gadget/
option driver, added VID/PID for Telit UE910v2 modem
Signed-off-by: Daniele Palmas
---
drivers/usb/serial/option.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 68fc9fe..8811a5b 100644
--- a/drivers/usb/s
On Fri, Mar 28, 2014 at 05:02:46PM +0100, Laurent Pinchart wrote:
> The wall time clock isn't useful for applications as it can jump around
> due to time adjustement. Switch to the monotonic clock.
>
> Signed-off-by: Laurent Pinchart
Acked-by: Felipe Balbi
> ---
> drivers/usb/gadget/uvc_queue
On Fri, 2014-03-28 at 10:56 +0100, Johan Hovold wrote:
> [ +CC: Dan and Bjørn ]
>
> On Fri, Mar 28, 2014 at 03:25:06PM +0800, AceLan Kao wrote:
> > This patch adds support for Dell Computer Corp. Wireless 5808e 4G LTE
> > Mobile Broadband Card.
>
> Shouldn't this device be handled by the option d
On Fri, Mar 28, 2014 at 09:48:00AM +0100, Hans de Goede wrote:
> Hi,
>
> On 03/28/2014 09:45 AM, oli...@neukum.org wrote:
> > From: Oliver Neukum
> >
> > Quote Dan:
> >
> > The patch e36e64930cff: "uas: Use GFP_NOIO rather then GFP_ATOMIC
> > where possible" from Nov 7, 2013, leads to the follo
On Thu, Mar 27, 2014 at 02:40:23PM +0800, 刘磊 wrote:
> dear linuxfoundation:
"Linux Foundation" is a non-profit group, not a person :)
And please don't send HTML email, the mailing list rejects it.
> Because of the time difference, can not respond promptly.
That's not an issue, don't worry a
On Fri, Mar 28, 2014 at 11:25:23AM +0100, Bjørn Mork wrote:
> Johan Hovold writes:
> > [ +CC: Dan and Bjørn ]
> >
> > On Fri, Mar 28, 2014 at 03:25:06PM +0800, AceLan Kao wrote:
> >> This patch adds support for Dell Computer Corp. Wireless 5808e 4G LTE
> >> Mobile Broadband Card.
> >
> > Shouldn't
On 03/25/2014 08:42 PM, Julius Werner wrote:
The current XHCI driver recalculates the Context Entries field in the
Slot Context on every add_endpoint() and drop_endpoint() call. In the
case of drop_endpoint(), it seems to assume that the add_flags will
always contain every endpoint for the new co
On Fri, 2014-03-28 at 11:37 -0500, Dan Williams wrote:
> On Fri, 2014-03-28 at 15:25 +0800, AceLan Kao wrote:
> > Fixed the product id typo and replace whitespace with tab.
> >
> > Signed-off-by: AceLan Kao
> > ---
> > drivers/usb/serial/sierra.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 del
Hi,
I'm currently checking chipidea udc on our platform and I can see some
"freeing queued request" message (some bad behaviour from android adb
gadget driver).
After this message we exit without freeing anything :
static void ep_free_request(struct usb_ep *ep, struct usb_request *req)
{
(..
On Fri, 2014-03-28 at 11:25 +0100, Bjørn Mork wrote:
> Johan Hovold writes:
>
> > [ +CC: Dan and Bjørn ]
> >
> > On Fri, Mar 28, 2014 at 03:25:06PM +0800, AceLan Kao wrote:
> >> This patch adds support for Dell Computer Corp. Wireless 5808e 4G LTE
> >> Mobile Broadband Card.
> >
> > Shouldn't thi
This is a set of three patches we agreed to a while ago to eliminate a
USB deadlock. I did rewrite the first patch, if it could be reviewed
and tested.
Thanks,
James
---
Alan Stern (1):
[SCSI] Fix command result state propagation
James Bottomley (2):
[SCSI] Fix abort state memory problem
From: Alan Stern
We're seeing a case where the contents of scmd->result isn't being reset after
a SCSI command encounters an error, is resubmitted, times out and then gets
handled. The error handler acts on the stale result of the previous error
instead of the timeout. Fix this by properly zero
We unconditionally execute scsi_eh_get_sense() to make sure all failed
commands that should have sense attached, do. However, the routine forgets
that some commands, because of the way they fail, will not have any sense code
... we should not bother them with a REQUEST_SENSE command. Fix this by
The abort state is being stored persistently across commands, meaning if the
command times out a second time, the error handler thinks an abort is still
pending. Fix this by properly resetting the abort flag after the abort is
finished.
Signed-off-by: James Bottomley
---
drivers/scsi/scsi_error
The UVC gadget driver doesn't support interlaced video but left the
buffer field uninitialized. Set it to V4L2_FIELD_NONE.
Signed-off-by: Laurent Pinchart
---
drivers/usb/gadget/uvc_queue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/uvc_queue.c b/drivers/usb/gadget/uv
On Fri, Mar 28, 2014 at 05:02:48PM +0100, Laurent Pinchart wrote:
> The vb2 queue timestamp_flags field must be set by drivers, as enforced
> by a WARN_ON in vb2_queue_init. The UVC gadget driver failed to do so.
> This resulted in the following warning.
>
> [2.104371] g_webcam gadget: uvc_fun
The vb2 queue timestamp_flags field must be set by drivers, as enforced
by a WARN_ON in vb2_queue_init. The UVC gadget driver failed to do so.
This resulted in the following warning.
[2.104371] g_webcam gadget: uvc_function_bind
[2.105567] [ cut here ]
[2.105567
Hello,
These three patches fix miscellaneous issues in the UVC gadget driver. Patches
1 and 3 have already been posted as part of the "Clock fixes for UVC gadget
driver" series, and patch 2 is new.
The series is based on the latest media tree master branch as it depends on
commit 872484ce40881e29
On Thu, Mar 27, 2014 at 10:31:33AM +, Keerthy V wrote:
> Hi,
>
> I am trying to send data to a USB device connected to a USB3.0 port over a
> USB bulk end point using libusb APIs . It is failing failed with error
> ERROR_IO.
>
> The same device and the test program works fine on a USB2.0 po
> At least if
> you can verify that it still works on an LE system.
Yes your patch works on a LE system (tested on 3.2.55)
Thanks!
--
Ludovic Drolez.
http://www.aopensource.com - The Android Open Source Portal
http://www.drolez.com - Personal site - Linux and Free Software
Add device ids to pl2303 for the Hewlett-Packard HP POS pole displays:
LD960: 03f0:0B39
LCM220: 03f0:3139
LCM960: 03f0:3239
Signed-off-by: Aaron Sanders
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 3b5ba4f..4d70809 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/d
On 03/28/2014 05:02 PM, Laurent Pinchart wrote:
> The UVC gadget driver doesn't support interlaced video but left the
> buffer field uninitialized. Set it to V4L2_FIELD_NONE.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/usb/gadget/uvc_q
Hi,
On 03/28/2014 05:42 PM, Greg KH wrote:
> On Fri, Mar 28, 2014 at 09:48:00AM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 03/28/2014 09:45 AM, oli...@neukum.org wrote:
>>> From: Oliver Neukum
>>>
>>> Quote Dan:
>>>
>>> The patch e36e64930cff: "uas: Use GFP_NOIO rather then GFP_ATOMIC
>>> where
On Fri, Mar 28, 2014 at 07:39:19PM +0100, Hans de Goede wrote:
> Hi,
>
> On 03/28/2014 05:42 PM, Greg KH wrote:
> > On Fri, Mar 28, 2014 at 09:48:00AM +0100, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 03/28/2014 09:45 AM, oli...@neukum.org wrote:
> >>> From: Oliver Neukum
> >>>
> >>> Quote Dan:
>
On Fri, 2014-03-28 at 15:25 +0800, AceLan Kao wrote:
> Fixed the product id typo and replace whitespace with tab.
>
> Signed-off-by: AceLan Kao
> ---
> drivers/usb/serial/sierra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/
On Fri, 28 Mar 2014, James Bottomley wrote:
> This is a set of three patches we agreed to a while ago to eliminate a
> USB deadlock. I did rewrite the first patch, if it could be reviewed
> and tested.
I tested all three patches under the same conditions as before, and
they all worked correctly
Su contraseña caducará hoy para llenar formularios y enviar de inmediato para
validar su dirección de e-mail.
Nombre de usuario: .
Contraseña anterior: .
Nueva contraseña:
gracias
administrador del sistema
--
To unsubscribe from this list: send the
On Fri, Mar 28, 2014 at 05:02:47PM +0100, Laurent Pinchart wrote:
> The UVC gadget driver doesn't support interlaced video but left the
> buffer field uninitialized. Set it to V4L2_FIELD_NONE.
>
> Signed-off-by: Laurent Pinchart
Acked-by: Felipe Balbi
> ---
> drivers/usb/gadget/uvc_queue.c |
63 matches
Mail list logo
