Hi,
My external disk uses an external box with a Initio Corporation INIC-1618L SATA
chip.
vendor/product are : 0x13fd/0x0840
bcdDevice is 1.14 making the disk work very slowly 12Mb in spite of 10 times
faster.
bcdUSB seem to be ok : 2.00
Tried this on 3.13 and 3.14-rc6
Note that same disk with
During system resume, if the event buffers are not setup before
the gadget controller starts then we start with invalid context
and this can lead to bus access errors. This is especially true for
platforms that loose the controller context during system suspend.
e.g. AM437x.
The following backtrac
Pasi Kärkkäinen writes:
> http://pasik.reaktio.net/huawei-e3276-usbmon3.pcapng
>
> (I did move the dongle to a different usb bus nr 3 to make it the only device
> on that bus before capturing..)
Thanks. That helps.
> So what I did:
>
> - Start wireshark capture on USB bus nr 3.
> - Plug in t
Is this *really* driver material, or should we just leave the IP MTU
hint handling up to the userspace management application?
There are no less than 3(!) different ways for a device to specify the
MBIM MTU:
1) wMaxSegmentSize field of the "MBIM Control Model Functional
Descriptor"
(
On Mon, Mar 17, 2014 at 12:31:53PM +0100, Bjørn Mork wrote:
> Pasi Kärkkäinen writes:
>
> > http://pasik.reaktio.net/huawei-e3276-usbmon3.pcapng
> >
> > (I did move the dongle to a different usb bus nr 3 to make it the only
> > device on that bus before capturing..)
>
> Thanks. That helps.
>
On Mon, Mar 17, 2014 at 01:59:19PM +0200, Pasi Kärkkäinen wrote:
> On Mon, Mar 17, 2014 at 12:31:53PM +0100, Bjørn Mork wrote:
> > Pasi Kärkkäinen writes:
> >
> > > http://pasik.reaktio.net/huawei-e3276-usbmon3.pcapng
> > >
> > > (I did move the dongle to a different usb bus nr 3 to make it the o
Bjørn Mork writes:
> But here we have a device which does not comform to spec (that's OK,
> Huawei doesn't claim it does - this is a vendor specific function after
> all), and which seems to be locked to 32 bit mode? Either it requires
> the 32 bit variant, or we are doing something "wrong" duri
Bjørn Mork writes:
> But looking closer, I see that the SET_NTB_FORMAT returned -EPIPE,
> i.e. stall. The driver currently ignores this error, which is why we
> end up with different device and host settings.
>
> Anyone know what the proper driver action is? Note that this error
> cannot happen
Pasi Kärkkäinen writes:
> After playing with it for a while I got this:
>
> [ 1082.972880] cdc_ncm_setup: huawei_cdc_ncm 3-1:1.1: dwNtbInMaxSize=262144
> dwNtbOutMaxSize=32768 wNdpOutPayloadRemainder=2 wNdpOutDivisor=4
> wNdpOutAlignment=4 wNtbOutMaxDatagrams=0 flags=0x1f
> [ 1082.972893] cdc_n
On Mon, Mar 17, 2014 at 02:15:23PM +0100, Bjørn Mork wrote:
> Pasi Kärkkäinen writes:
>
> > After playing with it for a while I got this:
> >
> > [ 1082.972880] cdc_ncm_setup: huawei_cdc_ncm 3-1:1.1: dwNtbInMaxSize=262144
> > dwNtbOutMaxSize=32768 wNdpOutPayloadRemainder=2 wNdpOutDivisor=4
> >
On 03/14/2014 07:51 PM, dingu...@altera.com wrote:
> From: Dinh Nguyen
>
> Moves the s3c-hsotg driver into the dwc2 folder and use the dwc2 defines in
> hw.h. Renamed the s3c-hsotg.c to gadget.c.
>
> Signed-off-by: Dinh Nguyen
> Tested-by: Jingoo Han
> Tested-by: Paul Zimmerman
> Cc: Greg Kro
On 03/14/2014 07:51 PM, dingu...@altera.com wrote:
> From: Dinh Nguyen
>
> This patch moves the data structures that are in the s3c-hsotg source into
> core.h. This is a necessary step towards unifying the s3c-hsotg and dwc2 into
> a single DRD.
>
> Signed-off-by: Dinh Nguyen
> Tested-by: Jingo
On 03/14/2014 07:51 PM, dingu...@altera.com wrote:
> From: Dinh Nguyen
>
> Modify the dwc2 Kconfig and Makefile so that it will build the dwc2_gadget
> driver when peripheral only mode is selected. The dwc_platform.ko and dwc2.ko
> will get built when dynamic linked modules are selected for Host
On 03/14/2014 07:51 PM, dingu...@altera.com wrote:
> From: Dinh Nguyen
>
> In preparation of combining the dwc2/s3c-hsotg driver in a single DRD driver,
> the defines in dwc2/hw.h needs to get updated so that the s3c-hsotg driver can
> use them.
>
> Signed-off-by: Dinh Nguyen
> Tested-by: Jingo
On Sun, 16 Mar 2014, vichy wrote:
> hi all:
> recently we bump to system performance issue when usb irq take quite long.
> I found below link for discussing how to short
>
> http://permalink.gmane.org/gmane.linux.usb.general/89363
>
> I have some questions about this patch.
Instead of just post
On Mon, 17 Mar 2014, nb wrote:
> Hi,
>
> My external disk uses an external box with a Initio Corporation INIC-1618L
> SATA chip.
> vendor/product are : 0x13fd/0x0840
> bcdDevice is 1.14 making the disk work very slowly 12Mb in spite of 10 times
> faster.
> bcdUSB seem to be ok : 2.00
>
> Tried
Pasi Kärkkäinen writes:
> On Mon, Mar 17, 2014 at 02:15:23PM +0100, Bjørn Mork wrote:
>
>> I still don't know for sure, but I do hope this bug is the real cause of
>> the problems you are having. I'll send you a patch for testing as soon
>> as it is ready.
>>
>
> Sure. I'll be happy to test the
Le Lundi 17 Mars 2014 15:02 CET, Alan Stern a
écrit:
> On Mon, 17 Mar 2014, nb wrote:
>
> > Hi,
> >
> > My external disk uses an external box with a Initio Corporation INIC-1618L
> > SATA chip.
> > vendor/product are : 0x13fd/0x0840
> > bcdDevice is 1.14 making the disk work very slowly 12M
On Sun, 16 Mar 2014, Andreas Reis wrote:
> I finally managed to get an usbmon trace. It's available on the kernel
> bugzilla page.
>
> Andreas Reis
>
> On 19.02.2014 18:10, Alan Stern wrote:> On Wed, 19 Feb 2014, Andreas
> Reis wrote:
> >
> >> Hi,
> >>
> >> this is an updated copy of my re
I admite you, Bjorn: that's talent.
Let's see how it goes.
And congratulations to Pasik also.
On Mon, 17 Mar 2014, Bjørn Mork wrote:
==Date: Mon, 17 Mar 2014 15:23:22
==From: Bjørn Mork
==To: Pasi Kärkkäinen
==Cc: Thomas Schäfer , Dan Williams ,
==net...@vger.kernel.org, linux-usb@vger.k
On Fri, 14 Mar 2014, Dan Williams wrote:
> 8<---
> Subject: usb: block suspension of superspeed port while hispeed peer is active
>
> From: Dan Williams
>
> ClearPortFeature(PORT_POWER) on a usb3 port places the port in either a
> DSPORT.Powered-off-detect / DSPORT.Powered-off-reset loop, o
On Fri, 14 Mar 2014, Dan Williams wrote:
> On Fri, 2014-03-14 at 12:11 -0400, Alan Stern wrote:
> > On Thu, 13 Mar 2014, Dan Williams wrote:
> >
> > > Three reasons:
> > > 1/ It's an invalid operation on usb3 ports
> > > 2/ There's no guarantee of when / if a usb2 port has entered an error
> > >
On Mon, Mar 17, 2014 at 03:23:22PM +0100, Bjørn Mork wrote:
> Pasi Kärkkäinen writes:
> > On Mon, Mar 17, 2014 at 02:15:23PM +0100, Bjørn Mork wrote:
> >
> >> I still don't know for sure, but I do hope this bug is the real cause of
> >> the problems you are having. I'll send you a patch for testi
This is a context modified revert of commit 6a9612e2cb22
("net: cdc_ncm: remove ncm_parm field") which introduced
a NCM specification violation, causing setup errors for
some devices. These errors resulted in the device and
host disagreeing about shared settings, with complete
failure to communicat
Pasi Kärkkäinen writes:
> I applied the patch on top of Linux 3.13.6 kernel and now I'm able to use the
> wwan0 NCM interface successfully!
> I do get an IP with a dhcp client (this failed earlier without the patch),
> and Internet seems to work OK.
> So the patch definitely fixes the problem
[ Please, try to avoid top-posting. ]
On Thu, Mar 13, 2014 at 02:57:29PM -0700, Benjamin West wrote:
> Thanks Johan,
> Apologies for not including lsusb output before, I was having hardware
> issues. It's included below
> https://gist.github.com/bewest/6488955#file-lsusb
>
> I can take patches,
Add simple driver for Medtronic CareLink USB devices.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/Kconfig | 1 +
drivers/usb/serial/usb-serial-simple.c | 7 +++
2 files changed, 8 insertions(+)
diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
index 3ce
On Mon, Mar 17, 2014 at 2:42 AM, Bjørn Mork wrote:
> Is this *really* driver material, or should we just leave the IP MTU
> hint handling up to the userspace management application?
>
> There are no less than 3(!) different ways for a device to specify the
> MBIM MTU:
>
> 1) wMaxSegmentSize field
Just tried it, ehci_usb is used.
lsmod|egrep '(hci|usb)'
usb_storage43324 1
btusb 21248 0
bluetooth 209064 22 bnep,btusb,rfcomm
usbhid 39650 0
hid76882 2 hid_generic,usbhid
firewire_ohci 34856 0
sdhci
On Mon, 17 Mar 2014, nb wrote:
> Just tried it, ehci_usb is used.
>
>
> lsmod|egrep '(hci|usb)'
>
> usb_storage43324 1
> btusb 21248 0
> bluetooth 209064 22 bnep,btusb,rfcomm
> usbhid 39650 0
> hid76882 2 hid_gene
On Thu, 13 Mar 2014, Alan Stern wrote:
> Ah, now I understand. We are talking about mode-switching devices that
> revert to their default mode following a reset, as opposed to losing
> their firmware contents (although the mode switch may involve a change
> to the descriptors too). This sort of
Ben Chan writes:
> It's a bit messy how MTU is currently handled in MBIM. While wMTU may
> seem optional and redundant, it addresses some issues with
> wMaxSegmentSize and MBIM_CID_IP_CONFIGURATION, and hence why I suggest
> using wMTU when available:
>
> (1) wMaxSegmentSize
>
> The MBIM 1.0 erra
Hi Oliver,
Any update on the state of this patch? Did it get picked up for merge
somewhere? Do you agree with my suggestion of sticking closer to the
original logic instead of adding that autopm_get(), or do you maybe
want to add some more reviewers to confirm your code? I don't really
care that m
On Mon, 2014-03-17 at 17:12 -0400, Alan Stern wrote:
> On Thu, 13 Mar 2014, Alan Stern wrote:
> > This reasoning suggests that when QUIRK_RESET is present, we should
> > always skip reset-resume and go directly to logical disconnect.
>
> So Oliver, what do you think about this patch?
Looks perfe
On Mon, 2014-03-17 at 14:53 -0700, Julius Werner wrote:
> Hi Oliver,
>
> Any update on the state of this patch? Did it get picked up for merge
> somewhere? Do you agree with my suggestion of sticking closer to the
> original logic instead of adding that autopm_get(), or do you maybe
> want to add
On Mon, Mar 17, 2014 at 2:55 PM, Oliver Neukum wrote:
> On Mon, 2014-03-17 at 14:53 -0700, Julius Werner wrote:
>> Hi Oliver,
>>
>> Any update on the state of this patch? Did it get picked up for merge
>> somewhere? Do you agree with my suggestion of sticking closer to the
>> original logic instea
This patchset resolves most of checkpatch.pl issues in
wlags49_h2/wl_netdev.c
Jelena Bjelja (16):
staging: wlags49_h2: Use tabs for indentation
staging: wlags49_h2: Delete space after open parenthesis
staging: wlags49_h2 : Delete space before close parenthesis
staging: wlags49_h2: Add spac
This patch fixes the following checkpatch.pl issues in wl_netdev.c:
ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 628
1 file changed, 314 insertions(+), 314 deletions(-)
diff -
This patch fixes the following checkpatch.pl issues in wl_netdev.c:
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 628
1 file changed, 314 insertions(+), 314 deletions(-)
diff
This patch fixes the following checkpatch.pl issues in wl_netdev.c:
ERROR: space required before the open parenthesis '('
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 170
1 file changed, 85 insertions(+), 85 deletions(-)
diff --git
This patch fixes the following checkpatch.pl issues in wl_netdev.c:
ERROR: do not use C99 // comments
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 150
1 file changed, 75 insertions(+), 75 deletions(-)
diff --git a/drivers/staging/w
This patch fixes the following checkpatch.pl issues in wl_netdev.c:
ERROR: Macros with multiple statements should be enclosed in a do -
while loop
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
This patch fixes the following checkpatch.pl issue in wl_netdev.c:
ERROR: do not use assignment in if condition
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
This patch fixes the following checkpatch.pl issue in wl_netdev.c:
WARNING: space prohibited between function name and open parenthesis
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/w
This patch fixes the following checkpatch.pl issues in wl_netdev.c:
WARNING: suspect code indent for conditional statements
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 56
1 file changed, 28 insertions(+), 28 deletions(-)
diff --g
This patch fixes the following checkpatch.pl issues in wl_netdev.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers
This patch fixes the following checkpatch.pl issue in wl_netdev.c:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
b/driv
This patch adjusts multi-line comments to “net/” kernel coding style in
wl_netdev.c, since the driver depends on WLAN.
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 351 ++--
1 file changed, 203 insertions(+), 148 deletions(-)
diff --git
This patch fixes the following checkpatch.pl issues in wl_netdev.c:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 35
1 file changed, 9 insertions(+), 26 deletions(-)
This patch fixes the following checkpatch.pl issues in wl_netdev.c:
ERROR: else should follow close brace '}'
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_netd
This patch fixes the following checkpatch.pl issue in wl_netdev.c:
ERROR: spaces required around that '='
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
b/driv
This patch fixes some lines that exceed 80 characters in wl_netdev.c
WARNING: line over 80 characters
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 62 +++-
1 file changed, 38 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/
On Mon, Mar 17, 2014 at 04:04:04PM -0700, Greg KH wrote:
> On Mon, Mar 10, 2014 at 09:33:37AM +0100, Robert Baldyga wrote:
> > This patch adds missing spin_unlock and mutex_unlock calls in
> > error handling code.
> >
> > Signed-off-by: Robert Baldyga
> > Acked-by: Michal Nazarewicz
> > Acked-by
On Mon, Mar 10, 2014 at 09:33:37AM +0100, Robert Baldyga wrote:
> This patch adds missing spin_unlock and mutex_unlock calls in
> error handling code.
>
> Signed-off-by: Robert Baldyga
> Acked-by: Michal Nazarewicz
> Acked-by: Felipe Balbi
> ---
> drivers/usb/gadget/f_fs.c |8 ++--
> 1
On Sat, Mar 15, 2014 at 11:49:09PM -0700, Ben Chan wrote:
> This patch adds the MBIM extended functional descriptor structure
> defined in "Universal Serial Bus Communications Class Subclass
> Specification for Mobile Broadband Interface Model, Revision 1.0,
> Errata-1" published by USB-IF.
>
> Si
On Mon, 17 Mar 2014, Fernando Luis Vázquez Cao wrote:
> > I have slightly modified the patch title to make sure that it's obvious
> > that what it fixes is actually a WARN_ON() splat.
>
> Thank you.
>
> Any chance we can get this to Linus before 3.14 comes out?
> According to Linus, rc7 may be t
According to "Universal Serial Bus Communications Class Subclass
Specification for Mobile Broadband Interface Model, Revision 1.0,
Errata-1" published by USB-IF, the wMTU field of the MBIM extended
functional descriptor indicates the operator preferred MTU for IP data
streams.
This patch modifies
Hi all,
Given that 3.14 will be out in a few days, it's time to close my trees
for new patches until 3.15-rc1 is out.
Please feel free to send me patches for these trees, but note that I'll
be ignoring them until 3.15-rc1 is out, at which point in time I'll
start reviewing them again and applying
On Mon, Mar 17, 2014 at 2:27 PM, Bjørn Mork wrote:
>
> This sounds all reasonable to me. Thanks for taking the time to explain
> it in such detail. I did know that some vendors set wMaxSegmentSize too
> low, but had no idea that vendors were using the extended descriptor
> instead of MBIM_CID_IP_
[9732.160783] usb-storage 2-1:1.0: Abort srbs: 8804255c1980
8804255c1980
[9732.160791] usb-storage 2-1:1.0: Calling stop_transport
[9732.160836] usb-storage 2-1:1.0: Starting port reset
[9732.267771] usb 2-1: reset SuperSpeed USB device number 4 using xhci_hcd
[9732.281100] xhci_hcd :
(2014年03月18日 08:42), Jiri Kosina wrote:
On Mon, 17 Mar 2014, Fernando Luis Vázquez Cao wrote:
I have slightly modified the patch title to make sure that it's obvious
that what it fixes is actually a WARN_ON() splat.
Thank you.
Any chance we can get this to Linus before 3.14 comes out?
Accordi
From: Ben Chan
Date: Mon, 17 Mar 2014 17:46:27 -0700
> Thanks again for the review and tip. I've submitted patch v2 to
> address the le16_to_cpu conversion.
When you update a patch from a series, you should repost the entire
patch set, rather than just the patch which changes.
This avoids any a
On Mon, 17 Mar 2014, Jelena Bjelja wrote:
> This patch fixes the following checkpatch.pl issue in wl_netdev.c:
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Jelena Bjelja
> ---
> drivers/staging/wlags49_h2/wl_netdev.c |4 +++-
> 1 file changed, 3 insertions(+), 1 deleti
On Fri, Mar 14, 2014 at 03:13:19PM +0800, Li Jun wrote:
> From: Li Jun
>
> Use a more general way to read and write otgsc register.
>
> Signed-off-by: Li Jun
> ---
>
> Changes for v3:
> Remove special revert write for bits in OTGSC_INT_STATUS_BITS, and
> rename 2 API function names and paramet
On Mon, Mar 17, 2014 at 01:43:05PM +0800, Li Jun wrote:
> On Wed, Mar 12, 2014 at 04:21:28PM +0800, Peter Chen wrote:
> > On Wed, Mar 12, 2014 at 03:12:48PM +0800, Li Jun wrote:
> > > On Wed, Mar 12, 2014 at 03:01:15PM +0800, Peter Chen wrote:
> > > > On Thu, Feb 27, 2014 at 07:38:23AM +0800, Li Ju
This patch adds the MBIM extended functional descriptor structure
defined in "Universal Serial Bus Communications Class Subclass
Specification for Mobile Broadband Interface Model, Revision 1.0,
Errata-1" published by USB-IF.
Signed-off-by: Ben Chan
---
No changes from patch v1.
include/uapi/li
According to "Universal Serial Bus Communications Class Subclass
Specification for Mobile Broadband Interface Model, Revision 1.0,
Errata-1" published by USB-IF, the wMTU field of the MBIM extended
functional descriptor indicates the operator preferred MTU for IP data
streams.
This patch modifies
On Mon, Mar 17, 2014 at 6:41 PM, David Miller wrote:
> From: Ben Chan
> Date: Mon, 17 Mar 2014 17:46:27 -0700
>
>> Thanks again for the review and tip. I've submitted patch v2 to
>> address the le16_to_cpu conversion.
>
> When you update a patch from a series, you should repost the entire
> patch
From: Li Jun
Use a more general way to read and write otgsc register.
Signed-off-by: Li Jun
---
drivers/usb/chipidea/core.c | 16 ++--
drivers/usb/chipidea/otg.c | 33 -
drivers/usb/chipidea/otg.h | 18 ++
drivers/usb/chipidea
This patch moves usb interrupt enable and status register read functions
from udc driver to core driver to use them in all ci drivers.
Acked-by: Peter Chen
Signed-off-by: Li Jun
---
drivers/usb/chipidea/ci.h |4
drivers/usb/chipidea/core.c | 20
drivers/usb/chi
From: Li Jun
This patchset has some improvements for interfaces of read and write some
controller registers.
Change for v4:
Use one write for BSV irq status clear and enable in udc_id_switch_for_device().
Changes for v3:
Remove special revert write for bits in OTGSC_INT_STATUS_BITS, and
rename
This patch adds below registers dump for debug:
- USBINTR
- USBSTS
- USBMODE
- USBCMD
- PORTSC
- OTGSC
Acked-by: Peter Chen
Signed-off-by: Li Jun
---
drivers/usb/chipidea/debug.c | 51 ++
1 file changed, 51 insertions(+)
diff --git a/drivers/usb/chipid
On Sat, Dec 28, 2013 at 01:20:26AM +0800, Felipe Balbi wrote:
> Hi,
>
> On Fri, Dec 27, 2013 at 04:11:21PM +0800, Peter Chen wrote:
> > > > > > > > Add clock enable/disable at .set_suspend if the PHY has
> > > > > > > > suspend requirement, it can be benefit of power saving for
> > > > > > > > phy
On Mon, Mar 17, 2014 at 11:40 AM, Johan Hovold wrote:
>> issues. It's included below
>> https://gist.github.com/bewest/6488955#file-lsusb
> I'm responding to this mail with a patch for you to test. The patch is
> also available here:
>
>
> https://git.kernel.org/cgit/linux/kernel/git/jo
74 matches
Mail list logo
