[PATCH 6/6] USB: gadget: mv_udc: fix corner case for missiong dTD

2014-02-24 Thread Neil Zhang
When the missing dTD issue is triggerred, queue_dtd may prime the new request instead of the missing dTD. We can just add the request to the queue end and jump out if there are more than one request in the queue already. Signed-off-by: Neil Zhang --- drivers/usb/gadget/mv_udc_core.c | 12 +

[PATCH 3/6] usb: gadget: mv_udc: clear corresponding interrupt when flush fifo

2014-02-24 Thread Neil Zhang
The interruts are useless when this endpoint is going to be flushed. Especially in the enumeration phase, let's take get device description for example. 1. Device doesn't ACK the status package from host in time due to irq is disabled by some module. 2. Host find no ACK in time, and send another re

[PATCH 1/6] usb: gadget: mv_udc: remove redundant pull up in udc_start

2014-02-24 Thread Neil Zhang
Romove redundant pull up in udc_start since function udc_bind_to_driver in udc-core.c will do it for us. Signed-off-by: Neil Zhang --- drivers/usb/gadget/mv_udc_core.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c ind

[PATCH 4/6] usb: gadget: mv_udc: check endpoint before queue dtd

2014-02-24 Thread Neil Zhang
There is a corner case that endpoint is disabled by system shutdown between check ep->desc and hold spin lock in mv_ep_queue. In this case ep->ep.desc will be NULL and occur kernel panic when access it in build_dtd. Signed-off-by: Neil Zhang --- drivers/usb/gadget/mv_udc_core.c |8

[PATCH 5/6] USB: gadget: mv_udc: workaroud for missing dTD

2014-02-24 Thread Neil Zhang
There is an issue with the add dTD tripwire semaphore (ATDTW bit in USBCMD register) that can cause the controller to ignore a dTD that is added to a primed endpoint. When this happens, the software can read the tripwire bit and the status bit at '1' even though the endpoint is unprimed. After exe

[PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Neil Zhang
Hardware zlt will try to send the zero length packet automatically when the data transferd is multiple times of max packet, this will cause issues on Windows. So let's disable HW zlt by default. Signed-off-by: Neil Zhang --- drivers/usb/gadget/mv_udc_core.c |2 +- 1 file changed, 1 insertion

[PATCH 0/6] bug fix for mv_udc_core.c

2014-02-24 Thread Neil Zhang
This patch set is mainly for bug fix. Neil Zhang (6): usb: gadget: mv_udc: remove redundant pull up in udc_start usb: gadget: mv_udc: disable HW zlt for ep0 usb: gadget: mv_udc: clear corresponding interrupt when flush fifo usb: gadget: mv_udc: check endpoint before queue dtd USB: gadget

RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-24 Thread Peter Chen
> +CI13xxx (Chipidea) USB controllers > + > +Required properties: > +- compatible: should contain "qcom,ci-hdrc" > +- reg: offset and length of the register set in the memory map > +- interrupts: interrupt-specifier for the controller interrupt. > +- usb-phy: phandle for the PHY

Re: [PATCH] usb: chipidea: imx: Use dev_name() for ci_hdrc name to distinguish USBs

2014-02-24 Thread Peter Chen
On Mon, Feb 24, 2014 at 11:49:40AM +0800, Peter Chen wrote: > On Mon, Feb 24, 2014 at 08:32:14AM +0400, Alexander Shiyan wrote: > > Понедельник, 24 февраля 2014, 10:02 +08:00 от Peter Chen > > : > > > On Sat, Feb 22, 2014 at 05:17:58PM +0400, Alexander Shiyan wrote: > > > > Signed-off-by: Alexande

Re: usbserial_generic, idVendor=1a28, idProduct=6010

2014-02-24 Thread Johan Hovold
On Mon, Feb 24, 2014 at 01:46:59AM +0100, Emanuel Koczwara wrote: > Hi, > > W dniu 23.02.2014 21:21, Johan Hovold pisze: > > You might need to mount debugfs: mount -t debugfs none > > /sys/kernel/debug and make sure your kernel is compiled with > > CONFIG_DYNAMIC_DEBUG (and CONFIG_DEBUG_FS) enab

Re: usbserial_generic, idVendor=1a28, idProduct=6010

2014-02-24 Thread Emanuel Koczwara
Hi, W dniu 24.02.2014 09:30, Johan Hovold pisze: > On Mon, Feb 24, 2014 at 01:46:59AM +0100, Emanuel Koczwara wrote: >> Hi, >> >> W dniu 23.02.2014 21:21, Johan Hovold pisze: >>> You might need to mount debugfs: mount -t debugfs none >>> /sys/kernel/debug and make sure your kernel is compiled wit

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Kishon Vijay Abraham I
Hi Roger, On Friday 21 February 2014 05:59 PM, Roger Quadros wrote: > On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: >> Hi Roger, >> >> On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: >>> Hi, >>> >>> On 02/12/2014 11:46 AM, Kishon Vijay Abraham I wrote: On Wednesday 29 Jan

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Kishon Vijay Abraham I
On Friday 21 February 2014 05:59 PM, Roger Quadros wrote: > On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: >> Hi Roger, >> >> On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: >>> Hi, >>> >>> On 02/12/2014 11:46 AM, Kishon Vijay Abraham I wrote: On Wednesday 29 January 2014 0

RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-24 Thread Ivan T. Ivanov
On Mon, 2014-02-24 at 08:15 +, Peter Chen wrote: > > +CI13xxx (Chipidea) USB controllers > > + > > +Required properties: > > +- compatible: should contain "qcom,ci-hdrc" > > +- reg: offset and length of the register set in the memory map > > +- interrupts: interrupt-specifier for

Re: SPDX-License-Identifier

2014-02-24 Thread Michal Simek
On 02/21/2014 08:01 PM, Theodore Ts'o wrote: > On Fri, Feb 21, 2014 at 09:57:20AM -0800, Greg Kroah-Hartman wrote: >>> But shouldn't we at least write somewhere >>> that it has connection to spdx.org where you can find out that licenses. >> >> Why? Are these licenses so unknown that no one knows w

Re: [PATCH v5 14/16] usb: documentation for usb port power off mechanisms

2014-02-24 Thread Oliver Neukum
On Fri, 2014-02-21 at 16:10 -0800, Dan Williams wrote: > From: Lan Tianyu > > describe the mechanisms for controlling port power policy and > discovering the port power state. > > Cc: Oliver Neukum > Signed-off-by: Lan Tianyu > [sarah]: wordsmithing > [djbw]: updates for peer port changes > Si

RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

2014-02-24 Thread Peter Chen
> > On Mon, 2014-02-24 at 08:15 +, Peter Chen wrote: > > > +CI13xxx (Chipidea) USB controllers > > > + > > > +Required properties: > > > +- compatible: should contain "qcom,ci-hdrc" > > > +- reg: offset and length of the register set in the memory > map > > > +- interrupts: inte

[Patch V1 0/2] usb: g_zero: Add support for interrupt EP

2014-02-24 Thread Amit Virdi
This patchset adds support for interrupt EP and the corresponding test cases to gadget zero. The code has been rebased and tested on Kernel v3.14-rc3 RFC -> V1 - Added support for configuring interrupt EP attributes from configfs interface Amit Virdi (2): usb: gadget: zero: Add support for int

[Patch V1 1/2] usb: gadget: zero: Add support for interrupt EP

2014-02-24 Thread Amit Virdi
Interrupt endpoints behave quite similar to the bulk endpoints with the difference that the endpoints expect data sending/reception request at particular intervals till the whole data has not been transmitted. The interrupt EP support is added to gadget zero. A new alternate setting (=2) has been

[Patch V1 2/2] usbtest: Add interrupt EP testcases

2014-02-24 Thread Amit Virdi
Two simple test cases for interrupt endpoints are added to the usbtest.c file. These are simple non-queued interrupt IN and interrupt OUT transfers. Currently, only gadget zero is capable of executing the interrupt EP test cases. However, extending the same to other gadgets is extremely simple and

Re: usbserial_generic, idVendor=1a28, idProduct=6010

2014-02-24 Thread Johan Hovold
On Mon, Feb 24, 2014 at 10:28:05AM +0100, Emanuel Koczwara wrote: > Hi, > > W dniu 24.02.2014 09:30, Johan Hovold pisze: > > On Mon, Feb 24, 2014 at 01:46:59AM +0100, Emanuel Koczwara wrote: > >> Hi, > >> > >> W dniu 23.02.2014 21:21, Johan Hovold pisze: > >>> You might need to mount debugfs:

RE: sisusb: Use static const, fix typo

2014-02-24 Thread David Laight
From: Joe Perches > Reduce text a bit by using static const. If you want to save a few bytes remove the pointers. (and the fixed RAM text to get below 7 chars). eg: > - const char *ramtypetext2[] = { "SDR SDRAM", "SDR SGRAM", > - "DDR SDRAM", "DDR SGRAM" }

Re: USB to Serial converter code pl2303

2014-02-24 Thread Johan Hovold
[ Please don't drop the lists from CC. ] On Mon, Feb 24, 2014 at 11:07:50AM +0100, Magnus wrote: > It doesnt work with my servo controller chip at 2400 Baud. > I get some reply back at 115200 Baud by using gtkterm > so it probably works at that speed but not lower speeds. > > I will get a null-mo

Re: [PATCH 0/6] bug fix for mv_udc_core.c

2014-02-24 Thread Matthieu CASTET
Le Mon, 24 Feb 2014 16:03:10 +0800, Neil Zhang a écrit : > This patch set is mainly for bug fix. > > Neil Zhang (6): > usb: gadget: mv_udc: remove redundant pull up in udc_start > usb: gadget: mv_udc: disable HW zlt for ep0 > usb: gadget: mv_udc: clear corresponding interrupt when flush fi

Re: usbserial_generic, idVendor=1a28, idProduct=6010

2014-02-24 Thread Emanuel Koczwara
Hi, W dniu 24.02.2014 11:25, Johan Hovold pisze: > On Mon, Feb 24, 2014 at 10:28:05AM +0100, Emanuel Koczwara wrote: >> Hi, >> >> W dniu 24.02.2014 09:30, Johan Hovold pisze: >> > On Mon, Feb 24, 2014 at 01:46:59AM +0100, Emanuel Koczwara wrote: >> >> Hi, >> >> >> >> W dniu 23.02.2014 21:21,

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Roger Quadros
On 02/24/2014 11:51 AM, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Friday 21 February 2014 05:59 PM, Roger Quadros wrote: >> On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: >>> Hi Roger, >>> >>> On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: Hi, On 02/12/20

[PATCH 1/1] usb: chipidea: udc: refine isr_tr_complete_handler

2014-02-24 Thread Peter Chen
Matthieu CASTET and Michael Grzeschik mentioned isr_tr_complete_handler is a bit messy at below: http://marc.info/?l=linux-usb&m=139047775001152&w=2 This commit creates a new function isr_setup_packet_handler to handle setup packet, it makes isr_tr_complete_handler easy to read. This is no functi

Re: is it possible to temporarily not let user mode get hid input event

2014-02-24 Thread loody
hi David: 2014-02-23 23:16 GMT+08:00 David Herrmann : > Hi > > On Sun, Feb 23, 2014 at 7:52 AM, loody wrote: >> hi David: >> >> Thanks for your suggestion. >> 2014-02-23 0:56 GMT+08:00 David Herrmann : >>> Hi >>> >>> On Sat, Feb 22, 2014 at 5:35 PM, loody wrote: hi all: is there any ke

Re: is it possible to temporarily not let user mode get hid input event

2014-02-24 Thread David Herrmann
Hi On Mon, Feb 24, 2014 at 12:20 PM, loody wrote: > hi David: > > 2014-02-23 23:16 GMT+08:00 David Herrmann : >> Hi >> >> On Sun, Feb 23, 2014 at 7:52 AM, loody wrote: >>> hi David: >>> >>> Thanks for your suggestion. >>> 2014-02-23 0:56 GMT+08:00 David Herrmann : Hi On Sat, Feb 2

Re: is it possible to temporarily not let user mode get hid input event

2014-02-24 Thread loody
hi David: 2014-02-24 19:35 GMT+08:00 David Herrmann : > Hi > > On Mon, Feb 24, 2014 at 12:20 PM, loody wrote: >> hi David: >> >> 2014-02-23 23:16 GMT+08:00 David Herrmann : >>> Hi >>> >>> On Sun, Feb 23, 2014 at 7:52 AM, loody wrote: hi David: Thanks for your suggestion. 201

Re: is it possible to temporarily not let user mode get hid input event

2014-02-24 Thread David Herrmann
Hi On Mon, Feb 24, 2014 at 1:34 PM, loody wrote: >> Yes. For instance, you can run ./samples/uhid/uhid-example.c via ssh >> to emulate a mouse. ssh keyboard input can then be used to generate >> mouse-movement events. > There is one embarrassing question :-) > Would you please let me know how to

RE: [PATCH 0/6] bug fix for mv_udc_core.c

2014-02-24 Thread Neil Zhang
> -Original Message- > From: Matthieu CASTET [mailto:matthieu.cas...@parrot.com] > Sent: 2014年2月24日 18:32 > To: Neil Zhang > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH 0/6] bug fix for mv_udc_core.c > > Le

Kernel OOPS with g_ffs module loaded

2014-02-24 Thread Marco Zamponi
I get a kernel panic with a null pointer dereference. Both on Kernel 3.6.9 and 3.0.35 Unable to handle kernel NULL pointer dereference at virtual address pgd = 80004000 [] *pgd= Internal error: Oops: 817 [#1] PREEMPT SMP Modules linked in: g_ffs CPU: 0Not tainted (3.0

Re: SPDX-License-Identifier

2014-02-24 Thread Theodore Ts'o
On Mon, Feb 24, 2014 at 11:12:53AM +0100, Michal Simek wrote: > > But of course, I'm not a lawyer, and if your company has is paying for > > the development of the driver, the Golden Rule applies (he who has the > > Gold, makes the Rules), and each of our respective corporate lawyers > > may have d

Re: SPDX-License-Identifier

2014-02-24 Thread Michal Simek
On 02/24/2014 02:41 PM, Theodore Ts'o wrote: > On Mon, Feb 24, 2014 at 11:12:53AM +0100, Michal Simek wrote: >>> But of course, I'm not a lawyer, and if your company has is paying for >>> the development of the driver, the Golden Rule applies (he who has the >>> Gold, makes the Rules), and each of

Re: Kernel OOPS with g_ffs module loaded

2014-02-24 Thread Fabio Estevam
On Mon, Feb 24, 2014 at 10:05 AM, Marco Zamponi wrote: > I get a kernel panic with a null pointer dereference. > Both on Kernel 3.6.9 and 3.0.35 > 1e00: ba8e0200 80771e18 805a3b40 7f000b9c 6193 > [<8009a850>] (__dabt_svc+0x70/0xa0) from [<7f000b9c>] > (ffs_func_set_alt+0xd4/0x1a

Re: SPDX-License-Identifier

2014-02-24 Thread Greg Kroah-Hartman
On Mon, Feb 24, 2014 at 03:03:25PM +0100, Michal Simek wrote: > > BTW: Isn't this a good topic for kernel-summit? :-) No, lawyers don't go to the summit, developers do. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Kishon Vijay Abraham I
Hi, On Monday 24 February 2014 04:35 PM, Roger Quadros wrote: > On 02/24/2014 11:51 AM, Kishon Vijay Abraham I wrote: >> Hi Roger, >> >> On Friday 21 February 2014 05:59 PM, Roger Quadros wrote: >>> On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: Hi Roger, On Wednesday 19 Febr

Re: [PATCH v2] u_ether: move hardware transmit to RX workqueue

2014-02-24 Thread Manu Gautam
On 2/22/2014 11:11 AM, Clanlab (Taiwan) Linux Project wrote: > In order to reduce the interrupt times in the embedded system, > a receiving workqueue is introduced. > This modification also enhanced the overall throughput as the > benefits of reducing interrupt occurrence. This patch looks to be

Re: [PATCH v2] storage: accept some UAS devices if streams are unavailable

2014-02-24 Thread Oliver Neukum
On Fri, 2014-02-21 at 15:00 -0800, Sarah Sharp wrote: > On Tue, Feb 11, 2014 at 08:36:04PM +0100, oli...@neukum.org wrote: > > From: Oliver Neukum > > > > On some older XHCIs streams are not supported and the UAS driver > > will fail at probe time. For those devices storage should try > > to bind

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Felipe Balbi
On Mon, Feb 24, 2014 at 03:21:05PM +0530, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Friday 21 February 2014 05:59 PM, Roger Quadros wrote: > > On 02/21/2014 02:25 PM, Kishon Vijay Abraham I wrote: > >> Hi Roger, > >> > >> On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: > >>> Hi

Re: [Patch V1 0/2] usb: g_zero: Add support for interrupt EP

2014-02-24 Thread Felipe Balbi
Hi, On Mon, Feb 24, 2014 at 03:55:09PM +0530, Amit Virdi wrote: > This patchset adds support for interrupt EP and the corresponding test cases > to > gadget zero. The code has been rebased and tested on Kernel v3.14-rc3 > > RFC -> V1 > - Added support for configuring interrupt EP attributes fro

Re: [RFC PATCH] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-24 Thread Mathias Nyman
On 02/23/2014 12:51 AM, Alan Stern wrote: Right, but I assume you'd want to hold the reference until after the hub is registered, otherwise there's still a chance we suspend right before register. So I'm saying hold the reference until the registration process takes its own. To be really saf

[RFC PATCH v2] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-24 Thread Mathias Nyman
xHCI driver has its own pci probe function that will call usb_hcd_pci_probe to register its usb-2 bus, and then continue to manually register the usb-3 bus. usb_hcd_pci_probe does a pm_runtime_put_noidle at the end and might thus trigger a runtime suspend before the usb-3 bus is ready. Prevent the

Re: [RFC PATCH] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-24 Thread Dan Williams
On Mon, Feb 24, 2014 at 8:22 AM, Mathias Nyman wrote: > On 02/23/2014 12:51 AM, Alan Stern wrote: > > > Right, but I assume you'd want to hold the reference until after the > hub is registered, otherwise there's still a chance we suspend right > before register. So I'm saying hold

Re: [RFC PATCH v2] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-24 Thread Dan Williams
On Mon, Feb 24, 2014 at 8:29 AM, Mathias Nyman wrote: > xHCI driver has its own pci probe function that will call usb_hcd_pci_probe > to register its usb-2 bus, and then continue to manually register the > usb-3 bus. usb_hcd_pci_probe does a pm_runtime_put_noidle at the end and > might thus trigge

Re: [PATCH v5 14/16] usb: documentation for usb port power off mechanisms

2014-02-24 Thread Dan Williams
On Mon, Feb 24, 2014 at 2:17 AM, Oliver Neukum wrote: > On Fri, 2014-02-21 at 16:10 -0800, Dan Williams wrote: >> From: Lan Tianyu >> >> describe the mechanisms for controlling port power policy and >> discovering the port power state. >> >> Cc: Oliver Neukum >> Signed-off-by: Lan Tianyu >> [sa

[PATCH 0/3] introduce assign_if() macros in attempt to reduce ifdeffery

2014-02-24 Thread Josh Cartwright
Based on the observation that given the following: static void my_callback(void) { } void (*callback)(void) = 0 ? my_callback : NULL; GCC will, 1.) Not emit 'defined but unused' warnings for 'my_callback' 2.) Typecheck my_callback against typeof(*c

[PATCH 3/3] usb: phy: msm: use ASSIGN_*_PM_OPS variants

2014-02-24 Thread Josh Cartwright
Use ASSIGN_SYSTEM_SLEEP_PM_OPS and ASSIGN_RUNTIME_PM_OPS in the initializer for msm_otg_dev_pm_ops. Doing so allows us to eliminate preprocessor conditionals around the specified callbacks. Signed-off-by: Josh Cartwright --- drivers/usb/phy/phy-msm-usb.c | 13 +++-- 1 file changed, 3 in

Re: [PATCH v11 09/15] usb: phy: Add set_wakeup API

2014-02-24 Thread Sergei Shtylyov
Hello. On 02/24/2014 05:21 AM, Peter Chen wrote: This API is used to set wakeup enable at PHY registers, in that case, the PHY can be waken up from suspend due to external events, like vbus change, dp/dm change and id change. Signed-off-by: Peter Chen --- include/linux/usb/phy.h | 16 ++

Re: [RFC PATCH v2] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-24 Thread Alan Stern
On Mon, 24 Feb 2014, Mathias Nyman wrote: > xHCI driver has its own pci probe function that will call usb_hcd_pci_probe > to register its usb-2 bus, and then continue to manually register the > usb-3 bus. usb_hcd_pci_probe does a pm_runtime_put_noidle at the end and > might thus trigger a runtime

Re: [RFC PATCH] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-24 Thread Alan Stern
On Mon, 24 Feb 2014, Dan Williams wrote: > > Thanks Dan and Alan for the input, I did the following changes: > > > > - Take and release the reference in xhci_pci_probe to avoid releasing the > > reference for a moment just before usb3 roothub registration. > > - Make sure we release the reference

Re: sisusb: Use static const, fix typo

2014-02-24 Thread Joe Perches
On Mon, 2014-02-24 at 10:26 +, David Laight wrote: > From: Joe Perches > > Reduce text a bit by using static const. > > If you want to save a few bytes remove the pointers. > (and the fixed RAM text to get below 7 chars). Hi David. > eg: > > > - const char *ramtypetext2[] = { "SDR SDRAM"

Re: [PATCH v5 14/16] usb: documentation for usb port power off mechanisms

2014-02-24 Thread Oliver Neukum
On Mon, 2014-02-24 at 08:55 -0800, Dan Williams wrote: > On Mon, Feb 24, 2014 at 2:17 AM, Oliver Neukum wrote: > > On Fri, 2014-02-21 at 16:10 -0800, Dan Williams wrote: > >> From: Lan Tianyu > >> +* wakeup note: the implementation does not allow a port connected to a > >> + device with wakeup

Re: [PATCH v5 14/16] usb: documentation for usb port power off mechanisms

2014-02-24 Thread Dan Williams
On Mon, Feb 24, 2014 at 9:58 AM, Oliver Neukum wrote: > On Mon, 2014-02-24 at 08:55 -0800, Dan Williams wrote: >> On Mon, Feb 24, 2014 at 2:17 AM, Oliver Neukum wrote: >> > On Fri, 2014-02-21 at 16:10 -0800, Dan Williams wrote: >> >> From: Lan Tianyu > >> >> +* wakeup note: the implementation do

Re: [PATCH v5 14/16] usb: documentation for usb port power off mechanisms

2014-02-24 Thread Dan Williams
On Mon, 2014-02-24 at 18:58 +0100, Oliver Neukum wrote: > On Mon, 2014-02-24 at 08:55 -0800, Dan Williams wrote: > > On Mon, Feb 24, 2014 at 2:17 AM, Oliver Neukum wrote: > > > On Fri, 2014-02-21 at 16:10 -0800, Dan Williams wrote: > > >> From: Lan Tianyu > > > >> +* wakeup note: the implementat

Re: [PATCH v5 14/16] usb: documentation for usb port power off mechanisms

2014-02-24 Thread Alan Stern
On Mon, 24 Feb 2014, Dan Williams wrote: > 8<--- > Subject: usb: documentation for usb port power off mechanisms > > From: Lan Tianyu > > describe the mechanisms for controlling port power policy and > discovering the port power state. > > Cc: Oliver Neukum > [oliver]: fixes, clarificatio

[PATCH] xhci: 'noxhci_port_switch' kernel parameter

2014-02-24 Thread Dan Williams
Add a command line switch for disabling ehci port switchover. Useful for working around / debugging xhci incompatibilities where ehci operation is available. Reference: http://marc.info/?l=linux-usb&m=138920063001509&w=2 Cc: Sarah Sharp Cc: Mathias Nyman Cc: Holger Hans Peter Freyther Suggest

[PATCH] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

2014-02-24 Thread Dan Williams
Save someone else the debug cycles of figuring out why a driver's transfer request is failing or causing undefined system behavior. Buffers submitted for dma must come from GFP allocated / DMA-able memory. Return -EAGAIN matching the return value for dma_mapping_error() cases. Cc: Alan Stern Cc:

Re: [PATCH v5 14/16] usb: documentation for usb port power off mechanisms

2014-02-24 Thread Dan Williams
On Mon, 2014-02-24 at 14:11 -0500, Alan Stern wrote: > On Mon, 24 Feb 2014, Dan Williams wrote: > > > 8<--- > > Subject: usb: documentation for usb port power off mechanisms > > > > From: Lan Tianyu > > > > describe the mechanisms for controlling port power policy and > > discovering the po

Re: [PATCH] xhci: 'noxhci_port_switch' kernel parameter

2014-02-24 Thread Greg KH
On Mon, Feb 24, 2014 at 11:37:35AM -0800, Dan Williams wrote: > Add a command line switch for disabling ehci port switchover. Useful > for working around / debugging xhci incompatibilities where ehci > operation is available. > > Reference: http://marc.info/?l=linux-usb&m=138920063001509&w=2 Wha

Re: [PATCH] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

2014-02-24 Thread Alan Stern
On Mon, 24 Feb 2014, Dan Williams wrote: > Save someone else the debug cycles of figuring out why a driver's > transfer request is failing or causing undefined system behavior. > Buffers submitted for dma must come from GFP allocated / DMA-able > memory. > > Return -EAGAIN matching the return val

[PATCH] gadgetfs: Initialize CHIP to NULL before UDC probe

2014-02-24 Thread Lubomir Rintel
Otherwise the value from the last probe would be retained that possibly is freed since (the UDC is removed) and therefore no longer relevant. Reproducible with the dummy UDC: modprobe dummy_hcd mount -t gadgetfs gadgetfs /dev/gadget umount /dev/gadget rmmod dummy_hcd mount -t gadgetfs ga

Re: [PATCH] xhci: 'noxhci_port_switch' kernel parameter

2014-02-24 Thread Dan Williams
On Mon, Feb 24, 2014 at 12:37 PM, Greg KH wrote: > On Mon, Feb 24, 2014 at 11:37:35AM -0800, Dan Williams wrote: >> Add a command line switch for disabling ehci port switchover. Useful >> for working around / debugging xhci incompatibilities where ehci >> operation is available. >> >> Reference:

Re: [PATCH] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

2014-02-24 Thread Dan Williams
On Mon, 2014-02-24 at 15:44 -0500, Alan Stern wrote: > On Mon, 24 Feb 2014, Dan Williams wrote: > > > Save someone else the debug cycles of figuring out why a driver's > > transfer request is failing or causing undefined system behavior. > > Buffers submitted for dma must come from GFP allocated /

Re: [PATCH v5 13/16] usb: force warm reset to break link re-connect livelock

2014-02-24 Thread Julius Werner
Acked-by: Julius Werner -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-24 Thread Alan Stern
On Fri, 21 Feb 2014, Dan Williams wrote: > Assume that the peer of a superspeed port is the port with the same id > on the shared_hcd root hub. This identification scheme is required of > external hubs by the USB3 spec [1]. However, for root hubs, tier mismatch > may be in effect [2]. Tier mism

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-24 Thread Dan Williams
On Mon, Feb 24, 2014 at 1:46 PM, Alan Stern wrote: > On Fri, 21 Feb 2014, Dan Williams wrote: > >> Assume that the peer of a superspeed port is the port with the same id >> on the shared_hcd root hub. This identification scheme is required of >> external hubs by the USB3 spec [1]. However, for r

Re: [PATCH] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

2014-02-24 Thread Alan Stern
On Mon, 24 Feb 2014, Dan Williams wrote: > > > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > > > index 2518c3250750..ff7cd489f55d 100644 > > > --- a/drivers/usb/core/hcd.c > > > +++ b/drivers/usb/core/hcd.c > > > @@ -1502,6 +1502,9 @@ int usb_hcd_map_urb_for_dma(struct usb_hcd *hc

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-24 Thread Alan Stern
On Mon, 24 Feb 2014, Dan Williams wrote: > > Also, the gyrations you have to go through here and elsewhere to print > > useful names indicate that we should set up better names for the port > > devices. How about: > > > > dev_set_name(&port_dev->dev, "%s-port%d", dev_name(&hub->hdev->dev)

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-24 Thread Dan Williams
On Mon, Feb 24, 2014 at 2:12 PM, Alan Stern wrote: > On Mon, 24 Feb 2014, Dan Williams wrote: > >> > Also, the gyrations you have to go through here and elsewhere to print >> > useful names indicate that we should set up better names for the port >> > devices. How about: >> > >> > dev_set

[PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-24 Thread Keith Packard
The Lenovo OneLink dock includes a USB ethernet adapter using the AX88179 chip, but with a different USB ID. Add this new USB id to the driver so that it will autodetect the adapter correctly. Signed-off-by: Keith Packard Tested-by: Carl Worth --- drivers/net/usb/ax88179_178a.c | 17 +++

Re: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-24 Thread Kyle McMartin
On Mon, Feb 24, 2014 at 03:13:49PM -0800, Keith Packard wrote: > +static const struct driver_info lenovo_info = { > +}, { > + /* Lenovo ThinkPad OneLink GigaLAN */ > + USB_DEVICE(0x17ef, 0x304b), > + .driver_info = (unsigned long)&samsung_info, &lenovo_info, surely. --Kyle -- To unsu

[PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-24 Thread Keith Packard
The Lenovo OneLink dock includes a USB ethernet adapter using the AX88179 chip, but with a different USB ID. Add this new USB id to the driver so that it will autodetect the adapter correctly. Signed-off-by: Keith Packard Tested-by: Carl Worth --- Kyle McMartin says: > &lenovo_info, surely.

RE: [PATCH v11 09/15] usb: phy: Add set_wakeup API

2014-02-24 Thread Peter Chen
> On 02/24/2014 05:21 AM, Peter Chen wrote: > > > This API is used to set wakeup enable at PHY registers, in that case, > > the PHY can be waken up from suspend due to external events, like vbus > > change, dp/dm change and id change. > > > Signed-off-by: Peter Chen > > --- > > include/linu

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Peter Chen
On Mon, Feb 24, 2014 at 04:03:12PM +0800, Neil Zhang wrote: > Hardware zlt will try to send the zero length packet automatically > when the data transferd is multiple times of max packet, this will > cause issues on Windows. > So let's disable HW zlt by default. Would you have description that wha

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-24 Thread Dan Williams
On Mon, 2014-02-24 at 16:46 -0500, Alan Stern wrote: > On Fri, 21 Feb 2014, Dan Williams wrote: > > > Assume that the peer of a superspeed port is the port with the same id > > on the shared_hcd root hub. This identification scheme is required of > > external hubs by the USB3 spec [1]. However,

Re: [PATCH 3/6] usb: gadget: mv_udc: clear corresponding interrupt when flush fifo

2014-02-24 Thread Peter Chen
On Mon, Feb 24, 2014 at 04:03:13PM +0800, Neil Zhang wrote: > The interruts are useless when this endpoint is going to be flushed. > Especially in the enumeration phase, let's take get device description > for example. > 1. Device doesn't ACK the status package from host in time due to irq is > dis

Re: [PATCH v5 05/16] usb: sysfs link peer ports

2014-02-24 Thread Dan Williams
On Fri, 2014-02-21 at 16:09 -0800, Dan Williams wrote: > The usb topology after this change will have symlinks between usb3 ports > and their usb2 peers, for example: > > usb2/2-1/2-1:1.0/port1/peer => ../../../../usb3/3-1/3-1:1.0/port1 > usb2/2-1/2-1:1.0/port2/peer => ../../../../usb3/3-1/3-1:1.0

Re: [PATCH v5 06/16] usb: defer suspension of superspeed port while peer is powered

2014-02-24 Thread Dan Williams
On Fri, 2014-02-21 at 16:09 -0800, Dan Williams wrote: > ClearPortFeature(PORT_POWER) on a usb3 port places the port in either a > DSPORT.Powered-off-detect / DSPORT.Powered-off-reset loop, or the > DSPORT.Powered-off state. There is no way to ensure that RX > terminations will persist in this sta

Re: [PATCH v5 11/16] usb: introduce port status lock

2014-02-24 Thread Dan Williams
On Fri, 2014-02-21 at 16:10 -0800, Dan Williams wrote: > In general we do not want khubd to act on port status changes that are > the result of in progress resets or USB runtime PM operations. > Specifically port power control testing has been able to trigger an > unintended disconnect in hub_port_

Re: [PATCH v5 06/16] usb: defer suspension of superspeed port while peer is powered

2014-02-24 Thread Dan Williams
On Mon, 2014-02-24 at 19:01 -0800, Dan Williams wrote: > As mentioned in the comments on patch 2, while ->peer is being modified > we don't want usb_port_runtime_{suspend|resume} to run. Introduce > pre_modify_peers() and post_modify_peers() to close that hole. ...thinking about it further, when

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Neil Zhang
> -Original Message- > From: Peter Chen [mailto:peter.c...@freescale.com] > Sent: 2014年2月25日 9:19 > To: Neil Zhang > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for

Re: [PATCH v5 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode

2014-02-24 Thread Manu Gautam
On 12/24/2013 3:00 PM, Manu Gautam wrote: > Allow userspace to pass SuperSpeed descriptors and > handle them in the driver accordingly. > This change doesn't modify existing desc_header and thereby > keeps the ABI changes backward compatible i.e. existing > userspace drivers compiled with old heade

Re: [PATCH 0/6] bug fix for mv_udc_core.c

2014-02-24 Thread Peter Chen
On Mon, Feb 24, 2014 at 04:42:40AM -0800, Neil Zhang wrote: > > > -Original Message- > > From: Matthieu CASTET [mailto:matthieu.cas...@parrot.com] > > Sent: 2014年2月24日 18:32 > > To: Neil Zhang > > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > > linux-ker...@vge

Re: [PATCH 5/6] USB: gadget: mv_udc: workaroud for missing dTD

2014-02-24 Thread Peter Chen
On Mon, Feb 24, 2014 at 04:03:15PM +0800, Neil Zhang wrote: > There is an issue with the add dTD tripwire semaphore (ATDTW bit in > USBCMD register) that can cause the controller to ignore a dTD that is > added to a primed endpoint. When this happens, the software can read > the tripwire bit and th

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Peter Chen
> > On Mon, Feb 24, 2014 at 04:03:12PM +0800, Neil Zhang wrote: > > > Hardware zlt will try to send the zero length packet automatically > > > when the data transferd is multiple times of max packet, this will > > > cause issues on Windows. > > > So let's disable HW zlt by default. > > > > Woul

Re: [Patch V1 2/2] usbtest: Add interrupt EP testcases

2014-02-24 Thread Amit Virdi
ccing: Felipe Balbi, Alan Stern On 2/24/2014 3:55 PM, Amit VIRDI wrote: Two simple test cases for interrupt endpoints are added to the usbtest.c file. These are simple non-queued interrupt IN and interrupt OUT transfers. Currently, only gadget zero is capable of executing the interrupt EP test c

Re: [Patch V1 1/2] usb: gadget: zero: Add support for interrupt EP

2014-02-24 Thread Amit Virdi
ccing: Felipe Balbi, Alen Stern On 2/24/2014 3:55 PM, Amit VIRDI wrote: Interrupt endpoints behave quite similar to the bulk endpoints with the difference that the endpoints expect data sending/reception request at particular intervals till the whole data has not been transmitted. The interrupt

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Neil Zhang
> -Original Message- > From: Peter Chen [mailto:peter.c...@freescale.com] > Sent: 2014年2月25日 13:15 > To: Neil Zhang > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for e

RE: [PATCH 5/6] USB: gadget: mv_udc: workaroud for missing dTD

2014-02-24 Thread Neil Zhang
> -Original Message- > From: Peter Chen [mailto:peter.c...@freescale.com] > Sent: 2014年2月25日 12:19 > To: Neil Zhang > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH 5/6] USB: gadget: mv_udc: workaroud for missi

RE: [PATCH 0/6] bug fix for mv_udc_core.c

2014-02-24 Thread Neil Zhang
> -Original Message- > From: Peter Chen [mailto:peter.c...@freescale.com] > Sent: 2014年2月25日 12:18 > To: Neil Zhang > Cc: Matthieu CASTET; ba...@ti.com; gre...@linuxfoundation.org; > linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH 0/6] bug fix for mv_udc_core.

RE: [PATCH 5/6] USB: gadget: mv_udc: workaroud for missing dTD

2014-02-24 Thread Peter Chen
> > From: Peter Chen [mailto:peter.c...@freescale.com] > > Sent: 2014年2月25日 12:19 > > To: Neil Zhang > > Cc: ba...@ti.com; gre...@linuxfoundation.org; > > linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org > > Subject: Re: [PATCH 5/6] USB: gadget: mv_udc: workaroud for missing > > dTD > >

RE: [PATCH 3/6] usb: gadget: mv_udc: clear corresponding interrupt when flush fifo

2014-02-24 Thread Neil Zhang
> -Original Message- > From: Peter Chen [mailto:peter.c...@freescale.com] > Sent: 2014年2月25日 9:59 > To: Neil Zhang > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH 3/6] usb: gadget: mv_udc: clear corresponding

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Peter Chen
> > > > > > > > > > > > On Mon, Feb 24, 2014 at 04:03:12PM +0800, Neil Zhang wrote: > > > > > Hardware zlt will try to send the zero length packet > > > > > automatically when the data transferd is multiple times of max > > > > > packet, this will cause issues on Windows. > > > > > So let's dis